Re: [PATCH] target/mips: Handle lock_user() failure in UHI_plog semihosting call

2022-08-08 Thread Philippe Mathieu-Daudé via
On Tue, Jul 19, 2022 at 9:17 PM Peter Maydell wrote: > > Coverity notes that we forgot to check the error return from > lock_user() in one place in the handling of the UHI_plog semihosting > call. Add the missing error handling. > > report_fault() is rather brutal in that it will call abort(), bu

Re: [PATCH] target/mips: Handle lock_user() failure in UHI_plog semihosting call

2022-07-23 Thread Richard Henderson
On 7/20/22 00:47, Peter Maydell wrote: Coverity notes that we forgot to check the error return from lock_user() in one place in the handling of the UHI_plog semihosting call. Add the missing error handling. report_fault() is rather brutal in that it will call abort(), but this is the same error

[PATCH] target/mips: Handle lock_user() failure in UHI_plog semihosting call

2022-07-19 Thread Peter Maydell
Coverity notes that we forgot to check the error return from lock_user() in one place in the handling of the UHI_plog semihosting call. Add the missing error handling. report_fault() is rather brutal in that it will call abort(), but this is the same error-handling used in the rest of this file.