On Tue, Jul 19, 2022 at 9:17 PM Peter Maydell <[email protected]> wrote: > > Coverity notes that we forgot to check the error return from > lock_user() in one place in the handling of the UHI_plog semihosting > call. Add the missing error handling. > > report_fault() is rather brutal in that it will call abort(), but > this is the same error-handling used in the rest of this file. > > Resolves: Coverity CID 1490684 > Fixes: ea4210600db3c5 ("target/mips: Avoid qemu_semihosting_log_out for > UHI_plog") > Signed-off-by: Peter Maydell <[email protected]> > --- > NB: only tested with 'make check' and 'make check-tcg', which > almost certainly don't actually exercise this codepath. > --- > target/mips/tcg/sysemu/mips-semi.c | 3 +++ > 1 file changed, 3 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Queued to mips-fixes, thanks!
