Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-04 Thread Markus Armbruster
Bruce Rogers writes: > On Fri, 2020-09-04 at 11:20 +0200, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >> > On 04/09/20 09:24, Markus Armbruster wrote: >> > > > Ah, via the tools variable in configure. Nice maze. I've >> > > > queued the patch. >> > > Please don't. >> > > >> > > Thes

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-04 Thread Bruce Rogers
On Fri, 2020-09-04 at 11:20 +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 04/09/20 09:24, Markus Armbruster wrote: > > > > Ah, via the tools variable in configure. Nice maze. I've > > > > queued the patch. > > > Please don't. > > > > > > These programs are examples to help p

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-04 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 11:37:58AM +0200, Philippe Mathieu-Daudé wrote: > On 9/4/20 9:24 AM, Markus Armbruster wrote: > > Paolo Bonzini writes: > > > >> On 03/09/20 17:49, Daniel P. Berrangé wrote: > >>> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: > On 03/09/20 17:35, Bruc

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-04 Thread Philippe Mathieu-Daudé
On 9/4/20 9:24 AM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 03/09/20 17:49, Daniel P. Berrangé wrote: >>> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: On 03/09/20 17:35, Bruce Rogers wrote: > Turn on the meson install flag for these executables > >>>

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-04 Thread Markus Armbruster
Paolo Bonzini writes: > On 04/09/20 09:24, Markus Armbruster wrote: >>> Ah, via the tools variable in configure. Nice maze. I've queued the patch. >> Please don't. >> >> These programs are examples to help people understand how the ivhsmem >> device works. They might even be useful for debugg

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-04 Thread Paolo Bonzini
On 04/09/20 09:24, Markus Armbruster wrote: >> Ah, via the tools variable in configure. Nice maze. I've queued the patch. > Please don't. > > These programs are examples to help people understand how the ivhsmem > device works. They might even be useful for debugging. They are *not* > to be us

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-04 Thread Markus Armbruster
Paolo Bonzini writes: > On 03/09/20 17:49, Daniel P. Berrangé wrote: >> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: >>> On 03/09/20 17:35, Bruce Rogers wrote: Turn on the meson install flag for these executables Signed-off-by: Bruce Rogers --- contrib

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-03 Thread Paolo Bonzini
On 03/09/20 17:49, Daniel P. Berrangé wrote: > On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: >> On 03/09/20 17:35, Bruce Rogers wrote: >>> Turn on the meson install flag for these executables >>> >>> Signed-off-by: Bruce Rogers >>> --- >>> contrib/ivshmem-client/meson.build | 2 +

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-03 Thread Bruce Rogers
On Thu, 2020-09-03 at 16:49 +0100, Daniel P. Berrangé wrote: > On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: > > On 03/09/20 17:35, Bruce Rogers wrote: > > > Turn on the meson install flag for these executables > > > > > > Signed-off-by: Bruce Rogers > > > --- > > > contrib/ivsh

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-03 Thread Daniel P . Berrangé
On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: > On 03/09/20 17:35, Bruce Rogers wrote: > > Turn on the meson install flag for these executables > > > > Signed-off-by: Bruce Rogers > > --- > > contrib/ivshmem-client/meson.build | 2 +- > > contrib/ivshmem-server/meson.build | 2 +

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-03 Thread Paolo Bonzini
On 03/09/20 17:35, Bruce Rogers wrote: > Turn on the meson install flag for these executables > > Signed-off-by: Bruce Rogers > --- > contrib/ivshmem-client/meson.build | 2 +- > contrib/ivshmem-server/meson.build | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/contr

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-03 Thread Marc-André Lureau
Hi On Thu, Sep 3, 2020 at 7:35 PM Bruce Rogers wrote: > > Turn on the meson install flag for these executables > > Signed-off-by: Bruce Rogers I am not sure we want to install binaries that don't even have maintainers (or am I wrong?). > --- > contrib/ivshmem-client/meson.build | 2 +- > cont

[PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-03 Thread Bruce Rogers
Turn on the meson install flag for these executables Signed-off-by: Bruce Rogers --- contrib/ivshmem-client/meson.build | 2 +- contrib/ivshmem-server/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/m