On 03/09/20 17:49, Daniel P. Berrangé wrote: > On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: >> On 03/09/20 17:35, Bruce Rogers wrote: >>> Turn on the meson install flag for these executables >>> >>> Signed-off-by: Bruce Rogers <[email protected]> >>> --- >>> contrib/ivshmem-client/meson.build | 2 +- >>> contrib/ivshmem-server/meson.build | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/contrib/ivshmem-client/meson.build >>> b/contrib/ivshmem-client/meson.build >>> index 1b171efb4f..83a559117f 100644 >>> --- a/contrib/ivshmem-client/meson.build >>> +++ b/contrib/ivshmem-client/meson.build >>> @@ -1,4 +1,4 @@ >>> executable('ivshmem-client', files('ivshmem-client.c', 'main.c'), >>> dependencies: glib, >>> build_by_default: targetos == 'linux', >>> - install: false) >>> + install: true) >>> diff --git a/contrib/ivshmem-server/meson.build >>> b/contrib/ivshmem-server/meson.build >>> index 3a53942201..a1c39aa3b3 100644 >>> --- a/contrib/ivshmem-server/meson.build >>> +++ b/contrib/ivshmem-server/meson.build >>> @@ -1,4 +1,4 @@ >>> executable('ivshmem-server', files('ivshmem-server.c', 'main.c'), >>> dependencies: [qemuutil, rt], >>> build_by_default: targetos == 'linux', >>> - install: false) >>> + install: true) >>> >> >> They weren't installed before the conversion, were they? > > Unfortunately they were historically installed with --enable-tools. > > IMHO nothing in contrib/ should be installed by default. If we consider > something maintained and high enough quality for end users, it should > migrate out of contrib/ into tools/.
Ah, via the tools variable in configure. Nice maze. I've queued the patch. Paolo > vhost-user-gpu and elf2dmp are also both in contrib/ but installed > by default :-( > > > Regards, > Daniel >
