Re: [PATCH] hw/display/framebuffer: Add cast to force 64x64 multiply

2025-07-21 Thread Manos Pitsidianakis
On Mon, Jul 21, 2025 at 4:58 PM Peter Maydell wrote: > > Ping -- any opinions/review about this one? > > -- PMM > > On Thu, 10 Jul 2025 at 18:43, Peter Maydell wrote: > > > > In framebuffer_update_display(), Coverity complains because we > > multiply two values of type 'int' (which will be done a

Re: [PATCH] hw/display/framebuffer: Add cast to force 64x64 multiply

2025-07-21 Thread Peter Maydell
Ping -- any opinions/review about this one? -- PMM On Thu, 10 Jul 2025 at 18:43, Peter Maydell wrote: > > In framebuffer_update_display(), Coverity complains because we > multiply two values of type 'int' (which will be done as a 32x32 > multiply and so in theory might overflow) and then add the

[PATCH] hw/display/framebuffer: Add cast to force 64x64 multiply

2025-07-10 Thread Peter Maydell
In framebuffer_update_display(), Coverity complains because we multiply two values of type 'int' (which will be done as a 32x32 multiply and so in theory might overflow) and then add the result to a ram_addr_t, which can be 64 bits. 4GB framebuffers are not plausible anyway, but keep Coverity happ