Re: [PATCH] hw/arm/virt.c: Remove newline from error_report() string

2024-01-18 Thread Philippe Mathieu-Daudé
On 18/1/24 17:09, Peter Maydell wrote: On Thu, 18 Jan 2024 at 15:30, Philippe Mathieu-Daudé wrote: On 18/1/24 16:17, Philippe Mathieu-Daudé wrote: On 18/1/24 14:16, Peter Maydell wrote: error_report() strings should not include trailing newlines; remove the newline from the error we print wh

Re: [PATCH] hw/arm/virt.c: Remove newline from error_report() string

2024-01-18 Thread Peter Maydell
On Thu, 18 Jan 2024 at 15:30, Philippe Mathieu-Daudé wrote: > > On 18/1/24 16:17, Philippe Mathieu-Daudé wrote: > > On 18/1/24 14:16, Peter Maydell wrote: > >> error_report() strings should not include trailing newlines; remove > >> the newline from the error we print when devices won't fit into t

Re: [PATCH] hw/arm/virt.c: Remove newline from error_report() string

2024-01-18 Thread Philippe Mathieu-Daudé
On 18/1/24 16:17, Philippe Mathieu-Daudé wrote: On 18/1/24 14:16, Peter Maydell wrote: error_report() strings should not include trailing newlines; remove the newline from the error we print when devices won't fit into the address space of the CPU. This commit also fixes the accidental hardcode

Re: [PATCH] hw/arm/virt.c: Remove newline from error_report() string

2024-01-18 Thread Philippe Mathieu-Daudé
On 18/1/24 14:16, Peter Maydell wrote: error_report() strings should not include trailing newlines; remove the newline from the error we print when devices won't fit into the address space of the CPU. This commit also fixes the accidental hardcoded tabs that were in this line, since we have to t

[PATCH] hw/arm/virt.c: Remove newline from error_report() string

2024-01-18 Thread Peter Maydell
error_report() strings should not include trailing newlines; remove the newline from the error we print when devices won't fit into the address space of the CPU. This commit also fixes the accidental hardcoded tabs that were in this line, since we have to touch the line anyway. Signed-off-by: Pet