On Thu, 18 Jan 2024 at 15:30, Philippe Mathieu-Daudé <[email protected]> wrote: > > On 18/1/24 16:17, Philippe Mathieu-Daudé wrote: > > On 18/1/24 14:16, Peter Maydell wrote: > >> error_report() strings should not include trailing newlines; remove > >> the newline from the error we print when devices won't fit into the > >> address space of the CPU. > >> > >> This commit also fixes the accidental hardcoded tabs that were in > >> this line, since we have to touch the line anyway. > >> > >> Signed-off-by: Peter Maydell <[email protected]> > >> --- > >> hw/arm/virt.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Philippe Mathieu-Daudé <[email protected]> > > BTW there is another case: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h \ > --sp-file scripts/coccinelle/err-bad-newline.cocci \ > --keep-comments --use-gitgrep --dir . > ./hw/arm/virt.c:1775:38:"Addressing limited to %d bits, but memory > exceeds it by %llu bytes\n" > ./ui/gtk.c:1094:56:"gtk: unexpected touch event type\n" > > We could run this some of these coccinelle scripts on CI, > as a new job in .gitlab-ci.d/static_checks.yml or extending > the check-patch job...
checkpatch catches it, if you read the output, which is how I noticed this in the first place (I was originally touching the line to fix the tab damage). -- PMM
