Re: [PATCH v6 00/36] ACPI PCI Hotplug support on ARM

2025-07-11 Thread Igor Mammedov
g it to make it usable on ARM. The DSDT table is > augmented to support ACPI PCI hotplug elements. > > On ARM we use use a GED event to notify the OS about > hotplug events. Reviewed-by: Igor Mammedov > > Best Regards > > Eric > > This series can be found at:

Re: [PATCH v6 34/36] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test

2025-07-11 Thread Igor Mammedov
On Tue, 8 Jul 2025 16:23:16 +0200 Eric Auger wrote: > From: Gustavo Romero > > Add 2 new tests: > - test_acpi_aarch64_virt_acpi_pci_hotplug tests the acpi pci hotplug > using -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > - test_acpi_aarch64_virt_pcie_root_port_hpoff tests static

Re: [PATCH v6 21/36] hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index

2025-07-11 Thread Igor Mammedov
On Tue, 8 Jul 2025 16:23:03 +0200 Eric Auger wrote: > hw/arm/virt-acpi-build: Let non hotplug ports support static acpi-index > > Add the requested ACPI bits requested to support static acpi-index > for non hotplug ports. > > Signed-off-by: Eric Auger > Reviewed-by: Jonathan Cameron > --- >

Re: [PATCH v6 18/36] qtest/bios-tables-test: Add a variant to the aarch64 viot test

2025-07-11 Thread Igor Mammedov
On Tue, 8 Jul 2025 16:23:00 +0200 Eric Auger wrote: > Signed-off-by: Eric Auger > Reviewed-by: Jonathan Cameron I'd merge this with previous patch > --- > tests/qtest/bios-tables-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/b

Re: [PATCH] i386/cpu: ARCH_CAPABILITIES should not be advertised on AMD

2025-07-02 Thread Igor Mammedov
On Tue, 1 Jul 2025 16:01:21 -0400 Konrad Rzeszutek Wilk wrote: > On Tue, Jul 01, 2025 at 03:05:00PM +0200, Igor Mammedov wrote: > > On Tue, 1 Jul 2025 20:36:43 +0800 > > Zhao Liu wrote: > > > > > On Tue, Jul 01, 2025 at 07:12:44PM +0800, Xiaoyao Li wrote: &g

Re: [PATCH 1/3] memory: reintroduce BQL-free fine-grained PIO/MMIO

2025-07-01 Thread Igor Mammedov
On Mon, 30 Jun 2025 12:02:25 +0200 Gerd Hoffmann wrote: > Hi, > > > As you've said in comment > > https://bugzilla.redhat.com/show_bug.cgi?id=1322713#c6 > > it's strange that patch causes issues at all, especially with > > '-smp 1' as in reproducer. > > > > Also repeated with -smp x>1, it sti

Re: [PATCH] i386/cpu: ARCH_CAPABILITIES should not be advertised on AMD

2025-07-01 Thread Igor Mammedov
On Tue, 1 Jul 2025 20:36:43 +0800 Zhao Liu wrote: > On Tue, Jul 01, 2025 at 07:12:44PM +0800, Xiaoyao Li wrote: > > Date: Tue, 1 Jul 2025 19:12:44 +0800 > > From: Xiaoyao Li > > Subject: Re: [PATCH] i386/cpu: ARCH_CAPABILITIES should not be advertised > > on AMD > > > > On 7/1/2025 6:26 PM, Zh

Re: [PATCH 1/3] memory: reintroduce BQL-free fine-grained PIO/MMIO

2025-06-27 Thread Igor Mammedov
On Tue, 24 Jun 2025 12:45:27 +0200 Igor Mammedov wrote: > On Tue, 24 Jun 2025 09:07:11 +0200 > Gerd Hoffmann wrote: > > > Hi, > > > > > Gerd mentioned this in the relevant bz: > > > > > > Note: root cause for the i

Re: [PATCH v4 04/19] target/i386/cpu: Remove X86CPU::check_cpuid field

2025-06-27 Thread Igor Mammedov
On Thu, 5 Jun 2025 10:24:34 +0100 Daniel P. Berrangé wrote: > On Tue, Jun 03, 2025 at 05:02:38PM +0200, Igor Mammedov wrote: > > On Wed, 28 May 2025 13:23:49 +0800 > > Zhao Liu wrote: > > > > > On Wed, May 28, 2025 at 10:09:56AM +0800, Xiaoyao Li wrote: > &

Re: [PATCH 3/3] mark HPET as unlocked

2025-06-25 Thread Igor Mammedov
On Fri, 20 Jun 2025 18:01:08 +0100 Peter Maydell wrote: > On Fri, 20 Jun 2025 at 16:15, Igor Mammedov wrote: > > > > Reading QEMU_CLOCK_VIRTUAL is thread-safe. > > > > with CLI > > -M q35,hpet=on -cpu host -enable-kvm -smp 240,sockets=4 > > patch makes W

Re: [PATCH 1/3] memory: reintroduce BQL-free fine-grained PIO/MMIO

2025-06-24 Thread Igor Mammedov
On Tue, 24 Jun 2025 09:07:11 +0200 Gerd Hoffmann wrote: > Hi, > > > Gerd mentioned this in the relevant bz: > > > > Note: root cause for the initrd issue noted in comment 5 is seabios > > running into problems with ehci -> io errors -> corrupted initrd. > > Sometimes i

Re: [PATCH 1/3] memory: reintroduce BQL-free fine-grained PIO/MMIO

2025-06-24 Thread Igor Mammedov
On Mon, 23 Jun 2025 09:36:05 -0400 Peter Xu wrote: > On Mon, Jun 23, 2025 at 02:51:46PM +0200, Igor Mammedov wrote: > > On Fri, 20 Jun 2025 12:53:06 -0400 > > Peter Xu wrote: > > > > > On Fri, Jun 20, 2025 at 05:14:16PM +0200, Igor Mammedov wrote: > > &

Re: [PATCH 1/3] memory: reintroduce BQL-free fine-grained PIO/MMIO

2025-06-23 Thread Igor Mammedov
On Fri, 20 Jun 2025 12:53:06 -0400 Peter Xu wrote: > On Fri, Jun 20, 2025 at 05:14:16PM +0200, Igor Mammedov wrote: > > This patch brings back Jan's idea [1] of BQL-free IO access, > > with a twist that whitelist read access only. > > > > (as BQL-free write acces

[PATCH 0/3] Reinvent BQL-free PIO/MMIO

2025-06-20 Thread Igor Mammedov
property to memory regions) ... de7ea885c539 (kvm: Switch to unlocked MMIO) 3) https://bugzilla.redhat.com/show_bug.cgi?id=1322713 1beb99f787 (Revert "acpi: mark PMTIMER as unlocked") Igor Mammedov (3): memory: reintroduce BQL-free fine-grained PIO/MMIO acpi: mark PMTIMER as unlock

Re: [PATCH v3 09/29] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-06-20 Thread Igor Mammedov
CDW3 = CTRL /* \_SB_.PCI0.CTRL */ > -Return (Arg3) > +CDW3 = Local0 > } > Else > { > CDW1 |= 0x04 > - Return (Arg3) >

Re: [PATCH v3 06/29] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-06-20 Thread Igor Mammedov
top helper that generates > both the _OSC and _DSM methods. I'd get rid of wrapper, but it's not something that worth to fight over, so Reviewed-by: Igor Mammedov > > We take the opportunity to move SUPP and CTRL in the _osc method > that use them. > >

Re: [PATCH v3 08/29] hw/i386/acpi-build: Turn build_q35_osc_method into a generic method

2025-06-20 Thread Igor Mammedov
use this later in place of acpi_dsdt_add_pci_osc(). > > Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov > > --- > > v2 -> v3: > - move to hw/acpi/pci.c instead of aml-build.c (Igor) > --- > include/hw/acpi/pci.h | 2 ++ > hw/acpi/pci.c | 50

[PATCH 1/3] memory: reintroduce BQL-free fine-grained PIO/MMIO

2025-06-20 Thread Igor Mammedov
https://bugzilla.redhat.com/show_bug.cgi?id=1322713 1beb99f787 (Revert "acpi: mark PMTIMER as unlocked") Signed-off-by: Igor Mammedov --- include/system/memory.h | 10 +- hw/remote/vfio-user-obj.c | 2 +- system/memory.c | 5 + system/memory_l

[PATCH 3/3] mark HPET as unlocked

2025-06-20 Thread Igor Mammedov
Reading QEMU_CLOCK_VIRTUAL is thread-safe. with CLI -M q35,hpet=on -cpu host -enable-kvm -smp 240,sockets=4 patch makes WS2025 guest, that was able to boot in 4/2min, to boot in 2/1min. Signed-off-by: Igor Mammedov --- hw/timer/hpet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw

[PATCH 2/3] acpi: mark PMTIMER as unlocked

2025-06-20 Thread Igor Mammedov
Reading QEMU_CLOCK_VIRTUAL is thread-safe. with CLI -M q35,hpet=off -cpu host -enable-kvm -smp 240,sockets=4 patch makes WS2025 guest, that wasn't able to boot in 30min, to boot in 2-1min. Signed-off-by: Igor Mammedov --- hw/acpi/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v3 17/29] hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug

2025-06-20 Thread Igor Mammedov
On Fri, 20 Jun 2025 10:35:38 +0100 Jonathan Cameron wrote: > On Mon, 16 Jun 2025 11:46:46 +0200 > Eric Auger wrote: > > > Modify the DSDT ACPI table to enable ACPI PCI hotplug. > > > > Signed-off-by: Eric Auger > > > > --- > > v2 -> v3: > > - use ACPI_PCIHP_SIZE instead of 0x1000 (Igor) > >

Re: [PATCH v3 18/29] hw/acpi/ged: Add a bus link property

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:47 +0200 Eric Auger wrote: > This property will be set by the machine code on the object > creation. It will be used by acpi pcihp hotplug code. > > Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov also with that it's possible to end up

Re: [PATCH v3 26/29] hw/arm/virt: Plug pcihp hotplug/hotunplug callbacks

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:55 +0200 Eric Auger wrote: > Signed-off-by: Eric Auger why do we still need this? pcihp code should override native pcie bus handlers, and then when device_add calls bus hotplug handlers it will be pcihp ones. > --- > v2 -> v3: > - fix cohabitation with virtio-mem-pc

Re: [PATCH v3 27/29] tests/qtest/bios-tables-test: Prepare for addition of acpi pci hp tests

2025-06-20 Thread Igor Mammedov
oks good in the next patch fo > instance. With that fixed. > > Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov > > > --- > > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > > tests/data/acpi/aarch64/virt/DSDT.acpipcihp | 0 > > 2 files ch

Re: [PATCH v3 28/29] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test

2025-06-20 Thread Igor Mammedov
On Fri, 20 Jun 2025 11:40:29 +0100 Jonathan Cameron wrote: > On Mon, 16 Jun 2025 11:46:57 +0200 > Eric Auger wrote: > > > From: Gustavo Romero > > > > The test uses -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > > to force the usage of ACPI PCI hotplug. > > > > Signed-off-by: Gus

Re: [PATCH v3 28/29] tests/qtest/bios-tables-test: Add aarch64 ACPI PCI hotplug test

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:57 +0200 Eric Auger wrote: > From: Gustavo Romero > > The test uses -global acpi-ged.acpi-pci-hotplug-with-bridge-support=on > to force the usage of ACPI PCI hotplug. > > Signed-off-by: Gustavo Romero > Signed-off-by: Eric Auger > --- > tests/qtest/bios-tables-test

Re: [PATCH v3 25/29] hw/arm/virt: Let virt support pci hotplug/unplug GED event

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:54 +0200 Eric Auger wrote: > Set up the IO registers used to communicate between QEMU > and ACPI. > > Signed-off-by: Eric Auger > > --- > v2 -> v3: > - remove acpi_ged_state->pcihp_state.use_acpi_hotplug_bridge = true; > - use sysbus_mmio_map_name for all regs (Igor)

Re: [PATCH v3 20/29] hw/acpi/ged: Prepare the device to react to PCI hotplug events

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:49 +0200 Eric Auger wrote: [...] > @@ -433,6 +443,12 @@ static void acpi_ged_realize(DeviceState *dev, Error > **errp) > cpu_hotplug_hw_init(&s->container_cpuhp, OBJECT(dev), > &s->cpuhp_state, 0); > break; > +

Re: [PATCH v3 20/29] hw/acpi/ged: Prepare the device to react to PCI hotplug events

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:49 +0200 Eric Auger wrote: > QEMU will notify the OS about PCI hotplug/hotunplug events through > GED interrupts. Let the GED device handle a new PCI hotplug event. > On its occurrence it calls the \\_SB.PCI0.PCNT method with the BLCK > mutex held. > > The GED device us

Re: [PATCH v3 21/29] hw/acpi/ged: Call pcihp plug callbacks in hotplug handler implementation

2025-06-20 Thread Igor Mammedov
). > > Signed-off-by: Eric Auger I'd put that before 20/29 Reviewed-by: Igor Mammedov > --- > > v2 -> v3: > - remove else block in acpi_ged_device_pre_plug_cb > --- > hw/acpi/generic_event_device.c | 17 + > 1 file changed, 17 insertions(

Re: [PATCH v3 16/29] hw/i386/acpi-build: Move aml_pci_edsm to a generic place

2025-06-20 Thread Igor Mammedov
On Fri, 20 Jun 2025 10:19:36 +0100 Jonathan Cameron wrote: > On Mon, 16 Jun 2025 11:46:45 +0200 > Eric Auger wrote: > > > Move aml_pci_edsm to pci-bridge.c since we want to reuse that for > > ARM and acpi-index support. > > > > Signed-off-by: Eric Auger > > A request for a bit of documenta

Re: [PATCH v3 17/29] hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:46 +0200 Eric Auger wrote: > Modify the DSDT ACPI table to enable ACPI PCI hotplug. > > Signed-off-by: Eric Auger > > --- > v2 -> v3: > - use ACPI_PCIHP_SIZE instead of 0x1000 (Igor) > - use cihp_state->use_acpi_hotplug_bridge > --- > include/hw/acpi/pcihp.h | 2 ++

Re: [PATCH v3 15/29] hw/i386/acpi-build: Use AcpiPciHpState::root in acpi_set_pci_info

2025-06-20 Thread Igor Mammedov
; Signed-off-by: Eric Auger > Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov > > --- > > v2 -> v3: > - Use AcpiPciHpState::root > > v1 -> v2 > - described the fact we changed the implementation of > acpi_get_pci_host() in the commit msg. >

Re: [PATCH v3 07/29] hw/pci-host/gpex-acpi: retrieve and use GED acpi_pcihp setting

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:36 +0200 Eric Auger wrote: > retrieve the acpi_pcihp option value from the ged. In > case acpi_pcihp is unset we configure pci native hotplug on > pci0. For expander bridges we keep legacy pci native hotplug, I guess it's remnants of from previous version s/legacy// >

Re: [PATCH v3 05/29] tests/qtest/bios-tables-test: Prepare for changes in the DSDT table

2025-06-20 Thread Igor Mammedov
On Mon, 16 Jun 2025 11:46:34 +0200 Eric Auger wrote: > From: Gustavo Romero > > This commit adds DSDT blobs to the whilelist in the prospect to > allow changes in the GPEX _OSC method. > > Signed-off-by: Gustavo Romero > Signed-off-by: Eric Auger Acked-by: Igor Mammed

Re: [PATCH v3 02/29] hw/acpi/ged: Add a acpi-pci-hotplug-with-bridge-support property

2025-06-20 Thread Igor Mammedov
tter. I guess Eric can rearrange that if there would be need to respin. Reviewed-by: Igor Mammedov > > Reviewed-by: Jonathan Cameron > > > --- > > include/hw/acpi/generic_event_device.h | 2 ++ > > hw/acpi/generic_event_device.c | 2 ++ > > 2 files chan

Re: [PATCH v2 06/25] hw/pci-host/gpex-acpi: Propagate hotplug type info from virt machine downto gpex

2025-06-12 Thread Igor Mammedov
On Wed, 11 Jun 2025 11:00:02 +0200 Eric Auger wrote: > Hi Igor, > > On 5/27/25 2:33 PM, Igor Mammedov wrote: > > On Tue, 27 May 2025 09:40:08 +0200 > > Eric Auger wrote: > > > >> Propagate the type of pci hotplug mode downto the gpex > >> acpi

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-12 Thread Igor Mammedov
On Wed, 11 Jun 2025 10:56:36 +0200 Eric Auger wrote: > On 6/11/25 10:49 AM, Igor Mammedov wrote: > > On Wed, 11 Jun 2025 08:47:36 +0200 > > Eric Auger wrote: > > > >> Hi Igor, > >> > >> On 5/27/25 1:58 PM, Igor Mammedov wrote: > >>>

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-12 Thread Igor Mammedov
On Wed, 11 Jun 2025 10:50:04 +0200 Eric Auger wrote: > Hi Igor, > On 6/11/25 10:45 AM, Igor Mammedov wrote: > > On Wed, 11 Jun 2025 08:53:28 +0200 > > Eric Auger wrote: > > > >> Hi Gustavo, Alex, > >> > >> On 5/28/25 12:33 PM, Igor Mammedo

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-06-12 Thread Igor Mammedov
On Wed, 11 Jun 2025 10:14:55 -0300 Gustavo Romero wrote: > Hi Igor, > > On 6/11/25 05:54, Igor Mammedov wrote: > > On Tue, 10 Jun 2025 11:29:02 -0300 > > Gustavo Romero wrote: [...] > > > BTW, why did we ultimately choose to commit blobs instead of the actua

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-06-11 Thread Igor Mammedov
ind it either in qemu-devel@ or in qemu-arm@ :( > > > > On 5/30/25 08:51, Igor Mammedov wrote: > >> On Wed, 28 May 2025 12:04:26 -0300 > >> Gustavo Romero wrote: > >> > >>> Hi Igor, > >>> > >>> On 5/28/25 10:02, Igor Mammedov wrote

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-11 Thread Igor Mammedov
On Wed, 11 Jun 2025 08:47:36 +0200 Eric Auger wrote: > Hi Igor, > > On 5/27/25 1:58 PM, Igor Mammedov wrote: > > On Tue, 27 May 2025 09:40:04 +0200 > > Eric Auger wrote: > > > >> acpi_pcihp VirtMachineClass state flag will allow > >> to opt

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-11 Thread Igor Mammedov
On Wed, 11 Jun 2025 08:53:28 +0200 Eric Auger wrote: > Hi Gustavo, Alex, > > On 5/28/25 12:33 PM, Igor Mammedov wrote: > > On Tue, 27 May 2025 15:54:15 +0200 > > Eric Auger wrote: > > > >> Hi Igor, > >> > >> On 5/27/25 1:58 PM, Igor Mamm

Re: [PATCH v1] vhost: Fix used memslot tracking when destroying a vhost device

2025-06-11 Thread Igor Mammedov
-yuanm...@chinatelecom.cn/ > Fixes: 2ce68e4cf5be ("vhost: add vhost_has_free_slot() interface") > Cc: Igor Mammedov > Cc: Michael S. Tsirkin > Cc: Stefano Garzarella > Signed-off-by: David Hildenbrand Reviewed-by: Igor Mammedov > --- > > I assume the problem

Re: [PATCH 16/18] hw/net/virtio-net: Remove VirtIONet::mtu_bypass_backend field

2025-06-06 Thread Igor Mammedov
nd all the code around it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > include/hw/virtio/virtio-net.h | 1 - > hw/net/virtio-net.c| 8 ++-- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/include/hw/virtio/vi

Re: [PATCH 18/18] hw/i386/x86-iommu: Remove X86IOMMUState::pt_supported field

2025-06-06 Thread Igor Mammedov
On Thu, 1 May 2025 23:04:56 +0200 Philippe Mathieu-Daudé wrote: > The X86IOMMUState::pt_supported boolean was only set in > the hw_compat_2_9[] array, via the 'pt=off' property. We > removed all machines using that array, lets remove that > property and all the code around it, always setting the

Re: [PATCH 17/18] hw/pci-bridge/gen_pcie_rp: Remove GenPCIERootPort::migrate_msix field

2025-06-06 Thread Igor Mammedov
all the code around it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > hw/pci-bridge/gen_pcie_root_port.c | 16 ++-- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/hw/pci-bridge/gen_pcie_root_port.c >

Re: [PATCH 15/18] hw/core/machine: Remove hw_compat_2_9[] array

2025-06-06 Thread Igor Mammedov
On Thu, 1 May 2025 23:04:53 +0200 Philippe Mathieu-Daudé wrote: > The hw_compat_2_9[] array was only used by the pc-q35-2.9 and > pc-i440fx-2.9 machines, which got removed. Remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > inclu

Re: [PATCH 14/18] hw/i386/pc: Remove pc_compat_2_9[] array

2025-06-06 Thread Igor Mammedov
On Thu, 1 May 2025 23:04:52 +0200 Philippe Mathieu-Daudé wrote: > The pc_compat_2_9[] array was only used by the pc-q35-2.9 > and pc-i440fx-2.9 machines, which got removed. Remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > includ

Re: [PATCH 11/18] hw/nvram/fw_cfg: Remove FWCfgState::file_slots field

2025-06-06 Thread Igor Mammedov
On Thu, 1 May 2025 23:04:49 +0200 Philippe Mathieu-Daudé wrote: > The FWCfgState::file_slots integer was only set in the > hw_compat_2_8[] array, via the 'x-file-slots=0x10' property. > We removed all machines using that array, lets remove that > property and all the code around it. The number o

Re: [PATCH 13/18] hw/i386/pc: Remove deprecated pc-q35-2.9 and pc-i440fx-2.9 machines

2025-06-06 Thread Igor Mammedov
& removal") they can now be removed. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > hw/i386/pc_piix.c | 9 - > hw/i386/pc_q35.c | 9 - > 2 files changed, 18 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc

Re: [PATCH 12/18] hw/nvram/fw_cfg: Inline fw_cfg_file_slots()

2025-06-06 Thread Igor Mammedov
On Thu, 1 May 2025 23:04:50 +0200 Philippe Mathieu-Daudé wrote: > Now than fw_cfg_file_slots() only returns > FW_CFG_FILE_SLOTS_DFLT, we can inline it. > > Signed-off-by: Philippe Mathieu-Daudé does this even compile? I see more usages of fw_cfg_file_slots(), then being removed here. git gre

Re: [PATCH 10/18] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_INIT_PM definition

2025-06-06 Thread Igor Mammedov
AG_INIT_PM (see commit 9a4c0e220d8 for similar > VIRTIO_PCI_FLAG_* enum removal). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > include/hw/virtio/virtio-pci.h | 4 > hw/virtio/virtio-pci.c | 19 +-- > 2 files changed,

Re: [PATCH 09/18] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_INIT_LNKCTL definition

2025-06-06 Thread Igor Mammedov
_FLAG_INIT_LNKCTL (see commit 9a4c0e220d8 for similar > VIRTIO_PCI_FLAG_* enum removal). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > include/hw/virtio/virtio-pci.h | 4 > hw/virtio/virtio-pci.c | 8 ++-- > 2 files changed,

Re: [PATCH 08/18] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_INIT_DEVERR definition

2025-06-06 Thread Igor Mammedov
_FLAG_INIT_DEVERR (see commit 9a4c0e220d8 for similar > VIRTIO_PCI_FLAG_* enum removal). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > include/hw/virtio/virtio-pci.h | 4 > hw/virtio/virtio-pci.c | 8 ++-- > 2 files changed,

Re: [PATCH 07/18] hw/pci/pcie: Remove QEMU_PCIE_EXTCAP_INIT definition

2025-06-05 Thread Igor Mammedov
On Thu, 1 May 2025 23:04:45 +0200 Philippe Mathieu-Daudé wrote: > QEMU_PCIE_EXTCAP_INIT was only used by the hw_compat_2_8[] > array, via the 'x-pcie-extcap-init=off' property. We removed > all machines using that array, lets remove all the code around > QEMU_PCIE_EXTCAP_INIT. > > Signed-off-by

Re: [PATCH 06/18] hw/block/pflash: Remove PFlashCFI01::old_multiple_chip_handling field

2025-06-05 Thread Igor Mammedov
> property and all the code around it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > hw/block/pflash_cfi01.c | 14 +++--- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/hw/block/pflash_cfi01.c b/hw/block/pfla

Re: [PATCH v3 1/6] hw/arm/smmuv3: Check SMMUv3 has PCIe Root Complex association

2025-06-05 Thread Igor Mammedov
On Thu, 5 Jun 2025 12:36:52 + Shameerali Kolothum Thodi wrote: > > -Original Message- > > From: Igor Mammedov > > Sent: Thursday, June 5, 2025 1:20 PM > > To: Shameerali Kolothum Thodi > > Cc: Shameer Kolothum via ; qemu- > > a...@nongnu.or

Re: [PATCH v3 1/6] hw/arm/smmuv3: Check SMMUv3 has PCIe Root Complex association

2025-06-05 Thread Igor Mammedov
On Thu, 5 Jun 2025 11:29:59 + Shameerali Kolothum Thodi wrote: > > -Original Message- > > From: Igor Mammedov > > Sent: Thursday, June 5, 2025 11:55 AM > > To: Shameer Kolothum via > > Cc: Shameerali Kolothum Thodi > > ; qemu-...@nongnu.org; &

Re: [PATCH v3 1/6] hw/arm/smmuv3: Check SMMUv3 has PCIe Root Complex association

2025-06-05 Thread Igor Mammedov
On Mon, 2 Jun 2025 16:41:05 +0100 Shameer Kolothum via wrote: > Although this change does not affect functionality at present, it is > required when we add support for user-creatable SMMUv3 devices in > future patches. > > Signed-off-by: Shameer Kolothum > --- > hw/arm/smmuv3.c | 8 >

Re: [PATCH v4 04/19] target/i386/cpu: Remove X86CPU::check_cpuid field

2025-06-05 Thread Igor Mammedov
On Tue, 3 Jun 2025 23:54:19 +0800 Xiaoyao Li wrote: > On 6/3/2025 11:02 PM, Igor Mammedov wrote: > > On Wed, 28 May 2025 13:23:49 +0800 > > Zhao Liu wrote: > > > >> On Wed, May 28, 2025 at 10:09:56AM +0800, Xiaoyao Li wrote: > >>> Date: Wed, 28 M

Re: [PATCH 05/18] hw/core/machine: Remove hw_compat_2_8[] array

2025-06-03 Thread Igor Mammedov
On Thu, 1 May 2025 23:04:43 +0200 Philippe Mathieu-Daudé wrote: > The hw_compat_2_8[] array was only used by the pc-q35-2.8 and > pc-i440fx-2.8 machines, which got removed. Remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > includ

Re: [PATCH 04/18] hw/i386/kvm: Remove KVMClockState::mach_use_reliable_get_clock field

2025-06-03 Thread Igor Mammedov
> > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > hw/i386/kvm/clock.c | 18 -- > 1 file changed, 18 deletions(-) > > diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c > index f56382717f7..726ebfcb0cb 100644 > --- a/h

Re: [PATCH 03/18] hw/southbridge/ich9: Remove ICH9_LPC_SMI_F_BROADCAST_BIT definition

2025-06-03 Thread Igor Mammedov
all the code around it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > include/hw/southbridge/ich9.h | 1 - > hw/acpi/ich9.c| 6 ++ > hw/isa/lpc_ich9.c | 22 +++--- > 3 files changed, 5 inser

Re: [PATCH 02/18] hw/i386/pc: Remove pc_compat_2_8[] array

2025-06-03 Thread Igor Mammedov
On Thu, 1 May 2025 23:04:40 +0200 Philippe Mathieu-Daudé wrote: > The pc_compat_2_8[] array was only used by the pc-q35-2.8 > and pc-i440fx-2.8 machines, which got removed. Remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > includ

Re: [PATCH 01/18] hw/i386/pc: Remove deprecated pc-q35-2.8 and pc-i440fx-2.8 machines

2025-06-03 Thread Igor Mammedov
& removal") they can now be removed. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > hw/i386/pc_piix.c | 9 - > hw/i386/pc_q35.c | 9 - > 2 files changed, 18 deletions(-) > > diff --git a/hw/i386/pc_piix.c b/

Re: [PATCH v4 04/19] target/i386/cpu: Remove X86CPU::check_cpuid field

2025-06-03 Thread Igor Mammedov
On Wed, 28 May 2025 13:23:49 +0800 Zhao Liu wrote: > On Wed, May 28, 2025 at 10:09:56AM +0800, Xiaoyao Li wrote: > > Date: Wed, 28 May 2025 10:09:56 +0800 > > From: Xiaoyao Li > > Subject: Re: [PATCH v4 04/19] target/i386/cpu: Remove X86CPU::check_cpuid > > field > > > > On 5/12/2025 4:39 PM,

Re: [PATCH v4 04/19] target/i386/cpu: Remove X86CPU::check_cpuid field

2025-06-03 Thread Igor Mammedov
alizefn(). > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Daniel P. Berrangé > Reviewed-by: Zhao Liu Reviewed-by: Igor Mammedov > --- > target/i386/cpu.h | 1 - > target/i386/cpu.c | 3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff -

Re: [PATCH v4 03/19] hw/i386/pc: Remove pc_compat_2_4[] array

2025-06-03 Thread Igor Mammedov
iewed-by: Zhao Liu Reviewed-by: Igor Mammedov > --- > include/hw/i386/pc.h | 3 --- > hw/i386/pc.c | 19 --- > 2 files changed, 22 deletions(-) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index f4a874b17fc..b34aa25fdce 100644 > ---

Re: [PATCH v4 02/19] hw/i386/pc: Remove PCMachineClass::broken_reserved_end field

2025-06-03 Thread Igor Mammedov
> Reviewed-by: Daniel P. Berrangé > Reviewed-by: Thomas Huth > Reviewed-by: Zhao Liu Reviewed-by: Igor Mammedov > --- > include/hw/i386/pc.h | 1 - > hw/i386/pc.c | 13 + > 2 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/i

Re: [PATCH v4 01/19] hw/i386/pc: Remove deprecated pc-q35-2.4 and pc-i440fx-2.4 machines

2025-06-03 Thread Igor Mammedov
& removal") they can now be removed. > > Remove the qtest in test-x86-cpuid-compat.c file. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Daniel P. Berrangé > Reviewed-by: Thomas Huth > Reviewed-by: Zhao Liu Reviewed-by: Igor Mammedov &g

Re: [PATCH 12/13] microvm: enable suspend

2025-06-03 Thread Igor Mammedov
On Wed, 28 May 2025 12:42:03 -0400 Annie Li wrote: > The function qemu_wakeup_suspend_enabled combines the suspend > and wakeup together. However, the microvm doesn't support > wakeup yet. Suspend is enabled here, but wakeup doesn't > actually work for microvm now. why wakeup doesn't work? > >

Re: [PATCH 03/13] acpi: Support Control Method sleep button for x86

2025-06-03 Thread Igor Mammedov
On Wed, 28 May 2025 12:39:17 -0400 Annie Li wrote: > Add Control Method Sleep button and its GPE event handler for > x86 platform. The GPE event handler notifies OSPM when the > Sleep button event is triggered. > > Signed-off-by: Annie Li > --- > hw/i386/acpi-build.c | 24 +

Re: [PATCH 05/13] acpi: Send the GPE event of sleep for x86

2025-06-03 Thread Igor Mammedov
On Wed, 28 May 2025 12:39:52 -0400 Annie Li wrote: > The GPE event is triggered to notify x86 guest to sleep > itself. The function acpi_send_sleep_event will also > trigger GED events on HW-reduced systems where ACPI GED > sleep event is supported. > > Signed-off-by: Annie Li > --- > hw/acpi/

Re: [PATCH 01/13] acpi: Implement control method sleep button

2025-06-03 Thread Igor Mammedov
On Wed, 28 May 2025 12:38:34 -0400 Annie Li wrote: > The fixed hardware sleep button isn't appropriate for hardware > reduced platform. This patch implements the control method sleep > button in a separate source file so that the button can be added > for various platforms. > > Co-developed-by:

Re: [PATCH 00/13] Support ACPI Control Method Sleep button

2025-06-03 Thread Igor Mammedov
On Wed, 28 May 2025 12:35:45 -0400 Annie Li wrote: > The ACPI sleep button can be implemented as a fixed hardware button > or Control Method Sleep button. > > The patch of implementing a fixed hardware sleep button was posted > here 1). More discussions can be found here 2). Essentially, the > d

Re: [PATCH 3/3] i386/tdx: Clarify the error message of mrconfigid/mrowner/mrownerconfig

2025-06-03 Thread Igor Mammedov
expected values. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Xiaoyao Li Reviewed-by: Igor Mammedov > --- > Suggested by Daniel at > https://lore.kernel.org/qemu-devel/abzt3trdldan-...@redhat.com/ > --- > target/i386/kvm/tdx.c | 12 +--- > 1 file changed,

Re: [PATCH 2/3] i386/tdx: Fix the typo of the comment of struct TdxGuest

2025-06-03 Thread Igor Mammedov
On Tue, 3 Jun 2025 01:03:04 -0400 Xiaoyao Li wrote: > Change sha348 to sha384. > > Signed-off-by: Xiaoyao Li Reviewed-by: Igor Mammedov > --- > target/i386/kvm/tdx.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/i386/kvm

Re: [PATCH 1/3] i386/cpu: Rename enable_cpuid_0x1f to force_cpuid_0x1f

2025-06-03 Thread Igor Mammedov
On Tue, 3 Jun 2025 01:03:03 -0400 Xiaoyao Li wrote: > The name of "enable_cpuid_0x1f" isn't right to its behavior because the > leaf 0x1f can be enabled even when "enable_cpuid_0x1f" is false. > > Rename it to "force_cpuid_0x1f" to better reflect

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-06-02 Thread Igor Mammedov
On Fri, 30 May 2025 16:00:19 +0100 Jonathan Cameron wrote: > On Fri, 30 May 2025 14:05:16 +0200 > Igor Mammedov wrote: > > > On Fri, 30 May 2025 11:02:27 +0100 > > Jonathan Cameron wrote: > > > > > On Tue, 27 May 2025 09

Re: [PATCH v4 01/27] hw/i386/pc: Remove deprecated pc-q35-2.6 and pc-i440fx-2.6 machines

2025-06-02 Thread Igor Mammedov
On Mon, 2 Jun 2025 10:53:19 +0200 Philippe Mathieu-Daudé wrote: > On 2/6/25 08:13, Thomas Huth wrote: > > On 09/05/2025 17.23, Igor Mammedov wrote: > >> On Thu,  8 May 2025 15:35:24 +0200 > >> Philippe Mathieu-Daudé wrote: > >> > >>> These

Re: [PATCH v9 12/20] acpi/generic_event_device: add logic to detect if HEST addr is available

2025-06-02 Thread Igor Mammedov
On Fri, 30 May 2025 22:18:10 +0200 Mauro Carvalho Chehab wrote: > Em Fri, 30 May 2025 16:49:03 +0200 > Igor Mammedov escreveu: > > > On Fri, 30 May 2025 08:01:28 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, May 28, 2025 at 05:42:1

Re: [PATCH v7] hw/i386/cpu: remove default_cpu_version and simplify

2025-05-30 Thread Igor Mammedov
On Sun, 11 May 2025 09:40:08 -0400 "Michael S. Tsirkin" wrote: > On Fri, Mar 07, 2025 at 03:53:28PM +0530, Ani Sinha wrote: > > commit 0788a56bd1ae3 ("i386: Make unversioned CPU models be aliases") > > introduced 'default_cpu_version' for PCMachineClass. This created three > > categories of CPU m

Re: [PATCH v9 12/20] acpi/generic_event_device: add logic to detect if HEST addr is available

2025-05-30 Thread Igor Mammedov
On Fri, 30 May 2025 08:01:28 -0400 "Michael S. Tsirkin" wrote: > On Wed, May 28, 2025 at 05:42:12PM +0200, Igor Mammedov wrote: > > On Tue, 20 May 2025 08:41:31 +0200 > > Mauro Carvalho Chehab wrote: > > > > > Create a new property (x-has-hest-addr

Re: [PATCH RFC 0/3] Attempt to add GHES for x86

2025-05-30 Thread Igor Mammedov
On Tue, 4 Mar 2025 14:30:55 +0100 Mauro Carvalho Chehab wrote: > Hi Igor, > > This patch series comes after: > > https://lore.kernel.org/qemu-devel/cover.1740903110.git.mchehab+hua...@kernel.org/ > > I'm basically trying to add support for error injection for x86, > without success so far.

Re: [PATCH RFC 1/3] acpi/ghes: move use_hest_addr out of acpi_build_hest()

2025-05-30 Thread Igor Mammedov
On Tue, 4 Mar 2025 14:30:56 +0100 Mauro Carvalho Chehab wrote: > The only reason why we're passing ags to acpi HEST table build > is to check if migration will be used or not. > > Well, we only need migration for arm, as other architectures > will only use the new code. So, move this out of acp

Re: [PATCH v2 06/25] hw/pci-host/gpex-acpi: Propagate hotplug type info from virt machine downto gpex

2025-05-30 Thread Igor Mammedov
On Fri, 30 May 2025 11:14:13 +0100 Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:08 +0200 > Eric Auger wrote: > > > Propagate the type of pci hotplug mode downto the gpex > > acpi code. In case machine acpi_pcihp is unset we configure > > pci native hotplug on pci0. For expander bridges w

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-05-30 Thread Igor Mammedov
On Fri, 30 May 2025 11:02:27 +0100 Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:07 +0200 > Eric Auger wrote: > > > acpi_dsdt_add_pci_osc() name is confusing as it gives the impression > > it appends the _OSC method but in fact it also appends the _DSM method > > for the host bridge. Let'

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-05-30 Thread Igor Mammedov
On Wed, 28 May 2025 12:04:26 -0300 Gustavo Romero wrote: > Hi Igor, > > On 5/28/25 10:02, Igor Mammedov wrote: > > On Wed, 28 May 2025 09:41:15 -0300 > > Gustavo Romero wrote: > > > >> Hi Igor, > >> > >> On 5/28/25 06:38, Igor Mamm

Re: [PATCH v9 12/20] acpi/generic_event_device: add logic to detect if HEST addr is available

2025-05-28 Thread Igor Mammedov
dware_errors firmware file. it doesn't apply to current master anymore > > Signed-off-by: Mauro Carvalho Chehab > Reviewed-by: Jonathan Cameron > Reviewed-by: Igor Mammedov > --- > hw/acpi/generic_event_device.c | 2 ++ > hw/arm/virt-acpi-build.c | 18 +

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-05-28 Thread Igor Mammedov
On Wed, 28 May 2025 09:41:15 -0300 Gustavo Romero wrote: > Hi Igor, > > On 5/28/25 06:38, Igor Mammedov wrote: > > On Tue, 27 May 2025 09:40:26 +0200 > > Eric Auger wrote: > > > >> From: Gustavo Romero > >> > >> ACPI PCI hotplu

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-05-28 Thread Igor Mammedov
On Tue, 27 May 2025 09:40:26 +0200 Eric Auger wrote: > From: Gustavo Romero > > ACPI PCI hotplug is now turned on by default so we need to change the > existing tests to keep it off. However, even setting the ACPI PCI > hotplug off in the existing tests, there will be changes in the ACPI > tabl

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-05-28 Thread Igor Mammedov
On Wed, 28 May 2025 11:48:20 +0200 Eric Auger wrote: > Hi Igor, > > On 5/28/25 11:38 AM, Igor Mammedov wrote: > > On Tue, 27 May 2025 09:40:26 +0200 > > Eric Auger wrote: > > > >> From: Gustavo Romero > >> > >> ACPI PCI hotplu

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-05-28 Thread Igor Mammedov
On Tue, 27 May 2025 15:54:15 +0200 Eric Auger wrote: > Hi Igor, > > On 5/27/25 1:58 PM, Igor Mammedov wrote: > > On Tue, 27 May 2025 09:40:04 +0200 > > Eric Auger wrote: > > > >> acpi_pcihp VirtMachineClass state flag will allow > >> to opt

Re: [PATCH v2 22/25] hw/arm/virt: Let virt support pci hotplug/unplug GED event

2025-05-28 Thread Igor Mammedov
On Tue, 27 May 2025 13:44:35 -0300 Gustavo Romero wrote: > Hi folks, > > On 5/27/25 12:56, Igor Mammedov wrote: > > On Tue, 27 May 2025 09:40:24 +0200 > > Eric Auger wrote: > > > >> Set up the IO registers used to communicate between QEMU > >&g

Re: [PATCH v2 09/25] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

2025-05-27 Thread Igor Mammedov
} > > -CDW3 = CTRL /* \_SB_.PCI0.CTRL */ > -Return (Arg3) > +CDW3 = Local0 > } > Else > { > CDW1 |= 0x04 > - Return (Arg3) >

Re: [PATCH v2 22/25] hw/arm/virt: Let virt support pci hotplug/unplug GED event

2025-05-27 Thread Igor Mammedov
On Tue, 27 May 2025 09:40:24 +0200 Eric Auger wrote: > Set up the IO registers used to communicate between QEMU > and ACPI. > Move the create_pcie() call after the creation of the acpi > ged device since hotplug callbacks will soon be called on gpex > realize and will require the acpi pcihp st

Re: [PATCH v2 15/25] hw/i386/acpi-build: Introduce and use acpi_get_pci_host

2025-05-27 Thread Igor Mammedov
On Tue, 27 May 2025 09:40:17 +0200 Eric Auger wrote: > pcihp acpi_set_pci_info() generic code currently uses > acpi_get_i386_pci_host() to retrieve the pci host bridge. > > Let's rename acpi_get_i386_pci_host into acpi_get_pci_host and > move it in pci generic code. > > The helper is augmented

Re: [PATCH v2 20/25] hw/acpi/ged: Support migration of AcpiPciHpState

2025-05-27 Thread Igor Mammedov
On Tue, 27 May 2025 09:40:22 +0200 Eric Auger wrote: > Add a subsection to migrate the AcpiPciHpState state. > > Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov > --- > hw/acpi/generic_event_device.c | 20 > 1 file changed, 20 insertions(+) &g

Re: [PATCH v2 19/25] hw/acpi/ged: Call pcihp plug callbacks in hotplug handler implementation

2025-05-27 Thread Igor Mammedov
On Tue, 27 May 2025 09:40:21 +0200 Eric Auger wrote: > Add PCI device related code in the TYPE_HOTPLUG_HANDLER > implementation. > > For a PCI device hotplug/hotunplug event, the code routes to > acpi_pcihp_device callbacks (pre_plug_cb, plug_cb, unplug_request_cb, > unplug_cb). > > Signed-off-

  1   2   3   4   5   6   7   8   9   10   >