> >> >> Guid="{6C117C78-0F47-4B07-8F34-6BEE11643829}">
> >>>> Source="$(var.Mingw_bin)/libwinpthread-1.dll" KeyPath="yes" DiskId="1"/>
> >>
> >> + >> Guid=&quo
e error was caused by the following commit:
https://github.com/qemu/qemu/commit/3ebee3b191e755d3f7311a6a62eea5c9628b221b
What do you think is the best approach to resolve this?
--
Respectfully,
Sameeh Jubran
Linkedin
Software Engineer @ Daynix.
On Thu, Oct 25, 2018 at 5:06 PM Sameeh Jubran wrote:
>
> From: Sameeh Jubran
>
> Hi all,
>
> Background:
>
> There has been a few attempts to implement the standby feature for vfio
> assigned devices which aims to enable the migration of such devices. This
> is a
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
hw/core/qdev.c | 48 +++---
hw/pci/pci.c | 1 +
include/hw/pci/pci.h | 2 ++
include/hw/qdev-core.h | 11 +++-
qdev-monitor.c | 58 +++---
5
From: Sameeh Jubran
Hi all,
Background:
There has been a few attempts to implement the standby feature for vfio
assigned devices which aims to enable the migration of such devices. This
is another attempt.
The series implements an infrastructure for hiding devices from the bus
upon boot. What
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
hw/net/virtio-net.c| 25 +
include/hw/virtio/virtio-net.h | 5 +
2 files changed, 30 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index f154756e85..f478445cbd 100644
--- a/hw
Thanks for your help, turns out that the hotlpug is set by piix4 after
the devices are realized.
On Mon, Oct 8, 2018 at 11:28 AM Igor Mammedov wrote:
>
> On Sun, 7 Oct 2018 12:52:11 +0300
> Sameeh Jubran wrote:
>
> > This is the command line. All of the devices are wired
sizeof(GuestDiskAddress));
> +
> +/* Disk numbers directly correspond to numbers used in UNCs
> + *
> + * See documentation for DISK_EXTENT:
> + *
> https://docs.microsoft.com/en-us/windows/desktop/api/winioctl/ns-winioctl-_disk_extent
&
ot;) == TRUE)) {
> > +name = g_strdup(&guid[4]);
>
> I find "guid + 4" easier to read though
>
> > +} else {
> > +name = g_strdup(guid);
> > +}
> >
> > if (!QueryDosDevice(name, dev_name, ARRAY_SIZE(dev_name))) {
> > error_setg_win32(errp, GetLastError(), "failed to get dos device
> > name");
> > --
> > 2.19.0
> >
>
--
Respectfully,
Sameeh Jubran
Linkedin
Software Engineer @ Daynix.
\
-chardev socket,path=/tmp/qga.sock,server,nowait,id=qga0 \
-device virtio-serial \
-device virtserialport,chardev=qga0,name=org.qemu.guest_agent.0 \
-monitor stdio
On Thu, Oct 4, 2018 at 2:20 PM Igor Mammedov wrote:
> On Wed, 3 Oct 2018 19:50:58 +0300
> Sameeh Jubran wrote:
>
&
Reviewed-by: Sameeh Jubran
On Thu, Oct 4, 2018 at 4:23 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote:
> >
> > There was inconsistency between commits:
> >
> > 50cbebb9a3 configure: add configure check for nt
Hi all,
I am trying to get the hotplug handler of a pci device in Qemu using
"qdev_get_hotplug_handler" function. This function simply tries to get
the hotplug handler from the parent bus. For some reason it's always
null. Why it is not initialized?
Thanks!
On Thu, Sep 27, 2018 at 12:06 PM Tomáš Golembiovský
wrote:
> Hi Michael,
>
> thanks for looking into this. My comments are below.
>
> Adding Sameeh...
>
>
> On Wed, 26 Sep 2018 12:15:48 -0500
> Michael Roth wrote:
>
> > Quoting Tomáš Golembiovský (2018-09-07 06:42:09)
> > > The guest-get-fsinfo
Hi All,
I have used the function "pci_qdev_find_device" to find a device using
it's id. This is a virtio device and I'm trying to convert it to
VirtIODevice.
What's the best way to do this? Simply converting it to DeviceState
doesn't work and I think I should access the underlying virtio pci bus
charredir1,name=usbredir -device
> usb-redir,chardev=charredir1,id=redir1,bus=usb.0,port=3 -device
> virtio-balloon-pci,id=balloon0,bus=pci.5,addr=0x0 -msg timestamp=on
>
> Cheers,
> Florian
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1791947/+subscriptions
>
--
Respectfully,
Sameeh Jubran
Linkedin
Software Engineer @ Daynix.
tive for this?
> So vhost_net_get_fd() did nothing in fact?
You are correct, I'm dropping it
> STEERING BPF is per device not per queue, so setting this for queue 0 should
> be ok.
Oh, okay will do.
On Mon, Sep 3, 2018 at 7:12 AM, Jason Wang wrote:
>
>
> On 2018年08月30日 22:
On Mon, Sep 3, 2018 at 6:34 AM, Jason Wang wrote:
>
>
> On 2018年08月30日 22:27, Sameeh Jubran wrote:
>>
>> From: Sameeh Jubran
>>
>> Signed-off-by: Sameeh Jubran
>> ---
>> hw/net/virtio-net.c | 65
>> ++
On Mon, Sep 3, 2018 at 2:54 PM, Daniel P. Berrangé wrote:
> On Thu, Aug 30, 2018 at 05:27:08PM +0300, Sameeh Jubran wrote:
>> From: Sameeh Jubran
>>
>> Signed-off-by: Sameeh Jubran
>> ---
>> hw/net/rss_bpf_insns.h | 3992
>> ++
n.)
That's what Daniel suggested and I though it should be good for the
reasons above. You have good points as well. Both approaches are okay
with me :)
>
> thanks
> -- PMM
--
Respectfully,
Sameeh Jubran
Linkedin
Software Engineer @ Daynix.
On Mon, Sep 3, 2018 at 2:59 PM, Daniel P. Berrangé wrote:
> On Thu, Aug 30, 2018 at 05:27:03PM +0300, Sameeh Jubran wrote:
>> From: Sameeh Jubran
>>
>> This commit adds the bpf header provided by Linux to Qemu.
>
> s/Qemu/QEMU/
>
>>
>> Signed-off
On Mon, Sep 3, 2018 at 6:24 AM, Jason Wang wrote:
>
>
> On 2018年08月30日 22:27, Sameeh Jubran wrote:
>>
>> From: Sameeh Jubran
>>
>> Signed-off-by: Sameeh Jubran
>
>
> Better explain the motivation in the commit log.
I used to use this function in my in
On Mon, Sep 3, 2018 at 6:48 AM, Jason Wang wrote:
>
>
> On 2018年08月30日 22:27, Sameeh Jubran wrote:
>>
>> From: Sameeh Jubran
>>
>> Signed-off-by: Sameeh Jubran
>> ---
>> hw/net/virtio-net.c | 122
>> +
On Thu, Aug 30, 2018 at 6:21 PM, Eric Blake wrote:
> On 08/30/2018 09:27 AM, Sameeh Jubran wrote:
>>
>> From: Sameeh Jubran
>>
>> Starting from kernel v4.16 tun device supports TUNSETSTEERINGEBPF and
>> TUNSETFILTEREBPF.
>>
>> Signed-off-by: Sam
On Mon, Sep 3, 2018 at 6:24 AM, Jason Wang wrote:
>
>
> On 2018年08月30日 22:27, Sameeh Jubran wrote:
>>
>> From: Sameeh Jubran
>>
>> Starting from kernel v4.16 tun device supports TUNSETSTEERINGEBPF and
>> TUNSETFILTEREBPF.
>>
>> Signed-off-by
On Mon, Sep 3, 2018 at 7:15 AM, Jason Wang wrote:
>
>
> On 2018年08月30日 22:27, Sameeh Jubran wrote:
>>
>> From: Sameeh Jubran
>>
>> This series implements the Steering Mode feature which was introduced on
>> the
>> virtio-dev list a while ago, whic
From: Sameeh Jubran
Starting from kernel v4.16 tun device supports TUNSETSTEERINGEBPF and
TUNSETFILTEREBPF.
Signed-off-by: Sameeh Jubran
---
include/net/net.h | 3 ++-
net/tap-bsd.c | 5 +
net/tap-linux.c | 29 -
net/tap-linux.h | 3 ++-
net/tap
From: Sameeh Jubran
This commit adds the bpf header provided by Linux to Qemu.
Signed-off-by: Sameeh Jubran
---
MAINTAINERS | 5 +
configure | 44 +
scripts/update-linux-headers.sh | 8 ++--
3 files
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
hw/net/virtio-net.c | 65 +
include/hw/virtio/virtio-net.h | 3 ++
include/standard-headers/linux/virtio_net.h | 55
3 files changed, 116 insertions
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
hw/net/vhost_net.c | 2 +-
include/hw/virtio/virtio-net.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index e037db63a3..c0bff725c9 100644
--- a/hw/net/vhost_net.c
From: Sameeh Jubran
This series implements the Steering Mode feature which was introduced on the
virtio-dev list a while ago, which can be found here:
* https://lists.oasis-open.org/archives/virtio-dev/201805/msg00024.html
The first three patches add some infrastructure support that is used in
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
hw/net/virtio-net.c | 122
1 file changed, 105 insertions(+), 17 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index e7c4ce6f66..4a52a6a1d0 100644
--- a/hw/net
On Mon, Jul 16, 2018 at 11:04 PM, Michael Roth
wrote:
> Quoting Sameeh Jubran (2018-06-26 10:10:38)
> > From: Sameeh Jubran
> >
> > The call to SetupDiGetDeviceRegistryProperty might fail because the
> > value doesn't exist in the registry, in this case we shou
ws8orLater) {
+ error_setg(errp, "fstrim is only supported for Win8+");
+ return NULL;
+}
handle = FindFirstVolumeW(guid, ARRAYSIZE(guid));
if (handle == INVALID_HANDLE_VALUE) {
--
2.8.1.185.gdc0db2c
On Mon, Jul 16, 2018 at 11:10 PM, Michael Roth
wrote:
ping.
On Sun, Jun 24, 2018 at 3:45 PM, Sameeh Jubran wrote:
> From: Sameeh Jubran
>
> The defrag.exe tool which is used for executing the fstrim command
> on Windows doesn't support retrim for OSes lower than Win8. This
> commit handles this case and returns a suitable
information about volume. */
} else {
disk->pci_controller = NULL;
}
This can be easily prevented by always calling "get_pci_info(name, errp);",
is this a separate patch, or should be combined with this one? what do you
think?
On Tue, Jul 10, 2018 at 1:58 AM, Michael Roth
wrote:
> Quoting
On Fri, Jun 29, 2018 at 12:44 AM, Eric Blake wrote:
> On 06/26/2018 10:10 AM, Sameeh Jubran wrote:
>
>> From: Sameeh Jubran
>>
>> The fsinfo command is currently implemented for Windows only and it's disk
>> parameter can be enabled by adding the define
From: Sameeh Jubran
The call to SetupDiGetDeviceRegistryProperty might fail because the
value doesn't exist in the registry, in this case we shouldn't exit from
the loop but instead continue to look for other available values in the
registry and set this value as unavailable (-1).
Sig
From: Sameeh Jubran
The fsinfo command is currently implemented for Windows only and it's disk
parameter can be enabled by adding the define "CONFIG_QGA_NTDDSCSI" to the qga
code. When enabled and executed the qemu-ga crashed with the fo
From: Sameeh Jubran
The following patch series fixes an issue with fsinfo command of qemu-ga
on Windows which leads to crash of qga when the disk paramter is
enabled.
Sameeh Jubran (2):
qga-win: prevent crash when executing fsinfo command
qga-win: fsinfo: pci-info: allow partial info
qga
On Mon, Jun 25, 2018 at 2:22 PM, Daniel P. Berrangé
wrote:
> On Mon, Jun 25, 2018 at 02:07:06PM +0300, Sameeh Jubran wrote:
> > From: Sameeh Jubran
> >
> > This commit is a sample only for using the libbpf in the code and
> > shouldn't be committed.
>
On Mon, Jun 25, 2018 at 2:16 PM, Peter Maydell
wrote:
> On 25 June 2018 at 12:07, Sameeh Jubran wrote:
> > From: Sameeh Jubran
> >
> > The Berkeley Packet Filter has been in the kernel for a while now and I
> > think it is time that it is introduced to Qemu. This pat
From: Sameeh Jubran
This commit adds the libbpf library provided by Linux to Qemu.
Signed-off-by: Sameeh Jubran
---
MAINTAINERS |6 +
configure | 46 +
include/standard-headers/linux/libbpf.h | 284
linux-headers/linux
From: Sameeh Jubran
This commit is a sample only for using the libbpf in the code and
shouldn't be committed.
Signed-off-by: Sameeh Jubran
---
hw/net/Makefile.objs | 4
hw/net/virtio-net.c | 4
2 files changed, 8 insertions(+)
diff --git a/hw/net/Makefile.objs b/h
From: Sameeh Jubran
The Berkeley Packet Filter has been in the kernel for a while now and I
think it is time that it is introduced to Qemu. This patch is an
infrastructure for any future usage of the BPF in Qemu.
It is important to note that the tun driver had started supporting using
BPF
From: Sameeh Jubran
The defrag.exe tool which is used for executing the fstrim command
on Windows doesn't support retrim for OSes lower than Win8. This
commit handles this case and returns a suitable error.
Output of fstrim before this commit:
{"execute":"guest-fstrim&
On Wed, Jun 20, 2018 at 11:34 AM, Daniel P. Berrangé
wrote:
> On Tue, Jun 19, 2018 at 05:37:10PM +0300, Sameeh Jubran wrote:
> > This patch is actually a preparation for an upcoming patch set that I
> want
> > to integrate into virtio-net which implements the RSS fe
On Wed, Jun 20, 2018 at 11:13 AM, Jason Wang wrote:
>
>
> On 2018年06月19日 21:21, Sameeh Jubran wrote:
>
>> From: Sameeh Jubran
>>
>> The Berkeley Packet Filter has been in the kernel for a while now and I
>> think it is time that it is introduced to Qemu. Th
On Tue, Jun 19, 2018 at 5:41 PM, Murilo Opsfelder Araujo <
muri...@linux.ibm.com> wrote:
> On Tue, Jun 19, 2018 at 04:22:00PM +0300, Sameeh Jubran wrote:
> > From: Sameeh Jubran
> >
> > This commit introduces wrappers around BPF syscalls to qemu. The Berkeley
>
preparation needed for the BPF from the actual RSS feature
implementation.
On Tue, Jun 19, 2018 at 4:49 PM, Daniel P. Berrangé
wrote:
> On Tue, Jun 19, 2018 at 04:21:59PM +0300, Sameeh Jubran wrote:
> > From: Sameeh Jubran
> >
> > The Berkeley Packet Filter has been in the k
From: Sameeh Jubran
This commit introduces wrappers around BPF syscalls to qemu. The Berkeley
Packet Filter (BPF) can be really usefull for packet filtering, tracing and
monitoring with very minimal overhead.
Signed-off-by: Sameeh Jubran
---
MAINTAINERS | 7 +
bpf
From: Sameeh Jubran
The Berkeley Packet Filter has been in the kernel for a while now and I
think it is time that it is introduced to Qemu. This patch is an
infrastructure for any future usage of the BPF in Qemu.
It is important to note that the tun driver had started supporting using
BPF
Ping.
On Fri, Oct 27, 2017 at 10:08 AM, Sameeh Jubran wrote:
>
>
> On Fri, Oct 27, 2017 at 2:51 AM, Michael Roth
> wrote:
>
>> Quoting Sameeh Jubran (2017-08-13 10:58:46)
>> > From: Sameeh Jubran
>> >
>> > This series fixes qemu-ga&#x
On Wed, Nov 29, 2017 at 1:17 AM, Michael Roth
wrote:
> Quoting Sameeh Jubran (2017-11-22 05:30:14)
> > From: Sameeh Jubran
> >
> > We can get VSS_E_PROVIDER_ALREADY_REGISTERED error if for some
> > reason the uninstall of qemu-ga didn't complete successfully
From: Sameeh Jubran
We can get VSS_E_PROVIDER_ALREADY_REGISTERED error if for some
reason the uninstall of qemu-ga didn't complete successfully.
In this case we can try to unregister the component service
and attempt to register it again.
Signed-off-by: Sameeh Jubran
---
qga/vss-
On Fri, Oct 27, 2017 at 2:51 AM, Michael Roth
wrote:
> Quoting Sameeh Jubran (2017-08-13 10:58:46)
> > From: Sameeh Jubran
> >
> > This series fixes qemu-ga's behaviour upon facing a missing serial/serial
> > driver by listening to the serial device's even
;
>> Hi all,
>>
>> I could repeat it, host os and guest os is Centos-7, qemu-ga is alive in
>> guest. the step to repeat it is:
>>
>> 1. run python script just like the first email.
>> 2. send qmp command1(cmd in the python script, like `route -n` command or
&
Ping.
On Tue, Aug 22, 2017 at 2:18 PM, Sameeh Jubran wrote:
> Ping.
>
> On Sun, Aug 13, 2017 at 6:58 PM, Sameeh Jubran wrote:
>
>> From: Sameeh Jubran
>>
>> This series fixes qemu-ga's behaviour upon facing a missing serial/serial
>> driver b
>> sock.settimeout(20)
> >>>> sock.connect(vm_qga_sockpath)
> >>>> sock.send(cmd)
> >>>> while True:
> >>>> res = sock.recv(1024)
> >>>> if len(res):
> >>>> break
> >>>> except Exception as e:
> >>>> res = -1
> >>>> finally:
> >>>> sock.settimeout(None)
> >>>> sock.close()
> >>>
> >>>
> >>
> >
>
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*
qga.sock,server,nowait,id=
> qga0
> >>> -device virtio-serial -device virtserialport,chardev=qga0,na
> >>> me=org.qemu.guest_agent.0
> >>
> >>
> >> But When I use socat to send command (https://wiki.qemu.org/Feature
> >> s/GuestAgent), it blocked. Why and how to fix this? Thank you~
> >>
> >
> >
>
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*
Reviewed-by: Sameeh Jubran
On Tue, Aug 22, 2017 at 4:55 PM, Bishara AbuHattoum
wrote:
> At the moment, Windows libraries don't provide a way to access
> RTC, so, a workaround is to use the Windows w32tm command to
> resync the time.
> Related bugzilla: https://bu
Reviewed-by: Sameeh Jubran
On Tue, Aug 22, 2017 at 3:20 PM, Bishara AbuHattoum
wrote:
> At the moment, Windows libraries don't provide a way to access
> RTC, so, a workaround is to use the Windows w32tm command to
> resync the time.
> Related bugzilla: https://bu
Ping.
On Sun, Aug 13, 2017 at 6:58 PM, Sameeh Jubran wrote:
> From: Sameeh Jubran
>
> This series fixes qemu-ga's behaviour upon facing a missing serial/serial
> driver by listening to the serial device's events.
>
> For more info on why this series is needed chec
From: Sameeh Jubran
Currently whenever the qemu-ga's service doesn't find the virtio-serial
it terminates. This commit addresses this issue by listening to the serial
events
by registering for notifications for the chosen serial and it handles channel
initialization accordingily.
From: Sameeh Jubran
This series fixes qemu-ga's behaviour upon facing a missing serial/serial
driver by listening to the serial device's events.
For more info on why this series is needed checkout the commit message
of the third patch and the following bugzilla:
https://bugzilla.
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
qga/main.c | 44 +++-
1 file changed, 23 insertions(+), 21 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 1b381d0..cf312b9 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -92,7 +92,28 @@ struct
From: Sameeh Jubran
This commit adds functions to check if the serial is
connected/disconnected or else if it has been attached or detached.
Signed-off-by: Sameeh Jubran
---
qga/channel-posix.c | 54 +++
qga/channel-win32.c | 60
uot;, VFIOPCIDevice, igd_gms, 0),
> +DEFINE_PROP_UINT32("x-igd-gms", VFIOPCIDevice, igd_gms, 1),
> /*
> * TODO - support passed fds... is this necessary?
> * DEFINE_PROP_STRING("vfiofd", VFIOPCIDevice, vfiofd_name),
> --
> 2.9.4
>
>
>
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*
Ping.
On Wed, Jul 5, 2017 at 10:54 AM, Sameeh Jubran wrote:
> From: Sameeh Jubran
>
> This patch series fixes qemu-ga's main service behaviour on Windows
> by listening to the virtio-serial device's events.
>
> For more info on why this series is needed checkout
From: Sameeh Jubran
This version doesn't differ from v2 at all, v2 have been waiting too
long for a review, so I'm resending it again.
Daniel Rempel (1):
qga-win: fix installation on localized windows
qga/vss-win32/install.cpp | 35 +--
1 file c
ndows has Well-known SIDs for "Administrators" group and "SYSTEM" user so
they were used to identify required users and groups.
Well-known SIDs:
https://support.microsoft.com/en-us/help/243330/well-known-security-identifiers-in-windows-operating-systems
Signed-off-by: Dan
From: Sameeh Jubran
Currently on Windows whenever the qemu-ga's service doesn't find the
virtio-serial
it terminates. This commit addresses this issue by adding a new listener service
which registers for notifications of the virtio-port-serial device handle the
qemu-ga's serv
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
qga/service-win32.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/qga/service-win32.c b/qga/service-win32.c
index 861f9fc..c17e0eb 100644
--- a/qga/service-win32.c
+++ b/qga/service-win32.c
From: Sameeh Jubran
This commits adds two functions which handle service's start and stop
process in Windows.
Signed-off-by: Sameeh Jubran
---
qga/service-win32.c | 52
qga/service-win32.h | 2 ++
2 files changed, 54 insertions(+)
From: Sameeh Jubran
Clean exe files such as qemu-ga.exe
Signed-off-by: Sameeh Jubran
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 16a0430..22d29d6 100644
--- a/Makefile
+++ b/Makefile
@@ -487,6 +487,7 @@ clean:
rm -f config.mak op-i386.h
From: Sameeh Jubran
Signed-off-by: Sameeh Jubran
---
qga/installer/qemu-ga.wxs | 24
1 file changed, 24 insertions(+)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index fa2260c..40b7a7b 100644
--- a/qga/installer/qemu-ga.wxs
+++ b/qga/installer
From: Sameeh Jubran
This patch series fixes qemu-ga's main service behaviour on Windows
by listening to the virtio-serial device's events.
For more info on why this series is needed checkout the commit message
of the third patch and the following bugzilla:
https://bugzilla.
This patch have been waiting too long for a review, Can someone please
review it!!
On Thu, Jun 1, 2017 at 3:07 PM, Sameeh Jubran wrote:
> Can someone review this patch please?
>
> On Thu, May 25, 2017 at 2:06 PM, Sameeh Jubran wrote:
>
>> Ping
>>
>> On Sun, M
Can someone review this patch please?
On Thu, May 25, 2017 at 2:06 PM, Sameeh Jubran wrote:
> Ping
>
> On Sun, May 14, 2017 at 3:53 PM, Sameeh Jubran wrote:
>
>> Reviewed-by: Sameeh Jubran
>>
>> On Thu, Apr 27, 2017 at 4:21 PM, Daniel Rempel wrote:
>>
Ping
On Sun, May 14, 2017 at 3:53 PM, Sameeh Jubran wrote:
> Reviewed-by: Sameeh Jubran
>
> On Thu, Apr 27, 2017 at 4:21 PM, Daniel Rempel wrote:
>
>> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789
>> Replace hardcoded user and group names ("Administr
63@1494850819.412998:e1000e_irq_pending_interrupts ICR PENDING: 0x100
(ICR: 0x815000c2, IMS: 0x1a4)
* This bug behaviour wasn't observed with the Linux driver.
This commit solves:
https://bugzilla.redhat.com/show_bug.cgi?id=1447935
https://bugzilla.redhat.com/show_bug.cgi?id=1449490
Signe
On Mon, May 22, 2017 at 5:46 AM, Jason Wang wrote:
>
>
> On 2017年05月19日 22:04, Sameeh Jubran wrote:
>
>> On Fri, May 19, 2017 at 9:25 AM, Jason Wang wrote:
>>
>>
>>> On 2017年05月17日 19:46, Sameeh Jubran wrote:
>>>
>>> The bug was ca
On Fri, May 19, 2017 at 9:25 AM, Jason Wang wrote:
>
>
> On 2017年05月17日 19:46, Sameeh Jubran wrote:
>
>> The bug was caused by the "receive overrun" (bit #6 of the ICR register)
>> interrupt
>> which would be triggered post migration in a heavy traffic env
: 0xa4)
27563@1494850819.412441:e1000e_irq_pending_interrupts ICR PENDING: 0x0 (ICR:
0x815000c2, IMS: 0xa4)
27563@1494850819.412998:e1000e_irq_pending_interrupts ICR PENDING: 0x100
(ICR: 0x815000c2, IMS: 0x1a4)
This commit solves:
https://bugzilla.redhat.com/show_bug.cgi?id=1447935
htt
Reviewed-by: Sameeh Jubran
On Thu, Apr 27, 2017 at 4:21 PM, Daniel Rempel wrote:
> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789
> Replace hardcoded user and group names ("Administrators", "SYSTEM") with
> the ones acquired from system. Windows use
Acked-by: Sameeh Jubran
On Thu, Apr 27, 2017 at 4:21 PM, Daniel Rempel wrote:
> Second version of the patch. Cleaned the code a bit.
>
> Daniel Rempel (1):
> qga-win: fix installation on localized windows
>
> qga/vss-win32/install.cpp | 35 +++
e' is missing entirely from the reply. This causes
errors in libvirt which is expecting the reply to be compliant with the
schema docs.
BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735
Signed-off-by: Sameeh Jubran
---
qga/commands-win32.c | 2 +-
1 file changed, 1 insertion(+),
re is stuck in an infinite loop and the other cores are halted!
Anyone else faced this issue? Is there any version of Windows 10 IoT Core
ARM that can run on top of Qemu?
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ D
for freeze is 10 seconds, so we should wait for the timeout, thaw
the file system and quit.
Signed-off-by: Sameeh Jubran
---
qga/main.c | 23 +++
qga/vss-win32.h | 1 +
qga/vss-win32/vss-common.h | 11 +--
qga/vss-win32/vss-handles.h | 14
On Wed, Apr 5, 2017 at 1:55 AM, Michael Roth
wrote:
> Quoting Sameeh Jubran (2017-03-21 09:14:35)
> > Errors that are related to ur inner implementation for the thaw command
> > shouldn't be displayed to the user.
> >
> > Signed-off-by: Sameeh Jubran
> > --
x80004004, Operation
aborted.
Signed-off-by: Sameeh Jubran
---
qga/vss-win32/provider.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp
index ef94669..72d8b0e 100644
--- a/qga/vss-win32/provider.cpp
+++ b/qga/vss-win32/provider.
for freeze is 10 seconds, so we should wait for the timeout, thaw
the file system and quit.
Signed-off-by: Sameeh Jubran
---
qga/main.c | 22 ++
qga/vss-win32.h | 1 +
qga/vss-win32/vss-common.h | 11 +--
qga/vss-win32/vss-handles.h | 14
I have tested the patch on Windows 2012 R2
Reviewed-by: Sameeh Jubran
Tested-by: Sameeh Jubran
On Thu, Mar 23, 2017 at 2:39 PM, Vinzenz 'evilissimo' Feenstra <
vfeen...@redhat.com> wrote:
> From: Vinzenz Feenstra
>
> Adds a new command `guest-get-timezone
Ping.
On Tue, Mar 21, 2017 at 5:14 PM, Sameeh Jubran wrote:
> Errors that are related to ur inner implementation for the thaw command
> shouldn't be displayed to the user.
>
> Signed-off-by: Sameeh Jubran
> ---
> qga/vss-win32/requester.cpp | 8
> 1 file c
Ping.
On Tue, Mar 21, 2017 at 4:59 PM, Sameeh Jubran wrote:
> After triggering a freeze command without any following thaw command,
> qemu-ga will not respond to stop operation. This behaviour is wanted on
> Linux
> as there is no time limit for a freeze command and we wan
Ping.
On Wed, Mar 22, 2017 at 11:14 AM, Sameeh Jubran wrote:
>
>
> On Tue, Mar 21, 2017 at 6:09 PM, Michael Roth
> wrote:
>
>> Quoting Sameeh Jubran (2017-03-21 05:49:52)
>> > When the command "guest-fsfreeze-freeze" is executed it causes
>> &g
Ping.
On Thu, Mar 23, 2017 at 7:26 PM, Sameeh Jubran wrote:
> Currently the service runs in background on boot even though it is not
> needed and once it is running it never stops. The service needs to be
> running only during freeze operation and it should be stopped after
> ex
> +
> +
> +##
> +# @GuestFQDN:
> +# @fqdn: Fully qualified domain name of the guest OS
> +#
> +# Since: 2.10
> +##
> +{ 'struct': 'GuestFQDN',
> + 'data': { 'fqdn': 'str' } }
> +
> +
> +##
> +# @guest-get-fqdn:
> +#
> +# Request the FQDN (Fully Qualified Domain Name) of the guest operating
> system
> +#
> +# Returns: FQDN on success
> +#
> +# Since: 2.10
> +##
> +{ 'command': 'guest-get-fqdn',
> + 'returns': 'GuestFQDN' }
> +
> --
> 2.9.3
>
>
>
--
Respectfully,
*Sameeh Jubran*
*Linkedin <https://il.linkedin.com/pub/sameeh-jubran/87/747/a8a>*
*Software Engineer @ Daynix <http://www.daynix.com>.*
g file for glib as it doesn't define
GLIB_STATIC_COMPILATION for pkg-config --static.
Signed-off-by: Sameeh Jubran
Reviewed-by: Stefan Hajnoczi
---
configure | 7 +++
1 file changed, 7 insertions(+)
diff --git a/configure b/configure
index b9a30cf..8210494 100755
--- a/configure
+++ b/
On Thu, Mar 23, 2017 at 9:21 PM, Stefan Hajnoczi wrote:
> On Thu, Mar 23, 2017 at 11:22:11AM +0200, Sameeh Jubran wrote:
> > Attempting to compile qemu-ga statically as follows for Windows causes
> > the following error:
> >
> > Compilation:
> > ./confi
Currently the service runs in background on boot even though it is not
needed and once it is running it never stops. The service needs to be
running only during freeze operation and it should be stopped after
executing thaw.
Signed-off-by: Sameeh Jubran
---
qga/vss-win32/install.cpp | 28
1 - 100 of 125 matches
Mail list logo
