Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-04 Thread Markus Armbruster
"Zhang, Chen" writes: >> -Original Message- >> From: Jason Wang >> Sent: Friday, November 5, 2021 12:03 PM >> To: Zhang, Chen >> Cc: Markus Armbruster ; qemu-dev > de...@nongnu.org>; Li Zhijian >> Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for >> filter-mirror/

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-04 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, November 5, 2021 12:03 PM > To: Zhang, Chen > Cc: Markus Armbruster ; qemu-dev de...@nongnu.org>; Li Zhijian > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redirector > > On Fri, Nov 5,

[PULL 2/2] Fix virtio-net-pci* "vectors" compat

2021-11-04 Thread Jason Wang
From: Eduardo Habkost hw_compat_5_2 has an issue: it affects only "virtio-net-pci" but not "virtio-net-pci-transitional" and "virtio-net-pci-non-transitional". The solution is to use the "virtio-net-pci-base" type in compat_props. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141 S

Re: [PATCH v4 2/2] vhost: Fix last vq queue index of devices with no cvq

2021-11-04 Thread Jason Wang
On Thu, Nov 4, 2021 at 4:56 PM Eugenio Pérez wrote: > > The -1 assumes that cvq device model is accounted in data_queue_pairs, > if cvq does not exists, but it's actually the opposite: Devices with > !cvq are ok but devices with cvq does not add the last queue to > data_queue_pairs. > > This is no

[PULL 1/2] e1000: fix tx re-entrancy problem

2021-11-04 Thread Jason Wang
From: Jon Maloy The fact that the MMIO handler is not re-entrant causes an infinite loop under certain conditions: Guest write to TDT -> Loopback -> RX (DMA to TDT) -> TX We now eliminate the effect of this problem locally in e1000, by adding a boolean in struct E1000State indicating when the

[PULL 0/2] Net patches

2021-11-04 Thread Jason Wang
The following changes since commit 18e356a53a2926a15343b914db64324d63748f25: Merge remote-tracking branch 'remotes/stsquad/tags/pull-for-6.2-041121-2' into staging (2021-11-04 08:33:46 -0400) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request

[PATCH v4 36/36] bsd-user: add arm target build

2021-11-04 Thread Warner Losh
CC: Paolo Bonzini Signed-off-by: Warner Losh Acked-by: Kyle Evans Reviewed-by: Richard Henderson --- configs/targets/arm-bsd-user.mak | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 configs/targets/arm-bsd-user.mak diff --git a/configs/targets/arm-bsd-user.mak b/configs/targets/ar

[PATCH v4 33/36] bsd-user/arm/target_arch_signal.c: arm set_mcontext

2021-11-04 Thread Warner Losh
Move the machine context to the CPU state. Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Warner Losh --- bsd-user/arm/signal.c | 79 +++ bsd-user/arm/target_arch_signal.h | 1 + 2 files changed, 80 insertions(+) diff --git a/bsd-us

Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-04 Thread Jason Wang
On Fri, Nov 5, 2021 at 11:27 AM Zhang, Chen wrote: > > > > > -Original Message- > > From: Jason Wang > > Sent: Friday, November 5, 2021 11:17 AM > > To: Zhang, Chen ; Markus Armbruster > > > > Cc: qemu-dev ; Li Zhijian > > > > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer pr

[PATCH v4 31/36] bsd-user/arm/target_arch_signal.c: arm set_sigtramp_args

2021-11-04 Thread Warner Losh
Implement set_sigtramp_args to setup the arguments to the sigtramp calls. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/arm/signal.c | 60 +++ bsd-user/arm/target_arch_signal.h | 5 +++ 2 files changed,

[PATCH] configure: Support modules for Windows

2021-11-04 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- configure | 7 +-- meson.build | 34 -- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 33682cb971..6280e412a9 100755 --- a/configure +++ b/configure @@ -1422,7 +1422,7 @@ cat << EOF

[PATCH v4 26/36] bsd-user/arm/target_arch_elf.h: arm get hwcap

2021-11-04 Thread Warner Losh
Implement get_elf_hwcap to get the first word of hardware capabilities. Signed-off-by: Kyle Evans Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_elf.h | 72 +- 1 file cha

[PATCH] target/ppc, hw/ppc: Change maintainers

2021-11-04 Thread David Gibson
As our day jobs and interests have moved onto other things, Greg and I have been struggling to keep on top of maintainership of target/ppc and associated pieces like the pseries and powernv machine types, with their platform specific devices. We've therefore discussed and plan to transfer maintain

[PATCH v4 23/36] bsd-user/arm/target_arch_sigtramp.h: Signal Trampoline for arm

2021-11-04 Thread Warner Losh
Copy of the signal trampoline code for arm, as well as setup_sigtramp to write it to the stack. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_sigtramp.h | 49 + 1 file change

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-04 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Friday, November 5, 2021 11:17 AM > To: Zhang, Chen ; Markus Armbruster > > Cc: qemu-dev ; Li Zhijian > > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter- > mirror/redirector > > > 在 2021/11/4 下午1:37, Zhang

[PATCH v4 20/36] bsd-user/arm/target_arch_cpu.h: Implement system call dispatch

2021-11-04 Thread Warner Losh
Implement the system call dispatch. This implements all three kinds of system call: direct and the two indirect variants. It handles all the special cases for thumb as well. Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Rich

[PATCH v4 35/36] bsd-user/freebsd/target_os_ucontext.h: Require TARGET_*CONTEXT_SIZE

2021-11-04 Thread Warner Losh
Now that all architecutres define TARGET_[MU]CONTEXT_SIZE, enforce requiring them and always check the sizeof target_{u,m}context_t sizes. Signed-off-by: Warner Losh --- bsd-user/freebsd/target_os_ucontext.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/bsd-user/freebsd/target_os_ucontext

[PATCH v4 19/36] bsd-user/arm/target_arch_cpu.h: Implement data abort exceptions

2021-11-04 Thread Warner Losh
Implement EXCP_PREFETCH_ABORT AND EXCP_DATA_ABORT. Both of these data exceptions cause a SIGSEGV. Signed-off-by: Kyle Evans Signed-off-by: Olivier Houchard Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arc

[PATCH v4 32/36] bsd-user/arm/target_arch_signal.c: arm get_mcontext

2021-11-04 Thread Warner Losh
Get the machine context from the CPU state. Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Warner Losh --- bsd-user/arm/signal.c | 51 +++ bsd-user/arm/target_arch_signal.h | 1 + 2 files changed, 52 insertions(+) diff --git a/bsd-u

[PATCH v4 18/36] bsd-user/arm/target_arch_cpu.h: Implement trivial EXCP exceptions

2021-11-04 Thread Warner Losh
Implement EXCP_UDEF, EXCP_DEBUG, EXCP_INTERRUPT, EXCP_ATOMIC and EXCP_YIELD. The first two generate a signal to the emulated binary. EXCP_ATOMIC handles atomic operations. The remainder are fancy nops. Signed-off-by: Stacey Son Signed-off-by: Mikaël Urankar Signed-off-by: Kyle Evans Signed-off-

[PATCH v4 29/36] bsd-user/arm/target_arch_signal.h: arm machine context and trapframe for signals

2021-11-04 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_signal.h | 28 1 file changed, 28 insertions(+) diff --git a/bsd-user/arm/target_arch_signal.h b/bsd-user/arm/target_arch_signal.h index 973183d99c..9527335

[PATCH v4 25/36] bsd-user/arm/target_arch_elf.h: arm defines for ELF

2021-11-04 Thread Warner Losh
Basic set of defines needed for arm ELF file activation. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_elf.h | 36 ++ 1 file changed, 36 insertions(+) create mode 100644

[PATCH v4 30/36] bsd-user/arm/target_arch_signal.h: Define size of *context_t

2021-11-04 Thread Warner Losh
Define the native sizes of mcontext_t and ucontext_t so that the tests in target_os_ucontext.h ensure the size of arm's version of these structures is correct. Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_signal.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bsd-user/arm/tar

[PATCH v4 15/36] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions

2021-11-04 Thread Warner Losh
target_arch_cpu.h is for CPU loop definitions. Create the file and define target_cpu_init and target_cpu_reset for arm. Signed-off-by: Olivier Houchard Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_cpu

[PATCH v4 22/36] bsd-user/arm/target_arch_vmparam.h: Parameters for arm address space

2021-11-04 Thread Warner Losh
Various parameters describing the layout of the ARM address space. In addition, define routines to get the stack pointer and to set the second return value. Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --

[PATCH v4 24/36] bsd-user/arm/target_arch_thread.h: Routines to create and switch to a thread

2021-11-04 Thread Warner Losh
Implement target_thread_init (to create a thread) and target_set_upcall (to switch to a thread) for arm. Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Warner Losh Reviewed-by: Kyle Evans --- bsd-user/arm/target_arch_thread.h | 82 +++ 1 file ch

[PATCH v4 34/36] bsd-user/arm/target_arch_signal.c: arm get_ucontext_sigreturn

2021-11-04 Thread Warner Losh
Update ucontext to implement sigreturn. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/arm/signal.c | 9 + bsd-user/arm/target_arch_signal.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/bsd-user/arm/signal.c b/bsd

[PATCH v4 11/36] bsd-user/x86_64: Move functions into signal.c

2021-11-04 Thread Warner Losh
Move the current inline functions into sigal.c. This will increate the flexibility of implementation in the future. Signed-off-by: Warner Losh --- bsd-user/x86_64/signal.c | 56 +++- bsd-user/x86_64/target_arch_signal.h | 43 - 2 files chan

[PATCH v4 17/36] bsd-user/arm/target_arch_cpu.h: Dummy target_cpu_loop implementation

2021-11-04 Thread Warner Losh
Add a boiler plate CPU loop that does nothing except return an error for all traps. Signed-off-by: Sean Bruno Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_cpu.h | 22 ++ 1 file cha

[PATCH v4 13/36] bsd-user/arm/target_syscall.h: Add copyright and update name

2021-11-04 Thread Warner Losh
The preferred name for the 32-bit arm is now armv7. Update the name to reflect that. In addition, add Stacey's copyright to this file and update the include guards to the new convention. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson

[PATCH v4 28/36] bsd-user/arm/target_arch_signal.h: arm specific signal registers and stack

2021-11-04 Thread Warner Losh
Defines for registers and stack layout related to signals. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_signal.h | 57 +++ 1 file changed, 57 insertions(+) create mode 1006

[PATCH v4 16/36] bsd-user/arm/target_arch_cpu.h: Implement target_cpu_clone_regs

2021-11-04 Thread Warner Losh
Implement target_cpu_clone_regs to clone the resister state on a fork. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_cpu.h | 8 1 file changed, 8 insertions(+) diff --git a/bsd-user/arm/target

[PATCH v4 09/36] bsd-user/x86_64/target_arch_signal.h: use new target_os_ucontext.h

2021-11-04 Thread Warner Losh
Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/x86_64/target_arch_signal.h | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/bsd-user/x86_64/target_arch_signal.h b/bsd-user/x86_64/target_arch_signal.h index 55f742b0a8..e84aff948c 100644 --- a/bs

[PATCH v4 21/36] bsd-user/arm/target_arch_reg.h: Implement core dump register copying

2021-11-04 Thread Warner Losh
Implement the register copying routines to extract registers from the cpu for core dump generation. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_reg.h | 60 ++ 1 file ch

[PATCH v4 27/36] bsd-user/arm/target_arch_elf.h: arm get_hwcap2 impl

2021-11-04 Thread Warner Losh
Implement the extended HW capabilities for HWCAP2. Signed-off-by: Kyle Evans Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_elf.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/bsd-user/arm/target_arc

[PATCH v4 10/36] bsd-user/x86_64/target_arch_signal.h: Fill in mcontext_t

2021-11-04 Thread Warner Losh
Fill in target_mcontext match the FreeBSD mcontext_t structure. Also define the size correctly. Signed-off-by: Warner Losh --- bsd-user/x86_64/target_arch_signal.h | 54 1 file changed, 54 insertions(+) diff --git a/bsd-user/x86_64/target_arch_signal.h b/bsd-user/x

[PATCH v4 08/36] bsd-user/x86_64/target_arch_signal.h: Remove target_sigcontext

2021-11-04 Thread Warner Losh
In FreeBSD, sigcontext was retired in favor of ucontext/mcontext. Remove vestigial target_sigcontext. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/x86_64/target_arch_signal.h | 4 1 file changed, 4 deletions(-) diff --git a/bsd-user/x86_64/target_arch_signal.h b

[PATCH v4 12/36] bsd-user/arm/target_arch_sysarch.h: Use consistent include guards

2021-11-04 Thread Warner Losh
As part of upstreaming, the include guards have been made more consistent. Update this file to use the new guards. Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch_sysarch.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-

[PATCH v4 01/36] bsd-user/mips*: Remove

2021-11-04 Thread Warner Losh
FreeBSD has dropped support for mips starting with FreeBSD 14. mips support has been removed from the bsd-user fork because updating it for new signal requirements. Remove it here since it is a distraction. Signed-off-by: Warner Losh --- bsd-user/mips/target_arch_sysarch.h | 69 ---

[PATCH v4 14/36] bsd-user/arm/target_arch_cpu.c: Target specific TLS routines

2021-11-04 Thread Warner Losh
Target specific TLS routines to get and set the TLS values. Signed-off-by: Kyle Evans Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Kyle Evans Reviewed-by: Richard Henderson --- bsd-user/arm/target_arch.h | 28 bsd-user/arm/target_arch_cpu.c |

[PATCH v4 04/36] bsd-user/i386/target_arch_signal.h: Remove target_sigcontext

2021-11-04 Thread Warner Losh
In FreeBSD, sigcontext was retired in favor of ucontext/mcontext. Remove vestigial target_sigcontext. Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/i386/target_arch_signal.h | 4 1 file changed, 4 deletions(-) diff --git a/bsd-user/i386/target_arch_signal.h b/bsd

[PATCH v4 03/36] bsd-user: create a per-arch signal.c file

2021-11-04 Thread Warner Losh
Create a place-holder signal.c file for each of the architectures that are currently built. In the future, some code that's currently inlined in target_arch_signal.h will live here. Signed-off-by: Warner Losh --- bsd-user/i386/signal.c | 1 + bsd-user/x86_64/signal.c | 1 + meson.build

[PATCH v4 06/36] bsd-user/i386/target_arch_signal.h: Update mcontext_t to match FreeBSD

2021-11-04 Thread Warner Losh
Fill in target_mcontext_t to match the FreeBSD mcontex_t. Also tag the current size of mcontext and ucontext to enable size checking for i386. Signed-off-by: Warner Losh --- bsd-user/i386/target_arch_signal.h | 46 ++ 1 file changed, 46 insertions(+) diff --git a/bsd

[PATCH v4 05/36] bsd-user/i386/target_arch_signal.h: use new target_os_ucontext.h

2021-11-04 Thread Warner Losh
Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/i386/target_arch_signal.h | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/bsd-user/i386/target_arch_signal.h b/bsd-user/i386/target_arch_signal.h index e262667bda..bf7263c4f8 100644 --- a/bsd-user

[PATCH v4 07/36] bsd-user/i386: Move the inlines into signal.c

2021-11-04 Thread Warner Losh
Move the (now stubbed out) inlines into bsd-user/i386/signal.c. Signed-off-by: Warner Losh --- bsd-user/i386/signal.c | 56 +- bsd-user/i386/target_arch_signal.h | 43 +-- 2 files changed, 63 insertions(+), 36 deletions(-) diff --git a

[PATCH v4 02/36] bsd-user/freebsd: Create common target_os_ucontext.h file

2021-11-04 Thread Warner Losh
FreeBSD has a MI ucontext structure that contains the MD mcontext machine state and other things that are machine independent. Create an include file for all the ucontext stuff. It needs to be included in the arch specific files after target_mcontext is defined. This is largely copied from sys/_uco

[PATCH v4 00/36] bsd-user: arm (32-bit) support

2021-11-04 Thread Warner Losh
This series of patches brings in 32-bit arm support for bsd-user. It implements all the bits needed to do image activation, signal handling, stack management and threading. This allows us to get to the "Hello World" level. The arm and x86 code are now the same as in the bsd-user fork. For full con

[PATCH] configure: Support modules for Windows

2021-11-04 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- configure | 7 +-- meson.build | 34 -- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 33682cb971..6280e412a9 100755 --- a/configure +++ b/configure @@ -1422,7 +1422,7 @@ cat << EOF

Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-11-04 Thread Jason Wang
在 2021/11/4 下午1:37, Zhang, Chen 写道: I wonder if we need to introduce new parameter, e.g force_vnet_hdr here, then we can always send vnet_hdr when it is enabled. Otherwise the "vnet_hdr_support" seems meaningless. Yes, Current "vnet_hdr_support" default enabled, and vnet_hdr_len already fo

Re: [PATCH v3 00/25] PowerISA v3.1 instruction batch

2021-11-04 Thread David Gibson
On Thu, Nov 04, 2021 at 09:36:54AM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > This patch series implements 56 new instructions for POWER10, moving 28 > "old" instructions to decodetree along the way. The series is divided by > facility as follows: > > - From patch 1 to

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-04 Thread Simon Glass
Hi François, On Tue, 2 Nov 2021 at 10:03, François Ozog wrote: > > Hi Simon, > > On Tue, 2 Nov 2021 at 15:59, Simon Glass wrote: >> >> Hi François, >> >> On Mon, 1 Nov 2021 at 02:53, François Ozog wrote: >> > >> > Hi Simon, >> > >> > this seems a great endeavor. I'd like to better understand th

Re: [PATCH v3 23/29] bsd-user/arm/target_arch_signal.h: arm set_mcontext

2021-11-04 Thread Warner Losh
On Thu, Nov 4, 2021 at 12:43 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/4/21 10:05 AM, Warner Losh wrote: > > +/* > > + * Make sure T mode matches the PC's notion of thumb mode, although > > + * FreeBSD lets the processor sort this out, so we may need remove >

FW: New Defects reported by Coverity Scan for QEMU

2021-11-04 Thread Taylor Simpson
Coverity is getting confused here. The index can never actually overflow. Does Coverity have a pragma or something to tell it it's OK? The loop nest in question is (the index must be < 128) for (int offset = 1; offset < 128; offset <<= 1) { for (int k = 0; k < 128; k++) {

Re: [PATCH] linux-user: Add GPL-2.0+ SPDX license identifier

2021-11-04 Thread Philippe Mathieu-Daudé
On 11/4/21 16:17, Taylor Simpson wrote: >> -Original Message- >> From: Philippe Mathieu-Daudé On >> Behalf Of Philippe Mathieu-Daudé >> Sent: Thursday, November 4, 2021 5:02 AM >> To: Daniel P. Berrangé >> Cc: Taylor Simpson ; Richard Henderson >> ; qemu-devel@nongnu.org; Laurent Vivier >

Re: [PATCH-for-6.2 v2] .mailmap: Fix more contributor entries

2021-11-04 Thread Philippe Mathieu-Daudé
Ping for 6.2? (Patch fully reviewed/acked by affected contributors). On 11/1/21 11:22, Philippe Mathieu-Daudé wrote: > Can this patch go via the Trivial tree? > > On 10/27/21 06:32, Philippe Mathieu-Daudé wrote: >> These authors have some incorrect author email field. >> >> Acked-by: Pan Nengyuan

Re: [PULL 07/20] migration/dirtyrate: implement dirty-ring dirtyrate calculation

2021-11-04 Thread Philippe Mathieu-Daudé
Hi Juan, On 11/1/21 23:08, Juan Quintela wrote: > From: Hyman Huang(黄勇) > > use dirty ring feature to implement dirtyrate calculation. > > introduce mode option in qmp calc_dirty_rate to specify what > method should be used when calculating dirtyrate, either > page-sampling or dirty-ring sh

Re: Qemu and ARM secure state.

2021-11-04 Thread Jean-Christophe DUBOIS
Le 04/11/2021 à 12:11, Peter Maydell a écrit : On Wed, 3 Nov 2021 at 13:27, Jean-Christophe DUBOIS wrote: I have a little application that is designed to work on the i.MX6UL processor. I developed it and tested it on the mcimx6ul-evk platform emulated by Qemu. This application used to work "

Re: [PULL 21/30] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-11-04 Thread Luis Machado
On 10/4/21 3:44 PM, Luis Machado wrote: Hi, On 9/21/21 10:55 AM, Peter Maydell wrote: On Tue, 19 Jan 2021 at 15:57, Alex Bennée wrote: Claudio Fontana writes: On 1/19/21 3:50 PM, Alex Bennée wrote: Claudio Fontana writes: qemu-system-aarch64: -gdb unix:path=/tmp/tmp9ru5tgk8qemu-gdbst

Re: [PATCH v3 19/29] bsd-user/arm/target_arch_signal.h: arm machine context for signals

2021-11-04 Thread Warner Losh
On Thu, Nov 4, 2021 at 11:58 AM Warner Losh wrote: > > > On Thu, Nov 4, 2021 at 11:49 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 11/4/21 10:05 AM, Warner Losh wrote: >> > +typedef struct target_mcontext { >> > +uint32_t__gregs[32]; >> >> sys/arm/include/ucontext

Re: [PULL 04/20] migration/dirtyrate: introduce struct and adjust DirtyRateStat

2021-11-04 Thread Eric Blake
On Mon, Nov 01, 2021 at 11:08:56PM +0100, Juan Quintela wrote: > From: Hyman Huang(黄勇) > > introduce "DirtyRateMeasureMode" to specify what method should be > used to calculate dirty rate, introduce "DirtyRateVcpu" to store > dirty rate for each vcpu. > > use union to store stat data of spec

Re: [PATCH v7 2/2] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation

2021-11-04 Thread Eric Blake
On Tue, Jul 20, 2021 at 11:19:17PM +0800, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > introduce dirty-bitmap mode as the third method of calc-dirty-rate. > implement dirty-bitmap dirtyrate calculation, which can be used > to measuring dirtyrate in the absence of dirty-ring. > > i

Re: [PATCH v2 5/7] hw/nvram: Update at24c EEPROM init function in NPCM7xx boards

2021-11-04 Thread Peter Maydell
On Wed, 3 Nov 2021 at 21:52, Hao Wu wrote: > > Thanks for the comment. I'll upload a new version using IF_OTHER as discussed > in that thread. > > I don't know if adding the assertion for type != IF_NONE is a good idea now > so I didn't add that. > If you think that's good I can add it as well.

Re: [PATCH v4 07/22] docs/devel: document expectations for QAPI data modelling for QMP

2021-11-04 Thread Eric Blake
On Thu, Oct 28, 2021 at 04:54:42PM +0100, Daniel P. Berrangé wrote: > Traditionally we have required that newly added QMP commands will model > any returned data using fine grained QAPI types. This is good for > commands that are intended to be consumed by machines, where clear data > representatio

Re: [PATCH v3 3/3] qapi: deprecate drive-backup

2021-11-04 Thread Eric Blake
On Wed, Nov 03, 2021 at 02:29:12PM +0100, Vladimir Sementsov-Ogievskiy wrote: > Modern way is using blockdev-add + blockdev-backup, which provides a > lot more control on how target is opened. > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Kashyap Chamarthy > --- > docs/abou

Re: [PATCH v3 23/29] bsd-user/arm/target_arch_signal.h: arm set_mcontext

2021-11-04 Thread Richard Henderson
On 11/4/21 10:05 AM, Warner Losh wrote: +/* + * Make sure T mode matches the PC's notion of thumb mode, although + * FreeBSD lets the processor sort this out, so we may need remove + * this check, or generate a signal... + */ +if (!!(tswap32(gr[TARGET_REG_PC]) & 1) != !!(c

Re: [PATCH v3 19/29] bsd-user/arm/target_arch_signal.h: arm machine context for signals

2021-11-04 Thread Warner Losh
On Thu, Nov 4, 2021, 11:58 AM Warner Losh wrote: > > > On Thu, Nov 4, 2021 at 11:49 AM Richard Henderson < > richard.hender...@linaro.org> wrote: > >> On 11/4/21 10:05 AM, Warner Losh wrote: >> > +typedef struct target_mcontext { >> > +uint32_t__gregs[32]; >> >> sys/arm/include/ucontext.h

Re: [PATCH 1/3] sev/i386: Allow launching with -kernel if no OVMF hashes table found

2021-11-04 Thread Daniel P . Berrangé
On Thu, Nov 04, 2021 at 06:18:10PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Mon, Nov 01, 2021 at 10:21:34AM +, Dov Murik wrote: > > > Commit cff03145ed3c ("sev/i386: Introduce sev_add_kernel_loader_hashes > > > for measured linux boot", 202

Re: [PATCH 1/3] sev/i386: Allow launching with -kernel if no OVMF hashes table found

2021-11-04 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Nov 01, 2021 at 10:21:34AM +, Dov Murik wrote: > > Commit cff03145ed3c ("sev/i386: Introduce sev_add_kernel_loader_hashes > > for measured linux boot", 2021-09-30) introduced measured direct boot > > with -kernel, using an OVMF-designa

Re: [PATCH] target-i386: mmu: fix handling of noncanonical virtual addresses

2021-11-04 Thread Mark Cave-Ayland
On 04/11/2021 14:09, Paolo Bonzini wrote: mmu_translate is supposed to return an error code for page faults; it is not able to handle other exceptions. The #GP case for noncanonical virtual addresses is not handled correctly, and incorrectly raised as a page fault with error code 1. Since it c

Re: [PATCH v3 19/29] bsd-user/arm/target_arch_signal.h: arm machine context for signals

2021-11-04 Thread Warner Losh
On Thu, Nov 4, 2021 at 11:49 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/4/21 10:05 AM, Warner Losh wrote: > > +typedef struct target_mcontext { > > +uint32_t__gregs[32]; > > sys/arm/include/ucontext.h has > > #define _NGREG 17 > typedef __greg_t__g

Re: [PATCH v3 19/29] bsd-user/arm/target_arch_signal.h: arm machine context for signals

2021-11-04 Thread Richard Henderson
On 11/4/21 10:05 AM, Warner Losh wrote: +typedef struct target_mcontext { +uint32_t__gregs[32]; sys/arm/include/ucontext.h has #define _NGREG 17 typedef __greg_t__gregset_t[_NGREG]; With s/32/17/ here, Reviewed-by: Richard Henderson r~

Re: [RFC PATCH] tests/docker: force NOUSER=1 for base images

2021-11-04 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 11/3/21 18:13, Alex Bennée wrote: >> As base images are often used to build further images like toolchains >> ensure we don't add the local user by accident. The local user should >> only exist on local images and not anything that gets pushed up to the >> pu

Re: [PATCH v3 07/29] bsd-user/arm/target_arch_cpu.h: Implement trivial EXCP exceptions

2021-11-04 Thread Richard Henderson
On 11/4/21 10:05 AM, Warner Losh wrote: Implement EXCP_UDEF, EXCP_DEBUG, EXCP_INTERRUPT, EXCP_ATOMIC and EXCP_YIELD. The first two generate a signal to the emulated binary. EXCP_ATOMIC handles atomic operations. The remainder are fancy nops. Signed-off-by: Stacey Son Signed-off-by: Mikaël Uranka

Re: [PATCH v3 25/25] target/ppc: cntlzdm/cnttzdm implementation without brcond

2021-11-04 Thread Richard Henderson
On 11/4/21 8:37 AM, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Suggested-by: Richard Henderson Signed-off-by: Matheus Ferst --- target/ppc/translate/fixedpoint-impl.c.inc | 31 +++--- 1 file changed, 16 insertions(+), 15 deletions(-) Reviewed-by: Richard Hender

Re: [PATCH v5] tests: qtest: Add virtio-iommu test

2021-11-04 Thread Eric Auger
Hi Thomas, On 11/2/21 2:34 PM, Thomas Huth wrote: > On 01/11/2021 19.48, Eric Auger wrote: >> Add the framework to test the virtio-iommu-pci device >> and tests exercising the attach/detach, map/unmap API. >> >> Signed-off-by: Eric Auger >> Tested-by: Jean-Philippe Brucker >> Reviewed-by: Jean-Ph

Re: [PATCH v3 05/25] target/ppc: Implement Vector Insert from GPR using GPR index insns

2021-11-04 Thread Richard Henderson
On 11/4/21 8:36 AM, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Implements the following PowerISA v3.1 instructions: vinsblx: Vector Insert Byte from GPR using GPR-specified Left-Index vinshlx: Vector Insert Halfword from GPR using GPR-specified Left-Index vinswlx: Vector Insert Wor

Re: [PATCH v5] tests: qtest: Add virtio-iommu test

2021-11-04 Thread Eric Auger
Hi Thomas, On 11/2/21 1:58 PM, Thomas Huth wrote: > On 01/11/2021 19.48, Eric Auger wrote: >> Add the framework to test the virtio-iommu-pci device >> and tests exercising the attach/detach, map/unmap API. >> >> Signed-off-by: Eric Auger >> Tested-by: Jean-Philippe Brucker >> Reviewed-by: Jean-Ph

Re: [PULL for 6.2 v2 00/19] testing, plugin and gdbstub updates

2021-11-04 Thread Richard Henderson
On 11/4/21 8:16 AM, Alex Bennée wrote: v2, dropped the hexagon toolchain updates which seem to be busted. The following changes since commit b1fd92137e4d485adeec8e9f292f928ff335b76c: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2021-11-03 13:07:30 -0400) a

[PATCH v10 10/10] virtio-pci: add support for configure interrupt

2021-11-04 Thread Cindy Lu
Add support for configure interrupt, The process is used kvm_irqfd_assign to set the gsi to kernel. When the configure notifier was signal by host, qemu will inject a msix interrupt to guest Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 92 -- hw/vi

[PATCH v10 07/10] vhost: add support for configure interrupt

2021-11-04 Thread Cindy Lu
Add functions to support configure interrupt. The configure interrupt process will start in vhost_dev_start and stop in vhost_dev_stop. Also add the functions to support vhost_config_pending and vhost_config_mask, for masked_config_notifier, we only use the notifier saved in vq 0. Signed-off-by:

[PATCH v10 08/10] virtio-net: add support for configure interrupt

2021-11-04 Thread Cindy Lu
Add functions to support configure interrupt in virtio_net The functions are config_pending and config_mask, while this input idx is VIRTIO_CONFIG_IRQ_IDX will check the function of configure interrupt. Signed-off-by: Cindy Lu --- hw/net/vhost_net.c | 9 + hw/net/virtio-net.c |

[PATCH v10 06/10] virtio: add support for configure interrupt

2021-11-04 Thread Cindy Lu
Add the functions to support the configure interrupt in virtio The function virtio_config_guest_notifier_read will notify the guest if there is an configure interrupt. The function virtio_config_set_guest_notifier_fd_handler is to set the fd hander for the notifier Signed-off-by: Cindy Lu --- hw

[PATCH v10 09/10] virtio-mmio: add support for configure interrupt

2021-11-04 Thread Cindy Lu
Add configure interrupt support for virtio-mmio bus. This interrupt will be working while the backend is vhost-vdpa Signed-off-by: Cindy Lu --- hw/virtio/virtio-mmio.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio

[PATCH v10 04/10] vhost: introduce new VhostOps vhost_set_config_call

2021-11-04 Thread Cindy Lu
This patch introduces new VhostOps vhost_set_config_call. This function allows the vhost to set the event fd to kernel Signed-off-by: Cindy Lu --- include/hw/virtio/vhost-backend.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhos

[PATCH v10 05/10] vhost-vdpa: add support for config interrupt

2021-11-04 Thread Cindy Lu
Add new call back function in vhost-vdpa, this function will set the event fd to kernel. This function will be called in the vhost_dev_start and vhost_dev_stop Signed-off-by: Cindy Lu --- hw/virtio/trace-events | 1 + hw/virtio/vhost-vdpa.c | 7 +++ 2 files changed, 8 insertions(+) diff --g

[PATCH v10 03/10] virtio-pci: decouple the single vector from the interrupt process

2021-11-04 Thread Cindy Lu
To reuse the interrupt process in configure interrupt Need to decouple the single vector from the interrupt process. Add new function kvm_virtio_pci_vector_use_one and _release_one. These functions are use for the single vector, the whole process will finish in a loop for the vq number. Signed-of

[PATCH v10 01/10] virtio: introduce macro IRTIO_CONFIG_IRQ_IDX

2021-11-04 Thread Cindy Lu
To support configure interrupt for vhost-vdpa Introduce VIRTIO_CONFIG_IRQ_IDX -1 as configure interrupt's queue index, Then we can reuse the functions guest_notifier_mask and guest_notifier_pending. Add the check of queue index in these drivers, if the driver does not support configure interrupt, t

[PATCH v10 02/10] virtio-pci: decouple notifier from interrupt process

2021-11-04 Thread Cindy Lu
To reuse the notifier process in configure interrupt. Use the virtio_pci_get_notifier function to get the notifier. the INPUT of this function is the IDX, the OUTPUT is notifier and the vector Signed-off-by: Cindy Lu --- hw/virtio/virtio-pci.c | 88 +++--- 1 f

[PATCH v10 00/10]vhost-vdpa: add support for configure interrupt

2021-11-04 Thread Cindy Lu
these patches add the support for configure interrupt These codes are all tested in vp-vdpa (support configure interrupt) vdpa_sim (not support configure interrupt), virtio tap device test in virtio-pci bus and virtio-mmio bus Change in v2: Add support for virtio-mmio bus active the notifier whi

Re: [PATCH v3 03/12] vfio-user: define vfio-user-server object

2021-11-04 Thread Stefan Hajnoczi
On Thu, Nov 04, 2021 at 01:13:02PM +0100, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Fri, Oct 29, 2021 at 02:42:49PM +, Jag Raman wrote: > >> > On Oct 27, 2021, at 11:40 AM, Stefan Hajnoczi > >> > wrote: > >> > On Mon, Oct 11, 2021 at 01:31:08AM -0400, Jagannathan Raman wro

Re: [RFC PATCH 00/12] QOM/QAPI integration part 1

2021-11-04 Thread Damien Hedde
On 11/4/21 10:07, Kevin Wolf wrote: Am 03.11.2021 um 22:26 hat Paolo Bonzini geschrieben: On 11/3/21 18:29, Kevin Wolf wrote: This series adds QOM class definitions to the QAPI schema, introduces a new TypeInfo.instance_config() callback that configures the object at creation time (instead o

Re: [RFC PATCH 00/12] QOM/QAPI integration part 1

2021-11-04 Thread Kevin Wolf
Am 04.11.2021 um 15:49 hat Paolo Bonzini geschrieben: > On 11/4/21 15:26, Kevin Wolf wrote: > > It took me a while to figure out how to deal with this, but I'm quite > > happy with the result. > > I like it too. > > > > > Oh, and I also wanted to say something about why not just directly using >

Re: [PATCH 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

2021-11-04 Thread Łukasz Gieryk
On Wed, Nov 03, 2021 at 01:07:31PM +0100, Klaus Jensen wrote: > On Oct 7 18:24, Lukasz Maniak wrote: > > From: Łukasz Gieryk > > > > With two new properties (sriov_max_vi_per_vf, sriov_max_vq_per_vf) one > > can configure the maximum number of virtual queues and interrupts > > assignable to a si

Re: [PATCH v8 4/8] qmp: add QMP command x-debug-virtio-status

2021-11-04 Thread Markus Armbruster
Jonah Palmer writes: > From: Laurent Vivier > > This new command shows the status of a VirtIODevice, including > its corresponding vhost device status (if active). > > Next patch will improve output by decoding feature bits, including > vhost device's feature bits (backend, protocol, acked, and

[RFC PATCH 3/3] jobs: add job-driver.h

2021-11-04 Thread Emanuele Giuseppe Esposito
job-driver.h contains all functions of job.h that are used by the drivers (JobDriver, BlockJobDriver). These functions are unaware of the job_mutex, so they all take and release the lock internally. No functional change intended. Signed-off-by: Emanuele Giuseppe Esposito --- include/qemu/job-d

[RFC PATCH 1/3] jobs: add job-common.h

2021-11-04 Thread Emanuele Giuseppe Esposito
job-common.h contains all struct and common function that currently are in job.h and will be shared by job-monitor and job-driver in the next commits. Also move job_type() and job_type_str() there, as they are common helper functions. No functional change intended. Signed-off-by: Emanuele Giusep

[RFC PATCH 2/3] jobs: add job-monitor.h

2021-11-04 Thread Emanuele Giuseppe Esposito
job-monitor.h contains all functions of job.h that are used by the monitor and essentially all functions that do not define a JobDriver/Blockdriver. No functional change intended. Signed-off-by: Emanuele Giuseppe Esposito --- include/qemu/job-monitor.h | 282

[RFC PATCH 0/3] job: split job API in driver and monitor

2021-11-04 Thread Emanuele Giuseppe Esposito
In this series, we split the job API in two headers: job-driver.h and job-monitor.h. As explained in job.c, job-monitor are the functions mainly used by the monitor, and require consistency between the search of a specific job (job_get) and the actual operation/action on it (e.g. job_user_cancel).

RE: [PATCH] linux-user: Add GPL-2.0+ SPDX license identifier

2021-11-04 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Thursday, November 4, 2021 5:02 AM > To: Daniel P. Berrangé > Cc: Taylor Simpson ; Richard Henderson > ; qemu-devel@nongnu.org; Laurent Vivier > > Subject: Re: [PATCH] linux-user: Add GPL-

Re: [PATCH v8 3/8] qmp: add QMP command x-debug-query-virtio

2021-11-04 Thread Markus Armbruster
Jonah Palmer writes: > From: Laurent Vivier > > This new command lists all the instances of VirtIODevice with > their QOM paths and virtio type/name. > > Signed-off-by: Jonah Palmer > --- > hw/virtio/meson.build | 2 ++ > hw/virtio/virtio-stub.c| 14 ++ > hw/virtio/virtio.c

  1   2   3   >