"Zhang, Chen" <chen.zh...@intel.com> writes: >> -----Original Message----- >> From: Jason Wang <jasow...@redhat.com> >> Sent: Friday, November 5, 2021 12:03 PM >> To: Zhang, Chen <chen.zh...@intel.com> >> Cc: Markus Armbruster <arm...@redhat.com>; qemu-dev <qemu- >> de...@nongnu.org>; Li Zhijian <lizhij...@cn.fujitsu.com> >> Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for >> filter-mirror/redirector >> >> On Fri, Nov 5, 2021 at 11:27 AM Zhang, Chen <chen.zh...@intel.com> wrote: >> > >> > >> > >> > > -----Original Message----- >> > > From: Jason Wang <jasow...@redhat.com> >> > > Sent: Friday, November 5, 2021 11:17 AM >> > > To: Zhang, Chen <chen.zh...@intel.com>; Markus Armbruster >> > > <arm...@redhat.com> >> > > Cc: qemu-dev <qemu-devel@nongnu.org>; Li Zhijian >> > > <lizhij...@cn.fujitsu.com> >> > > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol >> > > for filter- mirror/redirector >> > > >> > > >> > > 在 2021/11/4 下午1:37, Zhang, Chen 写道: >> > > > Hi Jason/Markus, >> > > > >> > > > Rethink about it, How about keep the original "vnet_hdr_support" >> > > > function, And add a new optional parameter "auto_vnet_hdr" for >> > > > filters/compare? >> > > >> > > >> > > It's a way but rethink of the whole thing. I wonder what if we just >> > > enable "vnet_hdr_support" by default for filter and colo-compare? >> > >> > It's works by default for user use -device virtio-net-pci and e1000... >> > But it can't resolve this series motivation, how to fix/check user >> > configuration issue: >> > For example user enable " vnet_hdr_support " filter-mirror and disable >> > " vnet_hdr_support" filter-redirector And connect both filter modules by >> > chardev socket. >> > In this case guest will get wrong network workload and filters didn’t >> > perceive any abnormalities, but in fact, the whole system is no longer >> > working. >> > This series will report error and try to correct it. >> >> The problem is how "auto_vnet_hdr" help in this case. It's a new parameter >> which may lead to more wrong configuration? > > No, the "auto_vnet_hdr" will fix most the wrong configuration issues as > "vnet_hdr_support" correct setting. > When we enable the "auto_vnet_hdr", the original "vnet_hdr_support" will no > effect.
I don't know enough to help much here. What I do know: having to specify an obscure parameter to get a nicer user interface is backwards. Is this the case here?