> On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
>
> On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote:
>>
>>
>>> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>>>
>>> o if there's a need to disable
>>> just one of these, commit log needs to do a better job docum
On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote:
>
>
> > On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
> >
> > o if there's a need to disable
> > just one of these, commit log needs to do a better job documenting the
> > usecase.
>
> The use case is simple. With this featur
On Wed, Apr 29, 2020 at 06:54:52AM +, Ani Sinha wrote:
>
>
> > On Apr 29, 2020, at 12:22 PM, Michael S. Tsirkin wrote:
> >
> > On Wed, Apr 29, 2020 at 06:11:20AM +, Ani Sinha wrote:
> >>
> >>
> >>> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
> >>>
> >>> o if there's a ne
Philippe Mathieu-Daudé writes:
> Running the coccinelle script produced:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h --include-headers \
> --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
> --keep-comments --smpl-spacing --dir .
> HANDLING: ./hw/mips/
Markus Armbruster writes:
> The Error ** argument must be NULL, &error_abort, &error_fatal, or a
> pointer to a variable containing NULL. Passing an argument of the
> latter kind twice without clearing it in between is wrong: if the
> first call sets an error, it no longer points to NULL for the
On Tue, Apr 28, 2020 at 7:26 PM Philippe Mathieu-Daudé wrote:
>
> MIDR_EL1 a 64-bit system register with the top 32-bit being RES0.
>
> This fixes when compiling with -Werror=conversion:
>
> target/arm/cpu64.c: In function ‘aarch64_max_initfn’:
> target/arm/cpu64.c:628:21: error: conversion fr
Philippe Mathieu-Daudé writes:
> Patch created mechanically by running:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h \
> --include-headers --keep-comments --in-place \
> --sp-file \
> scripts/coccinelle/use-error_abort-in-instance_init.cocci
>
> Reviewed-by: Cédric
On Tue, 28 Apr 2020 16:13:05 -0400
Stefan Berger wrote:
> On 4/28/20 6:38 AM, Cornelia Huck wrote:
> > On Mon, 27 Apr 2020 16:31:43 +0200
> > Eric Auger wrote:
> >
> >> Instead of using a compat in the mach-virt machine to force
> >> PPI off for all virt machines (PPI not supported by the
> >>
Instead of just relying on the comment "Called only on full-dirty
region" in block_copy_task_create() let's move initial dirty area
search directly to block_copy_task_create(). Let's also use effective
bdrv_dirty_bitmap_next_dirty_area instead of looping through all
non-dirty clusters.
Signed-off-
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>
> o if there's a need to disable
> just one of these, commit log needs to do a better job documenting the
> usecase.
The use case is simple. With this feature admins will be able to do what they
were forced to do from Windows driver
We are going to use aio-task-pool API, so tasks will be handled in
parallel. We need therefore separate allocated task on each iteration.
Introduce this logic now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/block-copy.c | 18 +++---
1 file changed,
On 4/29/2020 12:22 AM, Joao Martins wrote:
On 4/15/20 4:35 AM, Jingqi Liu wrote:
For device dax (e.g., /dev/dax0.0), the NUM of 'align=NUM' option
needs to match the alignment requirement of the device dax.
It must be larger than or equal to the 'align' of device dax.
Signed-off-by: Jingqi Liu
We are going to use aio-task-pool API, so we'll need state pointer in
BlockCopyTask anyway. Add it now and use where possible.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/block-copy.c | 28 +++-
1 file changed, 15 insertions(+), 13 deleti
Hi all!
v3:
01: drop extra line "+s->in_flight_bytes -= task->bytes - new_bytes;"
02: add Max's r-b
03: rebased on 01 fix (dropped line not updated now). keep Max's r-b
04: more refactoring:
don't require offset argument of block_copy_task_create being dirty,
use !bdrv_dirty_bitmap_n
Run block_copy iterations in parallel in aio tasks.
Changes:
- BlockCopyTask becomes aio task structure. Add zeroes field to pass
it to block_copy_do_copy
- add call state - it's a state of one call of block_copy(), shared
between parallel tasks. For now used only to keep information a
We are going to use aio-task-pool API and extend in-flight request
structure to be a successor of AioTask, so rename things appropriately.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 98 +++---
1 file changed, 48 insertions(+), 50
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 583 +
Philippe Mathieu-Daudé writes:
> Fixes the following coccinelle warnings:
>
> $ spatch --sp-file --verbose-parsing ... \
> scripts/coccinelle/remove_local_err.cocci
> ...
> SUSPICIOUS: a \ character appears outside of a #define at
> ./target/ppc/translate_init.inc.c:5213
[...]
> S
> On Apr 29, 2020, at 10:58 AM, Michael S. Tsirkin wrote:
>
> For example, how about hot-plugging a bridge which doesn't
> support hotplug itself?
So now for every device we want to hot plug, we will add a new bridge? Sounds
not a scalable and elegant idea.
> Would that happen to make windo
Philippe Mathieu-Daudé writes:
> On 4/24/20 9:20 PM, Markus Armbruster wrote:
>> The Error ** argument must be NULL, &error_abort, &error_fatal, or a
>> pointer to a variable containing NULL. Passing an argument of the
>> latter kind twice without clearing it in between is wrong: if the
>> first
David Hildenbrand writes:
> On 24.04.20 21:20, Markus Armbruster wrote:
>> Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API
>> violations" neglected to change visit_end_struct()'s Error ** argument
>> along with the others. If visit_end_struct() failed, we'd take the
>
> s/vi
Paul Durrant writes:
>> -Original Message-
>> From: Markus Armbruster
>> Sent: 24 April 2020 20:20
>> To: qemu-devel@nongnu.org
>> Cc: Stefano Stabellini ; Anthony Perard
>> ; Paul
>> Durrant ; Gerd Hoffmann ;
>> xen-de...@lists.xenproject.org
>> Subject: [PATCH 02/11] xen: Fix and imp
BALATON Zoltan writes:
> On Fri, 24 Apr 2020, Markus Armbruster wrote:
>> BALATON Zoltan writes:
>>> On Tue, 21 Apr 2020, Markus Armbruster wrote:
BALATON Zoltan writes:
> On Mon, 20 Apr 2020, Markus Armbruster wrote:
>> The Error ** argument must be NULL, &error_abort, &error_fata
On Apr 22 13:01, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Changes since v3
>
> * Remove the addition of a new PROPERTIES macro in "nvme: move device
> parameters to separate struct" (Philippe)
>
> * Add NVME_PMR_BIR constant and use it in PMR setup.
>
> * Split "nvme: fac
> -Original Message-
> From: Lukas Straub
> Sent: Monday, April 27, 2020 3:22 PM
> To: Zhang, Chen
> Cc: qemu-devel ; Li Zhijian
> ; Jason Wang ; Marc-
> André Lureau ; Paolo Bonzini
>
> Subject: Re: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in
> compare_chr_send
>
> On Mon, 27
On Wed, Apr 29, 2020 at 06:28:46AM +0530, Ani Sinha wrote:
> Well there were several discussions in the other thread around how PCIE
> behaves
> and how we can't change the slot features without a HW reset. Those were
> useful
> inputs.
OK so I'd expect these to be addressed in some way. If we c
29.04.2020 0:33, Eric Blake wrote:
On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
v1 was "[RFC 0/3] 64bit block-layer part I", please refer to initial
cover-letter
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg08723.html
for motivation.
v2:
patch 02 is unchanged,
BALATON Zoltan writes:
> On Tue, 21 Apr 2020, Markus Armbruster wrote:
>> BALATON Zoltan writes:
>>> On Mon, 20 Apr 2020, Markus Armbruster wrote:
Requesting 32 or 64 MiB of RAM with the sam460ex machine type produces
a useless warning:
qemu-system-ppc: warning: Memory siz
This was indeed caused by libvirt starting to use -blockdev. The issue
is that qemu's 'auto-read-only' property which is used by libvirt for
the backing files doesn't properly work if the 'host_device' backend
encounters a read-only LV.
The above situation also happens if you have an read-only LV
29.04.2020 1:09, Eric Blake wrote:
On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote:
The function is called from 64bit io handlers, and bytes is just passed
to throttle_account() which is 64bit too (unsigned though). So, let's
convert intermediate argument to 64bit too.
My audit for this
Masahiro Yamada writes:
> The second argument 'id' is a pointer. Pass NULL rather than 0.
>
> Signed-off-by: Masahiro Yamada
Reviewed-by: Markus Armbruster
and queued, thanks!
A quick check by checkpatch.pl, pretty straightforward to fix.
ERROR: return is not a function, parentheses are not required
#211: FILE: hw/misc/ivshmem2.c:138:
+return (ivs->features & (1 << feature));
ERROR: memory barrier without comment
#255: FILE: hw/misc/ivshmem2.c:182:
+smp_mb();
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1862986
Title:
qemu-s390x
A quick check by checkpatch.pl, pretty straightforward to fix.
ERROR: memory barrier without comment
#205: FILE: contrib/ivshmem2-server/ivshmem2-server.c:106:
+smp_mb();
ERROR: spaces required around that '*' (ctx:VxV)
#753: FILE: contrib/ivshmem2-server/main.c:22:
+#define IVSHMEM_SERVER_DE
Hi, All,
Did a test for these patches, all looked fine.
Test environment:
Host: opensuse tumbleweed + latest upstream qemu + these three patches
Guest: opensuse tumbleweed root fs + custom kernel(5.5) + related
uio-ivshmem driver + ivshmem-console/ivshmem-block tools
1. lspci show
00:04.0 Una
Hi, Aleksandar,
I've tried translate.google.com, and documents are available here:
Loongson-3A R1 (Loongson-3A1000)
User Manual Part 1:
http://ftp.godson.ac.cn/lemote/3A1000_p1.pdf
http://ftp.godson.ac.cn/lemote/Loongson3A1000_processor_user_manual_P1.pdf
(Chinese Version)
User Manual Part 2:
http
The current method of getting the vbios is broken - it just isn't working on
any device I've tested - the reason
for this is explained in the previous patch. The vbios is polymorphic and
getting a proper unmodified copy is
often not possible without reverse engineering the firmware. We don't need
This patch fixes qemu crashes when passing through an IGD device to HVM guests
under XEN. The problem is that on almost every laptop
reading the IGD ROM from SYSFS will fail, the reason for it is that the IGD rom
is polymorphic and it modifies itself
during bootup - this results in an invalid rom
This is the v1 cover letter - the patches now include a detailed description of
the changes.
Hi,
This patch series is a small subset of a bigger patch set spanning few projects
aiming to isolate the GPU
in QUBES OS to a dedicated security domain. I'm doing this together with 3
colleagues as pa
Patchew URL: https://patchew.org/QEMU/20200428202905.770727-1-ebl...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#
Patchew URL: https://patchew.org/QEMU/20200428202905.770727-1-ebl...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
Hi, Philippe and Aleksandar,
I'm not refusing to change my patch, but I have two questions:
1, Why we should identify Loongson-3 to deliver IP3? It seems that
deliver all IPs (IP2~IP7) unconditionally is harmless as well.
2, How to identify Loongson-3 by Config6/Config7? Loongson-3 is not
the only
On Tue, Apr 28, 2020 at 06:34:18PM +0200, Markus Armbruster wrote:
> chassis_from_bus() uses object_property_get_uint() to get property
> "chassis_nr" of the bridge device. Failure would be a programming
> error. Pass &error_abort, and simplify its callers.
>
> Cc: David Gibson
> Cc: qemu-...@n
Hi, Aleksandr,
On Wed, Apr 29, 2020 at 3:23 AM Aleksandar Markovic
wrote:
>
> Hi. Huacei.
>
> Please expand commit message with the description of the machine
> internal organization (several paragraphs).
>
> Also, please include command line for starting the machine. More than
> one example is b
Hi, Aleksandar,
On Wed, Apr 29, 2020 at 3:10 AM Aleksandar Markovic
wrote:
>
> пон, 27. апр 2020. у 11:36 Huacai Chen је написао/ла:
> >
> > Add more CP0 register for save/restore, including: EBase, XContext,
> > PageGrain, PWBase, PWSize, PWField, PWCtl, Config*, KScratch1~KScratch6.
> >
> > Si
On Wed, Apr 29, 2020 at 2:15 AM Michael S. Tsirkin wrote:
> On Tue, Apr 28, 2020 at 10:10:18PM +0530, Ani Sinha wrote:
> >
> >
> > On Tue, Apr 28, 2020 at 9:51 PM Michael S. Tsirkin
> wrote:
> >
> > On Tue, Apr 28, 2020 at 09:39:16PM +0530, Ani Sinha wrote:
> > >
> > > Ani
> > >
On 04/28/2020 10:51 PM, Dr. David Alan Gilbert wrote:
* Wei Wang (wei.w.w...@intel.com) wrote:
Users may need to check the xbzrle encoding rate to know if the guest
memory is xbzrle encoding-friendly, and dynamically turn off the
encoding if the encoding rate is low.
Signed-off-by: Yi Sun
Sign
Patchew URL: https://patchew.org/QEMU/20200428163419.4483-1-arm...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH 00/17] qom: Spring cleaning
Message-id: 20200428163419.4483-1-arm...@redhat.com
Type: series
=== TEST
Public bug reported:
Found in QEMU 4.1, and reproduced on master.
QEMU appears to suffer from remarkably poor disk performance when
writing to sparse-extent VMDKs. Of course it's to be expected that
allocation takes time and sparse VMDKs peform worse than allocated
VMDKs, but surely not on the or
On Tue 28 Apr 2020 11:38:07 PM CEST, Eric Blake wrote:
> It's been a while since we got rid of the sector-based bdrv_read and
> bdrv_write (commit 2e11d756); let's finish the job on a few remaining
> comments.
>
> Signed-off-by: Eric Blake
Reviewed-by: Alberto Garcia
Berto
On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote:
The function is called from 64bit io handlers, and bytes is just passed
to throttle_account() which is 64bit too (unsigned though). So, let's
convert intermediate argument to 64bit too.
My audit for this patch:
Caller has 32-bit, this pat
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of
the QEMU 5.0.0 release. This release contains 2800+ commits from 232
authors.
You can grab the tarball from our download page here:
https://www.qemu.org/download/#source
The full list of changes are available at:
h
It's been a while since we got rid of the sector-based bdrv_read and
bdrv_write (commit 2e11d756); let's finish the job on a few remaining
comments.
Signed-off-by: Eric Blake
---
Hmm - I started this in Nov 2018, and just barely noticed that it has
been sitting in a stale tree on my disk for a w
On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
v1 was "[RFC 0/3] 64bit block-layer part I", please refer to initial
cover-letter
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg08723.html
for motivation.
v2:
patch 02 is unchanged, add Stefan's r-b. Everything other i
On 4/28/20 3:00 PM, Denis Plotnikov wrote:
The test checks fulfilling qcow2 requirements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Tested-by: Vladimir Sementsov-Ogievskiy
---
Reviewed-by:
On 4/28/20 3:00 PM, Denis Plotnikov wrote:
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment, is the only compression
method available.
The performance
On Tue, Apr 28, 2020 at 05:33:08PM +0100, Daniel P. Berrangé wrote:
> On Tue, Apr 28, 2020 at 12:30:53PM -0400, Michael S. Tsirkin wrote:
> > On Tue, Apr 28, 2020 at 05:28:36PM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Apr 28, 2020 at 12:05:47PM -0400, Michael S. Tsirkin wrote:
> > > > On Tue,
On Tue, Apr 28, 2020 at 10:10:18PM +0530, Ani Sinha wrote:
>
>
> On Tue, Apr 28, 2020 at 9:51 PM Michael S. Tsirkin wrote:
>
> On Tue, Apr 28, 2020 at 09:39:16PM +0530, Ani Sinha wrote:
> >
> > Ani
> > On Apr 28, 2020, 21:35 +0530, Michael S. Tsirkin ,
> wrote:
> >
> >
Now that there are no clients of bdrv_has_zero_init_truncate, none of
the drivers need to worry about providing it.
What's more, this eliminates a source of some confusion: a literal
reading of the documentation as written in ceaca56f and implemented in
commit 1dcaf527 claims that a driver which r
Patchew URL:
https://patchew.org/QEMU/20200428171633.17487-1-alex.ben...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [RFC PATCH] plugins: new lockstep plugin for debugging TCG changes
Message-id: 20200428171633.17487-1-
The parallels driver tries to use truncation for image growth, but can
only do so when reads are guaranteed as zero. Now that we have a way
to request zero contents from truncation, we can defer the decision to
actual allocation attempts rather than up front, reducing the number
of places that sti
Our .bdrv_has_zero_init_truncate can detect when the remote side
always zero fills; we can reuse that same knowledge to implement
BDRV_REQ_ZERO_WRITE by ignoring it when the server gives it to us for
free.
Signed-off-by: Eric Blake
---
block/ssh.c | 4
1 file changed, 4 insertions(+)
diff
The vhdx driver uses truncation for image growth, with a special case
for blocks that already read as zero but which are only being
partially written. But with a bit of rearranging, it's just as easy
to defer the decision on whether truncation resulted in zeroes to the
actual allocation attempt, r
Our .bdrv_has_zero_init_truncate returns 1 if we detect that the OS
always 0-fills; we can use that same knowledge to implement
BDRV_REQ_ZERO_WRITE by ignoring it when the OS gives it to us for
free.
Signed-off-by: Eric Blake
---
block/nfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a
Our .bdrv_has_zero_init_truncate always returns 1 because rbd always
0-fills; we can use that same knowledge to implement
BDRV_REQ_ZERO_WRITE by ignoring it.
Signed-off-by: Eric Blake
---
block/rbd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index f2d52091c
block.c already defaults to 0 if we don't provide a callback; there's
no need to write a callback that always fails.
Signed-off-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block/gluster.c | 14 --
1 file changed, 14 deletions(-)
diff --
Our .bdrv_has_zero_init_truncate always returns 1 because sheepdog
always 0-fills; we can use that same knowledge to implement
BDRV_REQ_ZERO_WRITE by ignoring it.
Signed-off-by: Eric Blake
---
block/sheepdog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/sheepdog.c b/block/sheepdog.
When using bdrv_file, .bdrv_has_zero_init_truncate always returns 1;
therefore, we can behave just like file-posix, and always implement
BDRV_REQ_ZERO_WRITE by ignoring it since the OS gives it to us for
free (note that file-posix.c had to use an 'if' because it shared code
between regular files an
Based-on: <20200424125448.63318-1-kw...@redhat.com>
[PATCH v7 00/10] block: Fix resize (extending) of short overlays
After reviewing Kevin's work, I questioned if we had a redundancy with
bdrv_has_zero_init_truncate. It turns out we do, and this is the result.
Patch 1 has been previously posted
On 28.04.2020 20:54, Dr. David Alan Gilbert wrote:
* Denis Plotnikov (dplotni...@virtuozzo.com) wrote:
On 27.04.2020 15:14, Dr. David Alan Gilbert wrote:
* Denis Plotnikov (dplotni...@virtuozzo.com) wrote:
The patch adds ability to qemu-file to write the data
asynchronously to improve the
On 4/28/20 6:34 AM, Cornelia Huck wrote:
On Mon, 27 Apr 2020 16:31:44 +0200
Eric Auger wrote:
The tpm-tis-device device does not support PPI. Let's
change the default value for the corresponding property
instead of tricking this latter in the mach-virt machine.
Signed-off-by: Eric Auger
---
On 4/28/20 6:36 AM, Cornelia Huck wrote:
On Mon, 27 Apr 2020 16:31:45 +0200
Eric Auger wrote:
Now that the tpm-tis-device device PPI property is off by default,
we can remove the compat used for the same goal.
Signed-off-by: Eric Auger
---
hw/arm/virt.c | 5 -
1 file changed, 5 deleti
On Tue, Apr 28, 2020 at 04:05:09PM -0400, Peter Xu wrote:
> +/*
> + * Flush all the existing dirty pages to the KVM slot buffers. When
> + * this call returns, we guarantee that all the touched dirty pages
> + * before calling this function have been put into the per-kvmslot
> + * dirty bitmap.
>
On 4/28/20 6:38 AM, Cornelia Huck wrote:
On Mon, 27 Apr 2020 16:31:43 +0200
Eric Auger wrote:
Instead of using a compat in the mach-virt machine to force
PPI off for all virt machines (PPI not supported by the
tpm-tis-device device), let's simply change the default value
in the sysbus device.
Cache it too because we'll reference it more frequently in the future.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
accel/kvm/kvm-all.c | 1 +
include/sysemu/kvm_int.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index d
kvm_physical_sync_dirty_bitmap() calculates the ramblock offset in an
awkward way from the MemoryRegionSection that passed in from the
caller. The truth is for each KVMSlot the ramblock offset never
change for the lifecycle. Cache the ramblock offset for each KVMSlot
into the structure when the K
Provide a helper kvm_slot_get_dirty_log() to make the function
kvm_physical_sync_dirty_bitmap() clearer. We can even cache the as_id
into KVMSlot when it is created, so that we don't even need to pass it
down every time.
Since at it, remove return value of kvm_physical_sync_dirty_bitmap()
because
KVM dirty ring is a new interface to pass over dirty bits from kernel to the
userspace. Instead of using a bitmap for each memory region, the dirty ring
contains an array of dirtied GPAs to fetch (in the form of offset in slots).
For each vcpu there will be one dirty ring that binds to it.
kvm_di
Add a parameter for dirty gfn count for dirty rings. If zero, dirty ring is
disabled. Otherwise dirty ring will be enabled with the per-vcpu gfn count as
specified. If dirty ring cannot be enabled due to unsupported kernel or
illegal parameter, it'll fallback to dirty logging.
By default, dirty
Some of the memory listener may want to do log synchronization without
being able to specify a range of memory to sync but always globally.
Such a memory listener should provide this new method instead of the
log_sync() method.
Obviously we can also achieve similar thing when we put the global
syn
Previously we have two places that will create the per KVMSlot dirty
bitmap:
1. When a newly created KVMSlot has dirty logging enabled,
2. When the first log_sync() happens for a memory slot.
The 2nd case is lazy-init, while the 1st case is not (which is a fix
of what the 2nd case missed).
T
The test checks fulfilling qcow2 requirements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Tested-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/287 | 152 ++
v22:
03: remove assignemnt in if condition
v21:
03:
* remove the loop on compression [Max]
* use designated initializers [Max]
04:
* don't erase user's options [Max]
* use _rm_test_img [Max]
* add unsupported qcow2 options [Max]
v20:
04: fix a number
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be changed only later by image conversion, thus c
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block/qcow2-threads.c | 71 ++
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment, is the only compression
method available.
The performance test results:
Test compresses and decompresse
kvm_vm_ioctl() handles the errno trick already for ioctl() on
returning -1 for errors. Fix this.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
---
accel/kvm/kvm-all.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.
Signed-off-by: Peter Xu
---
include/standard-headers/linux/ethtool.h | 10 +-
.../linux/input-event-codes.h | 5 +-
include/standard-headers/linux/pci_regs.h | 2 +
.../standard-headers/linux/virtio_balloon.h | 1 +
include/standard-headers/linux/virtio_ids.h |
Still RFC. Firstly, the kernel series is mostly stall recently... Secondly, we
still haven't settled on how we should handle the dirty sync in kvm mem
removal. This version is based on the other QEMU series:
"vl: Sync dirty bitmap when system resets"
Another major change of this series is tha
System resets will also reset system memory layout. Although the memory layout
after the reset should probably the same as before the reset, we still need to
do frequent memory section removals and additions during the reset process.
Those operations could accidentally lose per-mem-section informa
28.04.2020 19:46, Vladimir Sementsov-Ogievskiy wrote:
28.04.2020 19:18, Eric Blake wrote:
On 4/28/20 10:13 AM, Vladimir Sementsov-Ogievskiy wrote:
Hm. I could imagine that there are formats that have non-zero holes
(e.g. 0xff or just garbage). It would be a bit wrong for them to return
ZERO
Export a helper globally to check whether we're during a precopy.
Signed-off-by: Peter Xu
---
include/migration/misc.h | 1 +
migration/migration.c| 7 +++
2 files changed, 8 insertions(+)
diff --git a/include/migration/misc.h b/include/migration/misc.h
index e338be8c30..b4f6bf7842 1006
With the system reset dirty sync in qemu_system_reset(), we should be able to
drop this operation now. After all it doesn't really fix the problem cleanly
because logically we could still have a race [1].
[1] https://lore.kernel.org/qemu-devel/20200327150425.GJ422390@xz-x1/
Signed-off-by: Peter
Make it usable outside migration. To make it easier to use, remove the
RAMState parameter since after all ram.c has the reference of ram_state
directly from its context.
Signed-off-by: Peter Xu
---
include/migration/misc.h | 1 +
migration/ram.c | 10 +-
2 files changed, 6 ins
This RFC series starts from the fact that we will sync dirty bitmap when
removing a memslot for KVM. IIUC that was majorly to maintain the dirty bitmap
even across a system reboot.
This series wants to move that sync from kvm memslot removal to system reset.
(I still don't know why the reset sys
Our comment did not actually match the code. Rewrite the comment to
be less sensitive to any future changes to qcow2-bitmap.c that might
implement scenarios that we currently reject.
Signed-off-by: Eric Blake
Reviewed-by: Max Reitz
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 de
There are several callers that need to create a new block backend from
an existing BDS; make the task slightly easier with a common helper
routine.
Suggested-by: Max Reitz
Signed-off-by: Eric Blake
Message-Id: <20200424190903.522087-2-ebl...@redhat.com>
[mreitz: Set @ret only in error paths, see
We originally refused to allow resize of images with internal
snapshots because the v2 image format did not require the tracking of
snapshot size, making it impossible to safely revert to a snapshot
with a different size than the current view of the image. But the
snapshot size tracking was rectif
Re-posting this to make Max' life easier when rebasing on top of Kevin's work.
Based-on: <20200424125448.63318-1-kw...@redhat.com>
[PATCH v7 00/10] block: Fix resize (extending) of short overlays
In v4:
- patch 1: fold in Max's touchups to my v3
- patch 1: resolve merge conflict on top of Kevin's
Hi. Huacei.
Please expand commit message with the description of the machine
internal organization (several paragraphs).
Also, please include command line for starting the machine. More than
one example is better than only one.
Specifically, can you explicitly say what is your KVM setup, so that
1 - 100 of 327 matches
Mail list logo
