Patchew URL: https://patchew.org/QEMU/20200428171633.17487-1-alex.ben...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [RFC PATCH] plugins: new lockstep plugin for debugging TCG changes Message-id: 20200428171633.17487-1-alex.ben...@linaro.org Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 608fdd3 plugins: new lockstep plugin for debugging TCG changes === OUTPUT BEGIN === WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 ERROR: do not use C99 // comments #162: FILE: tests/plugin/lockstep.c:122: + // compare and bail ERROR: do not use C99 // comments #168: FILE: tests/plugin/lockstep.c:128: + // mark the execution as complete ERROR: spaces required around that '-' (ctx:VxV) #203: FILE: tests/plugin/lockstep.c:163: + g_strlcpy(sockaddr.sun_path, path, sizeof(sockaddr.sun_path)-1); ^ ERROR: spaces required around that '-' (ctx:VxV) #242: FILE: tests/plugin/lockstep.c:202: + g_strlcpy(sockaddr.sun_path, path, sizeof(sockaddr.sun_path)-1); ^ total: 4 errors, 1 warnings, 251 lines checked Commit 608fdd3a7d7a (plugins: new lockstep plugin for debugging TCG changes) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200428171633.17487-1-alex.ben...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com