On 12.03.2019 3:00, Eric Blake wrote:
> On 3/11/19 1:51 PM, Vladimir Sementsov-Ogievskiy wrote:
>> We already use (we didn't notice it) IN_USE flag for marking bitmap
>> metadata outdated, such as AUTO flag, which mirrors enabled/disabled
>> bitmaps. No we are going to support bitmap resize, so i
On Mon, Mar 11, 2019 at 8:51 PM BALATON Zoltan wrote:
>
> On Mon, 11 Mar 2019, Markus Armbruster wrote:
> > Gerd Hoffmann writes:
> >> From: BALATON Zoltan
> >>
> >> At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI
> >> gfx chip by default (Rage 128 Pro and M6/RV100 respective
Patchew URL:
https://patchew.org/QEMU/1552370960-2061-1-git-send-email-guoh...@huawei.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
When we stop a VM for more than 30 seconds and then resume it, by qemu
monitor command "stop" and "cont", Linux on VM will complain of "soft
lockup - CPU#x stuck for xxs!" as below:
[ 2783.809517] watchdog: BUG: soft lockup - CPU#3 stuck for 2395s!
[ 2783.809559] watchdog: BUG: soft lockup - CPU#2
Gavig left the company sometime ago, cc:ing his gmail.
On 12/03/2019 05:01, Marc-André Lureau wrote:
> Hi Cédric, Gavin,
>
> On Mon, Mar 11, 2019 at 4:23 PM Cédric Le Goater wrote:
>>
>> On 2/13/19 12:03 PM, Marc-André Lureau wrote:
>>> Hi,
>>>
>>> As we are trying to move slirp/ in a standalon
NVIDIA V100 GPUs have on-board RAM which is mapped into the host memory
space and accessible as normal RAM via an NVLink bus. The VFIO-PCI driver
implements special regions for such GPUs and emulates an NVLink bridge.
NVLink2-enabled POWER9 CPUs also provide address translation services
which inclu
On 3/11/19 8:28 PM, Richard Henderson wrote:
> On 3/11/19 12:16 PM, Sven Schnelle wrote:
>> HP-UX (all versions) is losing timer interrupts, which leads to
>> hangs. Pressing a key on the console fixes this, so it looks like
>> QEMU is just looping trough TBs without checking for interrupts.
>> Fur
On Mon, Mar 11, 2019 at 11:52:28AM +0100, Greg Kurz wrote:
> On Sun, 10 Mar 2019 19:26:07 +1100
> David Gibson wrote:
>
> > From: Greg Kurz
> >
> > Commit b8165118f52c broke CPU hotplug tests for old machine types:
> >
> > $ QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 ./tests/cpu-plug-te
On Mon, Mar 11, 2019 at 10:40:54AM +, Alex Bennée wrote:
>
> Peter Maydell writes:
>
> > On Sun, 10 Mar 2019 at 08:27, David Gibson
> > wrote:
> >>
> >> The following changes since commit
> >> f5b4c31030f45293bb4517445722768434829d91:
> >>
> >> Merge remote-tracking branch 'remotes/stef
On Mon, Mar 11, 2019 at 03:07:43PM +0100, Paolo Bonzini wrote:
> On 11/03/19 14:48, Sergio Lopez wrote:
> >> The initialization is O(n^2) because the guest initializes one device at
> >> a time, so you rebuild the FlatView first with 0 devices, then 1, then
> >> 2, etc. This is very hard to fix, i
On 3/11/19 1:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> We are going to allow image resize when there are persistent bitmaps.
> It may lead to appearing of inconsistent bitmaps (IN_USE=1) with
> inconsistent size. But we still want to load them as inconsistent.
>
> Signed-off-by: Vladimir Sement
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> Assume the following sequence:
>
> pitlbe r0(sr0,r0)
> iitlba r4,(sr0,r0)
> ldil L%300,r5
> iitlbp r5,(sr0,r0)
>
> This will purge the whole TLB and add an entry for page 0. However
> the current TLB implementation in helper_iitlba() will store to
>
On Sun, Mar 10, 2019 at 04:06:38PM +, Peter Maydell wrote:
> On Sun, 10 Mar 2019 at 08:27, David Gibson
> wrote:
> >
> > The following changes since commit f5b4c31030f45293bb4517445722768434829d91:
> >
> > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> > into sta
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> Signed-off-by: Sven Schnelle
> ---
> target/hppa/mem_helper.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
At one point this didn't boot linux, but perhaps there was a second bug.
Reviewed-by: Richard Henderson
r~
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> When one of the source registers is the same as the destination register,
> the source register gets overwritten with the destionation value before
> do_add_sv() is called, which leads to unexpection condition matches.
>
> Signed-off-by: Sven Schnelle
>
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> HP ODE use rfi to set the Q bit, and i don't see anything in the
> documentation that this is forbidden. So remove it.
>
> Signed-off-by: Sven Schnelle
> ---
> target/hppa/op_helper.c | 5 -
> 1 file changed, 5 deletions(-)
Reviewed-by: Richard He
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> To ease TLB debugging add a few trace events, which are disabled
> by default so that there's no performance impact.
>
> Signed-off-by: Sven Schnelle
> ---
> Makefile.objs| 1 +
> target/hppa/mem_helper.c | 20 ++--
> targe
On 3/11/19 12:16 PM, Sven Schnelle wrote:
> +/* access_id == 0 means public page and no check is performed */
> +if ((env->psw & PSW_P) && ent->access_id) {
> +wd = 1;
> +
> +if (ent->access_id == (env->cr[CR_PID1] >> 1)) {
> +wd &= env->cr[CR_PID1];
On 3/11/19 12:16 PM, Sven Schnelle wrote:
> The current code assumes that we don't need to exit the TB
> if a Data Cache Flush or Insert has happend. However, as we
> have a shared Data/Instruction TLB, a Data cache flush also
> flushes Instruction TLB entries, and a Data cache TLB insert
> might a
On 3/11/19 12:16 PM, Sven Schnelle wrote:
> HP-UX (all versions) is losing timer interrupts, which leads to
> hangs. Pressing a key on the console fixes this, so it looks like
> QEMU is just looping trough TBs without checking for interrupts.
> Further investion showed that this happens when interr
hi Alex
thanks for your reply.
So, if we choose migration data to be userspace opaque, do you think below
sequence is the right behavior for vendor driver to follow:
1. initially LOGGING state is not set. If userspace calls GET_BUFFER to
vendor driver, vendor driver should reject and return 0.
On 3/11/19 1:51 PM, Vladimir Sementsov-Ogievskiy wrote:
> We already use (we didn't notice it) IN_USE flag for marking bitmap
> metadata outdated, such as AUTO flag, which mirrors enabled/disabled
> bitmaps. No we are going to support bitmap resize, so it's good to
s/No/Now/
> write IN_USE meanin
On 3/11/19 11:50 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> block.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Eric Blake
> diff --git a/block.c b/block.c
> index ccf008c177..e18bd5eefd 100644
> --- a/block.c
> +++ b/block.c
> @@ -3155,14 +3155,12
On 3/11/19 11:50 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/232 | 31 +++
> tests/qemu-iotests/232.out | 20
> 2 files changed, 51 insertions(+)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software
On 3/8/19 9:37 AM, Kevin Wolf wrote:
> tests/virtio-blk-test uses a temporary image file that it deletes while
> QEMU is still running, so it can't be reopened when writers are
> attached or detached. Disable auto-read-only to keep it always writable.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/
On 3/11/19 11:50 AM, Kevin Wolf wrote:
> tests/virtio-blk-test uses a temporary image file that it deletes while
> QEMU is still running, so it can't be reopened when writers are
> attached or detached. Disable auto-read-only to keep it always writable.
>
> Signed-off-by: Kevin Wolf
> ---
> test
> From: Alex Williamson [mailto:alex.william...@redhat.com]
> Sent: Tuesday, March 12, 2019 4:19 AM
> On Mon, 11 Mar 2019 02:33:11 +
> "Tian, Kevin" wrote:
>
[...]
>
> I think I've fully conceded any notion of security by obscurity towards
> opaque data already, but segregating types of devi
> On Mar 11, 2019, at 19:06, Kevin Wolf wrote:
>
> Am 09.03.2019 um 02:46 hat Yaowei Bai geschrieben:
>> Thanks for explaining the background. It comes to my mind that actually we
>> talked about these two cases with Fam a bit long time ago and decided to
>> support both these two cases. The r
The following changes since commit 336cfef495f0cd5b1606251c52628d0372e9a809:
Makefile: Don't install non-sphinx files in sphinx docs install (2019-03-11
11:10:44 +)
are available in the Git repository at:
git://github.com/ehabkost/qemu.git tags/python-next-pull-request
for you to fetch
From: Marc-André Lureau
Commit fcfab7541 ("qmp-shell: learn to send commands with quoted
arguments") introduces the usage of Python 'shlex' to handle quoted
arguments, but it accidentally broke generation of nested JSON
structs.
shlex drops quotes, which breaks parsing of the nested struct.
cmd
> -Original Message-
> From: Stefan Hajnoczi [mailto:stefa...@gmail.com]
> Sent: Monday, March 11, 2019 5:47 PM
> To: Lilijun (Jerry, Cloud Networking)
> Cc: qemu-devel@nongnu.org; wangxin (U)
> ; wangyunjian
>
> Subject: Re: [Qemu-devel] Question about VM inner route entry's lost when
Patchew URL:
https://patchew.org/QEMU/be04b88b-9aac-4348-a165-e115cbe54...@me.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: be04b88b-9aac-4348-a165-e115cbe54...@me.com
Subject: [Qemu-devel] [PATCH] ui/cocoa: Addi
This patch added cocoa_mouse_set() and cocoa_cursor_define(),
supporting virtio-gpu simple rendering on macOS host.
Image content, rect and visibility of the cursor buffer were added as
ivars in QemuCocoaView class. Corresponding accessors were added.
Note that the rect of the cursor was in coord
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> b,gate does GR[t] ← cat(GR[t]{0..29},IAOQ_Front{30..31});
> instead of saving the link address to register t.
>
Quite right. Silly mistake.
> #ifndef CONFIG_USER_ONLY
> +TCGv_reg tmp;
> if (ctx->tb_flags & PSW_C) {
> CPUHPPAState *e
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> The ODE software calls itlbp on existing TLB entries without
> calling itlba first, so this seems to be valid.
>
> Signed-off-by: Sven Schnelle
> ---
> target/hppa/mem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t
Here are three trivial cleanup on argument/variable.
---
v2:
* remove the last one which breaks hotplug
Wei Yang (3):
nvdimm: fix typo in nvdimm_build_nvdimm_devices argument
nvdimm: use *function* directly instead of allocating it again
nvdimm: use NVDIMM_ACPI_IO_LEN for the proper IO si
At the beginning or nvdimm_build_common_dsm(), variable *function* is
already allocated for Arg2.
This patch reuse variable *function* instead of allocating it again.
Signed-off-by: Wei Yang
Reviewed-by: Igor Mammedov
---
hw/acpi/nvdimm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
>From dsm_dma_arrea to dsm_dma_area.
Signed-off-by: Wei Yang
Reviewed-by: Igor Mammedov
---
hw/acpi/nvdimm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index e53b2cb681..39af8cdba8 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdim
The IO range is defined to 4 bytes with NVDIMM_ACPI_IO_LEN, so it is
more proper to use this macro instead of calculating it by sizeof.
Signed-off-by: Wei Yang
Reviewed-by: Igor Mammedov
---
hw/acpi/nvdimm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/nvdimm.c b/
From: Stefan Hajnoczi
Guests started with NVDIMMs larger than the underlying host file produce
confusing errors inside the guest. This happens because the guest
accesses pages beyond the end of the file.
Check the pmem file size on startup and print a clear error message if
the size is invalid.
From: Eric Auger
As NVDIMM support is looming for ARM and SPAPR, let's
move the acpi_nvdimm_state to the generic machine struct
instead of duplicating the same code in several machines.
It is also renamed into nvdimms_state and becomes a pointer.
nvdimm and nvdimm-persistence become generic mach
I'm removing this from the 19.0 blocking tracker. Generally we don't add
bugs to block a release if they were present in the previous release,
additionally there doesn't seem to be any consensus on a solution, at
this moment. If there is a fix implemented I'd be happy to pull that
into a later 19.0
From: Ilya Maximets
If seals are not supported, memfd_create() will fail.
Furthermore, there is no way to disable it in this case because
'.seal' property is not registered.
This issue leads to vhost-user-test failures on RHEL 7.2:
qemu-system-x86_64: -object memory-backend-memfd,id=mem,size=
From: Eric Auger
As we intend to migrate the acpi_nvdimm_state into
the base machine with a new dimms_state name, let's
also rename the datatype.
Signed-off-by: Eric Auger
Suggested-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20190308182053.5487-2-eric.au...@redhat.com>
From: Ilya Maximets
QEMU always sets this flag unconditionally. We need to
check if it's supported.
Signed-off-by: Ilya Maximets
Reviewed-by: Marc-André Lureau
Message-Id: <20190311135850.6537-3-i.maxim...@samsung.com>
Signed-off-by: Eduardo Habkost
---
util/memfd.c | 2 +-
1 file changed, 1
The following changes since commit 336cfef495f0cd5b1606251c52628d0372e9a809:
Makefile: Don't install non-sphinx files in sphinx docs install (2019-03-11
11:10:44 +)
are available in the Git repository at:
git://github.com/ehabkost/qemu.git tags/machine-next-pull-request
for you to fetc
From: Ilya Maximets
qemu_memfd_create() prints the value of 'errno' which is not
set in this case.
Signed-off-by: Ilya Maximets
Reviewed-by: Marc-André Lureau
Message-Id: <20190311135850.6537-4-i.maxim...@samsung.com>
Signed-off-by: Eduardo Habkost
---
util/memfd.c | 1 +
1 file changed, 1 i
On Sat, Mar 02, 2019 at 10:39:47PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/21/19 1:57 AM, Cleber Rosa wrote:
> > +import os
>
> One import is enough :P
>
Oh my... thanks for spotting this.
- Cleber.
From: Ilya Maximets
This gives more information about the failure.
Additionally 'ENOSYS' returned for a non-Linux platforms instead of
'errno', which is not initilaized in this case.
Signed-off-by: Ilya Maximets
Reviewed-by: Marc-André Lureau
Message-Id: <20190311135850.6537-5-i.maxim...@samsu
On Fri, Mar 01, 2019 at 11:55:13AM +0100, Cornelia Huck wrote:
> On Wed, 20 Feb 2019 19:57:46 -0500
> Cleber Rosa wrote:
>
> > The set_console() utility function traditionally adds a device either
> > based on the explicitly given device type, or based on the machine type,
> > a known good type o
Philippe Mathieu-Daudé 于2019年3月10日周日 下午10:34写道：
> On 3/10/19 12:34 PM, Li Qiang wrote:
> > Fixes: 2dbfadf
>
> ^ Please keep tags together (with Signed-off-by, ...)
>
> > Spotted by ASAN when 'make check'.
>
> I'm not native English speaker but I'd say:
>
>
Thanks your advice.
Hope the maintain
On 3/11/19 12:15 PM, Sven Schnelle wrote:
> +static bool trans_diag(DisasContext *ctx, arg_diag *a)
> +{
> +qemu_log_mask(LOG_UNIMP, "DIAG opcode ignored\n");
> +return true;
This needs to free the nullify condition, as with trans_nop.
I've fixed this up while applying.
r~
On Sat, Mar 02, 2019 at 10:43:52PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/21/19 1:57 AM, Cleber Rosa wrote:
> > When running on very low powered environments, some tests may time out
> > causing false negatives. As a conservative change, and for
> > considering that human time (investigating
On Sat, Mar 02, 2019 at 10:42:13PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/21/19 1:57 AM, Cleber Rosa wrote:
> > To the stock Fedora 29 kernel, from the Fedora 28. New tests will be
>
> [Update] to ... ?
>
Right... I used this line as a continuation of the commit title,
but probably shouldn'
On Fri, Mar 01, 2019 at 11:41:44AM +0100, Cornelia Huck wrote:
> On Wed, 20 Feb 2019 19:57:42 -0500
> Cleber Rosa wrote:
>
> > To the stock Fedora 29 kernel, from the Fedora 28. New tests will be
> > added using the 29 kernel, so for consistency, let's also update it
> > here.
> >
> > Signed-of
On Fri, Mar 01, 2019 at 11:37:19AM +0100, Cornelia Huck wrote:
> On Wed, 20 Feb 2019 19:57:40 -0500
> Cleber Rosa wrote:
>
> > A test can, optionally, be tagged for one or many architectures. If a
> > test has been tagged for a single architecture, there's a high chance
> > that the test won't r
On Fri, Mar 01, 2019 at 11:27:10AM +0100, Cornelia Huck wrote:
> On Wed, 20 Feb 2019 19:57:38 -0500
> Cleber Rosa wrote:
>
> > It's useful to define the architecture that should be used in
> > situations such as:
> > * the intended target of the QEMU binary to be used on tests
> > * the archite
On Fri, Mar 01, 2019 at 11:32:27AM +0100, Cornelia Huck wrote:
> On Wed, 20 Feb 2019 19:57:39 -0500
> Cleber Rosa wrote:
>
> > Currently, the only test that contains some target architecture
> > information is "boot_linux_console.py" which test contains a "x86_64"
>
> But there are two others ch
Peter Maydell writes:
...
>> Ok, this is easier. Now, I know what you are referring to
>> instead of guessing what and how I should be explainng.
>>
>> What you said is essentially correct. When deleting a
>> single object that's a file, the return value would either
>> be OK or STORE_READ_ONLY.
>
This adds a handler for ibm,get-vpd RTAS calls, allowing pseries guest
to collect host information. It is disabled by default to avoid unwanted
information leakage. To enable it, use:
‘-M pseries,host-serial={passthrough|string},host-model={passthrough|string}’
Only the SE and TM keywords are ret
Here are two patches to add a handler for ibm,get-vpd RTAS calls.
This RTAS exposes host information in case of set QEMU options
'host-serial' and 'host-model' as 'passthrough'.
The patch 1 creates helper functions to get valid 'host-serial'
and 'host-model' parameters, guided by QEMU command line
The pseries options 'host-serial' and 'host-model' accepts
'none', 'passthrough', or content. The helper
functions in this commit return a valid host field based on
user options.
Signed-off-by: Maxiwell S. Garcia
---
hw/ppc/spapr.c | 58 ++
includ
QOMification left parameter @qdev unused in pflash_cfi01_register()
and pflash_cfi02_register(). All callers pass NULL. Remove.
Signed-off-by: Markus Armbruster
Reviewed-by: Laszlo Ersek
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
Tested-by: Philippe Mathieu-Daudé
Message-I
Our pflash devices are simplistically modelled has having
"num-blocks" sectors of equal size "sector-length". Real hardware
commonly has sectors of different sizes. How our "sector-length"
property is related to the physical device's multiple sector sizes
is unclear.
Helper functions pflash_cfi0
On Mon, Mar 11, 2019 at 06:08:10PM +0100, Marc-André Lureau wrote:
>Hi
>
>On Mon, Mar 11, 2019 at 9:34 AM Wei Yang wrote:
>>
>> Function object_new_with_propv already get the Type of the object, so we
>> could leverage object_new_with_type here.
>>
>> [make check test pass]
>>
>> Signed-off-by: We
The PC machines put firmware in ROM by default. To get it put into
flash memory (required by OVMF), you have to use -drive
if=pflash,unit=0,... and optionally -drive if=pflash,unit=1,...
Why two -drive? This permits setting up one part of the flash memory
read-only, and the other part read/write
On Mon, Mar 11, 2019 at 02:42:58PM +0100, Paolo Bonzini wrote:
>On 11/03/19 06:42, Wei Yang wrote:
>> flatview_add_to_dispatch() registers page based on the condition of
>> *section*, which may looks like this:
>>
>> |s|PPP|s|
>>
>> where s stands for subpage and P for page.
>>
>> The pr
From: Philippe Mathieu-Daudé
The 'bios_size' variable is only used in the 'if (!kernel_filename &&
!dinfo)' clause. This is the case when we don't provide -pflash command
line option, and also don't provide a -kernel option. In this case we
will check for the -bios option, or use the default BIOS
From: Philippe Mathieu-Daudé
pc_system_firmware_init() parameter @isapc_ram_fw is PCMachineState
member pci_enabled negated. The next commit will need more of
PCMachineState. To prepare for that, pass a PCMachineState *, and
drop the now redundant parameter @isapc_ram_fw.
Signed-off-by: Markus
pflash_cfi01_register() takes a size in bytes, a block size in bytes
and a number of blocks. mips_malta_init() passes BIOS_SIZE, 65536,
FLASH_SIZE >> 16. Actually consistent only because BIOS_SIZE (defined
in include/hw/mips/bios.h as (4 * MiB)) matches FLASH_SIZE (defined
locally as 0x40).
From: Philippe Mathieu-Daudé
Add an helper to access the opaque struct PFlashCFI01.
Signed-off-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Laszlo Ersek
Message-Id: <20190308131445.17502-9-arm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
---
hw/block/pflash_cfi
The previous commit added a way to configure firmware with -blockdev
rather than -drive if=pflash. Document it as the preferred way.
Signed-off-by: Markus Armbruster
Message-Id: <20190308131445.17502-13-arm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Laszlo Ersek
---
docs/inte
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20190308131445.17502-7-arm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
---
vl.c | 74 ++--
1 file changed, 42 insertions(+), 32 deletions(-)
diff --git a
main() registers the user's -global only after we create the machine
object, i.e. too late for devices created in the machine's
.instance_init().
Fortunately, we know the bug is only latent: the commit before
previous fixed a bug that would've crashed any attempt to create a
device in an .instance
pflash_cfi01.c and pflash_cfi02.c start their identifiers with
pflash_cfi01_ and pflash_cfi02_ respectively, except for
CFI_PFLASH01(), TYPE_CFI_PFLASH01, CFI_PFLASH02(), TYPE_CFI_PFLASH02.
Rename for consistency.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Markus Armbruster
Reviewed-by:
The disabled DEBUG_BOARD_INIT code goes back to the initial commit
1a6c0886203, and has since seen only mechanical updates. It sure
feels like useless clutter now. Delete it.
Suggested-by: Alex Bennée
Signed-off-by: Markus Armbruster
Message-Id: <20190308094610.21210-8-arm...@redhat.com>
Revie
qemu-system-FOO's main() acts on command line arguments in its own
idiosyncratic order. There's not much method to its madness.
Whenever we find a case where one kind of command line argument needs
to refer to something created for another kind later, we rejigger the
order.
Block devices get crea
We have two open-coded copies of macro PFLASH_CFI01(). Move the macro
to the header, so we can ditch the copies. Move PFLASH_CFI02() to the
header for symmetry.
We define macros TYPE_PFLASH_CFI01 and TYPE_PFLASH_CFI02 for type name
strings, then mostly use the strings. If the macros are worth
d
See the previous commit for rationale.
Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20190308131445.17502-3-arm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
---
hw/core/qdev.c | 39 ---
pflash_cfi02_register() takes a size in bytes, a block size in bytes
and a number of blocks. r2d_init() passes FLASH_SIZE, 16 * KiB,
FLASH_SIZE >> 16. Does not compute: size doesn't match block size *
number of blocks. The latter happens to win: FLASH_SIZE / 4,
i.e. 8MiB.
The best information w
From: Philippe Mathieu-Daudé
This structure is not used since commit 6dd2a5c98a.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Laszlo Ersek
Signed-off-by: Markus Armbruster
Message-Id: <20190308131445.17502-10-arm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
---
hw/i386/pc_sysfw.c |
From: Philippe Mathieu-Daudé
Variable fl_sectors is used just once. Since
fl_sectors = bios_size >> 16 and bios_size = FLASH_SIZE there,
we can simply use FLASH_SIZE >> 16, and eliminate variable.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Markus Armbr
The first call of sysbus_get_default() creates the main system bus and
stores it in QOM as "/machine/unattached/sysbus". This must not
happen before main() creates "/machine", or else container_get() would
"helpfully" create it as "container" object, and the real creation of
"/machine" would later
Give the queue head type a name: BlockdevOptionsQueue.
Rename the queue entry type from BlockdevOptions_queue to
BlockdevOptionsQueueEntry.
Signed-off-by: Markus Armbruster
Message-Id: <20190308131445.17502-6-arm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Philippe Mathieu-Daudé
Compatibility properties started life as a qdev property thing: we
supported them only for qdev properties, and implemented them with the
machinery backing command line option -global.
Recent commit fa0cb34d221 put them to use (tacitly) with memory
backend objects (subtypes of TYPE_MEMORY_BACKEND)
The following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2019-03-11 18:26:37 +)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-pflash-2019-03-11
for yo
flash.h's incomplete struct pflash_t is completed both in
pflash_cfi01.c and in pflash_cfi02.c. The complete types are
incompatible. This can hide type errors, such as passing a pflash_t
created with pflash_cfi02_register() to pflash_cfi01_get_memory().
Furthermore, POSIX reserves typedef names
Machine "sam460ex" maps its flash memory at address 0xFFF0. When
no image is supplied, its size is 1MiB (0x10), and 512KiB of ROM
get mapped on top of its second half. Else, it's the size of the
image rounded up to the next multiple of 64KiB.
The rounding is actually useless: pflash_cfi0
The debug code under DEBUG_BOARD_INIT doesn't compile:
hw/mips/mips_malta.c:1273:16: error: implicit declaration of function
‘blk_name’; did you mean ‘basename’? [-Werror=implicit-function-declaration]
blk_name(dinfo->bdrv), fl_sectors);
^~~~
Machine "ref405ep" maps its flash memory at address 2^32 - image size.
Image size is rounded up to the next multiple of 64KiB. Useless,
because pflash_cfi02_realize() fails with "failed to read the initial
flash content" unless the rounding is a no-op.
If the image size exceeds 0x8 Bytes, we
When a guest tries to abort "write to buffer" (command 0xE8), we print
"PFLASH: Possible BUG - Write block confirm", then exit(1). Letting
the guest terminate QEMU is not a good idea. Instead, LOG_UNIMP we
screwed up, then reset the device.
Macro PFLASH_BUG() is now unused; delete it.
Suggested
Our implementation of "write to buffer" (command 0xE8) is flawed.
LOG_UNIMP its use, and add some FIXME comments.
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
Message-Id: <20190308094610.21210-4-arm...@redhat.com>
---
hw/block/pflash_cfi01.c | 1
On Mon, 11 Mar 2019, Markus Armbruster wrote:
Mark Cave-Ayland writes:
On 11/03/2019 19:51, BALATON Zoltan wrote:
On Mon, 11 Mar 2019, Markus Armbruster wrote:
Gerd Hoffmann writes:
From: BALATON Zoltan
At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI
gfx chip by defaul
Peter Krempa writes:
> On Mon, Mar 11, 2019 at 15:10:36 -0500, Eric Blake wrote:
>> On 3/11/19 2:59 PM, Peter Krempa wrote:
>>
>> >> auto-read-only was introduced in 3.1, at which point we intentionally
>> >> had sufficiently loose wording to permit (but not require) dynamic state
>> >> checking
Mark Cave-Ayland writes:
> On 11/03/2019 19:51, BALATON Zoltan wrote:
>
>> On Mon, 11 Mar 2019, Markus Armbruster wrote:
>>> Gerd Hoffmann writes:
From: BALATON Zoltan
At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI
gfx chip by default (Rage 128 Pro and M
Hi Shameer,
On 3/8/19 12:42 PM, Shameer Kolothum wrote:
> This initializes the GED device with base memory and irq.
> It also configures ged memory hotplug event and builds the
> corresponding aml code.
>
> But ged irq routing to Guest is not enabled and thus hotplug
> is not yet supported.
>
>
On 2/26/19 5:17 AM, David Gibson wrote:
> On Fri, Feb 22, 2019 at 02:13:22PM +0100, Cédric Le Goater wrote:
>> Instead of switching off the sources, set their state to PENDING to
>> possibly catch a hotplug event occuring while the VM is stopped. At
>> resume, check the previous state and if an int
Στις 2019-03-11 16:34, Pintu Agarwal έγραψε:
Hi,
I have a qemu-arm setup with busybox which I normally use to test my
kernel changes.
I use this command to boot it:
QEMU-ARM$
qemu-system-arm -M vexpress-a9 -m 1024M -kernel
../KERNEL/linux/arch/arm/boot/zImage -dtb
../KERNEL/linux/arch/arm/boot/
Unfortunately the subject of the first message in the v5 of this series
is wrong. I submitted '[PATCH v5 0/10] qemu-binfmt-conf.sh', but it
should have been '[PATCH v5 0/9] qemu-binfmt-conf.sh'.
All of the 9 patches have been properly submitted, but the patchset is
not detected as complete.
Do I
On 2/26/19 2:02 AM, David Gibson wrote:
> On Fri, Feb 22, 2019 at 02:13:16PM +0100, Cédric Le Goater wrote:
>> When the thread interrupt management state is retrieved from the KVM
>> VCPU, word2 is saved under the QEMU XIVE thread context to print out
>> the OS CAM line under the QEMU monitor.
>>
>
1 - 100 of 520 matches
Mail list logo
