Re: [Qemu-devel] seabios serial console vs. sgabios

2017-11-02 Thread Gerd Hoffmann
On Thu, 2017-11-02 at 16:11 +, Daniel P. Berrange wrote: > On Thu, Nov 02, 2017 at 05:04:20PM +0100, Gerd Hoffmann wrote: > >   Hi, > > > > One problem we have with the serial console support in seabios and > > sgabios:  It can happen that both are activated.  We'll go fix that > > in > > qemu

[Qemu-devel] [Bug 1188018] Re: qemu monitor does not suppot rbd "savevm" command

2017-11-02 Thread Thomas Huth
Triaging old bug tickets... has this ever been fixed? Can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH] ioapic/tracing: Remove last DPRINTFs

2017-11-02 Thread Peter Xu
On Thu, Nov 02, 2017 at 06:03:10PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Remove the last few DPRINTFs from hw/intc/ioapic.c and turn > them into tracing. In one case it's a new trace, in the others > it's just adding a parameter to the existing traces. >

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-02 Thread Ladi Prosek
On Thu, Nov 2, 2017 at 3:52 PM, Michael S. Tsirkin wrote: > On Thu, Nov 02, 2017 at 02:31:15PM +0100, Ladi Prosek wrote: >> The statement being removed doesn't change anything as virtio PCI devices >> already >> have Subsystem Vendor ID set to pci_default_sub_vendor_id (0x1af4), same as >> Vendo

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-02 Thread Xiao Guangrong
On 11/03/2017 12:30 AM, Dan Williams wrote: On Thu, Nov 2, 2017 at 1:50 AM, Xiao Guangrong wrote: [..] Yes, the GUID will specifically identify this range as "Virtio Shared Memory" (or whatever name survives after a bikeshed debate). The libnvdimm core then needs to grow a new region type tha

[Qemu-devel] [Bug 1729501] Re: qemu crashes with assertion error `off_cur_end >= off_cur' failed

2017-11-02 Thread Liang Dai
Hi Gerd, Xen toolstack uses 8 MB by default, see: https://github.com/xen-project/xen/blob/staging/tools/libxl/libxl_create.c#L292 Now I change it to 4MB, QEMU command line: /mnt/bin/bin/qemu-system-i386 -xen-domid 38 -chardev socket,id=libxl-cmd,path=/var/run/xen/qmp-libxl-38,server,nowait -no-s

Re: [Qemu-devel] RFC: use case for adding QMP, block jobs & multiple exports to qemu-nbd ?

2017-11-02 Thread Fam Zheng
On Thu, 11/02 12:02, Daniel P. Berrange wrote: > One alternative approach to doing this would be to suggest that we should > instead just spawn qemu-system-x86_64 with '--machine none' and use that > as a replacement for qemu-nbd, since it already has a built-in NBD server > which can do many expor

Re: [Qemu-devel] [PATCH 2/2] nbd/server: add assert to nbd_negotiate_handle_info

2017-11-02 Thread Vladimir Sementsov-Ogievskiy
02.11.2017 21:06, Eric Blake wrote: On 11/01/2017 10:42 AM, Vladimir Sementsov-Ogievskiy wrote: Add an assert here to make last length assignment meaningful and following return without tail dropping obvious. Not quite sure I followed your explanation, which means it's difficult for me to propo

Re: [Qemu-devel] [PATCH 1/2] nbd/server: fix nbd_negotiate_handle_info

2017-11-02 Thread Vladimir Sementsov-Ogievskiy
02.11.2017 20:54, Eric Blake wrote: On 11/01/2017 10:42 AM, Vladimir Sementsov-Ogievskiy wrote: It's best to send a 0/2 cover letter for a series, even when both patches are small, as that helps automation tools. ok. namelen should be here, lenght is unrelated. s/lenght/length/ my etern

Re: [Qemu-devel] ping Re: [PATCH v2 0/5] backup improvements part 1

2017-11-02 Thread Vladimir Sementsov-Ogievskiy
02.11.2017 23:52, John Snow wrote: On 10/31/2017 06:26 AM, Vladimir Sementsov-Ogievskiy wrote: Hey, what about this? Sorry Vladimir, unexpected leave of absence from work. It's at the top of my pile. I invite others to come take a look, too. No problems, thank you. -- Best regards, Vladim

Re: [Qemu-devel] qemu disk use writeback don't take effect in centos 7.2 1511

2017-11-02 Thread Paul Schlacter
latest progress: use centos 7.2 https://cloud.centos.org/centos/7/images/ test version: 1511 1601 1604 1606 1608 >From the above version in turn test, found the previous version 1511 1601 1603 have the problem, The latter two versions 1606 1608 are normal, dont't have the prblem, Normal is cac

Re: [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-11-02 Thread Fam Zheng
On Thu, 11/02 17:02, John Snow wrote: > > > On 10/20/2017 02:53 AM, Ashijeet Acharya wrote: > > > > On Fri, Oct 20, 2017 at 11:58 Fam Zheng > > wrote: > > > > On Mon, 10/09 22:12, Fam Zheng wrote: > > > On Mon, 10/09 18:29, Ashijeet Acharya wrote: > > > > Op

Re: [Qemu-devel] [PATCH v2] hw/display/xenfb: Simulate auto-repeat key events

2017-11-02 Thread Liang Yan
This patch doesn't work here, my test environment actually broke, I am so sorry for the mess! Please just ignore it. On 11/2/17 1:40 PM, Daniel P. Berrange wrote: > On Thu, Nov 02, 2017 at 05:26:50PM +, Peter Maydell wrote: >> On 2 November 2017 at 17:18, Liang Yan wrote: >>> New tigervnc cha

Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.

2017-11-02 Thread jiang.biao2
> On 11/02/2017 12:23 PM, jiang.bi...@zte.com.cn wrote: > > No, :) Just found some of these functions are inline and others are not > > when reading > > the code, the style looks inconsistent. > > > My preference would be to remove them all. Should I commit another patch to do that? :) > > Besid

Re: [Qemu-devel] [RFC PATCH] vl: only display available accelerators

2017-11-02 Thread Eduardo Habkost
On Mon, Oct 30, 2017 at 03:14:59PM -0300, Philippe Mathieu-Daudé wrote: > examples configuring with '--enable-kvm --disable-tcg' > > - before > > $ qemu-system-x86_64 -accel help > Possible accelerators: kvm, xen, hax, tcg > > $ qemu-system-x86_64 -accel tcg > qemu-system-x86_64: -machin

Re: [Qemu-devel] [PATCH v2] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2] cpu-exec: Exit exclusive region on longjmp from step_atomic Type: series Message-id: 1509640536-32160-1-git-send-email-peter.mayd...@linaro.org === TEST SCRIPT BEGIN

[Qemu-devel] [PATCH v7 09/13] xilinx_spips: Add support for zero pumping

2017-11-02 Thread Francisco Iglesias
Add support for zero pumping according to the transfer size register. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 47 --- include/hw/ssi/xilinx_spips.h | 2 ++ 2 files changed, 42 insertions(+), 7 deletions(-) diff --git a/hw/ss

[Qemu-devel] [PATCH v7 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI

2017-11-02 Thread Francisco Iglesias
Add support for 4 byte addresses in the LQSPI and correct LQSPI_CFG_SEP_BUS. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 3a98799..7f0f317 100644 --- a/hw/s

[Qemu-devel] [PATCH v7 12/13] xilinx_spips: Add support for the ZynqMP Generic QSPI

2017-11-02 Thread Francisco Iglesias
Add support for the Zynq Ultrascale MPSoc Generic QSPI. Signed-off-by: Francisco Iglesias --- default-configs/arm-softmmu.mak | 1 + hw/ssi/xilinx_spips.c | 579 include/hw/ssi/xilinx_spips.h | 32 ++- 3 files changed, 564 insertions(+), 48

[Qemu-devel] [PATCH v7 07/13] xilinx_spips: Add support for RX discard and RX drain

2017-11-02 Thread Francisco Iglesias
Add support for the RX discard and RX drain functionality. Also transmit one byte per dummy cycle (to the flash memories) with commands that require these. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 167 +- include/hw/ssi/xilinx_

[Qemu-devel] [PATCH v7 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-11-02 Thread Francisco Iglesias
Add support for the ZynqMP QSPI (consisting of the Generic QSPI and Legacy QSPI) and connect Numonyx n25q512a11 flashes to it. Signed-off-by: Francisco Iglesias Reviewed-by: Alistair Francis --- hw/arm/xlnx-zcu102.c | 23 +++ hw/arm/xlnx-zynqmp.c | 26 +++

[Qemu-devel] [PATCH v7 06/13] xilinx_spips: Update striping to be big-endian bit order

2017-11-02 Thread Francisco Iglesias
Update striping functionality to be big-endian bit order (as according to the Zynq-7000 Technical Reference Manual). Output thereafter the even bits into the flash memory connected to the lower QSPI bus and the odd bits into the flash memory connected to the upper QSPI bus. Signed-off-by: Francisc

[Qemu-devel] [PATCH v7 08/13] xilinx_spips: Make tx/rx_data_bytes more generic and reusable

2017-11-02 Thread Francisco Iglesias
Make tx/rx_data_bytes more generic so they can be reused (when adding support for the Zynqmp Generic QSPI). Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 64 +-- 1 file changed, 37 insertions(+), 27 deletions(-) diff --git a/hw/ssi

[Qemu-devel] [PATCH v7 05/13] xilinx_spips: Move FlashCMD, XilinxQSPIPS and XilinxSPIPSClass

2017-11-02 Thread Francisco Iglesias
Move the FlashCMD enum, XilinxQSPIPS and XilinxSPIPSClass structures to the header for consistency (struct XilinxSPIPS is found there). Also move out a define and remove two dubbel included headers (while touching the code). Finally, add 4 byte address commands to the FlashCMD enum. Signed-off-by:

[Qemu-devel] [PATCH v7 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done

2017-11-02 Thread Francisco Iglesias
Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. Also update interrupts after reading out the interrupt status. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/

[Qemu-devel] [PATCH v7 04/13] m25p80: Add support for n25q512a11 and n25q512a13

2017-11-02 Thread Francisco Iglesias
Add support for Micron (Numonyx) n25q512a11 and n25q512a13 flashes. Signed-off-by: Francisco Iglesias Acked-by: Marcin Krzemiński Reviewed-by: Alistair Francis --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 1d0aa1d..1725e

[Qemu-devel] [PATCH v7 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands

2017-11-02 Thread Francisco Iglesias
Add support for SST READ ID 0x90/0xAB commands for reading out the flash manufacuter ID and device ID. Signed-off-by: Francisco Iglesias Acked-by: Alistair Francis Acked-by: Marcin Krzemiński --- hw/block/m25p80.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/

[Qemu-devel] [PATCH v7 00/13] Add support for the ZynqMP Generic QSPI

2017-11-02 Thread Francisco Iglesias
Hi, This patch series is an attempt to add support for the ZynqMP QSPI (consisting of the Generic QSPI and the legacy QSPI) to the xlnx-zcu102 board and connect Numonyx n25q512a11 flashes to the QSPI. Also some functionality is added to m25p80. The series starts by adding support in m25p80 for c

[Qemu-devel] [PATCH v7 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-11-02 Thread Francisco Iglesias
Add support for continuous read out of the RDSR and READ_FSR status registers until the chip select is deasserted. This feature is supported by amongst others 1 or more flashtypes manufactured by Numonyx (Micron), Windbond, SST, Gigadevice, Eon and Macronix. Signed-off-by: Francisco Iglesias ---

[Qemu-devel] [PATCH v7 03/13] m25p80: Add support for BRRD/BRWR and BULK_ERASE (0x60)

2017-11-02 Thread Francisco Iglesias
Add support for the bank address register access commands (BRRD/BRWR) and the BULK_ERASE (0x60) command. Signed-off-by: Francisco Iglesias Acked-by: Marcin Krzemiński --- hw/block/m25p80.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 9d2

[Qemu-devel] [PATCH v7 09/13] xilinx_spips: Add support for zero pumping

2017-11-02 Thread Francisco Iglesias
Add support for zero pumping according to the transfer size register. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 47 --- include/hw/ssi/xilinx_spips.h | 2 ++ 2 files changed, 42 insertions(+), 7 deletions(-) diff --git a/hw/ss

Re: [Qemu-devel] [PATCH] sockets: Normalize test for addrinfo flag AI_V4MAPPED

2017-11-02 Thread Antonio Huete Jiménez
"Daniel P. Berrange" escribió: On Thu, Nov 02, 2017 at 04:56:29PM +, Antonio Huete Jiménez wrote: From 2b4d9d8cb617445af8f3b062f917dfea42dbdc27 Mon Sep 17 00:00:00 2001 From: Antonio Huete Jimenez Date: Thu, 2 Nov 2017 17:46:24 +0100 Subject: [PATCH] sockets: Normalize test for addrinfo

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-11-02 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.8+dfsg-3ubuntu2.7 --- qemu (1:2.8+dfsg-3ubuntu2.7) zesty; urgency=medium * d/p/ubuntu/virtio-Fix-no-interrupt-when-not-creating-msi-contro.patch: on Arm fix no interrupt when not creating msi controller. That fixes broken networki

[Qemu-devel] [Bug 1719196] Update Released

2017-11-02 Thread Brian Murray
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a reg

Re: [Qemu-devel] [PATCH v6 00/24] make bdrv_get_block_status byte-based

2017-11-02 Thread Eric Blake
On 11/02/2017 04:01 PM, John Snow wrote: >>> The overall conversion currently looks like: >>> part 1: bdrv_is_allocated (merged, commit 51b0a488) >>> part 2: dirty-bitmap (merged, commit ca759622) >>> part 3: bdrv_get_block_status (this series, v5 at [1]) >>> part 4: .bdrv_co_block_status (v3 is p

Re: [Qemu-devel] [PATCH v6 16/25] block: Add 'base-directory' BDS option

2017-11-02 Thread Eric Blake
On 11/02/2017 11:07 AM, Max Reitz wrote: > On 2017-11-02 15:40, Alberto Garcia wrote: >> On Fri 29 Sep 2017 06:53:38 PM CEST, Max Reitz wrote: >>> Using this option, one can directly override what bdrv_dirname() will >>> return. This is useful if one uses e.g. qcow2 on top of quorum (with >>> only

Re: [Qemu-devel] [PATCH v2 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g

2017-11-02 Thread Programmingkid
> On Nov 2, 2017, at 12:06 PM, BALATON Zoltan wrote: > > On Thu, 2 Nov 2017, Programmingkid wrote: >>> On Nov 2, 2017, at 5:10 AM, Peter Maydell wrote: >>> >>> On 5 October 2017 at 15:55, John Arbuckle wrote: Currently the cocoa user interface relys on the user pushing control-alt

[Qemu-devel] [PATCH v3 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g

2017-11-02 Thread John Arbuckle
Currently the cocoa user interface relys on the user pushing control-alt to ungrab the mouse. This is patch changes the key combination to control-alt-g to be in line with the GTK user interface. Signed-off-by: John Arbuckle --- v3 changes - Code is now keyboard layout aware. ui/cocoa.m | 31

[Qemu-devel] [PATCH v3 2/2] ui/cocoa.m: send ctrl-alt key combinations to guest if not used by QEMU

2017-11-02 Thread John Arbuckle
Send control-alt key combinations to the guest if not used by the user interface. Signed-off-by: John Arbuckle --- v3 changes: - Code is now keyboard layout aware v2 changes: - changed logic to use existing if case ui/cocoa.m | 41 - 1 file changed, 20

Re: [Qemu-devel] [Qemu-block] RFC: use case for adding QMP, block jobs & multiple exports to qemu-nbd ?

2017-11-02 Thread Max Reitz
On 2017-11-02 13:02, Daniel P. Berrange wrote: [...] > One alternative approach to doing this would be to suggest that we should > instead just spawn qemu-system-x86_64 with '--machine none' and use that > as a replacement for qemu-nbd, since it already has a built-in NBD server > which can do many

[Qemu-devel] [Bug 1728661] Re: qemu-io segfaults at block/qcow2.h:533

2017-11-02 Thread Max Reitz
Hi, And finally, also here, thanks a lot for reporting this bug! I've found a fix; sending a patch might take a little longer, though... Max -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1728661 T

[Qemu-devel] [Bug 1728643] Re: qemu-io fails with Assertion `*host_offset != 0' failed

2017-11-02 Thread Max Reitz
Hi, Once more, thanks a lot for reporting this bug! I've found a fix and I'll send a patch once I've written a test case. Max -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1728643 Title: qemu-io

[Qemu-devel] [Bug 1728660] Re: qemu-io segfaults at block/io.c:2545

2017-11-02 Thread Max Reitz
Hi, And once again, thanks a lot for reporting this bug! Here, too, I've found a fix and I'll send a patch once I've written a test case. Max -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1728660

[Qemu-devel] [Bug 1728639] Re: qemu-io crashes with SIGSEGV when did -c truncate 320000 on a image_fuzzer image

2017-11-02 Thread Max Reitz
Hi, Thanks a lot for reporting this bug! I've found a fix and I'll send a patch once I've written a test case. Max -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1728639 Title: qemu-io crashes wi

Re: [Qemu-devel] [PATCH v9 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-11-02 Thread John Snow
On 10/20/2017 02:53 AM, Ashijeet Acharya wrote: > > On Fri, Oct 20, 2017 at 11:58 Fam Zheng > wrote: > > On Mon, 10/09 22:12, Fam Zheng wrote: > > On Mon, 10/09 18:29, Ashijeet Acharya wrote: > > > Optimization test results: > > > > > > This patch se

Re: [Qemu-devel] [PATCH v6 00/24] make bdrv_get_block_status byte-based

2017-11-02 Thread John Snow
On 10/20/2017 12:45 PM, Kevin Wolf wrote: > Am 12.10.2017 um 05:46 hat Eric Blake geschrieben: >> There are patches floating around to add NBD_CMD_BLOCK_STATUS, >> but NBD wants to report status on byte granularity (even if the >> reporting will probably be naturally aligned to sectors or even >>

Re: [Qemu-devel] [PATCH] hw/ide/ahci: Move allwinner code into a separate file

2017-11-02 Thread John Snow
On 10/23/2017 02:48 PM, Thomas Huth wrote: > The allwinner code is only needed for the allwinner board (for which > we also have a separate CONFIG_ALLWINNER_A10 config switch), so it > does not make sense that we compile this for all the other boards > that need AHCI, too. Let's move it to a sepa

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch

2017-11-02 Thread John Snow
On 10/23/2017 05:29 AM, Vladimir Sementsov-Ogievskiy wrote: > Snapshot-switch actually changes active state of disk so it should > reflect on dirty bitmaps. Otherwise next incremental backup using > these bitmaps will be invalid. > Good call. I knew that snapshots weren't compatible, but this m

Re: [Qemu-devel] ping Re: [PATCH v2 0/5] backup improvements part 1

2017-11-02 Thread John Snow
On 10/31/2017 06:26 AM, Vladimir Sementsov-Ogievskiy wrote: > Hey, what about this? > Sorry Vladimir, unexpected leave of absence from work. It's at the top of my pile. I invite others to come take a look, too.

Re: [Qemu-devel] [PATCH v2] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Richard Henderson
On 11/02/2017 05:35 PM, Peter Maydell wrote: > Commit ac03ee5331612e44be narrowed the scope of the exclusive > region so it only covers when we're executing the TB, not when > we're generating it. However it missed that there is more than > one execution path out of cpu_tb_exec -- if the atomic ins

Re: [Qemu-devel] [PATCH] Enable 8-byte wide MMIO for 16550 serial devices

2017-11-02 Thread Paolo Bonzini
- Original Message - > From: "Philippe Mathieu-Daudé" > To: "Paolo Bonzini" , "Mike Nawrocki" > , "Avi Kivity" > , "Peter Maydell" , "Konrad > Frederic" > Cc: qemu-devel@nongnu.org, m...@redhat.com > Sent: Thursday, November 2, 2017 8:28:09 PM > Subject: Re: [Qemu-devel] [PATCH] Enabl

Re: [Qemu-devel] [RFC PATCH 13/26] cpus: only take BQL for sleeping threads

2017-11-02 Thread Paolo Bonzini
- Original Message - > From: "David Hildenbrand" > To: "Paolo Bonzini" , "Pavel Dovgalyuk" > , qemu-devel@nongnu.org > Cc: kw...@redhat.com, "peter maydell" , "boost > lists" , > quint...@redhat.com, jasow...@redhat.com, m...@redhat.com, > zuban...@gmail.com, "maria klimushenkova" > ,

Re: [Qemu-devel] [PULL 00/51] tcg queued patches

2017-11-02 Thread Emilio G. Cota
On Thu, Nov 02, 2017 at 13:38:07 +, Peter Maydell wrote: > Maybe we should allow machine models to specify: > * max_cpus (the most they can support; 1 if not set by board, >as in current code) > * min_cpus (the least they can support; 1 if not set by board) > * default_cpus (what you get

Re: [Qemu-devel] [PATCH v2] linux-user: fix is_proc_myself to check the paths via realpath

2017-11-02 Thread Peter Maydell
On 28 October 2017 at 06:14, Eric Blake wrote: > By definition, in linux-user, we ARE using glibc; therefore, you are > free to use all GNU extensions. Don't we also support musl libc? I forget... thanks -- PMM

Re: [Qemu-devel] [PATCH] Enable 8-byte wide MMIO for 16550 serial devices

2017-11-02 Thread Philippe Mathieu-Daudé
Hi Mike, Paolo. >> diff --git a/hw/char/serial.c b/hw/char/serial.c >> index 376bd2f240..c16c19a406 100644 >> --- a/hw/char/serial.c >> +++ b/hw/char/serial.c >> @@ -1005,7 +1005,7 @@ static void serial_mm_write(void *opaque, hwaddr addr, >> uint64_t value, unsigned si

Re: [Qemu-devel] [RFC v5 1/2] virtio: introduce `query-virtio' QMP command

2017-11-02 Thread Eric Blake
On 10/24/2017 12:50 PM, Jan Dakinevich wrote: > The command is intended for gathering virtio information such as status, > feature bits, negotiation status. It is convenient and useful for debug > purpose. > > The commands returns generic virtio information for virtio such as > common feature name

Re: [Qemu-devel] [RFC PATCH 13/26] cpus: only take BQL for sleeping threads

2017-11-02 Thread David Hildenbrand
On 02.11.2017 12:08, Paolo Bonzini wrote: > On 31/10/2017 12:26, Pavel Dovgalyuk wrote: >> From: Alex Bennée >> >> Now the only real need to hold the BQL is for when we sleep on the >> cpu->halt conditional. The lock is actually dropped while the thread >> sleeps so the actual window for contentio

Re: [Qemu-devel] [PATCH v2] linux-user: fix is_proc_myself to check the paths via realpath

2017-11-02 Thread Zach Riggle
Ping. What changes do I need to make to land this? On Sat, Oct 28, 2017 at 12:49 AM Eric Blake wrote: > On 10/27/2017 09:07 PM, Zach Riggle wrote: > > Another case that may be more relevant for general QEMU use, is that the > > current code fails if the software under test has poor path-handling

Re: [Qemu-devel] [PATCH] Enable 8-byte wide MMIO for 16550 serial devices

2017-11-02 Thread Paolo Bonzini
On 31/10/2017 16:24, Mike Nawrocki wrote: > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index 376bd2f240..c16c19a406 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -1005,7 +1005,7 @@ static void serial_mm_write(void *opaque, hwaddr addr, > uint6

Re: [Qemu-devel] [PATCH v2] hw/display/xenfb: Simulate auto-repeat key events

2017-11-02 Thread Liang Yan
On 11/2/17 1:40 PM, Daniel P. Berrange wrote: > On Thu, Nov 02, 2017 at 05:26:50PM +, Peter Maydell wrote: >> On 2 November 2017 at 17:18, Liang Yan wrote: >>> New tigervnc changes the way to send long pressed key, >>> from "down up down up ..." to "down down ... up", it only >>> affects xen

Re: [Qemu-devel] [Qemu-block] RFC: use case for adding QMP, block jobs & multiple exports to qemu-nbd ?

2017-11-02 Thread Paolo Bonzini
On 02/11/2017 13:02, Daniel P. Berrange wrote: > > After all that long background explanation, what I'm wondering is whether > there is any interest / desire to extend qemu-nbd to have more advanced > featureset than simply exporting a single disk image which must be listed > at startup time. > >

Re: [Qemu-devel] [PATCH 2/2] nbd/server: add assert to nbd_negotiate_handle_info

2017-11-02 Thread Eric Blake
On 11/01/2017 10:42 AM, Vladimir Sementsov-Ogievskiy wrote: > Add an assert here to make last length assignment meaningful and > following return without tail dropping obvious. Not quite sure I followed your explanation, which means it's difficult for me to propose an alternative wording. Maybe:

[Qemu-devel] [PATCH] ioapic/tracing: Remove last DPRINTFs

2017-11-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Remove the last few DPRINTFs from hw/intc/ioapic.c and turn them into tracing. In one case it's a new trace, in the others it's just adding a parameter to the existing traces. Signed-off-by: Dr. David Alan Gilbert --- hw/intc/ioapic.c | 17 +++--

Re: [Qemu-devel] [PATCH v2] hw/display/xenfb: Simulate auto-repeat key events

2017-11-02 Thread Liang Yan
Thanks for the reply. On 11/2/17 1:26 PM, Peter Maydell wrote: > On 2 November 2017 at 17:18, Liang Yan wrote: >> New tigervnc changes the way to send long pressed key, >> from "down up down up ..." to "down down ... up", it only >> affects xen pv console mode. I send a patch to latest >> kernel

Re: [Qemu-devel] [PATCH 1/2] nbd/server: fix nbd_negotiate_handle_info

2017-11-02 Thread Eric Blake
On 11/01/2017 10:42 AM, Vladimir Sementsov-Ogievskiy wrote: It's best to send a 0/2 cover letter for a series, even when both patches are small, as that helps automation tools. > namelen should be here, lenght is unrelated. s/lenght/length/ Broken in introduction in commit f37708f6; hence addin

Re: [Qemu-devel] [Qemu-block] RFC: use case for adding QMP, block jobs & multiple exports to qemu-nbd ?

2017-11-02 Thread Eric Blake
On 11/02/2017 12:04 PM, Daniel P. Berrange wrote: > vm-a-disk1.qcow2 open - its just a regular backing file setup. > >> >>> | (format=qcow2, proto=file) >>> | >>> +- vm-a-disk1.qcow2 (qemu-system-XXX) >>> >>> The problem is that many VMs are wanting to use cache-dis

Re: [Qemu-devel] [PATCH] oslib-posix: Use sysctl(2) call to resolve exec_dir on NetBSD

2017-11-02 Thread Kamil Rytarowski
On 02.11.2017 18:29, Peter Maydell wrote: > On 2 November 2017 at 17:27, Kamil Rytarowski wrote: >> On 02.11.2017 17:55, Peter Maydell wrote: >>> It's a shame the BSDs can't agree on a single way to implement this :-( > >> It's better to assume that there is no such entity as a shared BSD code >>

Re: [Qemu-devel] [PATCH 4/4] qcow2: Add iotest for an empty refcount table

2017-11-02 Thread Max Reitz
On 2017-11-01 16:42, Alberto Garcia wrote: > This patch adds a simple iotests in which we try to write to an image > with an empty refcount table (i.e. with all entries set to 0). > > This scenario was already handled by the existing consistency checks, > but we add an explicit test case for compl

Re: [Qemu-devel] [PATCH 3/4] qcow2: Don't open images with header.refcount_table_clusters == 0

2017-11-02 Thread Max Reitz
On 2017-11-01 16:42, Alberto Garcia wrote: > qcow2_do_open() is checking that header.refcount_table_clusters is not > too large, but it doesn't check that it's greater than zero. Apart > from the fact that an image like that is obviously corrupted, trying > to use it crashes QEMU since we end up wi

Re: [Qemu-devel] [PATCH v2] hw/display/xenfb: Simulate auto-repeat key events

2017-11-02 Thread Daniel P. Berrange
On Thu, Nov 02, 2017 at 05:26:50PM +, Peter Maydell wrote: > On 2 November 2017 at 17:18, Liang Yan wrote: > > New tigervnc changes the way to send long pressed key, > > from "down up down up ..." to "down down ... up", it only > > affects xen pv console mode. I send a patch to latest > > kern

Re: [Qemu-devel] [PATCH 2/4] qcow2: Prevent allocating L2 tables at offset 0

2017-11-02 Thread Max Reitz
On 2017-11-01 16:42, Alberto Garcia wrote: > If the refcount data is corrupted then we can end up trying to > allocate a new L2 table at offset 0 in the image, triggering an > assertion in the qcow2 cache that would crash QEMU: > > qcow2_cache_entry_mark_dirty: Assertion `c->entries[i].offset !=

Re: [Qemu-devel] [PATCH] oslib-posix: Use sysctl(2) call to resolve exec_dir on NetBSD

2017-11-02 Thread Peter Maydell
On 2 November 2017 at 17:27, Kamil Rytarowski wrote: > On 02.11.2017 17:55, Peter Maydell wrote: >> It's a shame the BSDs can't agree on a single way to implement this :-( > It's better to assume that there is no such entity as a shared BSD code > in modern BSD Operating Systems. My opinion is to

Re: [Qemu-devel] [PATCH 1/4] qcow2: Prevent allocating refcount blocks at offset 0

2017-11-02 Thread Max Reitz
On 2017-11-01 16:42, Alberto Garcia wrote: > Each entry in the qcow2 cache contains an offset field indicating the > location of the data in the qcow2 image. If the offset is 0 then it > means that the entry contains no data and is available to be used when > needed. > > Because of that it is not

Re: [Qemu-devel] [PATCH v2] hw/display/xenfb: Simulate auto-repeat key events

2017-11-02 Thread Peter Maydell
On 2 November 2017 at 17:18, Liang Yan wrote: > New tigervnc changes the way to send long pressed key, > from "down up down up ..." to "down down ... up", it only > affects xen pv console mode. I send a patch to latest > kernel side, but it may have a fix in qemu backend for > back compatible beca

Re: [Qemu-devel] [PATCH] oslib-posix: Use sysctl(2) call to resolve exec_dir on NetBSD

2017-11-02 Thread Kamil Rytarowski
On 02.11.2017 17:55, Peter Maydell wrote: > On 28 October 2017 at 20:48, Kamil Rytarowski wrote: >> NetBSD 8.0(beta) ships with KERN_PROC_PATHNAME in sysctl(2). >> Older NetBSD versions can use argv[0] parsing fallback. >> >> This code section is partly shared with FreeBSD. >> >> Signed-off-by: Ka

Re: [Qemu-devel] [PATCH 0/4] Misc qcow2 corruption checks

2017-11-02 Thread Max Reitz
On 2017-11-01 16:42, Alberto Garcia wrote: > Misc qcow2 corruption checks > > This series contains a few checks that prevent QEMU from crashing > under some scenarios with corrupted qcow2 images. > > The first patch solves the crash reported here: > > https://bugs.launchpad.net/qemu/+bug/17286

[Qemu-devel] [PATCH v2] hw/display/xenfb: Simulate auto-repeat key events

2017-11-02 Thread Liang Yan
New tigervnc changes the way to send long pressed key, from "down up down up ..." to "down down ... up", it only affects xen pv console mode. I send a patch to latest kernel side, but it may have a fix in qemu backend for back compatible becase guest VMs may use very old kernel. This patch inserts

Re: [Qemu-devel] [PATCH v2] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Emilio G. Cota
On Thu, Nov 02, 2017 at 16:35:36 +, Peter Maydell wrote: > Commit ac03ee5331612e44be narrowed the scope of the exclusive > region so it only covers when we're executing the TB, not when > we're generating it. However it missed that there is more than > one execution path out of cpu_tb_exec -- i

Re: [Qemu-devel] [PATCH 4/7] sdl2: Only accept the hotkeys on the main window

2017-11-02 Thread Jindřich Makovička
This fixes the following case: 1) Ctrl-Alt-2 for console is pressed 2) console pops up and gets focus 3) console receives the Ctrl-Alt-2 keypress event 4) console closes 5) focus returns to the main window 6) main window gets the keypress event 7) goto 2 until the key is released, with 50% chance

[Qemu-devel] [Bug 1725267] Re: armeb regression since qemu version 2.8

2017-11-02 Thread Peter Maydell
https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg00155.html should fix this bug. ** Changed in: qemu Status: New => Incomplete ** Changed in: qemu Status: Incomplete => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH] sockets: Normalize test for addrinfo flag AI_V4MAPPED

2017-11-02 Thread Daniel P. Berrange
On Thu, Nov 02, 2017 at 04:56:29PM +, Antonio Huete Jiménez wrote: > From 2b4d9d8cb617445af8f3b062f917dfea42dbdc27 Mon Sep 17 00:00:00 2001 > From: Antonio Huete Jimenez > Date: Thu, 2 Nov 2017 17:46:24 +0100 > Subject: [PATCH] sockets: Normalize test for addrinfo flag AI_V4MAPPED Can you exp

Re: [Qemu-devel] [PATCH 5/7] sdl2 uses surface relative coordinates

2017-11-02 Thread Jindřich Makovička
Hi, this patch fixes the exact case you mentioned. Currently, with surface size smaller than the window, the pointer is confined to the top left corner when using the absolute mode (-usbdevice tablet). On Wed, Nov 1, 2017 at 11:43 AM Gerd Hoffmann wrote: > Why? > > Also I think this breaks the

Re: [Qemu-devel] [Qemu-block] RFC: use case for adding QMP, block jobs & multiple exports to qemu-nbd ?

2017-11-02 Thread Daniel P. Berrange
On Thu, Nov 02, 2017 at 05:40:28PM +0100, Kashyap Chamarthy wrote: > [Cc: Matt Booth from Nova upstream; so not snipping the email to retain > context for Matt.] > > On Thu, Nov 02, 2017 at 12:02:23PM +, Daniel P. Berrange wrote: > > I've been thinking about a potential design/impl improvement

[Qemu-devel] [PATCH] sockets: Normalize test for addrinfo flag AI_V4MAPPED

2017-11-02 Thread Antonio Huete Jiménez
From 2b4d9d8cb617445af8f3b062f917dfea42dbdc27 Mon Sep 17 00:00:00 2001 From: Antonio Huete Jimenez Date: Thu, 2 Nov 2017 17:46:24 +0100 Subject: [PATCH] sockets: Normalize test for addrinfo flag AI_V4MAPPED Signed-off-by: Antonio Huete Jimenez --- util/qemu-sockets.c | 54 +++

Re: [Qemu-devel] [PATCH] oslib-posix: Use sysctl(2) call to resolve exec_dir on NetBSD

2017-11-02 Thread Peter Maydell
On 28 October 2017 at 20:48, Kamil Rytarowski wrote: > NetBSD 8.0(beta) ships with KERN_PROC_PATHNAME in sysctl(2). > Older NetBSD versions can use argv[0] parsing fallback. > > This code section is partly shared with FreeBSD. > > Signed-off-by: Kamil Rytarowski > --- > util/oslib-posix.c | 11 +

Re: [Qemu-devel] [PATCH v2] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Peter Maydell
On 2 November 2017 at 16:38, wrote: > Checking PATCH 1/1: cpu-exec: Exit exclusive region on longjmp from > step_atomic... > ERROR: Use of volatile is usually wrong: see > Documentation/volatile-considered-harmful.txt > #37: FILE: accel/tcg/cpu-exec.c:237: > +volatile bool in_exclusive_regi

Re: [Qemu-devel] [Qemu-block] RFC: use case for adding QMP, block jobs & multiple exports to qemu-nbd ?

2017-11-02 Thread Kashyap Chamarthy
[Cc: Matt Booth from Nova upstream; so not snipping the email to retain context for Matt.] On Thu, Nov 02, 2017 at 12:02:23PM +, Daniel P. Berrange wrote: > I've been thinking about a potential design/impl improvement for the way > that OpenStack Nova handles disk images when booting virtual m

[Qemu-devel] [PATCH v2] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Peter Maydell
Commit ac03ee5331612e44be narrowed the scope of the exclusive region so it only covers when we're executing the TB, not when we're generating it. However it missed that there is more than one execution path out of cpu_tb_exec -- if the atomic insn causes an exception then the code will longjmp out,

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-02 Thread Dan Williams
On Thu, Nov 2, 2017 at 1:50 AM, Xiao Guangrong wrote: [..] >> Yes, the GUID will specifically identify this range as "Virtio Shared >> Memory" (or whatever name survives after a bikeshed debate). The >> libnvdimm core then needs to grow a new region type that mostly >> behaves the same as a "pmem"

Re: [Qemu-devel] [RFC 0/3] cryptodev: add vhost support

2017-11-02 Thread Zhang, Roy Fan
Hi Gong Lei, How are you? As discussed in KVM Forum, the Vhost User Crypto implementation RFC patchset has been sent to dpdk.org today. Please find the patchset here --Cover letter http://dpdk.org/ml/archives/dev/2017-November/081048.html --Patches http://dpdk.org/dev/patchwork/patch/31115/ ht

Re: [Qemu-devel] [PATCH v6 18/25] block: Add sgfnt_runtime_opts to BlockDriver

2017-11-02 Thread Max Reitz
On 2017-11-02 17:11, Alberto Garcia wrote: > On Fri 29 Sep 2017 06:53:40 PM CEST, Max Reitz wrote: >> QLIST_ENTRY(BlockDriver) list; >> + >> +/* Pointer to a NULL-terminated array of names of significant options >> that >> + * can be specified for bdrv_open(). A significant option is

Re: [Qemu-devel] [PATCH] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Peter Maydell
On 2 November 2017 at 16:00, Alex Bennée wrote: > > Peter Maydell writes: > >> Commit ac03ee5331612e44be narrowed the scope of the exclusive >> region so it only covers when we're executing the TB, not when >> we're generating it. However it missed that there is more than >> one execution path ou

Re: [Qemu-devel] seabios serial console vs. sgabios

2017-11-02 Thread Paolo Bonzini
On 02/11/2017 17:11, Daniel P. Berrange wrote: > Historically libvirt will always use '-device sgabios' if the user has > requested . So if that -device arg is given, I > think QEMU must honour it, which implies QEMU must disable Seabios' > own built-in serial console impl in that scenario. We sh

Re: [Qemu-devel] [PATCH v6 18/25] block: Add sgfnt_runtime_opts to BlockDriver

2017-11-02 Thread Alberto Garcia
On Fri 29 Sep 2017 06:53:40 PM CEST, Max Reitz wrote: > QLIST_ENTRY(BlockDriver) list; > + > +/* Pointer to a NULL-terminated array of names of significant options > that > + * can be specified for bdrv_open(). A significant option is one that > + * changes the data of a BDS. > +

Re: [Qemu-devel] seabios serial console vs. sgabios

2017-11-02 Thread Daniel P. Berrange
On Thu, Nov 02, 2017 at 05:04:20PM +0100, Gerd Hoffmann wrote: > Hi, > > One problem we have with the serial console support in seabios and > sgabios: It can happen that both are activated. We'll go fix that in > qemu, but that'll work for new qemu versions only, not for the old > already rele

Re: [Qemu-devel] [PATCH v2 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g

2017-11-02 Thread Peter Maydell
On 2 November 2017 at 15:20, Programmingkid wrote: >> On Nov 2, 2017, at 5:10 AM, Peter Maydell wrote: >> Testing this I have found that it makes the grab key be >> "ctrl+alt+ the key labelled 'g'", even if in the >> OSX host keyboard mapping that key doesn't produce the >> letter 'g'. This is in

Re: [Qemu-devel] [PATCH v6 16/25] block: Add 'base-directory' BDS option

2017-11-02 Thread Max Reitz
On 2017-11-02 15:40, Alberto Garcia wrote: > On Fri 29 Sep 2017 06:53:38 PM CEST, Max Reitz wrote: >> Using this option, one can directly override what bdrv_dirname() will >> return. This is useful if one uses e.g. qcow2 on top of quorum (with >> only protocol BDSs under the quorum BDS) and wants t

Re: [Qemu-devel] [PATCH v2 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g

2017-11-02 Thread BALATON Zoltan
On Thu, 2 Nov 2017, Programmingkid wrote: On Nov 2, 2017, at 5:10 AM, Peter Maydell wrote: On 5 October 2017 at 15:55, John Arbuckle wrote: Currently the cocoa user interface relys on the user pushing control-alt to ungrab the mouse. This is patch changes the key combination to control-alt-g

Re: [Qemu-devel] [PATCH] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Alex Bennée
Peter Maydell writes: > Commit ac03ee5331612e44be narrowed the scope of the exclusive > region so it only covers when we're executing the TB, not when > we're generating it. However it missed that there is more than > one execution path out of cpu_tb_exec -- if the atomic insn > causes an except

[Qemu-devel] seabios serial console vs. sgabios

2017-11-02 Thread Gerd Hoffmann
Hi, One problem we have with the serial console support in seabios and sgabios: It can happen that both are activated. We'll go fix that in qemu, but that'll work for new qemu versions only, not for the old already released ones. So I think it would be useful if seabios makes sure sgabios and

  1   2   >