Re: [Qemu-devel] [RFC v2 32/33] migration: allow migrate_incoming for paused VM

2017-09-27 Thread Peter Xu
On Fri, Sep 22, 2017 at 09:32:28PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > migrate_incoming command is previously only used when we were providing > > "-incoming defer" in the command line, to defer the incoming migration > > channel creation. > > > > Howev

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 00/20] ARM SMMUv3 Emulation Support

2017-09-27 Thread Linu Cherian
Hi Eric, On Fri Sep 01, 2017 at 07:21:03PM +0200, Eric Auger wrote: > This series implements the emulation code for ARM SMMUv3. > > Changes since v6: > - DPDK testpmd now running on guest with 2 assigned VFs > - Changed the instantiation method: add the following option to > the QEMU command l

Re: [Qemu-devel] [PATCH 6/7] mac_dbdma: change DBDMA_register_channel to a MAC_DBDMA type method

2017-09-27 Thread Mark Cave-Ayland
On 26/09/17 04:47, David Gibson wrote: > On Sun, Sep 24, 2017 at 03:47:45PM +0100, Mark Cave-Ayland wrote: >> Using this we can change the MACIO_IDE instance to register the channel >> itself via a type method instead of requiring a separate >> DBDMA_register_channel() function. >> >> As a consequ

Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via device_add

2017-09-27 Thread Thomas Huth
On 13.09.2017 15:24, David Hildenbrand wrote: > E.g. the following now works: > device_add host-s390-cpu,id=cpu1,core-id=1 Hi David, FYI, this introduced a possibility to crash QEMU with the none machine: $ s390x-softmmu/qemu-system-s390x -M none -nographic QEMU 2.10.50 monitor - type 'help

Re: [Qemu-devel] [RFC] ppc: define spapr core types statically

2017-09-27 Thread David Gibson
On Wed, Sep 27, 2017 at 06:18:34PM +0200, Greg Kurz wrote: > On Wed, 27 Sep 2017 13:49:17 +0200 > Igor Mammedov wrote: > > > This looks nice indeed (just one remark, see below). > > Will you re-post as a patch series or do you prefer I do it ? Looks good to me as well. > > > Signed-off-by: I

Re: [Qemu-devel] [PATCH RFC 2/3] s390x/tcg: low-address protection support

2017-09-27 Thread Thomas Huth
On 27.09.2017 19:00, David Hildenbrand wrote: > This is a neat way to implement low address protection, whereby > only the first 512 bytes of the first two pages (each 4096 bytes) of > every address space are protected. > > Store a tec of 0 for the access exception, this is what is defined by > En

Re: [Qemu-devel] [PATCH RFC 3/3] s390x/tcg: make STFL store into the lowcore

2017-09-27 Thread Thomas Huth
On 27.09.2017 20:46, David Hildenbrand wrote: > On 27.09.2017 19:52, Richard Henderson wrote: >> On 09/27/2017 10:00 AM, David Hildenbrand wrote: >>> Using virtual memory access is wrong and will soon include low-address >>> protection checks, which is to be bypassed for STFL. >>> >>> This was orig

Re: [Qemu-devel] [PATCH v3 0/9] Support the Capstone disassembler

2017-09-27 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v3 0/9] Support the Capstone disassembler Message-id: 20170926201427.2833-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoke

Re: [Qemu-devel] [PATCH v2 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

2017-09-27 Thread David Gibson
On Wed, Sep 27, 2017 at 04:56:33PM -0300, Eduardo Habkost wrote: > Change all devices that set is_express=1 to implement > INTERFACE_PCIE_DEVICE. > > Cc: Keith Busch > Cc: Kevin Wolf > Cc: Max Reitz > Cc: Dmitry Fleytman > Cc: Jason Wang > Cc: "Michael S. Tsirkin" > Cc: Marcel Apfelbaum > C

Re: [Qemu-devel] [PATCH v2 1/5] pci: conventional-pci-device and pci-express-device interfaces

2017-09-27 Thread David Gibson
On Wed, Sep 27, 2017 at 04:56:31PM -0300, Eduardo Habkost wrote: > Those two interfaces will be used to indicate which device types > support Conventional PCI or PCI Express buses. Management > software will be able to use the qom-list-types QMP command to > query that information. > > Signed-off

Re: [Qemu-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-27 Thread David Gibson
On Wed, Sep 27, 2017 at 04:56:34PM -0300, Eduardo Habkost wrote: > Add INTERFACE_CONVENTIONAL_PCI_DEVICE to all direct subtypes of > TYPE_PCI_DEVICE, except: > > 1) The ones that already have INTERFACE_PCIE_DEVICE set: > > * base-xhci > * e1000e > * nvme > * pvscsi > * vfio-pci > * virtio-pci > *

Re: [Qemu-devel] [PATCH] spapr: move registration of "host" CPU core type to machine code

2017-09-27 Thread David Gibson
On Wed, Sep 27, 2017 at 02:11:44PM +0200, Igor Mammedov wrote: > On Wed, 27 Sep 2017 16:39:03 +1000 > David Gibson wrote: > > > On Tue, Sep 26, 2017 at 10:29:36AM +0200, Igor Mammedov wrote: > > > On Tue, 26 Sep 2017 09:19:28 +0200 > > > Greg Kurz wrote: > > > > > > > On Tue, 26 Sep 2017 12:5

Re: [Qemu-devel] [PATCH v2 5/5] pci: Validate interfaces on base_class_init

2017-09-27 Thread David Gibson
On Wed, Sep 27, 2017 at 04:56:35PM -0300, Eduardo Habkost wrote: > Make sure we don't forget to add the Conventional PCI or PCI > Express interface names on PCI device classes in the future. > > Signed-off-by: Eduardo Habkost Revieed-by: David Gibson > --- > Changes v1 -> v2: > * s/legacy/conv

Re: [Qemu-devel] [PATCH v3 2/5] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2017-09-27 Thread David Gibson
On Wed, Sep 27, 2017 at 05:23:51PM +0530, Aravinda Prasad wrote: > > > On Wednesday 27 September 2017 12:45 PM, David Gibson wrote: > > On Thu, Sep 21, 2017 at 02:39:06PM +0530, Aravinda Prasad wrote: > >> > >> > >> On Tuesday 22 August 2017 07:38 AM, David Gibson wrote: > >> > >> [ . . . ] > >>

Re: [Qemu-devel] [PATCH v2 2/5] pci: Add interface names to hybrid PCI devices

2017-09-27 Thread David Gibson
On Wed, Sep 27, 2017 at 04:56:32PM -0300, Eduardo Habkost wrote: > The following devices support both PCI Express and Conventional > PCI, by including special code to handle the QEMU_PCI_CAP_EXPRESS > flag and/or conditional pcie_endpoint_cap_init() calls: > > * vfio-pci (is_express=1, but legacy

Re: [Qemu-devel] [RFC v2 28/33] migration: return incoming task tag for sockets

2017-09-27 Thread Peter Xu
On Fri, Sep 22, 2017 at 09:11:50PM +0100, Dr. David Alan Gilbert wrote: [...] > > -void tcp_start_incoming_migration(const char *host_port, Error **errp) > > +guint tcp_start_incoming_migration(const char *host_port, Error **errp) > > { > > Error *err = NULL; > > SocketAddress *saddr =

[Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll during destroy

2017-09-27 Thread Peter Xu
From: Stefan Hajnoczi After iothread is enabled internally inside QEMU with GMainContext, we may encounter this warning when destroying the iothread: (qemu-system-x86_64:19925): GLib-CRITICAL **: g_source_remove_poll: assertion '!SOURCE_DESTROYED (source)' failed The problem is that g_source_r

[Qemu-devel] [PATCH v4 3/5] iothread: export iothread_stop()

2017-09-27 Thread Peter Xu
So that internal iothread users can explicitly stop one iothread without destroying it. Since at it, fix iothread_stop() to allow it to be called multiple times. Before this patch we may call iothread_stop() more than once on single iothread, while that may not be correct since qemu_thread_join()

[Qemu-devel] [PATCH v4 4/5] iothread: delay the context release to finalize

2017-09-27 Thread Peter Xu
When gcontext is used with iothread, the context will be destroyed during iothread_stop(). That's not good since sometimes we would like to keep the resources until iothread is destroyed, but we may want to stop the thread before that point. Delay the destruction of gcontext to iothread finalize.

[Qemu-devel] [PATCH v4 2/5] iothread: provide helpers for internal use

2017-09-27 Thread Peter Xu
IOThread is a general framework that contains IO loop environment and a real thread behind. It's also good to be used internally inside qemu. Provide some helpers for it to create iothreads to be used internally. Put all the internal used iothreads into the internal object container. Reviewed-by

[Qemu-devel] [PATCH v4 1/5] qom: provide root container for internal objs

2017-09-27 Thread Peter Xu
We have object_get_objects_root() to keep user created objects, however no place for objects that will be used internally. Create such a container for internal objects. CC: Andreas Färber CC: Markus Armbruster CC: Paolo Bonzini Suggested-by: Daniel P. Berrange Signed-off-by: Peter Xu --- in

[Qemu-devel] [PATCH v4 0/5] iothread: allow to create internal iothreads

2017-09-27 Thread Peter Xu
v4: - fix comment in patch 1 [Fam, Stefan] - add one more patch from Stefan to fix the aio glib warning v3: - pick up r-bs (one missing for Fam's on last patch) - fix patch 1 to create isolated internal container v2: - add one patch to provide object_get_internal_root() [Daniel] - patch 2: use th

Re: [Qemu-devel] A glib warning encountered with internal iothread

2017-09-27 Thread Peter Xu
On Wed, Sep 27, 2017 at 03:14:40PM +0200, Paolo Bonzini wrote: > On 27/09/2017 14:36, Fam Zheng wrote: > > On Wed, 09/27 13:17, Stefan Hajnoczi wrote: > >> On Tue, Sep 26, 2017 at 07:13:43PM +0800, Fam Zheng wrote: > >>> On Tue, 09/26 17:11, Peter Xu wrote: > >>> void aio_context_unref(AioContext

Re: [Qemu-devel] [RFC v2 24/33] migration: synchronize dirty bitmap for resume

2017-09-27 Thread Peter Xu
On Fri, Sep 22, 2017 at 12:33:19PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > This patch implements the first part of core RAM resume logic for > > postcopy. ram_resume_prepare() is provided for the work. > > > > When the migration is interrupted by network fa

Re: [Qemu-devel] [PATCH] docker: Don't mount ccache db if NOUSER=1

2017-09-27 Thread Philippe Mathieu-Daudé
On Mon, Sep 25, 2017 at 4:54 AM, Fam Zheng wrote: > With NOUSER=1 the container runs code as root, which may create > privileged files that will not be be accssible next time. Skip ccache > dir mount in this case. > > Signed-off-by: Fam Zheng Acked-by: Philippe Mathieu-Daudé > --- > tests/doc

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__

2017-09-27 Thread Peter Maydell
On 26 September 2017 at 06:32, Eric Blake wrote: > On 09/25/2017 07:08 PM, Alistair Francis wrote: >> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c >> index 58005b6619..32687afced 100644 >> --- a/hw/arm/nseries.c >> +++ b/hw/arm/nseries.c >> @@ -463,7 +463,7 @@ static uint32_t mipid_txrx(void *

Re: [Qemu-devel] Ping: [PATCH 0/2] ui/cocoa.m: enable guest to see control-alt key combinations

2017-09-27 Thread Peter Maydell
On 27 September 2017 at 15:55, Programmingkid wrote: > Currently if the user needs to send a control-alt key combination, he or she > was either out of luck or had to rely on the monitor's sendkey command to do > so. With this patch the user can now directly send control-alt key > combinations.

Re: [Qemu-devel] [PULL 0/7] migration queue

2017-09-27 Thread Peter Maydell
On 27 September 2017 at 06:57, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit 31bc1d8481af414cfa2857f905e40f7d8e6d5b2e: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into > staging (2017-09-26 19:49:08 +01

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

2017-09-27 Thread Peter Maydell
On 27 September 2017 at 16:14, Michael S. Tsirkin wrote: > On Tue, Sep 26, 2017 at 08:35:59PM +0100, Peter Maydell wrote: >> On 26 September 2017 at 20:31, Michael S. Tsirkin wrote: >> > Please do not apply this, trivial is not appropriate for functional >> > changes like this. >> >> It's not a f

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

2017-09-27 Thread Michael S. Tsirkin
On Tue, Sep 26, 2017 at 08:35:59PM +0100, Peter Maydell wrote: > On 26 September 2017 at 20:31, Michael S. Tsirkin wrote: > > On Mon, Sep 25, 2017 at 12:06:40AM +0300, Michael Tokarev wrote: > >> 22.09.2017 06:06, Thomas Huth wrote: > >> > If QEMU has been compiled with the flags --enable-tcg-inte

Re: [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr, "*\n" with error_report()

2017-09-27 Thread Alistair Francis
On Mon, Sep 25, 2017 at 5:55 PM, Emilio G. Cota wrote: > On Mon, Sep 25, 2017 at 17:08:48 -0700, Alistair Francis wrote: >> diff --git a/tests/atomic_add-bench.c b/tests/atomic_add-bench.c >> index caa1e8e689..41ba1600c0 100644 >> --- a/tests/atomic_add-bench.c >> +++ b/tests/atomic_add-bench.c >>

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-27 Thread Jan Dakinevich
> OK but if it's useful as an hmp command, why not as a qmp command? > The command is designed for debugging and produces quite sightly output. For respective qmp command most of `info virtio' output would excessive and unneccesary. On 09/27/2017 10:43 PM, Michael S. Tsirkin wrote: On Wed, S

Re: [Qemu-devel] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__

2017-09-27 Thread Alistair Francis
On Tue, Sep 26, 2017 at 6:32 AM, Eric Blake wrote: > On 09/25/2017 07:08 PM, Alistair Francis wrote: >> Replace all occurs of __FUNCTION__ except for the check in checkpatch >> with the non GCC specific __func__. >> >> One line in hcd-musb.c was manually tweaked to pass checkpatch. >> >> Signed-of

[Qemu-devel] Ping: [PATCH 0/2] ui/cocoa.m: enable guest to see control-alt key combinations

2017-09-27 Thread Programmingkid
Currently if the user needs to send a control-alt key combination, he or she was either out of luck or had to rely on the monitor's sendkey command to do so. With this patch the user can now directly send control-alt key combinations. This is great for Windows guest that may need the control-al

Re: [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr, "*\n" with error_report()

2017-09-27 Thread Alistair Francis
On Mon, Sep 25, 2017 at 8:51 PM, Thomas Huth wrote: > On 26.09.2017 02:08, Alistair Francis wrote: >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these commands and then >> compiler issues where manually fixed. >> >> find ./* -t

Re: [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable

2017-09-27 Thread Alistair Francis
On Wed, Sep 27, 2017 at 1:32 PM, Eduardo Habkost wrote: > Both -nodefconfig and -no-user-config options do the same thing > today, we only need one variable to keep track of them. > > Suggested-by: Markus Armbruster > Signed-off-by: Eduardo Habkost Acked-by: Alistair Francis Thanks, Alistair

Re: [Qemu-devel] [PATCH 2/2] qemu-options: Deprecate -nodefconfig

2017-09-27 Thread Alistair Francis
On Wed, Sep 27, 2017 at 1:32 PM, Eduardo Habkost wrote: > Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we > have no default config files that would be disabled using > -nodefconfig. Update documentation and document -nodefconfig as > deprecated. > > Cc: Markus Armbruster > Sign

Re: [Qemu-devel] [PATCH v4 18/23] qemu-img: Change compare_sectors() to be byte-based

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > In the continuing quest to make more things byte-based, change > compare_sectors(), renaming it to compare_buffers() in the > process. Note that one caller (qemu-img compare) only cares > about the first difference, while the other (qemu-img rebase) >

Re: [Qemu-devel] HDMI Question

2017-09-27 Thread Alistair Francis
On Wed, Sep 27, 2017 at 5:31 AM, Ni, Xingrong wrote: > Hello, > > I am using qemu and hit a question and would like to ask here, can we > simulate a HDMI device in Qemu, if so, how to do it? Hello, I don't see any reason why you can't. We (Xilinx) have a display port device in QEMU that we use.

Re: [Qemu-devel] [PATCH v4 01/23] block: Allow NULL file for bdrv_get_block_status()

2017-09-27 Thread Eric Blake
On 09/25/2017 05:43 PM, John Snow wrote: > > > On 09/13/2017 12:03 PM, Eric Blake wrote: >> Not all callers care about which BDS owns the mapping for a given >> range of the file. This patch merely simplifies the callers by >> consolidating the logic in the common call point, while guaranteeing

Re: [Qemu-devel] [PULL 00/26] ppc-for-2.11 queue 20170927

2017-09-27 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20170927 > > for you to fetch changes up to e451b85f1bf3c8140be51e2b03eb71ab96c246a5: > > macio: use object link between MACIO_IDE and

Re: [Qemu-devel] [PATCH v4 17/23] qemu-img: Change check_empty_sectors() to byte-based

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > Continue on the quest to make more things byte-based instead of > sector-based. > > Signed-off-by: Eric Blake Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v4 16/23] qemu-img: Drop redundant error message in compare

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > If a read error is encountered during 'qemu-img compare', we > were printing the "Error while reading offset ..." message twice. > Update the testsuite for the improved output. > > Further simplify the code by hoisting the error code conversion > into

Re: [Qemu-devel] [PATCH] iotests: Fix 195 if IMGFMT is part of TEST_DIR

2017-09-27 Thread Eric Blake
On 09/27/2017 04:13 PM, Max Reitz wrote: > do_run_qemu() in iotest 195 first applies _filter_imgfmt when printing > qemu's command line and _filter_testdir only afterwards. Therefore, if > the image format is part of the test directory path, _filter_testdir > will no longer apply and the actual ou

Re: [Qemu-devel] [PATCH v4 15/23] qemu-img: Add find_nonzero()

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > During 'qemu-img compare', when we are checking that an allocated > portion of one file is all zeros, we don't need to waste time > computing how many additional sectors after the first non-zero > byte are also non-zero. Create a new helper find_nonzer

[Qemu-devel] [PATCH] iotests: Fix 195 if IMGFMT is part of TEST_DIR

2017-09-27 Thread Max Reitz
do_run_qemu() in iotest 195 first applies _filter_imgfmt when printing qemu's command line and _filter_testdir only afterwards. Therefore, if the image format is part of the test directory path, _filter_testdir will no longer apply and the actual output will differ from the reference output even i

Re: [Qemu-devel] [PATCH v4 0/6] Misc improvements to crypto block driver

2017-09-27 Thread Max Reitz
On 2017-09-27 14:53, Daniel P. Berrange wrote: > This is a followup to > > v1: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06464.html > v3: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02923.ht

Re: [Qemu-devel] [PATCH v4 14/23] qemu-img: Speed up compare on pre-allocated larger file

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > Compare the following images with all-zero contents: > $ truncate --size 1M A > $ qemu-img create -f qcow2 -o preallocation=off B 1G > $ qemu-img create -f qcow2 -o preallocation=metadata C 1G > > On my machine, the difference is noticeable for pre-pat

Re: [Qemu-devel] [PATCH v4 5/6] block: convert qcrypto_block_encrypt|decrypt to take bytes offset

2017-09-27 Thread Max Reitz
On 2017-09-27 14:53, Daniel P. Berrange wrote: > Instead of sector offset, take the bytes offset when encrypting > or decrypting data. > > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 12 > block/qcow.c | 11 +++ > block/qcow2-cluster.c | 8

Re: [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return number of config groups

2017-09-27 Thread Eric Blake
On 09/27/2017 03:41 PM, Eduardo Habkost wrote: > Change qemu_config_parse() to return the number of config groups > in success and -EINVAL on error. This will allow callers of > qemu_config_parse() to check if something was really loaded from > the config file. > > All existing callers of qemu_con

Re: [Qemu-devel] [PATCH v4 4/6] block: convert crypto driver to bdrv_co_preadv|pwritev

2017-09-27 Thread Max Reitz
On 2017-09-27 14:53, Daniel P. Berrange wrote: > Make the crypto driver implement the bdrv_co_preadv|pwritev > callbacks, and also use bdrv_co_preadv|pwritev for I/O > with the protocol driver beneath. This replaces sector based > I/O with byte based I/O, and allows us to stop assuming the > physic

Re: [Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default config file is loaded

2017-09-27 Thread Eric Blake
On 09/27/2017 03:41 PM, Eduardo Habkost wrote: > In case there were options set in the default config file, print > a warning so users can update their scripts. > > If somebody wants to keep the config file as-is, avoid the > warning and use a command-line that will work in future QEMU > versions,

[Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return number of config groups

2017-09-27 Thread Eduardo Habkost
Change qemu_config_parse() to return the number of config groups in success and -EINVAL on error. This will allow callers of qemu_config_parse() to check if something was really loaded from the config file. All existing callers of qemu_config_parse() and qemu_read_config_file() only check if the r

[Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default config file is loaded

2017-09-27 Thread Eduardo Habkost
In case there were options set in the default config file, print a warning so users can update their scripts. If somebody wants to keep the config file as-is, avoid the warning and use a command-line that will work in future QEMU versions, they can use: $QEMU -no-user-config -readconfig /etc/qem

[Qemu-devel] [PATCH v3 0/2] vl: Print warning if a non-empty default config file is found

2017-09-27 Thread Eduardo Habkost
This missed v2.9 and v2.10. Let's try again: we can include this on v2.11, and remove the default config file in QEMU 2.12 or 2.13. Changes v2 -> v3: * Rebase to latest qemu.git master Changes v1 -> v2: * Remove unnecessary translation of qemu_config_parse() erros to -EINVAL at block/blkdebug.

Re: [Qemu-devel] [PATCH v4 1/6] block: use 1 MB bounce buffers for crypto instead of 16KB

2017-09-27 Thread Max Reitz
On 2017-09-27 14:53, Daniel P. Berrange wrote: > Using 16KB bounce buffers creates a significant performance > penalty for I/O to encrypted volumes on storage which high > I/O latency (rotating rust & network drives), because it > triggers lots of fairly small I/O operations. > > On tests with rot

Re: [Qemu-devel] [PATCH v3] spapr: disable decrementer during reset

2017-09-27 Thread Cédric Le Goater
On 07/17/2017 06:16 AM, Nikunj A Dadhania wrote: > Rebooting a SMP TCG guest is broken for both single/multi threaded TCG. > > When reset happens, all the CPUs are in halted state. First CPU is brought out > of reset and secondary CPUs would be initialized by the guest kernel using a > rtas call s

[Qemu-devel] [PATCH 2/2] qemu-options: Deprecate -nodefconfig

2017-09-27 Thread Eduardo Habkost
Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we have no default config files that would be disabled using -nodefconfig. Update documentation and document -nodefconfig as deprecated. Cc: Markus Armbruster Signed-off-by: Eduardo Habkost --- qemu-options.hx | 13 +++-- 1

[Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable

2017-09-27 Thread Eduardo Habkost
Both -nodefconfig and -no-user-config options do the same thing today, we only need one variable to keep track of them. Suggested-by: Markus Armbruster Signed-off-by: Eduardo Habkost --- vl.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 4fd01fda91..b

[Qemu-devel] [PATCH 0/2] Deprecate -nodefconfig

2017-09-27 Thread Eduardo Habkost
Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we have no default config files that would be disabled using -nodefconfig. This series cleans up the code, updates documentation, and document -nodefconfig as deprecated. Eduardo Habkost (2): vl: Eliminate defconfig variable qemu-

[Qemu-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-27 Thread Eduardo Habkost
Add INTERFACE_CONVENTIONAL_PCI_DEVICE to all direct subtypes of TYPE_PCI_DEVICE, except: 1) The ones that already have INTERFACE_PCIE_DEVICE set: * base-xhci * e1000e * nvme * pvscsi * vfio-pci * virtio-pci * vmxnet3 2) base-pci-bridge Not all PCI bridges are Conventional PCI devices, so INTERF

[Qemu-devel] [PATCH v2 5/5] pci: Validate interfaces on base_class_init

2017-09-27 Thread Eduardo Habkost
Make sure we don't forget to add the Conventional PCI or PCI Express interface names on PCI device classes in the future. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * s/legacy/conventional/ * Suggested-by: Alex Williamson --- hw/pci/pci.c | 12 1 file changed, 12 insert

[Qemu-devel] [PATCH v2 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

2017-09-27 Thread Eduardo Habkost
Change all devices that set is_express=1 to implement INTERFACE_PCIE_DEVICE. Cc: Keith Busch Cc: Kevin Wolf Cc: Max Reitz Cc: Dmitry Fleytman Cc: Jason Wang Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paul Burton Cc: Paolo Bonzini Cc: Hannes Reinecke Cc: qemu-bl...@nongnu.org Revie

[Qemu-devel] [PATCH v2 0/5] Mark conventional/PCIe/hybrid PCI devices using interface names

2017-09-27 Thread Eduardo Habkost
Changes v1 -> v2: * Use "Conventional PCI" instead of "legacy PCI" * Suggested-by: Alex Williamson * Mark base-xhci as hybrid too * Reported-by: Marcel Apfelbaum * Mark pcie-pci-bridge as PCI Express only * New Conventional PCI devices: sungem, sunhme v1 was a reimplementation of one portion

[Qemu-devel] [PATCH v2 2/5] pci: Add interface names to hybrid PCI devices

2017-09-27 Thread Eduardo Habkost
The following devices support both PCI Express and Conventional PCI, by including special code to handle the QEMU_PCI_CAP_EXPRESS flag and/or conditional pcie_endpoint_cap_init() calls: * vfio-pci (is_express=1, but legacy PCI handled by vfio_populate_device()) * vmxnet3 (is_express=0, but PCIe

[Qemu-devel] [PATCH v2 1/5] pci: conventional-pci-device and pci-express-device interfaces

2017-09-27 Thread Eduardo Habkost
Those two interfaces will be used to indicate which device types support Conventional PCI or PCI Express buses. Management software will be able to use the qom-list-types QMP command to query that information. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * s/legacy/conventional/ * Sugg

[Qemu-devel] [Bug 1719984] Re: wrgsbase misemulated in x86_64-softmmu

2017-09-27 Thread Todd Eisenberger
For further data, the faulting instruction is f3 48 0f ae df wrgsbase %rdi -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719984 Title: wrgsbase misemulated in x86_64-softmmu Status in QE

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-27 Thread Michael S. Tsirkin
On Wed, Sep 27, 2017 at 06:09:42PM +0300, Jan Dakinevich wrote: > The command is intended for exposing device specific virtio feature bits > and their negotiation status. It is convenient and useful for debug > purpose. > > Names of features are taken from a devices via get_feature_name() within >

Re: [Qemu-devel] [PATCH v4 12/23] block: Convert bdrv_get_block_status_above() to bytes

2017-09-27 Thread John Snow
On 09/27/2017 02:57 PM, Eric Blake wrote: > On 09/27/2017 01:41 PM, John Snow wrote: >> >> >> On 09/13/2017 12:03 PM, Eric Blake wrote: >>> We are gradually moving away from sector-based interfaces, towards >>> byte-based. In the common case, allocation is unlikely to ever use >>> values that ar

Re: [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12

2017-09-27 Thread Gerhard Wiesinger
On 15.09.2017 19:07, Paolo Bonzini wrote: On 15/09/2017 16:43, Gerhard Wiesinger wrote: On 27.08.2017 20:55, Paolo Bonzini wrote: Il 27 ago 2017 4:48 PM, "Gerhard Wiesinger" mailto:li...@wiesinger.com>> ha scritto: On 27.08.2017 14 :03, Paolo Bonzini wrote: We will revert the

[Qemu-devel] [Bug 1719984] [NEW] wrgsbase misemulated in x86_64-softmmu

2017-09-27 Thread Todd Eisenberger
Public bug reported: qemu revision: cfe4cade054c0e0d00d0185cdc433a9e3ce3e2e4 command: ./qemu-system-x86_64 -m 2048 -nographic -net none -smp 4,threads=2 -machine q35 -kernel zircon.bin -cpu Haswell,+smap,-check -initrd bootdata.bin -append 'TERM=screen kernel.halt-on-panic=true ' On this revisi

Re: [Qemu-devel] [PATCH v4 13/23] qemu-img: Simplify logic in img_compare()

2017-09-27 Thread Eric Blake
On 09/27/2017 02:05 PM, John Snow wrote: > > > On 09/13/2017 12:03 PM, Eric Blake wrote: >> As long as we are querying the status for a chunk smaller than >> the known image size, we are guaranteed that a successful return >> will have set pnum to a non-zero size (pnum is zero only for >> queries

Re: [Qemu-devel] [PATCH v4 13/23] qemu-img: Simplify logic in img_compare()

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > As long as we are querying the status for a chunk smaller than > the known image size, we are guaranteed that a successful return > will have set pnum to a non-zero size (pnum is zero only for > queries beyond the end of the file). Use that to slightly

Re: [Qemu-devel] libvirt/QEMU/SEV interaction

2017-09-27 Thread Richard Relph
Forgive the top post... some of the conversation has been trimmed, but I need to go back to first principles of SEV in order to make sure we all have a clear understanding of what the goal is. The goal - for BOTH guest owner and cloud provider - is to get to a VM where ONLY the guest owner (GO

Re: [Qemu-devel] [PATCH v3 0/9] Support the Capstone disassembler

2017-09-27 Thread Richard Henderson
On 09/26/2017 01:14 PM, Richard Henderson wrote: > Richard Henderson (9): > target/i386: Convert to disas_set_info hook > target/ppc: Convert to disas_set_info hook > disas: Remove unused flags arguments > disas: Support the Capstone disassembler library > i386: Support Capstone in disas_

Re: [Qemu-devel] [PATCH] linux-headers: sync against v4.14-rc1

2017-09-27 Thread Dr. David Alan Gilbert
cc'ing in Paolo who I think knows more about checking this sync. Dave * Alexey Perevalov (a.pereva...@samsung.com) wrote: > Signed-off-by: Alexey Perevalov > --- > include/standard-headers/asm-x86/hyperv.h| 19 ++--- > include/standard-headers/linux/pci_regs.h| 42 > +++

Re: [Qemu-devel] [PATCH v4 12/23] block: Convert bdrv_get_block_status_above() to bytes

2017-09-27 Thread Eric Blake
On 09/27/2017 01:41 PM, John Snow wrote: > > > On 09/13/2017 12:03 PM, Eric Blake wrote: >> We are gradually moving away from sector-based interfaces, towards >> byte-based. In the common case, allocation is unlikely to ever use >> values that are not naturally sector-aligned, but it is possible

Re: [Qemu-devel] [PATCH RFC 1/3] accel/tcg: allow to invalidate a write TLB entry immediately

2017-09-27 Thread David Hildenbrand
On 27.09.2017 19:48, Richard Henderson wrote: > On 09/27/2017 10:00 AM, David Hildenbrand wrote: >> Background: s390x implements Low-Address Protection (LAP). If LAP is >> enabled, writing to effective addresses (before any transaltion) >> 0-511 and 4096-4607 triggers a protection exception. >> >>

Re: [Qemu-devel] [PATCH RFC 3/3] s390x/tcg: make STFL store into the lowcore

2017-09-27 Thread David Hildenbrand
On 27.09.2017 19:52, Richard Henderson wrote: > On 09/27/2017 10:00 AM, David Hildenbrand wrote: >> Using virtual memory access is wrong and will soon include low-address >> protection checks, which is to be bypassed for STFL. >> >> This was originally part of a bigger STFL(E) refactoring. >> >> Si

[Qemu-devel] [Bug 1713825] Re: Booting Windows 2016 with qxl video crashes qemu

2017-09-27 Thread Maciej Piechotka
I reproduce it on 2.10.0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1713825 Title: Booting Windows 2016 with qxl video crashes qemu Status in QEMU: New Bug description: launched from libvi

Re: [Qemu-devel] [PATCH v4 12/23] block: Convert bdrv_get_block_status_above() to bytes

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. In the common case, allocation is unlikely to ever use > values that are not naturally sector-aligned, but it is possible > that byte-based values will let us be more prec

Re: [Qemu-devel] [PATCH v4 11/23] block: Switch bdrv_co_get_block_status_above() to byte-based

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert another internal > type (no semantic change), and rename it to match the corresponding > public function rename. > > Signed-off-by: E

Re: [Qemu-devel] [PATCH v4 10/23] block: Switch bdrv_common_block_status_above() to byte-based

2017-09-27 Thread John Snow
On 09/13/2017 12:03 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert another internal > function (no semantic change). > > Signed-off-by: Eric Blake > Reviewed-by: Fam Zheng Reviewed-by: John Snow

[Qemu-devel] [PATCH v3] virtio: introduce `info virtio' hmp command

2017-09-27 Thread Jan Dakinevich
The command is intended for exposing device specific virtio feature bits and their negotiation status. It is convenient and useful for debug purpose. Names of features are taken from a devices via get_feature_name() within VirtioDeviceClass. If certain device doesn't implement it, the command will

Re: [Qemu-devel] [PATCH RFC 3/3] s390x/tcg: make STFL store into the lowcore

2017-09-27 Thread Richard Henderson
On 09/27/2017 10:00 AM, David Hildenbrand wrote: > Using virtual memory access is wrong and will soon include low-address > protection checks, which is to be bypassed for STFL. > > This was originally part of a bigger STFL(E) refactoring. > > Signed-off-by: David Hildenbrand > --- > target/s390

Re: [Qemu-devel] [PATCH RFC 2/3] s390x/tcg: low-address protection support

2017-09-27 Thread Richard Henderson
On 09/27/2017 10:00 AM, David Hildenbrand wrote: > +case PSW_ASC_HOME: > +return !(env->cregs[13] & _ASCE_PRIVATE_SPACE); > +default: > +/* We don't support access register mode */ > +error_report("unsupported addressing mode"); > +exit(1); I think g_assert_

Re: [Qemu-devel] [PATCH RFC 1/3] accel/tcg: allow to invalidate a write TLB entry immediately

2017-09-27 Thread Richard Henderson
On 09/27/2017 10:00 AM, David Hildenbrand wrote: > Background: s390x implements Low-Address Protection (LAP). If LAP is > enabled, writing to effective addresses (before any transaltion) > 0-511 and 4096-4607 triggers a protection exception. > > So we have subpage protection on the first two pages

Re: [Qemu-devel] [PATCH v7 01/20] hw/arm/smmu-common: smmu base device and datatypes

2017-09-27 Thread Peter Maydell
On 1 September 2017 at 10:21, Eric Auger wrote: > The patch introduces the smmu base device and class for the ARM > smmu. Devices for specific versions will be derived from this > base device. > > We also introduce some important datatypes. > > Signed-off-by: Eric Auger > Signed-off-by: Prem Mall

Re: [Qemu-devel] [PATCH v2] virtio: introduce `info virtio' hmp command

2017-09-27 Thread Jan Dakinevich
On 09/27/2017 06:53 PM, Dr. David Alan Gilbert wrote: > * Jan Dakinevich (jan.dakinev...@virtuozzo.com) wrote: >> The command is intended for exposing device specific virtio feature bits >> and their negotiation status. It is convenient and useful for debug >> purpose. >> >> Names of features are

Re: [Qemu-devel] [PULL 00/24] Block layer patches

2017-09-27 Thread Peter Maydell
On 26 September 2017 at 07:21, Kevin Wolf wrote: > The following changes since commit 1e3ee834083227f552179f6e43902cba5a866e6b: > > Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into > staging (2017-09-25 20:31:24 +0100) > > are available in the git repository at: > > g

[Qemu-devel] [PATCH RFC 2/3] s390x/tcg: low-address protection support

2017-09-27 Thread David Hildenbrand
This is a neat way to implement low address protection, whereby only the first 512 bytes of the first two pages (each 4096 bytes) of every address space are protected. Store a tec of 0 for the access exception, this is what is defined by Enhanced Suppression on Protection in case of a low address

[Qemu-devel] [PATCH RFC 3/3] s390x/tcg: make STFL store into the lowcore

2017-09-27 Thread David Hildenbrand
Using virtual memory access is wrong and will soon include low-address protection checks, which is to be bypassed for STFL. This was originally part of a bigger STFL(E) refactoring. Signed-off-by: David Hildenbrand --- target/s390x/helper.h | 2 +- target/s390x/misc_helper.c | 7 ++- 2

[Qemu-devel] [PATCH RFC 1/3] accel/tcg: allow to invalidate a write TLB entry immediately

2017-09-27 Thread David Hildenbrand
Background: s390x implements Low-Address Protection (LAP). If LAP is enabled, writing to effective addresses (before any transaltion) 0-511 and 4096-4607 triggers a protection exception. So we have subpage protection on the first two pages of every address space (where the lowcore - the CPU privat

[Qemu-devel] [PATCH RFC 0/3] s390x/tcg: LAP support using immediate TLB invalidation

2017-09-27 Thread David Hildenbrand
Details about Low-Address Protection can be found in description of patch 1 and 2. It is basically a subpage protection of the first two pages of every address space (for which it is enabled). We can achieve this by simply directly invalidating the TLB entry and therefore forcing every write acces

Re: [Qemu-devel] Problem in pcie_pci_bridge_realize()

2017-09-27 Thread Thomas Huth
On 27.09.2017 18:22, Aleksandr Bezzubikov wrote: > 2017-09-27 18:50 GMT+03:00 Thomas Huth : >> Hi, >> >> QEMU currently aborts with an assertion when plugging of the >> pcie-pci-bridge fails, e.g.: >> >> $ mips64el-softmmu/qemu-system-mips64el -M malta -nographic -S \ >> -device pc

Re: [Qemu-devel] [RFC 6/6] device-crash-test: Multi-device device_add test

2017-09-27 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > On 27.09.2017 01:07, Eduardo Habkost wrote: > > When running device_add tests, test all devices in a single run > > instead of restarting QEMU every time. > > > > There's a plug_all testcase argument that can be used to make the > > test code plug all devi

Re: [Qemu-devel] [PATCH v2] hw/pci-bridge/pcie_pci_bridge: properly handle MSI unavailability case

2017-09-27 Thread Thomas Huth
On 25.09.2017 01:21, Aleksandr Bezzubikov wrote: > QEMU with the pcie-pci-bridge device crashes if the guest board doesn't > support MSI, > e.g. 'qemu-system-ppc64 -M prep -device pcie-pci-bridge'. > This is caused by wrong pcie-pci-bridge instantiation error handling. This > patch fixes this iss

Re: [Qemu-devel] [PATCH v2 2/2] qcow2: truncate the tail of the image file after shrinking the image

2017-09-27 Thread Max Reitz
On 2017-09-27 18:27, Pavel Butsykin wrote: > On 27.09.2017 19:00, Max Reitz wrote: >> On 2017-09-22 11:39, Pavel Butsykin wrote: >>> Now after shrinking the image, at the end of the image file, there >>> might be a >>> tail that probably will never be used. So we can find the last used >>> cluster

Re: [Qemu-devel] [PATCH] xen-hvm: use errno in error message

2017-09-27 Thread Anthony PERARD
On Wed, Sep 27, 2017 at 05:10:09PM +0100, Wei Liu wrote: > The error code is encoding in errno, not rc. ^ encoded I think. Otherwise, Reviewed-by: Anthony PERARD Thanks, > > Signed-off-by: Wei Liu > --- > Cc: Stefano Stabellini > Cc: Anthony PERARD > --- > hw/i386/xen/

Re: [Qemu-devel] blockdev-commit design

2017-09-27 Thread Max Reitz
On 2017-09-26 19:59, Kevin Wolf wrote: [...] > * The old block-commit command decides between an "actual" commit job > and the mirror-based active commit based on whether top is the > active layer. > > We don't get an option for the active layer any more now, so this > isn't ho

  1   2   3   >