On Fri, Sep 22, 2017 at 09:11:50PM +0100, Dr. David Alan Gilbert wrote:
[...]
> > -void tcp_start_incoming_migration(const char *host_port, Error **errp)
> > +guint tcp_start_incoming_migration(const char *host_port, Error **errp)
> > {
> > Error *err = NULL;
> > SocketAddress *saddr = tcp_build_address(host_port, &err);
> > + guint tag;
> > +
> > if (!err) {
> > - socket_start_incoming_migration(saddr, &err);
> > + tag = socket_start_incoming_migration(saddr, &err);
> > }
>
> I'd be tempted to initialise that tag = 0 for the case where
> there's an error; but OK.
Yeh, I think it worths a touch-up.
>
> Reviewed-by: Dr. David Alan Gilbert <[email protected]>
Will take the r-b after fixing above. Thanks!
--
Peter Xu
