On Mon, 29 May 2017 19:37:50 +0200
Andrew Jones wrote:
> Cc: Shannon Zhao
> Signed-off-by: Andrew Jones
Reviewed-by: Igor Mammedov
> ---
> hw/arm/virt-acpi-build.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index e58520
Thank you for this scenario. Hmm.
So, as I need guarantee that image and bitmap are unchanged,
bdrv_set_dirty should return error and fail the whole write. Ok?
29.05.2017 21:35, Max Reitz wrote:
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
It will be needed in following commits f
On Mon, May 29, 2017 at 10:46:05PM +0200, Greg Kurz wrote:
> On Fri, 26 May 2017 15:23:16 +1000
> David Gibson wrote:
>
> > As a rule, CPU internal state should never be updated when
> > !cpu->kvm_vcpu_dirty (or the HAX equivalent). If that is done, then
> > subsequent calls to cpu_synchronize_s
On Tue, May 30, 2017 at 01:14:16AM +0200, Greg Kurz wrote:
> On Fri, 26 May 2017 15:23:14 +1000
> David Gibson wrote:
>
> [...]
> >
> >
> > Changes since v3:
> > * Backwards compatible -cpu handling now removes compat= option from
> > options passed on to the cpu, so it doesn't trigger fu
29.05.2017 20:54, Max Reitz wrote:
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
We should release them here to reload on invalidate cache.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block.c | 4
block/dirty-bitmap.c | 29 ++
Currently ivshmem requires eventfd() which is Linux specific.
Do not and build it unconditionally on every Linux/BSD/Solaris.
This patch indirectly fixes build failure on NetBSD, where these tools
additionally require -lrt for shm_open(3). In future there should be
added support for NetBSD and the
Hi all,
I was wondering if anyone has information regarding Windows driver of
virtio pci p9.
Our users can have multiple VM instances running and providing some sort of
shared storage between different VMs would be very useful for them.
I know that the alternate is to use SMB but because of netw
Hi
On Tue, May 30, 2017 at 1:09 AM Philippe Mathieu-Daudé
wrote:
> Hi Marc-André,
>
> On 05/29/2017 05:45 AM, Marc-André Lureau wrote:
> > qemu_chr_fe_write() is similar to qemu_chr_write_all(): the later write
> > all with a chardev backend.
> >
> > Make qemu_chr_write() and qemu_chr_fe_write_b
Eduardo Habkost writes:
> On Mon, May 29, 2017 at 06:53:47PM +0200, Markus Armbruster wrote:
>> Eduardo Habkost writes:
>>
>> > Allow the exit code of QEMU to be queried by scripts.
>> >
>> > Signed-off-by: Eduardo Habkost
>> > ---
>> > scripts/qemu.py | 4
>> > 1 file changed, 4 inserti
Thomas Huth writes:
> We likely do not want to carry these legacy -drive options along forever.
> Let's emit a deprecation warning for the -drive options that have a
> replacement with the -device option, so that the (hopefully few) remaining
> users are aware of this and can adapt their scripts
> 在 2017年5月29日，下午6:43，Igor Mammedov 写道：
>
> On Sat, 27 May 2017 10:32:33 +0800
> Li Zhang wrote:
>
>>> On Fri, May 26, 2017 at 7:21 PM, Igor Mammedov wrote:
>>> On Fri, 26 May 2017 17:21:05 +0800
>>> Li Zhang wrote:
>>>
From: Li Zhang
virt machine doesn't support hot_add_c
I noticed you were wondering what happend to this message in the patchew thread:
http://patchew.org/QEMU/20170509173559.31598-1-marcandre.lur...@redhat.com/
Markus, apparently this is because of the unusual "In-Reply-To" header of your
message, which confuses patchew:
In-Reply-To: <2017050917355
On Fri, 26 May 2017 15:23:14 +1000
David Gibson wrote:
[...]
>
>
> Changes since v3:
> * Backwards compatible -cpu handling now removes compat= option from
> options passed on to the cpu, so it doesn't trigger further warnings
This seems to also have another interesting effect.
getset_c
On 05/29/2017 05:45 AM, Marc-André Lureau wrote:
Suggested by Paolo Bonizini during series review.
Bonzini ;) "serie" singular
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
{backends => chardev}/baum.c | 0
{backends => chardev}/msmouse.c | 0
Hi Marc-André,
Reviewed-by: Philippe Mathieu-Daudé
On 05/29/2017 05:45 AM, Marc-André Lureau wrote:
Move all the fronted struct and methods to a seperate unit. This avoids
"frontend, separate"
accidentally mixing backend and frontend calls, and helps with readibilty.
"readability"
Indee
On Thu, 25 May 2017 13:51:25 +1000
David Gibson wrote:
> Guests of the qemu machine type go through a feature negotiation process
> known as "client architecture support" (CAS) during early boot. This does
> a number of things, one of which is finding a CPU compatibility mode which
> can be supp
Hi Marc-André,
On 05/29/2017 05:45 AM, Marc-André Lureau wrote:
qemu_chr_fe_write() is similar to qemu_chr_write_all(): the later write
all with a chardev backend.
Make qemu_chr_write() and qemu_chr_fe_write_buffer() take an 'all'
argument. If false, handle 'partial' write the way qemu_chr_fe_w
On 05/29/2017 05:45 AM, Marc-André Lureau wrote:
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
include/chardev/char-parallel.h | 20 +++-
include/chardev/char-serial.h | 22 ++
include/chardev/char.h | 36 ---
On 05/29/2017 05:45 AM, Marc-André Lureau wrote:
So they are all in one place. The following patch will move serial &
parallel declarations to the respective headers.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
{chardev => include/chardev}/char-fd.h|
On Mon, May 29, 2017 at 05:05:17PM +0200, Alberto Garcia wrote:
On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote:
A quirk in the current implementation is that the throttling limits
for the group are overwritten by each -drive throttling.group=group0.
Limits for all but the last -drive
On 05/29/2017 05:45 AM, Marc-André Lureau wrote:
Those are apparently unnecessary includes.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/bcm2835_peripherals.c | 1 -
hw/char/imx_serial.c | 1 -
hw/display/xenfb.c | 1 -
hw/i386/xen/xen-
On 05/29/2017 01:30 PM, Jose Ricardo Ziviani wrote:
Today, if we use a trace-event file which does not declare an event
existing in the log file we'll get the following error:
$ scripts/simpletrace.py trace-events trace-68508
Traceback (most recent call last):
File "scripts/simpletrace.py", li
On 05/29/2017 04:24 PM, Aurelien Jarno wrote:
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
Reviewed-by: Philippe Mathieu-Daudé
---
target/s390x/translate.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/target/s390x/translate.c b/target/s390x/trans
On Fri, 26 May 2017 15:23:16 +1000
David Gibson wrote:
> As a rule, CPU internal state should never be updated when
> !cpu->kvm_vcpu_dirty (or the HAX equivalent). If that is done, then
> subsequent calls to cpu_synchronize_state() - usually safe and idempotent -
> will clobber state.
>
> Howev
Delay slots are indivisible, therefore avoid scheduling an interrupt in
the delay slot. However exceptions are possible.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/sh4/helper.c | 12 ++--
1 file changed, 10 insertions(+),
This will make easier the introduction of a new flag in the next
patches.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/sh4/cpu.h | 3 ++-
target/sh4/helper.c| 4 ++--
target/sh4/translate.c | 17 -
3 fil
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 13 +
target/s390x/translate.c | 8
4 files changed, 24 insertions(+)
diff --git a/target/s390x/helper.h b
When a masked exception happens, the SH4 CPU generates a non-masked
reset exception, which then jumps to the reset vector at address
0xA000. While this is emulated correctly in QEMU, this does not
work when using a kernel and initrd as this address then contain an
illegal instruction (and there
Use a common helper with PACK ASCII as the differences are limited to
the stride of the source operand.
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 30 +-
target/s390x/translate.
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 51 ++
target/s390x/translate.c | 17
4 files changed, 71 insertions
At the same time fix the TCG version of get_max_cpu_model to return the
maximum model like on KVM. Remove the long-displacement facility from
the additional features as it is included in the z800.
Signed-off-by: Aurelien Jarno
---
target/s390x/cpu_models.c | 12 ++--
1 file changed, 6 in
The ReTurn from Exception (RTE) instruction loads the system register
(SR) with the saved system register (SSR). It has a delay slot, and
behaves specially according to the SH4 manual:
The SR value accessed by the instruction in the RTE delay slot is the
value restored from SSR by the RTE inst
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 13 +
target/s390x/translate.c | 8
4 files changed, 24 insertions(+)
diff --git a/target/s390x/helper.h b
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 4
target/s390x/mem_helper.c | 31 +++
target/s390x/translate.c | 8
4 files changed, 44 insertions(+)
diff --git a/tar
qemu_log_mask() is preferred over fprintf() for logging errors.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/sh4/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/sh4/helper.c b/target/sh4/helper.c
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 3 +++
target/s390x/mem_helper.c | 23 +++
target/s390x/translate.c | 9 +
4 files changed, 36 insertions(+)
diff --git a/target/s390
For that we need to make program_interrupt available to qemu-user.
Fortunately there is almost nothing to change as both kvm_enabled and
CONFIG_KVM evaluate to false in that case.
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 49 --
target/s390x/translate.c | 18 +
4 files changed, 60 insertion
Signed-off-by: Aurelien Jarno
---
target/s390x/cpu.h| 2 ++
target/s390x/mem_helper.c | 17 ++---
target/s390x/mmu_helper.c | 4 +---
3 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 79235cfa45..d89ad83e71 100644
Signed-off-by: Aurelien Jarno
---
target/s390x/insn-data.def | 3 +++
target/s390x/translate.c | 10 ++
2 files changed, 13 insertions(+)
diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def
index f818437069..0f70acea5c 100644
--- a/target/s390x/insn-data.def
+++ b/tar
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 9 +
target/s390x/mem_helper.c | 46 ++
target/s390x/translate.c | 13 +
4 files changed, 69 insertions(+)
diff --git a/target/s39
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 47 --
target/s390x/translate.c | 21 +
4 files changed, 65 insertions(+), 6 deletions(-)
diff -
And at the same time make IPTE SMP aware.
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 2 +-
target/s390x/mem_helper.c | 19 ---
target/s390x/translate.c | 6 +-
3 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/target/s390x/helper.h b/target
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 35 +++
target/s390x/translate.c | 16
4 files changed, 54 insertions(+)
diff -
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 12
target/s390x/translate.c | 6 ++
4 files changed, 21 insertions(+)
diff --git a/target/s390x/helper.h b/target/s390x/helper.h
index ca78d1
As CLCL and CLCLE mostly differ by their operands, use a common do_clcl
helper. Another difference is that CLCL is not interruptible.
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 84 +
Improve fix_address to also handle the 24-bit mode. Rename fix_address
to wrap_address to better explain what is changed.
Replace the calls to get_address with x2 = 0 and b2 = 0 by
call to wrap_address, leading to the removal of this function. Rename
get_address_31fix into get_address.
Signed-off
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/mem_helper.c | 47 +--
1 file changed, 33 insertions(+), 14 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index e494b7dfd4..911c3d7f8e 1006
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 5 +
target/s390x/mem_helper.c | 37 +
target/s390x/translate.c | 8
4 files changed, 51 insertions(+)
diff --gi
As MVCL and MVCLE only differ by their operands, use a common
do_mvcl helper. Optimize it calling fast_memmove and fast_memset.
Correctly write back addresses. Check that r1 and r2/r3 registers
are even.
Signed-off-by: Aurelien Jarno
---
target/s390x/mem_helper.c | 90 +--
There are multiple issues with the COMPARE LOGICAL LONG EXTENDED
instruction:
- The test between the two operands is inverted, leading to an inversion
of the cc values 1 and 2.
- The address and length of an operand continue to be decreased after
reaching the end of this operand. These values a
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/mem_helper.c | 37 ++---
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index bbece93c9d..e494b7dfd4 100644
--- a/ta
This patchset tries to improve the s390x emulation by fixing and
improving some instructions. It implement some more instructions, from
the zArchitecture base and from the Extended-Translation Facility 2. The
last patch updates the maximum TCG CPU to z800, as the ETF2 and
Long-Displacement Facility
These functions differ from COMPARE by generating an exception for a
QNaN input. Use the non quiet version of floatXX_compare.
Signed-off-by: Aurelien Jarno
---
target/s390x/fpu_helper.c | 27 +++
target/s390x/helper.h | 3 +++
target/s390x/insn-data.def | 6 +
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 12
target/s390x/translate.c | 8
4 files changed, 23 insertions(+)
diff --git a/target/s390x/helper.h b/
Signed-off-by: Aurelien Jarno
---
target/s390x/insn-data.def | 3 +++
target/s390x/translate.c | 10 ++
2 files changed, 13 insertions(+)
diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def
index 0f70acea5c..170b50ef2e 100644
--- a/target/s390x/insn-data.def
+++ b/tar
adj_len_to_page doesn't return the correct result when the address
is already page aligned and the length is bigger than a page. Fix that.
Signed-off-by: Aurelien Jarno
---
target/s390x/mem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/mem_helper.c b/t
Signed-off-by: Aurelien Jarno
---
target/s390x/helper.h | 1 +
target/s390x/insn-data.def | 2 ++
target/s390x/mem_helper.c | 13 +
target/s390x/translate.c | 7 +++
4 files changed, 23 insertions(+)
diff --git a/target/s390x/helper.h b/target/s390x/helper.h
index c6fb
Reviewed-by: Richard Henderson
Signed-off-by: Aurelien Jarno
---
target/s390x/translate.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 97ca639a34..f7598184a6 100644
--- a/target/s390x/translate.c
+++ b/target/s3
Observe the following ('qmp-shell', for brevity) invocation of the four
major types (stream, commit, mirror, backup) of live block operations:
(QEMU) block-stream device=node-D base=a.qcow2 job-id=job-block-stream
(QEMU) block-commit device=node-D base=a.qcow2 top=b.qcow2
job-id=job-block
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> It will be needed in following commits for persistent bitmaps.
> If bitmap is loaded from read-only storage (and we can't mark it
> "in use" in this storage) corresponding BdrvDirtyBitmap should be
> read-only.
>
> Signed-off-by: Vladimir
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> We should release them here to reload on invalidate cache.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block.c | 4
> block/dirty-bitmap.c | 29 +++--
> include/block
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> Remove persistent bitmap from the storage on block-dirty-bitmap-remove.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Max Reitz
> Reviewed-by: John Snow
> ---
> blockdev.c | 10 ++
> qapi/block-core.j
This is based on patch Shannon Zhao originally posted.
Cc: Shannon Zhao
Signed-off-by: Andrew Jones
---
hw/arm/virt.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index c7c8159dfd59..4db2d4207cf2 100644
--- a/hw/arm/virt.c
+++ b/hw/arm
Andrew Jones (2):
hw/arm/virt-acpi-build: build SLIT when needed
hw/arm/virt: fdt: generate distance-map when needed
hw/arm/virt-acpi-build.c | 4
hw/arm/virt.c| 21 +
2 files changed, 25 insertions(+)
--
2.9.4
Cc: Shannon Zhao
Signed-off-by: Andrew Jones
---
hw/arm/virt-acpi-build.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index e5852067f5bd..2079828c22a4 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -776,6 +7
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/165 | 105
> +
> tests/qemu-iotests/165.out | 5 +++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 111 in
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> Store persistent dirty bitmaps in qcow2 image.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/qcow2-bitmap.c | 475
> +++
> block/qcow2.c| 9 +
> block/qcow2.h
On Mon, May 29, 2017 at 06:53:47PM +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > Allow the exit code of QEMU to be queried by scripts.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > scripts/qemu.py | 4
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/scripts/
Eduardo Habkost writes:
> Allow the exit code of QEMU to be queried by scripts.
>
> Signed-off-by: Eduardo Habkost
> ---
> scripts/qemu.py | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 16934f1e02..ebe1c4b919 100644
> --- a/scripts/qemu.py
On 23/05/2017 04:23, Xiao Guangrong wrote:
>
> Ping...
>
> Sorry to disturb, just make this patchset not be missed. :)
It won't. :) I'm going to look at it and the dirty page ring buffer
this week.
Paolo
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> New field BdrvDirtyBitmap.persistent means, that bitmap should be saved
> by format driver in .bdrv_close and .bdrv_inactivate. No format driver
> supports it for now.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/dirty-b
Eduardo Habkost writes:
> Keep the Popen object around to we can query its exit code later.
>
> To keep the existing 'self._popen is None' checks working, add a
> is_running() method, that will check if the process is still running.
>
> Signed-off-by: Eduardo Habkost
Reviewed-by: Markus Armbrus
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> Release bitmaps after 'if (bs->drv) { ... }' block. This will allow
> format driver to save persistent bitmaps, which will appear in following
> commits.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block.c | 6 +++---
> 1 fil
Today, if we use a trace-event file which does not declare an event
existing in the log file we'll get the following error:
$ scripts/simpletrace.py trace-events trace-68508
Traceback (most recent call last):
File "scripts/simpletrace.py", line 242, in
run(Formatter())
File "scripts/simpl
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They
> are loaded when the image is opened and become BdrvDirtyBitmaps for the
> corresponding drive.
>
> Extra data in bitmaps is not supported for now.
>
> Signed-off-by
On 12.05.2017 12:33, Thomas Huth wrote:
> We likely do not want to carry these legacy -drive options along forever.
> Let's emit a deprecation warning for the -drive options that have a
> replacement with the -device option, so that the (hopefully few) remaining
> users are aware of this and can ad
Hi,
did you remove me from the To: / Cc: list intentionally, or was that an
oversight? I caught your message in my list folders only by luck.
Some followup below:
On 05/29/17 17:27, gengdongjiu wrote:
>> (46) What is "physical_addr" good for? Below I can only see an
>> assignment to it, in ghe
On 2017-05-29 17:55, Eric Blake wrote:
> On 05/29/2017 10:46 AM, Max Reitz wrote:
>
>>> If you switch all of these to $(realpath -- "$(type -p "$QEMU_...")"),
>>> you can add:
>>
>> I'd love to, but this is what type -p outputs for me:
>>
>> $ type -p qemu-img
>> qemu-img is /usr/bin/qemu-img
>
>
On 05/29/2017 10:46 AM, Max Reitz wrote:
>> If you switch all of these to $(realpath -- "$(type -p "$QEMU_...")"),
>> you can add:
>
> I'd love to, but this is what type -p outputs for me:
>
> $ type -p qemu-img
> qemu-img is /usr/bin/qemu-img
Huh? That's plain 'type' output. Are you sure you'
Am 27.05.2017 um 09:56 hat Stefan Hajnoczi geschrieben:
> Throttling groups allow multiple drives to share the same throttling
> state (i.e. budget) between them. Manos is working on moving the
> throttling code into a block filter driver so it is no longer
> hardcoded into the I/O code path.
>
>
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> It will be needed in following commits for persistent bitmaps.
> If bitmap is loaded from read-only storage (and we can't mark it
> "in use" in this storage) corresponding BdrvDirtyBitmap should be
> read-only.
>
> Signed-off-by: Vladimir
On 2017-05-29 17:42, Eric Blake wrote:
> On 05/29/2017 10:23 AM, Max Reitz wrote:
>> A user may specify a relative path for accessing qemu, qemu-img, etc.
>> through environment variables ($QEMU_PROG and friends) or a symlink.
>>
>> If a test decides to change its working directory, relative paths
On 05/29/2017 10:23 AM, Max Reitz wrote:
> A user may specify a relative path for accessing qemu, qemu-img, etc.
> through environment variables ($QEMU_PROG and friends) or a symlink.
>
> If a test decides to change its working directory, relative paths will
> cease to work, however. Work around t
On 2017-05-03 14:25, Vladimir Sementsov-Ogievskiy wrote:
> Add bitmap extension as specified in docs/specs/qcow2.txt.
> For now, just mirror extension header into Qcow2 state and check
> constraints. Also, calculate refcounts for qcow2 bitmaps, to not break
> qemu-img check.
>
> For now, disable i
Dear Laszlo,
Thank your very much for your review and detailed comment. and very sorry for
the late response due to recently debug the wholes RAS solution.
On 2017/5/22 22:23, Laszlo Ersek wrote:
> Keeping some context:
>
> On 05/12/17 23:00, Laszlo Ersek wrote:
>> On 04/30/17 07:35, Dongjiu
Reviewed-by: Eric Blake
Signed-off-by: Max Reitz
---
tests/qemu-iotests/126 | 105 +
tests/qemu-iotests/126.out | 23 ++
tests/qemu-iotests/group | 1 +
3 files changed, 129 insertions(+)
create mode 100755 tests/qemu-iotests/126
cre
This is a v3 for "block: Fix backing paths for filenames with colons".
Kevin reported that the test added there does not work if the test
programs are specified with relative paths (because the new test changes
its working directory), so we/I dropped the test from the queue and here
it is again.
T
A user may specify a relative path for accessing qemu, qemu-img, etc.
through environment variables ($QEMU_PROG and friends) or a symlink.
If a test decides to change its working directory, relative paths will
cease to work, however. Work around this by making all of the paths to
programs that sho
From: Ben Warren
The following tests are implemented:
* test that a GUID passed in by command line is propagated to the guest.
Read the GUID from guest memory
* test that the "auto" argument to the GUID generates a valid GUID, as
seen by the guest.
* test that a GUID passed in can be queried
From: Max Reitz
path_combine() naturally tries to preserve a protocol prefix. However,
it recognizes such a prefix by scanning for the first colon; which is
different from what path_has_protocol() does: There only is a protocol
prefix if there is a colon before the first slash.
A protocol prefix
From: Max Reitz
The file drivers' *_parse_filename() implementations just strip the
optional protocol prefix off the filename. However, for e.g.
"file:foo:bar", this would lead to "foo:bar" being stored as the BDS's
filename which looks like it should be managed using the "foo" protocol.
This is
From: Fam Zheng
Reported by Coverity.
Signed-off-by: Fam Zheng
Message-id: 20170515141014.25793-1-f...@redhat.com
Reviewed-by: Eric Blake
Signed-off-by: Max Reitz
---
qemu-img.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-img.c b/qemu-img.c
index 0bf941b..5aef8ef 100644
--- a/qe
From: Alberto Garcia
Commit d7086422b1c1e75e320519cfe26176db6ec97a37 added a local_err
variable global to the qcow2_amend_options() function, so there's no
need to have this other one.
Signed-off-by: Alberto Garcia
Message-id: 20170511150337.21470-1-be...@igalia.com
Reviewed-by: Eric Blake
Sig
From: "Daniel P. Berrange"
The qemu-img dd/convert commands will create an image file and
then try to open it. Historically it has been possible to open
new files without passing any options. With encrypted files
though, the *key-secret options are mandatory, so we need to
provide those options w
From: Fam Zheng
It got lost in commit a8d16f9ca "qemu-img: Update documentation for -U".
Reported-by: Max Reitz
Signed-off-by: Fam Zheng
Message-id: 20170515103551.31313-1-f...@redhat.com
Reviewed-by: Eric Blake
Signed-off-by: Max Reitz
---
qemu-img-cmds.hx | 4 ++--
1 file changed, 2 inser
From: Eric Blake
When converting a 1.1 image down to 0.10, qemu-iotests 060 forces
a contrived failure where allocating a cluster used to replace a
zero cluster reads unaligned data. Since it is a zero cluster
rather than a data cluster being converted, changing the error
message to match our ea
From: "Daniel P. Berrange"
The '--image-opts' flag indicates whether the source filename
includes options. The target filename has to remain in the
plain filename format though, since it needs to be passed to
bdrv_create(). When using --skip-create though, it would be
possible to use image-opts
From: Stephen Bates
Implement NVMe Controller Memory Buffers (CMBs) which were added in
version 1.2 of the NVMe Specification. This patch adds an optional
argument (cmb_size_mb) which indicates the size of the CMB (in
MB). Currently only the Submission Queue Support (SQS) is enabled
which aligns
From: "Daniel P. Berrange"
The --image-opts flag can only be used to affect the parsing
of the source image. The target image has to be specified in
the traditional style regardless, since it needs to be passed
to the bdrv_create() API which does not support the new style
opts.
Reviewed-by: Fam
1 - 100 of 216 matches
Mail list logo
