Re: [Qemu-devel] [RFC 2/3] QMP: rate limit BLOCK_IO_ERROR

2014-08-16 Thread Paolo Bonzini
Il 11/08/2014 13:15, Daniel P. Berrange ha scritto: >> > 1. Don't throttle. Client can rely on events as long as it keeps the >> >QMP connection alive. Client should poll after establishing the QMP >> >connection. > A malicious guest OS can flood libvirt with events in this way. Of course

[Qemu-devel] [Bug 1335444] Re: qemu loses serial console data on EAGAIN

2014-08-16 Thread Paolo Bonzini
Please open a separate bug. Each serial device implementation must support flow control separately. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-16 Thread Paolo Bonzini
Il 15/08/2014 22:15, Paolo Bonzini ha scritto: >> > | Random throughput | Sequential throughput >> > +---+--- >> > master | 442 MB/s | 730 MB/s >> > base| 453 MB/s | 757 MB/s >> > bypass (Ming

Re: [Qemu-devel] QEMU, self-modifying code, and Windows 7 64-bit (no KVM)

2014-08-16 Thread Paolo Bonzini
Il 15/08/2014 23:49, Hulin, Patrick - 0559 - MITLL ha scritto: >>> In this case, the write is 8 bytes and unaligned, so it gets split >>> into 8 single-byte writes. In stock QEMU, these writes are done in >>> reverse order (see the loop in softmmu_template.h, line 402). The >>> third decryption xor

Re: [Qemu-devel] [RFC PATCH 00/11] Adding FreeBSD's Capsicum security framework (part 1)

2014-08-16 Thread Pavel Machek
Hi! > >>> I think that's more easily done by opening the file as O_RDONLY/O_WRONLY > >>> /O_RDWR. You could do it by running the file descriptor's seccomp-bpf > >>> program once per iocb with synthesized syscall numbers and argument > >>> vectors. > >> > >> > >> Right, but generating the equival

[Qemu-devel] [PATCH 4/4] qcow2: Check L1/L2/reftable entries for alignment

2014-08-16 Thread Max Reitz
Offsets taken from the L1, L2 and refcount tables are generally assumed to be correctly aligned. However, this cannot be guaranteed if the image has been written to by something different than qemu, thus check all offsets taken from these tables for correct cluster alignment. Signed-off-by: Max Re

[Qemu-devel] [PATCH 3/4] iotests: Fix output of 060

2014-08-16 Thread Max Reitz
With qcow2_pre_write_overlap_check() relying on qcow2_signal_corruption(), the output in case of a corruption changes. Therefore, 060's output has to be adapted accordingly. Signed-off-by: Max Reitz --- tests/qemu-iotests/060.out | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 2/4] qcow2: Use qcow2_signal_corruption() for overlaps

2014-08-16 Thread Max Reitz
Use the new function in case of a failed overlap check. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 3b77470..0ac1339 100644 --- a/block/qcow2

[Qemu-devel] [PATCH 1/4] qcow2: Add qcow2_signal_corruption()

2014-08-16 Thread Max Reitz
Add a helper function for easily marking an image corrupt while outputting an informative message to stderr and via QAPI. Signed-off-by: Max Reitz --- block/qcow2.c | 28 block/qcow2.h | 4 2 files changed, 32 insertions(+) diff --git a/block/qcow2.c b/block/q

[Qemu-devel] [PATCH 0/4] qcow2: Check L1/L2/reftable entries for alignment

2014-08-16 Thread Max Reitz
The image fuzzer from Maria exposed a lot of assertions which might fail in qemu when fed with a broken qcow2 image. Some of them are related to qemu trusting the offsets given in the L1, L2 and refcount tables to always be properly aligned on cluster boundaries (e.g. https://bugs.launchpad.net/qem

Re: [Qemu-devel] [PATCH v4 27/33] target-i386: Register X86CPU "feat-kvmclock" feature

2014-08-16 Thread Michael S. Tsirkin
On Thu, Aug 14, 2014 at 08:59:17PM -0300, Eduardo Habkost wrote: > On Thu, Aug 14, 2014 at 11:08:30PM +0200, Michael S. Tsirkin wrote: > > On Thu, Aug 14, 2014 at 04:25:56PM -0300, Eduardo Habkost wrote: > > > The "kvmclock" feature is special because it affects two bits in the KVM > > > CPUID leaf

Re: [Qemu-devel] [PATCH 2/3] arm_gic: SGIs for GICD_ICFGR are WI

2014-08-16 Thread Adam Lackorzynski
On Fri Aug 15, 2014 at 14:12:17 +0200, Christoffer Dall wrote: > On Sun, Aug 03, 2014 at 10:53:46AM +0200, Adam Lackorzynski wrote: > > Writes to SGIs for GICD_ICFGR register must be ignored. > > > > Signed-off-by: Adam Lackorzynski > > --- > > hw/intc/arm_gic.c | 11 +++ > > 1 file chan

[Qemu-devel] [PATCH 0/3] arm_gic: Improve handling of GICD_ICFGR

2014-08-16 Thread Adam Lackorzynski
The following patches address the behavior of the GICD_ICFGR register in the ARM GIC. Changes to previous version: - Setting of model mode only for old GIC revisions - Less invasive change for PPI settings Adam

[Qemu-devel] [PATCH 3/3] arm_gic: Do not force PPIs to edge-triggered mode

2014-08-16 Thread Adam Lackorzynski
Only SGIs must be WI, done by forcing them to their default (edge-triggered). Signed-off-by: Adam Lackorzynski --- hw/intc/arm_gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c index e546647..55019c9 100644 --- a/hw/intc/arm_gic.c +++

[Qemu-devel] [PATCH 2/3] arm_gic: GICD_ICFGR: Write model only for pre v1 GICs

2014-08-16 Thread Adam Lackorzynski
Setting the model is only available in pre-v1 GIC models. --- hw/intc/arm_gic.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c index d2b1aaf..e546647 100644 --- a/hw/intc/arm_gic.c +++ b/hw/intc/arm_gic.c @@ -561,10 +561,12 @@ s

[Qemu-devel] [PATCH 1/3] arm_gic: Fix read of GICD_ICFGR

2014-08-16 Thread Adam Lackorzynski
The GICD_ICFGR register covers 4 interrupts per byte. Acked-by: Christoffer Dall Signed-off-by: Adam Lackorzynski --- hw/intc/arm_gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c index 1532ef9..d2b1aaf 100644 --- a/hw/intc/arm_gic.c

Re: [Qemu-devel] [ARM - FCVT inst] : Difference in calculated value

2014-08-16 Thread Peter Maydell
On 16 August 2014 20:06, Gaurav Sharma wrote: > Can some one confirm is this is an issue with qemu implementation ? It's on my todo list to look at. If you want to confirm it as a QEMU bug your best bet is to write a short test program and compare the output on QEMU against running it on real har

Re: [Qemu-devel] [ARM - FCVT inst] : Difference in calculated value

2014-08-16 Thread Gaurav Sharma
Can some one confirm is this is an issue with qemu implementation ? Thanks, Gaurav On Thu, Aug 14, 2014 at 1:07 PM, Gaurav Sharma wrote: > I am trying to execute a 'fcvt' instruction for conversion from single > precision to half precision value. > with the following values : > > [Instrn] > fc

[Qemu-devel] [PATCH 2/3] qemu-io: Respect early image end for map

2014-08-16 Thread Max Reitz
bdrv_is_allocated() may report zero clusters which most probably means the image (file) is shorter than expected. Respect this case in order to avoid an infinite loop. Signed-off-by: Max Reitz --- qemu-io-cmds.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-io-cmds

[Qemu-devel] [PATCH 0/3] block: Fix is_allocated() for truncated images

2014-08-16 Thread Max Reitz
Patch 2: The bdrv_is_allocated() functions may return a number of zero sectors e.g. if a sector beyond the image end has been queried. Respect this case in qemu-io's map implementation so it doesn't run into an infinite loop (https://bugs.launchpad.net/qemu/+bug/1356969). Patch 1: In that bug repo

[Qemu-devel] [PATCH 3/3] iotests: Add test for map commands

2014-08-16 Thread Max Reitz
Add a test for qemu-img map and qemu-io -c map on truncated files. Signed-off-by: Max Reitz --- tests/qemu-iotests/102 | 64 ++ tests/qemu-iotests/102.out | 11 tests/qemu-iotests/group | 1 + 3 files changed, 76 insertions(+) create m

[Qemu-devel] [PATCH 1/3] block: Ignore allocation size in underlying file

2014-08-16 Thread Max Reitz
When falling through to the underlying file in bdrv_co_get_block_status(), do not let the number of sectors for which information could be obtained be overwritten. Signed-off-by: Max Reitz --- block.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c ind

Re: [Qemu-devel] [question] qemu-2.0.0 difference between download from http://wiki.qemu.org/Download and download http://git.qemu.org/qemu.git

2014-08-16 Thread Peter Maydell
On 16 August 2014 03:24, Zhang Haoyu wrote: > I download one copy of qemu-2.0.0 from http://wiki.qemu.org/Download, > and then download another copy of qemu-2.0.0 from http://git.qemu.org/qemu.git The latter of these is our git repository. pixman, dtc and roms are kept in git submodules, and git

[Qemu-devel] [Bug 1357445] Re: qemu-img: 'amend -o compat=0.10' command failed with segfault on the fuzzed image

2014-08-16 Thread Max Reitz
Hi, being on 2d591ce2aeebf, I rather receive "qemu-img: Error while amending options: File too large". Judging from the traces, though, this issue (the segfault at least) should be fixed by my "[PATCH v3 0/7] block/qcow2: Improve zero cluster expansion" series anyway (when merged eventually). Max

[Qemu-devel] [Bug 1357440] Re: qemu-img: Assert for 'amend' command and the fuzzed image

2014-08-16 Thread Max Reitz
Hi, This issue should be fixed by my "[PATCH v3 0/7] block/qcow2: Improve zero cluster expansion" series. However, there are similar issues in qemu, so we'll probably need a function to quickly mark an image corrupt instead of throwing these assertions. Max -- You received this bug notificatio

[Qemu-devel] [Bug 1335444] Re: qemu loses serial console data on EAGAIN

2014-08-16 Thread Andreas Gustafsson
Although the bug has been fixed in qemu-system-i386 and qemu-system- x86_64, it is still present in qemu-system-sparc. I'm attaching an updated version of the "Method 1" shell script which reproduces the problem with qemu 2.1.0. When I run it, the last output is: <0919> <0920> <092964

Re: [Qemu-devel] [questions] about using vfio to assign sr-iov vf to vm

2014-08-16 Thread Alex Williamson
On Sat, 2014-08-16 at 14:48 +0800, Zhang Haoyu wrote: > >> Hi, all > >> I'm using VFIO to assign intel 82599 VF to VM, now I encounter a problem, > >> 82599 PF and its VFs belong to the same iommu_group, but I only want to > >> assign some VFs to one VM, and some other VFs to another VM, ..., > >>

Re: [Qemu-devel] vexpress-a9: coreboot is unable to push any data on stack

2014-08-16 Thread Peter Maydell
On 16 August 2014 10:50, Piotr Król wrote: > On Fri, Aug 15, 2014 at 11:54:55PM +0100, Peter Maydell wrote: >> I'm not looking for advocacy, just for an explanation of what it's >> doing, and in particular whether anybody's ever tested this on real >> hardware. (Running guest code only on QEMU is

Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12

2014-08-16 Thread Peter Maydell
On 16 August 2014 02:08, Eric Blake wrote: > In file included from /usr/include/spice-server/spice.h:25:0, > from /home/eblake/qemu-tmp/include/ui/qemu-spice.h:25, > from qemu-char.c:84: > /usr/include/spice-1/spice/macros.h:105:0: error: "INLINE" redefined > [-We

Re: [Qemu-devel] vexpress-a9: coreboot is unable to push any data on stack

2014-08-16 Thread Piotr Król
On Fri, Aug 15, 2014 at 11:54:55PM +0100, Peter Maydell wrote: > I'm not looking for advocacy, just for an explanation of what it's > doing, and in particular whether anybody's ever tested this on real > hardware. (Running guest code only on QEMU is a recipe for bugs, > because our emulation is oft

Re: [Qemu-devel] [PATCH v3 0/5] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset

2014-08-16 Thread Jan Kiszka
On 2014-08-16 10:45, Jan Kiszka wrote: > On 2014-08-16 09:54, Knut Omang wrote: >> On Fri, 2014-08-15 at 19:37 +0800, Le Tan wrote: >>> Hi Knut, >>> >>> 2014-08-15 19:15 GMT+08:00 Knut Omang : On Fri, 2014-08-15 at 06:42 +0200, Knut Omang wrote: > On Thu, 2014-08-14 at 14:10 +0200, Jan Kis

Re: [Qemu-devel] [PATCH v3 0/5] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset

2014-08-16 Thread Jan Kiszka
On 2014-08-16 09:54, Knut Omang wrote: > On Fri, 2014-08-15 at 19:37 +0800, Le Tan wrote: >> Hi Knut, >> >> 2014-08-15 19:15 GMT+08:00 Knut Omang : >>> On Fri, 2014-08-15 at 06:42 +0200, Knut Omang wrote: On Thu, 2014-08-14 at 14:10 +0200, Jan Kiszka wrote: > On 2014-08-14 13:15, Michael S

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-16 Thread Ming Lei
On 8/16/14, Paolo Bonzini wrote: > Il 14/08/2014 12:46, Kevin Wolf ha scritto: >> So to finally reply with some numbers... I'm running fio tests based on >> Ming's configuration on a loop-mounted tmpfs image using dataplane. > > I'm not sure tmpfs is a particularly useful comparison, since it does

Re: [Qemu-devel] [PATCH v3 0/5] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset

2014-08-16 Thread Knut Omang
On Fri, 2014-08-15 at 19:37 +0800, Le Tan wrote: > Hi Knut, > > 2014-08-15 19:15 GMT+08:00 Knut Omang : > > On Fri, 2014-08-15 at 06:42 +0200, Knut Omang wrote: > >> On Thu, 2014-08-14 at 14:10 +0200, Jan Kiszka wrote: > >> > On 2014-08-14 13:15, Michael S. Tsirkin wrote: > >> > > On Mon, Aug 11,