Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Thu) 15 May 2014 [08:49:48], Greg Kurz wrote: > On Thu, 15 May 2014 11:34:25 +0530 > Amit Shah wrote: > > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > There is a need to add some more fields to VirtIODevice that should be > > > migrated (broken status, endianness). The problem is

Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Gerd Hoffmann
> > > static Property serial_pci_properties[] = { > > > DEFINE_PROP_CHR("chardev", PCISerialState, state.chr), > > > +DEFINE_PROP_UINT8("compat", PCISerialState, compat, 0), > > > DEFINE_PROP_END_OF_LIST(), > > > }; > > > > mst, do you take that through the pci tree? > > > > che

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-14 Thread Markus Armbruster
Max Reitz writes: > On 14.05.2014 14:33, Markus Armbruster wrote: >> Max Reitz writes: >> >>> Currently, QEMU's iotests rely on /usr/bin/env to start the correct >>> Python (that is, at least Python 2.4, but not 3). On systems where >>> Python 3 is the default, the user has no clean way of makin

Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os

2014-05-14 Thread Gerd Hoffmann
Hi, > Well then, may I post a formal patch for this issue, Gerd? Thanks. I'd like to know what the root cause for the lost interrupt is. Not implementing PIRQ enable could be it, especially as the guest os seems to use it (otherwise your patch would have no effect). The check for the PIRQ ena

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Greg Kurz
On Thu, 15 May 2014 11:34:25 +0530 Amit Shah wrote: > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > There is a need to add some more fields to VirtIODevice that should be > > migrated (broken status, endianness). The problem is that we do not > > want to break compatibility while adding a

Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration

2014-05-14 Thread Gonglei (Arei)
> -Original Message- > From: Michael R. Hines [mailto:mrhi...@linux.vnet.ibm.com] > Sent: Thursday, May 15, 2014 8:44 AM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); quint...@redhat.com; dgilb...@redhat.com; > owass...@redhat.com; mrhi...@us.ibm.com; pbonz...@redhat.c

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Thu) 15 May 2014 [09:23:51], Michael S. Tsirkin wrote: > On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > > There is a need to add some more fields to VirtIODevice that should be > > > migrated (broken status, endianness). The

Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 08:42:17AM +0200, Gerd Hoffmann wrote: > On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote: >^^ > Looks like your clock is _way_ off. > > > +if (!pci->compat) { > > +pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */ > > +} >

Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Gerd Hoffmann
On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote: ^^ Looks like your clock is _way_ off. > +if (!pci->compat) { > +pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */ > +} > static Property serial_pci_properties[] = { > DEFINE_PROP_CHR("charde

Re: [Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread Michael S. Tsirkin
On Thu, Feb 27, 2014 at 02:05:05AM +0100, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- This looks sane, a minor comment below (hopefully last). Thanks! > v2: resubmission after pc-2.1 is added with the multiport case > v3: added compatibility check to avoid changing earlier tha

Re: [Qemu-devel] [PATCH] SMI handler should set the CPL to zero and save and restore it on rsm.

2014-05-14 Thread Paolo Bonzini
Il 15/05/2014 03:32, Kevin O'Connor ha scritto: On Wed, May 14, 2014 at 08:20:59PM -0400, Kevin O'Connor wrote: On Wed, May 14, 2014 at 10:05:47AM +0200, Paolo Bonzini wrote: CPL isn't even altered when CS is reloaded, because you cannot jump out of ring-0 except with an inter-privilege IRET, a

[Qemu-devel] pidfile option in config file

2014-05-14 Thread William Dauchy
Hello, I'm using the `-pidfile` option in my qemu command line. Since I'm also using the `-readconfig` option I thought it was a good thing to include the pidfile option in my config file. Unfortunately I did not found any possibility to add such option in my config file. Is it something I could e

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Michael S. Tsirkin
On Thu, May 15, 2014 at 11:34:25AM +0530, Amit Shah wrote: > On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > > There is a need to add some more fields to VirtIODevice that should be > > migrated (broken status, endianness). The problem is that we do not > > want to break compatibility while add

Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

2014-05-14 Thread Amit Shah
On (Wed) 14 May 2014 [17:41:38], Greg Kurz wrote: > There is a need to add some more fields to VirtIODevice that should be > migrated (broken status, endianness). The problem is that we do not > want to break compatibility while adding a new feature... This issue has > been addressed in the generic

[Qemu-devel] Qemu stucking

2014-05-14 Thread sonia verma
Hi I'm getting below error when trying to boot the KVM with ethernet bridging,kvm support and universel TUN enabled by the following command.. /usr/bin/qemu-system-ppc64 -m 512 -nographic -hda /var/volatile/debian_lenny_ powerpc_standard.qcow2 cannot manage 'OHCI USB controller' PCI device type

Re: [Qemu-devel] [PATCHv4] block: optimize zero writes with bdrv_write_zeroes

2014-05-14 Thread Peter Lieven
Am 14.05.2014 13:41, schrieb Kevin Wolf: > Am 08.05.2014 um 18:22 hat Peter Lieven geschrieben: >> this patch tries to optimize zero write requests >> by automatically using bdrv_write_zeroes if it is >> supported by the format. >> >> This significantly speeds up file system initialization and >> s

Re: [Qemu-devel] [PATCH v3] vmdk: Optimize cluster allocation

2014-05-14 Thread Fam Zheng
On Wed, 05/14 16:23, Kevin Wolf wrote: > Am 08.05.2014 um 07:57 hat Fam Zheng geschrieben: > > This drops the unnecessary bdrv_truncate() from, and also improves, > > cluster allocation code path. > > [...] > > > > Tested that this passes qemu-iotests for all VMDK subformats. > > > > Signed-off-b

[Qemu-devel] [PATCH 3/5] block: make 'top' argument to block-commit optional

2014-05-14 Thread Jeff Cody
Now that active layer block-commit is supported, the 'top' argument no longer needs to be mandatory. Change it optional, with the default being the active layer in the device chain. Signed-off-by: Jeff Cody --- blockdev.c | 3 ++- qapi-schema.json | 7 --- qmp-commands.h

[Qemu-devel] [PATCH 4/5] block: Accept node-name arguments for block-commit

2014-05-14 Thread Jeff Cody
This modifies the block operation block-commit so that it will accept node-name arguments for either 'top' or 'base' BDS. The filename and node-name are mutually exclusive to each other; i.e.: "top" and "top-node-name" are mutually exclusive (enforced) "base" and "base-node-name" are mutua

[Qemu-devel] [PATCH 2/5] block: add helper function to determine if a BDS is in a chain

2014-05-14 Thread Jeff Cody
This is a small helper function, to determine if 'base' is in the chain of BlockDriverState 'top'. It returns true if it is in the chain, and false otherwise. If either argument is NULL, it will also return false. Signed-off-by: Jeff Cody --- block.c | 9 + include/block/

[Qemu-devel] [PATCH 5/5] block: extend block-commit to accept a string for the backing file

2014-05-14 Thread Jeff Cody
On some image chains, QEMU may not always be able to resolve the filenames properly, when updating the backing file of an image after a block commit. For instance, certain relative pathnames may fail, or drives may have been specified originally by file descriptor (e.g. /dev/fd/???), or a relative

[Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

2014-05-14 Thread Jeff Cody
Currently, node_name is only filled in when done so explicitly by the user. If no node_name is specified, then the node name field is not populated. If node_names are automatically generated when not specified, that means that all block job operations can be done by reference to the unique node_n

[Qemu-devel] [PATCH 0/5] block: Modify block-commit to use node-names

2014-05-14 Thread Jeff Cody
Using node-names instead of filenames for block job operations over QMP is a superior method of identifying the block driver images to operate on, as it removes all pathname ambiguity. This series is the conversion of block-commit to allow use of node-names. Also, it allows the user to specify th

[Qemu-devel] [PULL 2/6] Split ram_save_block

2014-05-14 Thread Juan Quintela
From: "Dr. David Alan Gilbert" ram_save_block is getting a bit too complicated, and does two separate things: 1) Finds a page to send 2) Sends the page (dealing with compression etc) Split into 'ram_save_page' to send the page and deal with compression (2) Rename remaining function to 'ram

[Qemu-devel] [PULL 0/6] migration queue

2014-05-14 Thread Juan Quintela
Hi peter This pull request includes: - split ram_save_block into two functions (David) - simplify code for load_xbzrle (Chen) - fix usb tests (fix on top of previous fixes)) (mst) - calculate at time of printing throughput (peter) - cleanup rest & usb devices version_minimum_id_old (qunitela) Ple

Re: [Qemu-devel] [PULL 5/6] migration: show average throughput when migration finishes

2014-05-14 Thread Eric Blake
On 05/14/2014 07:40 PM, Juan Quintela wrote: > From: Peter Lieven > > currently the value of the throughput field contains whatever > was the last calculated throughput shortly before the migration > finished. > > This patch updates the post migration contents of the field to > the average throu

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-14 Thread Fam Zheng
On Thu, 05/15 01:41, Max Reitz wrote: > On 14.05.2014 14:33, Markus Armbruster wrote: > >Max Reitz writes: > > > >>Currently, QEMU's iotests rely on /usr/bin/env to start the correct > >>Python (that is, at least Python 2.4, but not 3). On systems where > >>Python 3 is the default, the user has no

Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os

2014-05-14 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, May 14, 2014 6:26 PM > To: Gonglei (Arei); Gerd Hoffmann > Cc: qemu-devel@nongnu.org; Huangweidong (C); Michael S. Tsirkin > Subject: Re: usb: usb tablet freeze when save/restore guest os > > Il

[Qemu-devel] [PULL 5/6] migration: show average throughput when migration finishes

2014-05-14 Thread Juan Quintela
From: Peter Lieven currently the value of the throughput field contains whatever was the last calculated throughput shortly before the migration finished. This patch updates the post migration contents of the field to the average throughput. Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonz

[Qemu-devel] [PULL 4/6] savevm: Remove all the unneeded version_minimum_id_old (rest)

2014-05-14 Thread Juan Quintela
After previous Peter patch, they are redundant. This way we don't assign them except when needed. Once there, there were lots of case where the ".fields" indentation was wrong: .fields = (VMStateField []) { and .fields = (VMStateField []) { Change all the combinations to: .

[Qemu-devel] [PULL 6/6] usb: fix up post load checks

2014-05-14 Thread Juan Quintela
From: "Michael S. Tsirkin" Correct post load checks: 1. dev->setup_len == sizeof(dev->data_buf) seems fine, no need to fail migration 2. When state is DATA, passing index > len will cause memcpy with negative length, resulting in heap overflow First of the issues was reported by dgilbe

[Qemu-devel] [PULL 3/6] savevm: Remove all the unneeded version_minimum_id_old (usb)

2014-05-14 Thread Juan Quintela
After previous Peter patch, they are redundant. This way we don't assign them except when needed. Once there, there were lots of case where the ".fields" indentation was wrong: .fields = (VMStateField []) { and .fields = (VMStateField []) { Change all the combinations to: .

[Qemu-devel] [PULL 1/6] arch_init: Simplify code for load_xbzrle()

2014-05-14 Thread Juan Quintela
From: Chen Gang For xbzrle_decode_buffer(), when decoding contents will exceed writing buffer, it will return -1, so need not check the return value whether large than writing buffer. And when failure occurs within load_xbzrle(), it always return -1 without any resources which need release. So

Re: [Qemu-devel] [PATCH v3 21/25] vmdk: implement .bdrv_detach/attach_aio_context()

2014-05-14 Thread Fam Zheng
On Thu, 05/08 16:34, Stefan Hajnoczi wrote: > Implement .bdrv_detach/attach_aio_context() interfaces to propagate > detach/attach to BDRVVmdkState->extents[].file. The block layer takes > care of ->file and ->backing_hd but doesn't know about our extents > BlockDriverStates, which is also part of

Re: [Qemu-devel] [PATCH] SMI handler should set the CPL to zero and save and restore it on rsm.

2014-05-14 Thread Kevin O'Connor
On Wed, May 14, 2014 at 08:20:59PM -0400, Kevin O'Connor wrote: > On Wed, May 14, 2014 at 10:05:47AM +0200, Paolo Bonzini wrote: > > CPL isn't even altered when CS is reloaded, because you cannot jump out > > of ring-0 except with an inter-privilege IRET, and that reloads SS too. > > > > An IRET o

[Qemu-devel] [PATCH] MAINTAINERS: update Calxeda Highbank maintainer and status

2014-05-14 Thread Rob Herring
From: Rob Herring Signed-off-by: Rob Herring --- Mark, I guessing you don't want to stay as maintainer? MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 97c9fa1..5ad7dcc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -243,8 +243

Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration

2014-05-14 Thread Michael R. Hines
On 05/09/2014 12:25 PM, Gonglei (Arei) wrote: Hi, -Original Message- From: Michael R. Hines [mailto:mrhi...@linux.vnet.ibm.com] Sent: Tuesday, April 01, 2014 8:42 AM To: Gonglei (Arei); qemu-devel@nongnu.org Cc: Huangweidong (C); quint...@redhat.com; dgilb...@redhat.com; owass...@redhat

Re: [Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-05-14 Thread Peter Crosthwaite
On Tue, May 6, 2014 at 11:41 AM, Peter Crosthwaite wrote: > On Tue, Apr 29, 2014 at 2:57 AM, Peter Maydell > wrote: >> On 15 April 2014 04:18, Peter Crosthwaite >> wrote: >>> Add support for 16, 32 and 64 bit width FIFOs. The push and pop >>> functions are replicated to accept all four differe

Re: [Qemu-devel] [PATCH v2] qcow2: Patch for shrinking qcow2 disk image

2014-05-14 Thread Max Reitz
On 09.05.2014 17:20, Jun Li wrote: As the realization of raw shrinking, so when do qcow2 shrinking, do not *when doing check l1 entries. When resize to size1(size1 < "disk size"), the custemer *customer knows this will destory the data. So no need to check the l1 entries which is used or

Re: [Qemu-devel] [PATCH] SMI handler should set the CPL to zero and save and restore it on rsm.

2014-05-14 Thread Kevin O'Connor
On Wed, May 14, 2014 at 10:05:47AM +0200, Paolo Bonzini wrote: > CPL isn't even altered when CS is reloaded, because you cannot jump out > of ring-0 except with an inter-privilege IRET, and that reloads SS too. > > An IRET or task switch is also the only way to set EFLAGS.VM, and it will > hardcod

Re: [Qemu-devel] [PATCH 5/7] target-arm: add emulation of PSCI calls for system emulation

2014-05-14 Thread Rob Herring
On Wed, May 14, 2014 at 1:12 PM, Peter Maydell wrote: > On 5 May 2014 17:00, Rob Herring wrote: >> From: Rob Herring >> >> Add support for handling PSCI calls in system emulation. Both version >> 0.1 and 0.2 of the PSCI spec are supported. Platforms can enable support >> by setting "psci-method"

Re: [Qemu-devel] [PATCH v2] qemu-img fails to delete last snapshot

2014-05-14 Thread Max Reitz
On 12.05.2014 22:27, Mike Day wrote: When deleting the last snapshot, copying the resulting snapshot table currently fails, causing the delete operation to also fail. Fix the failure by skipping the copy and just writing the snapshot header and freeing the extra clusters. There are two specific

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-14 Thread Max Reitz
On 14.05.2014 14:33, Markus Armbruster wrote: Max Reitz writes: Currently, QEMU's iotests rely on /usr/bin/env to start the correct Python (that is, at least Python 2.4, but not 3). On systems where Python 3 is the default, the user has no clean way of making the iotests use the correct binary

[Qemu-devel] [PATCH 2/4] curl: Remove broken parsing of options from url

2014-05-14 Thread Matthew Booth
The block layer now supports a generic json syntax for passing option parameters explicitly, making parsing of options from the url redundant. Signed-off-by: Matthew Booth --- block/curl.c | 52 ++-- 1 file changed, 10 insertions(+), 42 deletions(-

[Qemu-devel] [PATCH 3/4] curl: Add sslverify option

2014-05-14 Thread Matthew Booth
This allows qemu to use images over https with a self-signed certificate. It defaults to verifying the certificate. Signed-off-by: Matthew Booth --- block/curl.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/curl.c b/block/curl.c index 1b9f2f2..43d6646 100644 --- a/block

[Qemu-devel] [PATCH 4/4] curl: Add usage documentation

2014-05-14 Thread Matthew Booth
Signed-off-by: Matthew Booth --- qemu-options.hx | 68 + 1 file changed, 68 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 781af14..7587bce 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2191,6 +2191,74 @@ qemu-s

[Qemu-devel] [PATCH 1/4] curl: Fix build when curl_multi_socket_action isn't available

2014-05-14 Thread Matthew Booth
Signed-off-by: Matthew Booth --- block/curl.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/curl.c b/block/curl.c index d2f1084..f3c797a 100644 --- a/block/curl.c +++ b/block/curl.c @@ -37,6 +37,21 @@ #if LIBCURL_VERSION_NUM >= 0x071000 /* The multi interface timer

Re: [Qemu-devel] [Qemu-ppc] macio ide question/bug report

2014-05-14 Thread BALATON Zoltan
On Wed, 14 May 2014, Mark Cave-Ayland wrote: On 14/05/14 12:10, BALATON Zoltan wrote: The logs I've posted are with DEBUG_IDE_ATAPI, DEBUG_DBDMA and DEBUG_MACIO already enabled... Well sure, but not the ones in your last email - I had to go back several mails back into the thread to pull them

Re: [Qemu-devel] [PATCH v2] block/raw-posix: Try both FIEMAP and SEEK_HOLE

2014-05-14 Thread Max Reitz
On 11.05.2014 19:26, Christoph Hellwig wrote: On Tue, May 06, 2014 at 09:00:54PM +0200, Max Reitz wrote: The current version of raw-posix always uses ioctl(FS_IOC_FIEMAP) if FIEMAP is available; lseek with SEEK_HOLE/SEEK_DATA are not even compiled in in this case. However, there may be implement

Re: [Qemu-devel] [PATCH 6/7] arm/virt: enable PSCI emulation support for system emulation

2014-05-14 Thread Rob Herring
On Wed, May 14, 2014 at 4:25 PM, Peter Maydell wrote: > On 14 May 2014 20:15, Rob Herring wrote: >> On Wed, May 14, 2014 at 12:51 PM, Peter Maydell >> wrote: >>> My suggestion to Pranav was that we abstract away the "which PSCI >>> version?" decision into a field in ARMCPU, in which case we can

Re: [Qemu-devel] [PATCH] configure: Ensure tests/qemu-iotests exists before writing common.env

2014-05-14 Thread Max Reitz
On 14.05.2014 16:26, Peter Maydell wrote: Before we write common.env to the tests/qemu-iotests directory, ensure that it exists. This fixes out-of-tree builds from clean. Signed-off-by: Peter Maydell --- If somebody would like to review this I'll apply it to master as a buildfix... configure

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Greg Bellows
Thanks for the input Peter. >From briefly looking, it actually looks like the ARMv7 spec more strictly states that the default is secure. ARMv8 on the other hand appears to leave it open as implementation defined, Based on out past discussions, I assumed non-secure as the default and that appear

Re: [Qemu-devel] Curl updates

2014-05-14 Thread Eric Blake
On 05/14/2014 03:20 PM, Matthew Booth wrote: > >> Right, but we want that anyway. I applied Max's patches for the >> json: pseudo-protocol today, so we should have everything we need. > > I can't see this in block/master. Am I looking in the wrong place? git://repo.or.cz/qemu/kevin.git block o

[Qemu-devel] [Bug 1303926] Re: qemu-system-x86_64 crashed with SIGABRT

2014-05-14 Thread Serge Hallyn
Hi, the cause of this particular bug was introduced during 2014, so could not have been present in precise. We definately will want to figure out the cause of your bug, so please open a new bug report using 'ubuntu-bug qemu-kvm' immediately after a crash has happened. Thanks! ** Also affects: q

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Peter Maydell
On 14 May 2014 21:22, Greg Bellows wrote: > I suppose it depends on how true we want to be to the specification and > whether our default is NS=0 or NS=1 when the security extension is present > or not. The code currently assumes non-secure as the default state. The v8 ARM ARM at least allows th

Re: [Qemu-devel] [PATCH 6/7] arm/virt: enable PSCI emulation support for system emulation

2014-05-14 Thread Peter Maydell
On 14 May 2014 20:15, Rob Herring wrote: > On Wed, May 14, 2014 at 12:51 PM, Peter Maydell > wrote: >> My suggestion to Pranav was that we abstract away the "which PSCI >> version?" decision into a field in ARMCPU, in which case we can >> just have TCG always set it to 0.2. So some of this logic

[Qemu-devel] [Bug 1318830] Re: High CPU usage on windows virtual machine

2014-05-14 Thread Serge Hallyn
** Package changed: libvirt (Ubuntu) => qemu (Ubuntu) ** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1318830 Title: High CPU usage

Re: [Qemu-devel] Curl updates

2014-05-14 Thread Matthew Booth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/05/14 12:43, Kevin Wolf wrote: > Am 14.05.2014 um 18:08 hat Matthew Booth geschrieben: >> On 14/05/14 03:48, Kevin Wolf wrote: >>> Am 13.05.2014 um 21:47 hat Eric Blake geschrieben: On 05/08/2014 02:42 AM, Matthew Booth wrote: > [PATCH 1

Re: [Qemu-devel] [PATCH v2 19/23] target-arm: maintain common bits of banked CP registers

2014-05-14 Thread Greg Bellows
On 13 May 2014 11:16, Fabian Aggeler wrote: > Some of SCTRL bits are common for secure and non-secure state. > Translation table base masks are updated on NS-bit switch as > well as on TTBCR writes. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Fabian Aggeler > --- > target-arm/cpu.h|

Re: [Qemu-devel] [PATCH 3/7] target-arm: add hvc and smc exception emulation handling infrastructure

2014-05-14 Thread Rob Herring
On Wed, May 14, 2014 at 12:44 PM, Peter Maydell wrote: > On 5 May 2014 17:00, Rob Herring wrote: >> From: Rob Herring >> >> Add the infrastructure to handle and emulate hvc and smc exceptions. >> This will enable emulation of things such as PSCI calls. This commit >> does not change the behavior

Re: [Qemu-devel] Curl updates

2014-05-14 Thread Matthew Booth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14/05/14 13:02, Eric Blake wrote: > On 05/14/2014 10:06 AM, Matthew Booth wrote: > The new syntax is: http://user:passw...@example.com/path?query[opt1=val:opt2=val] > >> >> A URI can, by definition, contain a query strin

Re: [Qemu-devel] [PATCH RESEND v4 00/18] target-i386: CPU feature flag queue

2014-05-14 Thread Andreas Färber
Am 14.05.2014 21:29, schrieb Eduardo Habkost: > (Resending due to complete lack of feedback on v4 submission from 15 days > ago.) Marcelo had reminded me, and I had started review of the original v4, but not through yet. It looks as if the resend changed nothing, so I'll continue on that one. An

Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value

2014-05-14 Thread Michael Roth
Quoting Luiz Capitulino (2014-05-14 13:25:16) > On Wed, 14 May 2014 20:29:37 +0300 > Marcel Apfelbaum wrote: > > > On Wed, 2014-05-14 at 19:00 +0200, Andreas Färber wrote: > > > Am 13.05.2014 21:08, schrieb Eric Blake: > > > > On 05/13/2014 11:36 AM, Andreas Färber wrote: > > > >> Am 07.05.2014 1

Re: [Qemu-devel] [PATCH v3.2 11/31] numa: introduce memory_region_allocate_system_memory

2014-05-14 Thread Eduardo Habkost
On Wed, May 14, 2014 at 05:43:15PM +0800, Hu Tao wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Hu Tao > --- > hw/i386/pc.c| 4 +--- > include/hw/boards.h | 6 +- > include/sysemu/sysemu.h | 1 + > numa.c | 9 + > 4 f

[Qemu-devel] [PATCH RESEND v4 09/18] target-i386: Define TCG_*_FEATURES earlier on cpu.c

2014-05-14 Thread Eduardo Habkost
Those macros will be used in the feature_word_info array data, so need to be defined earlier. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Rebase to latest qom-cpu (commit 90c5d39c) Changes v2 -> v3: * Trivial rebase after QEMU 2.0 (onto commit 2d03b49) --- target-i386/cpu.c | 117 ++

Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value

2014-05-14 Thread Andreas Färber
Am 14.05.2014 19:29, schrieb Marcel Apfelbaum: > On Wed, 2014-05-14 at 19:00 +0200, Andreas Färber wrote: >> Am 13.05.2014 21:08, schrieb Eric Blake: >>> On 05/13/2014 11:36 AM, Andreas Färber wrote: Am 07.05.2014 16:42, schrieb Marcel Apfelbaum: > A NULL value is not added to visitor's st

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Greg Bellows
I suppose it depends on how true we want to be to the specification and whether our default is NS=0 or NS=1 when the security extension is present or not. The code currently assumes non-secure as the default state. Is there a convention in qemu? How closely do we attempt to stay to the pseudo co

Re: [Qemu-devel] [PATCH v3.2 10/31] pc: pass QEMUMachineInitArgs to pc_memory_init

2014-05-14 Thread Eduardo Habkost
On Wed, May 14, 2014 at 05:43:14PM +0800, Hu Tao wrote: > From: Paolo Bonzini > > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Paolo Bonzini > Signed-off-by: Hu Tao Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH v3.2 09/31] qmp: improve error reporting for -object and object-add

2014-05-14 Thread Eduardo Habkost
On Wed, May 14, 2014 at 05:43:13PM +0800, Hu Tao wrote: > From: Paolo Bonzini > > Use QERR_INVALID_PARAMETER_VALUE for consistency. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Hu Tao Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [Qemu-ppc] macio ide question/bug report

2014-05-14 Thread Mark Cave-Ayland
On 14/05/14 12:10, BALATON Zoltan wrote: I've tried doing this and it seems that the cmd_read_toc_pma_atip function returns all right (via the case 0 path) with a 20 byte result array and calls ide_atapi_cmd_reply which takes the DMA path as s->atapi_dma is set to 1 and the error comes from some

Re: [Qemu-devel] [PATCH v3.2 06/31] man: improve -numa doc

2014-05-14 Thread Eduardo Habkost
On Wed, May 14, 2014 at 05:43:10PM +0800, Hu Tao wrote: > From: Luiz Capitulino > > The -numa option documentation in qemu's manpage lacks the command-line > options and some information regarding how it relates to options -m and > -smp. This commit fills in the missing text. > > Signed-off-by:

[Qemu-devel] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-05-14 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- v2: resubmission after pc-2.1 is added with the multiport case v3: added compatibility check to avoid changing earlier than pc-2.1 hw/char/serial-pci.c | 11 +++ include/hw/i386/pc.h | 15 +++ 2 files changed, 26 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value

2014-05-14 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 14 May 2014 20:29:37 +0300 > Marcel Apfelbaum wrote: > >> On Wed, 2014-05-14 at 19:00 +0200, Andreas Färber wrote: >> > Am 13.05.2014 21:08, schrieb Eric Blake: >> > > On 05/13/2014 11:36 AM, Andreas Färber wrote: >> > >> Am 07.05.2014 16:42, schrieb Marcel Apfe

Re: [Qemu-devel] [PATCH 11/18] block/vvfat: Propagate errors through init_directories()

2014-05-14 Thread Markus Armbruster
Eric Blake writes: > On 05/13/2014 10:02 AM, Markus Armbruster wrote: >> Completes the conversion of the open method to Error started in commit >> 015a103. >> >> Signed-off-by: Markus Armbruster >> --- >> block/vvfat.c | 16 +--- >> 1 file changed, 9 insertions(+), 7 deletions(-) >

[Qemu-devel] qemu error

2014-05-14 Thread sonia verma
Hi I'm getting below error when trying to boot the KVM with ethernet bridging,kvm support and universel TUN enabled by the following command.. /usr/bin/qemu-system-ppc64 -m 512 -nographic -hda /var/volatile/debian_lenny_powerpc_standard.qcow2 cannot manage 'OHCI USB controller' PCI device type

[Qemu-devel] [PATCH RESEND v4 14/18] target-i386: Add "migratable" property to "host" CPU model

2014-05-14 Thread Eduardo Habkost
This flag will allow the user to choose between two modes: * All flags that can be enabled on the host, even if unmigratable (migratable=no); * All flags that can be enabled on the host, known to QEMU, and migratable (migratable=yes). The default is still migratable=false, to keep current

[Qemu-devel] [PATCH RESEND v4 12/18] target-i386: Support check/enforce flags in TCG mode, too

2014-05-14 Thread Eduardo Habkost
If enforce/check is specified in TCG mode, QEMU will ensure all CPU features are supported by TCG, so no CPU feature is silently disabled. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (Reviewed-by lin

[Qemu-devel] [PATCH RESEND v4 18/18] target-i386: support "invariant tsc" flag

2014-05-14 Thread Eduardo Habkost
From: Marcelo Tosatti Expose "Invariant TSC" flag, if KVM is enabled. From Intel documentation: 17.13.1 Invariant TSC The time stamp counter in newer processors may support an enhancement, referred to as invariant TSC. Processor’s support for invariant TSC is indicated by CPUID.8007H:EDX[8].

[Qemu-devel] [PATCH RESEND v4 15/18] target-i386: Set migratable=yes by default

2014-05-14 Thread Eduardo Habkost
Having only migratable flags reported by default on the "host" CPU model is safer for the following reasons: * Existing users may expect "-cpu host" to be migration-safe, if they take care of always using compatible host CPUs, host kernels, and QEMU versions. * Users who don't care aboug m

[Qemu-devel] [PATCH RESEND v4 13/18] target-i386: Support "-cpu host" in TCG mode

2014-05-14 Thread Eduardo Habkost
As "-cpu host" simply means "enable every bit that can be enabled on this host", we can emulate similar behavior even if KVM is not enabled. We just need to set all feature bits supported by TCG, accordingly. Signed-off-by: Eduardo Habkost --- Changes v2: * Coding style fix (break long lines) --

[Qemu-devel] [PATCH RESEND v4 11/18] target-i386: Loop-based feature word filtering in TCG mode

2014-05-14 Thread Eduardo Habkost
Instead of manually filtering each feature word, add a tcg_features field to FeatureWordInfo, and use that field to filter all feature words in TCG mode. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (

[Qemu-devel] [PATCH RESEND v4 10/18] target-i386: Loop-based copying and setting/unsetting of feature words

2014-05-14 Thread Eduardo Habkost
Now that we have the feature word arrays, we don't need to manually copy each array item, we can simply iterate through each feature word. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 35 ++- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git

[Qemu-devel] [PATCH RESEND v4 05/18] target-i386: Isolate KVM-specific code on CPU feature filtering logic

2014-05-14 Thread Eduardo Habkost
This will allow us to re-use the feature filtering logic (and the check/enforce flag logic) for TCG. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (Reviewed-by line kept) Changes v2 -> v3: * Trivial r

[Qemu-devel] [PATCH RESEND v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed

2014-05-14 Thread Eduardo Habkost
From: Marcelo Tosatti Invariant TSC documentation mentions that "invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states". This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is performed. So block migration/savevm. Cc: Juan Quint

[Qemu-devel] [PATCH RESEND v4 08/18] target-i386: Filter KVM and 0xC0000001 features on TCG

2014-05-14 Thread Eduardo Habkost
TCG doesn't support any of the feature flags on FEAT_KVM and FEAT_C000_0001_EDX feature words, so clear all bits on those feature words. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (Reviewed-by line

[Qemu-devel] [PATCH RESEND v4 00/18] target-i386: CPU feature flag queue

2014-05-14 Thread Eduardo Habkost
(Resending due to complete lack of feedback on v4 submission from 15 days ago.) This started as a TCG vs KVM feature flag code cleanup, but now it is a queue which includes other feature-flag-related patches that depend on each other. Changes v3 -> v4: * New patch: target-i386: kvm: Don't enable

[Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for migratability status

2014-05-14 Thread Eduardo Habkost
From: Marcelo Tosatti Check vmsd for unmigratable field, allowing migratibility status to be modified after vmstate_register. Cc: Juan Quintela Signed-off-by: Marcelo Tosatti Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- savevm.c | 5 + 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH RESEND v4 02/18] target-i386: Simplify reporting of unavailable features

2014-05-14 Thread Eduardo Habkost
Instead of checking and calling unavailable_host_feature() once for each bit, simply call the function (now renamed to report_unavailable_features()) once for each feature word. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Rebase to latest qom-cpu (commit 90c5d39c) Changes v2 -> v3: *

[Qemu-devel] [PATCH RESEND v4 07/18] target-i386: Filter FEAT_7_0_EBX TCG features too

2014-05-14 Thread Eduardo Habkost
The TCG_7_0_EBX_FEATURES macro was defined but never used (it even had a typo that was never noticed). Make the existing TCG feature filtering code use it. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c)

[Qemu-devel] [PATCH RESEND v4 01/18] target-i386: kvm: Don't enable MONITOR by default on any CPU model

2014-05-14 Thread Eduardo Habkost
KVM never supported the MONITOR flag so it doesn't make sense to have it enabled by default when KVM is enabled. The rationale here is similar to the cases where it makes sense to have a feature enabled by default on all CPU models when on KVM mode (e.g. x2apic). In this case we are having a featu

[Qemu-devel] [PATCH RESEND v4 04/18] target-i386: Pass FeatureWord argument to report_unavailable_features()

2014-05-14 Thread Eduardo Habkost
This will help us simplify the code that calls report_unavailable_features() later. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Rebase to latest qom-cpu (commit 90c5d39c) Changes v2 -> v3: * Trivial rebase after QEMU 2.0 (onto commit 2d03b49) --- target-i386/cpu.c | 5 +++-- 1 file

[Qemu-devel] [PATCH RESEND v4 06/18] target-i386: Make TCG feature filtering more readable

2014-05-14 Thread Eduardo Habkost
Instead of an #ifdef in the middle of the code, just set TCG_EXT2_FEATURES to a different value depending on TARGET_X86_64. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (Reviewed-by line kept) Changes

[Qemu-devel] [PATCH RESEND v4 03/18] target-i386: Merge feature filtering/checking functions

2014-05-14 Thread Eduardo Habkost
Merge filter_features_for_kvm() and kvm_check_features_against_host(). Both functions made exactly the same calculations, the only difference was that filter_features_for_kvm() changed the bits on cpu->features[], and kvm_check_features_against_host() did error reporting. Reviewed-by: Richard Hen

[Qemu-devel] [PATCH] hw/arm/boot: get AArch64 kernel Image load offset from Image file

2014-05-14 Thread Rob Herring
From: Rob Herring The AArch64 kermel Image format defines the load offset in its header. Retrieve the offset from the file instead of hardcoding it to 0x8. Use of the hardcoded value will break when text_offset randomization is added to the kernel. Signed-off-by: Rob Herring --- hw/arm/bo

[Qemu-devel] [PATCH v2 RESEND] vl.c: Unify MAX_CPUMASK_BITS and machine->max_cpus checks

2014-05-14 Thread Eduardo Habkost
If a given machine have max_cpus set, not just smp_cpus needs to be limited, but the total number of CPUs (considering CPU hotplug) for the machine. We also had yet another max_cpus limit check at smp_parse(), ensuring that max_cpus < MAX_CPUMASK_BITS. This patch unifies the machine->max_cpus and

Re: [Qemu-devel] [PATCH 6/7] arm/virt: enable PSCI emulation support for system emulation

2014-05-14 Thread Rob Herring
On Wed, May 14, 2014 at 12:51 PM, Peter Maydell wrote: > On 5 May 2014 17:00, Rob Herring wrote: >> From: Rob Herring >> >> Now that we have PSCI emulation, enable it for the virt platform. >> This simplifies the virt machine a bit now that PSCI and SMP no longer >> need to be KVM only features.

Re: [Qemu-devel] uvesafb doesn't work with seabios

2014-05-14 Thread Bernhard Walle
Am 13.05.14 21:48, schrieb Bernhard Walle: > However, I took the step to update the x86emu code from X.org. That > seems to work! At least with my test VM that is based on Arch Linux. > I'll try the original Gentoo-based VM tomorrow. That worked, too. :) I sent a pull request via https://github.c

Re: [Qemu-devel] [PATCH 12/18] block/sheepdog: Propagate errors through connect_to_sdog()

2014-05-14 Thread Eric Blake
On 05/13/2014 10:02 AM, Markus Armbruster wrote: > Cc: MORITA Kazutaka > Signed-off-by: Markus Armbruster > --- > block/sheepdog.c | 77 > > 1 file changed, 55 insertions(+), 22 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake

Re: [Qemu-devel] [PATCH v2 10/23] target-arm: implement CPACR register logic

2014-05-14 Thread Fedorov Sergey
14.05.2014 10:06, Sergey Fedorov пишет: > On 13.05.2014 20:15, Fabian Aggeler wrote: >> From: Sergey Fedorov >> >> CPACR register allows to control access rights to coprocessor 0-13 >> interfaces. Bits corresponding to unimplemented coprocessors should be >> RAZ/WI. QEMU implements only VFP copro

Re: [Qemu-devel] [PATCH v2 06/23] target-arm: add arm_is_secure() function

2014-05-14 Thread Fedorov Sergey
14.05.2014 18:42, Greg Bellows пишет: > On 14 May 2014 00:53, Sergey Fedorov wrote: > >> On 13.05.2014 20:15, Fabian Aggeler wrote: >>> arm_is_secure() function allows to determine CPU security state >>> if the CPU implements Security Extensions. >>> >>> Signed-off-by: Sergey Fedorov >>> Signed-

  1   2   3   4   >