Eric Blake <[email protected]> writes: > On 05/13/2014 10:02 AM, Markus Armbruster wrote: >> Completes the conversion of the open method to Error started in commit >> 015a103. >> >> Signed-off-by: Markus Armbruster <[email protected]> >> --- >> block/vvfat.c | 16 +++++++++------- >> 1 file changed, 9 insertions(+), 7 deletions(-) >> >> @@ -892,8 +893,8 @@ static int init_directories(BDRVVVFATState* s, >> if (mapping->mode & MODE_DIRECTORY) { >> mapping->begin = cluster; >> if(read_directory(s, i)) { >> - fprintf(stderr, "Could not read directory %s\n", >> - mapping->path); >> + error_setg(errp, "Could not read directory %s", >> + mapping->path); > > I see you fixed some TABs in the process; is it worth widening the fix > to the rest of the 'if' statement? I don't care either way, as long as > checkpatch.pl didn't call you out (the new code is correct, even though > the existing code was not).
checkpatch is happy. The fewer lines in vvfat.c git blames on me, the happier I am ;) > Reviewed-by: Eric Blake <[email protected]> Thanks!
