Re: [Qemu-devel] [PATCH v3 02/11] AARCH64: add a57core

2013-09-27 Thread Peter Maydell
On 28 September 2013 00:53, Andreas Färber wrote: > Hi, > > Am 27.09.2013 12:10, schrieb Mian M. Hamayun: >> From: John Rigby >> >> Just an copy of a15 with a57 substituting a15 for now. > I had previously gently nack'ed this patch - conversions are still > queued on qom-next currently though. H

Re: [Qemu-devel] [PATCH 03/60] arm: Split VFP cmp from FPSCR setting

2013-09-27 Thread Richard Henderson
On 09/27/2013 07:05 AM, Richard Henderson wrote: > On 09/26/2013 05:47 PM, Alexander Graf wrote: >> -DEF_HELPER_3(vfp_cmps, void, f32, f32, env) >> -DEF_HELPER_3(vfp_cmpd, void, f64, f64, env) >> -DEF_HELPER_3(vfp_cmpes, void, f32, f32, env) >> -DEF_HELPER_3(vfp_cmped, void, f64, f64, env) >> +DEF_

Re: [Qemu-devel] ioh3420: Add a map_irq function

2013-09-27 Thread Alexander Duyck
On 02/28/2013 10:49 AM, Alex Williamson wrote: > Every bridge needs to know how to map IRQs from it's secondary bus to > the primary bus. We seem to be direct mapped on ioh3420. This avoids > segfaults when trying to put assigned devices behind root ports. > > Signed-off-by: Alex Williamson >

Re: [Qemu-devel] [Xen-devel] Hvmloader: Add _STA for PCI hotplug slots

2013-09-27 Thread Konrad Rzeszutek Wilk
On Fri, Sep 27, 2013 at 06:29:20AM +, Gonglei (Arei) wrote: > Hi, Hey, (CCing Stefano and Anthony). > > In Xen platform, after using upstream qemu, the all of pci devices will show > hotplug in the windows guest. > In this situation, the windows guest may occur blue screen when VM' user

Re: [Qemu-devel] [PATCH 59/60] AArch64: Add "Floating-point data-processing (3

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +if (is_neg) { > +gen_helper_vfp_negs(tcg_op1, tcg_op1); > +gen_helper_vfp_negs(tcg_op3, tcg_op3); > +} > + > +gen_helper_vfp_muls(tcg_res, tcg_op1, tcg_op2, fpst); > +if (is_sub) { > +gen_helper_vfp_subs(tcg_re

Re: [Qemu-devel] [PATCH 46/60] AArch64: Add rev instruction family emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > This patch adds emlulation support for rev and rbit instructions. > > Signed-off-by: Alexander Graf > --- > target-arm/helper-a64.c| 19 +++ > target-arm/helper-a64.h| 1 + > target-arm/translate-a64.c | 38

Re: [Qemu-devel] [PATCH 44/60] AArch64: Add division instruction family emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +if (is_32bit) { > +if (is_signed) { > +tcg_gen_ext32s_i64(cpu_reg(rd), cpu_reg(rd)); > +} else { > +tcg_gen_ext32u_i64(cpu_reg(rd), cpu_reg(rd)); > +} > +} Incorrect. Result is always zero-ext

Re: [Qemu-devel] [PATCH 43/60] AArch64: Add cinc instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +uint64_t HELPER(cinc)(uint32_t pstate, uint32_t insn, uint64_t n, uint64_t m) > +{ > +bool else_inc = get_bits(insn, 10, 1); > +int cond = get_bits(insn, 12, 4); > +bool else_inv = get_bits(insn, 30, 1); > +bool is_32bit = !get_bits(i

Re: [Qemu-devel] [PATCH 40/60] AArch64: Add tbz instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +tcg_cmp = tcg_temp_new_i64(); > +tcg_mask = tcg_const_i64(mask); > +tcg_gen_and_i64(tcg_cmp, cpu_reg(source), tcg_mask); > + > +no_match = gen_new_label(); > +if (is_one) { > +tcg_gen_brcond_i64(TCG_COND_NE, tcg_cmp, tcg_m

Re: [Qemu-devel] [PATCH 31/60] AArch64: Add bfm family instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > + > +uint64_t HELPER(sign_extend)(uint64_t x, uint64_t is_signed, uint64_t mask) > +{ > +if (x & is_signed) { > +x |= mask; > +} > + > +return x; > +} Why in the world do you have such a simple helper? > +tcg_gen_andi_i64(tcg

Re: [Qemu-devel] [PATCH 30/60] AArch64: Add extr instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +if (is_32bit) { > +tcg_gen_ext32u_i64(tcg_tmp, cpu_reg(rm)); > +} else { > +tcg_gen_mov_i64(tcg_tmp, cpu_reg(rm)); > +} > +tcg_gen_shri_i64(tcg_res, cpu_reg(rm), imms); > +tcg_gen_shli_i64(tcg_tmp, cpu_reg(rn), bit

Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +if (setflags) { > +tcg_dst = cpu_reg(dest); > +} else { > +tcg_dst = cpu_reg_sp(dest); > +} Never sp for logicals. > +handle_orri(s, insn); And yet again, a better function name. r~

Re: [Qemu-devel] [PATCH 28/60] AArch64: Add movi instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +if (is_k) { > +tcg_imm = tcg_const_i64(imm); > +tcg_gen_deposit_i64(cpu_reg(reg), cpu_reg(reg), tcg_imm, pos, 16); > +tcg_temp_free_i64(tcg_imm); > +} else { > +tcg_gen_movi_i64(cpu_reg(reg), imm << pos); > +

Re: [Qemu-devel] int128_get64: Assertion `!a.hi' failed

2013-09-27 Thread Paolo Bonzini
Il 27/09/2013 20:29, Max Filippov ha scritto: > Hi, > > I'm getting said assertion failure debugging linux userspace > application through the qemu gdbstub. The backtrace looks like this: > > qemu-system-xtensa: include/qemu/int128.h:22: int128_get64: Assertion `!a.hi' > failed. > > Program rec

Re: [Qemu-devel] [PATCH 24/60] AArch64: Add SIMD ushll instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +for (i = 0; i < (8 / ebytes); i++) { > +simd_ld(tcg_tmp, freg_offs_n + (i * ebytes), size); > +tcg_gen_shli_i64(tcg_tmp, tcg_tmp, shift); > +simd_st(tcg_tmp, freg_offs_d + (i * ebytes * 2), size + 1); > +} Are we real

Re: [Qemu-devel] [PATCH 22/60] AArch64: Add AdvSIMD scalar three same group handling

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > This patch adds decoding for the AdvSIMD scalar three same group with U == 0. > While at it, it also adds support for the ADD / SUB operations in this group. According to c3.6.16, your simdorr function is from the same group. What gives? r~

Re: [Qemu-devel] [PATCH 20/60] AArch64: Add SIMD ORR family instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +/* SIMD ORR */ > +static void handle_simdorr(DisasContext *s, uint32_t insn) A better name please. E.g. handle_simd_three_same, which is the name given to the insn group by C3.6.16. r~

Re: [Qemu-devel] [PATCH 18/60] AArch64: Add umov instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +switch (size) { > +case 0: > +idx = get_bits(imm5, 1, 4) << 0; > +tcg_gen_ld8u_i64(cpu_reg(rd), cpu_env, freg_offs_n + idx); > +break; > +case 1: > +idx = get_bits(imm5, 2, 3) << 1; > +tcg_gen_ld16u

[Qemu-devel] Virtio Polling Mode

2013-09-27 Thread Hu Yaohui
Hi All, I am wondering whether virtio has provided polling mode already. Instead of sending a event from guest to host through eventfd on guest side and inject an interrupt into guest on host side to notify each other? Could both sides keep polling the Vring to communicate with each other? Thanks f

Re: [Qemu-devel] [PATCH 17/60] AArch64: Add dup GPR->Vec instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +case 0x0e: > +if (!get_bits(insn, 31, 1) && !get_bits(insn, 29, 1) && > +(get_bits(insn, 10, 6) == 0x3)) { > +handle_dupg(s, insn); Is this really better than (insn & y) == x ? r~

Re: [Qemu-devel] [PATCH 15/60] AArch64: Add add instruction family emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +tcg_gen_mov_i64(tcg_src, cpu_reg(source)); > +tcg_dst = cpu_reg(dest); > +if (extend) { > +if ((shift_amount & 0x7) > 4) { > +/* reserved value */ > +unallocated_encoding(s); > +} > +if (!se

[Qemu-devel] int128_get64: Assertion `!a.hi' failed

2013-09-27 Thread Max Filippov
Hi, I'm getting said assertion failure debugging linux userspace application through the qemu gdbstub. The backtrace looks like this: qemu-system-xtensa: include/qemu/int128.h:22: int128_get64: Assertion `!a.hi' failed. Program received signal SIGABRT, Aborted. [Switching to Thread 0x77fe88

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > This patch adds emulation support for the orr instruction. > > Signed-off-by: Alexander Graf > --- > target-arm/helper-a64.c| 28 +++ > target-arm/helper-a64.h| 1 + > target-arm/translate-a64.c | 120 > +

Re: [Qemu-devel] [PATCH 11/60] AArch64: Add STP instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +static int get_reg(uint32_t inst) > +{ > +return get_bits(inst, 0, 5); > +} Surely get_rt or some such related to the actual field name, not something so generic as "reg" which applies equally to any of several fields. > +static void ldst_do_ve

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-27 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Wed, 2013-09-25 at 10:01 +0300, Michael S. Tsirkin wrote: >> On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote: >> > When I added support for the Q35-based machinetypes to libvirt, I >> > specifically prohibited attaching any PCI devices (with the exception

Re: [Qemu-devel] [PATCH] extend limit of physical sections number

2013-09-27 Thread Paolo Bonzini
Il 27/09/2013 18:49, Amos Kong ha scritto: > # qemu -drive file=/disk0,if=none,id=v0,format=qcow2 \ > -device virtio-blk-pci,drive=v0,id=v00,multifunction=on,addr=0x04.0 > > > Launching guest with more than 32 virtio-blk disks, > qemu will crash, because there are too many BARs. > > This

[Qemu-devel] [PATCH] extend limit of physical sections number

2013-09-27 Thread Amos Kong
# qemu -drive file=/disk0,if=none,id=v0,format=qcow2 \ -device virtio-blk-pci,drive=v0,id=v00,multifunction=on,addr=0x04.0 Launching guest with more than 32 virtio-blk disks, qemu will crash, because there are too many BARs. This patch brings the limit of non-tcg up by a factor of 8 (3276

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-09-27 Thread Stefan Weil
Am 27.09.2013 11:11, schrieb Stefan Hajnoczi: > On Fri, Sep 27, 2013 at 07:20:21AM +0200, Stefan Weil wrote: >> Am 11.09.2013 16:42, schrieb Stefan Hajnoczi: >>> The 'gthread' coroutine backend was written before the freelist (aka >>> pool) existed in qemu-coroutine.c. >>> >>> This means that every

Re: [Qemu-devel] [PATCH] eepro100: fix simplified mode

2013-09-27 Thread Stefan Weil
Am 27.09.2013 12:02, schrieb Paolo Bonzini: > Il 24/07/2012 09:49, christian schilling ha scritto: >> On Mon, Jul 23, 2012 at 6:28 PM, Stefan Weil wrote: >>> Am 23.07.2012 11:25, schrieb initcr...@gmail.com: A driver using simplified mode that works on real hardware did not work in qemu.

[Qemu-devel] [PULL 21/30] qemu-iotests: Add basic ability to use binary sample images

2013-09-27 Thread Kevin Wolf
From: Jeff Cody For image formats that are not "QEMU native", but supported for compatibility, it is useful to verify that an image created with the 'gold standard' native tool can be read / written to successfully by QEMU. In addition to testing non-native images, this could also be useful to t

Re: [Qemu-devel] [PATCH v3] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-27 Thread Michael Roth
Quoting Mark Wu (2013-09-25 20:57:15) > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients can handle th

Re: [Qemu-devel] [PATCH] Add interface to traverse the qmp command list by QmpCommand

2013-09-27 Thread Michael Roth
Quoting Mark Wu (2013-09-25 20:56:39) > In the original code, qmp_get_command_list is used to construct > a list of all commands' name. To get the information of all qga > commands, it traverses the name list and search the command info > with its name. So it can cause O(n^2) in the number of comm

Re: [Qemu-devel] [PATCH] Add interface to traverse the qmp command list by QmpCommand

2013-09-27 Thread Michael Roth
Quoting Eric Blake (2013-09-25 21:57:39) > On 09/25/2013 07:56 PM, Mark Wu wrote: > > In the original code, qmp_get_command_list is used to construct > > a list of all commands' name. To get the information of all qga > > commands, it traverses the name list and search the command info > > with its

[Qemu-devel] [PULL 08/30] qemu-iotests: fix test case 059

2013-09-27 Thread Kevin Wolf
From: Fam Zheng Since commit "block: Error parameter for open functions", error output is more verbose. Update test case output file to follow the change. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/059.out | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[Qemu-devel] [PULL 25/30] qcow2: Don't put invalid L2 table into cache

2013-09-27 Thread Kevin Wolf
From: Max Reitz In l2_allocate, the fail path is executed if qcow2_cache_flush fails. However, the L2 table has not yet been fetched from the L2 table cache. The qcow2_cache_put in the fail path therefore basically gives an undefined argument as the L2 table address (in this case). Signed-off-by

Re: [Qemu-devel] [PATCH v3 02/11] AARCH64: add a57core

2013-09-27 Thread Andreas Färber
Hi, Am 27.09.2013 12:10, schrieb Mian M. Hamayun: > From: John Rigby > > Just an copy of a15 with a57 substituting a15 for now. > > Signed-off-by: John Rigby > Signed-off-by: Mian M. Hamayun > --- > hw/cpu/Makefile.objs | 1 + > hw/cpu/a57mpcore.c | 122 > +++

[Qemu-devel] [PULL 29/30] qcow2: COMPRESSED on count_contiguous_clusters

2013-09-27 Thread Kevin Wolf
From: Max Reitz Compressed clusters can never be contiguous, therefore the corresponding flag does not need to be given explicitly to count_contiguous_clusters. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletion

[Qemu-devel] [PULL 24/30] qemu-iotests: Preallocated zero clusters in 061

2013-09-27 Thread Kevin Wolf
From: Max Reitz Add a test case for zero cluster expansion on an image completely filled with preallocated zero clusters to test 061. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/061 | 9 + tests/qemu-iotests/061.out | 11 +++ 2 files changed,

[Qemu-devel] [PULL 26/30] qcow2: Always use error path in l2_allocate

2013-09-27 Thread Kevin Wolf
From: Max Reitz Just returning -errno in some cases prevents trace_qcow2_l2_allocate_done from being executed (and, in one case, also the unused allocated L2 table from being freed). Always going down the error path fixes this. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow

[Qemu-devel] [PULL 30/30] qcow2: Remove useless count_contiguous_clusters() parameter

2013-09-27 Thread Kevin Wolf
All callers pass start = 0, and it's doubtful if any other value would actually do what you expect. Remove the parameter. Signed-off-by: Kevin Wolf Reviewed-by: Jeff Cody --- block/qcow2-cluster.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/block/qcow2-clust

[Qemu-devel] [PULL 18/30] qcow2: Assert against currently impossible overflow

2013-09-27 Thread Kevin Wolf
From: Max Reitz If qcow2_alloc_cluster_link_l2 is called with a QCowL2Meta describing a request crossing L2 boundaries, a buffer overflow will occur. This is impossible right now since such requests are never generated (every request is shortened to L2 boundaries before) and probably also complet

[Qemu-devel] [PULL 28/30] qcow2: count_contiguous_clusters and compression

2013-09-27 Thread Kevin Wolf
From: Max Reitz The function is not intended to be used on compressed clusters and will not work correctly, if used anyway, since L2E_OFFSET_MASK is not the right mask for determining the offset of compressed clusters. Therefore, assert that the first cluster is not compressed and always include

[Qemu-devel] [PULL 14/30] block: vdi - use QEMU_PACKED for on-disk structures

2013-09-27 Thread Kevin Wolf
From: Jeff Cody The header struct VdiHeader is an on-disk structure for the image format, and as such should be packed. Signed-off-by: Jeff Cody Reviewed-by: Richard Henderson Signed-off-by: Kevin Wolf --- block/vdi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/

[Qemu-devel] [PULL 17/30] block: qed - use QEMU_PACKED for on-disk structures

2013-09-27 Thread Kevin Wolf
From: Jeff Cody QEDHeader is read, and written, directly from on-disk images via bdrv_pread()/write(). To avoid any unintentional padding, these structs should be packed. Signed-off-by: Jeff Cody Reviewed-by: Richard Henderson Signed-off-by: Kevin Wolf --- block/qed.h | 2 +- 1 file changed

[Qemu-devel] [PULL 13/30] rbd: avoid qemu_rbd_snap_list() memory leaks

2013-09-27 Thread Kevin Wolf
From: Stefan Hajnoczi When there are no snapshots qemu_rbd_snap_list() returns 0 and the snapshot table pointer is NULL. Don't forget to free the snaps buffer we allocated for librbd rbd_snap_list(). When the function succeeds don't forget to free the snaps buffer after calling rbd_snap_list_en

[Qemu-devel] [PULL 27/30] qcow2: Free only newly allocated clusters on error

2013-09-27 Thread Kevin Wolf
From: Max Reitz In expand_zero_clusters_in_l1, a new cluster is only allocated if it was not already preallocated. On error, such preallocated clusters should not be freed, but only the newly allocated ones. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 16 +++

[Qemu-devel] [PULL 16/30] block: qcow2 - used QEMU_PACKED for on-disk structures

2013-09-27 Thread Kevin Wolf
From: Jeff Cody QCowHeader and QCowExtension are structs that reside in the on-disk image format, and are read and written directly via bdrv_pread()/write(), and as such should be packed to avoid any unintentional struct padding. Signed-off-by: Jeff Cody Reviewed-by: Richard Henderson Signed-o

[Qemu-devel] [PULL 07/30] vmdk: fix cluster size check for flat extents

2013-09-27 Thread Kevin Wolf
From: Fam Zheng We use the extent size as cluster size for flat extents (where no L1/L2 table is allocated so it's safe) reuse sector calculating code with sparse extents. Don't pass in the cluster size for adding flat extent, just set it to sectors later, then the cluster size checking will not

[Qemu-devel] [PULL 19/30] block: use DIV_ROUND_UP in bdrv_co_do_readv

2013-09-27 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 4833b37..93e113a 100644 --- a/block.c +++ b/block.c @@ -2653,7 +2653,7 @@ static int coroutine_fn

[Qemu-devel] [PULL 20/30] qemu-iotests: fix qmp.py search path

2013-09-27 Thread Kevin Wolf
From: Fam Zheng QMP/qmp.py is renamed to scripts/qmp/qmp.py, fix the search path in iotests.py. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/iotests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-i

[Qemu-devel] [PULL 11/30] block: Fix compiler warning (-Werror=uninitialized)

2013-09-27 Thread Kevin Wolf
From: Stefan Weil The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3: block/stream.c:141:22: error: ‘copy’ may be used uninitialized in this function [-Werror=uninitialized] This is not a real bug - a better compiler would not complain. Now 'copy' has always a defined value, so th

[Qemu-devel] [PULL 09/30] qemu-iotests: add monolithicFlat creation test to 059

2013-09-27 Thread Kevin Wolf
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 7 +++ 2 files changed, 12 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index b03429d..d2b3f9e 100755 --- a/tests/qemu-io

[Qemu-devel] [PULL 04/30] qcow2: Don't shadow return value

2013-09-27 Thread Kevin Wolf
From: Max Reitz When trying to update the refcounts for a snapshot, the return value of update_refcount on a compressed cluster was pretty much ignored, cancelling the update on error but returning 0. This is caused by an inner "ret" variable shadowing the outer one (the latter is used in the ret

[Qemu-devel] [PULL 15/30] block: vpc - use QEMU_PACKED for on-disk structures

2013-09-27 Thread Kevin Wolf
From: Jeff Cody The VHD footer and header structs (vhd_footer and vhd_dyndisk_header) are on-disk structures for the image format, and as such should be packed. Go ahead and make these typedefs as well, with the preferred QEMU naming convention, so that the packed attribute is used consistently

[Qemu-devel] [PULL 06/30] block/get_block_status: avoid segfault if there is no backing_hd

2013-09-27 Thread Kevin Wolf
From: Peter Lieven Reviewed-by: Eric Blake Signed-off-by: Peter Lieven Signed-off-by: Kevin Wolf --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 9b444b3..3366017 100644 --- a/block.c +++ b/block.c @@ -3169,7 +3169,7 @@ static int64_t cor

[Qemu-devel] [PULL 10/30] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-27 Thread Kevin Wolf
From: Benoît Canet Some drivers will have driver specifics options but no filename. This new bool allow the block layer to treat them correctly. The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and not having .bdrv_open. The first exception to this rule will be the quo

[Qemu-devel] [PULL 02/30] qemu-iotests: add test for backing file overriding

2013-09-27 Thread Kevin Wolf
From: Fam Zheng Test that backing.file.filename option can be parsed and override the backing file from image (backing file reflected with "info block"). Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051 | 17 - tests/qemu-iotests/051.out | 11 +

[Qemu-devel] [PULL 12/30] qdict: Extract qdict_extract_subqdict

2013-09-27 Thread Kevin Wolf
From: Benoît Canet Signed-off-by: Benoit Canet Signed-off-by: Kevin Wolf --- block.c | 23 ++- include/qapi/qmp/qdict.h | 2 ++ qobject/qdict.c | 21 + 3 files changed, 25 insertions(+), 21 deletions(-) diff --git a/block.c b/

[Qemu-devel] [PULL 03/30] qemu-iotests: Do not execute 052 with -nocache

2013-09-27 Thread Kevin Wolf
From: Max Reitz Test 052 uses qemu-io -s which will result in bdrv_open trying to create a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs do not work well together, disable this test for -nocache. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/05

[Qemu-devel] [PULL 05/30] block/get_block_status: set *pnum = 0 on error

2013-09-27 Thread Kevin Wolf
From: Peter Lieven if the call is invoked through bdrv_is_allocated the caller might expect *pnum = 0 on error. however, a new implementation of bdrv_get_block_status might only return a negative exit value on error while keeping *pnum untouched. Reviewed-by: Eric Blake Signed-off-by: Peter Lie

[Qemu-devel] [PULL 00/30] Block patches

2013-09-27 Thread Kevin Wolf
The following changes since commit f828a4c8faa118e0ebab3e353ac6840f3b2a0318: Merge remote-tracking branch 'stefanha/tracing' into staging (2013-09-23 11:53:22 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony for you to fetch changes up to 61653008

[Qemu-devel] [PULL 01/30] block: fix backing file overriding

2013-09-27 Thread Kevin Wolf
From: Fam Zheng Providing backing.file.filename doesn't override backing file as expected: $ x86_64-softmmu/qemu-system-x86_64 -drive \ file=/tmp/child.qcow2,backing.file.filename=/tmp/fake.qcow2 qemu-system-x86_64: -drive \ file=/tmp/child.qcow2,backing.file.filename=/t

[Qemu-devel] [PATCH v2] qemu/xen: make use of xenstore relative paths

2013-09-27 Thread Roger Pau Monne
Qemu has several hardcoded xenstore paths that are only valid on Dom0. Attempts to launch a Qemu instance (to act as a userspace backend for PV disks) will fail because Qemu is not able to access those paths when running on a domain different than Dom0. Instead make the xenstore paths relative to

Re: [Qemu-devel] [PULL] [PATCH 00/11] Linux-user updates

2013-09-27 Thread Edgar E. Iglesias
On Fri, Sep 27, 2013 at 03:09:55PM +0300, riku.voi...@linaro.org wrote: > From: Riku Voipio > > The following changes since commit f828a4c8faa118e0ebab3e353ac6840f3b2a0318: > > Merge remote-tracking branch 'stefanha/tracing' into staging (2013-09-23 > 11:53:22 -0500) > > are available in the

Re: [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error

2013-09-27 Thread Kevin Wolf
Am 25.09.2013 um 16:37 hat Max Reitz geschrieben: > If an error occurs in l2_allocate, the allocated (but unused) L2 cluster > should be freed. > > Signed-off-by: Max Reitz > --- > block/qcow2-cluster.c | 4 > 1 file changed, 4 insertions(+) This needs an update of the reference output for

Re: [Qemu-devel] [PATCH 10/60] AArch64: Add handling for br instructions

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +static void handle_br(DisasContext *s, uint32_t insn) > +{ > +int branch_type = get_bits(insn, 21, 2); > +int source = get_bits(insn, 5, 5); > + > +switch (branch_type) { > +case 0: /* JMP */ > +break; > +case 1: /* CALL *

Re: [Qemu-devel] [PATCH 09/60] AArch64: Add b and bl handling

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +static int get_bits(uint32_t inst, int start, int len) > +{ > +return (inst >> start) & ((1 << len) - 1); > +} > + > +static int get_sbits(uint32_t inst, int start, int len) > +{ > +int r = get_bits(inst, start, len); > +if (r & (1 << (le

Re: [Qemu-devel] [PATCH 09/60] AArch64: Add b and bl handling

2013-09-27 Thread Claudio Fontana
Hi Alex, On 09/27/13 02:48, Alexander Graf wrote: > This adds handling for the b and bl instructions. > > Signed-off-by: Alexander Graf > --- > target-arm/translate-a64.c | 61 > ++ > 1 file changed, 61 insertions(+) > > diff --git a/target-arm/tran

Re: [Qemu-devel] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID

2013-09-27 Thread Eduardo Habkost
On Thu, Sep 26, 2013 at 10:32:06PM +0200, Borislav Petkov wrote: > On Thu, Sep 26, 2013 at 04:20:59PM -0300, Eduardo Habkost wrote: > > Please point me to the code that does this, because I don't see it on > > patch 6/6. > > @@ -1850,7 +1850,14 @@ static void filter_features_for_kvm(X86CPU *cpu) >

Re: [Qemu-devel] [PATCH 04/60] arm: Add AArch64 disassembler stub

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:47 PM, Alexander Graf wrote: > While we don't have a working disassembler for AArch64 yet, we still > don't want AArch64 code be disassembled through the old AArch32 > disassembler. > > So add a small disassembler stub that declares every instruction as > unsupported. This should

Re: [Qemu-devel] [PATCH 03/60] arm: Split VFP cmp from FPSCR setting

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:47 PM, Alexander Graf wrote: > -DEF_HELPER_3(vfp_cmps, void, f32, f32, env) > -DEF_HELPER_3(vfp_cmpd, void, f64, f64, env) > -DEF_HELPER_3(vfp_cmpes, void, f32, f32, env) > -DEF_HELPER_3(vfp_cmped, void, f64, f64, env) > +DEF_HELPER_3(vfp_fpscr_cmps, void, f32, f32, env) > +DEF_HEL

Re: [Qemu-devel] [PATCH] qcow2: Remove useless count_contiguous_clusters() parameter

2013-09-27 Thread Jeff Cody
On Fri, Sep 27, 2013 at 01:51:10PM +0200, Kevin Wolf wrote: > All callers pass start = 0, and it's doubtful if any other value would > actually do what you expect. Remove the parameter. > > Signed-off-by: Kevin Wolf Reviewed-by: Jeff Cody > --- > block/qcow2-cluster.c | 12 ++-- > 1 f

Re: [Qemu-devel] Qxl problem with xen domU, is xen spice and/or qemu bugs?

2013-09-27 Thread Fabio Fantoni
Il 27/09/2013 10:51, Gerd Hoffmann ha scritto: Hi, #2 When using f19 try without X11 first. You should have a working framebuffer console on qxldrmfb before trying to get X11 going. I tried on Fedora19 minimal installation and with qxl the text console is working and lsmod show also q

Re: [Qemu-devel] [PATCH v6 18/20] block: qemu-iotests for vhdx, read sample dynamic image

2013-09-27 Thread Jeff Cody
On Wed, Sep 25, 2013 at 05:03:03PM -0400, Jeff Cody wrote: > This adds the VHDX format to the qemu-iotests format, and adds > a read test. The test reads from an existing sample image, that > was created with Hyper-V under Windwos Server 2012. > > The image file is a 1GB dynamic image, with 32MB

Re: [Qemu-devel] [PATCH v6 20/20] block: qemu-iotests for vhdx, add write test support

2013-09-27 Thread Jeff Cody
This patch should be replaced, because of the vhdx r/o test patch posted upstream: [PATCH v4] block: qemu-iotests for vhdx, read sample dynamic image This patch should be: --- This removes the IMGFMT_GENERIC blocker for read-only, so existing iotests run read/write tests for vhdx images crea

[Qemu-devel] [PATCH v4] block: qemu-iotests for vhdx, read sample dynamic image

2013-09-27 Thread Jeff Cody
This adds the VHDX format to the qemu-iotests format, and adds a read test. The test reads from an existing sample image, that was created with Hyper-V under Windwos Server 2012. The image file is a 1GB dynamic image, with 32MB blocks. The pattern 0xa5 exists from 0MB-33MB (past a block size bou

[Qemu-devel] [PATCH 10/11] [v2] linux-user: implement m68k atomic syscalls

2013-09-27 Thread riku . voipio
From: Riku Voipio With nptl enabled, atomic_cmpxchg_32 and atomic_barrier system calls are needed. This patch enabled really dummy versions of the system calls, modeled after the m68k kernel code. With this patch I am able to execute m68k binaries with qemu linux-user (busybox compiled for coldf

[Qemu-devel] [PATCH 06/11] linux-user: add some IPV6 commands in setsockop()

2013-09-27 Thread riku . voipio
From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 20 1 file changed, 20 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 505031b..7a093ba 100644 --- a/linux-use

[Qemu-devel] [PATCH 09/11] linux-user: Check type of microMIPS break instruction

2013-09-27 Thread riku . voipio
From: Kwok Cheung Yeung microMIPS instructions that cause breakpoint exceptions come in 16-bit and 32-bit variants. When handling exceptions caused by such instructions, the instruction type needs to be taken into account when extracting the break code. The code has also been restructured for b

[Qemu-devel] [PATCH 11/11] linux-user: Handle SOCK_CLOEXEC/NONBLOCK if unavailable on host

2013-09-27 Thread riku . voipio
From: "Edgar E. Iglesias" If the host lacks SOCK_CLOEXEC, bail out with -EINVAL. If the host lacks SOCK_ONONBLOCK, try to emulate it with fcntl() and O_NONBLOCK. Signed-off-by: Edgar E. Iglesias Signed-off-by: Riku Voipio --- linux-user/syscall.c | 40 +---

[Qemu-devel] [PATCH 07/11] linux-user: add support of binfmt_misc 'O' flag

2013-09-27 Thread riku . voipio
From: Laurent Vivier The binfmt_misc module can calculate the credentials and security token according to the binary instead of to the interpreter if the 'C' flag is enabled. To be able to execute non-readable binaries, this flag implies 'O' flag. When 'O' flag is enabled, bintfmt_misc opens the

[Qemu-devel] [PATCH 08/11] linux-user: correct how SOL_SOCKET is converted from target to host and back

2013-09-27 Thread riku . voipio
From: Petar Jovanovic Previous implementation does not take into account that SOL_SOCKET constant can be arch specific. This change fixes some issues with sendmsg/recvmsg. Signed-off-by: Petar Jovanovic Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 18 +

[Qemu-devel] [PULL] [PATCH 00/11] Linux-user updates

2013-09-27 Thread riku . voipio
From: Riku Voipio The following changes since commit f828a4c8faa118e0ebab3e353ac6840f3b2a0318: Merge remote-tracking branch 'stefanha/tracing' into staging (2013-09-23 11:53:22 -0500) are available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git linux-user-for-up

[Qemu-devel] [PATCH 03/11] linux-user: convert /proc/net/route when endianess differs

2013-09-27 Thread riku . voipio
From: Laurent Vivier This patch allows to have IP addresses in correct order in the case of "netstat -nr" when the endianess of the guest differs from one of the host. For instance, an m68k guest on an x86_64 host: WITHOUT this patch: $ netstat -nr Kernel IP routing table Destination Gatew

[Qemu-devel] [PATCH 04/11] linux-user: Add setsockopt(SO_ATTACH_FILTER)

2013-09-27 Thread riku . voipio
From: Laurent Vivier This is needed to be able to run dhclient. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c | 44 linux-user/syscall_defs.h | 12 2 files changed, 5

[Qemu-devel] [PATCH 02/11] mips-linux-user: Adjust names in mips_syscall_args

2013-09-27 Thread riku . voipio
From: Richard Henderson The name field of MIPS_SYS isn't actually used; it's just documentation. But adjust the umount entries to match mips/syscall_nr.h anyway. Signed-off-by: Richard Henderson Signed-off-by: Riku Voipio --- linux-user/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[Qemu-devel] [PATCH 05/11] linux-user: allow use of TIOCGSID

2013-09-27 Thread riku . voipio
From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/ioctls.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index 439c2a9..7381012 100644 --- a/linux-user/ioctls.h +++ b/linux-us

[Qemu-devel] [PATCH 01/11] alpha-linux-user: Fix umount syscall numbers

2013-09-27 Thread riku . voipio
From: Richard Henderson It has been pointed out on LKML that the alpha umount syscall numbers are named wrong, and a patch to rectify that has been posted for 3.11. Glibc works around this by treating NR_umount as NR_umount2 if NR_oldumount exists. That's more complicated than we need in QEMU,

[Qemu-devel] [PATCH] qcow2: Remove useless count_contiguous_clusters() parameter

2013-09-27 Thread Kevin Wolf
All callers pass start = 0, and it's doubtful if any other value would actually do what you expect. Remove the parameter. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-clust

Re: [Qemu-devel] [PATCH v2 0/2] qcow2: count_contiguous_clusters and compression

2013-09-27 Thread Kevin Wolf
Am 27.09.2013 um 12:14 hat Max Reitz geschrieben: > Compressed clusters can never be contiguous and count_contiguous_clusters > will not even work correctly for them. Therefore, those cluster should > always be treated as non-contiguous. > > This series makes count_contiguous_clusters always stop

Re: [Qemu-devel] [PATCH v3 2/3] block: qemu-iotests for vhdx, read sample dynamic image

2013-09-27 Thread Jeff Cody
On Fri, Sep 27, 2013 at 11:14:55AM +0200, Kevin Wolf wrote: > Am 25.09.2013 um 14:12 hat Jeff Cody geschrieben: > > This adds the VHDX format to the qemu-iotests format, and adds > > a read test. The test reads from an existing sample image, that > > was created with Hyper-V under Windwos Server 2

Re: [Qemu-devel] [v2 33/71] hw/isa/Kconfig: Add Kconfig file

2013-09-27 Thread Paolo Bonzini
Il 27/09/2013 13:13, Stefan Hajnoczi ha scritto: > On Fri, Sep 27, 2013 at 04:30:54AM +0200, Ákos Kovács wrote: >> Signed-off-by: Ákos Kovács >> --- >> hw/isa/Kconfig | 39 +++ >> 1 file changed, 39 insertions(+) >> create mode 100644 hw/isa/Kconfig >> >> diff

Re: [Qemu-devel] [v2 30/71] hw/ide/Kconfig: Add Kconfig file

2013-09-27 Thread Paolo Bonzini
Il 27/09/2013 13:11, Stefan Hajnoczi ha scritto: > On Fri, Sep 27, 2013 at 04:30:51AM +0200, Ákos Kovács wrote: >> diff --git a/hw/net/Kconfig b/hw/net/Kconfig >> new file mode 100644 >> index 000..19ca549 >> --- /dev/null >> +++ b/hw/net/Kconfig > > This should be a separate patch. > >> @@ -

Re: [Qemu-devel] [v2 22/71] hw/block/Kconfig: Add Kconfig file

2013-09-27 Thread Paolo Bonzini
Il 27/09/2013 13:14, Stefan Hajnoczi ha scritto: > On Fri, Sep 27, 2013 at 04:30:43AM +0200, Ákos Kovács wrote: >> Signed-off-by: Ákos Kovács >> --- >> hw/block/Kconfig | 31 +++ >> 1 file changed, 31 insertions(+) >> create mode 100644 hw/block/Kconfig >> >> diff --g

Re: [Qemu-devel] [v2 22/71] hw/block/Kconfig: Add Kconfig file

2013-09-27 Thread Stefan Hajnoczi
On Fri, Sep 27, 2013 at 04:30:43AM +0200, Ákos Kovács wrote: > Signed-off-by: Ákos Kovács > --- > hw/block/Kconfig | 31 +++ > 1 file changed, 31 insertions(+) > create mode 100644 hw/block/Kconfig > > diff --git a/hw/block/Kconfig b/hw/block/Kconfig > new file mode

Re: [Qemu-devel] [v2 33/71] hw/isa/Kconfig: Add Kconfig file

2013-09-27 Thread Stefan Hajnoczi
On Fri, Sep 27, 2013 at 04:30:54AM +0200, Ákos Kovács wrote: > Signed-off-by: Ákos Kovács > --- > hw/isa/Kconfig | 39 +++ > 1 file changed, 39 insertions(+) > create mode 100644 hw/isa/Kconfig > > diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig > new file mode

Re: [Qemu-devel] [v2 30/71] hw/ide/Kconfig: Add Kconfig file

2013-09-27 Thread Stefan Hajnoczi
On Fri, Sep 27, 2013 at 04:30:51AM +0200, Ákos Kovács wrote: > diff --git a/hw/net/Kconfig b/hw/net/Kconfig > new file mode 100644 > index 000..19ca549 > --- /dev/null > +++ b/hw/net/Kconfig This should be a separate patch. > @@ -0,0 +1,74 @@ > +menu "Network devices" > +config DP8393X >

Re: [Qemu-devel] [PATCH] qemu-xen: make use of xenstore relative paths

2013-09-27 Thread Anthony PERARD
On Thu, Sep 26, 2013 at 07:20:31PM +0200, Roger Pau Monné wrote: > On 26/09/13 18:46, Anthony PERARD wrote: > > On Wed, Sep 18, 2013 at 09:50:58PM +0200, Roger Pau Monne wrote: > >> Qemu has several hardcoded xenstore paths that are only valid on Dom0. > >> Attempts to launch a Qemu instance (to ac

[Qemu-devel] [PATCH v3 03/11] AARCH64: Add A57 CPU to default AArch64 configuration and enable KVM

2013-09-27 Thread Mian M. Hamayun
From: "Mian M. Hamayun" Introduce the A57 cpu to the default AArch64 configuration and enable KVM for 64-bit guests only. Signed-off-by: Mian M. Hamayun --- configure | 2 +- default-configs/aarch64-softmmu.mak | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) d

[Qemu-devel] [PATCH v3 05/11] AARCH64: Add AARCH64 CPU initialization, get and put registers support

2013-09-27 Thread Mian M. Hamayun
From: "Mian M. Hamayun" The cpu init function tries to initialize with all possible cpu types, as KVM does not provide a means to detect the real cpu type and simply refuses to initialize on cpu type mis-match. By using the loop based init function, we avoid the need to modify code if the underly

  1   2   >