On 09/27/2013 07:05 AM, Richard Henderson wrote: > On 09/26/2013 05:47 PM, Alexander Graf wrote: >> -DEF_HELPER_3(vfp_cmps, void, f32, f32, env) >> -DEF_HELPER_3(vfp_cmpd, void, f64, f64, env) >> -DEF_HELPER_3(vfp_cmpes, void, f32, f32, env) >> -DEF_HELPER_3(vfp_cmped, void, f64, f64, env) >> +DEF_HELPER_3(vfp_fpscr_cmps, void, f32, f32, env) >> +DEF_HELPER_3(vfp_fpscr_cmpd, void, f64, f64, env) >> +DEF_HELPER_3(vfp_fpscr_cmpes, void, f32, f32, env) >> +DEF_HELPER_3(vfp_fpscr_cmped, void, f64, f64, env) >> +DEF_HELPER_3(vfp_cmps, i32, f32, f32, env) >> +DEF_HELPER_3(vfp_cmpd, i32, f64, f64, env) >> +DEF_HELPER_3(vfp_cmpes, i32, f32, f32, env) >> +DEF_HELPER_3(vfp_cmped, i32, f64, f64, env) > > While you're changing these, please change them to use DEF_HELPER_FLAGS_*. > For the fpscr helpers, TCG_CALL_NO_RWG (since they have the side effect of > setting the fpscr); for the new helpers, TCG_CALL_NO_RWG_SE since there are > no side effects at all.
Actually I forgot the side effect of setting exception bits because of the comparison. So TCG_CALL_NO_RWG for both. r~
