[Qemu-devel] Question about life cycle of QEMU's stable branches

2013-08-08 Thread Hitoshi Mitake
Hi QEMU list, I have a question about life cycle of QEMU's stable branches. Is there an explicit support period for the stable branches? We are maintaining stable branches of sheepdog, distributed block storage system for QEMU. The stable branches of sheepdog corresponds to the stable branches

Re: [Qemu-devel] [PATCH] pc: drop external DSDT loading

2013-08-08 Thread Gerd Hoffmann
On 08/08/13 18:38, Anthony Liguori wrote: > This breaks migration and is unneeded with modern SeaBIOS. No. Dropping for piix is fine. It will break q35 though. Given that q35 can't be migrated anyway due to ahci being tagged as unmigratable keeping it for q35 (until the new acpi table loading i

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Rusty Russell
Anthony Liguori writes: > I suspect this is a premature optimization. With a weak function called > directly in the accessors below, I suspect you would see no measurable > performance overhead compared to this approach. > > It's all very predictable so the CPU should do a decent job optimizing >

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Gerd Hoffmann
Hi, >> pmbase is a compile-time constant (aka #define) in both seabios and >> coreboot, and making this runtime-configurable is non-trivial. See >> src/smm.c in seabios for one reason why. > Converting src/smm.c to use a runtime value isn't hard - just change > the assembler from: "mov $" __s

[Qemu-devel] [Bug 1208540] Re: RDMSR of register 0x345 (IA32_PERF_CAPABILITIES) fails in guest

2013-08-08 Thread Jari Ruusu
Looks like the problem is in host linux kernel kvm code, not in qemu. Until kvm code is fixed, this works as temporary workaround: echo 1 >/sys/module/kvm/parameters/ignore_msrs ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Anton Blanchard
Hi, > > The distinction is important in QEMU. ppc64 is still > > TARGET_WORDS_BIGENDIAN. We still want most stl_phys to treat > > integers as big endian. There's just this extra concept that CPU > > loads/stores are sometimes byte swapped. That affects virtio but > > not a lot else. > > You'

Re: [Qemu-devel] [SeaBIOS] [PATCH] acpi: hide 64-bit PCI hole for Windows XP

2013-08-08 Thread Kevin O'Connor
On Thu, Aug 08, 2013 at 04:56:55PM +0200, Gerd Hoffmann wrote: > On 08/08/13 16:13, Michael S. Tsirkin wrote: > > On Thu, Aug 08, 2013 at 12:21:32PM +0200, Gerd Hoffmann wrote: > >> On 08/08/13 11:52, Michael S. Tsirkin wrote: > >>> On Thu, Aug 08, 2013 at 10:57:44AM +0200, Gerd Hoffmann wrote: > >

Re: [Qemu-devel] 1.7.3.1 release planned

2013-08-08 Thread Kevin O'Connor
On Thu, Aug 08, 2013 at 03:43:48PM +0200, Gerd Hoffmann wrote: > I've just created a 1.7.3-stable branch. It has a single commit right > now, which is 2a9aeabdfb34374ecac25e7a8d21c9e368618cd4 from master > cherry-picked (Fix USB EHCI detection that was broken in hlist > conversion of PCIDevices).

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Rusty Russell
Anthony Liguori writes: > "Daniel P. Berrange" writes: > >> On Thu, Aug 08, 2013 at 10:40:28AM -0500, Anthony Liguori wrote: >>> Andreas Färber writes: >>> >> We have a mechanism to do weak functions via stubs/. I think it would >>> >> be better to do cpu_get_byteswap() as a stub function and t

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Rusty Russell
Andreas Färber writes: > Am 08.08.2013 15:31, schrieb Anthony Liguori: >> Rusty Russell writes: >> >>> Virtio is currently defined to work as "guest endian", but this is a >>> problem if the guest can change endian. As most targets can't change >>> endian, we make it a per-target option to avoi

[Qemu-devel] [RFC] [PATCHv8 13/30] aio / timers: Add aio_timer_new wrapper

2013-08-08 Thread Alex Bligh
Add aio_timer_new wrapper function. Signed-off-by: Alex Bligh --- include/block/aio.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/block/aio.h b/include/block/aio.h index a13f6e8..bd6f17c 100644 --- a/include/block/aio.h +++ b/include/block/aio.h @@ -255,4 +

[Qemu-devel] [RFC] [PATCHv8 18/30] aio / timers: Use all timerlists in icount warp calculations

2013-08-08 Thread Alex Bligh
Notify all timerlists derived from vm_clock in icount warp calculations. When calculating timer delay based on vm_clock deadline, use all timerlists. For compatibility, maintain an apparent bug where when using icount, if no vm_clock timer was set, qemu_clock_deadline would return INT32_MAX and a

[Qemu-devel] [RFC] [PATCHv8 15/30] aio / timers: Convert mainloop to use timeout

2013-08-08 Thread Alex Bligh
Convert mainloop to use timeout from default timerlist group (i.e. the current 3 static timers) Signed-off-by: Alex Bligh --- main-loop.c | 45 ++--- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/main-loop.c b/main-loop.c index a44fff6.

Re: [Qemu-devel] [PATCH v10 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-08-08 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-08-07 10:39:25) > Hi, > > I rebased the patch series to add fsfreeze for Windows qemu-ga. > > changes from v9: > - Fix conflict with commit e8ef31a3518c "qemu-ga: build it even if !system" > > changes from v8: > - Add hEventTimeout to improve timeout error messag

[Qemu-devel] [RFC] [PATCHv8 03/30] aio / timers: Consistent treatment of disabled clocks for deadlines

2013-08-08 Thread Alex Bligh
Make treatment of disabled clocks consistent in deadline calculation Signed-off-by: Alex Bligh --- qemu-timer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-timer.c b/qemu-timer.c index 8f378a9..47b5e4b 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -264,7 +264,7

[Qemu-devel] [RFC] [PATCHv8 04/30] aio / timers: add ppoll support with qemu_poll_ns

2013-08-08 Thread Alex Bligh
Add qemu_poll_ns which works like g_poll but takes a nanosecond timeout. Signed-off-by: Alex Bligh --- configure| 19 +++ include/qemu/timer.h | 12 qemu-timer.c | 24 3 files changed, 55 insertions(+) diff --git a/

Re: [Qemu-devel] [RFC] [PATCHv8 00/30] aio / timers: Add AioContext timers and use ppoll

2013-08-08 Thread Alex Bligh
--On 8 August 2013 22:41:57 +0100 Alex Bligh wrote: This patch series adds support for timers attached to an AioContext clock which get called within aio_poll. For ease of review, the finished result (and for that matter all the intermediate steps) are available at: https://github.com/ablig

[Qemu-devel] [RFC] [PATCHv8 02/30] aio / timers: add qemu-timer.c utility functions

2013-08-08 Thread Alex Bligh
Add utility functions to qemu-timer.c for nanosecond timing. Add qemu_clock_deadline_ns to calculate deadlines to nanosecond accuracy. Add utility function qemu_soonest_timeout to calculate soonest deadline. Add qemu_timeout_ns_to_ms to convert a timeout in nanoseconds back to milliseconds for w

Re: [Qemu-devel] [RFC] [PATCHv8 23/30] aio / timers: Rearrange timer.h & make legacy functions call non-legacy

2013-08-08 Thread Alex Bligh
--On 8 August 2013 22:42:20 +0100 Alex Bligh wrote: diff --git a/pc-bios/slof.bin b/pc-bios/slof.bin index 092e58a46e1d511410793f94a0ca415657dc72b7..3b925b32663d47516a770a8766f6ec1 7915e75a1 100644 GIT binary patch delta 59 zcmbPn*nGxe^M)427N!>F7M2#)7Pc1l7LF~P^$MINnYpP&@#(20?Hvl7K+FZi+(68; Ky

[Qemu-devel] [RFC] [PATCHv8 11/30] aio / timers: Add a notify callback to QEMUTimerList

2013-08-08 Thread Alex Bligh
Add a notify pointer to QEMUTimerList so it knows what to notify on a timer change. Signed-off-by: Alex Bligh --- async.c |7 ++- include/qemu/timer.h | 35 --- qemu-timer.c | 24 ++-- 3 files changed, 60 insert

[Qemu-devel] [RFC] [PATCHv8 28/30] aio / timers: Add scripts/switch-timer-api

2013-08-08 Thread Alex Bligh
Add scripts/switch-timer-api to programatically rewrite source files to use the new timer system. Signed-off-by: Alex Bligh --- scripts/switch-timer-api | 178 ++ 1 file changed, 178 insertions(+) diff --git a/scripts/switch-timer-api b/scripts/switc

[Qemu-devel] [RFC] [PATCHv8 25/30] aio / timers: Convert rtc_clock to be a QEMUClockType

2013-08-08 Thread Alex Bligh
Convert rtc_clock to be a QEMUClockType Move rtc_clock users to use the new API Signed-off-by: Alex Bligh --- hw/arm/omap1.c|4 ++-- hw/arm/pxa2xx.c | 35 +++ hw/arm/strongarm.c| 10 +- hw/timer/m48t59.c |

[Qemu-devel] [RFC] [PATCHv8 26/30] aio / timers: convert block_job_sleep_ns and co_sleep_ns to new API

2013-08-08 Thread Alex Bligh
Convert block_job_sleep_ns and co_sleep_ns to use the new timer API. Signed-off-by: Alex Bligh --- block/backup.c|4 ++-- block/commit.c|2 +- block/mirror.c|4 ++-- block/stream.c|2 +- blockjob.c|4 ++-- includ

[Qemu-devel] [RFC] [PATCHv8 21/30] aio / timers: Remove legacy qemu_clock_deadline & qemu_timerlist_deadline

2013-08-08 Thread Alex Bligh
Remove qemu_clock_deadline and qemu_timerlist_deadline now we are using the ns functions throughout. Signed-off-by: Alex Bligh --- include/qemu/timer.h | 16 qemu-timer.c | 20 2 files changed, 36 deletions(-) diff --git a/include/qemu/timer.h b

[Qemu-devel] [RFC] [PATCHv8 24/30] aio / timers: Remove main_loop_timerlist

2013-08-08 Thread Alex Bligh
Now we have timerlistgroups implemented and main_loop_tlg, we no longer need the concept of a default timer list associated with each clock. Remove it and simplify initialisation of clocks and timer lists. Signed-off-by: Alex Bligh --- include/qemu/timer.h |6 +- qemu-timer.c |

[Qemu-devel] [RFC] [PATCHv8 19/30] aio / timers: Add documentation and new format calls

2013-08-08 Thread Alex Bligh
Add documentation for existing qemu timer calls. Add new format calls of the format qemu_timer_XXX rather than qemu_XXX_timer for consistency. Signed-off-by: Alex Bligh --- configure| 18 + include/qemu/timer.h | 215 +- 2 files

[Qemu-devel] [RFC] [PATCHv8 20/30] aio / timers: Remove alarm timers

2013-08-08 Thread Alex Bligh
Remove alarm timers from qemu-timers.c now we use g_poll / ppoll instead. Signed-off-by: Alex Bligh --- include/qemu/timer.h |3 - main-loop.c |4 - qemu-timer.c | 500 +- vl.c |4 +- 4 files changed, 4

[Qemu-devel] [RFC] [PATCHv8 17/30] aio / timers: Introduce new API qemu_timer_new and friends

2013-08-08 Thread Alex Bligh
Introduce new API for creating timers - qemu_timer_new and _ns, _ms, _us derivatives. Signed-off-by: Alex Bligh --- include/qemu/timer.h | 69 ++ 1 file changed, 69 insertions(+) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 68f

[Qemu-devel] [RFC] [PATCHv8 16/30] aio / timers: On timer modification, qemu_notify or aio_notify

2013-08-08 Thread Alex Bligh
On qemu_mod_timer_ns, ensure qemu_notify or aio_notify is called to end the appropriate poll(), irrespective of use_icount value. On qemu_clock_enable, ensure qemu_notify or aio_notify is called for all QEMUTimerLists attached to the QEMUClock. Signed-off-by: Alex Bligh --- include/qemu/timer.h

[Qemu-devel] [RFC] [PATCHv8 30/30] aio / timers: Remove legacy interface

2013-08-08 Thread Alex Bligh
Remove the legacy interface from include/qemu/timers.h. Ensure struct QEMUClock is not exposed at all. Signed-off-by: Alex Bligh --- include/qemu/timer.h | 216 +- qemu-timer.c | 35 +--- 2 files changed, 5 insertions(+), 246 deleti

[Qemu-devel] [RFC] [PATCHv8 09/30] aio / timers: Add QEMUTimerListGroup and helper functions

2013-08-08 Thread Alex Bligh
Add QEMUTimerListGroup and helper functions, to represent a QEMUTimerList associated with each clock. Add a default QEMUTimerListGroup representing the default timer lists which are not associated with any other object (e.g. an AioContext as added by future patches). Signed-off-by: Alex Bligh ---

[Qemu-devel] [RFC] [PATCHv8 07/30] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-08 Thread Alex Bligh
Split QEMUClock into QEMUClock and QEMUTimerList so that we can have more than one QEMUTimerList associated with the same clock. Introduce a main_loop_timerlist concept and make existing qemu_clock_* calls that actually should operate on a QEMUTimerList call the relevant QEMUTimerList implementati

[Qemu-devel] [RFC] [PATCHv8 27/30] aio / timers: Add test harness for AioContext timers

2013-08-08 Thread Alex Bligh
Add a test harness for AioContext timers. The g_source equivalent is unsatisfactory as it suffers from false wakeups. Signed-off-by: Alex Bligh --- tests/test-aio.c | 136 ++ 1 file changed, 136 insertions(+) diff --git a/tests/test-aio.c b/t

[Qemu-devel] [RFC] [PATCHv8 08/30] aio / timers: Untangle include files

2013-08-08 Thread Alex Bligh
include/qemu/timer.h has no need to include main-loop.h and doing so causes an issue for the next patch. Unfortunately various files assume including timers.h will pull in main-loop.h. Untangle this mess. Signed-off-by: Alex Bligh --- dma-helpers.c |1 + hw/dma/xilinx_axidma.c

[Qemu-devel] [RFC] [PATCHv8 10/30] aio / timers: Add QEMUTimerListGroup to AioContext

2013-08-08 Thread Alex Bligh
Add a QEMUTimerListGroup each AioContext (meaning a QEMUTimerList associated with each clock is added) and delete it when the AioContext is freed. Signed-off-by: Alex Bligh --- async.c |2 ++ include/block/aio.h |4 tests/test-aio.c |3 +++ tests/te

[Qemu-devel] [RFC] [PATCHv8 14/30] aio / timers: Convert aio_poll to use AioContext timers' deadline

2013-08-08 Thread Alex Bligh
Convert aio_poll to use deadline based on AioContext's timers. aio_poll has been changed to return accurately whether progress has occurred. Prior to this commit, aio_poll always returned true if g_poll was entered, whether or not any progress was made. This required a change to tests/test-aio.c w

[Qemu-devel] [RFC] [PATCHv8 00/30] aio / timers: Add AioContext timers and use ppoll

2013-08-08 Thread Alex Bligh
This patch series adds support for timers attached to an AioContext clock which get called within aio_poll. In doing so it removes alarm timers and moves to use ppoll where possible. This patch set 'sort of' passes make check (see below for caveat) including a new test harness for the aio timers,

[Qemu-devel] [RFC] [PATCHv8 22/30] aio / timers: Add qemu_clock_get_ms and qemu_clock_get_ms

2013-08-08 Thread Alex Bligh
Add utility functions qemu_clock_get_ms and qemu_clock_get_us Signed-off-by: Alex Bligh --- include/qemu/timer.h | 28 1 file changed, 28 insertions(+) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index fedd7f1..0106f63 100644 --- a/include/qemu/timer.

[Qemu-devel] [RFC] [PATCHv8 06/30] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress

2013-08-08 Thread Alex Bligh
Make qemu_run_timers and qemu_run_all_timers return progress so that aio_poll etc. can determine whether a timer has been run. Signed-off-by: Alex Bligh --- include/qemu/timer.h | 21 +++-- qemu-timer.c | 18 -- 2 files changed, 31 insertions(+), 8 del

[Qemu-devel] [RFC] [PATCHv8 01/30] aio / timers: Rename qemu_new_clock and expose clock types

2013-08-08 Thread Alex Bligh
Rename qemu_new_clock to qemu_clock_new. Expose clock types. Signed-off-by: Alex Bligh --- include/qemu/timer.h |4 qemu-timer.c | 12 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 9dd206c..45c745

[Qemu-devel] [RFC] [PATCHv8 12/30] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-08 Thread Alex Bligh
Calculate the timeout in aio_ctx_prepare taking into account the timers attached to the AioContext. Alter aio_ctx_check similarly. Signed-off-by: Alex Bligh --- async.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/async.c b/async.c index 2051921..dd27459

[Qemu-devel] [RFC] [PATCHv8 05/30] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack

2013-08-08 Thread Alex Bligh
Where supported, called prctl(PR_SET_TIMERSLACK, 1, ...) to set one nanosecond timer slack to increase precision of timer calls. Signed-off-by: Alex Bligh --- qemu-timer.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-timer.c b/qemu-timer.c index 5e81935..9eb6db8 100644 ---

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Michael R. Hines
On 08/08/2013 02:41 PM, Eric Blake wrote: On 08/08/2013 11:05 AM, Orit Wasserman wrote: "ram" is present also when migration completes. expected-downtime, total-time and downtime are no longer part of "ram" data. Signed-off-by: Orit Wasserman --- qmp-commands.hx | 20 ++-- 1

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Peter Maydell
On 8 August 2013 21:57, Christoffer Dall wrote: > I'm fine with having a discovery mechanism for the GIC and not for the > CPU, if there's an implicit discovery mechanism for the CPU. But are > we sure there will not be cases where we want to know the list of > available CPUs that the kernel can

[Qemu-devel] [Bug 1210212] [NEW] qemu core dumps with -serial mon:vc

2013-08-08 Thread David Mazieres
Public bug reported: qemu 1.5.2-1 dumps core when asked to put the monitor on a virtual console. For example, suppose you want to monitor the second serial port, you might try something like: qemu-system-x86_64 -serial null -serial mon:vc But that creates a core dump. In fact, even re-creating

Re: [Qemu-devel] [PATCH] tcg/mips: fix invalid op definition errors

2013-08-08 Thread Aurelien Jarno
On Thu, Aug 08, 2013 at 03:40:23PM +0100, James Hogan wrote: > tcg/mips/tcg-target.h defines various operations conditionally depending > upon the isa revision, however these operations are included in > mips_op_defs[] unconditionally resulting in the following runtime errors > if CONFIG_DEBUG_TCG

Re: [Qemu-devel] [PATCH v2 for-1.6] mips: revert commit b332d24a8e1290954029814d09156b06ede358e2

2013-08-08 Thread Aurelien Jarno
On Tue, Aug 06, 2013 at 01:35:12PM +0200, Andreas Färber wrote: > Am 06.08.2013 13:08, schrieb Aurelien Jarno: > > Now that this code path is not triggered anymore during the tests, > > revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS > > target without kernel nor bios doesn't

Re: [Qemu-devel] [PATCH v1 1/5] util: introduce gsource event abstraction

2013-08-08 Thread Michael Roth
Quoting Michael Roth (2013-08-08 16:03:30) > Quoting Liu Ping Fan (2013-08-08 01:26:07) > > Introduce struct EventsGSource. It will ease the usage of GSource > > associated with a group of files, which are dynamically allocated > > and release, ex, slirp. > > > > Signed-off-by: Liu Ping Fan > > -

Re: [Qemu-devel] [PATCH v1 1/5] util: introduce gsource event abstraction

2013-08-08 Thread Michael Roth
Quoting Liu Ping Fan (2013-08-08 01:26:07) > Introduce struct EventsGSource. It will ease the usage of GSource > associated with a group of files, which are dynamically allocated > and release, ex, slirp. > > Signed-off-by: Liu Ping Fan > --- > util/Makefile.objs | 1 + > util/event_gsource.c

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Christoffer Dall
On Thu, Aug 08, 2013 at 09:48:23PM +0100, Peter Maydell wrote: > On 8 August 2013 20:29, Christoffer Dall wrote: > > On Thu, Aug 08, 2013 at 08:05:11PM +0100, Peter Maydell wrote: > >> On 8 August 2013 19:39, Christoffer Dall > >> wrote: > >> > FWIW, from the kernel point of view I'd much prefer

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Peter Maydell
On 8 August 2013 20:29, Christoffer Dall wrote: > On Thu, Aug 08, 2013 at 08:05:11PM +0100, Peter Maydell wrote: >> On 8 August 2013 19:39, Christoffer Dall wrote: >> > FWIW, from the kernel point of view I'd much prefer to return "this is >> > the type of VCPU that I prefer to emulate" to user s

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Christoffer Dall
On Thu, Aug 08, 2013 at 08:05:11PM +0100, Peter Maydell wrote: > On 8 August 2013 19:39, Christoffer Dall wrote: > > FWIW, from the kernel point of view I'd much prefer to return "this is > > the type of VCPU that I prefer to emulate" to user space on this current > > host than having QEMU come up

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Peter Maydell
On 8 August 2013 19:39, Christoffer Dall wrote: > FWIW, from the kernel point of view I'd much prefer to return "this is > the type of VCPU that I prefer to emulate" to user space on this current > host than having QEMU come up with its own suggestion for CPU and asking > the kernel for it. The r

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Eric Blake
On 08/08/2013 11:05 AM, Orit Wasserman wrote: > "ram" is present also when migration completes. > expected-downtime, total-time and downtime are no longer part of "ram" data. > > Signed-off-by: Orit Wasserman > --- > qmp-commands.hx | 20 ++-- > 1 file changed, 10 insertions(+),

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Christoffer Dall
On Thu, Aug 08, 2013 at 07:20:41PM +0100, Peter Maydell wrote: > On 8 August 2013 16:55, Andreas Färber wrote: > > Am 08.08.2013 14:51, schrieb Peter Maydell: > >> So, coming at this from an ARM perspective: > >> Should any target arch that supports KVM also support "-cpu host"? > >> If so, what s

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Peter Maydell
On 8 August 2013 16:55, Andreas Färber wrote: > Am 08.08.2013 14:51, schrieb Peter Maydell: >> So, coming at this from an ARM perspective: >> Should any target arch that supports KVM also support "-cpu host"? >> If so, what should it do? > > I think that depends on the target and whether/what is u

[Qemu-devel] [PATCH v2 for 1.6] w32: Add missing version.o to all executables (fix regression)

2013-08-08 Thread Stefan Weil
QEMU executables for w32, w64 had included meta information built from version.rc. These rules were changed several times some months ago. The latest version added version.o to the tools, but not to the system emulations. This patch adds the meta information to all system emulations again. Signe

[Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
"ram" is present also when migration completes. expected-downtime, total-time and downtime are no longer part of "ram" data. Signed-off-by: Orit Wasserman --- qmp-commands.hx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands

Re: [Qemu-devel] [ceph-users] qemu-1.4.0 and onwards, linux kernel 3.2.x, ceph-RBD, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process, [Bug 1207686]

2013-08-08 Thread Josh Durgin
On 08/08/2013 05:40 AM, Oliver Francke wrote: Hi Josh, I have a session logged with: debug_ms=1:debug_rbd=20:debug_objectcacher=30 as you requested from Mike, even if I think, we do have another story here, anyway. Host-kernel is: 3.10.0-rc7, qemu-client 1.6.0-rc2, client-kernel is 3.2.0

[Qemu-devel] [PATCH 01/14] target-arm: Make IRQ and FIQ gpio lines on the CPU object

2013-08-08 Thread Peter Maydell
Now that ARMCPU is a subclass of DeviceState, we can make the CPU's inbound IRQ and FIQ lines be simply gpio lines, which means we can remove the odd arm_pic shim. We retain the arm_pic_init_cpu() function as a backwards compatibility shim layer so we can convert the board models to get the IRQ an

Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions"

2013-08-08 Thread Andreas Färber
Am 08.08.2013 18:48, schrieb Peter Maydell: > On 8 August 2013 17:46, Andreas Färber wrote: >> Since no one has spoken up with a concrete use case that breaks when >> having the PIO region opaque, I agree this seems the best solution we >> have for 1.6. But given the musicpal issue you have raised

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Luiz Capitulino
On Thu, 08 Aug 2013 19:47:50 +0300 Orit Wasserman wrote: > On 08/08/2013 05:50 PM, Luiz Capitulino wrote: > > On Thu, 8 Aug 2013 11:46:14 +0300 > > Orit Wasserman wrote: > > > >> "ram" is present also when migration completes. > >> total-time and downtime are no longer part of "ram" data. > >

Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions"

2013-08-08 Thread Peter Maydell
On 8 August 2013 17:46, Andreas Färber wrote: > Since no one has spoken up with a concrete use case that breaks when > having the PIO region opaque, I agree this seems the best solution we > have for 1.6. But given the musicpal issue you have raised, I would ask > Paolo or Jan to squash these two

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
On 08/08/2013 05:50 PM, Luiz Capitulino wrote: > On Thu, 8 Aug 2013 11:46:14 +0300 > Orit Wasserman wrote: > >> "ram" is present also when migration completes. >> total-time and downtime are no longer part of "ram" data. > > expected-downtime has to be moved too, looks good otherwise. I will f

[Qemu-devel] [PULL for-1.6] TCG mips --enable-debug fix

2013-08-08 Thread Richard Henderson
Please pull for -rc2, thanks. r~ The following changes since commit 6fdf98f281f85ae6e2883bed2f691bcfe33b1f9f: fw_cfg: the I/O port variant expects little-endian (2013-08-07 12:48:15 -0500) are available in the git repository at: git://github.com/rth7680/qemu.git for-1.6 for you to fetch

[Qemu-devel] [PULL for-1.6] tcg/mips: fix invalid op definition errors

2013-08-08 Thread Richard Henderson
From: James Hogan tcg/mips/tcg-target.h defines various operations conditionally depending upon the isa revision, however these operations are included in mips_op_defs[] unconditionally resulting in the following runtime errors if CONFIG_DEBUG_TCG is defined: Invalid op definition for movcond_i3

Re: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions"

2013-08-08 Thread Andreas Färber
Am 08.08.2013 17:23, schrieb Peter Maydell: > On 3 August 2013 09:31, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71. >> >> The commit was wrong: We only return -1 on invalid accesses, not on >> valid but unbacked ones. This broke various

[Qemu-devel] [PATCH] pc: drop external DSDT loading

2013-08-08 Thread Anthony Liguori
This breaks migration and is unneeded with modern SeaBIOS. Signed-off-by: Anthony Liguori --- hw/i386/pc_piix.c | 1 - hw/i386/pc_q35.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index ab25458..daaff8a 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Peter Maydell
On 8 August 2013 17:25, Anthony Liguori wrote: > Peter Maydell writes: >> On 8 August 2013 17:07, Anthony Liguori wrote: >>> CPU data structures are still read as big endian though. >> >> Do you have an example of what you mean by "CPU data structure"? > > MMU tlb hash table. If you grep ldl ta

[Qemu-devel] [PATCH 05/14] hw/arm/integratorcp: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/integratorcp.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c index d

Re: [Qemu-devel] [PATCH v1 1/5] util: introduce gsource event abstraction

2013-08-08 Thread Michael Roth
Quoting Liu Ping Fan (2013-08-08 01:26:07) > Introduce struct EventsGSource. It will ease the usage of GSource > associated with a group of files, which are dynamically allocated > and release, ex, slirp. > > Signed-off-by: Liu Ping Fan > --- > util/Makefile.objs | 1 + > util/event_gsource.c

Re: [Qemu-devel] [PATCH v2 for-1.6] pc: disable pci-info for 1.6

2013-08-08 Thread Andreas Färber
Am 08.08.2013 17:55, schrieb Michael S. Tsirkin: > The BIOS that we ship in 1.6 does not use pci info > from host (yet). Several issues turned up > (e.g. around winXP boot crashes). So it's safest to disable that > interface for 1.6 machine types for now, leave it on for 1.7 > so we have enough tim

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Anthony Liguori
Peter Maydell writes: > On 8 August 2013 17:07, Anthony Liguori wrote: >> It's the same processor. It still starts executing big endian >> instructions. A magic register value is tweaked and loads/stores are >> swapped. > > I dunno about PPC, but for ARM generally the boot-up state is > contro

[Qemu-devel] [PATCH 07/14] hw/arm/musicpal: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/musicpal.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index d715143..4404b8d

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Andreas Färber
Am 08.08.2013 17:40, schrieb Anthony Liguori: > Andreas Färber writes: >> Am 08.08.2013 15:31, schrieb Anthony Liguori: >>> We have a mechanism to do weak functions via stubs/. I think it would >>> be better to do cpu_get_byteswap() as a stub function and then overload >>> it in the ppc64 code. >

[Qemu-devel] [PATCH 10/14] hw/arm/strongarm: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/strongarm.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c index 82a9492..7b

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Peter Maydell
On 8 August 2013 17:07, Anthony Liguori wrote: > It's the same processor. It still starts executing big endian > instructions. A magic register value is tweaked and loads/stores are > swapped. I dunno about PPC, but for ARM generally the boot-up state is controlled by config signals which a SoC

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, Aug 08, 2013 at 10:40:28AM -0500, Anthony Liguori wrote: >> Andreas Färber writes: >> >> We have a mechanism to do weak functions via stubs/. I think it would >> >> be better to do cpu_get_byteswap() as a stub function and then overload >> >> it in the ppc

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Anthony Liguori
Peter Maydell writes: > On 8 August 2013 16:40, Anthony Liguori wrote: >> PPC64 is big endian. AFAIK, there is no such thing as a little endian >> PPC64 processor. > > What's your definition of "little endian processor" here if > it isn't "one which is doing byte swaps of data"? I would > descr

[Qemu-devel] [PATCH 08/14] hw/arm/omap*: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/omap1.c |8 hw/arm/omap2.c |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm/omap1.c b/hw/arm/om

[Qemu-devel] [PATCH 09/14] hw/arm/realview: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/realview.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/realview.c b/hw/arm/realview.c index 3060f48..82ec02d

Re: [Qemu-devel] [PATCH] tcg/mips: fix invalid op definition errors

2013-08-08 Thread Richard Henderson
On 08/08/2013 04:40 AM, James Hogan wrote: > tcg/mips/tcg-target.h defines various operations conditionally depending > upon the isa revision, however these operations are included in > mips_op_defs[] unconditionally resulting in the following runtime errors > if CONFIG_DEBUG_TCG is defined: > > I

[Qemu-devel] [PATCH 04/14] hw/arm/highbank: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/highbank.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index 35d5511..f733a6c

[Qemu-devel] [PATCH 03/14] hw/arm/exynos4210: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/exynos4210.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c ind

[Qemu-devel] [PATCH 02/14] hw/arm/armv7m: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/armv7m.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 82d36fb..89a9015 1006

[Qemu-devel] [PATCH 12/14] hw/arm/vexpress: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/vexpress.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index 9586e38..fbd

[Qemu-devel] [PATCH 13/14] hw/arm/xilinx_zynq: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/xilinx_zynq.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 3444

[Qemu-devel] [PATCH 14/14] hw/arm/pic_cpu: Remove the now-unneeded arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Now all the boards have been converted arm_pic_init_cpu() is unused and can just be deleted. Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs |2 +- hw/arm/pic_cpu.c | 25 - include/hw/arm/arm.h |5 - 3 files changed, 1 insertion(+), 31 deletions(-)

[Qemu-devel] [PATCH 00/14] ARM: make IRQ/FIQ gpio lines on CPU object

2013-08-08 Thread Peter Maydell
This patch series makes IRQ and FIQ be inbound gpio lines on the ARMCPU object (which we can do now that it is a subclass of DeviceState). This allows us to drop the odd 'arm_pic' shim, which doesn't correspond to real hardware and existed purely to be a thing which exposed qemu_irqs. Peter Maydel

[Qemu-devel] [PATCH 06/14] hw/arm/kzm: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/kzm.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/arm/kzm.c b/hw/arm/kzm.c index bd6c05c..a248bf0 100644 ---

[Qemu-devel] [PATCH 11/14] hw/arm/versatilepb: Don't use arm_pic_init_cpu()

2013-08-08 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell --- hw/arm/versatilepb.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/arm/versatilepb.c b/hw/arm/versatilepb.c index b48d

Re: [Qemu-devel] [PATCH v2 for-1.6] pc: disable pci-info for 1.6

2013-08-08 Thread Richard Henderson
On 08/08/2013 05:55 AM, Michael S. Tsirkin wrote: > The BIOS that we ship in 1.6 does not use pci info > from host (yet). Several issues turned up > (e.g. around winXP boot crashes). So it's safest to disable that > interface for 1.6 machine types for now, leave it on for 1.7 > so we have enough ti

Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.

2013-08-08 Thread Benoît Canet
> Also, it would be better to have a workaround for this. Perhaps we > could simply make the default value of max nonzero? In the old > throttling code the slice time is 0.1s, so perhaps we could see what > happens with max=0.1*avg. This gives correct results with cfg with some little auto compe

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-08 Thread Andreas Färber
Hi Peter, Am 08.08.2013 14:51, schrieb Peter Maydell: > [I missed this KVM call but the stuff about -cpu host ties into > an issue we've been grappling with for ARM KVM, so it seems > a reasonable jumping-off-point.] > > On 6 August 2013 16:15, Juan Quintela wrote: >> 2013-08-06 >> -- >>

Re: [Qemu-devel] [PATCH] block: Bugfix 'format' and 'snapshot' used in drive option

2013-08-08 Thread Kevin Wolf
Am 08.08.2013 um 16:45 hat Mike Qiu geschrieben: > When use -drive file='xxx',format=qcow2,snapshot=on the error > message "Can't use snapshot=on with driver-specific options" > can be show, and fail to start the qemu. > > This should not be happened, and there is no file.driver option > in qemu c

[Qemu-devel] [PATCH v2 for-1.6] pc: disable pci-info for 1.6

2013-08-08 Thread Michael S. Tsirkin
The BIOS that we ship in 1.6 does not use pci info from host (yet). Several issues turned up (e.g. around winXP boot crashes). So it's safest to disable that interface for 1.6 machine types for now, leave it on for 1.7 so we have enough time to figure out the right way to fix issues if any. Cc: Ri

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Peter Maydell
On 8 August 2013 16:40, Anthony Liguori wrote: > PPC64 is big endian. AFAIK, there is no such thing as a little endian > PPC64 processor. What's your definition of "little endian processor" here if it isn't "one which is doing byte swaps of data"? I would describe a PPC64 with the relevant mode

Re: [Qemu-devel] [PATCH 1/7] virtio: allow byte swapping for vring and config access

2013-08-08 Thread Daniel P. Berrange
On Thu, Aug 08, 2013 at 10:40:28AM -0500, Anthony Liguori wrote: > Andreas Färber writes: > >> We have a mechanism to do weak functions via stubs/. I think it would > >> be better to do cpu_get_byteswap() as a stub function and then overload > >> it in the ppc64 code. > > > > If this as your name

Re: [Qemu-devel] [PATCH 1/2] memory: Provide separate handling of unassigned io ports accesses

2013-08-08 Thread Jan Kiszka
On 2013-08-08 17:33, Peter Maydell wrote: > On 3 August 2013 09:31, Jan Kiszka wrote: >> --- a/ioport.c >> +++ b/ioport.c >> @@ -44,6 +44,22 @@ typedef struct MemoryRegionPortioList { >> MemoryRegionPortio ports[]; >> } MemoryRegionPortioList; >> >> +static uint64_t unassigned_io_read(void *

Re: [Qemu-devel] [PATCH V4 3/5] block: Enable the new throttling code in the block layer.o

2013-08-08 Thread Benoît Canet
> This is not really accurate; the cfq scheduler reorders reads and writes > to have longer bursts, and these sometimes exceed the rate you set. I > understood this is mostly for separate rd/wr settings, or did you > reproduce it with "total" rates too? I'll drop the comment. It's only with read

  1   2   >