Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat

2013-05-15 Thread Amos Kong
On Thu, May 16, 2013 at 01:30:28PM +0800, li guang wrote: > 在 2013-05-16四的 12:30 +0800,Amos Kong写道: > > Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, > > but ps2 backend doesn't process it and no auto-repeat implementation. > > This patch adds support of auto-repeat feature. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/11] vfio: Add guest side IOMMU support

2013-05-15 Thread David Gibson
On Wed, May 15, 2013 at 01:32:50PM +1000, David Gibson wrote: > On Tue, May 14, 2013 at 08:51:08PM -0600, Alex Williamson wrote: > > On Wed, 2013-05-15 at 11:33 +1000, David Gibson wrote: > > > On Tue, May 14, 2013 at 11:15:26AM -0600, Alex Williamson wrote: > > > > On Tue, 2013-05-14 at 19:13 +100

Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat

2013-05-15 Thread Peter Maydell
On 16 May 2013 05:30, Amos Kong wrote: > Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, > but ps2 backend doesn't process it and no auto-repeat implementation. > This patch adds support of auto-repeat feature. > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > index 3412079..1cfe

Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat

2013-05-15 Thread Jason Wang
On 05/16/2013 12:30 PM, Amos Kong wrote: > Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, > but ps2 backend doesn't process it and no auto-repeat implementation. > This patch adds support of auto-repeat feature. > > Guest ps2 driver sets autorepeat to fastest possible in reset, >

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2013-05-15 Thread Michael S. Tsirkin
On Thu, May 16, 2013 at 09:24:05AM +0300, Michael S. Tsirkin wrote: > On Wed, May 15, 2013 at 12:00:03PM +0100, Nicholas Thomas wrote: > > Hi again, > > > > On Tue, 2013-05-14 at 15:49 +0100, Nicholas Thomas wrote: > > > /sys/devices/virtual/net/t100/tun_flags is 0x5002 - so it looks like > > > IF

Re: [Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-15 Thread Wenchao Xia
于 2013-5-15 22:34, Stefan Hajnoczi 写道: > Note: These patches apply to my block-next tree. You can also grab the code > from git here: > git://github.com/stefanha/qemu.git block-backup-core > > This series adds a new QMP command, drive-backup, which takes a point-in-time > snapshot of a block devi

Re: [Qemu-devel] [PATCH] ui/input.c: replace magic numbers with macros

2013-05-15 Thread Lei Li
On 05/16/2013 01:19 PM, Amos Kong wrote: It's clearer to use defined macros than magic numbers. Signed-off-by: Amos Kong --- ui/input.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ui/input.c b/ui/input.c index 8ca1a03..92c44ca 100644 --- a/ui/input.c +++

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-15 Thread TeLeMan
The patch is working on 134a03e0b3d34b01b68107104c525c3bff1211d4 and is not working from cbff4b342b000a7642125dbdabf61113e05eee44. -- SUN OF A BEACH On Wed, May 15, 2013 at 4:37 PM, Paolo Bonzini wrote: > Il 15/05/2013 03:38, TeLeMan ha scritto: >> On Tue, May 14, 2013 at 7:55 PM, Paolo Bonzini

Re: [Qemu-devel] [PATCH] ps2: add support of auto-repeat

2013-05-15 Thread li guang
在 2013-05-16四的 12:30 +0800,Amos Kong写道: > Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, > but ps2 backend doesn't process it and no auto-repeat implementation. > This patch adds support of auto-repeat feature. > > Guest ps2 driver sets autorepeat to fastest possible in reset, >

[Qemu-devel] [PATCH] ui/input.c: replace magic numbers with macros

2013-05-15 Thread Amos Kong
It's clearer to use defined macros than magic numbers. Signed-off-by: Amos Kong --- ui/input.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ui/input.c b/ui/input.c index 8ca1a03..92c44ca 100644 --- a/ui/input.c +++ b/ui/input.c @@ -28,6 +28,7 @@ #include "qa

Re: [Qemu-devel] seabios for qemu 1.5

2013-05-15 Thread Amos Kong
On Wed, Apr 24, 2013 at 02:11:26PM +0800, Amos Kong wrote: > On Wed, Apr 24, 2013 at 07:59:36AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > b44a7be17bdd270ea029a8e2ec0c2e80c6cd0444 virtio-scsi: Pack struct > > > virtio_scsi_{req_cmd,resp_cmd} > > > 5a7730db57ab0715223421e65b54fb50d6fefe5c vir

[Qemu-devel] [PATCH] ps2: add support of auto-repeat

2013-05-15 Thread Amos Kong
Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat implementation. This patch adds support of auto-repeat feature. Guest ps2 driver sets autorepeat to fastest possible in reset, period: 250ms, delay: 33ms Tested by 'sendkey' mon

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc2 is now available

2013-05-15 Thread Dongsheng Song
On Thu, May 16, 2013 at 7:53 AM, Anthony Liguori wrote: > Hi, > > On behalf of the QEMU Team, I'd like to announce the availability of the > third release candidate for the QEMU 1.5 release. This release is meant > for testing purposes and should not be used in a production environment. > > http:

Re: [Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver

2013-05-15 Thread Wenchao Xia
> From: Dietmar Maurer > > backup_start() creates a block job that copies a point-in-time snapshot > of a block device to a target block device. > > We call backup_do_cow() for each write during backup. That function > reads the original data from the block device before it gets > overwritten.

Re: [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

2013-05-15 Thread Wenchao Xia
Reviewed the code, except Paolo's comments, function seems fine. Il 15/05/2013 16:34, Stefan Hajnoczi ha scritto: The bdrv_add_before_write_cb() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time snapshot

Re: [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular

2013-05-15 Thread Wenchao Xia
> The QMP 'transaction' command keeps a list of in-flight transactions. > The transaction state structure is called BlkTransactionStates even > though it only deals with a single transaction. The only plural thing > is the linked list of transaction states. > > I find it confusing to call the sin

Re: [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction

2013-05-15 Thread Wenchao Xia
于 2013-5-16 3:01, Eric Blake 写道: On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: The Abort action can be used to test QMP 'transaction' failure. Add it as the last action to exercise the .abort() and .cleanup() code paths for all previous actions. Signed-off-by: Stefan Hajnoczi --- blockdev.

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-15 Thread Wenchao Xia
于 2013-5-15 20:28, Luiz Capitulino 写道: On Wed, 15 May 2013 10:10:37 +0800 Wenchao Xia wrote: 于 2013-5-6 21:22, Luiz Capitulino 写道: On Mon, 06 May 2013 10:09:43 +0800 Wenchao Xia wrote: 于 2013-5-3 10:51, Wenchao Xia 写道: 于 2013-5-2 20:02, Luiz Capitulino 写道: On Thu, 02 May 2013 10:05:08 +0

Re: [Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false

2013-05-15 Thread li guang
在 2013-05-15三的 15:44 +0200,Laszlo Ersek写道: > On 05/15/13 10:54, li guang wrote: > > 在 2013-05-15三的 10:38 +0200,Paolo Bonzini写道: > >> Il 15/05/2013 06:01, liguang ha scritto: > >>> Signed-off-by: liguang > >> > >> --verbose, please. > >> > >> What problem does this patch fix? > > > > Oh, sorry to

[Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc2 is now available

2013-05-15 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 1.5 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.5.0-rc2.tar.bz2 You can help improve

[Qemu-devel] [PATCH] pcie: Add more ASPM support

2013-05-15 Thread Bjorn Helgaas
Indicate ASPM L0s and L1 support in Link Capabilities and make the ASPM bits in Link Control writable. These Link Control bits don't do anything in qemu, but having them writable means the BIOS or OS can write them as on real hardware. Signed-off-by: Bjorn Helgaas --- hw/pci/pcie.c

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-15 Thread Cole Robinson
On 05/14/2013 05:52 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.4.2: > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > The release is planned for 05-24-2013: > > http://wiki.qemu.org/Planning/1.4 > > Please CC qemu-sta...@n

Re: [Qemu-devel] Para-Virtualized Clock Usage

2013-05-15 Thread Joji Mekkattuparamban (joji)
Hi Gleb, On a related note, does Qemu have an option to emulate RDTSC? Thanks, Joji. -Original Message- From: Gleb Natapov [mailto:g...@redhat.com] Sent: Wednesday, April 24, 2013 11:57 PM To: Joji Mekkattuparamban (joji) Cc: Marcelo Tosatti; qemu-devel@nongnu.org; k...@vger.kernel.org

Re: [Qemu-devel] [Bug 1094564] Re: images used as scsi disks not readable (qemu-system-arm, macos 10.8)

2013-05-15 Thread Peter Maydell
On 15 May 2013 19:02, Joss Reeves wrote: > Thanks so much for the patch and including me on the thread. I can > confirm that it did fix the problem running on a Linux host, but the OS > X bug cited by myself and the OP still remains elusive. It's rather > puzzling as I pulled from HEAD and built u

Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU

2013-05-15 Thread Peter Maydell
On 15 May 2013 16:48, Paolo Bonzini wrote: > Here is an RCU implementation based on liburcu. Doesn't compile on MacOSX/clang: CCutil/rcu.o In file included from util/rcu.c:35: /Users/pm215/src/qemu/include/qemu/rcu.h:112:6: warning: implicit declaration of function 'g_private_replace' is i

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

2013-05-15 Thread mdroth
On Wed, May 15, 2013 at 02:05:58PM -0400, Luiz Capitulino wrote: > On Wed, 15 May 2013 12:42:24 -0500 > mdroth wrote: > > > On Wed, May 15, 2013 at 11:04:27AM -0400, Luiz Capitulino wrote: > > > On Wed, 15 May 2013 09:32:37 -0500 > > > mdroth wrote: > > > > > > > On Wed, May 15, 2013 at 09:17:4

Re: [Qemu-devel] [PATCH v3 6/8] blockdev: add DriveBackup transaction

2013-05-15 Thread Eric Blake
On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: > This patch adds a transactional version of the drive-backup QMP command. > It allows atomic snapshots of multiple drives along with automatic > cleanup if there is a failure to start one of the backup jobs. > > Note that QMP events are emitted for b

Re: [Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular

2013-05-15 Thread Eric Blake
On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: > The QMP 'transaction' command keeps a list of in-flight transactions. > The transaction state structure is called BlkTransactionStates even > though it only deals with a single transaction. The only plural thing > is the linked list of transaction s

Re: [Qemu-devel] [PATCH for-1.5 0/3] hw/pci-host/versatile: Fix issues with newer kernels

2013-05-15 Thread Linus Walleij
On Tue, May 14, 2013 at 5:33 PM, Peter Maydell wrote: > The reworking of the versatile PCI controller model so that it actually > behaved like hardware included an attempt to autodetect whether the > guest Linux kernel was assuming the old broken behaviour. Unfortunately > it turns out that there

Re: [Qemu-devel] [PATCH v3 3/8] block: add drive-backup QMP command

2013-05-15 Thread Eric Blake
On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: > @drive-backup > > Start a point-in-time copy of a block device to a new destination. The > status of ongoing drive-backup operations can be checked with > query-block-jobs where the BlockJobInfo.type field has the value 'backup'. > The operation ca

Re: [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction

2013-05-15 Thread Eric Blake
On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote: > The Abort action can be used to test QMP 'transaction' failure. Add it > as the last action to exercise the .abort() and .cleanup() code paths > for all previous actions. > > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 15 ++

Re: [Qemu-devel] [Bug 1094564] Re: images used as scsi disks not readable (qemu-system-arm, macos 10.8)

2013-05-15 Thread Joss Reeves
Hi Peter, Thanks so much for the patch and including me on the thread. I can confirm that it did fix the problem running on a Linux host, but the OS X bug cited by myself and the OP still remains elusive. It's rather puzzling as I pulled from HEAD and built using the same options on both. I've got

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

2013-05-15 Thread Luiz Capitulino
On Wed, 15 May 2013 12:42:24 -0500 mdroth wrote: > On Wed, May 15, 2013 at 11:04:27AM -0400, Luiz Capitulino wrote: > > On Wed, 15 May 2013 09:32:37 -0500 > > mdroth wrote: > > > > > On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > > > > On Fri, 10 May 2013 17:45:59 -0500 > >

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

2013-05-15 Thread mdroth
On Wed, May 15, 2013 at 11:04:27AM -0400, Luiz Capitulino wrote: > On Wed, 15 May 2013 09:32:37 -0500 > mdroth wrote: > > > On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > > > On Fri, 10 May 2013 17:45:59 -0500 > > > Michael Roth wrote: > > > > > > > These patches apply on to

Re: [Qemu-devel] [PATCH v2] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-15 Thread Jordan Justen
On Tue, May 14, 2013 at 7:57 AM, Anthony Liguori wrote: > Jordan Justen writes: > >> The isapc machine with seabios currently requires the BIOS region >> to be read/write memory rather than read-only memory. >> >> KVM currently cannot support the BIOS as a ROM region, but qemu >> in non-KVM mode

Re: [Qemu-devel] [SeaBIOS] [PATCH v17] Add pvpanic device driver

2013-05-15 Thread Laszlo Ersek
On 05/15/13 18:25, Paolo Bonzini wrote: > Il 15/05/2013 18:25, Laszlo Ersek ha scritto: >> (Not sure why the CC list has grown this huge, but I'm adding Drew for >> good mesaure.) >> >> On 05/15/13 09:27, Hu Tao wrote: >>> On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote: On 04/05/

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-15 Thread mdroth
On Wed, May 15, 2013 at 10:09:32AM -0400, Brad Smith wrote: > On Tue, May 14, 2013 at 04:52:57PM -0500, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v1.4.2: > > > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > > > The release

Re: [Qemu-devel] [SeaBIOS] [PATCH v17] Add pvpanic device driver

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 18:25, Laszlo Ersek ha scritto: > (Not sure why the CC list has grown this huge, but I'm adding Drew for > good mesaure.) > > On 05/15/13 09:27, Hu Tao wrote: >> On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote: >>> On 04/05/13 09:17, Hu Tao wrote: >>> +M

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 18:22, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> Il 15/05/2013 17:09, Markus Armbruster ha scritto: >>> @@ -209,7 +209,7 @@ void pc_system_firmware_init(MemoryRegion >>> *rom_memory) >>> * TODO This device exists only so that users can switch betw

Re: [Qemu-devel] [SeaBIOS] [PATCH v17] Add pvpanic device driver

2013-05-15 Thread Laszlo Ersek
(Not sure why the CC list has grown this huge, but I'm adding Drew for good mesaure.) On 05/15/13 09:27, Hu Tao wrote: > On Wed, May 15, 2013 at 09:21:54AM +0200, Laszlo Ersek wrote: >> On 04/05/13 09:17, Hu Tao wrote: >> >>> +Method(RDPT, 0, NotSerialized) { >>> +Store

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Markus Armbruster
Paolo Bonzini writes: > Il 15/05/2013 17:09, Markus Armbruster ha scritto: >> @@ -209,7 +209,7 @@ void pc_system_firmware_init(MemoryRegion >> *rom_memory) >> * TODO This device exists only so that users can switch between >> * use of flash and ROM for the BIOS. The

Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 18:16, Peter Maydell ha scritto: > On 15 May 2013 16:48, Paolo Bonzini wrote: >> Giving a shot to rcutorture on a weak memory-model machine (PPC) >> would be nice. > > # ./tests/rcutorture 16 rperf 2 > n_reads: 116103000 n_updates: 0 nreaders: 16 nupdaters: 0 duration: 2 > ns/rea

Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 18:03, Peter Maydell ha scritto: > On 15 May 2013 16:48, Paolo Bonzini wrote: >> Giving a shot to rcutorture on a weak memory-model machine (PPC) >> would be nice. It's available on my github repo as branch rcu. >> rcutorture works on Linux-x86. My WINE setup has some problem with

Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU

2013-05-15 Thread Peter Maydell
On 15 May 2013 16:48, Paolo Bonzini wrote: > Giving a shot to rcutorture on a weak memory-model machine (PPC) > would be nice. # ./tests/rcutorture 16 rperf 2 n_reads: 116103000 n_updates: 0 nreaders: 16 nupdaters: 0 duration: 2 ns/read: 275.617 ns/update: nan ...that "nan" isn't entirely re

Re: [Qemu-devel] [PATCH 01/12] add a header file for atomic operations

2013-05-15 Thread Peter Maydell
On 15 May 2013 16:48, Paolo Bonzini wrote: > We're already using them in several places, but __sync builtins are just > too ugly to type, and do not provide seqcst load/store operations. This doesn't compile: CCtests/test-thread-pool.o tests/test-thread-pool.c: In function ‘worker_cb’: tes

Re: [Qemu-devel] Fwd: Re: [PATCH v4 2/2] Add AT24Cxx I2C EEPROM device model

2013-05-15 Thread Jan Kiszka
On 2013-05-15 08:20, Weng Fan wrote: > Hi. > I want to use this patch for qemu-system-arm. > But an error occurred during initialization of the i2c device. > > The error message is : > > qemu-system-arm: drive property not set > qemu-system-arm: Initialization of device at24 failed > > The comma

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

2013-05-15 Thread mdroth
On Wed, May 15, 2013 at 10:37:43AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 15/05/2013 15:24, Kevin Wolf ha scritto: > >> Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: > >>> Il 15/05/2013 15:00, Kevin Wolf ha scritto: > The test case passes on big endian hosts n

Re: [Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU

2013-05-15 Thread Peter Maydell
On 15 May 2013 16:48, Paolo Bonzini wrote: > Giving a shot to rcutorture on a weak memory-model machine (PPC) > would be nice. It's available on my github repo as branch rcu. > rcutorture works on Linux-x86. My WINE setup has some problem with glib > right now. Doesn't compile (ARM): root@local

[Qemu-devel] [PATCH 07/12] rcu: allow nested calls to rcu_thread_offline/rcu_thread_online

2013-05-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 5 + include/qemu/rcu.h | 21 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/docs/rcu.txt b/docs/rcu.txt index d7c4f0b..4e7cde3 100644 --- a/docs/rcu.txt +++ b/docs/rcu.txt @@ -187,6 +187,11 @@ Marki

[Qemu-devel] [PATCH 12/12] migration: report RCU quiescent states

2013-05-15 Thread Paolo Bonzini
The migration thread polls s->state periodically, it does not use a mutex or condition variable, so it has to report quiescent states manually. Signed-off-by: Paolo Bonzini --- migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration.c b/migration.c index 866d68d..fb8b326 1006

[Qemu-devel] [PATCH 01/12] add a header file for atomic operations

2013-05-15 Thread Paolo Bonzini
We're already using them in several places, but __sync builtins are just too ugly to type, and do not provide seqcst load/store operations. Signed-off-by: Paolo Bonzini --- docs/atomics.txt | 322 +++ hw/display/qxl.c | 3 +- hw/virti

[Qemu-devel] [PATCH 10/12] cpus: report RCU quiescent states

2013-05-15 Thread Paolo Bonzini
CPU threads have extended quiescent states while relinquishing control to the accelerator (except TCG). Signed-off-by: Paolo Bonzini --- cpus.c| 3 +++ kvm-all.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/cpus.c b/cpus.c index c232265..66970d6 100644 --- a/cpus.c +++ b/cpus.c @@

[Qemu-devel] [PATCH 09/12] event loop: report RCU quiescent states

2013-05-15 Thread Paolo Bonzini
Threads that run event loops also have places that can sleep for an extended time. Place an extended quiescent state there. Signed-off-by: Paolo Bonzini --- aio-posix.c | 7 +++ aio-win32.c | 10 +- main-loop.c | 5 + 3 files changed, 21 insertions(+), 1 deletion(-) diff --gi

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 17:09, Markus Armbruster ha scritto: > @@ -209,7 +209,7 @@ void pc_system_firmware_init(MemoryRegion *rom_memory) > * TODO This device exists only so that users can switch between > * use of flash and ROM for the BIOS. The ability to switch was > * c

[Qemu-devel] [PATCH 08/12] qemu-thread: report RCU quiescent states

2013-05-15 Thread Paolo Bonzini
Most threads will use mutexes and other sleeping synchronization primitives (condition variables, semaphores, events) periodically. For these threads, the synchronization primitives are natural places to report a quiescent state (possibly an extended one). Signed-off-by: Paolo Bonzini --- docs/

[Qemu-devel] [PATCH 04/12] qemu-thread: register threads with RCU

2013-05-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 13 +++-- util/qemu-thread-posix.c | 28 +++- util/qemu-thread-win32.c | 2 ++ 3 files changed, 36 insertions(+), 7 deletions(-) diff --git a/docs/rcu.txt b/docs/rcu.txt index 19e4840..5736676 100644 ---

[Qemu-devel] [PATCH 06/12] rcu: add rcutorture

2013-05-15 Thread Paolo Bonzini
A stress test program (works, too :)). Signed-off-by: Paolo Bonzini --- tests/Makefile | 5 +- tests/rcutorture.c | 387 + 2 files changed, 391 insertions(+), 1 deletion(-) create mode 100644 tests/rcutorture.c diff --git a/tests/Makefi

[Qemu-devel] [RFC PATCH 00/12] RCU implementation for QEMU

2013-05-15 Thread Paolo Bonzini
Here is an RCU implementation based on liburcu. I had posted something like this a couple years ago, but there have been many changes: - more portable code - adjusted for all the threads that we have now - updated atomic operations for GCC 4.8 - lots of documentation There is plenty of docume

[Qemu-devel] [PATCH 03/12] rcu: add rcu library

2013-05-15 Thread Paolo Bonzini
This includes a (mangled) copy of the urcu-qsbr code from liburcu. The main changes are: 1) removing dependencies on many other header files in liburcu; 2) removing for simplicity the tentative busy waiting in synchronize_rcu, which has limited performance effects; 3) replacing futexes in synchroni

[Qemu-devel] [PATCH 05/12] rcu: add call_rcu

2013-05-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/rcu.txt | 108 +-- include/qemu/rcu.h | 22 ++ util/rcu.c | 120 + 3 files changed, 246 insertions(+), 4 deletions(-) diff --git a/docs/rcu

[Qemu-devel] [PATCH 11/12] block: report RCU quiescent states

2013-05-15 Thread Paolo Bonzini
The aio workers may spend a long time executing I/O operations; mark that time as an extended quiescent state. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 3 +++ block/raw-win32.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index c0ccf27

[Qemu-devel] [PATCH 02/12] qemu-thread: add QemuEvent

2013-05-15 Thread Paolo Bonzini
This emulates Win32 manual-reset events using futexes or conditional variables. Typical ways to use them are with multi-producer, single-consumer data structures, to test for a complex condition whose elements come from different threads: for (;;) { qemu_event_reset(ev); ... t

[Qemu-devel] [PATCH buildfix for-1.5] qemu-common: Resolve vector build breakes for AltiVec

2013-05-15 Thread Andreas Färber
From: Paolo Bonzini On Mac OS X ppc, altivec.h defines "vector", leading to build breakage when used as variable name, e.g. in tracing code. Fix this by undefining identifiers after altivec.h inclusion. Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- include/qemu-common.h | 10

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

2013-05-15 Thread Anthony Liguori
Paolo Bonzini writes: > Il 15/05/2013 15:24, Kevin Wolf ha scritto: >> Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: >>> Il 15/05/2013 15:00, Kevin Wolf ha scritto: The test case passes on big endian hosts now (tested on ppc64) Signed-off-by: Kevin Wolf >>> >>> For 1.5? D

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Markus Armbruster
Paolo Bonzini writes: > Il 15/05/2013 16:28, Markus Armbruster ha scritto: >> Sorry for the delay, I was off for a few days. >> >> Anthony Liguori writes: >> >>> Paolo Bonzini writes: >>> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. While Markus's analysis is entire

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

2013-05-15 Thread Luiz Capitulino
On Wed, 15 May 2013 09:32:37 -0500 mdroth wrote: > On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > > On Fri, 10 May 2013 17:45:59 -0500 > > Michael Roth wrote: > > > > > These patches apply on top of qemu.git master, and can also be obtained > > > from: > > > git://github.co

[Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction

2013-05-15 Thread Stefan Hajnoczi
The Abort action can be used to test QMP 'transaction' failure. Add it as the last action to exercise the .abort() and .cleanup() code paths for all previous actions. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 15 +++ qapi-schema.json | 11 ++- 2 files changed, 25

Re: [Qemu-devel] [PATCH for-1.5 2/2] osdep: introduce qemu_anon_ram_free to free qemu_anon_ram_alloc-ed memory

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 16:36, Markus Armbruster ha scritto: > This patch would break the build for me, if I didn't configure > --disable-werror. Using --enable-trace-backend=stderr in case it makes > a difference. Troublemaker flagged inline. Yes, it does---and it makes it a bit less urgent. Will fix to

Re: [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 16:34, Stefan Hajnoczi ha scritto: > The bdrv_add_before_write_cb() function installs a callback that is > invoked before a write request is processed. This will be used to > implement copy-on-write point-in-time snapshots where we need to copy > out old data before overwriting it.

[Qemu-devel] [PATCH v3 2/8] block: add basic backup support to block driver

2013-05-15 Thread Stefan Hajnoczi
From: Dietmar Maurer backup_start() creates a block job that copies a point-in-time snapshot of a block device to a target block device. We call backup_do_cow() for each write during backup. That function reads the original data from the block device before it gets overwritten. The data is then

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 16:28, Markus Armbruster ha scritto: > Sorry for the delay, I was off for a few days. > > Anthony Liguori writes: > >> Paolo Bonzini writes: >> >>> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. >>> While Markus's analysis is entirely correct, there are 1.6 patches

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

2013-05-15 Thread mdroth
On Wed, May 15, 2013 at 09:17:46AM -0400, Luiz Capitulino wrote: > On Fri, 10 May 2013 17:45:59 -0500 > Michael Roth wrote: > > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qapi-native-lists > > > > Sending this now sin

[Qemu-devel] [PATCH v3 3/8] block: add drive-backup QMP command

2013-05-15 Thread Stefan Hajnoczi
@drive-backup Start a point-in-time copy of a block device to a new destination. The status of ongoing drive-backup operations can be checked with query-block-jobs where the BlockJobInfo.type field has the value 'backup'. The operation can be stopped before it has completed using the block-job-ca

[Qemu-devel] [PATCH v3 0/8] block: drive-backup live backup command

2013-05-15 Thread Stefan Hajnoczi
Note: These patches apply to my block-next tree. You can also grab the code from git here: git://github.com/stefanha/qemu.git block-backup-core This series adds a new QMP command, drive-backup, which takes a point-in-time snapshot of a block device. The snapshot is copied out to a target block d

[Qemu-devel] [PATCH v3 5/8] blockdev: rename BlkTransactionStates to singular

2013-05-15 Thread Stefan Hajnoczi
The QMP 'transaction' command keeps a list of in-flight transactions. The transaction state structure is called BlkTransactionStates even though it only deals with a single transaction. The only plural thing is the linked list of transaction states. I find it confusing to call the single structur

[Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

2013-05-15 Thread Stefan Hajnoczi
The bdrv_add_before_write_cb() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time snapshots where we need to copy out old data before overwriting it. Signed-off-by: Stefan Hajnoczi --- block.c

[Qemu-devel] [PATCH v3 4/8] qemu-iotests: add 055 drive-backup test case

2013-05-15 Thread Stefan Hajnoczi
Testing drive-backup is similar to image streaming and drive mirroring. This test case is based on 041. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/055 | 230 + tests/qemu-iotests/055.out | 5 + tests/qemu-iotests/group | 1 + 3 fil

Re: [Qemu-devel] [PATCH for-1.5 2/2] osdep: introduce qemu_anon_ram_free to free qemu_anon_ram_alloc-ed memory

2013-05-15 Thread Markus Armbruster
This patch would break the build for me, if I didn't configure --disable-werror. Using --enable-trace-backend=stderr in case it makes a difference. Troublemaker flagged inline. Paolo Bonzini writes: > We switched from qemu_memalign to mmap() but then we don't modify > qemu_vfree() to do a munm

[Qemu-devel] [PATCH v3 6/8] blockdev: add DriveBackup transaction

2013-05-15 Thread Stefan Hajnoczi
This patch adds a transactional version of the drive-backup QMP command. It allows atomic snapshots of multiple drives along with automatic cleanup if there is a failure to start one of the backup jobs. Note that QMP events are emitted for block job completion/cancellation and the block job will b

[Qemu-devel] [PATCH v3 8/8] qemu-iotests: test 'drive-backup' transaction in 055

2013-05-15 Thread Stefan Hajnoczi
Ensure that the 'drive-backup' transaction works and check that a transaction abort works properly. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/055 | 118 + tests/qemu-iotests/055.out | 4 +- 2 files changed, 120 insertions(+), 2 deleti

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-15 Thread Markus Armbruster
Sorry for the delay, I was off for a few days. Anthony Liguori writes: > Paolo Bonzini writes: > >> This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. >> While Markus's analysis is entirely correct, there are 1.6 patches >> that fix the bug for real and without requiring machine type

Re: [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-15 Thread Brad Smith
On Tue, May 14, 2013 at 04:52:57PM -0500, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.4.2: > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > The release is planned for 05-24-2013: > > http://wiki.qemu.org/Planning/1.4 > > Pleas

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 15:24, Kevin Wolf ha scritto: > Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: >> Il 15/05/2013 15:00, Kevin Wolf ha scritto: >>> The test case passes on big endian hosts now (tested on ppc64) >>> >>> Signed-off-by: Kevin Wolf >> >> For 1.5? Do we need an extra -rc? > > An e

Re: [Qemu-devel] [RFC] save/restore with icount enabled.

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 15:35, KONRAD Frédéric ha scritto: > On 15/05/2013 14:50, Paolo Bonzini wrote: >> Il 15/05/2013 11:31, KONRAD Frédéric ha scritto: >>> Hi, >>> >>> We are trying to do a simple save/restore on the VM with icount enabled. >>> >>> We saw that qemu_icount_bias and qemu_icount in cpus.c ar

Re: [Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false

2013-05-15 Thread Laszlo Ersek
On 05/15/13 10:54, li guang wrote: > 在 2013-05-15三的 10:38 +0200,Paolo Bonzini写道: >> Il 15/05/2013 06:01, liguang ha scritto: >>> Signed-off-by: liguang >> >> --verbose, please. >> >> What problem does this patch fix? > > Oh, sorry to be lazy ... > QEMU's option '-no-acpi' seems does not play > a

Re: [Qemu-devel] [RFC] save/restore with icount enabled.

2013-05-15 Thread KONRAD Frédéric
On 15/05/2013 14:50, Paolo Bonzini wrote: Il 15/05/2013 11:31, KONRAD Frédéric ha scritto: Hi, We are trying to do a simple save/restore on the VM with icount enabled. We saw that qemu_icount_bias and qemu_icount in cpus.c are not saved/restored, and icount_extra, icount_decr in CPUState neith

[Qemu-devel] [PULL 1/2] qmp: fix handling of cmd with Equals in qmp-shell

2013-05-15 Thread Luiz Capitulino
From: Zhangleiqiang qmp: fix handling of cmd with equal mark in qmp-shell qmp-shell splits the argument and value of input command by equal mark("="). But there are commands whose values include equal mark themselves, and the json built by qmp-shell will not c

[Qemu-devel] [PULL for-1.5 0/2] QMP queue

2013-05-15 Thread Luiz Capitulino
These two fixes are not hugely important, but they are pretty isolated anyway. The changes (since 110db9b48c0a6379fca122801c3ae48e349aa6d4) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Michael Roth (1): qapi: fix leak in unit tests Zhangleiqi

[Qemu-devel] [PULL 2/2] qapi: fix leak in unit tests

2013-05-15 Thread Luiz Capitulino
From: Michael Roth qmp_output_get_qobject() increments the qobject's reference count. Since we currently pass this straight into qobject_to_json() so we can feed the data into a QMP input visitor, we never actually free the underlying qobject when qmp_output_visitor_cleanup() is called. This caus

Re: [Qemu-devel] [PATCH for-1.5 1/2] virtio-net: add virtio_net_set_netclient_name.

2013-05-15 Thread KONRAD Frédéric
On 15/05/2013 15:16, Stefan Hajnoczi wrote: On Wed, May 15, 2013 at 02:12:49PM +0200, fred.kon...@greensocs.com wrote: @@ -1315,8 +1338,17 @@ static int virtio_net_device_init(VirtIODevice *vdev) memcpy(&n->mac[0], &n->nic_conf.macaddr, sizeof(n->mac)); n->status = VIRTIO_NET_S_LINK_

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

2013-05-15 Thread Kevin Wolf
Am 15.05.2013 um 15:15 hat Paolo Bonzini geschrieben: > Il 15/05/2013 15:00, Kevin Wolf ha scritto: > > The test case passes on big endian hosts now (tested on ppc64) > > > > Signed-off-by: Kevin Wolf > > For 1.5? Do we need an extra -rc? An extra -rc for a test case fix on big endian hosts is

Re: [Qemu-devel] [PATCH v3 00/11] qapi: add support for lists of native types

2013-05-15 Thread Luiz Capitulino
On Fri, 10 May 2013 17:45:59 -0500 Michael Roth wrote: > These patches apply on top of qemu.git master, and can also be obtained from: > git://github.com/mdroth/qemu.git qapi-native-lists > > Sending this now since a number of series have popped up in the past that > wanted this, and Amos has so

Re: [Qemu-devel] [PATCH for-1.5 0/2] virtio-net: fix netclient id and type.

2013-05-15 Thread Stefan Hajnoczi
On Wed, May 15, 2013 at 02:12:48PM +0200, fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This fixes this bug: https://bugs.launchpad.net/qemu/+bug/1179357 > > The name, and the type is replaced by virtio-net-x's id and virtio-net-x's > type > to restore the behaviour of "info netw

Re: [Qemu-devel] [PATCH for-1.5 1/2] virtio-net: add virtio_net_set_netclient_name.

2013-05-15 Thread Stefan Hajnoczi
On Wed, May 15, 2013 at 02:12:49PM +0200, fred.kon...@greensocs.com wrote: > @@ -1315,8 +1338,17 @@ static int virtio_net_device_init(VirtIODevice *vdev) > memcpy(&n->mac[0], &n->nic_conf.macaddr, sizeof(n->mac)); > n->status = VIRTIO_NET_S_LINK_UP; > > -n->nic = qemu_new_nic(&net_v

Re: [Qemu-devel] [PATCH for-1.5?] ide-test: Fix endianness problems

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 15:00, Kevin Wolf ha scritto: > The test case passes on big endian hosts now (tested on ppc64) > > Signed-off-by: Kevin Wolf For 1.5? Do we need an extra -rc? Paolo

[Qemu-devel] [PATCH] ide-test: Fix endianness problems

2013-05-15 Thread Kevin Wolf
The test case passes on big endian hosts now (tested on ppc64) Signed-off-by: Kevin Wolf --- tests/ide-test.c | 32 +++- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index bdc1da7..365e995 100644 --- a/tests/ide-te

Re: [Qemu-devel] [RFC] save/restore with icount enabled.

2013-05-15 Thread Paolo Bonzini
Il 15/05/2013 11:31, KONRAD Frédéric ha scritto: > Hi, > > We are trying to do a simple save/restore on the VM with icount enabled. > > We saw that qemu_icount_bias and qemu_icount in cpus.c are not > saved/restored, > and icount_extra, icount_decr in CPUState neither, so the vm_clock is just > g

[Qemu-devel] Actual Physical Memory in Qemu !

2013-05-15 Thread Muhammad Nouman
Hi ! I am emulating mips64 linux on Qemu running on X86 machine.I want to see that which function in the Qemu writes any register value at any address in the memory of x86 machine? Which functions should i see? Thanks Nouman

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-15 Thread Luiz Capitulino
On Wed, 15 May 2013 10:10:37 +0800 Wenchao Xia wrote: > 于 2013-5-6 21:22, Luiz Capitulino 写道: > > On Mon, 06 May 2013 10:09:43 +0800 > > Wenchao Xia wrote: > > > >> 于 2013-5-3 10:51, Wenchao Xia 写道: > >>> 于 2013-5-2 20:02, Luiz Capitulino 写道: > On Thu, 02 May 2013 10:05:08 +0800 > Wenc

[Qemu-devel] [PATCH for-1.5 2/2] virtio-net-x: forward the netclient name and type.

2013-05-15 Thread fred . konrad
From: KONRAD Frederic This forwards the name and the type of virtio-net-x to fix the bad behaviour of "info network" command. Signed-off-by: KONRAD Frederic --- hw/s390x/s390-virtio-bus.c | 3 +++ hw/s390x/virtio-ccw.c | 3 +++ hw/virtio/virtio-pci.c | 3 +++ 3 files changed, 9 insert

  1   2   >