On 15 May 2013 16:48, Paolo Bonzini <pbonz...@redhat.com> wrote: > We're already using them in several places, but __sync builtins are just > too ugly to type, and do not provide seqcst load/store operations.
This doesn't compile: CC tests/test-thread-pool.o tests/test-thread-pool.c: In function ‘worker_cb’: tests/test-thread-pool.c:20:34: error: macro "atomic_inc" passed 2 arguments, but takes just 1 tests/test-thread-pool.c:20:12: error: ‘atomic_inc’ undeclared (first use in this function) tests/test-thread-pool.c:20:12: note: each undeclared identifier is reported only once for each function it appears in tests/test-thread-pool.c:19:21: error: unused variable ‘data’ [-Werror=unused-variable] tests/test-thread-pool.c: In function ‘long_cb’: tests/test-thread-pool.c:26:27: error: macro "atomic_inc" passed 2 arguments, but takes just 1 tests/test-thread-pool.c:26:5: error: ‘atomic_inc’ undeclared (first use in this function) tests/test-thread-pool.c:28:27: error: macro "atomic_inc" passed 2 arguments, but takes just 1 tests/test-thread-pool.c:25:21: error: unused variable ‘data’ [-Werror=unused-variable] tests/test-thread-pool.c: In function ‘worker_cb’: tests/test-thread-pool.c:21:1: error: control reaches end of non-void function [-Werror=return-type] cc1: all warnings being treated as errors thanks -- PMM