Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-27 Thread Nicholas A. Bellinger
On Wed, 2013-03-27 at 15:33 -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-03-27 at 23:56 +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 27, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: > > > On Wed, 2013-03-20 at 11:51 +0200, Michael S. Tsirkin wrote: > > > > On Tue, Mar 19, 2013 a

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 08:19 +0200, Michael S. Tsirkin wrote: > On Wed, Mar 27, 2013 at 04:24:22PM -0700, Nicholas A. Bellinger wrote: > > On Thu, 2013-03-28 at 00:53 +0200, Michael S. Tsirkin wrote: > > > On Thu, Mar 28, 2013 at 12:50:21AM +0200, Michael S. Tsirkin wrote: > > > > On Wed, Mar 27, 20

Re: [Qemu-devel] [patch]Make GTK build on OS X

2013-03-27 Thread Paolo Bonzini
> > Yes, I know. The point is that there's already an idiom to choose > > between pty.h/util.h/libutil.h, and we should not introduce > > another. > > Note that mingw has none of those headers, so double-check the _WIN32 > conditionals. Good catch. C.W., the right include file is include/sysem

Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-03-27 Thread Paolo Bonzini
> > Signed-off-by: Hans de Goede > > Cc: Alberto Garcia > > I don't think this is a show stopper, but this is a compatibility > breaker, no? > > We should be more up front about that and include release notes as > appropriate. Yes on all counts. I can work on the release notes. Paolo

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2013 at 04:24:22PM -0700, Nicholas A. Bellinger wrote: > On Thu, 2013-03-28 at 00:53 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 28, 2013 at 12:50:21AM +0200, Michael S. Tsirkin wrote: > > > On Wed, Mar 27, 2013 at 03:45:42PM -0700, Nicholas A. Bellinger wrote: > > > > On Thu,

[Qemu-devel] [PATCH v15.2 4/6] pvpanic: add document of pvpanic

2013-03-27 Thread Hu Tao
Signed-off-by: Hu Tao --- docs/specs/pvpanic.txt | 37 + 1 file changed, 37 insertions(+) create mode 100644 docs/specs/pvpanic.txt diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt new file mode 100644 index 000..6fe8bb6 --- /dev/null +++ b/do

Re: [Qemu-devel] [PATCH 4/5] qdev: add qdev_{create, free} tracepoints

2013-03-27 Thread Kazuya Saito
(2013/03/27 20:03), Andreas Färber wrote:> Am 22.03.2013 09:29, schrieb Kazuya Saito: >> This patch adds tracepoints at creating and removing virtual >> devices. It is useful for investigation of trouble related to virtual >> devices. >> >> Signed-off-by: Kazuya Saito > > I would prefer not to do

Re: [Qemu-devel] [PATCH 0/5] Add some tracepoints for clarification of the cause of troubles

2013-03-27 Thread Kazuya Saito
(2013/03/27 17:45), Paolo Bonzini wrote:> >>> Wouldn't you get the same information from the command line? >> >> I think the information you said is different from what I meant. The >> information I wanted to know is whether QEMU creates/deletes a device >> successfully or not. > > Failing to creat

Re: [Qemu-devel] [PATCH v9 05/24] hw/arm: add FTDDRII030 DDRII controller support

2013-03-27 Thread Kuo-Jung Su
2013/3/28 Peter Crosthwaite : > Hi Kuo Jung, > > On Thu, Mar 28, 2013 at 1:24 PM, Kuo-Jung Su wrote: >> 2013/3/28 Peter Crosthwaite : >>> Hi Kuo-Jung, >>> >>> On Mon, Mar 25, 2013 at 10:09 PM, Kuo-Jung Su wrote: From: Kuo-Jung Su The FTDDRII030 is a DDRII SDRAM controller which is

Re: [Qemu-devel] [PATCH v4] Add option to mlock qemu and guest memory

2013-03-27 Thread Satoru Moriya
> -Original Message- > From: Anthony Liguori [mailto:aligu...@us.ibm.com] > Sent: Wednesday, March 27, 2013 11:18 AM > To: Satoru Moriya; qemu-devel@nongnu.org > Cc: Jan Kiszka; mtosa...@redhat.com; Paolo Bonzini; Seiji Aguchi; Tomoki > Sekiyama; dle- > deve...@lists.sourceforge.net; sator

[Qemu-devel] 回复: dataplane bug: fail to start Windows VM with dataplane enable

2013-03-27 Thread leiqzhang
Hi, Stefan: Thank for your reply and patch. I have done the test for Windows 7, Windows 2003, and fedora. The patch has fixed the problem now, thanks. -- leiqzhang Sent by Sparrow (http://www.sparrowmailapp.com/?sig) 在 2013年3月27日星期三,23:41,Stefan Hajnoczi 写道: > On Tue, Mar 26,

Re: [Qemu-devel] [PATCH v9 05/24] hw/arm: add FTDDRII030 DDRII controller support

2013-03-27 Thread Peter Crosthwaite
Hi Kuo Jung, On Thu, Mar 28, 2013 at 1:24 PM, Kuo-Jung Su wrote: > 2013/3/28 Peter Crosthwaite : >> Hi Kuo-Jung, >> >> On Mon, Mar 25, 2013 at 10:09 PM, Kuo-Jung Su wrote: >>> From: Kuo-Jung Su >>> >>> The FTDDRII030 is a DDRII SDRAM controller which is responsible for >>> SDRAM initialization.

Re: [Qemu-devel] [PATCH v9 05/24] hw/arm: add FTDDRII030 DDRII controller support

2013-03-27 Thread Kuo-Jung Su
2013/3/28 Peter Crosthwaite : > Hi Kuo-Jung, > > On Mon, Mar 25, 2013 at 10:09 PM, Kuo-Jung Su wrote: >> From: Kuo-Jung Su >> >> The FTDDRII030 is a DDRII SDRAM controller which is responsible for >> SDRAM initialization. >> >> Signed-off-by: Kuo-Jung Su >> --- >> hw/arm/Makefile.objs|2

Re: [Qemu-devel] [PATCH 2/2] Monitor: Make output buffer dynamic

2013-03-27 Thread Wenchao Xia
于 2013-3-27 20:27, Luiz Capitulino 写道: On Wed, 27 Mar 2013 14:45:53 +0800 Wenchao Xia wrote: Hi, Luiz Personally I hope reduce the dynamic allocated buffer which brings fragments and unexpected memory grow. Instead, how about sacrifice some time to wait output complete, since monitor is not

Re: [Qemu-devel] [PATCH 03/12] tcg-s390: Remove useless preprocessor conditions

2013-03-27 Thread Richard Henderson
On 2013-03-27 17:14, Aurelien Jarno wrote: >+/* We only support generating code for 64-bit mode. */ >+#if TCG_TARGET_REG_BITS != 64 >+#error "unsupported code generation mode" >+#endif >+ I don't know when the s390 support has been removed, but it has not been removed from the configure script

Re: [Qemu-devel] [PATCH] vmxnet: Don't use bswap_64 for constants

2013-03-27 Thread Richard Henderson
On 2013-03-27 16:42, Andreas Färber wrote: Am 27.03.2013 19:47, schrieb Richard Henderson: This macro is used in the context of defining enum values. We can't use a function call in that case. Cc: qemu-triv...@nongnu.org Signed-off-by: Richard Henderson --- hw/vmxnet3.h | 10 +- 1 f

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Nicholas A. Bellinger
On Wed, 2013-03-27 at 16:24 -0700, Nicholas A. Bellinger wrote: > On Thu, 2013-03-28 at 00:53 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 28, 2013 at 12:50:21AM +0200, Michael S. Tsirkin wrote: > > > On Wed, Mar 27, 2013 at 03:45:42PM -0700, Nicholas A. Bellinger wrote: > > > > On Thu, 2013-03

Re: [Qemu-devel] [PATCH 03/12] tcg-s390: Remove useless preprocessor conditions

2013-03-27 Thread Aurelien Jarno
On Wed, Mar 27, 2013 at 11:52:24AM -0700, Richard Henderson wrote: > We only support 64-bit code generation for s390x. > Don't clutter the code with ifdefs that suggest otherwise. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 17 + > tcg/s390/tcg-target.h |

Re: [Qemu-devel] Connection breaks for macvtap

2013-03-27 Thread Anthony Liguori
Richa Marwaha writes: > Hi > > I am trying to run some KVM fuzz testing where I have a tool called scapy > running on my host and guest which changes the data in the IP header > of the FWIW, I don't think you'll gain a lot from this. QEMU does not ever look at a packet beyond the MAC address (a

Re: [Qemu-devel] [PATCH v9 05/24] hw/arm: add FTDDRII030 DDRII controller support

2013-03-27 Thread Peter Crosthwaite
Hi Kuo-Jung, On Mon, Mar 25, 2013 at 10:09 PM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The FTDDRII030 is a DDRII SDRAM controller which is responsible for > SDRAM initialization. > > Signed-off-by: Kuo-Jung Su > --- > hw/arm/Makefile.objs|2 +- > hw/arm/ftplat_a369soc.c |8 ++ >

[Qemu-devel] [PATCH 3/3] target-i386: add AES-NI instructions

2013-03-27 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-i386/cpu.c|6 +- target-i386/ops_sse.h| 188 ++ target-i386/ops_sse_header.h |6 ++ target-i386/translate.c |7 ++ 4 files changed, 204 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 1/3] target-i386: add pclmulqdq instruction

2013-03-27 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-i386/cpu.c| 19 +-- target-i386/ops_sse.h| 24 target-i386/ops_sse_header.h |5 + target-i386/translate.c |3 +++ 4 files changed, 41 insertions(+), 10 deletions(-) diff --g

[Qemu-devel] [PATCH 0/3] target-i386: add PCLMULQDQ and AES-NI instructions

2013-03-27 Thread Aurelien Jarno
This patch series adds the PCLMULQDQ and AES-NI instructions to the x86 emulation. Along with the SSE4.1 and SSE4.2 series, this brings the instructions emulation to the level of a Westmere CPU. It has been tested with the valgrind testsuite and with the kernel autotest. Aurelien Jarno (3): t

[Qemu-devel] [PATCH 2/3] target-i386: enable PCLMULQDQ on Westmere CPU

2013-03-27 Thread Aurelien Jarno
The PCLMULQDQ instruction has been introduced on the Westmere CPU. Signed-off-by: Aurelien Jarno --- target-i386/cpu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 41382c5..5941d40 100644 --- a/target-i386/cpu.c +++ b/target-i

[Qemu-devel] Connection breaks for macvtap

2013-03-27 Thread Richa Marwaha
Hi I am trying to run some KVM fuzz testing where I have a tool called scapy running on my host and guest which changes the data in the IP header of the packages and send it out to the host and vice versa. I have macvtap setup on my host (have tried both VEPA and Bridge mode). My ssh connection

Re: [Qemu-devel] [PATCH] vmxnet: Don't use bswap_64 for constants

2013-03-27 Thread Andreas Färber
Am 27.03.2013 19:47, schrieb Richard Henderson: > This macro is used in the context of defining enum values. > We can't use a function call in that case. > > Cc: qemu-triv...@nongnu.org > Signed-off-by: Richard Henderson > --- > hw/vmxnet3.h | 10 +- > 1 file changed, 9 insertions(+), 1

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 00:53 +0200, Michael S. Tsirkin wrote: > On Thu, Mar 28, 2013 at 12:50:21AM +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 27, 2013 at 03:45:42PM -0700, Nicholas A. Bellinger wrote: > > > On Thu, 2013-03-28 at 00:28 +0200, Michael S. Tsirkin wrote: > > > > On Wed, Mar 27, 20

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 00:50 +0200, Michael S. Tsirkin wrote: > On Wed, Mar 27, 2013 at 03:45:42PM -0700, Nicholas A. Bellinger wrote: > > On Thu, 2013-03-28 at 00:28 +0200, Michael S. Tsirkin wrote: > > > On Wed, Mar 27, 2013 at 09:59:45PM +, Nicholas A. Bellinger wrote: > > > > From: Paolo Bon

Re: [Qemu-devel] [PATCH 1/2] char: introduce a blocking version of qemu_chr_fe_write

2013-03-27 Thread Anthony Liguori
Peter Maydell writes: > On 27 March 2013 21:15, Anthony Liguori wrote: >> Applied. Thanks. > > Replied to wrong email by accident, or applied ignoring > the review comments? I interpreted your comment as a suggestion. I'm not a fan of while (true) loops so I left it as is. Since it's a prett

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Michael S. Tsirkin
On Thu, Mar 28, 2013 at 12:50:21AM +0200, Michael S. Tsirkin wrote: > On Wed, Mar 27, 2013 at 03:45:42PM -0700, Nicholas A. Bellinger wrote: > > On Thu, 2013-03-28 at 00:28 +0200, Michael S. Tsirkin wrote: > > > On Wed, Mar 27, 2013 at 09:59:45PM +, Nicholas A. Bellinger wrote: > > > > From: Pa

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2013 at 03:45:42PM -0700, Nicholas A. Bellinger wrote: > On Thu, 2013-03-28 at 00:28 +0200, Michael S. Tsirkin wrote: > > On Wed, Mar 27, 2013 at 09:59:45PM +, Nicholas A. Bellinger wrote: > > > From: Paolo Bonzini > > > > > > The WWPN specified in configfs is passed to "-devi

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Nicholas A. Bellinger
On Thu, 2013-03-28 at 00:28 +0200, Michael S. Tsirkin wrote: > On Wed, Mar 27, 2013 at 09:59:45PM +, Nicholas A. Bellinger wrote: > > From: Paolo Bonzini > > > > The WWPN specified in configfs is passed to "-device vhost-scsi-pci". > > The tgpt field of the SET_ENDPOINT ioctl is obsolete now,

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-27 Thread Nicholas A. Bellinger
On Wed, 2013-03-27 at 23:56 +0200, Michael S. Tsirkin wrote: > On Wed, Mar 27, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: > > On Wed, 2013-03-20 at 11:51 +0200, Michael S. Tsirkin wrote: > > > On Tue, Mar 19, 2013 at 06:57:08PM -0700, Nicholas A. Bellinger wrote: > > > > On Tue, 2013-03

Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2013 at 09:59:45PM +, Nicholas A. Bellinger wrote: > From: Paolo Bonzini > > The WWPN specified in configfs is passed to "-device vhost-scsi-pci". > The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not > available from the QEMU command-line. Instead, I hardc

Re: [Qemu-devel] [PATCH 0/3] Add support for vhost-scsi-pci

2013-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2013 at 09:59:43PM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi QEMU folks, > > The following is the patch series to support vhost-scsi-pci within the > upstream QEMU tree. > > This includes the refactoring of existing virtio-scsi code from Paolo > to al

Re: [Qemu-devel] [PATCH 3/3] vhost: Only call vhost_verify_ring_mappings when adding vhost memory

2013-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2013 at 09:59:46PM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch fixes a bug where vhost_verify_ring_mappings() could be > called after vhost_dev_unassign_memory() has been called during > vhost_set_memory(..., add=false). > Sorry, I NAK'd this al

[Qemu-devel] [PATCH 1/3] virtio-scsi: create VirtIOSCSICommon

2013-03-27 Thread Nicholas A. Bellinger
From: Paolo Bonzini This patch refactors existing virtio-scsi code into VirtIOSCSICommon in order to allow virtio_scsi_init_common() to be used by both internal virtio_scsi_init() and external vhost-scsi-pci code. Signed-off-by: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Asias He Signed-off-by:

[Qemu-devel] [PATCH 3/3] vhost: Only call vhost_verify_ring_mappings when adding vhost memory

2013-03-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a bug where vhost_verify_ring_mappings() could be called after vhost_dev_unassign_memory() has been called during vhost_set_memory(..., add=false). This appears to be fallout from when dev->started = true assignment occurs before vhost_set_memory(..., ad

[Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-27 Thread Nicholas A. Bellinger
From: Paolo Bonzini The WWPN specified in configfs is passed to "-device vhost-scsi-pci". The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not available from the QEMU command-line. Instead, I hardcode it to zero. Changes in V4: - Set event_idx=off by default (nab, thanks as

[Qemu-devel] [PATCH 0/3] Add support for vhost-scsi-pci

2013-03-27 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi QEMU folks, The following is the patch series to support vhost-scsi-pci within the upstream QEMU tree. This includes the refactoring of existing virtio-scsi code from Paolo to allow a VirtIOSCSICommon structure that is shared amoungst existing virtio-scsi-pci device

Re: [Qemu-devel] [PATCH 1/2] char: introduce a blocking version of qemu_chr_fe_write

2013-03-27 Thread Peter Maydell
On 27 March 2013 21:15, Anthony Liguori wrote: > Applied. Thanks. Replied to wrong email by accident, or applied ignoring the review comments? -- PMM

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2013 at 02:31:27PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-03-20 at 11:51 +0200, Michael S. Tsirkin wrote: > > On Tue, Mar 19, 2013 at 06:57:08PM -0700, Nicholas A. Bellinger wrote: > > > On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote: > > > > On Tue, Mar 19, 20

Re: [Qemu-devel] [PATCH] Fix some memory leaks in test-visitor-serialization

2013-03-27 Thread mdroth
On Tue, Mar 26, 2013 at 05:46:55PM -0400, Stefan Berger wrote: > This patch fixes some of the memory leaks in > test-visitor-serialization but not all of them. > > Signed-off-by: Stefan Berger > > --- > tests/test-visitor-serialization.c | 17 ++--- > 1 file changed, 14 insertions

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-27 Thread Nicholas A. Bellinger
On Wed, 2013-03-20 at 11:51 +0200, Michael S. Tsirkin wrote: > On Tue, Mar 19, 2013 at 06:57:08PM -0700, Nicholas A. Bellinger wrote: > > On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote: > > > On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: > > > > --- > > > > hw/vhost.c | 2 ++

Re: [Qemu-devel] [PATCH V10 05/17] block: add snapshot info query function bdrv_query_snapshot_info_list()

2013-03-27 Thread Eric Blake
On 03/22/2013 08:19 AM, Wenchao Xia wrote: > This patch adds function bdrv_query_snapshot_info_list(), which will > retrieve snapshot info of an image in qmp object format. The implementation > is based on the code moved from qemu-img.c with modification to fit more > for qmp based block layer AP

Re: [Qemu-devel] [PATCH v5 0/7] Migration: Remove copying of guest ram pages

2013-03-27 Thread Eric Blake
On 03/22/2013 08:47 AM, Orit Wasserman wrote: > In migration all data is copied to a static buffer in QEMUFile, > this hurts our network bandwidth and CPU usage especially with large guests. > We switched to iovec for storing different buffers to send (even a byte field > is > considered as a buff

Re: [Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-03-27 Thread Anthony Liguori
Hans de Goede writes: > Signed-off-by: Hans de Goede > Cc: Alberto Garcia I don't think this is a show stopper, but this is a compatibility breaker, no? We should be more up front about that and include release notes as appropriate. Signed-off-by: Anthony Liguori > --- > hw/ipoctal232.c |

Re: [Qemu-devel] [PATCH 0/11] chardev frontend open handling cleanup v2

2013-03-27 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/2] char: introduce a blocking version of qemu_chr_fe_write

2013-03-27 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] [PULL] virtio-ccw fix.

2013-03-27 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] compiler: fix warning with GCC 4.8.0

2013-03-27 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] virtio,pci,qom

2013-03-27 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH v2 03/10] ccid-card-passthru, dev-smartcard-reader: add debug environment variables

2013-03-27 Thread Alon Levy
Introduces a new utility function: parse_debug_env to avoid code duplication. This overrides whatever debug value is set on the corresponding devices from the command line, and is meant to ease the usage with any management stack. For libvirt you can set environment variables by extending the dom

[Qemu-devel] [PATCH v2 09/10] dev-smartcard-reader: empty implementation for Mechanical (fail correctly)

2013-03-27 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/usb/dev-smartcard-reader.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 7040e8d..689468b 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -1051,6 +1051,1

[Qemu-devel] [PATCH v2 10/10] libcacard/cac: change big switch functions to single return point

2013-03-27 Thread Alon Levy
Signed-off-by: Alon Levy --- libcacard/cac.c | 73 - 1 file changed, 52 insertions(+), 21 deletions(-) diff --git a/libcacard/cac.c b/libcacard/cac.c index 5864539..7a06b5a 100644 --- a/libcacard/cac.c +++ b/libcacard/cac.c @@ -40,41 +40,51

[Qemu-devel] [PATCH v2 07/10] libcacard/vreader: add debugging messages for apdu

2013-03-27 Thread Alon Levy
Using g_debug with log domain libcacard Signed-off-by: Alon Levy --- libcacard/cac.c | 7 - libcacard/cac.h | 8 ++ libcacard/vreader.c | 77 + 3 files changed, 85 insertions(+), 7 deletions(-) diff --git a/libcacard/cac.c b/

[Qemu-devel] [PATCH v2 06/10] dev-smartcard-reader: copy atr protocol to ccid parameters

2013-03-27 Thread Alon Levy
Adds todos. Signed-off-by: Alon Levy --- hw/usb/dev-smartcard-reader.c | 45 +++ 1 file changed, 45 insertions(+) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index bb96f02..7040e8d 100644 --- a/hw/usb/dev-smartcard-reader.c

[Qemu-devel] [PATCH v2 04/10] dev-smartcard-reader: define structs for CCID_Parameter internals

2013-03-27 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/usb/dev-smartcard-reader.c | 74 +++ 1 file changed, 47 insertions(+), 27 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 751bd04..014c0b1 100644 --- a/hw/usb/dev-smartcard-reade

[Qemu-devel] [PATCH v2 08/10] libcacard: move atr setting from macro to function

2013-03-27 Thread Alon Levy
Only because qemu's checkpatch complains about it. Signed-off-by: Alon Levy --- Makefile.objs | 1 + libcacard/vcard_emul_nss.c | 14 +++--- libcacard/vcardt.c | 40 libcacard/vcardt.h | 13 - libcacar

[Qemu-devel] [PATCH v2 05/10] dev-smartcard-reader: change default protocol to T=0

2013-03-27 Thread Alon Levy
We don't support T=1 so we shouldn't advertise it by default. Two independent changes: * Default ATR sets T=0. This gets overwritten by the client provided ATR later. * Class descriptor changes dwAdvertise dwProtocols. to 0x1 and dwProtocols.=0 per spec. Signed-off-by: Alon Levy --- h

[Qemu-devel] [PATCH v2 02/10] ccid-card-passthru: add atr check

2013-03-27 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/ccid-card-passthru.c | 59 + 1 file changed, 59 insertions(+) diff --git a/hw/ccid-card-passthru.c b/hw/ccid-card-passthru.c index 3566e55..111894f 100644 --- a/hw/ccid-card-passthru.c +++ b/hw/ccid-card-passthru.c @

[Qemu-devel] [PATCH v2 01/10] libcacard: change default ATR

2013-03-27 Thread Alon Levy
Signed-off-by: Alon Levy --- libcacard/vcardt.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h index 538bdde..3b9a619 100644 --- a/libcacard/vcardt.h +++ b/libcacard/vcardt.h @@ -26,9 +26,17 @@ typedef struct VCardEmulStru

[Qemu-devel] [PATCH v2 00/10] ccid and libcacard fixes for windows/mingw

2013-03-27 Thread Alon Levy
This series: 1. fixes windows guests to show the ccid device 2. changes libcacard to use glib 3. makes libcacard build under mingw 4. does some cleanups It contains a few patches already posted to the list (the two Jim Meyering patches) which were already acked. I'll make a pull request once thi

Re: [Qemu-devel] [PATCH] compiler: fix warning with GCC 4.8.0

2013-03-27 Thread Richard Henderson
On 03/27/2013 06:34 AM, Paolo Bonzini wrote: > GCC 4.8.0 introduces a new warning: > > block/qcow2-snapshot.c: In function 'qcow2_write_snapshots’: > block/qcow2-snapshot.c:252:18: error: typedef 'qemu_build_bug_on__253' > locally defined but not used [-Werror=unused-local-ty

Re: [Qemu-devel] [PATCH 10/10] target-i386: SSE4.2: use clz32/ctz32 instead of reinventing the wheel

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > Signed-off-by: Aurelien Jarno > --- > target-i386/fpu_helper.c |1 + > target-i386/ops_sse.h| 32 ++-- > 2 files changed, 3 insertions(+), 30 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 09/10] target-i386: enable SSE4.1 and SSE4.2 in TCG mode

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > Signed-off-by: Aurelien Jarno > --- > target-i386/cpu.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 08/10] target-i386: SSE4.2: fix pcmpXstrX instructions with "Masked(-)" polarity

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > valids can equals to -1 if the reg/mem string is empty. Change the > expression to have an empty xor mask in that case. > > Signed-off-by: Aurelien Jarno > --- > target-i386/ops_sse.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Revi

Re: [Qemu-devel] [PATCH 07/10] target-i386: SSE4.2: fix pcmpXstrX instructions in "Equal ordered" mode

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > The inner loop should only change the current bit of the result, instead > of the whole result. > > Signed-off-by: Aurelien Jarno > --- > target-i386/ops_sse.h |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Richard He

Re: [Qemu-devel] [PATCH 06/10] target-i386: SSE4.2: fix pcmpXstrX instructions in "Equal each" mode

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > pcmpXstrX instructions in "Equal each" mode force both invalid element > pair to true. It means (upper - MAX(valids, validd)) bits should be set > to 1, not (upper - MAX(valids, validd) + 1). > > Signed-off-by: Aurelien Jarno > --- > target-i386/op

Re: [Qemu-devel] [PATCH 05/10] target-i386: SSE4.2: fix pcmpXstrX instructions in "Ranges" mode

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > Fix the order of the of the comparisons to match the "Intel 64 and > IA-32 Architectures Software Developer's Manual". > > Signed-off-by: Aurelien Jarno > --- > target-i386/ops_sse.h |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) R

Re: [Qemu-devel] [PATCH 04/10] target-i386: SSE4.2: fix pcmpXstrm instructions

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > pcmpXstrm instructions returns their result in the XMM0 register and > not in the first operand. > > Signed-off-by: Aurelien Jarno > --- > target-i386/ops_sse.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by

Re: [Qemu-devel] [PATCH 03/10] target-i386: SSE4.2: fix pcmpXstri instructions

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > ffs1 returns the first bit set to one starting counting from the most > significant bit. > > pcmpXstri returns the most significant bit set to one, starting counting > from the least significant bit. > > Signed-off-by: Aurelien Jarno > --- > targe

Re: [Qemu-devel] [PATCH 02/10] target-i386: SSE4.2: fix pcmpgtq instruction

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > The "Intel 64 and IA-32 Architectures Software Developer's Manual" (at > least recent versions) clearly says that the comparison is signed. > > Signed-off-by: Aurelien Jarno > --- > target-i386/ops_sse.h |3 +-- > 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 01/10] target-i386: SSE4.1: fix pinsrb instruction

2013-03-27 Thread Richard Henderson
On 03/26/2013 12:01 PM, Aurelien Jarno wrote: > gen_op_mov_TN_reg() loads the value in cpu_T[0], so this temporary should > be used instead of cpu_tmp0. > > Signed-off-by: Aurelien Jarno > --- > target-i386/translate.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by:

[Qemu-devel] [PATCH 07/14] cpu: introduce CPUClass.resume() method

2013-03-27 Thread Igor Mammedov
... and call it if defined from CPUClass.realize() if CPU was hotplugged by default leave .resume() unset (i.e. NULL) and override it for softmmu in qemu_init_vcpu() if it's still unset. Signed-off-by: Igor Mammedov --- cpus.c| 15 --- include/qom/cpu.h | 2 ++ qom/cpu.

[Qemu-devel] [PATCH 06/14] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-03-27 Thread Igor Mammedov
... to synchronize CPU state to KVM * in addition link kvm-stub.o to *-user target and fix related compiling issues. Signed-off-by: Igor Mammedov --- Makefile.target | 6 ++ include/sysemu/kvm.h | 22 -- kvm-all.c| 1 + kvm-stub.c | 5 +

[Qemu-devel] [PATCH 05/14] cpu: Pass CPUState to *cpu_synchronize_post*()

2013-03-27 Thread Igor Mammedov
... so it could be called from without requiring cpu.h Signed-off-by: Igor Mammedov --- cpus.c | 4 ++-- include/sysemu/kvm.h | 12 ++-- kvm-all.c| 8 ++-- kvm-stub.c | 4 ++-- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/cpu

Re: [Qemu-devel] [patch]Make GTK build on OS X

2013-03-27 Thread Bob Breuer
On 3/27/2013 1:34 PM, Paolo Bonzini wrote: > > > - Messaggio originale - >> Da: "C.W. Betts" >> A: "Paolo Bonzini" >> Cc: qemu-devel@nongnu.org >> Inviato: Mercoledì, 27 marzo 2013 19:05:46 >> Oggetto: Re: [patch]Make GTK build on OS X >> >> >> On Mar 27, 2013, at 2:34 AM, Paolo Bonzini

Re: [Qemu-devel] [PATCH 05/12] target-i386: push hot-plugged VCPU state to KVM and unstop it

2013-03-27 Thread Igor Mammedov
On Wed, 27 Mar 2013 16:20:15 +0100 Paolo Bonzini wrote: > Il 27/03/2013 16:16, Igor Mammedov ha scritto: > > yep, I re-factored every *cpu_synchronize_post*() call, > > > > but considering an intention to call cpu_synchronize_post_init() from > > qom/cpu.c this patch won't work nice since it wil

Re: [Qemu-devel] [PATCH 09/12] tcg-s390: Use risbgz for andi

2013-03-27 Thread Richard Henderson
On 03/27/2013 12:03 PM, Paolo Bonzini wrote: > I wonder if PPC can use this too. Yep, though it's more complicated for ppc64. r~

[Qemu-devel] [PATCH 3/3] ipoctal232: Convert to use chardev properties directly

2013-03-27 Thread Hans de Goede
Signed-off-by: Hans de Goede Cc: Alberto Garcia --- hw/ipoctal232.c | 43 ++- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/hw/ipoctal232.c b/hw/ipoctal232.c index 345efae..685fee2 100644 --- a/hw/ipoctal232.c +++ b/hw/ipoctal232.c @@ -93

[Qemu-devel] [PATCH 2/3] qemu-char: Call fe_claim / fe_release when not using qdev chr properties

2013-03-27 Thread Hans de Goede
chardev-frontends need to explictly check, increase and decrement the avail_connections "property" of the chardev when they are not using a qdev-chardev-property for the chardev. This fixes things like: qemu-kvm -chardev stdio,id=foo -device isa-serial,chardev=foo \ -mon chardev=foo Working, wh

[Qemu-devel] [PATCH 1/3] qemu-char: Add qemu_chr_fe_claim / _release helper functions

2013-03-27 Thread Hans de Goede
Add qemu_chr_fe_claim / _release helper functions for properly dealing with avail_connections. Signed-off-by: Hans de Goede --- hw/qdev-properties-system.c | 5 ++--- include/char/char.h | 29 + qemu-char.c | 23 +++ 3 file

[Qemu-devel] [PATCH 0/3] chardev-frontends: Explicitly check, inc and dec avail_connections v2

2013-03-27 Thread Hans de Goede
Hi All, Here is v2 of my "chardev-frontends: Explicitly check, inc and dec avail_connections" patch, which now actuall is a patch series. Changes since v1: -Add qemu_chr_fe_claim / _release helper functions for the avail_connections manipulations -Drop the changes to hw/serial.c -Add a bonus pat

[Qemu-devel] [patch v3] Make GTK UI build on OS X

2013-03-27 Thread C.W. Betts
From 51326a5db7e774cfe405b8cbcac7fc748857faac Mon Sep 17 00:00:00 2001 From: "C.W. Betts" Date: Wed, 27 Mar 2013 13:19:07 -0600 Subject: [PATCH] Make the GTK UI build on OS X. Moved the terminal includes from qemu-char.c to qemu-common.h. Removed the terminal includes from gtk.c. Signed-off-by:

[Qemu-devel] [PATCH 03/12] tcg-s390: Remove useless preprocessor conditions

2013-03-27 Thread Richard Henderson
We only support 64-bit code generation for s390x. Don't clutter the code with ifdefs that suggest otherwise. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 17 + tcg/s390/tcg-target.h | 2 -- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/tcg/s390/

Re: [Qemu-devel] vNVRAM / blobstore design

2013-03-27 Thread Stefan Berger
On 03/27/2013 02:27 PM, Anthony Liguori wrote: Stefan Berger writes: On 03/27/2013 01:14 PM, Anthony Liguori wrote: Stefan Berger writes: What I struggle with is that we're calling this a "blobstore". Using BER to store "blobs" seems kind of pointless especially when we're talking about ex

Re: [Qemu-devel] [PATCH 09/12] tcg-s390: Use risbgz for andi

2013-03-27 Thread Paolo Bonzini
Il 27/03/2013 19:52, Richard Henderson ha scritto: > This is immediately usable by the tlb lookup code. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 58 > ++- > 1 file changed, 53 insertions(+), 5 deletions(-) > > diff --g

[Qemu-devel] [PATCH 07/12] tcg-s390: Implement deposit opcodes

2013-03-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 24 tcg/s390/tcg-target.h | 8 ++-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index dbe2fa6..673a568 100644 --- a/tcg/s390/tcg-target.c ++

[Qemu-devel] [PATCH 12/12] tcg-s390: Use all 20 bits of the offset in tcg_out_mem

2013-03-27 Thread Richard Henderson
This can save one insn, if the constant has any bits in 32-63 set, but no bits in 21-31 set. It never results in more insns. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/t

[Qemu-devel] [PATCH 10/12] tcg-s390: Cleanup argument shuffling fixme in softmmu code

2013-03-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 85 +++ 1 file changed, 38 insertions(+), 47 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 2bab245..43a0de8 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s3

[Qemu-devel] [PATCH 11/12] tcg-s390: Use load-address for addition

2013-03-27 Thread Richard Henderson
Since we're always in 64-bit mode, load address performs a full 64-bit add. Use that for 3-address addition, as well as for larger constant addends when we lack extended-immediates facility. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 113 +--

[Qemu-devel] [PATCH 09/12] tcg-s390: Use risbgz for andi

2013-03-27 Thread Richard Henderson
This is immediately usable by the tlb lookup code. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 58 ++- 1 file changed, 53 insertions(+), 5 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 203cbb5..2bab

[Qemu-devel] [PATCH 06/12] tcg-s390: Implement movcond opcodes

2013-03-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 41 +++-- tcg/s390/tcg-target.h | 4 ++-- 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 81e2f6a..dbe2fa6 100644 --- a/tcg/s390/tc

[Qemu-devel] [PATCH 05/12] tcg-s390: Implement mulu2_i64 opcode

2013-03-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 5 + tcg/s390/tcg-target.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index b007763..81e2f6a 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg-target.c @@

[Qemu-devel] [PATCH 08/12] tcg-s390: Remove constraint letters for and

2013-03-27 Thread Richard Henderson
Since we have a free temporary and can always just load the constant, we ought to do so, rather than spending the same effort constraining the const. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 149 +++--- 1 file changed, 32 insertions

[Qemu-devel] [PATCH 04/12] tcg-s390: Implement add2/sub2 opcodes

2013-03-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 38 ++ tcg/s390/tcg-target.h | 8 2 files changed, 42 insertions(+), 4 deletions(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index ba314b3..b007763 100644 --- a/tcg/s390/t

[Qemu-devel] [PATCH 02/12] tcg-s390: Properly allocate a stack frame.

2013-03-27 Thread Richard Henderson
Set TCG_TARGET_CALL_STACK_OFFSET properly for the abi. Allocate the standard TCG_STATIC_CALL_ARGS_SIZE. And while we're at it, allocate space for CPU_TEMP_BUF_NLONGS. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 20 ++-- tcg/s390/tcg-target.h | 2 +- 2 files ch

[Qemu-devel] [PATCH 01/12] tcg-s390: Fix movi

2013-03-27 Thread Richard Henderson
The code to load the high 64 bits assumed that the insn used to load the low 64 bits zero-extended. Enforce that. --- tcg/s390/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index e12a152..0132010 100644 --- a/tcg/s39

[Qemu-devel] [PATCH 00/12] tcg-s390 updates

2013-03-27 Thread Richard Henderson
The first patch here has been seen previously, fixing a bug in how constants are constructed. The second patch fixes how parameters beyond the first 5 are passed to functions. I'm not sure how this got missed during the initial creation of the port. :-P The remaining patches are improvements, e

  1   2   3   >