(2013/03/27 20:03), Andreas Färber wrote:> Am 22.03.2013 09:29, schrieb Kazuya Saito: >> This patch adds tracepoints at creating and removing virtual >> devices. It is useful for investigation of trouble related to virtual >> devices. >> >> Signed-off-by: Kazuya Saito <[email protected]> > > I would prefer not to do this. I had previously posted a patch to remove > qdev_free() in favor of using the QOM function object_unparent() > directly, which adding stuff to qdev_free() would interfere with. And > you should rather add a tracepoint to object_new() or better to > object_initialize() than into the legacy qdev_create() - which doesn't > cover qdev_try_create() btw. Either way, adding new tracepoints with the > legacy "qdev" in the name is ugly.
Just as I replied to Paolo, I won't add these tracepoints. Thank you for your good information. > Regards, > Andreas > > P.S. Your patches arrived in HTML format, please check your workflow. I checked and modified the setting. Did this mail arrive in plain-text? Kazuya
