Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2013-03-18 Thread li guang
在 2013-01-10四的 19:57 +0100,Vasilis Liaskovitis写道: > > > > > > IIRC q35 supports memory hotplug natively (picked up in some > > > discussion). Is that correct? > > > > > From previous discussion I also understand that q35 supports native > > hotplug. > > Sections 5.1 and 5.2 of the spec describ

[Qemu-devel] [PATCH v3] add a boot option to do strict boot

2013-03-18 Thread Amos Kong
Seabios already added a new device type to halt booting. Qemu can add "HALT" at the end of bootindex string, then seabios will halt booting after trying to boot from all selected devices. This patch added a new boot option to configure if boot from un-selected devices. This option only effects wh

Re: [Qemu-devel] [PATCH v2 0/2] block: fix BDRV_O_SNAPSHOT with protocols

2013-03-18 Thread Michael Tokarev
18.03.2013 20:58, Stefan Hajnoczi wrote: > Richard Jones reported that BDRV_O_SNAPSHOT does not work > with NBD: Heh. http://permalink.gmane.org/gmane.comp.emulators.qemu/148390 (nothing's wrong with the patchset, just saying ;) /mjt

Re: [Qemu-devel] [PATCH] pvevent: pvevent device driver

2013-03-18 Thread Hu Tao
On Fri, Mar 15, 2013 at 07:35:12PM +, Matthew Garrett wrote: > On Thu, 2013-03-14 at 16:51 +0800, Hu Tao wrote: > > > + { "MSFT0001", 0}, > > This seems wrong, and it looks like qemu agrees. Can you resubmit when > there's agreement on the name? My fault. The name should be "QEMU". I'll se

Re: [Qemu-devel] [PATCH] pvevent: pvevent device driver

2013-03-18 Thread Hu Tao
On Sun, Mar 17, 2013 at 07:12:09PM +, Blue Swirl wrote: > On Thu, Mar 14, 2013 at 8:51 AM, Hu Tao wrote: > > pvevent device is a qemu simulated device through which guest panic > > event is sent to host. > > > > ref: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg02293.html > > > >

Re: [Qemu-devel] [PATCH v8 05/24] hw/arm: add FTDDRII030 DDRII controller support

2013-03-18 Thread Kuo-Jung Su
2013/3/18 Peter Maydell : > On 18 March 2013 09:56, Kuo-Jung Su wrote: >> The FTDDRII030 is responsible for SDRAM initialization. >> Which means the DDRII SDRAM would not be stabilized until the >> SDRAM is correctly initialized. >> => >> In QEMU, the memory_region_add_subregion() is used to perfo

Re: [Qemu-devel] migrate cancel bug in latest qemu upstream

2013-03-18 Thread Amos Kong
On Mon, Mar 18, 2013 at 09:20:03PM +0800, Amos Kong wrote: > On Tue, Mar 12, 2013 at 10:58:54AM +0800, Amos Kong wrote: > > Hi quintela, I found a migrate bug in Autotest result, not sure if > > it's already known. > > > > | commit fa3889162ff724d09eb6b6bd06ba54769100a77f > > | Merge: 6e72a00 a496

[Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-18 Thread Alex Williamson
As QEMU gains PCI bridge and PCIe root port support, we won't always find the VGA device on the root bus. We therefore need to add support to find and enable a VGA device and the path to it through the VGA Enable support in the PCI bridge control register. Signed-off-by: Alex Williamson --- src

[Qemu-devel] [Bug 1087114] Re: assertion "QLIST_EMPTY(&bs->tracked_requests)" failed

2013-03-18 Thread Brad Smith
So this is still an issue with 1.4.x and/or master? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1087114 Title: assertion "QLIST_EMPTY(&bs->tracked_requests)" failed Status in QEMU: New Bug de

Re: [Qemu-devel] [PATCH] Fix TAGS creation

2013-03-18 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v10 00/11] virtio-blk refactoring.

2013-03-18 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Fix TAGS creation

2013-03-18 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v4] virtio: make virtio device's structures public.

2013-03-18 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Fix TAGS creation

2013-03-18 Thread David Gibson
On Fri, Mar 15, 2013 at 07:15:52AM +0100, Markus Armbruster wrote: > David Gibson writes: > > > Currently the Makefile creates TAGS for emacs with the command: > > find "$(SRC_PATH)" -name '*.[hc]' -print0 | xargs -0 etags > > That works only if xargs ends up invoking etags just once. If xar

[Qemu-devel] [PATCH V3 WIP 1/3] virtio-scsi: create VirtIOSCSICommon

2013-03-18 Thread Asias He
From: Paolo Bonzini Signed-off-by: Paolo Bonzini --- hw/virtio-scsi.c | 199 +-- hw/virtio-scsi.h | 127 include/qemu/osdep.h | 4 ++ 3 files changed, 180 insertions(+), 150 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH V3 WIP 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-18 Thread Asias He
From: Paolo Bonzini The WWPN specified in configfs is passed to "-device vhost-scsi-pci". The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not available from the QEMU command-line. Instead, I hardcode it to zero. Changes in V3: - Drop ioeventfd vhost_scsi_properties (asias,

[Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-18 Thread Asias He
--- hw/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vhost.c b/hw/vhost.c index 4d6aee3..0c52ec4 100644 --- a/hw/vhost.c +++ b/hw/vhost.c @@ -421,10 +421,12 @@ static void vhost_set_memory(MemoryListener *listener, return; } +#if 0 if (dev->started) {

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

2013-03-18 Thread David Gibson
On Mon, Mar 18, 2013 at 11:54:05AM +0100, Andreas Färber wrote: > Am 15.03.2013 13:27, schrieb Alexander Graf: > > > > On 14.03.2013, at 02:53, David Gibson wrote: > > > >> PAPR requires that the device tree's CPU nodes have several properties > >> with information about the L1 cache. We already

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

2013-03-18 Thread David Gibson
On Mon, Mar 18, 2013 at 12:10:12PM +0100, Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 16.03.2013 08:10, schrieb David Gibson: > > On Fri, Mar 15, 2013 at 01:27:09PM +0100, Alexander Graf wrote: > >> On 14.03.2013, at 02:53, David Gibson wrote: > >> > >>> PAPR re

Re: [Qemu-devel] [PATCH 0/2] Fix booting tcm_vhost + seabios

2013-03-18 Thread Asias He
On Mon, Mar 18, 2013 at 02:26:14PM -0700, Nicholas A. Bellinger wrote: > On Fri, 2013-03-15 at 09:45 +0800, Asias He wrote: > > Asias He (2): > > virtio-scsi: Set _DRIVER_OK flag before scsi target scanning > > virtio-scsi: Pack struct virtio_scsi_{req_cmd,resp_cmd} > > > > src/virtio-scsi.c

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-18 Thread li guang
在 2013-03-18一的 11:07 +,Peter Maydell写道: > On 13 March 2013 08:01, liguang wrote: > > By now, all devices of QEMU do not have much more > > power management consideration, for example, if > > system do suspend, it will call all registered notifiers, > > this was loosely required, and the code t

[Qemu-devel] [PATCH V3 WIP 0/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-03-18 Thread Asias He
This is on top of Paolo and Nick's work. Current status: Basically, tcm_vhost + seabios works now. We still have one more issue, vhost_verify_ring_mappings fails. The hotplug also works with the latest tcm_vhost.ko hotplug patch. Asias He (1): disable vhost_verify_ring_mappings check Paolo Bon

Re: [Qemu-devel] Is is a bug? (window scale)

2013-03-18 Thread Eric Blake
On 03/17/2013 10:34 PM, Peter Cheung wrote: > Hi All Is is a bug? (window scale) > I am running Fedora 18 64 bits. Sending a 1.8 megabyte email, with a question embedded in the attached image instead of in the plain-text portion of the email, is a waste of bandwidth and considered not very polit

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-18 Thread Michael R. Hines
On 03/18/2013 05:26 PM, Michael S. Tsirkin wrote: Probably but I haven't mentioned ballooning at all. memory overcommit != ballooning Sure, then setting ballooning aside for the moment, then let's just consider regular (unused) virtual memory. In this case, what's wrong with the destination

[Qemu-devel] [PATCH] linux-user: improve target_to_host_sock_type conversion for MIPS

2013-03-18 Thread Petar Jovanovic
From: Petar Jovanovic Previous implementation has failed to take into account different value of SOCK_NONBLOCK on target (MIPS) and host, and existence of SOCK_CLOEXEC. The same conversion has to be applied both for do_socket and do_socketpair, so the code has been isolated in a static inline fun

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-18 Thread Michael S. Tsirkin
On Mon, Mar 18, 2013 at 04:24:44PM -0400, Michael R. Hines wrote: > On 03/18/2013 06:40 AM, Michael S. Tsirkin wrote: > >I think there are two things here, API documentation and protocol > >documentation, protocol documentation still needs some more work. > >Also if what I understand from this docu

Re: [Qemu-devel] [PATCH 0/2] Fix booting tcm_vhost + seabios

2013-03-18 Thread Nicholas A. Bellinger
On Fri, 2013-03-15 at 09:45 +0800, Asias He wrote: > Asias He (2): > virtio-scsi: Set _DRIVER_OK flag before scsi target scanning > virtio-scsi: Pack struct virtio_scsi_{req_cmd,resp_cmd} > > src/virtio-scsi.c | 5 +++-- > src/virtio-scsi.h | 4 ++-- > 2 files changed, 5 insertions(+), 4 dele

Re: [Qemu-devel] [PATCH 7/7] pcie: Mangle types to match topology

2013-03-18 Thread Alex Williamson
On Sun, 2013-03-17 at 14:19 +0200, Michael S. Tsirkin wrote: > On Thu, Mar 14, 2013 at 04:01:35PM -0600, Alex Williamson wrote: > > Windows will fail to start drivers for devices with an Endpoint type > > PCIe capability attached to a Root Complex (code 10 - Device cannot > > start). The proper ty

Re: [Qemu-devel] [PATCH 01/15] pixman: add qemu_pixman_color()

2013-03-18 Thread Søren Sandmann
Gerd Hoffmann writes: > Helper function to map qemu colors (32bit integer + matching PixelFormat) > into pixman_color_t. Are qemu colors premultiplied? If not, this function should probably premultiply before returning the color. Søren

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions

2013-03-18 Thread Igor Mitsyanko
On Mar 19, 2013 12:21 AM, "Peter Maydell" wrote: > > On 18 March 2013 19:48, Igor Mitsyanko wrote: > >> On 03/18/2013 09:47 PM, Peter Maydell wrote: > >>> > >>> +VMSTATE_BUFFER_UNSAFE(last_active, GICState, 0, > >>> + GIC_MAXIRQ * NCPU * sizeof(uint16_t)), > >

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 09/10] check for QMP string and bypass nonblock() calls

2013-03-18 Thread Michael R. Hines
Comments inline... On 03/18/2013 04:47 AM, Paolo Bonzini wrote: int migrate_use_xbzrle(void); +void *migrate_use_rdma(QEMUFile *f); Perhaps you can add a new function to QEMUFile send_page? And if it returns -ENOTSUP, proceed with the normal is_dup_page + put_buffer. I wonder if that let

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

2013-03-18 Thread Michael R. Hines
Comments inline - tell me what you think... On 03/18/2013 05:09 AM, Paolo Bonzini wrote: +typedef struct QEMUFileRDMA +{ +void *rdma; This is an RDMAData *. Please avoid using void * as much as possible. Acknowledged - forgot to move this to rdma.c, so it doesn't have to be void anymor

[Qemu-devel] [PATCH] ui/cocoa.m: Fix compile failures introduced by recent console changes

2013-03-18 Thread Peter Maydell
Fix various compilation failures introduced by the recent console changes. Signed-off-by: Peter Maydell --- ui/cocoa.m | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 8e0eaa2..048cc97 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -403,6 +4

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 07/10] connection-establishment for RDMA

2013-03-18 Thread Michael R. Hines
Acknowledged. On 03/18/2013 04:56 AM, Paolo Bonzini wrote: In a "socket-like" abstraction, all of these steps except the initial listen are part of "accept". Please move them to qemu_rdma_migrate_accept (possibly renaming the existing qemu_rdma_migrate_accept to a different name). Similarly, p

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 04/10] iterators for getting the RAMBlocks

2013-03-18 Thread Michael R. Hines
Acnkowledged. On 03/18/2013 04:48 AM, Paolo Bonzini wrote: Il 18/03/2013 04:18, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" This introduces: 1. qemu_ram_foreach_block 2. qemu_ram_count_blocks Both used in communicating the RAMBlocks to each side for later memory registrat

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-18 Thread Michael R. Hines
On 03/18/2013 06:40 AM, Michael S. Tsirkin wrote: I think there are two things here, API documentation and protocol documentation, protocol documentation still needs some more work. Also if what I understand from this document is correct this breaks memory overcommit on destination which needs

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-18 Thread Peter Maydell
On 18 March 2013 20:05, Paolo Bonzini wrote: > Il 18/03/2013 19:17, Peter Maydell ha scritto: >>> > Shouldn't these containers also host the CPU device(s), rather than the >>> > boards? And create them according to the num-cpu property? If so, they >>> > would have to go in hw/arm. >> Yes, ideal

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions

2013-03-18 Thread Peter Maydell
On 18 March 2013 19:48, Igor Mitsyanko wrote: >> On 03/18/2013 09:47 PM, Peter Maydell wrote: >>> >>> +VMSTATE_BUFFER_UNSAFE(last_active, GICState, 0, >>> + GIC_MAXIRQ * NCPU * sizeof(uint16_t)), > I'm not sure about this one, do we have any guarantees that it

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-18 Thread Paolo Bonzini
Il 18/03/2013 19:17, Peter Maydell ha scritto: >> > Shouldn't these containers also host the CPU device(s), rather than the >> > boards? And create them according to the num-cpu property? If so, they >> > would have to go in hw/arm. > Yes, ideally they should have the CPU devices in them too. > R

[Qemu-devel] [PATCH v11 4/4] Add top level changes for moxie

2013-03-18 Thread Anthony Green
Signed-off-by: Anthony Green --- MAINTAINERS | 5 + arch_init.c | 2 ++ configure | 9 - cpu-exec.c| 2 ++ default-configs/moxie-softmmu.mak | 2 ++ qapi-schema.json | 6 +++--

[Qemu-devel] [PATCH v11 1/4] Add moxie target code

2013-03-18 Thread Anthony Green
Signed-off-by: Anthony Green --- target-moxie/Makefile.objs | 2 + target-moxie/cpu.c | 172 + target-moxie/cpu.h | 167 target-moxie/helper.c | 171 + target-moxie/helper.h | 9 + target-moxie/machine.c | 28 ++ target-moxie/machine.h

[Qemu-devel] [PATCH v11 2/4] Add moxie disassembler

2013-03-18 Thread Anthony Green
Signed-off-by: Anthony Green --- disas.c | 6 + disas/Makefile.objs | 1 + disas/moxie.c | 360 include/disas/bfd.h | 2 + 4 files changed, 369 insertions(+) create mode 100644 disas/moxie.c diff --git a/disas.c b/dis

[Qemu-devel] [PATCH v11 3/4] Add sample moxie system

2013-03-18 Thread Anthony Green
Signed-off-by: Anthony Green --- hw/moxie/Makefile.objs | 6 ++ hw/moxie/moxiesim.c| 174 + include/sysemu/arch_init.h | 1 + 3 files changed, 181 insertions(+) create mode 100644 hw/moxie/Makefile.objs create mode 100644 hw/moxie/mox

[Qemu-devel] [PATCH v11 0/4] Moxie CPU port

2013-03-18 Thread Anthony Green
This version of the patch addresses recent changes in the upstream qemu sources (where interrupt_request resides). Please consider applying this version of the patch. Thank you! AG Anthony Green (4): Add moxie target code Add moxie disassembler Add sample moxie system Add top level cha

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions

2013-03-18 Thread Igor Mitsyanko
On 03/18/2013 09:47 PM, Peter Maydell wrote: > >> Update the GIC save/restore to use vmstate rather than hand-rolled >> save/load functions. >> >> Signed-off-by: Peter Maydell >> --- >> hw/arm_gic_common.c | 109 --** >> - >> 1 file changed, 42 i

Re: [Qemu-devel] [PATCH v2 1/2] arm_gic: Fix sizes of state fields in preparation for vmstate support

2013-03-18 Thread Igor Mitsyanko
On 03/18/2013 09:47 PM, Peter Maydell wrote: > >> In preparation for switching to vmstate for migration support, fix >> the sizes of various GIC state fields. In particular, we replace all >> the bitfields (which VMState can't deal with) with straightforward >> uint8_t values which we do bit operat

Re: [Qemu-devel] [PATCH] Fix typos and misspellings

2013-03-18 Thread Stefan Weil
Am 18.03.2013 18:20, schrieb Peter Maydell: > Fix various typos and misspellings. The bulk of these were found with > codespell. > > Signed-off-by: Peter Maydell > --- > I noticed the PCI typo while reading the file so I figured I'd run codespell > on the tree while I was at it. (Oddly codespell d

[Qemu-devel] QEMU-kvm 1.0 build and python

2013-03-18 Thread Udayan Bapat
Hi all, I am trying to cross compile qemu-kvm for a custom platform and the environment does not contain python. Due to this, the configure is breaking. I found that there are a few .pl scripts that get fired during configure. Are they essential for core functionality? If not, is there any way to

[Qemu-devel] [PULL 00/12] target-lm32 queue

2013-03-18 Thread Michael Walle
Hi Anthony, Hi Blue, these are various bugfixes for the lm32 target. Please pull. The following changes since commit e531761d63b7f8fe6b6423fafb3616ebbff768aa: Merge remote-tracking branch 'kraxel/pixman.v8' into staging (2013-03-18 07:34:24 -0500) are available in the git repository at:

[Qemu-devel] [PATCH v2] net: increase buffer size to accommodate Jumbo frame pkts

2013-03-18 Thread sfeldma
From: Scott Feldman Socket buffer sizes were hard-coded to 4K for VDE and socket netdevs. Bump this up to 68K (ala tap netdev) to handle maximum GSO packet size (64k) plus plenty of room for the ethernet and virtio_net headers. Originally, ran into this limitation when using -netdev UDP sockets

[Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename

2013-03-18 Thread Kevin Wolf
In order to achieve this, the .bdrv_probe callbacks of all drivers must cope with this. The DMG driver is the only one that bases its decision on the filename and it needs to be changed. Signed-off-by: Kevin Wolf --- block/dmg.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-

[Qemu-devel] [PATCH 07/35] hw: move virtio devices to hw/ subdirectories

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 5 - hw/block/Makefile.objs | 2 ++ hw/{ => block}/dataplane/Makefile.objs | 0 hw/{ => block}/dataplane/hostmem.c | 0 hw/{ => block}/dataplane/hostmem.h | 0 hw/{ => block}/dataplane/ioq.c

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-18 Thread Corey Bryant
On 03/18/2013 01:46 PM, Stefan Berger wrote: On 03/18/2013 12:16 PM, Markus Armbruster wrote: Corey Bryant writes: Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59 + 2 files changed, 61 insertions(+)

Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf"

2013-03-18 Thread Michael Walle
Am Sonntag 10 März 2013, 14:47:57 schrieb Igor Mitsyanko: > VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state, > not for buffers allocated dynamically. Change to > VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right. > > Signed-off-by: Igor Mitsyanko > --- >

[Qemu-devel] [PATCH 24/35] hw: move input devices to hw/input/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak| 1 + hw/arm/Makefile.objs | 3 +-- hw/input/Makefile.objs | 4 hw/{ => input}/milkymist-softusb.c | 0 hw/{ => input}/pxa2xx_keypad.c | 0 hw/{ => input}/tsc210x.c | 0 hw/lm32/Makef

[Qemu-devel] [PATCH 32/35] hw: move other devices to hw/misc/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak | 4 default-configs/sparc-softmmu.mak | 1 + hw/arm/Makefile.objs | 11 +-- hw/lm32/Makefile.objs | 8 hw/misc/Makefile.objs | 19 +++ hw/{ => misc}/a9

[Qemu-devel] [Bug 1156632] [NEW] not receiving RESET event after system_reset command causes QMP connection to die

2013-03-18 Thread Bram Klein Gunnewiek
Public bug reported: I have written my own implementation to control machine running KVM instances with the QMP protocol. Its a pretty basic implementation that sends/receives in the same thread. This means that all of the events QEMU sents are received only when the application expects a reply fr

Re: [Qemu-devel] [PATCH 01/18] console: fix displaychangelisteners interface

2013-03-18 Thread Niel van der Westhuizen
On 12 March 2013 21:32, Gerd Hoffmann wrote: > diff --git a/ui/cocoa.m b/ui/cocoa.m > index ca42413..b1fb30e 100644 > --- a/ui/cocoa.m > +++ b/ui/cocoa.m > @@ -1030,6 +1034,14 @@ static void cocoa_cleanup(void) > g_free(dcl); > } > > +static const DisplayChangeListenerOps dcl_ops = { > +

Re: [Qemu-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-18 Thread George Dunlap
On 18/03/13 16:53, Alex Bligh wrote: Paolo, --On 18 March 2013 17:19:14 +0100 Paolo Bonzini wrote: I remembered this incorrectly, sorry. It's not from a previous run, it's from the beginning of this run. See http://wiki.qemu.org/Migration/Storage for more information. A VM has a disk backe

Re: [Qemu-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-18 Thread Paolo Bonzini
Il 18/03/2013 18:38, George Dunlap ha scritto: >>> >> This might be a difference between Xen and KVM. On Xen migration is >> made to a server in a paused state, and it's only unpaused when >> the migration to B is complete. There's a sort of extra handshake at >> the end. > > I think what you mean

[Qemu-devel] [PATCH 29/35] hw: move interrupt controllers to hw/intc/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak | 3 +++ default-configs/i386-softmmu.mak| 2 ++ default-configs/ppc-softmmu.mak | 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/ppcemb-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 2

[Qemu-devel] [PATCH v2 0/2] arm_gic: convert to vmstate

2013-03-18 Thread Peter Maydell
Convert the arm_gic save/load support from hand-coded save/load functions to use VMState. This seems like a good thing to do before we get to the point with KVM/ARM that we need to start supporting between-version migration... Changes v1->v2: * fix true/false mixup that stopped armv7m from bootin

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-18 Thread Peter Maydell
On 18 March 2013 18:16, Paolo Bonzini wrote: > Il 18/03/2013 19:11, Peter Maydell ha scritto: >> > So what is the better alternative? A new hw/container/? >> >> Maybe. Whatever it is, it should be a classification by kind >> of device, so we can consistently sort by kind of device >> and not part

[Qemu-devel] [PATCH 11/35] hw: move watchdogs to hw/watchdog, configure via default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/i386-softmmu.mak | 1 + default-configs/pci.mak| 1 + default-configs/x86_64-softmmu.mak | 1 + hw/i386/Makefile.objs | 1 - hw/watchdog/Makefile.objs | 3 ++- hw/{ => watchdog}/wdt_ib700.c | 0 6 files chan

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-18 Thread Paolo Bonzini
Il 18/03/2013 19:11, Peter Maydell ha scritto: > > So what is the better alternative? A new hw/container/? > > Maybe. Whatever it is, it should be a classification by kind > of device, so we can consistently sort by kind of device > and not part by kind of device and part by target architecture.

[Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions

2013-03-18 Thread Peter Maydell
Update the GIC save/restore to use vmstate rather than hand-rolled save/load functions. Signed-off-by: Peter Maydell --- hw/arm_gic_common.c | 109 --- 1 file changed, 42 insertions(+), 67 deletions(-) diff --git a/hw/arm_gic_common.c b/hw/arm_gi

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-18 Thread Peter Maydell
On 18 March 2013 18:04, Paolo Bonzini wrote: > Il 18/03/2013 18:38, Peter Maydell ha scritto: >> On 18 March 2013 17:34, Paolo Bonzini wrote: >>> > hw/{ => arm}/a15mpcore.c | 0 >>> > hw/{ => arm}/a9mpcore.c| 0 >>> > hw/{ => arm}/arm11mp

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-18 Thread Paolo Bonzini
Il 18/03/2013 18:38, Peter Maydell ha scritto: > On 18 March 2013 17:34, Paolo Bonzini wrote: >> > hw/{ => arm}/a15mpcore.c | 0 >> > hw/{ => arm}/a9mpcore.c| 0 >> > hw/{ => arm}/arm11mpcore.c | 0 > Still no. I

[Qemu-devel] [PATCH 34/35] MAINTAINERS: update for source code movement

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- MAINTAINERS | 170 +--- 1 file changed, 93 insertions(+), 77 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0ca7e1d..f8e25c5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -59,75 +59,90 @@ Alpha M

Re: [Qemu-devel] [PATCH 01/18] console: fix displaychangelisteners interface

2013-03-18 Thread Peter Maydell
On 12 March 2013 10:32, Gerd Hoffmann wrote: > +static const DisplayChangeListenerOps dcl_ops = { > +.dpy_name = "cocoa", > +.dpy_gfx_update = cocoa_update; > +.dpy_gfx_resize = cocoa_resize; > +.dpy_gfx_setdata = cocoa_setdata; > +.dpy_refresh = cocoa_refresh; > +};

[Qemu-devel] [PATCH 09/35] hw: make all of hw/usb/ configurable via default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 2 +- hw/usb/Makefile.objs| 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak index 2d53895..4b7

[Qemu-devel] [PATCH 23/35] hw: move timer devices to hw/timer/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak | 3 +++ default-configs/sparc-softmmu.mak | 1 + hw/arm/Makefile.objs | 14 ++ hw/cris/Makefile.objs | 1 - hw/lm32/Makefile.objs | 1 - hw/sh4/Makefile.objs | 2

Re: [Qemu-devel] [Bug 1155403] Re: virtio cdrom detected as hard disk

2013-03-18 Thread Markus Armbruster
Phillip Susi writes: > On 3/18/2013 11:17 AM, Paolo Bonzini wrote: >> if=virtio means virtio-blk, not virtio-something. > > Why do you say that? I would say that virtio means use > paravirtualized IO rather than emulating some real hardware. Whether > that ends up being done with virtio-blk, or

[Qemu-devel] [PATCH 10/35] hw: make all of hw/pci/ configurable via default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/i386-softmmu.mak | 1 + default-configs/ppc64-softmmu.mak | 2 ++ default-configs/x86_64-softmmu.mak | 1 + hw/i386/Makefile.objs | 2 +- hw/pci/Makefile.objs | 1 + hw/ppc/Makefile.objs | 2 +- 6 files c

[Qemu-devel] [Bug 1155677] Re: snapshot=on fails with non file-based storage

2013-03-18 Thread Stefan Hajnoczi
** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Stefan Hajnoczi (stefanha) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1155677 Title: sna

[Qemu-devel] [PATCH 31/35] hw: move NVRAM interfaces to hw/nvram/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/nvram/Makefile.objs | 1 + hw/{ => nvram}/spapr_nvram.c | 0 hw/ppc/Makefile.objs | 5 - 3 files changed, 1 insertion(+), 5 deletions(-) rename hw/{ => nvram}/spapr_nvram.c (100%) diff --git a/hw/nvram/Makefile.objs b/hw/nvram/Makefile.objs

[Qemu-devel] [Bug 1156632] Re: not receiving RESET event after system_reset command causes QMP connection to die

2013-03-18 Thread Bram Klein Gunnewiek
For what its worth, i'm using Ubuntu 12.10: kvm --version QEMU emulator version 1.2.0 (qemu-kvm-1.2.0+noroms-0ubuntu2.12.10.3, Debian), Copyright (c) 2003-2008 Fabrice Bellard -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

[Qemu-devel] [PATCH 26/35] hw: move PCI bridges to hw/pci/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/i386-softmmu.mak | 3 +++ default-configs/mips-softmmu.mak | 1 + default-configs/mips64-softmmu.mak | 1 + default-configs/mips64el-softmmu.mak | 1 + default-configs/mipsel-softmmu.mak | 1 + default-configs/ppc-softmmu

[Qemu-devel] [PATCH 33/35] arm: move remaining files to hw/arm/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/arm/Makefile.objs | 8 ++-- hw/{ => arm}/a15mpcore.c | 0 hw/{ => arm}/a9mpcore.c| 0 hw/{ => arm}/arm11mpcore.c | 0 hw/{ => arm}/strongarm.c | 0 5 files changed, 6 insertions(+), 2 deletions(-) rename hw/{ => arm}/a15mpcore.c (100%) renam

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-18 Thread Stefan Berger
On 03/18/2013 12:16 PM, Markus Armbruster wrote: Corey Bryant writes: Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59 + 2 files changed, 61 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/

[Qemu-devel] [PATCH 35/35] hw: move private headers to hw/ subdirectories.

2013-03-18 Thread Paolo Bonzini
Many headers are used only in a single directory. These can be kept in hw/. Signed-off-by: Paolo Bonzini --- hw/arm/collie.c | 2 +- hw/arm/strongarm.c| 2 +- hw/{ => arm}/strongarm.h | 0 hw/audio/adl

[Qemu-devel] [PATCH 25/35] hw: move SD/MMC devices to hw/sd/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/arm/Makefile.objs| 4 ++-- hw/lm32/Makefile.objs | 1 - hw/sd/Makefile.objs | 4 hw/{ => sd}/milkymist-memcard.c | 0 hw/{ => sd}/omap_mmc.c | 0 hw/{ => sd}/pxa2xx_mmci.c | 0 6 files changed, 6 insertions(

[Qemu-devel] [PATCH v2 1/2] arm_gic: Fix sizes of state fields in preparation for vmstate support

2013-03-18 Thread Peter Maydell
In preparation for switching to vmstate for migration support, fix the sizes of various GIC state fields. In particular, we replace all the bitfields (which VMState can't deal with) with straightforward uint8_t values which we do bit operations on. (The bitfields made more sense when NCPU was set d

Re: [Qemu-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-18 Thread Alex Bligh
George, --On 18 March 2013 17:38:54 + George Dunlap wrote: I think what you mean is that all the memory is handled by Xen and the toolstack, not by qemu. The qemu state is sent as the very last thing, after all of the memory, and therefore (you are arguing) that qemu is not started, and

[Qemu-devel] [PATCH 08/35] hw: make all of hw/ide/ configurable via default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak | 1 + default-configs/sh4-softmmu.mak | 1 + default-configs/sh4eb-softmmu.mak | 1 + hw/arm/Makefile.objs | 2 +- hw/ide/Makefile.objs | 2 ++ hw/sh4/Makefile.objs | 1 - 6 files changed,

[Qemu-devel] [PATCH 27/35] hw: move VFIO and ivshmem to hw/pci/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 10 -- hw/pci/Makefile.objs | 5 + hw/{ => pci}/ivshmem.c| 0 hw/{vfio_pci.c => pci/vfio.c} | 0 4 files changed, 5 insertions(+), 10 deletions(-) rename hw/{ => pci}/ivshmem.c (100%) rename hw/{vfi

[Qemu-devel] [PATCH 30/35] hw: move GPIO interfaces to hw/gpio/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/arm/Makefile.objs | 3 +-- hw/gpio/Makefile.objs | 3 +++ hw/{ => gpio}/omap_gpio.c | 0 hw/{ => gpio}/zaurus.c| 0 4 files changed, 4 insertions(+), 2 deletions(-) rename hw/{ => gpio}/omap_gpio.c (100%) rename hw/{ => gpio}/zaurus.c (100%) dif

[Qemu-devel] [PATCH 22/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/i386-softmmu.mak | 4 default-configs/x86_64-softmmu.mak | 4 hw/i386/Makefile.objs | 7 ++- hw/isa/Makefile.objs | 6 ++ hw/{ => isa}/debugexit.c | 0 hw/{ => isa}/lpc_ich9.c| 0

[Qemu-devel] [PATCH 28/35] hw: move DMA controllers to hw/dma/, configure with default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/sparc-softmmu.mak | 2 ++ hw/arm/Makefile.objs | 7 ++- hw/cris/Makefile.objs | 1 - hw/dma/Makefile.objs | 6 ++ hw/{ => dma}/etraxfs_dma.c| 0 hw/{ => dma}/omap_dma.c | 0 hw/{ => dm

[Qemu-devel] [PATCH 03/35] configure: fix TPM logic

2013-03-18 Thread Paolo Bonzini
A non-native i386 or x86_64 emulator should not have TPM passthrough support, since the TPM is only present for those hosts. Signed-off-by: Paolo Bonzini --- configure | 24 ++-- default-configs/i386-softmmu.mak | 3 +-- default-configs/x86_64-soft

[Qemu-devel] [PATCH 02/35] hw: make subdirectories for devices

2013-03-18 Thread Paolo Bonzini
Prepare the new directory structure. Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 33 ++--- hw/acpi/Makefile.objs | 0 hw/audio/Makefile.objs| 0 hw/block/Makefile.objs| 0 hw/bt/Makefile.objs | 0 hw/char/Makefile.objs | 0

[Qemu-devel] [PATCH] pl050: Don't send always-constant is_mouse field

2013-03-18 Thread Peter Maydell
The is_mouse field of the pl050 state structure is constant (it tracks whether this is a 'pl050_keyboard' or 'pl050_mouse'), so there's no need to include it in the VMState structure. Signed-off-by: Peter Maydell --- It doesn't hurt to carry around the is_mouse field, I guess, but I thought it ni

[Qemu-devel] [PATCH 21/35] hw: move char devices to hw/char/, configure via default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak| 1 + default-configs/i386-softmmu.mak | 1 + default-configs/lm32-softmmu.mak | 1 + default-configs/s390x-softmmu.mak | 1 + default-configs/sparc-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/arm

[Qemu-devel] [PATCH 04/35] tpm: reorganize headers and split hardware part

2013-03-18 Thread Paolo Bonzini
The TPM subsystem does not have a good front-end/back-end separation. However, we can at least try to split the user interface (tpm.c) from the implementation (hw/tpm). The patches makes tpm.c not include tpm_int.h; instead it moves more stuff to tpm_backend.h. Signed-off-by: Paolo Bonzini ---

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-18 Thread Peter Maydell
On 18 March 2013 17:34, Paolo Bonzini wrote: > hw/{ => arm}/a15mpcore.c | 0 > hw/{ => arm}/a9mpcore.c| 0 > hw/{ => arm}/arm11mpcore.c | 0 Still no. -- PMM

[Qemu-devel] [Bug 1155403] Re: virtio cdrom detected as hard disk

2013-03-18 Thread Paolo Bonzini
> The media argument seems a perfectly natural > way to select between the two. Then how do you distinguish between a virtio-scsi and a virtio-blk hard disk? These may even require changes to the guest, since one becomes /dev/vda and the other becomes /dev/sda. virtio-scsi will grow more and mor

[Qemu-devel] [PATCH 18/35] hw: move SSI controllers to hw/ssi/, configure via default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak | 1 + default-configs/microblaze-softmmu.mak | 1 + default-configs/microblazeel-softmmu.mak | 1 + hw/arm/Makefile.objs | 3 +-- hw/microblaze/Makefile.objs | 4 hw/ssi/Makefile.obj

[Qemu-devel] [PATCH 16/35] hw: move display devices to hw/display/, configure via default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak| 6 ++ default-configs/i386-softmmu.mak | 1 + default-configs/lm32-softmmu.mak | 1 + default-configs/sh4-softmmu.mak| 1 + default-configs/sh4eb-softmmu.mak | 1 + default-configs/sparc-softmmu.mak | 1 + d

[Qemu-devel] [PATCH 20/35] hw: move more files to hw/xen/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 + hw/i386/Makefile.objs | 3 --- hw/xen/Makefile.objs | 4 hw/{ => xen}/xen-host-pci-device.c | 0 hw/{ => xen}/xen_apic.c| 0 hw/{ => xen

[Qemu-devel] [PATCH 17/35] hw: move I2C controllers to hw/i2c/, configure via default-configs/

2013-03-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 5 ++--- hw/i2c/Makefile.objs| 3 +++ hw/{ => i2c}/bitbang_i2c.c | 0 hw/{ => i2c}/exynos4210_i2c.c | 0 hw/{ => i2c}/omap_i2c.c | 0 6 files changed, 6 insertions(

  1   2   3   >