Comments inline.......
On 03/18/2013 04:47 AM, Paolo Bonzini wrote:
int migrate_use_xbzrle(void);
+void *migrate_use_rdma(QEMUFile *f);
Perhaps you can add a new function to QEMUFile send_page? And if it
returns -ENOTSUP, proceed with the normal is_dup_page + put_buffer. I
wonder if that lets use remove migrate_use_rdma() completely.
That's great - I'll make the modification......
void process_incoming_migration(QEMUFile *f)
{
Coroutine *co = qemu_coroutine_create(process_incoming_migration_co);
- int fd = qemu_get_fd(f);
-
- assert(fd != -1);
- socket_set_nonblock(fd);
+ if(!migrate_use_rdma(f)) {
+ int fd = qemu_get_fd(f);
+ assert(fd != -1);
+ socket_set_nonblock(fd);
Is this because qemu_get_fd(f) returns -1 for RDMA? Then, you can
instead put socket_set_nonblock under an if(fd != -1).
Yes, I proposed doing that check (for -1) in a previous RFC,
but you told me to remove it and make a separate patch =)
Is it OK to keep it in this patch?
Otherwise looks good.
Thanks for taking the time =)
