Re: [Qemu-devel] [PATCH V4 00/13] add qmp/hmp interfaces for snapshot info

2013-01-20 Thread Wenchao Xia
于 2013-1-17 15:39, Wenchao Xia 写道: >This serial of patches does two things: merge some info code > in qemu-img, and add following interfaces: > 1) qmp: query-images > 2) qmp: query-snapshots > 3) hmp: show snapshot info on a single block device >These patches follows the rule that use qmp t

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-20 Thread Gerd Hoffmann
Hi, >> I can't see a difference between Landscape + Landscape (flipped). >> Likewise Portrait + Portrait (flipped). Is there any? > > I can't actually get the "(flipped)" modes (both portrait and landscape) > to work, I get an error message "Unable to save display settings". How > did you mana

[Qemu-devel] [PATCH][v3] linux-user: correct semctl() and shmctl()

2013-01-20 Thread Laurent Vivier
The parameter "union semun" of semctl() is not a value but a pointer to the value. Moreover, all fields of target_su must be swapped (if needed). The third argument of shmctl is a pointer. WITHOUT this patch: $ ipcs kernel not configured for shared memory qemu: uncaught target signal 11 (Segm

Re: [Qemu-devel] wrong argument to qemu_flush_queued_packets() in network frontends ?

2013-01-20 Thread Luigi Rizzo
... and upon closer inspection, the problem described below (frontend blocks the backend, then tries to drain the wrong queue causing a stall) occurs because the hub in the middle breaks the flow of events. In the configuration below ( -net nic -net tap,ifname=tap0,... ) we have e1000.0 <--> h

Re: [Qemu-devel] wrong argument to qemu_flush_queued_packets() in network frontends ?

2013-01-20 Thread Luigi Rizzo
small correction: On Sun, Jan 20, 2013 at 6:50 PM, Luigi Rizzo wrote: > While running qemu 1.3.0 with the following network-related flags: > > -net nic -net tap,ifname=tap0,script='' > > I encountered the same problem (should be common to several > frontends, e.g. e100, eepro100, virtio-

[Qemu-devel] [QEMU]Patch for QEMU errors

2013-01-20 Thread harryxiyou
Hi all, We programmed a block storage(HLFS) patch for QEMU. Therefore, when i patched this driver for QEMU, it happened to me some errors. Could anyone give me some suggestions, thanks in advance ;-) You can see this issue i described in details from http://code.google.com/p/cloudxy/issues/detail

Re: [Qemu-devel] [PATCH v4 2/3] net: split eth_mac_addr for better error handling

2013-01-20 Thread David Miller
From: ak...@redhat.com Date: Sun, 20 Jan 2013 10:43:08 +0800 > From: Stefan Hajnoczi > > When we set mac address, software mac address in system and hardware mac > address all need to be updated. Current eth_mac_addr() doesn't allow > callers to implement error handling nicely. > > This patch s

Re: [Qemu-devel] [RFC qom-cpu v2 0/2] target-sh4: SuperHCPU subclasses

2013-01-20 Thread Andreas Färber
Am 21.01.2013 04:28, schrieb Andreas Färber: > Hello, > > This series introduces SuperH CPU subclasses. > The first conversion to QOM patch had used a declarative approach reusing > sh4_def_t as SuperHCPUInfo. This approach now uses imperative instance_init > functions. To preserve -cpu ? output a

Re: [Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-20 Thread Andreas Färber
Am 17.01.2013 21:59, schrieb Eduardo Habkost: > Currently, the pc-1.4 machine init function enables PV EOI and then > calls the pc-1.2 machine init function. The problem with this approach > is that now we can't enable any additional compatibility code inside the > pc-1.2 init function because it w

[Qemu-devel] [RFC qom-cpu v2 2/2] target-sh4: Move PVR/PRR/CVR into SuperHCPUClass

2013-01-20 Thread Andreas Färber
They are never changed once initialized, and moving them to the class will allow to inspect them before instantiating. Signed-off-by: Andreas Färber --- hw/sh7750.c | 10 +++--- target-sh4/cpu-qom.h |6 ++ target-sh4/cpu.c | 18 +- target-sh4/cpu.h

[Qemu-devel] [RFC qom-cpu v2 1/2] target-sh4: Introduce SuperHCPU subclasses

2013-01-20 Thread Andreas Färber
Store legacy name in SuperHCPUClass for -cpu ? and for case-insensitive class lookup. List CPUs by iterating over TYPE_SUPERH_CPU subclasses. Signed-off-by: Andreas Färber --- target-sh4/cpu-qom.h |7 +++ target-sh4/cpu.c | 124 +++- targ

[Qemu-devel] [RFC qom-cpu v2 0/2] target-sh4: SuperHCPU subclasses

2013-01-20 Thread Andreas Färber
Hello, This series introduces SuperH CPU subclasses. The first conversion to QOM patch had used a declarative approach reusing sh4_def_t as SuperHCPUInfo. This approach now uses imperative instance_init functions. To preserve -cpu ? output and case-insensitivity, distinct name and type name are us

Re: [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2013-01-20 Thread li guang
在 2013-01-18五的 14:40 +0100,Igor Mammedov写道: > On Fri, 18 Jan 2013 15:12:36 +0800 > li guang wrote: > > > 在 2013-01-17四的 16:16 +0100,Igor Mammedov写道: > > > > > > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > > index ce914da..ab80dbe 100644 > > > --- a/target-i386/cpu.c > > > +++ b/t

Re: [Qemu-devel] [PATCH for-1.4 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-20 Thread li guang
在 2013-01-18五的 12:49 -0200,Eduardo Habkost写道: > On Fri, Jan 18, 2013 at 02:54:41PM +0800, li guang wrote: > > 在 2013-01-17四的 18:59 -0200,Eduardo Habkost写道: > > > I am hoping to get this bug fixed in 1.4. I didn't get much feedback on > > > the RFC > > > I sent last week, though. > > > > > > Igor

[Qemu-devel] wrong argument to qemu_flush_queued_packets() in network frontends ?

2013-01-20 Thread Luigi Rizzo
While running qemu 1.3.0 with the following network-related flags: -net nic -net tap,ifname=tap0,script='' I encountered the same problem (should be common to several frontends, e.g. e100, eepro100, virtio-net, xen_nic): in net/tap.c :: tap_send(), if qemu_send_packet_async() returns 0 (

Re: [Qemu-devel] [PATCH 16/18] hw: add QEMU model for Faraday RTCtimer

2013-01-20 Thread 蘇國榮
Sorry for the inconveniences, our e-mail server has a limitation on the rate of sending mails. It prevents the git-send-email to do that for me. I'll try to use gmail later when I get the QOM issues fixed. Best Regards Dante Su -Original Message- From: qemu-devel-bounces+dantesu=farada

Re: [Qemu-devel] [PATCH] target-arm: add Faraday ARMv5TE processors support

2013-01-20 Thread 蘇國榮
>> * ARMv5TE series (FA606TE, FA626TE, FA616TE, FA726TE) >> >> All the single core RISC listed above are included in this patch. >> And there are two Faraday CP15 extensions (AUX and I/D-Scratchpad) >> have been implemented as NOP. >Is a NOP appropriate? Should you at least read the

Re: [Qemu-devel] [PATCH 16/18] hw: add QEMU model for Faraday RTCtimer

2013-01-20 Thread 蘇國榮
Hi Konrad: Thanks for the information, I'm now studying the QOM. And when I finished the reading. I'll send out new patches later. Best Regards Dante Su -Original Message- From: qemu-devel-bounces+dantesu=faraday-tech@nongnu.org [mailto:qemu-devel-bounces+dantesu=faraday-tech@no

[Qemu-devel] [PATCH qom-cpu for-1.4 v2 2/2] target-i386: Drop redundant list of CPU definitions

2013-01-20 Thread Andreas Färber
It is no longer needed since dropping cpudef config file support. Cleaning this up removes knowledge about other models from x86_def_t, in preparation for reusing x86_def_t as intermediate step towards pure QOM X86CPU subclasses. Signed-off-by: Andreas Färber --- target-i386/cpu.c | 22 +++

[Qemu-devel] [PATCH qom-cpu for-1.4 v2 0/2] target-i386: x86_defs cleanup

2013-01-20 Thread Andreas Färber
Hello, Here's a revamped mini-series doing cleanups of x86_defs for v1.4 before we proceed with X86CPU subclasses for v1.5. v2 leaves the cpudef hooks in place and refactors only within functions. Intended to catch this week's qom-cpu pull if there are no more objections. Regards, Andreas v1 -

[Qemu-devel] [PATCH qom-cpu for-1.4 v2 1/2] target-i386: Simplify cpu_x86_find_by_name()

2013-01-20 Thread Andreas Färber
Catch NULL name argument early to avoid repeated checks. Similarly, check for -cpu host early and untangle from iterating through model definitions. Signed-off-by: Andreas Färber --- target-i386/cpu.c | 22 -- 1 Datei geändert, 12 Zeilen hinzugefügt(+), 10 Zeilen entfernt(-

[Qemu-devel] [PATCH v2 2/3] sheepdog: use inet_connect to simplify connect code

2013-01-20 Thread MORITA Kazutaka
This uses the form ":" for the representation of the sheepdog server to use inet_connect. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 112 +- 1 files changed, 35 insertions(+), 77 deletions(-) diff --git a/block/sheepdog.c b/block/s

[Qemu-devel] [PATCH v2 3/3] sheepdog: add support for connecting to unix domain socket

2013-01-20 Thread MORITA Kazutaka
This patch adds support for a unix domain socket for a connection between qemu and local sheepdog server. You can use the unix domain socket with the following syntax like NBD driver: $ qemu sheepdog:unix:: Note that must be an absolute path. Signed-off-by: MORITA Kazutaka --- block/sheepdo

[Qemu-devel] [PATCH v2 1/3] move socket_set_nodelay to osdep.c

2013-01-20 Thread MORITA Kazutaka
Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 11 +-- gdbstub.c |5 ++--- include/qemu/sockets.h |1 + qemu-char.c|6 -- slirp/tcp_subr.c |3 +-- util/osdep.c |6 ++ 6 files changed, 11 insertions(+), 21

[Qemu-devel] [PATCH v2 0/3] sheepdog: unix domain socket support

2013-01-20 Thread MORITA Kazutaka
This series adds support for a unix domain socket for a connection between qemu and local sheepdog server. The first two patches are cleanups for the third patch. Changes from v1: - split patch for easy review - move set_nodelay to lib/osdep.c - remove redundant error checks - add a bit more

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2013-01-20 Thread James Le Cuirot
I have just encountered this trying to emulate i386 on x86_64, which should dismiss any theories about ARM or MIPS. I've tried to apply the previous patch to QEMU 1.2.2 but it doesn't build. Currently trying to fix it. -- You received this bug notification because you are a member of qemu- devel-

Re: [Qemu-devel] [PATCH] linux-user: correct semctl() and shmctl()

2013-01-20 Thread Peter Maydell
On 20 January 2013 21:12, Laurent Vivier wrote: > case GETALL: > case SETALL: > -err = target_to_host_semarray(semid, &array, target_su.array); > +err = target_to_host_semarray(semid, &array, > + tswapal(target_su->ar

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

2013-01-20 Thread Vadim Evard
Thank you! By the way (sorry if this was discussed before and is a strong decision) I'd say e-mail based workflow is of course very flexible - and very very novice-unfriendly. Dash, I had to learn git commands I'd never use in my usual workflow with local or Github repos. And, well, I was not

[Qemu-devel] [PATCH] linux-user: correct semctl() and shmctl()

2013-01-20 Thread Laurent Vivier
The parameter "union semun" of semctl() is not a value but a pointer to the value. Moreover, all fields of target_su must be swapped (if needed). The third argument of shmctl is a pointer. WITHOUT this patch: $ ipcs kernel not configured for shared memory qemu: uncaught target signal 11 (Segm

Re: [Qemu-devel] [PULL 0/5] QMP queue

2013-01-20 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] virtio-pci: fix irqfd cleanup argument order

2013-01-20 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL for-1.4 0/8] Block patches

2013-01-20 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] bswap: improve gluing

2013-01-20 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Makefile: drop recursive libcacard clean

2013-01-20 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4] qom: Extend documentation on QOM method concepts

2013-01-20 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH] target-mips: Fix signedness of loads in MIPS16 RESTOREs

2013-01-20 Thread Richard Sandiford
Make RESTORE use sign-extending rather than zero-extending loads. Signed-off-by: Richard Sandiford --- target-mips/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 47528d7..623edd0 100644 --- a/target-mips/tra

[Qemu-devel] [PATCH] target-mips: Sign-extend the result of LWR

2013-01-20 Thread Richard Sandiford
Sign-extend the result of LWR, as is already done for LWL. This is necessary in the case where LWR loads the full word (i.e. the address is actually aligned). In the other cases, it is implementation defined whether the upper 32 bits of the result are unchanged or a copy of bit 31. The latter se

[Qemu-devel] [PATCH] target-mips: Fix accumulator selection for MIPS16 and microMIPS

2013-01-20 Thread Richard Sandiford
Add accumulator arguments to gen_HILO and gen_muldiv, rather than extracting the accumulator directly from ctx->opcode. The extraction was only right for the standard encoding: MIPS16 doesn't have access to the DSP registers, while microMIPS encodes the accumulator register in a different field (b

[Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

2013-01-20 Thread David Woodhouse
The PCI Firmware Specification apparently requires that the PCI Data Structure be DWORD-aligned. The implementation in OVMF also requires this, so vgabios ROMs don't work there. With this fixed, I can now initialise the VGA ROM from EFI, and EFI can display using INT 10h services. --- vgabios-0.6c

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-20 Thread Paul Brook
> I don't think there's much point adding tons of "XXX" comments > when a bunch of these aren't actually wrong code. If you want to fix > this I think a better approach would be more focused patches aimed > at adding 'break;' or "/* fallthrough */" based on actual human > examination of the surroun

Re: [Qemu-devel] [PATCH for-1.4?] isa: QOM'ify isa_bus_from_device()

2013-01-20 Thread Andreas Färber
Am 20.01.2013 18:56, schrieb Andreas Färber: > DeviceState::parent_bus is document as private and should be accessed "documented" - please fix when applying. > through qdev_get_parent_bus(). Use a DEVICE() cast instead of accessing > ISADevice's qdev field directly. Use ISA_BUS() in place of DO_U

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-20 Thread Peter Maydell
On 20 January 2013 17:38, Andreas Färber wrote: > Am 20.01.2013 18:26, schrieb Blue Swirl: >> On Sun, Jan 20, 2013 at 4:56 PM, Peter Maydell >> wrote: case 0x4c: /* TBR */ hw_error("TODO: Timer value read\n"); +/* XXX: questionable fallthrough */ >>> >>> This

[Qemu-devel] [PATCH for-1.4?] isa: QOM'ify isa_bus_from_device()

2013-01-20 Thread Andreas Färber
DeviceState::parent_bus is document as private and should be accessed through qdev_get_parent_bus(). Use a DEVICE() cast instead of accessing ISADevice's qdev field directly. Use ISA_BUS() in place of DO_UPCAST(). Signed-off-by: Andreas Färber Cc: Anthony Liguori --- hw/isa.h |2 +- 1 Datei

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-20 Thread Andreas Färber
Am 20.01.2013 18:26, schrieb Blue Swirl: > On Sun, Jan 20, 2013 at 4:56 PM, Peter Maydell > wrote: >> On 20 January 2013 15:54, Blue Swirl wrote: >> >> This patch is a bit big to usefully review. A few comments on bits >> I happened to notice: [...] >>> --- a/hw/stellaris.c >>> +++ b/hw/stellari

Re: [Qemu-devel] [PATCH 1/3] net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation

2013-01-20 Thread Andreas Färber
Am 19.01.2013 23:28, schrieb Grant Likely: > The etraxfs Ethernet model implements quite a nice bitbanging core. The > change splits it out into a separate .c file. There are no functional > changes here, just movement of code and reformatting to match qemu > coding standards. > > Cc: Peter Maydel

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-20 Thread Blue Swirl
On Sun, Jan 20, 2013 at 4:56 PM, Peter Maydell wrote: > On 20 January 2013 15:54, Blue Swirl wrote: > > This patch is a bit big to usefully review. A few comments on bits > I happened to notice: > >> diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c >> index a196fcc..2066ef3 100644 >> --- a/hw/arm_s

Re: [Qemu-devel] [PATCH 0/3] Generalize bitbang MDIO and use for versatile-pb

2013-01-20 Thread Andreas Färber
Am 19.01.2013 23:28, schrieb Grant Likely: > This series extracts the MDIO bitbang code from the etraxfs driver and > makes it usable on targets using the smc9 Ethernet controller. I've > tested this using u-boot on the versatile-pb model. > > net/bitbang_mdio: Generalize etraxfs MDIO bitbangi

Re: [Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-20 Thread Peter Maydell
On 20 January 2013 15:54, Blue Swirl wrote: This patch is a bit big to usefully review. A few comments on bits I happened to notice: > diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c > index a196fcc..2066ef3 100644 > --- a/hw/arm_sysctl.c > +++ b/hw/arm_sysctl.c > @@ -199,6 +199,7 @@ static void

Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

2013-01-20 Thread Alon Levy
On Thu, Jan 17, 2013 at 02:02:26PM +0100, Gerd Hoffmann wrote: > On 01/16/13 18:59, Alon Levy wrote: > > Regarding orientation setting in windows 7 64 guest: > > Desktop, right click->Screen resolution > > - You can choose Orientation: Landscape, Portrait, Landscape (flipped), > > Portrait (flipp

[Qemu-devel] [PATCH] Annotate questionable fallthroughs

2013-01-20 Thread Blue Swirl
Recent Clang compilers have preliminary support for finding unannotated fallthrough cases in switch statements with compiler flag -Wimplicit-fallthrough. The support is incomplete, it's only possible to annotate the case in C++ but not in C, so it wouldn't be useful to enable the flag for QEMU yet.

[Qemu-devel] [Bug 1102027] [NEW] QED Time travel

2013-01-20 Thread Mekza
Public bug reported: This night after a reboot of a VM, it was back to 8 Oct. 2012, i've lost all data between 8 Oct 2012 and now. I've check the QED file and mount on another VM, all seems OK. This QED has a raw backfile with the base OS (debian) shared with many others QED. It has NO snapshot.

Re: [Qemu-devel] [PULL 0/6] Block patches

2013-01-20 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 3/3] net/bitbang_mdio: Use bitbang core for smc91c111 network device

2013-01-20 Thread Peter Maydell
On 19 January 2013 22:28, Grant Likely wrote: > The smc91c111 device has bitbanged MDIO access, but the model doesn't > yet implement it. This patch uses the generalized bitbang MDIO support > pulled out of etraxfs Ethernet driver. > @@ -44,6 +45,13 @@ typedef struct { > uint8_t int_level; >

Re: [Qemu-devel] [PATCH][v2] linux-user: correct semctl() and shmctl()

2013-01-20 Thread Peter Maydell
On 2 January 2013 20:38, Laurent Vivier wrote: > The parameter "union semun" of semctl() is not a value > but a pointer to the value. > > Moreover, all fields of target_su must be swapped (if needed). > > The third argument of shmctl is a pointer. > > WITHOUT this patch: > > $ ipcs > > kernel not

[Qemu-devel] [PATCH for-1.4] *-user: Don't reset X86CPU again

2013-01-20 Thread Andreas Färber
Since commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c) the x86 CPU is reset through cpu_init() but was still reset immediately after in linux-user and bsd-user. Similarly it was reset again in linux-user after cpu_copy(), defeating its very p

[Qemu-devel] [RFC qom-cpu v3] target-ppc: Introduce unrealizefn for PowerPCCPU

2013-01-20 Thread Andreas Färber
Use it to clean up the opcode table, resolving a former TODO from Jocelyn. Also switch from malloc() to g_malloc(). Signed-off-by: Andreas Färber Cc: David Gibson Cc: Markus Armbruster --- Based on my "CPUState QOM realizefn support" series v2 (1.5 material). From "QOM'ify Power Architecture

Re: [Qemu-devel] [PATCH for 1.4 0/4] Simplify Makefile.objs some more

2013-01-20 Thread Paolo Bonzini
Il 20/01/2013 00:22, Andreas Färber ha scritto: > Am 19.01.2013 23:06, schrieb Paolo Bonzini: >> Il 19/01/2013 19:11, Andreas Färber ha scritto: > The patches are mostly mechanical substitutions, and there is no > user-visible change---neither in total build time, nor in the files that

[Qemu-devel] [RFC qom-cpu v2 03/28] target-arm: Update ARMCPU to QOM realizefn

2013-01-20 Thread Andreas Färber
Turn arm_cpu_realize() into a QOM realize function, no longer called via cpu.h prototype. To maintain the semantics of cpu_init(), set realized = true explicitly in cpu_arm_init(). Move GDB coprocessor registration, CPU reset and vCPU initialization into the realizefn. Signed-off-by: Andreas Färb

[Qemu-devel] [RFC qom-cpu v2 23/28] target-ppc: Move TCG initialization to PowerPCCPU initfn

2013-01-20 Thread Andreas Färber
Ensures that a QOM-created PowerPCCPU is usable. Signed-off-by: Andreas Färber --- target-ppc/translate_init.c |9 - 1 Datei geändert, 4 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 63ba4a5..786d871 100644 -

[Qemu-devel] [RFC qom-cpu v2 09/28] target-m68k: Introduce QOM realizefn for M68kCPU

2013-01-20 Thread Andreas Färber
Introduce realizefn and set realized = true in cpu_m68k_init(). Split off GDB registration to a new m68k_cpu_init_gdb() so that it can be called from the realizefn. Signed-off-by: Andreas Färber --- target-m68k/cpu-qom.h |2 ++ target-m68k/cpu.c | 17 + target-m68k/cpu

[Qemu-devel] [RFC qom-cpu v2 15/28] target-unicore32: Introduce QOM realizefn for UniCore32CPU

2013-01-20 Thread Andreas Färber
Introduce a realizefn and set realized = true in uc32_cpu_init(). Acked-by: Guan Xuetao [AF: Invoke the parent's realizefn] Signed-off-by: Andreas Färber --- target-unicore32/cpu-qom.h |3 +++ target-unicore32/cpu.c | 20 target-unicore32/helper.c |3 ++- 3 D

[Qemu-devel] [RFC qom-cpu v2 20/28] target-m68k: Move TCG initialization to M68kCPU initfn

2013-01-20 Thread Andreas Färber
Add a tcg_enabled() check to suppress it for qtest. Signed-off-by: Andreas Färber --- target-m68k/cpu.c|6 ++ target-m68k/helper.c |7 --- 2 Dateien geändert, 6 Zeilen hinzugefügt(+), 7 Zeilen entfernt(-) diff --git a/target-m68k/cpu.c b/target-m68k/cpu.c index f6720ca..bbea

[Qemu-devel] [RFC qom-cpu v2 22/28] target-mips: Move TCG initialization to MIPSCPU initfn

2013-01-20 Thread Andreas Färber
Make mips_tcg_init() non-static and add tcg_enabled() check to suppress it for qtest. Signed-off-by: Andreas Färber --- target-mips/cpu.c |4 target-mips/cpu.h |1 + target-mips/translate.c |3 +-- 3 Dateien geändert, 6 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) di

[Qemu-devel] [RFC qom-cpu v2 16/28] target-xtensa: Introduce QOM realizefn for XtensaCPU

2013-01-20 Thread Andreas Färber
Introduce realizefn and set realized = true in cpu_xtensa_init(). Signed-off-by: Andreas Färber --- target-xtensa/cpu-qom.h |2 ++ target-xtensa/cpu.c | 14 ++ target-xtensa/helper.c |4 +++- 3 Dateien geändert, 19 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git

[Qemu-devel] [RFC qom-cpu v2 12/28] target-s390x: Introduce QOM realizefn for S390CPU

2013-01-20 Thread Andreas Färber
Introduce realizefn and set realized = true in cpu_s390x_init(). Defer CPU reset from initfn to realizefn. Signed-off-by: Andreas Färber --- target-s390x/cpu-qom.h |2 ++ target-s390x/cpu.c | 17 +++-- target-s390x/helper.c |4 +++- 3 Dateien geändert, 20 Zeilen hinzu

[Qemu-devel] [RFC qom-cpu v2 08/28] target-lm32: Introduce QOM realizefn for LM32CPU

2013-01-20 Thread Andreas Färber
Introduce a realizefn and set realized = true in cpu_lm32_init(). Also move cpu_reset() call from initfn to realizefn. Signed-off-by: Andreas Färber --- target-lm32/cpu-qom.h |2 ++ target-lm32/cpu.c | 18 -- target-lm32/helper.c |4 ++-- 3 Dateien geändert, 20 Ze

[Qemu-devel] [RFC qom-cpu v2 24/28] target-s390x: Move TCG initialization to S390CPU initfn

2013-01-20 Thread Andreas Färber
Ensures that a QOM-created S390CPU is usable. Signed-off-by: Andreas Färber --- target-s390x/cpu.c|6 ++ target-s390x/helper.c |7 --- 2 Dateien geändert, 6 Zeilen hinzugefügt(+), 7 Zeilen entfernt(-) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index 60f71fc..109777

[Qemu-devel] [RFC qom-cpu v2 18/28] target-cris: Move TCG initialization to CRISCPU initfn

2013-01-20 Thread Andreas Färber
Split out TCG initialization from cpu_cris_init(). Avoid CPUCRISState dependency for v10-specific initialization and for non-v10 by inlining the decision into the initfn as well. Signed-off-by: Andreas Färber --- target-cris/cpu.c | 10 ++ target-cris/cpu.h |3 +

[Qemu-devel] [RFC qom-cpu v2 07/28] target-cris: Introduce QOM realizefn for CRISCPU

2013-01-20 Thread Andreas Färber
Introduce realizefn and set realized = true from cpu_cris_init(). Signed-off-by: Andreas Färber --- target-cris/cpu-qom.h |2 ++ target-cris/cpu.c | 15 +++ target-cris/translate.c |3 +-- 3 Dateien geändert, 18 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --gi

[Qemu-devel] [RFC qom-cpu v2 06/28] target-ppc: Update PowerPCCPU to QOM realizefn

2013-01-20 Thread Andreas Färber
Adapt ppc_cpu_realize() signature, hook it up to DeviceClass and set realized = true in cpu_ppc_init(). Signed-off-by: Andreas Färber --- target-ppc/cpu-qom.h|2 ++ target-ppc/translate_init.c | 12 +--- 2 Dateien geändert, 11 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) di

[Qemu-devel] [RFC qom-cpu v2 04/28] target-i386: Update X86CPU to QOM realizefn

2013-01-20 Thread Andreas Färber
Adapt the signature of x86_cpu_realize(), hook up to DeviceClass::realize and set realized = true in cpu_x86_init(). The QOM realizefn cannot depend on errp being non-NULL as in cpu_x86_init(), so use a local Error to preserve error handling behavior on APIC initialization errors. Signed-off-by: