On 20 January 2013 17:38, Andreas Färber <[email protected]> wrote: > Am 20.01.2013 18:26, schrieb Blue Swirl: >> On Sun, Jan 20, 2013 at 4:56 PM, Peter Maydell <[email protected]> >> wrote: >>>> case 0x4c: /* TBR */ >>>> hw_error("TODO: Timer value read\n"); >>>> + /* XXX: questionable fallthrough */ >>> >>> This isn't a fallthrough at all, hw_error() never returns. > > Maybe hw_error() needs some annotation instead?
It is already marked QEMU_NORETURN. Presumably whatever tool Blue is using doesn't pay attention to noreturn annotations. -- PMM
