From: Dunrong Huang
We check whether the variable machine is NULL or not before accessing
it. If machine is NULL, exit QEMU with an error, this can avoids a
segfault error.
Signed-off-by: Dunrong Huang
---
vl.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/v
Hi,
>> Maybe the guest driver places the qxl commands in native endian instead
>> of big endian into memory?
>
> The guest drivers places the commands in the memory in its native
> endianess. That why the device only works when guest/host has the same
> endianess. That's sanit-checks doesn't fa
i really would like to test with actual git. But my VMs run awfully SLOW
with actual git version. Boot process prints one line every two seconds.
So i can't test. Is there a patch or backport for this problem?
Thanks,
Stefan
Am 08.08.2012 18:17, schrieb Paolo Bonzini:
Il 08/08/2012 17:21, St
On 07/30/2012 05:35 PM, Supriya Kannery wrote:
> qcow2 driver changes for bdrv_reopen_xx functions to
> safely reopen image files. Reopening of image files while
> changing hostcache dynamically is handled here.
>
> Signed-off-by: Supriya Kannery
>
> ---
> Index: qemu/block/qcow2.c
> ===
On 07/30/2012 05:34 PM, Supriya Kannery wrote:
> For changing host pagecache setting of a running VM, it is
> important to have a safe way of reopening its image file.
>
> V1 introduced:
> * a generic way to reopen image files safely.
> In this approach, before reopening an image, for e
On 07/30/2012 05:34 PM, Supriya Kannery wrote:
> raw-posix driver changes for bdrv_reopen_xx functions to
> safely reopen image files. Reopening of image files while
> changing hostcache dynamically is handled here.
>
> Signed-off-by: Supriya Kannery
>
> ---
> Index: qemu/block/raw.c
>
On 07/30/2012 05:34 PM, Supriya Kannery wrote:
> Struct BDRVReopenState along with three reopen related functions
> introduced for handling reopening of images safely. This can be
> extended by each of the block drivers to reopen respective
> image files.
>
> Signed-off-by: Supriya Kannery
>
> -
Hi Blue,
> > You mean like what KVM does for shadow page table? I think we should
> > mprotect the QEMU virtual memory which is allocated as a guest page
> > table by the guest OS, right? If so, how do we know what (QEMU) virtual
> > memory we should protect? The other way I was thought of is to
Paolo,
On Mon, Aug 6, 2012 at 6:51 PM, Paolo Bonzini wrote:
> Il 06/08/2012 10:24, ronniesahlb...@gmail.com ha scritto:
>> diff --git a/block/iscsi.c b/block/iscsi.c
>> index 993a86d..243496b 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -896,23 +896,31 @@ static char *parse_initiat
The Buildbot has detected a new failure on builder block_mingw32 while building
qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/289
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: kraxel_rhel61
Build Reason: The
On Wed, 08 Aug 2012 17:18:33 -0400
Corey Bryant wrote:
>
>
> On 08/08/2012 05:13 PM, Luiz Capitulino wrote:
> > On Wed, 08 Aug 2012 16:52:41 -0400
> > Corey Bryant wrote:
> >
> >>
> >>
> >> On 08/08/2012 04:48 PM, Luiz Capitulino wrote:
> >>> On Wed, 08 Aug 2012 15:07:02 -0400
> >>> Corey Brya
On Wed, Aug 08, 2012 at 05:22:11PM +0200, Andreas Färber wrote:
> Am 08.08.2012 03:45, schrieb David Gibson:
> > On Wed, Aug 08, 2012 at 12:32:39AM +0200, Andreas Färber wrote:
> >> Am 08.08.2012 00:02, schrieb Benjamin Herrenschmidt:
> >>> On Fri, 2012-08-03 at 17:01 +0200, Andreas Färber wrote:
>
This fixes the following error:
$ qemu-system-xtensa -cpu help
Segmentation fault
Signed-off-by: Max Filippov
---
hw/xtensa_sim.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/xtensa_sim.c b/hw/xtensa_sim.c
index ed38bd4..831460b 100644
--- a/hw/xtensa_sim.
On 8 August 2012 23:40, Peter Maydell wrote:
> On 24 June 2012 00:07, Alexander Graf wrote:
>> Due to popular demand, we're updating the way we generate the MPIC
>> node and interrupt lines based on what the current state of art is.
>
> Any chance of a slightly more detailed commit message?
Whoo
On 24 June 2012 00:07, Alexander Graf wrote:
> Due to popular demand, we're updating the way we generate the MPIC
> node and interrupt lines based on what the current state of art is.
Any chance of a slightly more detailed commit message?
thanks
-- PMM
On 08/08/2012 04:16 PM, Alexander Graf wrote:
>
> On 24.06.2012, at 01:07, Alexander Graf wrote:
>
>> Due to popular demand, we're updating the way we generate the MPIC
>> node and interrupt lines based on what the current state of art is.
>>
>> Requested-by: Scott Wood
>> Signed-off-by: Alexand
On 08/08/2012 05:13 PM, Luiz Capitulino wrote:
On Wed, 08 Aug 2012 16:52:41 -0400
Corey Bryant wrote:
On 08/08/2012 04:48 PM, Luiz Capitulino wrote:
On Wed, 08 Aug 2012 15:07:02 -0400
Corey Bryant wrote:
On 08/07/2012 06:16 PM, Eric Blake wrote:
On 08/07/2012 11:07 AM, Corey Bryant
On 24.06.2012, at 01:07, Alexander Graf wrote:
> Due to popular demand, we're updating the way we generate the MPIC
> node and interrupt lines based on what the current state of art is.
>
> Requested-by: Scott Wood
> Signed-off-by: Alexander Graf
Hey Scott,
This patch breaks SMP for me. The
On 07/30/2012 05:34 PM, Supriya Kannery wrote:
> Struct BDRVReopenState along with three reopen related functions
> introduced for handling reopening of images safely. This can be
> extended by each of the block drivers to reopen respective
> image files.
>
> Signed-off-by: Supriya Kannery
>
> -
On Wed, 08 Aug 2012 16:52:41 -0400
Corey Bryant wrote:
>
>
> On 08/08/2012 04:48 PM, Luiz Capitulino wrote:
> > On Wed, 08 Aug 2012 15:07:02 -0400
> > Corey Bryant wrote:
> >
> >>
> >>
> >> On 08/07/2012 06:16 PM, Eric Blake wrote:
> >>> On 08/07/2012 11:07 AM, Corey Bryant wrote:
> >>>
>
On 08/08/2012 04:48 PM, Luiz Capitulino wrote:
On Wed, 08 Aug 2012 15:07:02 -0400
Corey Bryant wrote:
On 08/07/2012 06:16 PM, Eric Blake wrote:
On 08/07/2012 11:07 AM, Corey Bryant wrote:
+#
+# Since: 1.2.0
We're not very consistent on '1.2' vs. '1.2.0' in since listings, but
that's p
On Wed, 08 Aug 2012 15:07:02 -0400
Corey Bryant wrote:
>
>
> On 08/07/2012 06:16 PM, Eric Blake wrote:
> > On 08/07/2012 11:07 AM, Corey Bryant wrote:
> >
> +#
> +# Since: 1.2.0
> >>>
> >>> We're not very consistent on '1.2' vs. '1.2.0' in since listings, but
> >>> that's probably wor
Am 07.08.2012 18:20, schrieb Jason Baron:
> On Tue, Aug 07, 2012 at 06:13:25PM +0200, Andreas Färber wrote:
>> Hi Jason,
>>
>> Am 07.08.2012 18:01, schrieb Jason Baron:
>>> Hi,
>>>
>>> vmstate_ahci has its 'unmigratable' bit set. Gerd suggested that there was
>>> work
>>> in this area. Anybody kno
On Wed, Aug 8, 2012 at 7:34 PM, Peter Maydell wrote:
> On 8 August 2012 20:16, Blue Swirl wrote:
>> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck
>> wrote:
>>> On Tue, 7 Aug 2012 21:00:59 +
>>> Blue Swirl wrote:
Please use more descriptive names instead of acronyms, for example
On Wed, Aug 8, 2012 at 7:39 AM, Markus Armbruster wrote:
> Blue Swirl writes:
>
>> On Tue, Aug 7, 2012 at 7:26 PM, Markus Armbruster wrote:
>>> Very basic smoke test: start QEMU with -monitor stdio, quit immediately.
>>> Wouldn't it be nice if that worked for all targets and machine types?
>>>
>
On 8 August 2012 20:16, Blue Swirl wrote:
> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck
> wrote:
>> On Tue, 7 Aug 2012 21:00:59 +
>> Blue Swirl wrote:
>>> Please use more descriptive names instead of acronyms, for example
>>> SubChStatus.
>>
>> I'd rather leave these at the well-known sc
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote:
> From: Liu Ping Fan
>
> Flatview and radix view are all under the protection of pointer.
> And this make sure the change of them seem to be atomic!
>
> The mr accessed by radix-tree leaf or flatview will be reclaimed
> after the prev PhysMap no
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote:
> From: Liu Ping Fan
>
> PhysMap contain the flatview and radix-tree view, they are snapshot
> of system topology and should be consistent. With PhysMap, we can
> swap the pointer when updating and achieve the atomic.
>
> Signed-off-by: Liu Ping
On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote:
> From: Liu Ping Fan
>
> Using mem_map_lock to protect among updaters. So we can get the intact
> snapshot of mem topology -- FlatView & radix-tree.
>
> Signed-off-by: Liu Ping Fan
> ---
> exec.c |3 +++
> memory.c | 22 +++
On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck wrote:
> On Tue, 7 Aug 2012 21:00:59 +
> Blue Swirl wrote:
>
>
>> > diff --git a/hw/s390x/css.c b/hw/s390x/css.c
>> > new file mode 100644
>> > index 000..7941c44
>> > --- /dev/null
>> > +++ b/hw/s390x/css.c
>> > @@ -0,0 +1,440 @@
>> > +/*
>>
On Wed, Aug 8, 2012 at 8:33 AM, 陳韋任 (Wei-Ren Chen)
wrote:
> On Wed, Aug 08, 2012 at 09:05:18AM +0100, Peter Maydell wrote:
>> On 8 August 2012 08:38, 陳韋任 (Wei-Ren Chen) wrote:
>> > Just for research, we are studying if we can leave the guest page
>> > table walk to underlying hardware rather th
On 08/07/2012 06:16 PM, Eric Blake wrote:
On 08/07/2012 11:07 AM, Corey Bryant wrote:
+#
+# Since: 1.2.0
We're not very consistent on '1.2' vs. '1.2.0' in since listings, but
that's probably worth a global cleanup closer to hard freeze.
I'll make a note of it. Or does Luiz usually do a
On Wed, Aug 08, 2012 at 06:57:30PM +, Blue Swirl wrote:
> On Tue, Aug 7, 2012 at 7:56 PM, Eduardo Habkost wrote:
> > Changes v1 -> v2:
> > - Support 32-bit APIC IDs (in case x2APIC is going to be used)
> > - Coding style changes
> > - Use TARGET_I386_TOPOLOGY_H instead of __QEMU_X86_TOPOLOG
On Wed, Aug 8, 2012 at 8:28 AM, Cornelia Huck wrote:
> On Tue, 7 Aug 2012 20:47:22 +
> Blue Swirl wrote:
>
>
>> > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
>> > new file mode 100644
>> > index 000..8a90c3a
>> > --- /dev/null
>> > +++ b/hw/s390x/virtio-ccw.c
>> > @@ -0,0 +
On Wed, Aug 8, 2012 at 2:47 AM, Wen Congyang wrote:
> If the target is x86/x86_64, the guest's kernel will write 0x01 to the
> port KVM_PV_EVENT_PORT when it is panciked. This patch introduces a new
> qom device kvm_pv_ioport to listen this I/O port, and deal with panicked
> event according to pan
On Tue, Aug 7, 2012 at 7:56 PM, Eduardo Habkost wrote:
> Changes v1 -> v2:
> - Support 32-bit APIC IDs (in case x2APIC is going to be used)
> - Coding style changes
> - Use TARGET_I386_TOPOLOGY_H instead of __QEMU_X86_TOPOLOGY_H__
> - Rename topo_make_apic_id() to topo_apicid_for_cpu()
> - Re
On 08/08/2012 11:58 AM, Stefan Hajnoczi wrote:
On Wed, Aug 8, 2012 at 3:54 PM, Corey Bryant wrote:
On 08/08/2012 09:04 AM, Stefan Hajnoczi wrote:
On Tue, Aug 7, 2012 at 4:58 PM, Corey Bryant
wrote:
libvirt's sVirt security driver provides SELinux MAC isolation for
Qemu guest processes
On Mon, Aug 06, 2012 at 10:19:40AM -0300, Eduardo Otubo wrote:
> On Fri, Aug 03, 2012 at 03:54:40PM -0500, Anthony Liguori wrote:
> > Eduardo Otubo writes:
> >
> > > The new 'trap' (debug) mode will capture the illegal system call before
> > > it is
> > > executed. The feature and the implementa
While testing q35 live migration, I found that the migration would abort with
the following error: "Unknown savevm section type 76".
The error is due to this check failing in 'vmstate_load_state()':
while(field->name) {
if ((field->field_exists &&
field->field_exists(opaq
Il 08/08/2012 19:12, Stefan Priebe ha scritto:
> Yes cache none. Is there a bugfix for 1.1.1?
It's not fixed in 1.1.1, but it's fixed in git.
Paolo
>>> On 6/20/2012 at 08:05 AM, Gerd Hoffmann wrote:
> We update the QTAILQ in the loop, thus we must use the SAFE version
> to make sure we don't touch the queue struct after freeing it.
>
> https://bugzilla.novell.com/show_bug.cgi?id=766310
>
> Signed-off-by: Gerd Hoffmann
> ---
> hw/usb/hcd
Yes cache none. Is there a bugfix for 1.1.1?
Stefan
Am 08.08.2012 um 18:17 schrieb Paolo Bonzini :
> Il 08/08/2012 17:21, Stefan Priebe ha scritto:
>> Hello list,
>>
>> i wanted to start using virtio-scsi instead of virtio-blk, cause it
>> offers the possibility to use discard / trim support.
>
Which debian package do you mean? The fix is included is current debian
qemu-kvm 1.1.0+dfsg-3 release. qemu package in debian does not have
this fix however.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net
Am 31.01.2012 15:01, schrieb Mitsyanko Igor:
> On 01/31/2012 05:15 PM, Andreas Färber wrote:
>> Am 31.01.2012 00:53, schrieb Anthony Liguori:
>>> On 01/30/2012 05:41 PM, Andreas Färber wrote:
Am 30.01.2012 19:55, schrieb Juan Quintela:
> Please send in any agenda items you are interested i
Il 08/08/2012 17:21, Stefan Priebe ha scritto:
> Hello list,
>
> i wanted to start using virtio-scsi instead of virtio-blk, cause it
> offers the possibility to use discard / trim support.
>
> Kernel: 3.5.0 on host and guest
> Qemu-kvm: 1.1.1 stable
>
> But i'm not seeing the same or nearly the
On 08.08.2012 18:42, Michael Tokarev wrote:
> Should it go to qemu/stable-1.1 as well?
qemu/stable-1.1 also includes f63e60327b8e239ae97fa71060940ca20a8bf38e.
FWIW.
On Wed, Aug 8, 2012 at 3:54 PM, Corey Bryant wrote:
>
>
> On 08/08/2012 09:04 AM, Stefan Hajnoczi wrote:
>>
>> On Tue, Aug 7, 2012 at 4:58 PM, Corey Bryant
>> wrote:
>>>
>>> libvirt's sVirt security driver provides SELinux MAC isolation for
>>> Qemu guest processes and their corresponding image f
On 31 July 2012 19:18, Igor Mitsyanko wrote:
> On 07/31/2012 06:56 PM, Peter Maydell wrote:
>> On 27 July 2012 20:29, Igor Mitsyanko wrote:
>>>
>>> +VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0,
>>> wpgrps_size,
>>> +sizeof(unsigned long)),
>>
>>
>> Isn't this tr
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> +static void quorum_copy_qiov(QEMUIOVector *dest, QEMUIOVector *source)
> +{
> +int i;
> +for (i = 0; i < source->niov; i++) {
> +memcpy(dest->iov[i].iov_base,
> + source->iov[i].iov_base,
> + source-
On Wed, Aug 8, 2012 at 4:44 PM, Stefan Hajnoczi wrote:
> On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
>> @@ -224,6 +232,32 @@ static void quorum_aio_cb(void *opaque, int ret)
>> }
>> }
>>
>> +static BlockDriverAIOCB *quorum_aio_readv(BlockDriverState *bs,
>> +
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 35 +++
> 1 file changed, 35 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 2df3ae6..13804c1 100644
> --- a/block/quorum.c
> +++ b/
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/blkverify.c |8 ++--
> block/quorum.c|4
> 2 files changed, 10 insertions(+), 2 deletions(-)
Perhaps these should be in cutils.c with the other iovec functions.
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> +static int quorum_check_ret(QuorumAIOCB *acb)
> +{
> +int i, j;
> +
> +for (i = 0, j = 0; i <= 2; i++) {
> +if (acb->aios[0].ret) {
> +j++;
> +}
> +}
> +
> +if (j > 1) {
> +return -EIO;
> +
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 9da0432..5cd7083 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @
Reported as a bug at: https://bugs.launchpad.net/qemu/+bug/1034423
First observed with OpenSolaris 2009.06, and also applies to the latest
OpenIndiana release.
Version: qemu-kvm 1.1.1
Hardware:
2 x AMD Opteron 6128 8-core processors, 64GB RAM.
These guests boot on equivalent Intel hardware.
T
Am 08.08.2012 03:45, schrieb David Gibson:
> On Wed, Aug 08, 2012 at 12:32:39AM +0200, Andreas Färber wrote:
>> Am 08.08.2012 00:02, schrieb Benjamin Herrenschmidt:
>>> On Fri, 2012-08-03 at 17:01 +0200, Andreas Färber wrote:
I have posted a suggestion where CPU reset is triggered by "the
Hello list,
i wanted to start using virtio-scsi instead of virtio-blk, cause it
offers the possibility to use discard / trim support.
Kernel: 3.5.0 on host and guest
Qemu-kvm: 1.1.1 stable
But i'm not seeing the same or nearly the same speed:
virtio-scsi:
rand. 4k:
write: io=677628KB, bw=6
On Tue, Aug 7, 2012 at 9:30 PM, Blue Swirl wrote:
> On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet wrote:
>> +static void quorum_close(BlockDriverState *bs)
>> +{
>> +BDRVQuorumState *s = bs->opaque;
>> +int i;
>> +
>> +/* Ensure writes reach stable storage */
>> +for (i = 0; i <= 2
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet
> ---
> block/quorum.c | 62
>
> 1 file changed, 62 insertions(+)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index e0405b6..de58ab8 100644
> --- a
On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote:
> This patchset create a block driver implementing a quorum using three qemu
> disk
> images. Writes are mirrored on the three files.
> For the reading part the three files are read at the same time and a vote is
> done to determine which is the
On 08/08/2012 09:04 AM, Stefan Hajnoczi wrote:
On Tue, Aug 7, 2012 at 4:58 PM, Corey Bryant wrote:
libvirt's sVirt security driver provides SELinux MAC isolation for
Qemu guest processes and their corresponding image files. In other
words, sVirt uses SELinux to prevent a QEMU process from op
On Wed, Aug 8, 2012 at 2:54 PM, Corey Bryant wrote:
>
>
> On 08/08/2012 09:02 AM, Stefan Hajnoczi wrote:
>>
>> On Tue, Aug 07, 2012 at 11:58:28AM -0400, Corey Bryant wrote:
>>>
>>> @@ -2566,6 +2567,92 @@ FdsetInfoList *qmp_query_fdsets(Error **errp)
>>> return fdset_list;
>>> }
>>>
>>> +in
On 08.08.2012 17:09, Michael Tokarev wrote:
[]
> Something similar should be applied to 1.1-stable. FWIW, some
> changes are not needed there.
Cherry-pick to stable-1.1 removes the two unneeded hunks.
This is what I plan to include into debian package. It
fixes the original usb_del issue, and I
On Tue, Aug 7, 2012 at 9:01 AM, Bharata B Rao
wrote:
> block: Support GlusterFS as a QEMU block backend.
>
> From: Bharata B Rao
>
> This patch adds gluster as the new block backend in QEMU. This gives
> QEMU the ability to boot VM images from gluster volumes. Its already
> possible to boot from
[adding qemu-devel, for a qemu-ga question]
On 08/07/2012 06:04 PM, MATSUDA, Daiki wrote:
> Hi, All.
>
> I rewrote the patches as Eric suggested.
>
>
>
> virsh # help qemu-agent-command
> NAME
> qemu-agent-command - Qemu Guest Agent Command
>
> SYNOPSIS
> qemu-agent-command [--ti
On Wed, Aug 8, 2012 at 3:18 AM, Gerd Hoffmann wrote:
> Hi,
>
The only thing
its missing is to fix the endianess for server/client handshaking.
>>>
>>> What exactly do you mean here?
>>
>> Well that are negotiation messages configuring each channel, its
>> capabilities, encryption keys
On 08/08/2012 04:49 PM, Paolo Bonzini wrote:
> Il 08/08/2012 15:32, Peter Maydell ha scritto:
>>> > 1. GCC atomics look ugly, :) do not provide rmb/wmb, and in some
>>> > versions of GCC mb is known to be (wrongly) a no-op.
>>> >
>>> > 2. glib atomics do not provide mb/rmb/wmb either, and
>>> > g_a
On 08/08/2012 09:02 AM, Stefan Hajnoczi wrote:
On Tue, Aug 07, 2012 at 11:58:28AM -0400, Corey Bryant wrote:
@@ -2566,6 +2567,92 @@ FdsetInfoList *qmp_query_fdsets(Error **errp)
return fdset_list;
}
+int monitor_fdset_get_fd(int64_t fdset_id, int flags)
+{
+mon_fdset_t *mon_fdset;
Il 08/08/2012 15:32, Peter Maydell ha scritto:
>> > 1. GCC atomics look ugly, :) do not provide rmb/wmb, and in some
>> > versions of GCC mb is known to be (wrongly) a no-op.
>> >
>> > 2. glib atomics do not provide mb/rmb/wmb either, and
>> > g_atomic_int_get/g_atomic_int_set are inefficient: they
On 08/08/2012 04:52 AM, Stefan Hajnoczi wrote:
On Tue, Aug 7, 2012 at 8:59 PM, Corey Bryant wrote:
On 08/07/2012 02:16 PM, Stefan Hajnoczi wrote:
On Fri, Aug 3, 2012 at 6:28 PM, Corey Bryant
wrote:
+snprintf(fd_str, sizeof(fd_str), "%ld", fd);
+qerror_report(QERR_FD_NOT_FOUND, f
On 8 August 2012 14:18, Paolo Bonzini wrote:
> Il 08/08/2012 15:09, Stefan Hajnoczi ha scritto:
>> No need to roll our own or copy the implementation from the kernel.
>
> To some extent we need to because:
>
> 1. GCC atomics look ugly, :) do not provide rmb/wmb, and in some
> versions of GCC mb is
On Wed, 08 Aug 2012 14:35:23 +0200
Pavel Hrdina wrote:
> On 08/07/2012 05:53 PM, Luiz Capitulino wrote:
> > Add information about the new error format and improve the text a bit.
> >
> > Signed-off-by: Luiz Capitulino
> > ---
> > docs/writing-qmp-commands.txt | 47
> >
Il 08/08/2012 15:09, Stefan Hajnoczi ha scritto:
>> > NAK. We don't want random inline assembly implementations of locking
>> > primitives in QEMU, they are way too hard to keep working with all the
>> > possible host architectures we support. I spent some time a while back
>> > getting rid of the
On 08.08.2012 16:39, Paolo Bonzini wrote:
> Il 08/08/2012 14:22, Michael Tokarev ha scritto:
>> @@ -152,6 +152,16 @@ int qdev_init(DeviceState *dev)
>> +
>> +if (!OBJECT(dev)->parent) {
>> +static int unattached_count = 0;
>> +gchar *name = g_strdup_printf("device[%d]", unattach
On Wed, Aug 8, 2012 at 10:21 AM, Peter Maydell wrote:
> On 8 August 2012 07:25, Liu Ping Fan wrote:
>> +static inline void atomic_sub(int i, Atomic *v)
>> +{
>> +asm volatile("lock; subl %1,%0"
>> + : "+m" (v->counter)
>> + : "ir" (i));
>> +}
>
> NAK. We don't want ran
On Tue, Aug 7, 2012 at 4:58 PM, Corey Bryant wrote:
> libvirt's sVirt security driver provides SELinux MAC isolation for
> Qemu guest processes and their corresponding image files. In other
> words, sVirt uses SELinux to prevent a QEMU process from opening
> files that do not belong to it.
>
> sV
available in the git repository at:
http://repo.or.cz/r/qemu/quintela.git migration-next-20120808
for you to fetch changes up to dd051c7217eae04191169ac62f6ffb7531c8da32:
Restart optimization on stage3 update version (2012-08-08 13:51:12 +0200)
Juan Quintela (1):
Restart optimization
On Tue, Aug 07, 2012 at 11:58:28AM -0400, Corey Bryant wrote:
> @@ -2566,6 +2567,92 @@ FdsetInfoList *qmp_query_fdsets(Error **errp)
> return fdset_list;
> }
>
> +int monitor_fdset_get_fd(int64_t fdset_id, int flags)
> +{
> +mon_fdset_t *mon_fdset;
> +mon_fdset_fd_t *mon_fdset_fd;
>
Il 08/08/2012 14:48, Andreas Färber ha scritto:
> Adding object_unparent() to object_delete() looks okay to me, but we
> should not forget about the upcoming i440fx and prep_pci use cases where
> we want to embed children in the parent's struct, so that
> object_delete() will never be called on it.
Am 08.08.2012 14:39, schrieb Paolo Bonzini:
> Il 08/08/2012 14:22, Michael Tokarev ha scritto:
>> [...] should there be a call to object_unref()
>> somewhere?
>
> There should be a call to object_unparent() somewhere actually.
> We've been peppering the code with them for a few months now while
>
Il 08/08/2012 14:22, Michael Tokarev ha scritto:
> @@ -152,6 +152,16 @@ int qdev_init(DeviceState *dev)
> +
> +if (!OBJECT(dev)->parent) {
> +static int unattached_count = 0;
> +gchar *name = g_strdup_printf("device[%d]", unattached_count++);
> +
> +object_property_add_c
On 08/07/2012 05:53 PM, Luiz Capitulino wrote:
Add information about the new error format and improve the text a bit.
Signed-off-by: Luiz Capitulino
---
docs/writing-qmp-commands.txt | 47 +--
1 file changed, 27 insertions(+), 20 deletions(-)
diff --g
Ping?
patchwork url: http://patchwork.ozlabs.org/patch/173202/
-- PMM
On 25 July 2012 16:29, Peter Maydell wrote:
> Add asm-generic/kvm_para.h to the set of non-architecture specific
> KVM kernel headers we copy into QEMU. This header may be included
> by an architecture's kvm_para.h header.
>
On 08.08.2012 16:18, Michael Tokarev wrote:
> While dealing with USB issues today I noticed that
> usb_del monitor command is broken, attempting to
> delete any usb device immediately results in assertion
> failure:
>
> (qemu) usb_del 0.1
> ERROR:qom/object.c:408:object_delete: assertion failed: (
Markus Armbruster writes:
> Andreas Färber writes:
>
>> Am 07.08.2012 21:26, schrieb Markus Armbruster:
>>> Very basic smoke test: start QEMU with -monitor stdio, quit immediately.
>> [...]
>>> Summary of results:
>>>
>>> * Bad unexplained
>> [...]
>>> qemu-system-ppc64 prep
>>> qemu: h
While dealing with USB issues today I noticed that
usb_del monitor command is broken, attempting to
delete any usb device immediately results in assertion
failure:
(qemu) usb_del 0.1
ERROR:qom/object.c:408:object_delete: assertion failed: (obj->ref == 0)
Aborted
I bisected this issue to commit:
Max Filippov writes:
> This makes usable default for -cpu option both for qemu-system-xtensa
> and qemu-system-xtensaeb fixing the following error:
>
> $ qemu-system-xtensaeb -M sim
> Unable to find CPU definition
>
> Signed-off-by: Max Filippov
Tested-by: Markus Armbruster
The read-side critical sections in 9p-synth currently only include the
navigation of the list. This is incorrect; it works for two reasons,
first obviously because rcu_read_lock/unlock are still no-ops; second,
because elements of the list are never deleted from the list (only added).
In fact, onl
Even with the fix in the previous patch, the lockless handling of paths
in 9p-synth is wrong. Paths can outlive rcu_read_unlock arbitrarily
via the V9fsPath objects that 9p-synth creates. This would require
a reference counting mechanism that is not there and is quite hard to
retrofit into V9fsPa
There are several mistakes in the pseudo-RCU usage of 9pfs. This
patch series converts everything to a regular mutex. Patch 1 applies
enough fixes so that a trivial mutex-based synchronization is correct.
Patch 2 uses the mutex for both read and write sides.
Paolo Bonzini (2):
9p-synth: fix re
The bug also applies to Debian Qemu 1.1.0
Adding the changes of commit c52acf60b6c12ff5eb58eb6ac568c159ae0c8737 on
top of the 1.1.0 Debian package fixes the issue.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpa
ping
- Original Message -
> From: "Igor Mammedov"
> To: qemu-devel@nongnu.org
> Cc: "peter maydell" , aligu...@us.ibm.com,
> ehabk...@redhat.com, s...@weilnetz.de,
> mtosa...@redhat.com, ag...@suse.de, mdr...@linux.vnet.ibm.com,
> blauwir...@gmail.com, jcmvb...@gmail.com,
> a...@redhat.
This makes usable default for -cpu option both for qemu-system-xtensa
and qemu-system-xtensaeb fixing the following error:
$ qemu-system-xtensaeb -M sim
Unable to find CPU definition
Signed-off-by: Max Filippov
---
hw/xtensa_lx60.c|6 +++---
hw/xtensa_sim.c |4 ++--
targ
On 08/08/2012 12:52 PM, Paolo Bonzini wrote:
> Il 08/08/2012 08:25, Liu Ping Fan ha scritto:
>> +void qdev_unplug_complete(DeviceState *dev, Error **errp)
>> +{
>> +/* isolate from mem view */
>> +qdev_unmap(dev);
>> +qemu_lock_devtree();
>> +/* isolate from device tree */
>> +q
Ok. I tried to bisect this, but it appears to be not so easy. The
problem is that between 1.0 and 1.1, there's a lot of usb breakage, and
bisection leads to segfaults or assertion failures.
(qemu) usb_add host:003.002
usb_create: no bus specified, using "usb.0" for "usb-host"
(qemu) Segmentatio
Peter Maydell writes:
> On 8 August 2012 10:04, Markus Armbruster wrote:
>> Next problem: minimum RAM size.
>>
>> For instance, -M pc -m X, where X < 32KiB dies "qemu: fatal: Trying to
>> execute code outside RAM or ROM at [...] Aborted (core dumped)" with
>> TCG, and "KVM internal error. Suberr
Il 08/08/2012 08:25, Liu Ping Fan ha scritto:
>
> +static void
> +pci_e1000_unmap(PCIDevice *p)
> +{
> +/* DO NOT FREE anything!until refcnt=0 */
> +/* isolate from memory view */
> +}
At least you need to call the superclass method.
Paolo
> static int
> pci_e1000_uninit(PCIDevice *d
Il 08/08/2012 08:25, Liu Ping Fan ha scritto:
> +void qdev_unplug_complete(DeviceState *dev, Error **errp)
> +{
> +/* isolate from mem view */
> +qdev_unmap(dev);
> +qemu_lock_devtree();
> +/* isolate from device tree */
> +qdev_unset_parent(dev);
> +qemu_unlock_devtree();
>
On 08/08/2012 12:04 PM, Markus Armbruster wrote:
>>
>> Yes please, maybe with a notice to the user.
>
> Next problem: minimum RAM size.
>
> For instance, -M pc -m X, where X < 32KiB dies "qemu: fatal: Trying to
> execute code outside RAM or ROM at [...] Aborted (core dumped)" with
> TCG, and "KVM
On 08/08/2012 09:25 AM, Liu Ping Fan wrote:
> From: Liu Ping Fan
>
Please explain the motivation. AFAICT, the big qemu lock is sufficient.
--
error compiling committee.c: too many arguments to function
1 - 100 of 154 matches
Mail list logo
