Re: [Qemu-devel] [PATCH 16/16] hub: add the support for hub own flow control

2012-07-23 Thread Paolo Bonzini
Il 24/07/2012 00:27, Laszlo Ersek ha scritto: > This seems to consolidate net_hub_receive_iov()'s retval with that of > net_hub_receive(), but may I ask why it used to be calculated differently? Because until this patch was introduced, net/hub.c had a TODO about the return values of net_hub_receiv

Re: [Qemu-devel] [PATCH 21/22] Add XBZRLE statistics

2012-07-23 Thread Orit Wasserman
On 07/23/2012 10:33 PM, Luiz Capitulino wrote: > On Fri, 13 Jul 2012 09:23:43 +0200 > Juan Quintela wrote: > >> From: Orit Wasserman >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserman >> Signed-off-by: Juan Quin

Re: [Qemu-devel] [PATCH 13/22] Add migration capabilities

2012-07-23 Thread Orit Wasserman
On 07/23/2012 09:23 PM, Luiz Capitulino wrote: > On Fri, 13 Jul 2012 09:23:35 +0200 > Juan Quintela wrote: > >> From: Orit Wasserman >> >> Add migration capabilities that can be queried by the management. >> The management can query the source QEMU and the destination QEMU in order to >> verify

[Qemu-devel] [Bug 1028260] Re: ARM: stellaris lm3s6965evb machine model broken

2012-07-23 Thread Peter Crosthwaite
** Attachment added: "Test vector to replicate bug" https://bugs.launchpad.net/qemu/+bug/1028260/+attachment/3233691/+files/stellaris-test.tar -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1028260

Re: [Qemu-devel] [Bug 1028260] [NEW] ARM: stellaris lm3s6965evb machine model broken

2012-07-23 Thread Peter Crosthwaite
cc relevant maintainers (PMM and PB). On Tue, Jul 24, 2012 at 3:58 PM, Peter Crosthwaite wrote: > Public bug reported: > > The Stellaris lm3s6965evb Machine model is broken: > > qemu-system-arm -M lm3s6965evb -kernel qs_ek-lm3s6965.bin > GNU gdb (GDB) 7.1-ubuntu > Copyright (C) 2010 Free Software

[Qemu-devel] [Bug 1028260] [NEW] ARM: stellaris lm3s6965evb machine model broken

2012-07-23 Thread Peter Crosthwaite
Public bug reported: The Stellaris lm3s6965evb Machine model is broken: qemu-system-arm -M lm3s6965evb -kernel qs_ek-lm3s6965.bin GNU gdb (GDB) 7.1-ubuntu Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free s

Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2

2012-07-23 Thread Bharata B Rao
On Mon, Jul 23, 2012 at 08:34:30AM -0600, Eric Blake wrote: > On 07/23/2012 03:20 AM, Stefan Hajnoczi wrote: > >> > >> So without the capability to pass custom options to block drivers, am I > >> forced > >> to keep extending the file= with more and more options ? > >> > >> file=gluster:transport:

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-23 Thread Masami Hiramatsu
(2012/07/24 11:36), Yoshihiro YUNOMAE wrote: > Therefore, we propose a new system "virtio-trace", which uses enhanced > virtio-serial and existing ring-buffer of ftrace, for collecting guest kernel > tracing data. In this system, there are 5 main components: > (1) Ring-buffer of ftrace in a guest

[Qemu-devel] [RFC PATCH 5/6] virtio/console: Allocate scatterlist according to the current pipe size

2012-07-23 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Allocate scatterlist according to the current pipe size. This allows splicing bigger buffer if the pipe size has been changed by fcntl. Signed-off-by: Masami Hiramatsu Cc: Amit Shah Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- drivers/char/virtio_console.c | 23 +++

[Qemu-devel] [RFC PATCH 4/6] ftrace: Allow stealing pages from pipe buffer

2012-07-23 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Use generic steal operation on pipe buffer to allow stealing ring buffer's read page from pipe buffer. Note that this could reduce the performance of splice on the splice_write side operation without affinity setting. Since the ring buffer's read pages are allocated on the

[Qemu-devel] [RFC PATCH 6/6] tools: Add guest trace agent as a user tool

2012-07-23 Thread Yoshihiro YUNOMAE
This patch adds a user tool, "trace agent" for sending trace data of a guest to a Host in low overhead. This agent has the following functions: - splice a page of ring-buffer to read_pipe without memory copying - splice the page from write_pipe to virtio-console without memory copying - write tr

[Qemu-devel] [RFC PATCH 3/6] virtio/console: Wait until the port is ready on splice

2012-07-23 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Wait if the port is not connected or full on splice like as write is doing. Signed-off-by: Masami Hiramatsu Cc: Amit Shah Cc: Arnd Bergmann Cc: Greg Kroah-Hartman --- drivers/char/virtio_console.c | 39 +++ 1 files changed, 27 in

[Qemu-devel] [RFC PATCH 1/6] virtio/console: Add splice_write support

2012-07-23 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Enable to use splice_write from pipe to virtio-console port. This steals pages from pipe and directly send it to host. Note that this may accelerate only the guest to host path. Signed-off-by: Masami Hiramatsu Cc: Amit Shah Cc: Arnd Bergmann Cc: Greg Kroah-Hartman ---

[Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-07-23 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Add a failback memcpy path for unstealable pipe buffer. If buf->ops->steal() fails, virtio-serial tries to copy the page contents to an allocated page, instead of just failing splice(). Signed-off-by: Masami Hiramatsu Cc: Amit Shah Cc: Arnd Bergmann Cc: Greg Kroah-Hartm

[Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-23 Thread Yoshihiro YUNOMAE
Hi All, The following patch set provides a low-overhead system for collecting kernel tracing data of guests by a host in a virtualization environment. A guest OS generally shares some devices with other guests or a host, so reasons of any problems occurring in a guest may be from other guests or

Re: [Qemu-devel] [PATCH v5 1/6] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-07-23 Thread Corey Bryant
On 07/23/2012 06:50 PM, Eric Blake wrote: On 07/23/2012 07:08 AM, Corey Bryant wrote: Set the close-on-exec flag for the file descriptor received via SCM_RIGHTS. +++ b/qemu-char.c @@ -2263,9 +2263,17 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char *buf, size_t len) msg.msg

[Qemu-devel] [PATCH 2/2] vhost-scsi: Add support for VHOST_SCSI_GET_ABI_VERSION ioctl

2012-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support in vhost-scsi QEMU userspace code to check the running tcm_vhost ABI version using VHOST_SCSI_GET_ABI_VERSION. This series selects VHOST_SCSI_ABI_VERSION=1 for current code, and requires the pre-requsite tcm_vhost patch to expose an ABI version nu

[Qemu-devel] [PATCH 1/2] vhost-scsi: Rename vhost_vring_target -> vhost_scsi_target

2012-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Rename the main IOCTL structure to vhost_scsi_target so that it makes a little more sense than vhost_vring_target. As requested by MST. Reported-by: Michael S. Tsirkin Cc: Stefan Hajnoczi Cc: Anthony Liguori Cc: Paolo Bonzini Cc: Zhi Yong Wu Signed-off-by: Nicholas

[Qemu-devel] [PATCH 0/2] vhost-scsi: Check for tcm_vhost ABI version

2012-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi Anthony, Here are the two patches against Zhi's vhost-scsi tree to check for a supported version (VHOST_SCSI_ABI_VERSION=1) that's now exposed via the tcm_vhost ioctl. Please have a look and let me know if this is what you had in mind. Thanks! Nicholas Bellinger (2

[Qemu-devel] [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger As requested by Anthony, here is a patch against target-pending/for-next-merge to expose an ABI version to userspace via a new VHOST_SCSI_GET_ABI_VERSION ioctl operation. As mentioned in the comment, ABI Rev 0 is for pre 2012 out-of-tree code, and ABI Rev 1 (the current

Re: [Qemu-devel] [PATCH v5 1/6] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-07-23 Thread Eric Blake
On 07/23/2012 07:08 AM, Corey Bryant wrote: > Set the close-on-exec flag for the file descriptor received > via SCM_RIGHTS. > > +++ b/qemu-char.c > @@ -2263,9 +2263,17 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char > *buf, size_t len) > msg.msg_control = &msg_control; > msg.

Re: [Qemu-devel] [PATCH 16/16] hub: add the support for hub own flow control

2012-07-23 Thread Laszlo Ersek
On 07/20/12 14:01, Stefan Hajnoczi wrote: > From: Zhi Yong Wu > > Only when all other hub port's *peer* .can_receive() all return 1, > the source hub port .can_receive() return 1. > > Reviewed-off-by: Paolo Bonzini Probably a typo. > Signed-off-by: Zhi Yong Wu > Signed-off-by: Stefan Hajnocz

Re: [Qemu-devel] [Qemu-discuss] qemu-kvm: -netdev user: Parameter 'id' is missing

2012-07-23 Thread anatoly techtonik
Forwarding per discussion in qemu-discuss. Please CC. -- Forwarded message -- From: Mike Lovell Date: Mon, Jul 23, 2012 at 10:58 PM Subject: Re: [Qemu-discuss] qemu-kvm: -netdev user: Parameter 'id' is missing To: qemu-disc...@nongnu.org On 07/20/2012 04:10 PM, anatoly techtonik

Re: [Qemu-devel] [PATCH 13/16] net: Make "info network" output more readable info

2012-07-23 Thread Laszlo Ersek
On 07/20/12 14:01, Stefan Hajnoczi wrote: > diff --git a/net.h b/net.h > index 7e629d3..c819de4 100644 > --- a/net.h > +++ b/net.h > @@ -100,6 +100,7 @@ void qemu_check_nic_model(NICInfo *nd, const char *model); > int qemu_find_nic_model(NICInfo *nd, const char * const *models, >

Re: [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment

2012-07-23 Thread Peter Maydell
On 23 July 2012 19:49, Blue Swirl wrote: > On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil wrote: >> +/* >> + * This callback is used to create Open Firmware device path in >> accordance >> + * with OF spec http://forthworks.com/standards/of1275.pdf. Individual >> bus >> + * bindin

[Qemu-devel] 1. Re: [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386 (Avi Kivity) 2. Re: [PATCH] pc: Fix max_cpus (Dunrong Huang) 3. Re: [PATCH] kvm: Move kvm_allows_irq0_override() to targ

2012-07-23 Thread Paulo Arcinas
1. Re: [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386 (Avi Kivity) 2. Re: [PATCH] pc: Fix max_cpus (Dunrong Huang) 3. Re: [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386 (Avi Kivity) 4. Re: [PATCH] check for available room when formatting OpenFirmware device path (Peter May

Re: [Qemu-devel] [PATCH 08/16] net: Remove VLANState

2012-07-23 Thread Laszlo Ersek
On 07/20/12 14:01, Stefan Hajnoczi wrote: > diff --git a/hw/exynos4_boards.c b/hw/exynos4_boards.c > index e5c2a5f..4bb0a60 100644 > --- a/hw/exynos4_boards.c > +++ b/hw/exynos4_boards.c > @@ -81,7 +81,7 @@ static void lan9215_init(uint32_t base, qemu_irq irq) > SysBusDevice *s; > > /*

Re: [Qemu-devel] [RFC PATCH 1/4] qapi: Convert savevm

2012-07-23 Thread Luiz Capitulino
On Mon, 16 Jul 2012 10:12:08 +0200 Pavel Hrdina wrote: > On 07/12/2012 07:53 PM, Eric Blake wrote: > > On 07/12/2012 10:55 AM, Pavel Hrdina wrote: > >> Signed-off-by: Pavel Hrdina > >> --- > >> +++ b/qapi-schema.json > >> @@ -1868,3 +1868,25 @@ > >> # Since: 0.14.0 > >> ## > >> { 'command':

Re: [Qemu-devel] [RFC PATCH 1/4] qapi: Convert savevm

2012-07-23 Thread Luiz Capitulino
On Thu, 12 Jul 2012 18:55:15 +0200 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > hmp-commands.hx |2 +- > hmp.c| 10 ++ > hmp.h|1 + > qapi-schema.json | 22 ++ > qerror.c | 24 > qer

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Eduardo Habkost
On Mon, Jul 23, 2012 at 07:44:44PM +, Blue Swirl wrote: > On Mon, Jul 23, 2012 at 7:28 PM, Eduardo Habkost wrote: > > On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote: > >> On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost > >> wrote: > >> > On Mon, Jul 23, 2012 at 04:49:07PM +,

Re: [Qemu-devel] [PATCH 06/16] net: Convert qdev_prop_vlan to peer with hub

2012-07-23 Thread Laszlo Ersek
On 07/20/12 14:01, Stefan Hajnoczi wrote: > @@ -638,11 +642,17 @@ static void get_vlan(Object *obj, Visitor *v, void > *opaque, > { > DeviceState *dev = DEVICE(obj); > Property *prop = opaque; > -VLANState **ptr = qdev_get_prop_ptr(dev, prop); > -int64_t id; > +VLANClientSt

Re: [Qemu-devel] [PATCH 4/8] qemu-option: add alias support

2012-07-23 Thread Luiz Capitulino
On Mon, 23 Jul 2012 20:33:52 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Sat, 21 Jul 2012 10:11:39 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > Allow for specifying an alias for each option name, see next commits > >> > for examples. >

Re: [Qemu-devel] [PATCH 1/8] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-07-23 Thread Luiz Capitulino
On Mon, 23 Jul 2012 20:14:31 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Sat, 21 Jul 2012 10:09:09 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > Call qemu_opt_set() instead of duplicating opt_set(). > >> > > >> > Signed-off-by: Luiz Cap

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Blue Swirl
On Mon, Jul 23, 2012 at 7:28 PM, Eduardo Habkost wrote: > On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote: >> On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost wrote: >> > On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: >> >> On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost

Re: [Qemu-devel] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS

2012-07-23 Thread Eduardo Habkost
On Mon, Jul 23, 2012 at 07:25:01PM +, Blue Swirl wrote: > On Mon, Jul 23, 2012 at 7:09 PM, Eduardo Habkost wrote: > > On Mon, Jul 23, 2012 at 06:40:51PM +, Blue Swirl wrote: > >> On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost > >> wrote: > >> > Hi, > >> > > >> > While working at the CP

Re: [Qemu-devel] [PATCH 05/16] net: Drop vlan argument to qemu_new_net_client()

2012-07-23 Thread Laszlo Ersek
On 07/20/12 14:01, Stefan Hajnoczi wrote: > Since hubs are now used to implement the 'vlan' feature and the vlan > argument is always NULL, remove the argument entirely and update all net > clients that use qemu_new_net_client(). > @@ -249,7 +242,7 @@ NICState *qemu_new_nic(NetClientInfo *info, >

Re: [Qemu-devel] [PATCH 21/22] Add XBZRLE statistics

2012-07-23 Thread Luiz Capitulino
On Fri, 13 Jul 2012 09:23:43 +0200 Juan Quintela wrote: > From: Orit Wasserman > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > arch_init.c | 66 > +

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Peter Maydell
On 23 July 2012 18:45, Peter Maydell wrote: > On 23 July 2012 18:40, Blue Swirl wrote: >> On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell >> wrote: >>> The trouble is that the warnings and errors here don't cause the >>> build to fail noisily; that's a big distinction IMHO. >>> I suppose we coul

Re: [Qemu-devel] [PATCH 13/22] Add migration capabilities

2012-07-23 Thread Eric Blake
On 07/23/2012 12:23 PM, Luiz Capitulino wrote: > On Fri, 13 Jul 2012 09:23:35 +0200 > Juan Quintela wrote: > >> From: Orit Wasserman >> >> Add migration capabilities that can be queried by the management. >> The management can query the source QEMU and the destination QEMU in order to >> verify

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Eduardo Habkost
On Mon, Jul 23, 2012 at 07:11:11PM +, Blue Swirl wrote: > On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost wrote: > > On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: > >> On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost > >> wrote: > >> > On Sat, Jul 14, 2012 at 09:14:30AM +,

Re: [Qemu-devel] [PATCH 20/22] Add migrate_set_cachesize command

2012-07-23 Thread Luiz Capitulino
On Fri, 13 Jul 2012 09:23:42 +0200 Juan Quintela wrote: > From: Orit Wasserman > > Change XBZRLE cache size in bytes (the size should be a power of 2, it will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. As far as QMP is conce

Re: [Qemu-devel] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS

2012-07-23 Thread Blue Swirl
On Mon, Jul 23, 2012 at 7:09 PM, Eduardo Habkost wrote: > On Mon, Jul 23, 2012 at 06:40:51PM +, Blue Swirl wrote: >> On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost wrote: >> > Hi, >> > >> > While working at the CPU index vs APIC ID changes, I stumbled upon >> > another not-very-well-defined

Re: [Qemu-devel] [PATCH 04/16] hub: Check that hubs are configured correctly

2012-07-23 Thread Laszlo Ersek
On 07/20/12 14:01, Stefan Hajnoczi wrote: > Checks can be performed to make sure that hubs have at least one NIC and > one host device, warning the user if this is not the case. > Configurations which do not meet this rule tend to be broken but just > emit a warning. This patch preserves compatibi

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Blue Swirl
On Mon, Jul 23, 2012 at 6:59 PM, Eduardo Habkost wrote: > On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: >> On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost wrote: >> > On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote: >> > [...] >> >> >> > diff --git a/tests/Makefile b/tes

Re: [Qemu-devel] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS

2012-07-23 Thread Eduardo Habkost
On Mon, Jul 23, 2012 at 06:40:51PM +, Blue Swirl wrote: > On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost wrote: > > Hi, > > > > While working at the CPU index vs APIC ID changes, I stumbled upon > > another not-very-well-defined interface between SeaBIOS and QEMU, and I > > would like to cla

Re: [Qemu-devel] [PATCH 01/16] net: Add a hub net client

2012-07-23 Thread Blue Swirl
On Mon, Jul 23, 2012 at 4:33 PM, Andreas Färber wrote: > Am 23.07.2012 17:23, schrieb Stefan Hajnoczi: >> On Mon, Jul 23, 2012 at 4:16 PM, Laszlo Ersek wrote: >>> On 07/23/12 16:52, Stefan Hajnoczi wrote: On Mon, Jul 23, 2012 at 3:05 PM, Laszlo Ersek wrote: >>> > The idea is, rather tha

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Eduardo Habkost
On Mon, Jul 23, 2012 at 04:49:07PM +, Blue Swirl wrote: > On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost wrote: > > On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote: > > [...] > >> >> > diff --git a/tests/Makefile b/tests/Makefile > >> >> > index b605e14..89bd890 100644 > >> >> > -

Re: [Qemu-devel] [PATCH] qdev: Fix Open Firmware comment

2012-07-23 Thread Blue Swirl
On Fri, Jul 20, 2012 at 9:04 PM, Stefan Weil wrote: > Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code, > but left the related comment at a location where it no longer > belongs to. > > The patch moves the comment to the correct callback and improves the text. > > Signed-off-by: Stefan

Re: [Qemu-devel] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS

2012-07-23 Thread Blue Swirl
On Fri, Jul 20, 2012 at 8:00 PM, Eduardo Habkost wrote: > Hi, > > While working at the CPU index vs APIC ID changes, I stumbled upon > another not-very-well-defined interface between SeaBIOS and QEMU, and I > would like to clarify the semantics and constraints of some FW_CFG > entries. > > First,

Re: [Qemu-devel] [PATCH 4/8] qemu-option: add alias support

2012-07-23 Thread Markus Armbruster
Luiz Capitulino writes: > On Sat, 21 Jul 2012 10:11:39 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Allow for specifying an alias for each option name, see next commits >> > for examples. >> > >> > Signed-off-by: Luiz Capitulino >> > --- >> > qemu-option.c | 5 +++--

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-23 Thread Blue Swirl
On Fri, Jul 20, 2012 at 5:19 PM, Stefan Weil wrote: > Am 20.07.2012 08:38, schrieb Alexey Kardashevskiy: > >> On 20/07/12 16:05, Alexey Kardashevskiy wrote: >>> >>> On 20/07/12 15:37, Alexey Kardashevskiy wrote: On 20/07/12 15:23, Stefan Weil wrote: > > Am 20.07.2012 05:53, schri

Re: [Qemu-devel] [PULL] pci,msi,virtio

2012-07-23 Thread Alex Williamson
On Mon, 2012-07-23 at 13:16 -0500, Anthony Liguori wrote: > On 07/23/2012 12:05 PM, Alex Williamson wrote: > > On Mon, 2012-07-23 at 11:39 -0500, Anthony Liguori wrote: > >> Andreas Färber writes: > >> > >>> Am 19.07.2012 17:15, schrieb Michael S. Tsirkin: > The following changes since commit

Re: [Qemu-devel] [PATCH 13/22] Add migration capabilities

2012-07-23 Thread Luiz Capitulino
On Fri, 13 Jul 2012 09:23:35 +0200 Juan Quintela wrote: > From: Orit Wasserman > > Add migration capabilities that can be queried by the management. > The management can query the source QEMU and the destination QEMU in order to > verify both support some migration capability (currently only XB

Re: [Qemu-devel] [PULL] pci,msi,virtio

2012-07-23 Thread Anthony Liguori
On 07/23/2012 12:05 PM, Alex Williamson wrote: On Mon, 2012-07-23 at 11:39 -0500, Anthony Liguori wrote: Andreas Färber writes: Am 19.07.2012 17:15, schrieb Michael S. Tsirkin: The following changes since commit 80aa796bf38b7ef21daa42673b4711510c450d8a: pci_bridge_dev: fix error path in

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-23 Thread Blue Swirl
On Wed, Jul 18, 2012 at 8:51 AM, Wenchao Xia wrote: > Hi, following is API draft, prototypes were taken from qemu/block.h, > and the API prefix is changed frpm bdrv to qbdrvs, to declare related > object is BlockDriverState, not BlockDriver. One issue here is it may > require include block_int.h

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-07-23 Thread Serge Hallyn
@houstonbofh which release is your host? Please show the result of 'virsh dumpxml MACHINEID | grep machine' -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/918791 Title: qemu-kvm dies when using vm

Re: [Qemu-devel] [PATCH 1/8] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-07-23 Thread Markus Armbruster
Luiz Capitulino writes: > On Sat, 21 Jul 2012 10:09:09 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Call qemu_opt_set() instead of duplicating opt_set(). >> > >> > Signed-off-by: Luiz Capitulino >> > --- >> > qemu-option.c | 28 +--- >> > 1 fi

[Qemu-devel] [PATCH] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop

2012-07-23 Thread Peter Maydell
The code to initialise the target_to_host_errno_table[] array was accidentally inside the loop through checking and initialising all the supported ioctls. This was harmless but meant that we reinitialised the array several hundred times on startup. Signed-off-by: Peter Maydell --- The code seems

[Qemu-devel] [PATCH] linux-user: Fix SNDCTL_DSP_MAP{IN, OUT}BUF ioctl definitions

2012-07-23 Thread Peter Maydell
Fix the SNDCTL_DSP_MAP{IN,OUT}BUF ioctl definitions so that they refer to a suitably defined target struct layout rather than hardcoding the ioctl number. This fixes complaints from the syscall_init() consistency check when running an x86_64-to-x86_64 linux-user qemu. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH] linux-user: Fix incorrect TARGET_BLKBSZGET, TARGET_BLKBSZSET

2012-07-23 Thread Peter Maydell
The definitions for the ioctl numbers TARGET_BLKBSZGET and TARGET_BLKBSZSET had the wrong size parameters (they are defined with size_t, not int, even though the ioctl implementations themselves read and write integers). Since commit 354a0008 we now have an ioctl wrapper definition for BLKBSZGET an

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Peter Maydell
On 23 July 2012 15:30, Avi Kivity wrote: > But I was only joking. Nested virtualization is interesting technically > but so far I haven't seen any huge or even small uptake. Yes; that (as I understand it) is why it wasn't an expected use case for the architecture extensions. The other related th

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Jan Kiszka
On 2012-07-23 19:41, Peter Maydell wrote: > On 23 July 2012 17:55, Jan Kiszka wrote: >> On 2012-07-23 17:19, Peter Maydell wrote: >>> OK, let's see if we can get some agreement about naming here. >>> >>> First, some test-functions I think we definitely need: >>> >>> kvm_interrupts_are_async() >>>

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Peter Maydell
On 23 July 2012 18:40, Blue Swirl wrote: > On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell > wrote: >> The trouble is that the warnings and errors here don't cause the >> build to fail noisily; that's a big distinction IMHO. >> I suppose we could make compile_prog do something like: >> * run the

Re: [Qemu-devel] [PATCH v3 2/2] bitops: fix types

2012-07-23 Thread Peter Maydell
On 23 July 2012 18:33, Blue Swirl wrote: > I'm getting a strong feeling that it's a bad idea to reuse any Linux > kernel sources since they are seen as divine and untouchable, unlike > for example BSD queue macros. We should also try to avoid deviations in our queue macros, and I think we do (eg

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Peter Maydell
On 23 July 2012 17:55, Jan Kiszka wrote: > On 2012-07-23 17:19, Peter Maydell wrote: >> OK, let's see if we can get some agreement about naming here. >> >> First, some test-functions I think we definitely need: >> >> kvm_interrupts_are_async() >>-- true if interrupt delivery is asynchronous >

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Blue Swirl
On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell wrote: > On 17 July 2012 20:24, Stefan Weil wrote: >> The arguments why -Werror is a bad idea for some configure tests >> are reasonable. >> >> Nevertheless the QEMU community was able to produce thousands of >> lines of code which compile without a

Re: [Qemu-devel] [PATCHv4 0/4] Sandboxing Qemu guests with Libseccomp

2012-07-23 Thread Blue Swirl
On Mon, Jul 23, 2012 at 12:59 PM, Eduardo Otubo wrote: > On Tue, Jul 17, 2012 at 04:19:11PM -0300, Eduardo Otubo wrote: >> Hello all, >> >> This patch is an effort to sandbox Qemu guests using Libseccomp[0]. The >> patches >> that follows are pretty simple and straightforward. I added the correct

Re: [Qemu-devel] question about qemu migrate.

2012-07-23 Thread Sheldon
On 07/23/2012 06:26 AM, Amos Kong wrote: On Sun, Jul 22, 2012 at 10:59 PM, Sheldon wrote: (qemu) migrate -d exec:cat>/tmp/vm.out -incoming fd: Load the suspend vm.out by # qemu-kvm incoming fd/tmp/vm.out2 Is it satisfied for you? Thank for your patience. Load the suspend vm.out

Re: [Qemu-devel] [PATCH v3 2/2] bitops: fix types

2012-07-23 Thread Blue Swirl
On Tue, Jul 17, 2012 at 12:36 PM, Markus Armbruster wrote: > Peter Maydell writes: > >> On 14 July 2012 13:34, Blue Swirl wrote: >>> bitops.h uses inconsistently 'unsigned long' and 'int' for bit numbers. >>> >>> Unify to 'unsigned long' because it generates better code on x86_64. >>> Adjust ass

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-07-23 Thread houstonbofh
It looks like this bug is still around. I was running a 12.04 guest with the vmvga graphics, and on logging the emulation just dies. Running 0.14.0+noroms-0ubuntu7+dnjl1~lucid0 I have done almost no troubleshooting on this yet, and the vga driver works well enough for now. -- You received this

Re: [Qemu-devel] [PATCH V4 1/3] block: Add bdrv_are_busy()

2012-07-23 Thread Luiz Capitulino
On Mon, 23 Jul 2012 16:22:58 +0200 benoit.ca...@gmail.com wrote: > From: Benoît Canet > > bdrv_are_busy will be used to check if any of the bs are in use > or if one of them have a running block job. > > The first user will be qmp_migrate(). > > Signed-off-by: Benoit Canet > --- > block.c |

Re: [Qemu-devel] [PATCH 01/16] net: Add a hub net client

2012-07-23 Thread Markus Armbruster
Andreas Färber writes: > Hm, I'm not so much into those documents [cc'ing Blue], but we used to > be stricter about ANSI C some years back (which iirc forbids > non-constant expressions in initializers?). FWIW we have since switched It doesn't, except when the variable has static storage duratio

Re: [Qemu-devel] [PATCH 2/2] fdc-test: Check RELATIVE SEEK beyond track 0/80

2012-07-23 Thread Blue Swirl
On Tue, Jul 17, 2012 at 9:03 AM, Pavel Hrdina wrote: > On 07/16/2012 04:36 PM, Kevin Wolf wrote: >> >> TODO This needs to be checked against a real drive >> >> Signed-off-by: Kevin Wolf >> --- >> tests/fdc-test.c | 48 +--- >> 1 files changed, 37 in

Re: [Qemu-devel] [PATCH V4 2/3] qerror: Add error telling that block dev usage prevents migration

2012-07-23 Thread Luiz Capitulino
On Mon, 23 Jul 2012 16:22:59 +0200 benoit.ca...@gmail.com wrote: > From: Benoît Canet > > Signed-off-by: Benoit Canet > --- > qerror.c |4 > qerror.h |3 +++ > 2 files changed, 7 insertions(+) > > diff --git a/qerror.c b/qerror.c > index 92c4eff..d2e76ca 100644 > --- a/qerror.c >

Re: [Qemu-devel] [PULL] pci,msi,virtio

2012-07-23 Thread Alex Williamson
On Mon, 2012-07-23 at 11:39 -0500, Anthony Liguori wrote: > Andreas Färber writes: > > > Am 19.07.2012 17:15, schrieb Michael S. Tsirkin: > >> The following changes since commit > >> 80aa796bf38b7ef21daa42673b4711510c450d8a: > >> > >> pci_bridge_dev: fix error path in pci_bridge_dev_initfn()

Re: [Qemu-devel] Can't Build i386-bsd-user on Freebsd

2012-07-23 Thread Blue Swirl
On Tue, Jul 17, 2012 at 2:07 AM, Paramjot Oberoi wrote: > Hey all, > > I'm having trouble building user mode BSD emulation on FreeBSD. I've tried > 1.0.1, 1.1.1, and stable from GIT. I build by doing a: "./configure > --target-list=i386-bsd-user", and then make with "gmake". The first error I > ge

Re: [Qemu-devel] [PATCH 12/12] raw-win32: add emulated AIO support

2012-07-23 Thread Paolo Bonzini
Il 23/07/2012 18:35, Blue Swirl ha scritto: >> > +struct qemu_paiocb { > QEMUPAIOCB RawWin32AIOData. :) >> > +BlockDriverState *bs; >> > +HANDLE hfile; >> > +struct iovec *aio_iov; >> > +int aio_niov; >> > +size_t aio_nbytes; >> > +off_t aio_offset; >> > +int aio_type;

Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-23 Thread Jan Kiszka
On 2012-07-23 17:19, Peter Maydell wrote: > On 23 July 2012 13:26, Avi Kivity wrote: >> On 07/21/2012 11:54 AM, Peter Maydell wrote: >>> The reason I want to get rid of common-code uses of kvm_irqchip_in_kernel() >>> is because I think they're all similar to this -- the common code is >>> using th

Re: [Qemu-devel] [RFC][PATCH v3 1/3] configure: Add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-23 Thread Blue Swirl
On Tue, Jul 17, 2012 at 2:06 AM, YeongKyoon Lee wrote: > The reason why softmmu condition in configure is that softmmu is thought to > be a logical prerequisite of ldst optimization. > Current patch causes compilation error if removed the condition above. > To avoid compilation error, it needs mo

Re: [Qemu-devel] [PATCH 1/5] scsi-disk: removable hard disks support START/STOP

2012-07-23 Thread Paolo Bonzini
Il 23/07/2012 18:44, Blue Swirl ha scritto: >> > Support for START/STOP UNIT right now is limited to CD-ROMs. This is >> > wrong, >> > since removable hard disks (in the real world: SD card readers) also >> > support >> > it in pretty much the same way. > I remember vaguely tuning a set of large

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-23 Thread Blue Swirl
On Mon, Jul 16, 2012 at 5:42 PM, Eduardo Habkost wrote: > On Sat, Jul 14, 2012 at 09:14:30AM +, Blue Swirl wrote: > [...] >> >> > diff --git a/tests/Makefile b/tests/Makefile >> >> > index b605e14..89bd890 100644 >> >> > --- a/tests/Makefile >> >> > +++ b/tests/Makefile >> >> > @@ -15,6 +15,7

Re: [Qemu-devel] [PULL] pci,msi,virtio

2012-07-23 Thread Andreas Färber
Am 23.07.2012 18:39, schrieb Anthony Liguori: > Andreas Färber writes: > >> Am 19.07.2012 17:15, schrieb Michael S. Tsirkin: >>> The following changes since commit 80aa796bf38b7ef21daa42673b4711510c450d8a: >>> >>> pci_bridge_dev: fix error path in pci_bridge_dev_initfn() (2012-06-11 >>> 22:55:

Re: [Qemu-devel] [PATCH 1/5] scsi-disk: removable hard disks support START/STOP

2012-07-23 Thread Blue Swirl
On Mon, Jul 16, 2012 at 2:25 PM, Paolo Bonzini wrote: > Support for START/STOP UNIT right now is limited to CD-ROMs. This is wrong, > since removable hard disks (in the real world: SD card readers) also support > it in pretty much the same way. I remember vaguely tuning a set of large SCSI hard

[Qemu-devel] [PATCH] vl.c: Exit QEMU early if no machine is found

2012-07-23 Thread riegamaths
From: Dunrong Huang We check whether the variable machine is NULL or not before accessing it. If machine is NULL, exit QEMU with an error, this can avoids a segfault error. Signed-off-by: Dunrong Huang --- vl.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/v

Re: [Qemu-devel] [PULL] pci,msi,virtio

2012-07-23 Thread Anthony Liguori
Andreas Färber writes: > Am 19.07.2012 17:15, schrieb Michael S. Tsirkin: >> The following changes since commit 80aa796bf38b7ef21daa42673b4711510c450d8a: >> >> pci_bridge_dev: fix error path in pci_bridge_dev_initfn() (2012-06-11 >> 22:55:13 +0300) >> >> are available in the git repository a

Re: [Qemu-devel] [PATCH v3 1/2] bitops: drop volatile qualifier

2012-07-23 Thread Blue Swirl
On Mon, Jul 16, 2012 at 2:40 PM, Eric Blake wrote: > On 07/14/2012 06:34 AM, Blue Swirl wrote: >> Qualifier 'volatile' is not useful for applications, it's too strict >> for single threaded code but does not give the real atomicity guarantees >> needed for multithreaded code. >> >> Drop them and n

Re: [Qemu-devel] [PATCH 12/12] raw-win32: add emulated AIO support

2012-07-23 Thread Blue Swirl
On Mon, Jul 16, 2012 at 10:42 AM, Paolo Bonzini wrote: > The thread pool can be used under Win32 in the same way as in raw-posix.c. > Move the existing synchronous code into callbacks, and pass the return > code back. > > Signed-off-by: Paolo Bonzini > --- > block/raw-win32.c | 189 > +

Re: [Qemu-devel] [PATCH 01/16] net: Add a hub net client

2012-07-23 Thread Andreas Färber
Am 23.07.2012 17:23, schrieb Stefan Hajnoczi: > On Mon, Jul 23, 2012 at 4:16 PM, Laszlo Ersek wrote: >> On 07/23/12 16:52, Stefan Hajnoczi wrote: >>> On Mon, Jul 23, 2012 at 3:05 PM, Laszlo Ersek wrote: >> The idea is, rather than unsigned int id = hub->num_ports++; i

[Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-23 Thread Alon Levy
bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1 RHBZ: 770842 Signed-off-by: Alon Levy --- v2: fixed interface_async_complete_io to not complain about unexpected async io. configure|2 +- hw/qxl.c | 30

Re: [Qemu-devel] [PATCH V4 1/3] linux-user: pass sockaddr from host to target

2012-07-23 Thread Peter Maydell
On 24 July 2012 00:49, Jing Huang wrote: > > Signed-off-by: Jing Huang > Reviewed-by: Peter Maydell > --- > linux-user/syscall.c | 15 +-- > 1 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 539af3f..3319bb8 1006

Re: [Qemu-devel] [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements

2012-07-23 Thread Paolo Bonzini
Il 03/07/2012 15:20, Paolo Bonzini ha scritto: > These patches let virtio-blk use the new support for toggling the cache > mode between writethrough and writeback. > > The first patch introduces a new feature bit and configuration field to > do this. The second patch disables writeback caching fo

Re: [Qemu-devel] [PATCH V4 3/3] linux-user: make host_to_target_cmsg support SO_TIMESTAMP cmsg_type

2012-07-23 Thread Peter Maydell
On 24 July 2012 00:52, Jing Huang wrote: > > Signed-off-by: Jing Huang > --- > linux-user/syscall.c | 20 > 1 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 9b498d0..ce70459 100644 > --- a/linux-user/sys

Re: [Qemu-devel] [PATCH] eepro100: fix simplified mode

2012-07-23 Thread Stefan Weil
Am 23.07.2012 11:25, schrieb initcr...@gmail.com: From: Christian Schilling A driver using simplified mode that works on real hardware did not work in qemu. Signed-off-by: Christian Schilling --- hw/eepro100.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/h

Re: [Qemu-devel] [PATCH 4/8] qemu-option: add alias support

2012-07-23 Thread Luiz Capitulino
On Sat, 21 Jul 2012 10:11:39 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Allow for specifying an alias for each option name, see next commits > > for examples. > > > > Signed-off-by: Luiz Capitulino > > --- > > qemu-option.c | 5 +++-- > > qemu-option.h | 1 + > > 2 files c

Re: [Qemu-devel] [PULL] pci,msi,virtio

2012-07-23 Thread Andreas Färber
Am 19.07.2012 17:15, schrieb Michael S. Tsirkin: > The following changes since commit 80aa796bf38b7ef21daa42673b4711510c450d8a: > > pci_bridge_dev: fix error path in pci_bridge_dev_initfn() (2012-06-11 > 22:55:13 +0300) > > are available in the git repository at: > > git://git.kernel.org/pu

Re: [Qemu-devel] [PATCH 1/8] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-07-23 Thread Luiz Capitulino
On Sat, 21 Jul 2012 10:09:09 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Call qemu_opt_set() instead of duplicating opt_set(). > > > > Signed-off-by: Luiz Capitulino > > --- > > qemu-option.c | 28 +--- > > 1 file changed, 1 insertion(+), 27 deletion

[Qemu-devel] [PATCH V4 3/3] linux-user: make host_to_target_cmsg support SO_TIMESTAMP cmsg_type

2012-07-23 Thread Jing Huang
Signed-off-by: Jing Huang --- linux-user/syscall.c | 20 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 9b498d0..ce70459 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1348,16 +1348,28 @@

[Qemu-devel] [PATCH V4 2/3] linux-user: make do_setsockopt support SOL_RAW ICMP_FILTER socket option

2012-07-23 Thread Jing Huang
Signed-off-by: Jing Huang Reviewed-by: Peter Maydell --- linux-user/syscall.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 3319bb8..9b498d0 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscal

[Qemu-devel] [PATCH V4 1/3] linux-user: pass sockaddr from host to target

2012-07-23 Thread Jing Huang
Signed-off-by: Jing Huang Reviewed-by: Peter Maydell --- linux-user/syscall.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 539af3f..3319bb8 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @

[Qemu-devel] [PATCH V4 0/3] Fix ping issues in linux-user guest

2012-07-23 Thread Jing Huang
The following changes since commit 61dc008f3529fa74a63aad1907438dad857e255a: Revert "audio: Make PC speaker audio card available by default" These patches fix ping issues in linux-user guest: - do_sebdrecv() could not pass sockaddr to target after executing recvmsg(). Therefore, ping will shows:

  1   2   3   >