On 07/20/12 14:01, Stefan Hajnoczi wrote:
> diff --git a/hw/exynos4_boards.c b/hw/exynos4_boards.c
> index e5c2a5f..4bb0a60 100644
> --- a/hw/exynos4_boards.c
> +++ b/hw/exynos4_boards.c
> @@ -81,7 +81,7 @@ static void lan9215_init(uint32_t base, qemu_irq irq)
> SysBusDevice *s;
>
> /* This should be a 9215 but the 9118 is close enough */
> - if (nd_table[0].vlan) {
> + if (nd_table[0].used) {
> qemu_check_nic_model(&nd_table[0], "lan9118");
> dev = qdev_create(NULL, "lan9118");
> qdev_set_nic_properties(dev, &nd_table[0]);
Right, relevant commits: 0ae18cee & 7697079b.
> @@ -970,7 +895,7 @@ void qmp_set_link(const char *name, bool up, Error **errp)
> done:
>
> if (!vc) {
> - error_set(errp, QERR_DEVICE_NOT_FOUND, name);
> + qerror_report(QERR_DEVICE_NOT_FOUND, name);
> return;
> }
Why? The only caller (at this point) seems to be hmp_set_link(), and it
handles the error (with monitor_printf()).
Thanks,
Laszlo
