Hi!
Found 2 problems while I was debugging qemu/ppc64-softmmu/qemu-system-ppc64.exe
WindowsXP SP3 Pro, 32bit, i686-pc-mingw32-gcc (GCC) 4.5.2.
1. The size of the following is 7 bytes on linux and 8 bytes on Windows:
struct {
uint32_t hi;
uint64_t child;
uint64_t parent;
uint64_t
Hi,
On Monday, July 16, 2012 12:07:58 PM Stefan Hajnoczi wrote:
> On Sun, Jul 15, 2012 at 03:49:13PM +0200, Stefan Weil wrote:
> > One of the buildbot jobs should be configured with all sound options:
> >
> > --audio-card-list¬97,es1370,sb16,cs4231a,adlib,gus,hda
> > --audio-drv-list=alsa,sdl,oss,
At 07/06/2012 07:05 PM, Jan Kiszka Wrote:
> On 2012-07-06 11:41, Wen Congyang wrote:
>> If the target is x86/x86_64, the guest's kernel will write 0x01 to the
>> port KVM_PV_PORT when it is panciked. This patch introduces a new qom
>> device kvm_pv_ioport to listen this I/O port, and deal with pani
On Tue, 17 Jul 2012 19:05:39 -0500
Anthony Liguori wrote:
> q...@buildbot.b1-systems.de writes:
>
> > The Buildbot has detected a new failure on builder
> > default_x86_64_debian_6_0 while building qemu.
> > Full details are available at:
> >
> > http://buildbot.b1-systems.de/qemu/builders/de
The Buildbot has detected a new failure on builder
disable_kvm_x86_64_out_of_tree while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/disable_kvm_x86_64_out_of_tree/builds/519
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Buil
The Buildbot has detected a new failure on builder disable_kvm_i386_out_of_tree
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/disable_kvm_i386_out_of_tree/builds/519
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: y
The Buildbot has detected a new failure on builder
disable_kvm_x86_64_debian_6_0 while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/disable_kvm_x86_64_debian_6_0/builds/332
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build:
q...@buildbot.b1-systems.de writes:
> The Buildbot has detected a new failure on builder default_x86_64_debian_6_0
> while building qemu.
> Full details are available at:
>
> http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/331
>
> Buildbot URL: http://buildbot.b1-sy
The Buildbot has detected a new failure on builder disable_kvm_i386_debian_6_0
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/disable_kvm_i386_debian_6_0/builds/332
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuz
34bb443ee74df3780d86044dbf6492eb798c5807 broke the build but in a subtle way.
The patch on the ML was actually based on the 1.1.1 stable branch
(accidentally). When I merged it from the ML, the fuzzing got resolved in a
such a way that the newly introduced Makefile dependency on GENERATED_HEADERS
The Buildbot has detected a new failure on builder default_i386_debian_6_0
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_i386_debian_6_0/builds/331
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
Buil
The Buildbot has detected a new failure on builder default_i386_out_of_tree
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_i386_out_of_tree/builds/517
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
Bu
The Buildbot has detected a new failure on builder default_mingw32 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/320
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: kraxel_rhel61
Build Reason:
The Buildbot has detected a new failure on builder default_x86_64_out_of_tree
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_x86_64_out_of_tree/builds/517
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuk
The Buildbot has detected a new failure on builder default_openbsd_current
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_openbsd_current/builds/321
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: brad_openbsd
The Buildbot has detected a new failure on builder default_openbsd_4.9 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_openbsd_4.9/builds/320
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: kraxel_openbsd49
Bu
The Buildbot has detected a new failure on builder default_x86_64_debian_6_0
while building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/331
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: yuzuki
On Mon, Jul 16, 2012 at 01:49:19PM -0700, desi babu wrote:
> Any pointers for debugging ?.
>> What version of the virtio-win drivers are you using? More specifically,
>> what's the name of the ISO/package you used? I'm not sure how
>> "Driver Date" maps to actual virto-win releases.
I tested wit
On Tue, Jul 17, 2012 at 05:02:49PM -0500, Michael Roth wrote:
> On Tue, Jul 17, 2012 at 02:34:53PM -0700, desi babu wrote:
> > On Mon, Jul 16, 2012 at 01:49:19PM -0700, desi babu wrote:
> > > Any pointers for debugging ?.
> >
> > >> What version of the virtio-win drivers are you using? More specif
On Tue, Jul 17, 2012 at 02:34:53PM -0700, desi babu wrote:
> On Mon, Jul 16, 2012 at 01:49:19PM -0700, desi babu wrote:
> > Any pointers for debugging ?.
>
> >> What version of the virtio-win drivers are you using? More specifically,
> >> what's the name of the ISO/package you used? I'm not sure
This patch is an attempt to fix the non-continguous-APIC-ID problem without the
FW_CFG_LAPIC_INFO approach I have sent proposed last week.
Basically, this changes Seabios to probe for APIC IDs directly from the
CPUs on boot, instead of getting it using fw_cfg, store the found APIC
IDs on a bitmap,
upstream git head qemu still behaves the same as quantal qemu-kvm
(1.1.0), marking a affecting upstream.
** Also affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.l
On 07/18/2012 12:31 AM, Harsh Bora wrote:
On 07/17/2012 08:51 PM, Stefan Hajnoczi wrote:
On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora
wrote:
Existing simpletrace backend allows to trace at max 6 args and does not
support strings. This newer tracelog format gets rid of fixed size
records
On 07/17/2012 08:53 PM, Stefan Hajnoczi wrote:
On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora
wrote:
Existing simpletrace backend allows to trace at max 6 args and does not
support strings. This newer tracelog format gets rid of fixed size records
and therefore allows to trace variable num
Quote from ISA, 2.1:
For most Xtensa instructions, bit numbering is irrelevant; only the BBC
and BBS instructions assign bit numbers to values on which the processor
operates. The BBC/BBS instructions use big-endian bit ordering (0 is the
most-significant bit) on a big-endian processor configurati
Am 17.07.2012 21:28, schrieb Peter Maydell:
On 17 July 2012 20:24, Stefan Weil wrote:
The arguments why -Werror is a bad idea for some configure tests
are reasonable.
Nevertheless the QEMU community was able to produce thousands of
lines of code which compile without a warning, so we should be
On 17.07.2012, at 21:24, Peter Maydell wrote:
> Don't run configure tests with -Werror in the compiler flags. The idea
> of -Werror is that it makes problems very obvious to developers, so
> they get fixed quickly. However, when running configure tests, failures
> due to -Werror are far from obvi
Am 17.07.2012 21:24, schrieb Peter Maydell:
Don't run configure tests with -Werror in the compiler flags. The idea
of -Werror is that it makes problems very obvious to developers, so
they get fixed quickly. However, when running configure tests, failures
due to -Werror are far from obvious -- the
Adding basic options to the configure script to use libseccomp or not.
The default is set to 'no'. If the flag --enable-libseccomp is used, the
script will check for its existence using pkg-config.
v2:
* As I removed all the code related to seccomp from vl.c, I created
qemu-seccomp.[ch].
* Al
On 17 July 2012 20:24, Stefan Weil wrote:
> The arguments why -Werror is a bad idea for some configure tests
> are reasonable.
>
> Nevertheless the QEMU community was able to produce thousands of
> lines of code which compile without a warning, so we should be able
> to create warning and error fr
On 2012-07-17 20:50, Michael Tokarev wrote:
> Hello.
>
> We're getting more and more various bugreports and questions
> about -net user,smb=xxx - about usage of "private" smbd to
> share a given directory.
>
> In short: it does not quite work. Due to alot of various
> reasons, most things being
Don't run configure tests with -Werror in the compiler flags. The idea
of -Werror is that it makes problems very obvious to developers, so
they get fixed quickly. However, when running configure tests, failures
due to -Werror are far from obvious -- they simply result in the test
quietly failing wh
Am 17.07.2012 20:46, schrieb Peter Maydell:
On 17 July 2012 19:32, Stefan Weil wrote:
Hello Anthony, hello Blue,
these patches fix broken builds, therefore I expected that they
would be applied fast:
http://patchwork.ozlabs.org/patch/171066/
http://patchwork.ozlabs.org/patch/171067/
http://pa
The new 'trap' (debug) mode will capture the illegal system call before it is
executed. The feature and the implementation is based on Will Drewry's
patch - https://lkml.org/lkml/2012/4/12/449
v4:
* New files in v4
* If SCMP_ACT_TRAP flag used when calling seccomp_init(), the kernel will
send
v1:
* Full seccomp calls and data included in vl.c
v2:
* Full seccomp calls and data removed from vl.c and put into separate
qemu-seccomp.[ch] file.
v4:
* Call to install_seccomp_syscall_debug() added.
* Now calling seccomp_start() with 'SECCOMP_MODE' argument, depending on
settings use
v1:
* I added a syscall struct using priority levels as described in the
libseccomp man page. The priority numbers are based to the frequency
they appear in a sample strace from a regular qemu guest run under
libvirt.
Libseccomp generates linear BPF code to filter system calls, those
Hello all,
This patch is an effort to sandbox Qemu guests using Libseccomp[0]. The patches
that follows are pretty simple and straightforward. I added the correct options
and checks to the configure script and the basic calls to libseccomp in the
main loop at vl.c. Details of each one are in the e
On 17 July 2012 20:07, Stefan Weil wrote:
> If the user overrides CFLAGS, I expect that he/she will notice
> that compilation fails and hopefully find the cause (only
> expert users should override CFLAGS). Overriding -march=i486
> might be useful to set -march=i686.
>
> Therefore it was not so ob
On Tue, Jul 17, 2012 at 01:33:32PM -0500, Anthony Liguori wrote:
> Let's stop screwing up releases by having a script do the work that Anthony's
> fat fingers can't seem to get right.
>
> Cc: Michael Roth
> Signed-off-by: Anthony Liguori
Breaks if there's no tag corresponding with the contents
Am 17.07.2012 20:43, schrieb Peter Maydell:
On 15 July 2012 19:34, Stefan Weil wrote:
"+=" does not work with dash and other simple /bin/sh implementations.
The new code prepends the flag while the old code either did not work
(it continued after an error message which typically was not read)
On 07/17/2012 08:51 PM, Stefan Hajnoczi wrote:
On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora
wrote:
Existing simpletrace backend allows to trace at max 6 args and does not
support strings. This newer tracelog format gets rid of fixed size records
and therefore allows to trace variable num
Hello.
We're getting more and more various bugreports and questions
about -net user,smb=xxx - about usage of "private" smbd to
share a given directory.
In short: it does not quite work. Due to alot of various
reasons, most things being wrong/insufficient smb.conf
generated by slirp code.
Lookin
On 07/17/2012 12:33 PM, Anthony Liguori wrote:
> Let's stop screwing up releases by having a script do the work that Anthony's
> fat fingers can't seem to get right.
>
> Cc: Michael Roth
> Signed-off-by: Anthony Liguori
> ---
> +++ b/scripts/make-release
> @@ -0,0 +1,24 @@
> +#!/bin/bash -e
Is
On 17 July 2012 19:32, Stefan Weil wrote:
> Hello Anthony, hello Blue,
>
> these patches fix broken builds, therefore I expected that they
> would be applied fast:
>
> http://patchwork.ozlabs.org/patch/171066/
> http://patchwork.ozlabs.org/patch/171067/
> http://patchwork.ozlabs.org/patch/171081/
On 15 July 2012 19:34, Stefan Weil wrote:
> "+=" does not work with dash and other simple /bin/sh implementations.
>
> The new code prepends the flag while the old code either did not work
> (it continued after an error message which typically was not read) or
> appended the flag. That difference
On Tue, 17 Jul 2012, Avi Kivity wrote:
> On 07/17/2012 04:59 PM, Anthony PERARD wrote:
> >>
> >> This is pretty ugly. An alternative is to set up a periodic bitmap scan
> >> that looks at the qemu dirty bitmap and calls xen_modified_memory() for
> >> dirty page ranges, and clears the bitmap for th
Let's stop screwing up releases by having a script do the work that Anthony's
fat fingers can't seem to get right.
Cc: Michael Roth
Signed-off-by: Anthony Liguori
---
v1 -> v2
- include the scripts for real this time
- remove tar/tarbin from PHONY
---
Makefile | 19 -
Am 17.07.2012 20:03, schrieb Igor Mitsyanko:
I see now that this bug was already noticed, please ignore this mail
On 07/17/2012 09:34 PM, Igor Mitsyanko wrote:
After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure
tests are
executed with -Werror flag. Current ALSA configure test p
On 2012-07-17 19:34, Peter Maydell wrote:
> On 17 July 2012 18:03, Jan Kiszka wrote:
>> On 2012-07-17 18:41, Peter Maydell wrote:
>>> Rather than hardcoding the list of architectures in the kernel
>>> header update script, just import headers for every architecture
>>> which supports KVM. This red
On Tue, 17 Jul 2012, Stefano Stabellini wrote:
> On Tue, 17 Jul 2012, Anthony PERARD wrote:
> > Because the call to track the dirty bit in the video ram during migration
> > won't
> > work (it returns -1), we set dirtybit on the all video ram.
> >
> > Signed-off-by: Anthony PERARD
> > ---
> > x
On Tue, 17 Jul 2012, Anthony PERARD wrote:
> Because the call to track the dirty bit in the video ram during migration
> won't
> work (it returns -1), we set dirtybit on the all video ram.
>
> Signed-off-by: Anthony PERARD
> ---
> xen-all.c |5 +
> 1 files changed, 5 insertions(+), 0 de
On 17 July 2012 19:16, Anthony Liguori wrote:
> Let's stop screwing up releases by having a script do the work that Anthony's
> fat fingers can't seem to get right.
>
> Cc: Michael Roth
> Signed-off-by: Anthony Liguori
> ---
> Makefile | 19 ---
> 1 files changed, 8 insertions
Let's stop screwing up releases by having a script do the work that Anthony's
fat fingers can't seem to get right.
Cc: Michael Roth
Signed-off-by: Anthony Liguori
---
Makefile | 19 ---
1 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/Makefile b/Makefile
index 9
On 17 July 2012 18:31, Peter Maydell wrote:
> We need to add a check somewhere that if we're not emulating
> an A15 then we either fail noisily or silently drop back to
> TCG. Then we should have an assert in here that env refers
> to an A15 I guess. [not yet figured out how to do that, I
> don't
On Tue, 17 Jul 2012, Anthony PERARD wrote:
> This patch add some calls to xen_modified_memory to notify Xen about dirtybits
> during migration.
>
> Signed-off-by: Anthony PERARD
> ---
> exec.c |4
> memory.c |2 ++
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git
I see now that this bug was already noticed, please ignore this mail
On 07/17/2012 09:34 PM, Igor Mitsyanko wrote:
After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are
executed with -Werror flag. Current ALSA configure test program invokes a
warning:
warning: ‘handle’
On Tue, 17 Jul 2012, Avi Kivity wrote:
> On 07/17/2012 04:30 PM, Anthony PERARD wrote:
> > This command is used during a migration of a guest under Xen. It calls
> > memory_global_dirty_log_start or memory_global_dirty_log_stop according to
> > the
> > argument pass to the command.
>
> Is the com
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/block-common.c | 40
hw/block-common.h |2 ++
hw/ide/core.c | 24
hw/ide/qdev.c | 19 ++-
hw/scsi-disk.c
From: Markus Armbruster
So far covers only IDE and tests only CMOS contents.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
tests/Makefile |2 +
tests/hd-geo-test.c | 403 +++
2 files changed, 405 insertions(+), 0 delet
On 17 July 2012 18:03, Jan Kiszka wrote:
> On 2012-07-17 18:41, Peter Maydell wrote:
>> Rather than hardcoding the list of architectures in the kernel
>> header update script, just import headers for every architecture
>> which supports KVM. This reduces the number of QEMU files which
>> need to b
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Signed-off-by: Kevin Wolf
---
hw/fdc.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/fdc.c b/hw/fdc.c
index 41191c7..08830c1 100644
--- a/hw/fdc.c
+++ b/hw/fdc.c
@@ -1802,7 +1802,7 @@ static void
fdctrl_hand
From: Markus Armbruster
Unless parameter ":floppy:" is given, vvfat creates a virtual image
with DOS MBR defining a single partition which holds the FAT file
system. The size of the virtual image depends on the width of the
FAT: 32 MiB (CHS 64, 16, 63) for 12 bit FAT, 504 MiB (CHS 1024, 16,
63)
From: Markus Armbruster
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
except it was put into block.c. Device-specific functionality should
be kept in device code, not the block layer. Move it to
hw/hd-geometry.c, and make stylistic changes required to keep
checkpatch.pl happ
From: Markus Armbruster
New limits straight from ATA4 6.2 Register delivered data transfer
command sector addressing.
I figure the old sector limit 63 was blindly copied from the BIOS
int 13 limit. Doesn't apply to the hardware. No idea where the old
cylinder limit comes from.
Signed-off-by:
From: Markus Armbruster
In particular, don't set disk type and geometry when a CD-ROM on bus
ide.0 has media during CMOS initialization.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/ide/qdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/id
From: Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbru
From: Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Do this only for ide-hd. ide-drive is legacy. ide-cd doesn't have a
g
After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are
executed with -Werror flag. Current ALSA configure test program invokes a
warning:
warning: ‘handle’ is used uninitialized in this function [-Wuninitialized]
which results in error with -Werror flag and, consequently,
Almost all callers of create_iovec() forgot to destroy the qiov when the
request has completed.
Signed-off-by: Kevin Wolf
Reviewed-by: Stefan Hajnoczi
---
qemu-io.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 5882067..8f3b94b 100644
--
The following changes since commit 83617103984eb4d81cf46c94435f3da2c6f33b55:
audio: Unbreak capturing in mixemu case (2012-07-16 18:08:36 +0400)
are available in the git repository at:
http://repo.or.cz/r/qemu/kevin.git for-anthony
Christoph Hellwig (1):
sheepdog: do not blindly memse
On 13 July 2012 04:37, Rusty Russell wrote:
> int kvm_arch_init_vcpu(CPUARMState *env)
> {
> -return 0;
> +struct kvm_sregs sregs;
> +
> +sregs.target = KVM_ARM_TARGET_CORTEX_A15;
> +sregs.num_features = 0;
We need to add a check somewhere that if we're not emulating
an A15 then
From: Pavel Hrdina
Signed-off-by: Pavel Hrdina
Signed-off-by: Kevin Wolf
---
tests/fdc-test.c | 46 +-
1 files changed, 41 insertions(+), 5 deletions(-)
diff --git a/tests/fdc-test.c b/tests/fdc-test.c
index 585fb0e..10d11a4 100644
--- a/tests/fdc
From: Markus Armbruster
Commit 5bbdbb46 moved it to block.c because "other geometry guessing
functions already reside in block.c". Device-specific functionality
should be kept in device code, not the block layer. Move it back.
Disk geometry guessing is still in block.c. To be moved out in a
l
From: Markus Armbruster
Best to use the same type, to avoid unwanted truncation or sign
extension.
BlockConf can't use plain int for cyls, heads and secs, because
integer properties require an exact width.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/block-common.h |
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/qdev-properties.c | 15 +++
hw/qdev.h|3 +++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 002c7f9..0b18f8
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/hd-geometry.c | 22 --
1 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 1a58894..fb849a3 100644
--- a/hw/hd-geometry.c
+++ b/
From: Markus Armbruster
PC BIOS setup needs IDE geometry information. Get it directly from
the device model rather than through the block layer. In preparation
of purging geometry from the block layer, which will happen later in
this series.
Signed-off-by: Markus Armbruster
Signed-off-by: Kev
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
tests/hd-geo-test.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index cc447a2..a47b945 100644
--- a/tests/hd-geo-test.c
+++ b/tests
From: Markus Armbruster
When hd_geometry_guess() picks a geometry, it also picks the
appropriate translation, but only when the prior translation hint is
BIOS_ATA_TRANSLATION_AUTO. Looks wrong, because such a prior
translation would be passed to the BIOS whether it's suitable for the
geometry or
From: MORITA Kazutaka
This reduces some code duplication.
Signed-off-by: MORITA Kazutaka
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 113 ++---
1 files changed, 47 insertions(+), 66 deletions(-)
diff --git a/block/sheepdog.c b/block/sheep
From: Markus Armbruster
hd_geometry_guess() picks geometry and translation. Callers can get
the geometry directly, via parameters, but for translation they need
to go through the block layer.
Add a parameter for translation, so it can optionally be gotten just
like geometry. In preparation of
Readability of the test code has suffered as the test case evolved. This
should improve it a bit again.
Signed-off-by: Kevin Wolf
---
tests/fdc-test.c | 36
1 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/tests/fdc-test.c b/tests/fdc-test.c
From: Markus Armbruster
Just code motion, with one long line wrapped to keep checkpatch.pl
happy.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/qdev-properties.c | 144 +-
1 files changed, 72 insertions(+), 72 deletions(-)
Hi,
I've been toying around with adding NVIDIA Tegra support to QEMU. While
adding SMP support I came across a problem: on Tegra, the secondary CPU
is kept in reset by the clock-and-reset controller (CRC). When bringing
up the secondary CPU, the OS writes a given register in the CRC to
release the
On 2012-07-17 18:41, Peter Maydell wrote:
> Rather than hardcoding the list of architectures in the kernel
> header update script, just import headers for every architecture
> which supports KVM. This reduces the number of QEMU files which
> need to be updated to add support for a new KVM architect
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/hd-geometry.c | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index db47846..1a58894 100644
--- a/hw/hd-geomet
valgrind tends to get confused and report false positives when you
switch stacks and don't tell it about it.
Signed-off-by: Kevin Wolf
Reviewed-by: Paolo Bonzini
---
configure| 20
coroutine-ucontext.c | 28
2 files changed, 48 i
Hi,
The qemu-1.1.1 release tarball[1] has file extention .tar.bz2 while the
real file format is gzip.
$ file Downloads/qemu-1.1.1.tar.bz2
Downloads/qemu-1.1.1.tar.bz2: gzip compressed data, from Unix, last
modified: Thu Jul 12 21:52:36 2012
Would it be possible to add a tarball which has a fil
From: Markus Armbruster
All current users (IDE, SCSI and virtio-blk) happen to share this 20
characters limit. Still, it should be left to device models. They
already enforce their limits. They have to, as the DriveInfo limit
only affects legacy -drive serial=..., not the qdev properties.
usb
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
block.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/block.h b/block.h
index 993894e..1cd8a01 100644
--- a/block.h
+++ b/block.h
@@ -426,6 +426,8 @@ typedef struct BlockCon
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
tests/hd-geo-test.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 5d9d2e4..9a31e85 100644
--- a/tests/hd-geo-t
check -valgrind wraps all qemu-io calls with valgrind. This makes it a
bit easier to debug problems that occur somewhere deep in a test case.
Signed-off-by: Kevin Wolf
Reviewed-by: Paolo Bonzini
---
tests/qemu-iotests/common| 11 +++
tests/qemu-iotests/common.rc | 10 ++
From: Markus Armbruster
This stuff doesn't belong to block layer, and was put there only
because a better home didn't exist then. Now it does.
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
block.h | 45 -
hw/block-commo
From: Markus Armbruster
Currently, it is split between hd_geometry_guess() and
pc_cmos_init_late(). Confusing. info qtree shows the result of the
former. Also confusing.
Fold the part done in pc_cmos_init_late() into hd_geometry_guess().
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Signed-off-by: Kevin Wolf
---
hw/Makefile.objs |2 +-
hw/block-common.c| 24
hw/block-common.h|3 +++
hw/ide/qdev.c| 12 ++--
hw/scsi-disk.c |8 +---
hw/usb/d
From: Christoph Hellwig
Only buffers that map to unallocated blocks need to be zeroed.
Signed-off-by: Christoph Hellwig
Acked-by: MORITA Kazutaka
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 37 ++---
1 files changed, 18 insertions(+), 19 deletions(-)
d
From: Markus Armbruster
There are two producers of these hints: drive_init() on behalf of
-drive, and hd_geometry_guess().
The only consumer of the hint is hd_geometry_guess().
The callers of hd_geometry_guess() call it only when drive_init()
didn't set the hints. Therefore, drive_init()'s hin
Rather than hardcoding the list of architectures in the kernel
header update script, just import headers for every architecture
which supports KVM. This reduces the number of QEMU files which
need to be updated to add support for a new KVM architecture.
It also means we won't break if the kernel dr
From: Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Do this only for scsi-hd. scsi-disk is legacy. scsi-cd doesn't have
a
From: Markus Armbruster
vvfat creates a virtual VFAT filesystem with a certain logical
geometry that depends on its options. It sets the "geometry hint" to
this geometry. It is the only block driver to do this.
The geometry hint is about about *physical* geometry, and used only by
certain hard
1 - 100 of 182 matches
Mail list logo
