Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API

2011-01-18 Thread Stefan Hajnoczi
On Tue, Jan 18, 2011 at 6:10 PM, Venkateswararao Jujjuri (JV) wrote: > On 1/17/2011 11:14 PM, Stefan Hajnoczi wrote: >> On Tue, Jan 18, 2011 at 6:46 AM, Arun R Bharadwaj >> wrote: >>> * Stefan Hajnoczi [2011-01-18 06:31:34]: >>> On Tue, Jan 18, 2011 at 4:43 AM, Arun R Bharadwaj wrote:

[Qemu-devel] [PATCH 16/19] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-01-18 Thread Yoshiaki Tamura
Introduce migrate_ft_trans_put_ready() which kicks the FT transaction cycle. When ft_mode is on, migrate_fd_put_ready() would open ft_trans_file and turn on event_tap. To end or cancel FT transaction, ft_mode and event_tap is turned off. migrate_ft_trans_get_ready() is called to receive ack from

[Qemu-devel] [PATCH 00/19] Kemari for KVM v0.2.6

2011-01-18 Thread Yoshiaki Tamura
Hi, This patch series is a revised version of Kemari for KVM, which applied comments for the previous post. The current code is based on qemu.git d03d11260ee2d55579e8b76116e35ccdf5031833. The changes from v0.2.5 -> v0.2.6 are: - use qemu_{put,get}_be32() to save/load niov in event-tap The chan

[Qemu-devel] [PATCH 07/19] Introduce fault tolerant VM transaction QEMUFile and ft_mode.

2011-01-18 Thread Yoshiaki Tamura
This code implements VM transaction protocol. Like buffered_file, it sits between savevm and migration layer. With this architecture, VM transaction protocol is implemented mostly independent from other existing code. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.objs

[Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState.

2011-01-18 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Signed-off-by: Yoshiaki Tamura --- migration-tcp.c | 15 +++ migration.c | 13 + migration.h |3 +++ 3 files changed, 31 insertions(+), 0 d

[Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-18 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- Makefile.targe

[Qemu-devel] [PATCH 10/19] Call init handler of event-tap at main() in vl.c.

2011-01-18 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- vl.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 8bbb785..9faeb27 100644 --- a/vl.c +++ b/vl.c @@ -162,6 +162,7 @@ int main(int argc, char **argv) #include "qemu-queue.h" #include "cpus.h" #include "arch_init.h

[Qemu-devel] [PATCH 11/19] ioport: insert event_tap_ioport() to ioport_write().

2011-01-18 Thread Yoshiaki Tamura
Record ioport event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- ioport.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index aa4188a..74aebf5 100644 --- a/ioport.c +++ b/ioport.c @@ -27,6 +27,7 @@ #include "ioport.h" #include

[Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-01-18 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index 163a683..a506688 100644 --- a/hw/

[Qemu-devel] [PATCH 17/19] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled.

2011-01-18 Thread Yoshiaki Tamura
When ft_mode is set in the header, tcp_accept_incoming_migration() sets ft_trans_incoming() as a callback, and call qemu_file_get_notify() to receive FT transaction iteratively. We also need a hack no to close fd before moving to ft_transaction mode, so that we can reuse the fd for it. vm_change_

[Qemu-devel] [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.

2011-01-18 Thread Yoshiaki Tamura
The option looks like, -incoming ::,ft_mode Signed-off-by: Yoshiaki Tamura --- migration.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/migration.c b/migration.c index 11bbdf8..7275f02 100644 --- a/migration.c +++ b/migration.c @@ -45,6 +45,12 @@ int qemu_start_i

[Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-01-18 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura --- hw/hw.h |5 ++ savevm.c | 149 ++ 2 files changed, 154 insertions(+), 0 deletions(-) diff --git a/hw/hw.h b/hw/hw.h ind

[Qemu-devel] [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2011-01-18 Thread Yoshiaki Tamura
When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed-off-by: Yoshiaki Tamura --- hmp-commands.hx |7 --- migration.c |4 qmp-commands.hx |7 --- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/h

[Qemu-devel] [PATCH 04/19] qemu-char: export socket_set_nodelay().

2011-01-18 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index edc9ad6..737d347 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2116,7 +2116,7 @@ static void tcp_chr_telnet_init(int

[Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-18 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura --- block.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index ff2795b..85bd8b8 100644 --- a/block.c +++ b/block.c @@

[Qemu-devel] [PATCH 05/19] vl.c: add deleted flag for deleting the handler.

2011-01-18 Thread Yoshiaki Tamura
Make deleting handlers robust against deletion of any elements in a handler by using a deleted flag like in file descriptors. Signed-off-by: Yoshiaki Tamura --- vl.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 0292184..8bbb785 100644 ---

[Qemu-devel] [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-01-18 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index 49c28b1..4a171cc 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7 @@ #include "osdep.h" #include "kvm.h

[Qemu-devel] [PATCH 06/19] virtio: decrement last_avail_idx with inuse before saving.

2011-01-18 Thread Yoshiaki Tamura
For regular migration inuse == 0 always as requests are flushed before save. However, event-tap log when enabled introduces an extra queue for requests which is not being flushed, thus the last inuse requests are left in the event-tap queue. Move the last_avail_idx value sent to the remote back to

[Qemu-devel] [PATCH 03/19] Introduce skip_header parameter to qemu_loadvm_state().

2011-01-18 Thread Yoshiaki Tamura
Introduce skip_header parameter to qemu_loadvm_state() so that it can be called iteratively without reading the header. Signed-off-by: Yoshiaki Tamura --- migration.c |2 +- savevm.c| 24 +--- sysemu.h|2 +- 3 files changed, 15 insertions(+), 13 deletions(-)

[Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-01-18 Thread Yoshiaki Tamura
Introduce qemu_savevm_state_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. Signed-off-by: Yoshiaki Tamura --- savevm.c | 93 ++ sysemu.h |2 + 2 files changed, 95 inser

[Qemu-devel] [PATCH 13/19] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async().

2011-01-18 Thread Yoshiaki Tamura
event-tap function is called only when it is on. Signed-off-by: Yoshiaki Tamura --- net.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index 9ba5be2..1176124 100644 --- a/net.c +++ b/net.c @@ -36,6 +36,7 @@ #include "qemu-common.h" #include "qe

Re: [Qemu-devel] unknown keycodes

2011-01-18 Thread Anthony Liguori
On 01/18/2011 07:22 PM, Henry Grebler wrote: qemu -cdrom /dev/acd1 -hda kwinxp.img -m 512 -boot d -localtime unknown keycodes `sun(type6_usb)_aliases(qwerty)', please report to qemu-devel@nongnu.org Thanks, you can work around this by using -k en-us. Regards, Anthony Liguori

[Qemu-devel] unknown keycodes

2011-01-18 Thread Henry Grebler
qemu -cdrom /dev/acd1 -hda kwinxp.img -m 512 -boot d -localtime unknown keycodes `sun(type6_usb)_aliases(qwerty)', please report to qemu-devel@nongnu.org uname -a FreeBSD freew.t-s-f.com.au 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Sat Nov 21 15:48:17 UTC 2009 r...@almeida.cse.bu

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-18 Thread Jamie Lokier
Chunqiang Tang wrote: > > Based on my limited understanding, I think FVD shares a > > lot in common with the COW format (block/cow.c). > > > > But I think most of the advantages you mention could be considered as > > additions to either qcow2 or qed. At any rate, the right way to have > > that

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-18 Thread Jamie Lokier
Chunqiang Tang wrote: > Doing both fault injection and verification together introduces some > subtlety. For example, even under the random failure mode, two disk writes > triggered by one VM-issued write must either fail together or succeed > together. Otherwise, the truth image and the test im

Re: [Qemu-devel] [sparc] Floating point exception issue

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 6:00 PM, Mateusz Loskot wrote: > On 18/01/11 17:36, Blue Swirl wrote: >> >> On Tue, Jan 18, 2011 at 3:27 PM, Mateusz Loskot >>  wrote: >>> >>> Hi, >>> >>> Recently, I have reported mysterious issues on NetBSD 5.1 >>> emulated on SPARC. The whole first thread is here: >>> >>

[Qemu-devel] [PATCH 2/2] prep: Disable second IDE channel, as long as ISA IDE emulation doesn't support same irq for both channels

2011-01-18 Thread Hervé Poussineau
Cc: Andreas Färber Signed-off-by: Hervé Poussineau --- hw/ppc_prep.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c index 6b22122..6c1499a 100644 --- a/hw/ppc_prep.c +++ b/hw/ppc_prep.c @@ -690,7 +690,7 @@ static void ppc_prep_init (ram_ad

[Qemu-devel] [PATCH 1/2] prep: Remove bogus BIOS size check

2011-01-18 Thread Hervé Poussineau
From: Andreas Färber r3480 added this check to account for the entry vector 0xfff00100 to be available for CPUs that need it. Today however, the NIP is not yet initialized at this point (zero), so the check always triggers. Moreover, BIOS size check is already done previously, so this part can b

[Qemu-devel] [PATCH] pcibus_get_dev_path: correct pci device path construction

2011-01-18 Thread Igor V. Kovalenko
From: Igor V. Kovalenko - fix snprintf off by one pci domain and slot number formatting snprintf calls require extra space for trailing null character without this change devices are assigned the same path name which triggers assertion in vmstate_register_with_alias_id - while iterating

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
On 01/18/2011 02:36 PM, Jes Sorensen wrote: On 01/18/11 21:30, Anthony Liguori wrote: On 01/18/2011 10:53 AM, Eric Blake wrote: On 01/18/2011 09:50 AM, Anthony Liguori wrote: @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, const char default_suffix

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Jes Sorensen
On 01/18/11 21:30, Anthony Liguori wrote: > On 01/18/2011 10:53 AM, Eric Blake wrote: >> On 01/18/2011 09:50 AM, Anthony Liguori wrote: >> > @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char > **end, const char default_suffix) >} >} >

Re: [Qemu-devel] [RFC] Propose the Fast Virtual Disk (FVD) image format that outperforms QCOW2 by 249%

2011-01-18 Thread Chunqiang Tang
> > Here are the unique features you've described beyond what qemu-io, > > blkdebug, and blkverify do: > > > > 1. New functionality > > * Control over ordering of I/O request submission and completion. > > * Random I/O generator (probably as new qemu-io command). > > > > 2. Enhancements to existi

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:53 AM, Eric Blake wrote: On 01/18/2011 09:50 AM, Anthony Liguori wrote: @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, const char default_suffix) } } switch (toupper(d)) { BTW, a useful change would be to accept

[Qemu-devel] [RFC PATCH] Fake machine for scalability testing

2011-01-18 Thread Markus Armbruster
The problem: you want to do serious scalability testing (1000s of VMs) of your management stack. If each guest eats up a few 100MiB and competes for CPU, that requires a serious host machine. Which you don't have. You also don't want to modify the management stack at all, if you can help it. Th

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-18 Thread Alexander Graf
On 17.01.2011, at 08:48, Gerd Hoffmann wrote: >>> There are three cases: >>> >>> (1) no pressure supported (i.e. your mouse moving around in the vnc >>> window and qemu reporting this as tablet coordinates). >>> (2) just pen/finger present/not present supported. pressure jumps >>> between 0 and

[Qemu-devel] Re: [PATCH V2 1/3] Introduce log_start/log_stop in CPUPhysMemoryClient

2011-01-18 Thread Jan Kiszka
Send patch updates always with proper "[PATCH]" tag, they may get lost otherwise. On 2011-01-18 13:25, anthony.per...@citrix.com wrote: > From: Anthony PERARD > > In order to use log_start/log_stop with Xen as well in the vga code, > this two operations have been put in CPUPhysMemoryClient. > >

Re: [Qemu-devel] [PATCH] linux-user: Fix possible realloc memory leak

2011-01-18 Thread Peter Maydell
On 18 January 2011 17:51, Markus Armbruster wrote: > Stefan Weil writes: >> Am 18.01.2011 09:26, schrieb Markus Armbruster: >>> Stefan Weil writes: Extract from "man realloc": "If realloc() fails the original block is left untouched; it is not freed or moved." >>> Sidestep the pr

Re: [Qemu-devel] Changing the content of target cpu registers

2011-01-18 Thread Stefano Bonifazi
On 01/18/2011 06:17 PM, Blue Swirl wrote: On Tue, Jan 18, 2011 at 9:29 AM, Stefano Bonifazi wrote: Hi all! I am working on qemu-user (qemu-ppc). I'd like to edit the values of target registers during the execution. Can I do that by simply changing the content of env->gpr[] or do these only c

Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API

2011-01-18 Thread Venkateswararao Jujjuri (JV)
On 1/17/2011 11:14 PM, Stefan Hajnoczi wrote: > On Tue, Jan 18, 2011 at 6:46 AM, Arun R Bharadwaj > wrote: >> * Stefan Hajnoczi [2011-01-18 06:31:34]: >> >>> On Tue, Jan 18, 2011 at 4:43 AM, Arun R Bharadwaj >>> wrote: * Stefan Hajnoczi [2011-01-17 09:56:58]: > On Thu, Jan 13, 201

Re: [Qemu-devel] [PATCH] linux-user: Fix possible realloc memory leak

2011-01-18 Thread Stefan Weil
Am 18.01.2011 18:51, schrieb Markus Armbruster: Stefan Weil writes: Am 18.01.2011 09:26, schrieb Markus Armbruster: Stefan Weil writes: Extract from "man realloc": "If realloc() fails the original block is left untouched; it is not freed or moved." Fix a possible memory

Re: [Qemu-devel] [sparc] Floating point exception issue

2011-01-18 Thread Mateusz Loskot
On 18/01/11 17:36, Blue Swirl wrote: On Tue, Jan 18, 2011 at 3:27 PM, Mateusz Loskot wrote: Hi, Recently, I have reported mysterious issues on NetBSD 5.1 emulated on SPARC. The whole first thread is here: http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg01509.html I decided to investi

Re: [Qemu-devel] Re: Fwd: Re: port-sparc/44389: awk failure during m4 installation with pkgsrc

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 11:40 AM, Mateusz Loskot wrote: > Blue Swirl gmail.com> writes: >> Mateusz Loskot loskot.net> wrote: >> > Hi, >> > >> > I emulate SPARC with NetBSD 5.0 installed and I've experienced a problem >> > with pkgsrc installing one of packages. >> > I submitted bug report to Net

Re: [Qemu-devel] [PATCH] linux-user: Fix possible realloc memory leak

2011-01-18 Thread Markus Armbruster
Stefan Weil writes: > Am 18.01.2011 09:26, schrieb Markus Armbruster: >> Stefan Weil writes: >> >>> Extract from "man realloc": >>> "If realloc() fails the original block is left untouched; >>> it is not freed or moved." >>> >>> Fix a possible memory leak (reported by cppcheck). >>> >>> Cc: Riku

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 18:31, Anthony Liguori wrote: >>> It's automatically created as part of the CPUs or as part of the >>> chipset. How to enable/disable kvm assistance is a property of the CPU >>> and/or chipset. >>> >> If we exclude creation via command line / config files, we could also >> pass

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Alex Williamson
On Tue, 2011-01-18 at 18:08 +0100, Jan Kiszka wrote: > On 2011-01-18 18:02, Alex Williamson wrote: > > On Tue, 2011-01-18 at 16:54 +0100, Jan Kiszka wrote: > >> On 2011-01-18 16:48, Anthony Liguori wrote: > >>> On 01/18/2011 09:43 AM, Jan Kiszka wrote: > On 2011-01-18 16:04, Anthony Liguori wr

Re: [Qemu-devel] [sparc] Floating point exception issue

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 3:27 PM, Mateusz Loskot wrote: > Hi, > > Recently, I have reported mysterious issues on NetBSD 5.1 > emulated on SPARC. The whole first thread is here: > > http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg01509.html > > I decided to investigate the problem deeper and

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 11:20 AM, Jan Kiszka wrote: Which only works as along as we expose a single bus. You don't need to be an oracle to predict that this is not a stable interface. Today we only have a very low level factory interface--device creation and deletion. I think we should move to hi

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
On 18.01.2011 16:36, Peter Maydell wrote: > Incidentally there are some correctness fixes for the multiply-by-scalar > neon insns from the qemu-meego tree which are on my list to push > upstream. So you probably aren't getting the right results even if > you've managed to shut up qemu's warnings :-

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Peter Maydell
On 18 January 2011 17:00, Christophe Lyon wrote: > On 18.01.2011 16:36, Peter Maydell wrote: >> Incidentally there are some correctness fixes for the multiply-by-scalar >> neon insns from the qemu-meego tree which are on my list to push >> upstream. So you probably aren't getting the right results

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 18:09, Anthony Liguori wrote: > On 01/18/2011 10:56 AM, Jan Kiszka wrote: >> >>> The device model topology is 100% a hidden architectural detail. >>> >> This is true for the sysbus, it is obviously not the case for PCI and >> similarly discoverable buses. There we have a guest-e

Re: [Qemu-devel] Changing the content of target cpu registers

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 9:29 AM, Stefano Bonifazi wrote: > Hi all! >  I am working on qemu-user (qemu-ppc). > I'd like to edit the values of target registers during the execution. Can I > do that by simply changing the content of env->gpr[] or do these only > contain a copy of the values of the re

Re: [Qemu-devel] [PATCH] linux-user: Fix possible realloc memory leak

2011-01-18 Thread Stefan Weil
Am 18.01.2011 09:26, schrieb Markus Armbruster: Stefan Weil writes: Extract from "man realloc": "If realloc() fails the original block is left untouched; it is not freed or moved." Fix a possible memory leak (reported by cppcheck). Cc: Riku Voipio Signed-off-by: Stefan Weil Sidestep the

Re: [Qemu-devel] [V3 PATCH 6/8] virtio-9p: Support for creating special files

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 6:26 AM, M. Mohan Kumar wrote: > Add both server and client side interfaces to create special files > (directory, device nodes, links and symbolic links) > > Signed-off-by: M. Mohan Kumar > --- >  hw/9pfs/virtio-9p-chroot.c |   84 ++- >  hw/9pfs/vir

Re: [Qemu-devel] [V3 PATCH 5/8] virtio-9p: Create support in chroot environment

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 6:25 AM, M. Mohan Kumar wrote: > Add both server & client side interfaces to create regular files in > chroot environment > > Signed-off-by: M. Mohan Kumar > --- >  hw/9pfs/virtio-9p-chroot.c |   42 ++ >  hw/9pfs/virtio-9p-local.c  |

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:56 AM, Jan Kiszka wrote: The device model topology is 100% a hidden architectural detail. This is true for the sysbus, it is obviously not the case for PCI and similarly discoverable buses. There we have a guest-explorable topology that is currently equivalent to the the

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 18:02, Alex Williamson wrote: > On Tue, 2011-01-18 at 16:54 +0100, Jan Kiszka wrote: >> On 2011-01-18 16:48, Anthony Liguori wrote: >>> On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: > On 01/18/2011 08:28 AM, Jan Kiszka wrote: >

Re: [Qemu-devel] [V3 PATCH 2/8] virtio-9p: Provide chroot environment server side interfaces

2011-01-18 Thread Blue Swirl
On Tue, Jan 18, 2011 at 6:25 AM, M. Mohan Kumar wrote: > Implement chroot server side interfaces like sending the file > descriptor to qemu process, reading the object request from socket etc. > Also add chroot main function and other helper routines. > > Signed-off-by: M. Mohan Kumar > --- >  Ma

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
On 18.01.2011 16:26, Peter Maydell wrote: > On 18 January 2011 14:34, Christophe Lyon wrote: >> + >> +/* gen_helper_neon_mull_[su]{8|16} do not free their parameters. >> + Don't forget to clean them now. */ >> +switch ((size << 1) | u) { >> +case 0: >> +case 1: >> +case

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Alex Williamson
On Tue, 2011-01-18 at 16:54 +0100, Jan Kiszka wrote: > On 2011-01-18 16:48, Anthony Liguori wrote: > > On 01/18/2011 09:43 AM, Jan Kiszka wrote: > >> On 2011-01-18 16:04, Anthony Liguori wrote: > >> > >>> On 01/18/2011 08:28 AM, Jan Kiszka wrote: > >>> > On 2011-01-12 11:31, Jan Kisz

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 17:37, Anthony Liguori wrote: > On 01/18/2011 10:17 AM, Jan Kiszka wrote: >> On 2011-01-18 17:04, Anthony Liguori wrote: >> >>> A KVM device should sit on a KVM specific bus that hangs off of >>> sysbus. >>> It can get to kvm_state through that bus. >>> >>> Tha

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Eric Blake
On 01/18/2011 09:50 AM, Anthony Liguori wrote: >>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char >>> **end, const char default_suffix) >>> } >>> } >>> switch (toupper(d)) { > BTW, a useful change would be to accept both upper and lower case letters. And

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Jes Sorensen
On 01/18/11 17:50, Anthony Liguori wrote: > On 01/18/2011 03:20 AM, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >> >> >>> From: Jes Sorensen >>> >>> Signed-off-by: Jes Sorensen >>> --- >>> cutils.c | 10 +- >>> 1 files changed, 5 insertions(+), 5 deletions(-) >>> >>>

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
On 01/18/2011 03:20 AM, Markus Armbruster wrote: jes.soren...@redhat.com writes: From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cutils.c b/cutils.c index 328738c..f2c8bbd 100644 --- a/cutils.c

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:17 AM, Jan Kiszka wrote: On 2011-01-18 17:04, Anthony Liguori wrote: A KVM device should sit on a KVM specific bus that hangs off of sysbus. It can get to kvm_state through that bus. That bus doesn't get instantiated through qdev so requiring a pointer argument should not b

[Qemu-devel] [PATCH] pxa2xx_lcd: restore updating of display

2011-01-18 Thread Dmitry Eremin-Solenikov
Recently PXA2xx lcd have stopped to be updated incrementally (picture frozen). This patch fixes that by passing non min/max x/y, but rather (correctly) x/y and w/h. Signed-off-by: Dmitry Eremin-Solenikov --- hw/pxa2xx_lcd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 17:04, Anthony Liguori wrote: > A KVM device should sit on a KVM specific bus that hangs off of > sysbus. > It can get to kvm_state through that bus. > > That bus doesn't get instantiated through qdev so requiring a pointer > argument should not be an issue. >>

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:01 AM, Jan Kiszka wrote: On 2011-01-18 16:50, Anthony Liguori wrote: On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote:

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 16:50, Anthony Liguori wrote: > On 01/18/2011 09:43 AM, Jan Kiszka wrote: >> On 2011-01-18 16:04, Anthony Liguori wrote: >> >>> On 01/18/2011 08:28 AM, Jan Kiszka wrote: >>> On 2011-01-12 11:31, Jan Kiszka wrote: > Am 12.01.2011 11:22, Avi Kivity w

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 16:48, Anthony Liguori wrote: > On 01/18/2011 09:43 AM, Jan Kiszka wrote: >> On 2011-01-18 16:04, Anthony Liguori wrote: >> >>> On 01/18/2011 08:28 AM, Jan Kiszka wrote: >>> On 2011-01-12 11:31, Jan Kiszka wrote: > Am 12.01.2011 11:22, Avi Kivity w

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 09:43 AM, Jan Kiszka wrote: On 2011-01-18 16:04, Anthony Liguori wrote: On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-18 16:04, Anthony Liguori wrote: > On 01/18/2011 08:28 AM, Jan Kiszka wrote: >> On 2011-01-12 11:31, Jan Kiszka wrote: >> >>> Am 12.01.2011 11:22, Avi Kivity wrote: >>> On 01/11/2011 03:54 PM, Anthony Liguori wrote: > Right, we should introduce a KVMBus th

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Peter Maydell
Incidentally there are some correctness fixes for the multiply-by-scalar neon insns from the qemu-meego tree which are on my list to push upstream. So you probably aren't getting the right results even if you've managed to shut up qemu's warnings :-) -- PMM

Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Peter Maydell
On 18 January 2011 14:34, Christophe Lyon wrote: > + > +    /* gen_helper_neon_mull_[su]{8|16} do not free their parameters. > +       Don't forget to clean them now.  */ > +    switch ((size << 1) | u) { > +    case 0: > +    case 1: > +    case 2: > +    case 3: > +      dead_tmp(a); > +      de

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Alex Williamson
On Tue, 2011-01-18 at 10:20 +0100, Markus Armbruster wrote: > jes.soren...@redhat.com writes: > > > From: Jes Sorensen > > > > Signed-off-by: Jes Sorensen > > --- > > cutils.c | 10 +- > > 1 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/cutils.c b/cutils.c > > in

[Qemu-devel] [sparc] Floating point exception issue

2011-01-18 Thread Mateusz Loskot
Hi, Recently, I have reported mysterious issues on NetBSD 5.1 emulated on SPARC. The whole first thread is here: http://lists.gnu.org/archive/html/qemu-devel/2011-01/msg01509.html I decided to investigate the problem deeper and with great help from NetBSD folks, I managed to find reproducible t

Re: [Qemu-devel] paravirtual tablet v3

2011-01-18 Thread Anthony Liguori
On 01/18/2011 07:46 AM, Gerd Hoffmann wrote: Hi, Sure, someone needs to map multitouch to non-multitouch. I'd leave that job to the guest driver tough. Why do you think doing it in the host is better? My assumptions are 1) the host is capable of doing the mapping just as easily as the guest

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Anthony Liguori
On 01/18/2011 08:28 AM, Jan Kiszka wrote: On 2011-01-12 11:31, Jan Kiszka wrote: Am 12.01.2011 11:22, Avi Kivity wrote: On 01/11/2011 03:54 PM, Anthony Liguori wrote: Right, we should introduce a KVMBus that KVM devices are created on. The devices can get at KVMState through

[Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

2011-01-18 Thread Christophe Lyon
Fix garbage collection of temporaries in Neon emulation. Signed-off-by: Christophe Lyon --- target-arm/translate.c | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 57664bc..363351e 100644 --- a/t

[Qemu-devel] Re: KVM call agenda for Jan 18

2011-01-18 Thread Chris Wright
* Chris Wright (chr...@redhat.com) wrote: > Please send in any agenda items you are interested in covering. No agenda, this week's call is cancelled. thanks, -chris

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-18 Thread Jan Kiszka
On 2011-01-12 11:31, Jan Kiszka wrote: > Am 12.01.2011 11:22, Avi Kivity wrote: >> On 01/11/2011 03:54 PM, Anthony Liguori wrote: >>> >>> Right, we should introduce a KVMBus that KVM devices are created on. >>> The devices can get at KVMState through the BusState. >> >> There is no kvm bus in a PC

Re: [Qemu-devel] [PATCH] target-arm: Log instruction start in TCG code

2011-01-18 Thread Edgar E. Iglesias
On Tue, Jan 18, 2011 at 01:08:40PM +, Peter Maydell wrote: > Add support for logging the start of instructions in TCG > code debug dumps for ARM targets. > > Signed-off-by: Peter Maydell Applied, thanks. > --- > target-arm/translate.c |4 > 1 files changed, 4 insertions(+), 0 del

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-18 Thread Anthony Liguori
On 01/18/2011 05:56 AM, Amit Shah wrote: On (Mon) Jan 17 2011 [08:57:16], Anthony Liguori wrote: Also -- this patchset was prompted by a bug in qemu chardevs that freezes guests if they write faster than the chardevs can consume. What should the strategy on fixing that bug be? Fix t

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-01-18 Thread Anthony Liguori
On 01/18/2011 08:02 AM, Gerd Hoffmann wrote: On 01/17/11 15:53, Michael Roth wrote: On 01/17/2011 07:53 AM, Gerd Hoffmann wrote: What is your plan to handle system-level queries+actions (such as reboot) vs. per-user stuff (such as cut+paste)? This is an area that hasn't been well-defined yet

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-01-18 Thread Gerd Hoffmann
On 01/17/11 15:53, Michael Roth wrote: On 01/17/2011 07:53 AM, Gerd Hoffmann wrote: What is your plan to handle system-level queries+actions (such as reboot) vs. per-user stuff (such as cut+paste)? This is an area that hasn't been well-defined yet and is definitely open for suggestions. One

Re: [Qemu-devel] paravirtual tablet v3

2011-01-18 Thread Gerd Hoffmann
Hi, Sure, someone needs to map multitouch to non-multitouch. I'd leave that job to the guest driver tough. Why do you think doing it in the host is better? My assumptions are 1) the host is capable of doing the mapping just as easily as the guest Probably. 2) the host can do something us

[Qemu-devel] Re: [PATCH 6/8] ahci: make number of ports runtime determined

2011-01-18 Thread Kevin Wolf
Am 18.01.2011 13:46, schrieb Alexander Graf: > > On 18.01.2011, at 13:40, Kevin Wolf wrote: > >> Am 20.12.2010 22:13, schrieb Alexander Graf: >>> Different AHCI controllers have a different number of ports, so the core >>> shouldn't care about the amount of ports available. >>> >>> This patch mak

[Qemu-devel] Re: [PATCH 4/8] ahci: use qiov instead of dma helpers

2011-01-18 Thread Kevin Wolf
Am 18.01.2011 14:14, schrieb Stefan Hajnoczi: > On Tue, Jan 18, 2011 at 01:45:40PM +0100, Alexander Graf wrote: >> >> On 18.01.2011, at 13:35, Kevin Wolf wrote: >> >>> Am 20.12.2010 22:13, schrieb Alexander Graf: The DMA helpers incur additional overhead on data transfers. I'm not sure we

[Qemu-devel] [PATCH v2 3/3] usb-msd: Propagate removable bit to SCSI device

2011-01-18 Thread Stefan Hajnoczi
USB Mass Storage Devices sometimes have the RMB (removable) bit set in the SCSI INQUIRY response. Thumbdrives tend to have the bit set whereas hard disks do not. Operating systems differentiate between removable devices and fixed devices. Under Linux, the anaconda installer looks for removable d

Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices

2011-01-18 Thread Luiz Capitulino
On Tue, 18 Jan 2011 13:48:06 +0100 Christoph Hellwig wrote: > On Tue, Jan 18, 2011 at 10:35:39AM -0200, Luiz Capitulino wrote: > > Well, what happens is this: we screwed up with that interface and we > > should replace it soon. > > > > I see you're not adding the new command in QMP (only in the

[Qemu-devel] Re: [PATCH 4/8] ahci: use qiov instead of dma helpers

2011-01-18 Thread Stefan Hajnoczi
On Tue, Jan 18, 2011 at 01:45:40PM +0100, Alexander Graf wrote: > > On 18.01.2011, at 13:35, Kevin Wolf wrote: > > > Am 20.12.2010 22:13, schrieb Alexander Graf: > >> The DMA helpers incur additional overhead on data transfers. I'm not > >> sure we need the additional complexity provided by them.

Re: [Qemu-devel] Re: [PATCH 6/8] ahci: make number of ports runtime determined

2011-01-18 Thread Gerd Hoffmann
Hi, diff --git a/hw/ide/ich.c b/hw/ide/ich.c index 70cb766..f242d7a 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -100,7 +100,7 @@ static int pci_ich9_ahci_init(PCIDevice *dev) msi_init(dev, 0x50, 1, true, false); -ahci_init(&d->ahci,&dev->qdev); +ahci_init(&d->ahci,&dev->qde

[Qemu-devel] [PATCH] target-arm: Log instruction start in TCG code

2011-01-18 Thread Peter Maydell
Add support for logging the start of instructions in TCG code debug dumps for ARM targets. Signed-off-by: Peter Maydell --- target-arm/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 907d73a..c60cd18 10

Re: [Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Gerd Hoffmann
Hi, edge triggered interrupts wouldn't though. The code change doesn't change anything for edge triggered interrupts - they work fine. Only !msi (== level) ones are broken. apic irqs can be both edge and level triggered too ... That re-trigger smells like you are not clearing the interru

[Qemu-devel] Re: [PATCH 8/8] ahci: fix !msi interrupts

2011-01-18 Thread Jan Kiszka
On 2011-01-18 13:05, Alexander Graf wrote: > > On 18.01.2011, at 10:08, Gerd Hoffmann wrote: > >> Hi, >> Worse might also be that unknown issue that force you to inject an IRQ here. We don't know. That's probably worst. >>> >>> Well, IIRC the issue was that usually a level high interru

Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices

2011-01-18 Thread Christoph Hellwig
On Tue, Jan 18, 2011 at 10:35:39AM -0200, Luiz Capitulino wrote: > Well, what happens is this: we screwed up with that interface and we > should replace it soon. > > I see you're not adding the new command in QMP (only in the human monitor), > is that intentional? (qmp commands are added to the qm

[Qemu-devel] Re: [PATCH 6/8] ahci: make number of ports runtime determined

2011-01-18 Thread Alexander Graf
On 18.01.2011, at 13:40, Kevin Wolf wrote: > Am 20.12.2010 22:13, schrieb Alexander Graf: >> Different AHCI controllers have a different number of ports, so the core >> shouldn't care about the amount of ports available. >> >> This patch makes the number of ports available to the AHCI core runti

[Qemu-devel] Re: [PATCH 4/8] ahci: use qiov instead of dma helpers

2011-01-18 Thread Alexander Graf
On 18.01.2011, at 13:35, Kevin Wolf wrote: > Am 20.12.2010 22:13, schrieb Alexander Graf: >> The DMA helpers incur additional overhead on data transfers. I'm not >> sure we need the additional complexity provided by them. So let's just >> use qiovs directly when running in the fast path (ncq). >>

[Qemu-devel] Re: [PATCH 3/8] ahci: send init d2h fis on fis enable

2011-01-18 Thread Alexander Graf
On 18.01.2011, at 13:25, Kevin Wolf wrote: > Am 20.12.2010 22:13, schrieb Alexander Graf: >> The drive sends a d2h init fis on initialization. Usually, the guest doesn't >> receive fises yet at that point though, so the delivery is deferred. >> >> Let's reflect that by sending the init fis on fi

[Qemu-devel] Re: [PATCH 7/8] ahci: free dynamically allocated iovs

2011-01-18 Thread Kevin Wolf
Am 20.12.2010 22:13, schrieb Alexander Graf: > We allocate iovs on the fly now, but also need to free them on uninit. > This patch does that. > > Signed-off-by: Alexander Graf Isn't this a fix for patch 4? If so, please merge it there. Kevin

  1   2   >