On 01/18/11 17:50, Anthony Liguori wrote:
> On 01/18/2011 03:20 AM, Markus Armbruster wrote:
>> jes.soren...@redhat.com writes:
>>
>>
>>> From: Jes Sorensen<jes.soren...@redhat.com>
>>>
>>> Signed-off-by: Jes Sorensen<jes.soren...@redhat.com>
>>> ---
>>> cutils.c | 10 +++++-----
>>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/cutils.c b/cutils.c
>>> index 328738c..f2c8bbd 100644
>>> --- a/cutils.c
>>> +++ b/cutils.c
>>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char
>>> **end, const char default_suffix)
>>> }
>>> }
>>> switch (toupper(d)) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>>
>> And this improves what? Certainly not clarity.
>>
>> In my opinion, the STRTOSZ_DEFSUFFIX_TB are useless chaff. Chacun à son
>> goût.
>>
>
> Yeah, I have to agree. I'm not of the literals are evil camp.
>
> BTW, a useful change would be to accept both upper and lower case letters.
It already supports both, it's handle in the toupper() call.
Cheers,
Jes
