Re: [Qemu-devel] [PATCH] Megasas HBA emulation and SCSI update v.2

2010-12-01 Thread Hannes Reinecke
On 12/02/2010 01:14 AM, Nicholas A. Bellinger wrote: > On Wed, 2010-12-01 at 16:46 +0100, Hannes Reinecke wrote: >> On 12/01/2010 03:18 PM, Hannes Reinecke wrote: >>> Hey Nic, >>> >>> On 11/24/2010 10:41 AM, Nicholas A. Bellinger wrote: On Mon, 2010-11-22 at 11:34 +0100, Hannes Reinecke wrote:

[Qemu-devel] Re: [PATCHv6 00/16] boot order specification

2010-12-01 Thread Kevin O'Connor
On Wed, Dec 01, 2010 at 02:27:40PM +0200, Gleb Natapov wrote: > On Tue, Nov 30, 2010 at 09:53:32PM -0500, Kevin O'Connor wrote: > > BTW, what's the plan for handling SCSI adapters? Lets say a user has > > a scsi card with three drives (lun 1, lun 3, lun 5) that show up as 3 > > bcvs (lun1, lun3, l

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-12-01 Thread Imre Gergely
I can confirm the segfault with the same Fedora 1 install. It doesn't even get to 50%, it segfaults way earlier. In fact I tried this: - kvm-img create -f qcow2 /store/KVM/test.qcow2 2G - gi...@voy:~$ sudo LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/sn:/sbin:/bin QEMU_AUDIO_DRV=no

[Qemu-devel] Re: [PATCH 09/10] Exit loop if we have been there too long

2010-12-01 Thread Takuya Yoshikawa
Thanks for the answers Avi, Juan, Some FYI, (not about the bottleneck) On Wed, 01 Dec 2010 14:35:57 +0200 Avi Kivity wrote: > > > - how many dirty pages do we have to care? > > > > default values and assuming 1Gigabit ethernet for ourselves ~9.5MB of > > dirty pages to have only 30ms of downt

Re: [Qemu-devel] [PATCH] Megasas HBA emulation and SCSI update v.2

2010-12-01 Thread Nicholas A. Bellinger
On Wed, 2010-12-01 at 16:46 +0100, Hannes Reinecke wrote: > On 12/01/2010 03:18 PM, Hannes Reinecke wrote: > > Hey Nic, > > > > On 11/24/2010 10:41 AM, Nicholas A. Bellinger wrote: > >> On Mon, 2010-11-22 at 11:34 +0100, Hannes Reinecke wrote: > > [ .. ] > >> > >> Hey Hannes, > >> > >> Just a head

Re: [Qemu-devel] [PATCH V8 00/16] Xen device model support

2010-12-01 Thread Alexander Graf
On 02.12.2010, at 00:40, Alexander Graf wrote: > > On 01.12.2010, at 18:39, anthony.per...@citrix.com wrote: > >> From: Anthony PERARD >> >> Hi all, >> >> Here is the V8 of the patch series that adds Xen device model support in >> QEMU. >> >> The change mades on it since the v7: >> - Move

Re: [Qemu-devel] [PATCH V8 00/16] Xen device model support

2010-12-01 Thread Alexander Graf
On 01.12.2010, at 18:39, anthony.per...@citrix.com wrote: > From: Anthony PERARD > > Hi all, > > Here is the V8 of the patch series that adds Xen device model support in QEMU. > > The change mades on it since the v7: > - Move build of all xen object to x86 target only since Xen work only for

[Qemu-devel] Re: [patch 3/3] UHCI: Substate section for migration of remote wakeup feature

2010-12-01 Thread Marcelo Tosatti
On Wed, Dec 01, 2010 at 08:14:22PM +0100, Juan Quintela wrote: > Gerd Hoffmann wrote: > > On 12/01/10 17:47, Marcelo Tosatti wrote: > >> Use a subsection to migrate remote wakeup feature only when used by the > >> guest. > > > > Yea, right, this must be saved. But certainly not by the UHCI > > a

[Qemu-devel] Re: [PATCH 00/12] AHCI emulation support v4

2010-12-01 Thread Alexander Graf
On 24.11.2010, at 12:44, Gerd Hoffmann wrote: > On 11/23/10 15:34, Alexander Graf wrote: >> This patch adds support for AHCI emulation. I have tested and verified it >> works >> in Linux, OpenBSD, Windows Vista and Windows 7. > > Also seabios ;) > http://cgit.freedesktop.org/~kraxel/seabios/log

[Qemu-devel] Re: [PULL] More format checking

2010-12-01 Thread Stefan Weil
Am 24.11.2010 22:46, schrieb Stefan Weil: Hello, with these patches, hopefully all functions with printf like arguments use gcc's format checking, so the TODO comment in HACKING can be removed. The patch series was tested with a default build configuration on linux and windows hosts (including

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-12-01 Thread Stefan Hajnoczi
On Wed, Dec 1, 2010 at 12:30 PM, Avi Kivity wrote: > On 12/01/2010 01:44 PM, Stefan Hajnoczi wrote: >> >> >> >> >>  And, what about efficiency?  As in bits/cycle? >> > >> >  We are running benchmarks with this latest patch and will report >> > results. >> >> Full results here (thanks to Khoa Huynh

Re: locking for TCG (was: Re: [Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext))

2010-12-01 Thread Jan-Simon Möller
Am Mittwoch, 1. Dezember 2010, 20:40:37 schrieb Peter Maydell: > On 28 November 2010 11:24, Peter Maydell wrote: > > 2010/11/28 Brian Harring : > >> Additional note... it *looks* like the deadlock potential is there > >> already in 0.13, it's just heavily exacerbated by this patch- out of > >> abo

Re: [Qemu-devel] [PATCH] Convert fprintf() to error_request(): virtio-9p

2010-12-01 Thread Stefan Hajnoczi
On Wed, Dec 1, 2010 at 6:01 PM, Venkateswararao Jujjuri (JV) wrote: > On 12/1/2010 1:35 AM, Stefan Hajnoczi wrote: >> On Tue, Nov 30, 2010 at 9:52 AM, Sanchit Garg >> wrote: >>> @@ -3707,19 +3708,19 @@ VirtIODevice *virtio_9p_init(DeviceState *dev, >>> V9fsConf *conf) >>>         s->ctx.fs_sm =

[Qemu-devel] [PATCH 04/10] ide: add DMA hooks to bus ops

2010-12-01 Thread Alexander Graf
For DMA operations, we need to hook into even more IDE functionality. This patch adds the respective hooking points, allowing us to handle SG lists ourselves in the AHCI code. Signed-off-by: Roland Elek Signed-off-by: Alexander Graf --- v1 -> v2: - make dma hooks explicit by putting them i

[Qemu-devel] [PATCH 00/10] AHCI emulation support v7

2010-12-01 Thread Alexander Graf
This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7. This AHCI emulation supports NCQ, so multiple read or write requests can be outstanding at the same time. The code is however not fully optimized yet. I'm fairly sure tha

[Qemu-devel] [PATCH] Remove unused spin_trylock() function

2010-12-01 Thread Peter Maydell
Remove the spin_trylock() function, as it is not used anywhere, and is not even implemented if CONFIG_USE_NPTL is defined. Signed-off-by: Peter Maydell --- qemu-lock.h | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/qemu-lock.h b/qemu-lock.h index 9a3e6ac..65ca

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Peter Zijlstra
On Wed, 2010-12-01 at 14:42 -0500, Rik van Riel wrote: > On 12/01/2010 02:35 PM, Peter Zijlstra wrote: > > On Wed, 2010-12-01 at 14:24 -0500, Rik van Riel wrote: > > >> Even if we equalized the amount of CPU time each VCPU > >> ends up getting across some time interval, that is no > >> guarantee t

Re: [Qemu-devel] [PATCH 0/7] Fixes for ia64-linux host

2010-12-01 Thread Edgar E. Iglesias
On Mon, Nov 22, 2010 at 02:57:51PM -0800, Richard Henderson wrote: > Three compilation errors, one tcg_abort, two code-generation errors, and > one warning fix. Though for the most part I'm using --disable-werror > until the code base is generally fixed up for gcc 4.6. > > I don't know if Aurelie

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Peter Zijlstra
On Wed, 2010-12-01 at 14:24 -0500, Rik van Riel wrote: > On 12/01/2010 02:07 PM, Peter Zijlstra wrote: > > On Wed, 2010-12-01 at 12:26 -0500, Rik van Riel wrote: > >> On 12/01/2010 12:22 PM, Peter Zijlstra wrote: > > >> The pause loop exiting& directed yield patches I am working on > >> preserve

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Rik van Riel
On 12/01/2010 02:35 PM, Peter Zijlstra wrote: On Wed, 2010-12-01 at 14:24 -0500, Rik van Riel wrote: Even if we equalized the amount of CPU time each VCPU ends up getting across some time interval, that is no guarantee they get useful work done, or that the time gets fairly divided to _user pr

locking for TCG (was: Re: [Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext))

2010-12-01 Thread Peter Maydell
On 28 November 2010 11:24, Peter Maydell wrote: > 2010/11/28 Brian Harring : >> Additional note... it *looks* like the deadlock potential is there >> already in 0.13, it's just heavily exacerbated by this patch- out of >> about 600 builds I've seen 2 lockup in the same fashion (rate was far >> hig

[Qemu-devel] [PATCH 02/10] ide: fix whitespace gap in ide_exec_cmd

2010-12-01 Thread Alexander Graf
Now that we have the function split out, we have to reindent it. In order to increase the readability of the actual functional change, this is split out. Signed-off-by: Alexander Graf --- hw/ide/core.c | 734 1 files changed, 367 insertio

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Rik van Riel
On 12/01/2010 02:07 PM, Peter Zijlstra wrote: On Wed, 2010-12-01 at 12:26 -0500, Rik van Riel wrote: On 12/01/2010 12:22 PM, Peter Zijlstra wrote: The pause loop exiting& directed yield patches I am working on preserve inter-vcpu fairness by round robining among the vcpus inside one KVM gues

[Qemu-devel] [PATCH 03/10] ide: add support for ide bus ops

2010-12-01 Thread Alexander Graf
From: Roland Elek We need to hook into some of the core IDE functionality for AHCI. To do that, the easiest way is to make explicit functions calls be implicit through a function call struct. Signed-off-by: Roland Elek Signed-off-by: Alexander Graf --- v1 -> v2: - rename IDEExtender to ID

[Qemu-devel] [PATCH 08/10] ahci: add ahci emulation

2010-12-01 Thread Alexander Graf
This patch adds an emulation layer for an ICH-7M AHCI controller. For now this controller does not do IDE legacy emulation. It is a pure AHCI controller. Signed-off-by: Alexander Graf --- v1 -> v2: - rename IDEExtender to IDEBusOps and make a pointer (kraxel) - make dma hooks explicit by p

[Qemu-devel] [PATCH 06/10] pci: add storage class for sata

2010-12-01 Thread Alexander Graf
This patch adds the storage sata class id. Signed-off-by: Alexander Graf --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 82cba7e..ea3418c 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -15,6 +15,7 @@ #define PCI_CLAS

[Qemu-devel] [PATCH 07/10] pci: add ich7 pci id

2010-12-01 Thread Alexander Graf
We need a PCI ID for our new AHCI adapter. I just picked an ICH-7M because that's the one built into the first Macbooks. This patch adds a PCI ID define for an ICH-7 AHCI adapter. Signed-off-by: Alexander Graf --- v3 -> v4: - add ICH7 instead of ICH7M (herbszt) v4 -> v5: - rename to ICH

[Qemu-devel] [PATCH 09/10] ide: move pata specific parts to pata.c

2010-12-01 Thread Alexander Graf
Due to popular request, this patch moves pieces that are successfully identified as PATA only to a new file called pata.c. Signed-off-by: Alexander Graf --- v6 -> v7: - stick to new IDEBusOps (stefanha, kwolf) --- Makefile.objs |2 +- hw/ide/core.c | 144 +--

[Qemu-devel] [PATCH 01/10] ide: split ide command interpretation off

2010-12-01 Thread Alexander Graf
The ATA command interpretation code can be used for PATA and SATA interfaces alike. So let's split it out into a separate function. Signed-off-by: Alexander Graf --- v6 -> v7: - use bus instead of opaque (stefanha) --- hw/ide/core.c | 20 ++-- hw/ide/internal.h |2

[Qemu-devel] [PATCH 10/10] config: add ahci for pci capable machines

2010-12-01 Thread Alexander Graf
This patch enables AHCI for all machines supporting PCI. Signed-off-by: Alexander Graf --- default-configs/pci.mak |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/default-configs/pci.mak b/default-configs/pci.mak index c74a99f..33fc073 100644 --- a/default-configs/pci.ma

[Qemu-devel] [PATCH] add a command line option to specify the IP address to send multicast packets from

2010-12-01 Thread Mike Ryan
[one more minor change which is needed on older kernels] Add an option to specify the host IP to send multicast packets from when using a multicast socket for networking. The option takes an IP address and sets the IP_MULTICAST_IF socket option, which causes the packets to use that IP's interface

[Qemu-devel] [PATCH 05/10] ide: add ncq identify data for ahci sata drives

2010-12-01 Thread Alexander Graf
From: Roland Elek I modified ide_identify() to include the zero-based queue length value in word 75, and set bit 8 in word 76 to signal NCQ support in the identify data for AHCI SATA drives. Signed-off-by: Roland Elek --- hw/ide/core.c |7 +++ hw/ide/internal.h |2 ++ 2 files c

[Qemu-devel] Re: [patch 3/3] UHCI: Substate section for migration of remote wakeup feature

2010-12-01 Thread Juan Quintela
Gerd Hoffmann wrote: > On 12/01/10 17:47, Marcelo Tosatti wrote: >> Use a subsection to migrate remote wakeup feature only when used by the >> guest. > > Yea, right, this must be saved. But certainly not by the UHCI > adapter, it belongs into the usb devices. Some of them don't save > state at

Re: [Qemu-devel] [PATCH 08/12] ARM: Return correct result for single<->double conversion of NaN

2010-12-01 Thread Richard Henderson
On 12/01/2010 07:39 AM, Nathan Froyd wrote: > RTH (CC'd) is the expert on the Alpha bits. The Alpha cmptun is supposed to return true for both Q+SNaN. Although, Invalid Operand is supposed to be raised for SNaN, which is not happening here in helper_cmptun. Or, indeed, any of the comparison help

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Peter Zijlstra
On Wed, 2010-12-01 at 23:30 +0530, Srivatsa Vaddagiri wrote: > On Wed, Dec 01, 2010 at 06:45:02PM +0100, Peter Zijlstra wrote: > > On Wed, 2010-12-01 at 22:59 +0530, Srivatsa Vaddagiri wrote: > > > > > > yield_task_fair(...) > > > { > > > > > > + ideal_runtime = sched_slice(cfs_rq, curr); >

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Peter Zijlstra
On Wed, 2010-12-01 at 12:26 -0500, Rik van Riel wrote: > On 12/01/2010 12:22 PM, Peter Zijlstra wrote: > > On Wed, 2010-12-01 at 09:17 -0800, Chris Wright wrote: > >> Directed yield and fairness don't mix well either. You can end up > >> feeding the other tasks more time than you'll ever get back.

[Qemu-devel] [PATCH V8 04/16] xen: Support new libxc calls from xen unstable.

2010-12-01 Thread anthony . perard
From: Anthony PERARD Update the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build against new versions of the library. We also check libxenctrl version in configure, from Xen 3.3.0 to Xen unstable. Signed-off-by: Anthony PERARD Signed-off-by: Stefano S

Re: [Qemu-devel] Re: [PATCH] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-01 Thread Edgar E. Iglesias
On Wed, Dec 01, 2010 at 09:12:48AM -0800, Nathan Froyd wrote: > On Tue, Nov 30, 2010 at 11:25:33AM +, Peter Maydell wrote: > > The softfloat functions float*_is_nan() were badly misnamed, > > because they return true only for quiet NaNs, not for all NaNs. > > Rename them to float*_is_quiet_nan(

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Juan Quintela
Anthony Liguori wrote: > On 12/01/2010 11:01 AM, Avi Kivity wrote: >> On 12/01/2010 06:56 PM, Anthony Liguori wrote: >>> On 12/01/2010 10:52 AM, Avi Kivity wrote: On 12/01/2010 06:49 PM, Anthony Liguori wrote: >> We need actual measurements instead of speculations. > > > Yes,

Re: [Qemu-devel] Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-12-01 Thread Venkateswararao Jujjuri (JV)
On 11/30/2010 5:16 PM, Hidetoshi Seto wrote: > Ping. > > Maintainers, please tell me if still something is required for > this patch before applying it. With Jes's Ack it should be good to go. I will included it in my next pull request to Anthony..and during that time if I see any issues I will l

[Qemu-devel] [PATCH V8 07/16] xen: Add the Xen platform pci device

2010-12-01 Thread anthony . perard
From: Steven Smith Introduce a new emulated PCI device, specific to fully virtualized Xen guests. The device is necessary for PV on HVM drivers to work. Signed-off-by: Steven Smith Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- Makefile.target |1 + hw/hw.h

[Qemu-devel] [PATCH V8 03/16] xen: Add a generic layer for xc calls

2010-12-01 Thread anthony . perard
From: Alexander Graf This patch adds a generic layer for xc calls, allowing us to choose between the xenner and xen implementations at runtime. Signed-off-by: Alexander Graf Signed-off-by: Anthony PERARD --- hw/xen_interfaces.c | 100 + hw/xen_

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Rik van Riel
On 12/01/2010 12:22 PM, Peter Zijlstra wrote: On Wed, 2010-12-01 at 09:17 -0800, Chris Wright wrote: Directed yield and fairness don't mix well either. You can end up feeding the other tasks more time than you'll ever get back. If the directed yield is always to another task in your cgroup the

[Qemu-devel] [PATCH V8 00/16] Xen device model support

2010-12-01 Thread anthony . perard
From: Anthony PERARD Hi all, Here is the V8 of the patch series that adds Xen device model support in QEMU. The change mades on it since the v7: - Move build of all xen object to x86 target only since Xen work only for this type of target. You can find a git tree here: git://xenbits.xe

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Srivatsa Vaddagiri
On Wed, Dec 01, 2010 at 05:25:18PM +0100, Peter Zijlstra wrote: > On Wed, 2010-12-01 at 21:42 +0530, Srivatsa Vaddagiri wrote: > > > Not if yield() remembers what timeslice was given up and adds that back when > > thread is finally ready to run. Figure below illustrates this idea: > > > > > >

[Qemu-devel] Re: [patch 2/2] support for UHCI suspend / remote wake up

2010-12-01 Thread Gerd Hoffmann
I was seeing bus disconnects when not clearing port resume bit properly. port->ctrl&= ~(val& 0x000a); +port->ctrl&= ~(port->ctrl& 0x0040); /* clear port resume detected */ } This chunk looks suspicious ... I suspect the port suspend/resume emulation is

Re: [Qemu-devel] [PATCH] Convert fprintf() to error_request(): virtio-9p

2010-12-01 Thread Venkateswararao Jujjuri (JV)
On 12/1/2010 1:35 AM, Stefan Hajnoczi wrote: > On Tue, Nov 30, 2010 at 9:52 AM, Sanchit Garg > wrote: >> @@ -3707,19 +3708,19 @@ VirtIODevice *virtio_9p_init(DeviceState *dev, >> V9fsConf *conf) >> s->ctx.fs_sm = SM_NONE; >> s->ctx.xops = none_xattr_ops; >> } else { >> -

[Qemu-devel] Re: [PATCH] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

2010-12-01 Thread Nathan Froyd
On Tue, Nov 30, 2010 at 11:25:33AM +, Peter Maydell wrote: > The softfloat functions float*_is_nan() were badly misnamed, > because they return true only for quiet NaNs, not for all NaNs. > Rename them to float*_is_quiet_nan() to more accurately reflect > what they do. > > This change was prod

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Anthony Liguori
On 12/01/2010 11:01 AM, Avi Kivity wrote: On 12/01/2010 06:56 PM, Anthony Liguori wrote: On 12/01/2010 10:52 AM, Avi Kivity wrote: On 12/01/2010 06:49 PM, Anthony Liguori wrote: We need actual measurements instead of speculations. Yes, I agree 100%. I think the place to start is what I sug

Re: [Qemu-devel] CFP: 1st International QEMU Users Forum

2010-12-01 Thread Jes Sorensen
On 11/29/10 08:44, Jes Sorensen wrote: > On 11/26/10 15:21, Anthony Liguori wrote: >> Attaching is easier logistically but I don't know how much that helps if >> it's a full 3 days instead of just a single day. Might be worth poking >> the LF folks for some advice. >> >> But the key point is bread

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Srivatsa Vaddagiri
On Wed, Dec 01, 2010 at 06:45:02PM +0100, Peter Zijlstra wrote: > On Wed, 2010-12-01 at 22:59 +0530, Srivatsa Vaddagiri wrote: > > > > yield_task_fair(...) > > { > > > > + ideal_runtime = sched_slice(cfs_rq, curr); > > + delta_exec = curr->sum_exec_runtime - curr->prev_sum_exec_runtim

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Anthony Liguori
On 12/01/2010 10:43 AM, Avi Kivity wrote: On 12/01/2010 06:33 PM, Anthony Liguori wrote: BTW, by this logic, even a 1-byte dirty bitmap is only 16mb which can be read in less than 16ms so where is the reported 24 minute stall coming from? a) we read the bitmap more than once Not in a single i

[Qemu-devel] [PATCH V8 16/16] acpi-piix4: Add Xen hypercall for sleep state.

2010-12-01 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/acpi_piix4.c |4 hw/xen.h|2 ++ xen-all.c |7 +++ xen-stub.c |4 4 files changed, 17 insertions(+), 0 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 173d781..1bcd40e 10

Re: [Qemu-devel] [PATCH 08/12] ARM: Return correct result for single<->double conversion of NaN

2010-12-01 Thread Nathan Froyd
On Wed, Dec 01, 2010 at 09:52:13AM -0800, Richard Henderson wrote: > I think I've lost the thread a bit -- is the proposal to > replace the existing float*_is_nan with _is_quiet_nan and > invent a new function that returns true for both Q+S? That > at least would be monotonic improvement for Alpha

[Qemu-devel] [PATCH V8 15/16] xen: Set running state in xenstore.

2010-12-01 Thread anthony . perard
From: Anthony PERARD This tells to the xen management tool that the machine can begin run. Signed-off-by: Anthony PERARD --- xen-all.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 36bdf30..b94d56e 100644 --- a/x

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Peter Zijlstra
On Wed, 2010-12-01 at 22:59 +0530, Srivatsa Vaddagiri wrote: > > yield_task_fair(...) > { > > + ideal_runtime = sched_slice(cfs_rq, curr); > + delta_exec = curr->sum_exec_runtime - curr->prev_sum_exec_runtime; > + rem_time_slice = ideal_runtime - delta_exec; > + > + curren

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Avi Kivity
On 12/01/2010 06:33 PM, Anthony Liguori wrote: BTW, by this logic, even a 1-byte dirty bitmap is only 16mb which can be read in less than 16ms so where is the reported 24 minute stall coming from? a) we read the bitmap more than once Not in a single iteration which is what the "stall" would co

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Chris Wright
* Peter Zijlstra (a.p.zijls...@chello.nl) wrote: > On Wed, 2010-12-01 at 09:17 -0800, Chris Wright wrote: > > Directed yield and fairness don't mix well either. You can end up > > feeding the other tasks more time than you'll ever get back. > > If the directed yield is always to another task in yo

[Qemu-devel] [PATCH V8 13/16] vl.c: Introduce getter for shutdown_requested and reset_requested.

2010-12-01 Thread anthony . perard
From: Anthony PERARD Introduce two functions qemu_shutdown_requested_get and qemu_reset_requested_get to get the value of shutdown/reset_requested without reset it. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- sysemu.h |2 ++ vl.c | 10 ++ 2 files chan

[Qemu-devel] [PATCH V8 06/16] xen: Add initialisation of Xen

2010-12-01 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- Makefile.target |3 +++ hw/xen.h| 13 + vl.c|2 ++ xen-all.c | 29 + xen-stub.c | 17 + 5 files changed, 64 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH V8 14/16] xen: Initialize event channels and io rings

2010-12-01 Thread anthony . perard
From: Arun Sharma Open and bind event channels; map ioreq and buffered ioreq rings. Signed-off-by: Arun Sharma Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen_common.h |3 + xen-all.c | 407 +++ 2 files

[Qemu-devel] [PATCH V8 09/16] xen: add a 8259 Interrupt Controller

2010-12-01 Thread anthony . perard
From: Anthony PERARD Introduce a 8259 Interrupt Controller for target-xen; every set_irq call makes a Xen hypercall. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen_common.h |2 ++ hw/xen_machine_fv.c |5 ++--- xen-all.c | 12 3

[Qemu-devel] [PATCH V8 10/16] xen: Introduce the Xen mapcache

2010-12-01 Thread anthony . perard
From: Jun Nakajima On IA32 host or IA32 PAE host, at present, generally, we can't create an HVM guest with more than 2G memory, because generally it's almost impossible for Qemu to find a large enough and consecutive virtual address space to map an HVM guest's whole physical address space. The at

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Juan Quintela
Anthony Liguori wrote: > On 12/01/2010 09:51 AM, Juan Quintela wrote: >> Avi Kivity wrote: >> >>> On 11/30/2010 04:46 PM, Juan Quintela wrote: >>> Anthony Liguori wrote: > On 11/23/2010 05:03 PM, Juan Quintela wrote: > >> From: Juan Quintela

[Qemu-devel] [PATCH V8 12/16] Introduce qemu_ram_ptr_unlock.

2010-12-01 Thread anthony . perard
From: Anthony PERARD This function allows to unlock a ram_ptr give by qemu_get_ram_ptr. After a call to qemu_ram_ptr_unlock, the pointer may be unmap from QEMU when used with Xen. Signed-off-by: Anthony PERARD --- cpu-common.h |1 + exec.c | 10 ++ xen-mapcache.c | 34

[Qemu-devel] [PATCH V8 01/16] xen: Replace some tab-indents with spaces (clean-up).

2010-12-01 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/xen_backend.c | 308 hw/xen_disk.c| 412 +++--- hw/xen_nic.c | 222 +++--- 3 files changed, 471 insertions(+), 47

[Qemu-devel] [PATCH V8 08/16] piix_pci: Introduces Xen specific call for irq.

2010-12-01 Thread anthony . perard
From: Anthony PERARD This patch introduces Xen specific call in piix_pci. The specific part for Xen is in write_config, set_irq and get_pirq. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/piix_pci.c | 28 ++-- hw/xen.h |6 ++ xe

[Qemu-devel] [PATCH V8 11/16] configure: Always use 64bits target physical addresses with xen enabled.

2010-12-01 Thread anthony . perard
From: Anthony PERARD With MapCache, we can handle a 64b target, even with a 32b host/qemu. So, we need to have target_phys_addr_t to 64bits. Signed-off-by: Anthony PERARD --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index a7a06ed.

[Qemu-devel] [PATCH V8 05/16] xen: Add xen_machine_fv

2010-12-01 Thread anthony . perard
From: Anthony PERARD Add the Xen FV (Fully Virtualized) machine to Qemu; this is groundwork to add Xen device model support in Qemu. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- Makefile.target |3 + hw/xen_common.h |5 ++ hw/xen_machine_fv.c | 158

[Qemu-devel] [PATCH V8 02/16] xen: Make xen build only on x86 target.

2010-12-01 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- Makefile.objs |4 Makefile.target |4 +++- configure |5 + 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index 23b17ce..e2bf50e 100644 --- a/Makefile.objs +++ b/Mak

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Peter Zijlstra
On Wed, 2010-12-01 at 09:17 -0800, Chris Wright wrote: > Directed yield and fairness don't mix well either. You can end up > feeding the other tasks more time than you'll ever get back. If the directed yield is always to another task in your cgroup then inter-guest scheduling fairness should be ma

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Avi Kivity
On 12/01/2010 06:56 PM, Anthony Liguori wrote: On 12/01/2010 10:52 AM, Avi Kivity wrote: On 12/01/2010 06:49 PM, Anthony Liguori wrote: We need actual measurements instead of speculations. Yes, I agree 100%. I think the place to start is what I suggested in a previous note in this thread,

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Chris Wright
* Peter Zijlstra (a.p.zijls...@chello.nl) wrote: > On Wed, 2010-12-01 at 21:42 +0530, Srivatsa Vaddagiri wrote: > > > Not if yield() remembers what timeslice was given up and adds that back when > > thread is finally ready to run. Figure below illustrates this idea: > > > > > > A0/4C0/

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Anthony Liguori
On 12/01/2010 09:51 AM, Juan Quintela wrote: Avi Kivity wrote: On 11/30/2010 04:46 PM, Juan Quintela wrote: Anthony Liguori wrote: On 11/23/2010 05:03 PM, Juan Quintela wrote: From: Juan Quintela Calculate the number of dirty pages takes a lot on hosts wi

[Qemu-devel] Re: [patch 1/3] add USBPortOps to USBPort

2010-12-01 Thread Gerd Hoffmann
On 12/01/10 17:47, Marcelo Tosatti wrote: Needed for remote wakeup notification. Urks. Crossover. /me did this (and more) as part of the usb cleanup bits. Current state: http://cgit.freedesktop.org/spice/qemu/log/?h=usb.1 cheers, Gerd

[Qemu-devel] Re: [patch 2/3] support for UHCI suspend / remote wake up

2010-12-01 Thread Gerd Hoffmann
Hi, port->ctrl = (port->ctrl& 0x01fb) | (val& ~0x01fb); /* some bits are reset when a '1' is written to them */ port->ctrl&= ~(val& 0x000a); +port->ctrl&= ~(port->ctrl& 0x0040); /* clear port resume detected */ Removing the port resu

[Qemu-devel] PATCH 0/5] add TRIM/UNMAP support, v2

2010-12-01 Thread Christoph Hellwig
This patchset adds support for the ATA TRIM and SCSI WRITE SAME with unmap commands, which allow reclaiming free space from a backing image. The user facing implementation is pretty complete, but not really efficient because the underlying bdrv_discard implementation doesn't use the aio implementa

[Qemu-devel] Re: [patch 2/2] support for UHCI suspend / remote wake up

2010-12-01 Thread Marcelo Tosatti
On Wed, Dec 01, 2010 at 04:12:14PM +0100, Gerd Hoffmann wrote: > On 11/25/10 18:04, Marcelo Tosatti wrote: > >This patch enables USB UHCI global suspend/resume feature. The OS will > >stop the HC once all ports are suspended. If there is activity on the > >port(s), an interrupt signalling remote wa

[Qemu-devel] Re: [patch 3/3] UHCI: Substate section for migration of remote wakeup feature

2010-12-01 Thread Gerd Hoffmann
On 12/01/10 17:47, Marcelo Tosatti wrote: Use a subsection to migrate remote wakeup feature only when used by the guest. Yea, right, this must be saved. But certainly not by the UHCI adapter, it belongs into the usb devices. Some of them don't save state at all today, which makes it a bit t

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Anthony Liguori
On 12/01/2010 10:52 AM, Avi Kivity wrote: On 12/01/2010 06:49 PM, Anthony Liguori wrote: We need actual measurements instead of speculations. Yes, I agree 100%. I think the place to start is what I suggested in a previous note in this thread, we need to measure actual stall time in the gue

[Qemu-devel] LinkedIn Messages, 12/01/2010

2010-12-01 Thread LinkedIn Communication
LinkedIn REMINDERS: Invitation Reminders: * View Invitation from vishnumurthy prabhu http://www.linkedin.com/e/-kkb1ec-gh6bg75y-a/qTMmi8QEI_f3FNXUkL1mvZgy00BGYniwg3/blk/I69963066_11/0NclYSdz0PdzAVdAALqnpPbOYWrSlI/svi/ PENDING MESSAGES: There is a message awa

Re: [Qemu-devel] [PATCH v2 0/3] vnc/spice: add monitor commands to change+expire passwords.

2010-12-01 Thread Anthony Liguori
On 12/01/2010 10:07 AM, Gerd Hoffmann wrote: On 12/01/10 15:10, Anthony Liguori wrote: On 11/30/2010 07:22 AM, Gerd Hoffmann wrote: Hi, This patch series adds new monitor commands to set and expire the password: set-password $protocol $secret expire-password $protocol [ now | never | +secs |

[Qemu-devel] [patch 2/3] support for UHCI suspend / remote wake up

2010-12-01 Thread Marcelo Tosatti
This patch enables USB UHCI global suspend/resume feature. The OS will stop the HC once all ports are suspended. If there is activity on the port(s), an interrupt signalling remote wakeup will be triggered. To enable autosuspend for the USB tablet on Linux guests: echo auto > /sys/devices/pci

[Qemu-devel] [patch 1/3] add USBPortOps to USBPort

2010-12-01 Thread Marcelo Tosatti
Needed for remote wakeup notification. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/hw/usb-bus.c === --- qemu-kvm.orig/hw/usb-bus.c +++ qemu-kvm/hw/usb-bus.c @@ -110,11 +110,11 @@ USBDevice *usb_create_simple(USBBus *bus } voi

[Qemu-devel] [patch 0/3] QEMU support for UHCI suspend / remote wake up (v3)

2010-12-01 Thread Marcelo Tosatti
v3: - Move remote wakeup callback to USBPort - Add subsection

Re: [Qemu-devel] [PATCH v2 0/3] vnc/spice: add monitor commands to change+expire passwords.

2010-12-01 Thread Anthony Liguori
On 11/30/2010 07:22 AM, Gerd Hoffmann wrote: Hi, This patch series adds new monitor commands to set and expire the password: set-password $protocol $secret expire-password $protocol [ now | never | +secs | secs ] The time when the password expires can be specified either relative (+60

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Avi Kivity
On 12/01/2010 06:49 PM, Anthony Liguori wrote: We need actual measurements instead of speculations. Yes, I agree 100%. I think the place to start is what I suggested in a previous note in this thread, we need to measure actual stall time in the guest. I'd actually start at the host. How

[Qemu-devel] [patch 3/3] UHCI: Substate section for migration of remote wakeup feature

2010-12-01 Thread Marcelo Tosatti
Use a subsection to migrate remote wakeup feature only when used by the guest. Signed-off-by: Marcelo Tosatti Index: qemu-kvm/hw/usb-uhci.c === --- qemu-kvm.orig/hw/usb-uhci.c +++ qemu-kvm/hw/usb-uhci.c @@ -363,6 +363,39 @@ static

Re: [Qemu-devel] [PATCH 1/2] spice: connection events.

2010-12-01 Thread Anthony Liguori
On 11/30/2010 07:11 AM, Gerd Hoffmann wrote: This patch adds support for connection events to spice. The events are quite simliar to the vnc events. Unlike vnc spice uses multiple tcp channels though. qemu will report every single tcp connection (aka spice channel). If you want track spice se

Re: [Qemu-devel] [PATCH v4 0/4] virtio: Use ioeventfd for virtqueue notify

2010-12-01 Thread Michael S. Tsirkin
On Wed, Dec 01, 2010 at 11:53:01AM +, Stefan Hajnoczi wrote: > On Wed, Nov 17, 2010 at 4:19 PM, Stefan Hajnoczi > wrote: > > The v4 version includes: > >  * Simpler start/stop ioeventfd mechanism using bool ioeventfd_started state > >  * Support for migration > >  * Handle deassign race condit

[Qemu-devel] Re: [PATCH 07/13] pci: add ich7 pci id

2010-12-01 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 7:17 PM, Alexander Graf wrote: > We need a PCI ID for our new AHCI adapter. I just picked an ICH-7M > because that's the one built into the first Macbooks. > > This patch adds a PCI ID define for an ICH-7M AHCI adapter. > > Signed-off-by: Alexander Graf > > --- > > v3 -> v

[Qemu-devel] Re: [PATCH 03/13] ide: add support for ide bus ops

2010-12-01 Thread Alexander Graf
On 01.12.2010, at 14:17, Kevin Wolf wrote: > Am 01.12.2010 14:09, schrieb Stefan Hajnoczi: >> On Fri, Nov 26, 2010 at 7:17 PM, Alexander Graf wrote: >> Just some cosmetic suggestions. >> >>> @@ -2716,6 +2736,12 @@ static void ide_init1(IDEBus *bus, int unit) >>>

[Qemu-devel] Re: [PATCH 03/13] ide: add support for ide bus ops

2010-12-01 Thread Kevin Wolf
Am 01.12.2010 14:09, schrieb Stefan Hajnoczi: > On Fri, Nov 26, 2010 at 7:17 PM, Alexander Graf wrote: > Just some cosmetic suggestions. > >> @@ -2716,6 +2736,12 @@ static void ide_init1(IDEBus *bus, int unit) >>ide_sector_write_timer_cb, s); >> } >> >

[Qemu-devel] Re: [PATCH 10/10] Maintaing number of dirty pages

2010-12-01 Thread Anthony Liguori
On 12/01/2010 10:25 AM, Juan Quintela wrote: Anthony Liguori wrote: On 12/01/2010 09:51 AM, Juan Quintela wrote: Avi Kivity wrote: On 11/30/2010 04:46 PM, Juan Quintela wrote: Anthony Liguoriwrote: On 11/23/2010 05:03 PM, Juan Quintela wro

Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

2010-12-01 Thread Yoshiaki Tamura
2010/11/30 Dor Laor : > On 11/29/2010 06:23 PM, Stefan Hajnoczi wrote: >> >> On Mon, Nov 29, 2010 at 3:00 PM, Yoshiaki Tamura >>  wrote: >>> >>> 2010/11/29 Paul Brook: >> >> If devices incorrectly claim support for live migration, then that >> should >> also be fixed, either by rem

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Peter Zijlstra
On Wed, 2010-12-01 at 21:42 +0530, Srivatsa Vaddagiri wrote: > Not if yield() remembers what timeslice was given up and adds that back when > thread is finally ready to run. Figure below illustrates this idea: > > > A0/4C0/4 D0/4 A0/4 C0/4 D0/4 A0/4 C0/4 D0/4 A0/4 > p0 ||-L|--

[Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2010-12-01 Thread Yoshiaki Tamura
2010/11/30 Stefan Hajnoczi : > On Tue, Nov 30, 2010 at 9:50 AM, Yoshiaki Tamura > wrote: >> 2010/11/29 Stefan Hajnoczi : >>> On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura >>> wrote: event-tap controls when to start FT transaction, and provides proxy functions to called from net/block

[Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant

2010-12-01 Thread Juan Quintela
Anthony Liguori wrote: > On 11/24/2010 04:52 AM, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> >>> On Wed, Nov 24, 2010 at 12:02:59AM +0100, Juan Quintela wrote: >>> From: Juan Quintela >> diff --git a/buffered_file.h b/buffered_file.h index 98d3

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-12-01 Thread Srivatsa Vaddagiri
On Wed, Dec 01, 2010 at 02:56:44PM +0200, Avi Kivity wrote: > >> (a directed yield implementation would find that all vcpus are > >> runnable, yielding optimal results under this test case). > > > >I would think a plain yield() (rather than usleep/directed yield) would > >suffice > >here (yield

[Qemu-devel] Re: [PATCH 04/13] ide: add DMA hooks to bus ops

2010-12-01 Thread Stefan Hajnoczi
On Fri, Nov 26, 2010 at 7:17 PM, Alexander Graf wrote: > For DMA operations, we need to hook into even more IDE functionality. > > This patch adds the respective hooking points, allowing us to handle > SG lists ourselves in the AHCI code. > > Signed-off-by: Roland Elek > Signed-off-by: Alexander

  1   2   3   >