On Tue, Nov 17, 2009 at 03:21:31PM +0200, Avi Kivity wrote:
> qemu-kvm's switch to seabios uncovered a regression with cdrom handling.
> Vista x64 no longer recognizes the cdrom, while pc-bios still works.
> Installing works, but that uses int 13, not the native driver. Haven't
> investigated
On Mon, Nov 16, 2009 at 03:14:33PM -0600, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
>> Huh? Do you want export *all* block devices via extboot? Will IDE
>> drives show up twice then?
>
> No, because SeaBIOS already has an ATA driver so we wouldn't want to
> expose IDE on the extboot bus.
On Wed, 18 Nov 2009 07:06:29 am Adam Litke wrote:
> virtio: Add memory statistics reporting to the balloon driver (V2)
>
> Changes since V1:
> - Use a virtqueue instead of the device config space
Hi Adam,
If Anthony's happy, I'm happy with this approach.
Couple of minor points:
> +static
On 18.11.2009, at 00:40, Aurelien Jarno wrote:
On Wed, Nov 11, 2009 at 12:56:47AM +, Paul Brook wrote:
On Thursday 22 October 2009, Aurelien Jarno wrote:
On Wed, Oct 21, 2009 at 03:52:22PM +0200, Ulrich Hecht wrote:
sync allows concurrent accesses to locations in memory through
differen
On Tue, Nov 17, 2009 at 8:17 PM, Evgeniy Dushistov wrote:
> On Tue, Nov 17, 2009 at 10:28:25AM +0100, Filip Navara wrote:
>> Interesting, I have been working on AT91SAM7X implementation. Most of
>> the stuff is in the GIT repository at
>> http://repo.or.cz/w/qemu/navara.git
>>
>> Any way to merge
On Tue, Nov 17, 2009 at 8:23 PM, Evgeniy Dushistov wrote:
> On Tue, Nov 17, 2009 at 10:39:27AM +0100, Filip Navara wrote:
>> I'd say it is preferable to split the individual devices and model
>> them using the QDEV infrastructure instead of putting it all together
>> into one "system controller" d
On Wed, Nov 11, 2009 at 12:56:47AM +, Paul Brook wrote:
> On Thursday 22 October 2009, Aurelien Jarno wrote:
> > On Wed, Oct 21, 2009 at 03:52:22PM +0200, Ulrich Hecht wrote:
> > > sync allows concurrent accesses to locations in memory through different
> > > TCG variables. This comes in handy
malc wrote:
Makefile has this:
sdl.o audio/sdlaudio.o sdl_zoom.o baum.o: QEMU_CFLAGS += $(SDL_CFLAGS)
Which, i guess, doesn't play well with expansion of $@ in rules.mak.
I wonder what changes you will see by adding following to the rules.mak.
QEMU_CFLAGS := $(QEMU_CFLAGS) -MMD -MP -MT $@
$
On Tue, Nov 17, 2009 at 12:35 AM, Jamie Lokier wrote:
> Artyom Tarasenko wrote:
>> I don't know, how the real sun4m reacts in the case where irq stays
>> on, not being cleared.
>> It can not be though that it would try to process irq for every next
>> tick. The CPU must have some time to clear the
virtio: Add memory statistics reporting to the balloon driver (V2)
Changes since V1:
- Use a virtqueue instead of the device config space
When using ballooning to manage overcommitted memory on a host, a system for
guests to communicate their memory usage to the host can provide information
that
Each mouse is represented by a QDict, the returned QObject is a QList of
all mice.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
console.h |3 +-
monitor.c |3 +-
vl.c | 62 ++--
3 files chang
Each VLAN is represented by a QDict, the returned QObject is a QList
of all VLANs.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
monitor.c |3 +-
net.c | 72 +---
net.h |3 +-
3 files chang
Return a QDict with server information. Connected clients are returned
as a QList of QDicts.
The new functions (vnc_qdict_remote_addr(), vnc_qdict_local_addr() and
put_addr_qdict()) are used to insert 'host' and 'service' information
in the returned QDict.
This patch is big, but I don't see how t
Return a QDict with information about the just added device.
This commit should not change user output.
Please, note that this patch does not do error handling
conversion. In error conditions the handler still calls
monitor_printf().
Signed-off-by: Luiz Capitulino
---
hw/pci-hotplug.c | 37 +
Each device statistic information is stored in a QDict and
the returned QObject is a QList of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
block.c | 82
block.h |3 +-
monitor.c
Each device is represented by a QDict. The returned QObject is a QList
of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
monitor.c |3 ++-
qemu-char.c | 43 +--
qemu-char.h |4 +++-
3 files changed,
Return a QDict, which may contain another QDict if the migration
process is active.
IMPORTANT: as a QInt stores a int64_t integer, RAM values are going
to be stored as int64_t and not as uint64_t as they are today. If
this is a problem QInt will have to be changed.
This commit should not change u
Each block device information is stored in a QDict and the
returned QObject is a QList of all devices.
This commit should not change user output.
Signed-off-by: Luiz Capitulino
---
Makefile |2 +-
block.c | 123 +++--
block.h |
The returned QObject is a QString, snprintf() is used because the
UUID_FMT is too complex for qobject_from_jsonf().
Signed-off-by: Luiz Capitulino
---
monitor.c | 15 ---
1 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 9ecf5ff..c86c7a5 10
The returned QObject is a QString.
Signed-off-by: Luiz Capitulino
---
monitor.c | 24 +---
1 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 5140198..9ecf5ff 100644
--- a/monitor.c
+++ b/monitor.c
@@ -361,10 +361,27 @@ static void d
The returned QObject is a QString.
Signed-off-by: Luiz Capitulino
---
monitor.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 1a37be3..5140198 100644
--- a/monitor.c
+++ b/monitor.c
@@ -349,10 +349,15 @@ static void do_info_versio
The returned QObject is a QString with kvm status information.
Signed-off-by: Luiz Capitulino
---
monitor.c | 31 +--
1 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index 72de320..1a37be3 100644
--- a/monitor.c
+++ b/monitor.c
Return a QString with status information.
Signed-off-by: Luiz Capitulino
---
monitor.c | 33 +++--
1 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index 3286ba2..72de320 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1678,16 +1678,3
A helper function to get a QList from a QDict.
Signed-off-by: Luiz Capitulino
---
Makefile |2 +-
qdict.c | 13 +
qdict.h |2 ++
3 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index fa41ac9..6be75a1 100644
--- a/Makefile
+++ b/Makefile
This is a helper function that does type checking before retrieving
a QBool from the dictionary.
Signed-off-by: Luiz Capitulino
---
Makefile |2 +-
qdict.c | 15 +++
qdict.h |1 +
3 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index dd
Other subsystems will need to link against them.
Signed-off-by: Luiz Capitulino
---
Makefile |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index d770e2a..dd48a35 100644
--- a/Makefile
+++ b/Makefile
@@ -72,6 +72,11 @@ ALL_SUBDIRS=$(TARGET_DIR
An easy way to include all QEMU objects.
Signed-off-by: Luiz Capitulino
---
qemu-objects.h | 24
1 files changed, 24 insertions(+), 0 deletions(-)
create mode 100644 qemu-objects.h
diff --git a/qemu-objects.h b/qemu-objects.h
new file mode 100644
index 000..e1d1e
Hi,
Now that qjson has been merged, it's time to flush my queues..
This series covers almost half of the info handlers conversions to the
QObject style, the other half is a bit more complicated as some handlers
can be defined by different machine types.
Detailed conversion status can be foun
Hi people,
I would like to tank you for your attention and patience. I don't understand
many things about emulators, nor linux. I started using Ubuntu-Linux this
year, and since then, i started to discover a new world. But sometimes i
have some problems and it's not so easy to a newbie to solve it
On Tue, Nov 17, 2009 at 11:12 AM, Kevin Wolf wrote:
> Am 17.11.2009 00:05, schrieb Jamie Lokier:
>> Blue Swirl wrote:
>>> On Mon, Nov 16, 2009 at 2:47 PM, Kevin Wolf wrote:
Am 13.11.2009 22:05, schrieb Blue Swirl:
> On Fri, Nov 13, 2009 at 5:17 PM, Kevin Wolf wrote:
>> We're leaking
virtio: Report new guest memory statistics pertinent to memory ballooning (V3)
Changes since V2:
- Use a virtqueue for communication instead of the device config space
Changes since V1:
- In the monitor, print all stats on one line with less abbreviated names
- Coding style changes
When using
Signed-off-by: Luiz Capitulino
---
hw/qdev.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index d19d531..875ca50 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -29,6 +29,7 @@
#include "qdev.h"
#include "sysemu.h"
#include "monitor.h"
+#include "q
This commit adds QError support in the Monitor.
A QError member is added to the Monitor struct. This new member
stores error information and is also used to check if an error
has occurred when the called handler returns.
Additionally, a new macro called qemu_error_new() is introduced.
It builds o
Signed-off-by: Luiz Capitulino
---
monitor.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 74abef9..e42434f 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1722,10 +1722,11 @@ static void do_info_balloon(Monitor *mon, QObject
**ret_data)
QError is a high-level data type which represents an exception
in QEMU, it stores the following error information:
- class Error class name (eg. "ServiceUnavailable")
- descriptionA detailed error description, which can contain
references to run-time error data
- file
Signed-off-by: Luiz Capitulino
---
check-qstring.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/check-qstring.c b/check-qstring.c
index 412038a..c308a63 100644
--- a/check-qstring.c
+++ b/check-qstring.c
@@ -71,6 +71,19 @@ START_TEST(qstring_append_chr_te
Signed-off-by: Luiz Capitulino
---
check-qstring.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/check-qstring.c b/check-qstring.c
index ea4dfd0..412038a 100644
--- a/check-qstring.c
+++ b/check-qstring.c
@@ -55,6 +55,22 @@ START_TEST(qstring_get_str_te
Note that we can now write qstring_from_str() as a wrapper.
Signed-off-by: Luiz Capitulino
---
qstring.c | 20 +++-
qstring.h |1 +
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/qstring.c b/qstring.c
index ad17769..740a106 100644
--- a/qstring.c
+++ b/qstr
Signed-off-by: Luiz Capitulino
---
qstring.c |8
qstring.h |2 ++
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/qstring.c b/qstring.c
index e422bd9..ad17769 100644
--- a/qstring.c
+++ b/qstring.c
@@ -75,6 +75,14 @@ void qstring_append(QString *qstring, const cha
It appends a C char to a QString.
Signed-off-by: Luiz Capitulino
---
qstring.c | 24 +++-
qstring.h |1 +
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/qstring.c b/qstring.c
index 441a9e6..e422bd9 100644
--- a/qstring.c
+++ b/qstring.c
@@ -53,25 +53,39
It accepts a va_list and will be used by QError. Also simplifies
the code a little, as the other qobject_from_() functions can
use it.
Signed-off-by: Luiz Capitulino
---
qjson.c | 21 +++--
qjson.h |2 ++
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/qjso
Hi,
This new QError version has some small improvements and is a candidate
for merging, as qjson is already on master.
Just to remind you that it implements what was suggested by Anthony
in this email:
http://lists.gnu.org/archive/html/qemu-devel/2009-11/msg00601.html
Basically, the error t
Saul Tamari wrote:
This patch reduces the size of memory being cleared on every virtio-blk IO.
Improve number of IOPS when using avirtio-blk device.
On every virtio-blk IO command passed to QEMU, virtio_blk_alloc_request()
allocates and clears (with qemu_mallocz()) a VirtIOBlockReq object.
The
On Tue, Nov 17, 2009 at 10:39:27AM +0100, Filip Navara wrote:
> I'd say it is preferable to split the individual devices and model
> them using the QDEV infrastructure instead of putting it all together
> into one "system controller" device.
>
> I've QDEV-based implementation of these devices alre
On 11/17/09 19:11, Ian Molton wrote:
Gerd Hoffmann wrote:
Maybe also create a common function for parsing called by both
parse_size() and parse_option_size() to make sure OPT_SIZE and the new
size property accept the same syntax?
The thought crossed my mind, but then I thought that as none of
On Tue, Nov 17, 2009 at 10:28:25AM +0100, Filip Navara wrote:
> Interesting, I have been working on AT91SAM7X implementation. Most of
> the stuff is in the GIT repository at
> http://repo.or.cz/w/qemu/navara.git
>
> Any way to merge the efforts? I'd love to merge both mine and your
> patches to th
On Tuesday 17 November 2009 12:11:58 am Luiz Felipe wrote:
> Hi, i tried to use kqemu in ubuntu to start Windows XP SP3. I used the
> command line: "qemu -kernel-kqemu" and the system started to run windows on
> qemu. Although, i observed the following message on my shell:
>
> QEMU acceleration la
Gerd Hoffmann wrote:
> On 11/17/09 15:23, Ian Molton wrote:
>> I've cooked up this patch (attached) to add a SIZE property to qdevs.
>> I've kept the same semantics as the OPT_SIZE parser for now.
>
> The error message should be adapted (s/Option/Property/ at least).
Fixed locally.
> Maybe also
Avi Kivity schrieb:
> qemu-kvm's switch to seabios uncovered a regression with cdrom
> handling. Vista x64 no longer recognizes the cdrom, while pc-bios
> still works. Installing works, but that uses int 13, not the native
> driver. Haven't investigated further yet.
>
> Command line:
>
> qemu -d
On 11/17/09 15:23, Ian Molton wrote:
I've cooked up this patch (attached) to add a SIZE property to qdevs.
I've kept the same semantics as the OPT_SIZE parser for now.
The error message should be adapted (s/Option/Property/ at least).
Maybe also create a common function for parsing called by b
While trying to run -kernel with -bios pc-bios/pcbios.bin, I realized
that I was actually writing data to %es, but only set up %ds to a 32-bit
segment we want to write to.
So at the end of the day the data hasn't actually been copied. Oops.
So here's a fix to set ES instead of DS, which makes -ke
On 11/17/09 11:51, Hannes Reinecke wrote:
Grand. Meanwhile I've dug up some more register definitions,
so I'll doing some more updates to the driver.
Feel free to send updates (both incremental and replacement are fine).
Meanwhile I've stumbled across another issue:
The megasas HBA insists on
Avi Kivity wrote:
On 11/16/2009 04:18 PM, Fernando Luis Vázquez Cao wrote:
Avi Kivity wrote:
On 11/09/2009 05:53 AM, Fernando Luis Vázquez Cao wrote:
Kemari runs paired virtual machines in an active-passive configuration
and achieves whole-system replication by continuously copying the
state
Hi, i tried to use kqemu in ubuntu to start Windows XP SP3. I used the
command line: "qemu -kernel-kqemu" and the system started to run windows on
qemu. Although, i observed the following message on my shell:
QEMU acceleration layer not activated: Permission denied
unknown keycodes `evdev(abnt2)_a
Alexander Graf wrote:
Because that's not what you'd use it for. That's what -kernel and
-initrd are there for.
IMHO having a BIOS backdoor is a good thing in general. If anyone wants
to destroy their user experience by writing a driver for that in their
OS, I'm good with that, but let's not exp
Paul Brook wrote:
> On Tuesday 17 November 2009, Ian Molton wrote:
> When do we ever have a value that can be specified as both bits and bytes? I
> don't think it makes sense to specify this. The fact that we accept a "b"
> suffix at all is suspicious.
Well, entropy is often measured in 'bits'
Paul Brook wrote:
> On Tuesday 17 November 2009, Gerd Hoffmann wrote:
>
>> On 11/17/09 13:36, Paul Brook wrote:
>>
> In fact I'd much prefer to see extboot rewritten to just virtio-block.
>
Hmm, I'd prefer something which is *not* used by the guest OS, so it is
2009/11/17 Avi Kivity :
> On 11/17/2009 01:04 PM, Yoshiaki Tamura wrote:
>>>
>>> What I mean is:
>>>
>>> - choose synchronization point A
>>> - start copying memory for synchronization point A
>>> - output is delayed
>>> - choose synchronization point B
>>> - copy memory for A and B
>>> if guest
> > Why aren't you also using this function in scsi- disc.c? Surely that's the
> > whole point of moving it into common code.
>
> Same as with the command move: next patch series will rework scsi-disk
> to put the new fields and functions into use.
Hmm, maybe you need to rethink your patch sequen
On 11/17/2009 02:20 PM, Paul Brook wrote:
What you're describing is commonly referred to as a Single System
Image. It's been around for a while and can be found in software-only
verses (pre-Xen VirtualIron, ScaleMP) and hardware-assisted (IBM, 3leaf).
Or better still do it at the OS level
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
> On 11/17/09 13:36, Paul Brook wrote:
> >>> In fact I'd much prefer to see extboot rewritten to just virtio-block.
> >>
> >> Hmm, I'd prefer something which is *not* used by the guest OS, so it is
> >> a pure bootloader thing. When using it to boo
On Tuesday 17 November 2009, Ian Molton wrote:
> Hi,
>
> Qemu currently is making a bit of a hash of parsing suffixes,
>
> Right now, it has:
>
> T, G, M, and K which are multiples of 1024 bytes - fair enough
>
> but it also has:
>
> k - 1024 (should be 1000)
>
> and b:
>
> Byte (also wron
On 11/17/2009 04:26 AM, Kevin O'Connor wrote:
On Mon, Nov 16, 2009 at 04:02:20PM +0200, Avi Kivity wrote:
Something that is likely related, I am seeing reboot failures in
seabios's pmm_free. Immediately after loading gpxe, seabios is in an
endless loop there, likely due to memory corruption
qemu-kvm's switch to seabios uncovered a regression with cdrom
handling. Vista x64 no longer recognizes the cdrom, while pc-bios still
works. Installing works, but that uses int 13, not the native driver.
Haven't investigated further yet.
Command line:
qemu -drive
file=/root/kvm-autotest/
On 11/17/09 11:17, Gerd Hoffmann wrote:
Hi,
First batch of scsi patches. They bring some data structure unification
and a bunch of fixes and cleanups. In preparation for the other scsi
patches, but also useful on its own IMHO, so I'm hoping for a quick and
painless merge.
The major rewrite
On 11/17/09 13:36, Paul Brook wrote:
In fact I'd much prefer to see extboot rewritten to just virtio-block.
Hmm, I'd prefer something which is *not* used by the guest OS, so it is
a pure bootloader thing. When using it to boot from scsi you don't want
to have the disk show up twice (as virtio
On 11/17/09 13:02, Christoph Hellwig wrote:
On Tue, Nov 17, 2009 at 11:17:51AM +0100, Gerd Hoffmann wrote:
Handy for debugging.
Yes, nice one, but what about getting rid of the ad-hoc printfs in
scsi-disk, too?
Will be part of the next scsi patch series which reworks scsi-disk.c
cheers,
G
On 11/17/09 12:54, Christoph Hellwig wrote:
Looks good. Long term we might want to make this a pointer to be able
to deal with block format sense descriptors more nicely.
Did already happen ;)
I just can't move up that patch easily without causing massive churn in
the patch series ...
chee
On 11/17/09 13:27, Paul Brook wrote:
On Tuesday 17 November 2009, Christoph Hellwig wrote:
The subject is a bit confusing - it's not the full request parsing but
just some helpers.
This is a good example of a patch with an insufficient commit message.
Given the way GIT treats the first line of
On 11/17/09 12:55, Paul Brook wrote:
move scsi command from SCSIGenericReq to SCSIRequest.
Why? AFAICS This has precisely one user, and more importantly it is not
populated by scsi-disk.c.
Next patch of scsi patches will make scsi-disk use it too.
(in the git tree: a bunch of patches prefixe
On 11/17/09 12:59, Paul Brook wrote:
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
Changes:
* Move from open-coded lists to QTAILQ macros.
* Move the struct elements to the common data structures
(SCSIDevice + SCSIRequest).
* Fix request cleanup in the destroy callback.
This feel
Hi,
Qemu currently is making a bit of a hash of parsing suffixes,
Right now, it has:
T, G, M, and K which are multiples of 1024 bytes - fair enough
but it also has:
k - 1024 (should be 1000)
and b:
Byte (also wrong)
since its only using a single character, with b taken, theres no way to
r
> > In fact I'd much prefer to see extboot rewritten to just virtio-block.
>
> Hmm, I'd prefer something which is *not* used by the guest OS, so it is
> a pure bootloader thing. When using it to boot from scsi you don't want
> to have the disk show up twice (as virtio and scsi) in the guest.
You
On Tuesday 17 November 2009, Christoph Hellwig wrote:
> The subject is a bit confusing - it's not the full request parsing but
> just some helpers.
This is a good example of a patch with an insufficient commit message.
Given the way GIT treats the first line of the commit mesaage, my advice is to
On 11/17/09 12:36, Paul Brook wrote:
It would require a mechanism to do enumeration and identification
though.
Huh? Do you want export *all* block devices via extboot? Will IDE
drives show up twice then?
No, because SeaBIOS already has an ATA driver so we wouldn't want to
expose IDE on the
> > The practical example below will explain it completely:
> >
> > 1) we take 4 common modern computers - CoreQuad + 8 GB Memory.
> > 2) we assemble a standard Linux cluster with 16 cores and 32G memory.
> > 3) and now - we run the only one virtual guest system, but give it ALL
> > available resou
On 11/17/2009 01:04 PM, Yoshiaki Tamura wrote:
What I mean is:
- choose synchronization point A
- start copying memory for synchronization point A
- output is delayed
- choose synchronization point B
- copy memory for A and B
if guest touches memory not yet copied for A, COW it
- once A cop
On Tue, Nov 17, 2009 at 11:17:51AM +0100, Gerd Hoffmann wrote:
> Handy for debugging.
Yes, nice one, but what about getting rid of the ad-hoc printfs in
scsi-disk, too?
On Tue, Nov 17, 2009 at 11:17:50AM +0100, Gerd Hoffmann wrote:
> Also add and use the scsi_req_complete() helper function for calling the
> completion callback.
>
> Signed-off-by: Gerd Hoffmann
Look good,
Reviewed-by: Christoph Hellwig
On Tue, Nov 17, 2009 at 11:17:49AM +0100, Gerd Hoffmann wrote:
>
> Signed-off-by: Gerd Hoffmann
Looks good,
Reviewed-by: Christoph Hellwig
On Tuesday 17 November 2009, Gerd Hoffmann wrote:
> Changes:
> * Move from open-coded lists to QTAILQ macros.
> * Move the struct elements to the common data structures
>(SCSIDevice + SCSIRequest).
> * Fix request cleanup in the destroy callback.
This feels like the abstraction boundaries w
> add xfer mode
This should also be used by scsi-disc.c
Paul
> move scsi command from SCSIGenericReq to SCSIRequest.
Why? AFAICS This has precisely one user, and more importantly it is not
populated by scsi-disk.c.
Sharing common code is good. Implementing shared fields inconsistently or
putting implementation specific fields in common structures.
Paul
Looks good. Long term we might want to make this a pointer to be able
to deal with block format sense descriptors more nicely.
On Tue, Nov 17, 2009 at 11:17:47AM +0100, Gerd Hoffmann wrote:
> +static void scsi_req_xfer_mode(SCSIRequest *req)
> +{
> +switch (req->cmd.buf[0]) {
Having this as a void seem a bit odd to me. I'd make it return the
mode, and maybe just pass the cmd to it to make it more clear.
> +static in
On Tue, Nov 17, 2009 at 11:17:46AM +0100, Gerd Hoffmann wrote:
>
> Signed-off-by: Gerd Hoffmann
Looks good,
Reviewed-by: Christoph Hellwig
The subject is a bit confusing - it's not the full request parsing but
just some helpers.
> +static int scsi_req_length(SCSIRequest *req, uint8_t *cmd)
> +{
> +switch (cmd[0] >> 5) {
I know qemu code tends to be very uncommented and the code this is
lifted from too, but some comments on how t
> >> It would require a mechanism to do enumeration and identification
> >> though.
> >
> > Huh? Do you want export *all* block devices via extboot? Will IDE
> > drives show up twice then?
>
> No, because SeaBIOS already has an ATA driver so we wouldn't want to
> expose IDE on the extboot bus.
Looks good,
Reviewed-by: Christoph Hellwig
On Tue, Nov 17, 2009 at 11:17:43AM +0100, Gerd Hoffmann wrote:
> Largely based on from linux. Added into the tree so we
> can use the defines everywhere, not just in scsi-generic.c (which is
> linux-specific).
Btw, I'm not sure having the name clash with the Linux header is a good
idea as we nee
On Tue, Nov 17, 2009 at 11:17:42AM +0100, Gerd Hoffmann wrote:
>
> Signed-off-by: Gerd Hoffmann
Looks good,
Reviewed-by: Christoph Hellwig
On (Tue) Nov 17 2009 [11:10:32], Ian Molton wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Amit Shah wrote:
> > (Any reason to take this off-list?)
>
> None other than hitting reply rather than reply-all. CCing list once
> more :-)
>
> >> Either way, you still need to specify the p
On Tue, Nov 17, 2009 at 11:17:41AM +0100, Gerd Hoffmann wrote:
>
> Signed-off-by: Gerd Hoffmann
A little description of why you can it would be good. I will
defintively help with my SBC thin provisioning implementation later, so
no complaints from me :)
Reviewed-by: Christoph Hellwig
On Tue, Nov 17, 2009 at 11:17:40AM +0100, Gerd Hoffmann wrote:
> Helper function to init SCSIRequest, so scsi-disk and scsi-generic
> don't duplicate init code for the common bits.
Looks good,
Reviewed-by: Christoph Hellwig
On Tue, Nov 17, 2009 at 11:17:39AM +0100, Gerd Hoffmann wrote:
> Changes:
> * Move from open-coded lists to QTAILQ macros.
> * Move the struct elements to the common data structures
>(SCSIDevice + SCSIRequest).
> * Fix request cleanup in the destroy callback.
Perfect, the old, duplicated li
On Tue, Nov 17, 2009 at 11:17:38AM +0100, Gerd Hoffmann wrote:
> Rename the SCSIRequest structs in scsi-disk.c and scsi-generic.c to
> SCSIDiskReq and SCSIGenericReq. Create a SCSIRequest struct and move
> the common elements over.
Nice, have been waiting for this for a long time.
Reviewed-by:
On Tue, Nov 17, 2009 at 11:17:37AM +0100, Gerd Hoffmann wrote:
> Also delete the leftover and unused scsi-disk.h file.
>
> Signed-off-by: Gerd Hoffmann
Looks good,
Reviewed-by: Christoph Hellwig
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Amit Shah wrote:
> (Any reason to take this off-list?)
None other than hitting reply rather than reply-all. CCing list once
more :-)
>> Either way, you still need to specify the properties - they've just
>> moved into the console driver in your patch
Gerd Hoffmann wrote:
> On 11/12/09 12:48, Hannes Reinecke wrote:
>>
>> This patch adds an emulation for the LSI MegaRAID SAS HBA.
>> It is build on top of kraxel's scsi.v7 tree.
>>
>> This is just a rough implementation, many of the more
>> advanced topics (like Windows booting :-) are missing.
>>
This patch adds a 'index' property to the isa-parallel and isa-serial
devices. This can be used to create devices with the default isa irqs
and ioports by simply specifying the index, i.e.
-device isa-serial,index=1
instead of
-device isa-serial,iobase=0x2f8,irq=3
for ttyS1 aka com2. Li
1 - 100 of 134 matches
Mail list logo
