> move scsi command from SCSIGenericReq to SCSIRequest. Why? AFAICS This has precisely one user, and more importantly it is not populated by scsi-disk.c.
Sharing common code is good. Implementing shared fields inconsistently or putting implementation specific fields in common structures. Paul