Am 16.03.2011 15:31, schrieb Jesus Cea:
> On 08/03/11 22:16, Georg Brandl wrote:
>> But in any case, by popular demand "fix" is now removed, and only
>> "close" and its variants actually closes the issue -- since there
>> is not much chance that you can write "close #12345" without
>> actually mean
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/03/11 22:16, Georg Brandl wrote:
> But in any case, by popular demand "fix" is now removed, and only
> "close" and its variants actually closes the issue -- since there
> is not much chance that you can write "close #12345" without
> actually mea
On 08.03.2011 21:07, Terry Reedy wrote:
>
>> +If "closes" or "fixes" (with alternative verb forms like "fixing"
>> +allowed too) is prepended, the issue is automatically closed as
>> +"fixed".
>
> Fix may be too broad. "This patch fixes the first part of the issue."
Well, you'd have to write "Th
On Tue, 08 Mar 2011 15:07:29 -0500
Terry Reedy wrote:
>
> > +If "closes" or "fixes" (with alternative verb forms like "fixing"
> > +allowed too) is prepended, the issue is automatically closed as
> > +"fixed".
>
> Fix may be too broad. "This patch fixes the first part of the issue."
Ok, it has
On 08.03.2011 14:19, Antoine Pitrou wrote:
> On Tue, 08 Mar 2011 12:23:54 +0100
> local wrote:
>> +
>> +VERBS = r'(?:\b(?Pclose[sd]?|closing|fixe[sd]|fixing|fix)\s+)?'
>> +ISSUE_PATTERN = re.compile(r'%s(?:#|\bissue|\bbug)\s*(?P[0-9]+)'
>> + % VERBS, re.I)
>
> This shoul
On Tue, 08 Mar 2011 12:23:54 +0100
local wrote:
> +
> +VERBS = r'(?:\b(?Pclose[sd]?|closing|fixe[sd]|fixing|fix)\s+)?'
> +ISSUE_PATTERN = re.compile(r'%s(?:#|\bissue|\bbug)\s*(?P[0-9]+)'
> + % VERBS, re.I)
This should only match numbers with 4 and 5 figures IMO.
Otherwis
