On 08.03.2011 14:19, Antoine Pitrou wrote: > On Tue, 08 Mar 2011 12:23:54 +0100 > local <python-check...@python.org> wrote: >> + >> +VERBS = r'(?:\b(?P<verb>close[sd]?|closing|fixe[sd]|fixing|fix)\s+)?' >> +ISSUE_PATTERN = re.compile(r'%s(?:#|\bissue|\bbug)\s*(?P<issue_id>[0-9]+)' >> + % VERBS, re.I) > > This should only match numbers with 4 and 5 figures IMO. > Otherwise things like "this is priority #1" in commit messages will > spam issue number 1 (assuming it exists). > > Also, I'm not sure trying to match too many verbs is useful. Things are > clearer and more predictible if we mandate a single form, perhaps only > at the last line of the commit message. We don't want false positives > (such as messages about closed files, etc.).
Please go ahead: I'm not attached to any of the details. Georg _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
