[Python-Dev] Re: PEP 624: Remove Py_UNICODE encoder APIs

2021-01-21 Thread Inada Naoki
Hi, Lemburg. I want to send the PEP to SC. I think I wrote all your points in the PEP. Would you review it? Regards, On Tue, Aug 4, 2020 at 5:04 PM Inada Naoki wrote: > > On Tue, Aug 4, 2020 at 3:31 PM M.-A. Lemburg wrote: > > > > Hi Inada-san, > > > > thanks for attending EuroPython. I won't

[Python-Dev] Re: PEP 651: Robust Overflow Handling, version 2

2021-01-21 Thread Guido van Rossum
On Wed, Jan 20, 2021 at 9:16 AM Mark Shannon wrote: > I've updated the PEP in light of my experiments and feedback. > The new API is simpler and a bit more backwards compatible. > > https://www.python.org/dev/peps/pep-0651 Minor question: what's the `where` argument to `Py_CheckStackDepth()` fo

[Python-Dev] Re: pathlib.Path: inconsistent symlink_to() and link_to()

2021-01-21 Thread Barney Gale
Hi Brett, Per your PR review feedback [0] I left a comment on the bug [1] asking when the link_to() method should be scheduled for removal. It didn't elicit a great deal of feedback, so I'm raising this again here! The proposed deprecation warning in the docs currently reads: > This method is de

[Python-Dev] Re: Please explain how to migrate when a function is removed, thanks ;-)

2021-01-21 Thread Kyle Stanley
On Jan 20, 2021 at 9:51 PM Chros Jerdonek wrote: > Is there / would it make sense to have a section analogous to "Porting to > Python X" that covers "Make All DeprecationWarnings Go Away in X"? If we > had such a section, the "Porting to" section could be constructed by > copying the relevant bit

[Python-Dev] Re: Please explain how to migrate when a function is removed, thanks ;-)

2021-01-21 Thread Mariatta
I agree that when we land a feature that introduces incompatible change like this, as part of the PR it should also include updating the documentation on how to migrate. I would think that the feature should not be merged unless the doc has been updated too. Perhaps we should include this explicit

[Python-Dev] The SC is accepting PEP 632: deprecating distutils

2021-01-21 Thread Brett Cannon
On behalf of the SC, I'm happy to announce that we have chosen to accept PEP 632. Congrats, Steve, and thanks for the work on the PEP! I'll let Steve outline what the next steps are for implementing the PEP. ___ Python-Dev mailing list -- python-dev@pyth

[Python-Dev] Doctest does not work with mock.call PR #22981

2021-01-21 Thread Alfred Perlstein
Hello, There's been a bug open where doctest can break if there are proxy objects that fail to unwrap (https://bugs.python.org/issue35753) since python 3.7, this includes when importing 'call' from the 'mock' module. Does someone have time to review PR 22981 (https://github.com/python/cpytho

[Python-Dev] Re: Please explain how to migrate when a function is removed, thanks ;-)

2021-01-21 Thread Victor Stinner
Currently, we wait until the first user complains, sometimes after a 3.x.0 final release, before starting to document how to port existing code. I agree that it should be done earlier. I suggest that developers who want to introduce an incompatible change think about how to port existing code, esp