On Jan 20, 2021 at 9:51 PM Chros Jerdonek <chris.jerdo...@gmail.com> wrote:
> Is there / would it make sense to have a section analogous to "Porting to > Python X" that covers "Make All DeprecationWarnings Go Away in X"? If we > had such a section, the "Porting to" section could be constructed by > copying the relevant bits from that section in the previous release. +1 from me to include this section in 3.10 and future whatsnew. On Thu, Jan 21, 2021 at 2:17 PM Mariatta <maria...@python.org> wrote: > I agree that when we land a feature that introduces incompatible change > like this, as part of the PR it should also include updating the > documentation on how to migrate. > I would think that the feature should not be merged unless the doc has > been updated too. > > Perhaps we should include this explicitly in devguide, as one of the > things to consider when reviewing pull requests. > Do we have such a guide/doc yet, on how to review CPython pull requests? > This seems like it would be a good location to include that information: https://devguide.python.org/pullrequest/#how-to-review-a-pull-request Maybe also a brief mention in the checklist for https://devguide.python.org/committing/#is-the-pr-ready-to-be-accepted. Step 9 currently has: "Was “What’s New” updated (as appropriate)?", which could have a sub-point to mention "Incompatible changes should include migration information in their respective "What's New".".
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/E7NYJ5DUQM46GXKCQTUWRXBJUQ5DOAHR/ Code of Conduct: http://python.org/psf/codeofconduct/
