[issue8406] Make some setup.py paths exclude-able

2016-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: I'm sorry if my comment was too harsh, it wasn't intended as such. I was surprised at seeing a number of e-mails about issues that were closed because they were out of date. I don't agree with closing old issues when there is actionable

[issue15661] OS X installer packages should be signed for OS X 10.8 Gatekeeper feature

2016-07-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: Ned, Can this issue be closed? The current installers on www.python.org are signed. Ronald -- ___ Python tracker <http://bugs.python.org/issue15

[issue27596] Build failure with Xcode 8 beta on OSX 10.11

2016-07-23 Thread Ronald Oussoren
New submission from Ronald Oussoren: I just noticed that building the Xcode 8 beta 2 on OSX 10.11 results in a link failure of the python binary. Based on a quick glance at the error (before switching back to Xcode 7): 1) macOS 10.12 appears to have a getentropy function that's detected

[issue27596] Build failure with Xcode 8 beta on OSX 10.11

2016-07-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: P.S. This issue is mostly a reminder for myself, Xcode 8 is still in beta and hence patches to CPython to support it are IMHO still out of scope for merging at this time. -- ___ Python tracker <h

[issue18049] Re-enable threading test on OSX

2016-07-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: The patch increases the stack size for threads to slightly less than size as is used for the main thread, see this fragment in configure.ac: # Issue #18075: the default maximum stack size (8MBytes) is too # small for the default recursion limit

[issue18181] PEP447: Add type.__getdescriptor__

2016-07-24 Thread Ronald Oussoren
Changes by Ronald Oussoren : Added file: http://bugs.python.org/file43853/pep447-2015-07-26.txt ___ Python tracker <http://bugs.python.org/issue18181> ___ ___ Python-bug

[issue27612] socket.gethostbyname resolving octal IP addresses incorrectly

2016-07-26 Thread Ronald Oussoren
Ronald Oussoren added the comment: For what it is worth: the relevant standard says that octal and hexadecimal addresses should be accepted (POSIX getaddrinfo refers to inet_addr for numeric IP addresses and that says that octal and hexadecimal numbers are valid in IP addresses), see: http

[issue27735] 'module' object has no attribute 'SIGALRM' - singal module

2016-08-11 Thread Ronald Oussoren
Ronald Oussoren added the comment: The documentation for the "SIG*" constants says: """ Note that not all systems define the same set of signal names; only those names defined by the system are defined by this module. ""

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2013-02-18 Thread Ronald Oussoren
Ronald Oussoren added the comment: Why are zipfiles without entries for directories broken? When you don't care about directory permissions (such as when the zipfile won't be extracted at all) the entries for directories are not necessary. Also, AFAIK the zipfile specifica

[issue17267] datetime.time support for '+' and 'now'

2013-02-21 Thread Ronald Oussoren
New submission from Ronald Oussoren: It would be nice if datetime.time would be possible to add a delta to a datetime.time object, and if datetime.time had a method for returning the current time (just like datetime.date and date time.datetime have 'today' and 'now' meth

[issue17267] datetime.time support for '+' and 'now'

2013-02-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: IMHO this would to module 24 arithmetic, just like a normal clock. When I do calculations with plain time that is what I want, if the date is also important I use datetime.datetime. That a time value silently truncates when going past midnight is IMHO also

[issue17269] getaddrinfo segfaults on OS X when provided with invalid arguments combinations

2013-02-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: Looks like a bug in libSystem, see mdns_addrinfo in <http://www.opensource.apple.com/source/Libinfo/Libinfo-406.17/lookup.subproj/mdns_module.c>. Its handling of AI_NUMERICSERV doesn't match that of si_getaddrinfo.c at the same location. I&#x

[issue17269] getaddrinfo segfaults on OS X when provided with invalid arguments combinations

2013-02-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: That's interesting... this also crashes: >>> socket.getaddrinfo("localhost", "0", 0, 0, 0, socket.AI_NUMERICSERV) While using another port number does not. The attached patches for the default branch fixes the issue for me (

[issue17269] getaddrinfo segfaults on OS X when provided with invalid arguments combinations

2013-02-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: I've filed radar #13271126 for this in Apple's tracker. -- ___ Python tracker <http://bugs.python.org/issue17269> ___ ___

[issue17295] __slots__ on PyVarObject subclass

2013-02-25 Thread Ronald Oussoren
New submission from Ronald Oussoren: Currently a subclass of a PyVarObject (such as 'int') cannot use a non-empty slots, for example: >>> class L (int): ...__slots__ = ('a', 'b') ... Traceback (most recent call last): File "", line 1, in

[issue17269] getaddrinfo segfaults on OS X when provided with invalid arguments combinations

2013-02-26 Thread Ronald Oussoren
Ronald Oussoren added the comment: My bug submission at Apple was closed as a duplicate of radar 13058317. Given the state of testing of getaddrinfo a testcase will be easier than expected, just pasting the call in this bugreport into the right testcase will match the style of most other

[issue17267] datetime.time support for '+' and 'now'

2013-02-26 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- keywords: +needs review nosy: +belopolsky ___ Python tracker <http://bugs.python.org/issue17267> ___ ___ Python-bugs-list mailin

[issue17267] datetime.time support for '+' and 'now'

2013-02-27 Thread Ronald Oussoren
Ronald Oussoren added the comment: datetime.time arithmetic cannot be timezone aware, as there is no associated date and hence you cannot possibly know if there it a DST transition. I don't think this is a problem. Adding/removing time to a clock value has clear real-world semantics.

[issue16848] Mac OS X: python-config --ldflags and location of Python.framework

2013-02-27 Thread Ronald Oussoren
Ronald Oussoren added the comment: With framework build from yesterday this is not fixed for python 2.7, it prints: -L/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/config -ldl -framework CoreFoundation -lpython2.7 -u _PyMac_Error Python.framework/Versions/2.7/Python The bit

[issue17053] pydoc should use inspect.signature instead of inspect.getfullargspec

2013-03-15 Thread Ronald Oussoren
Ronald Oussoren added the comment: The attached patch appears to work correctly and includes a test for pydoc (text output). There could be more testing (HTML output, annotations, positional-only arguments). With this patch I can get usable documentation for Cocoa classes with a patched

[issue17444] multiprocessing.cpu_count() should use hw.availcpu on Mac OS X

2013-03-18 Thread Ronald Oussoren
Ronald Oussoren added the comment: I'm not sure if hw.availcpu is the right value to use as it is not documented at all (neither in a manpage, nor in a headerfile). hw.activecpu seems to be the one that should be used: it is documented as "The number of processors currently ava

[issue17424] help() should use the class signature

2013-03-18 Thread Ronald Oussoren
Ronald Oussoren added the comment: If I read the code correctly help(pyth.__init__) won't use the __signature__ because that is an attribute of the type, not of the method itself. With the patch in issue17053 help should be better when __init__'s signatuer is set explicitly: c

[issue17053] pydoc should use inspect.signature instead of inspect.getfullargspec

2013-03-18 Thread Ronald Oussoren
Ronald Oussoren added the comment: See my comment in issue 17424: the code in that issue doesn't work with my patch because __signature__ is defined on the class instead of the method where help is called on. -- ___ Python tracker

[issue17053] pydoc should use inspect.signature instead of inspect.getfullargspec

2013-03-18 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- keywords: +needs review ___ Python tracker <http://bugs.python.org/issue17053> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17444] multiprocessing.cpu_count() should use hw.availcpu on Mac OS X

2013-03-19 Thread Ronald Oussoren
Ronald Oussoren added the comment: I also like the os.cpu_count() function, the information is useful sometimes outside of multiprocessing, and calling out to external scripts to gather the information (as multiprocessing currently does) feels yucky. That should probably be a new issue, the

[issue17295] __slots__ on PyVarObject subclass

2013-03-19 Thread Ronald Oussoren
Ronald Oussoren added the comment: You're right, this is a duplicate. -- resolution: -> duplicate stage: needs patch -> committed/rejected superseder: -> __slots__ for subclasses of variable length types type: -> behavior ___ Pyth

[issue1173475] __slots__ for subclasses of variable length types

2013-03-19 Thread Ronald Oussoren
Ronald Oussoren added the comment: I do have a usecase for this: subclasses of int. Having slots would be nice for a reasonably efficient implementation of named constants (as recently discussed on python-ideas), and I'm already using a subclass of int of PyObjC to attach a single

[issue17053] pydoc should use inspect.signature instead of inspect.getfullargspec

2013-03-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: * renamed "render" method of inspect.Parameter and inspect.Signature to "_render" to avoid changing the public API * updated patch for current tip (I got a merge conflict when pulling in the tip due to a patch for Lib/test/test_pydoc.p

[issue17496] OS X test for Tk availability in runtktests.py doesn't work

2013-03-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: A small helper program that does the equavalent of this should also work: import Cocoa Cocoa.NSWindow.alloc().initWithContentRect_styleMask_backing_defer_(((10, 10), (100, 100)), 0, 0, 0) If this code raises an exception you cannot create windows, if it

[issue17496] OS X test for Tk availability in runtktests.py doesn't work

2013-03-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: Wouldn't it be better to check for the actual problem, that is use subprocess to start a small Tcl script that creates a window and check if that crashes? That way the code for disabling the test doesn't have to try to guess whether or not Tk wil

[issue17512] backport of the _sysconfigdata.py module (issue 13150) breaks the build on darwin

2013-03-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: Reverting the backport would also fix the breakage. Is the addition of _sysconfigdata not a new feature? It changes the place where sysconfig (and distutils sysconfig?) looks for configuration data, and hence breaks all instructions that mention that you can

[issue17512] backport of the _sysconfigdata.py module (issue 13150) breaks the build on darwin

2013-03-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: Guess what, I hadn't read the thread on this python-dev yet :-( -- ___ Python tracker <http://bugs.python.org/is

[issue17609] IDLE: Remove config option 'editor on startup' and utilize command line options only

2013-04-01 Thread Ronald Oussoren
Ronald Oussoren added the comment: I agree with the change, but keep in mind that at least on OSX a lot of users start IDLE by double clicking on the IDLE application in the Finder (or double-clicking a .py file) and as such don't have an easy way to specify the -e or -i op

[issue14455] plistlib unable to read json and binary plist files

2013-04-01 Thread Ronald Oussoren
Ronald Oussoren added the comment: d9pouces: are you willing to sign a contributor agreement? The agreement is needed before we can add these changes to the stdlib, and I'd like to that for the 3.4 release. More information on the contributor agreement: http://www.python.org/psf/co

[issue17654] IDLE only customizes correctly for OS X when using framework build

2013-04-10 Thread Ronald Oussoren
Ronald Oussoren added the comment: The trigger for the customizations is probably too specific. The primary reason for a having a check that's more specific than 'if sys.platform == "darwin"' is to avoid using the customizations when someone uses an X11 build of T

[issue17695] _sysconfigdata broken with universal builds on OSX

2013-04-10 Thread Ronald Oussoren
New submission from Ronald Oussoren: The _sysconfig module contains the definitions for sysconfig.get_config_var and is created during python's build. The definitions in _sysconfig.py for #define macros redefined in pymacconfig.h are wrong when building a universal build of Python

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-04-15 Thread Ronald Oussoren
Ronald Oussoren added the comment: I agree that plistlib shouldn't raise an exception for data that can represented as a valid plist file. I've checked that the Cocoa class for generating plist files will happily create a plist file when the data is nested 100 levels deep. In

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-04-15 Thread Ronald Oussoren
Ronald Oussoren added the comment: The attach patch should fix the issue (but there needs to be a unittest as well). -- Added file: http://bugs.python.org/file29863/issue-17353.txt ___ Python tracker <http://bugs.python.org/issue17

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-04-17 Thread Ronald Oussoren
Ronald Oussoren added the comment: The tests look good, thanks for writing them. -- ___ Python tracker <http://bugs.python.org/issue17353> ___ ___ Python-bug

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-04-23 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue17353> ___ ___ Python-bugs-list

[issue17496] OS X test for Tk availability in runtktests.py doesn't work

2013-04-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: The attached patch start wish and stops it by sending the 'exit' command. With the patch I can run the tk tests without getting a skip. I cannot easily test if the patch also does the right thing on buildbots, but have high hopes. I did check

[issue17269] getaddrinfo segfaults on OS X when provided with invalid arguments combinations

2013-04-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: I've updated the patch: it now contains a testcase (although the getaddrinfo tests are stretching the definition of the word, the new test only checks that the function doesn't crash) -- Added file: http://bugs.python.org/file29991/issue

[issue12958] test_socket failures on Mac OS X

2013-04-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: Not sure what changed, but these tests are reported as failures when I run 'make test' and not as expected failures. -- nosy: +ronaldoussoren versions: +Python 3.4 ___ Python tracker <http://bu

[issue12958] test_socket failures on Mac OS X

2013-04-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: Yes, only on 3.4: == ERROR: testFDPassSeparate (test.test_socket.RecvmsgSCMRightsStreamTest) -- Traceback (most recent call

[issue12958] test_socket failures on Mac OS X

2013-04-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: FWIW I've filed a bug report about the behavior of sendmsg with Apple, the RADAR number is 13716133. -- ___ Python tracker <http://bugs.python.org/is

[issue17866] TestCase.assertItemsEqual exists in 2.7, not in 3.3

2013-04-29 Thread Ronald Oussoren
New submission from Ronald Oussoren: assertItemsEqual was added to unittest.TestCase in Python 2.7 (according to the documentation), but is not present in Python 3.3. I'd expect it to be present in 3.3 as well, or for it to be mentioned in documentation as not being present (either in th

[issue17866] TestCase.assertItemsEqual exists in 2.7, not in 3.3

2013-04-29 Thread Ronald Oussoren
Ronald Oussoren added the comment: I do think this should be mentioned in the 2.7 docs, assertDictContainsSubset is mentioned as "deprecated since 3.2" in the 2.7 docs. The only problem with that is that there doesn't seem to be a "versionremoved" directive in sphi

[issue17866] TestCase.assertItemsEqual exists in 2.7, not in 3.3

2013-04-29 Thread Ronald Oussoren
Ronald Oussoren added the comment: You're right, according to #10242 the method was renamed in 3.2. Something like the attached patch? I'm somewhat flabbergasted that #10242 came to the conclusion that it would be a good idea to rename this method, given the folks that contr

[issue17866] TestCase.assertItemsEqual exists in 2.7, not in 3.3

2013-04-29 Thread Ronald Oussoren
Ronald Oussoren added the comment: Your patch looks good. -- ___ Python tracker <http://bugs.python.org/issue17866> ___ ___ Python-bugs-list mailing list Unsub

[issue16141] Possible simplification for old-style exception handling code in stdlib

2013-05-01 Thread Ronald Oussoren
Ronald Oussoren added the comment: Shouldn't this issue be closed? (the proposed patch was applied in Oct. last year) -- nosy: +ronaldoussoren ___ Python tracker <http://bugs.python.org/is

[issue5845] rlcompleter should be enabled automatically

2013-05-06 Thread Ronald Oussoren
Ronald Oussoren added the comment: I expect that a lot of users use the tab key to indent in the repl (as well as in editors, smart enough editors can convert the tab presses to spaces) -- ___ Python tracker <http://bugs.python.org/issue5

[issue17932] Win64: possible integer overflow in iterobject.c

2013-05-08 Thread Ronald Oussoren
Ronald Oussoren added the comment: Create a class with a __getitem__ method but no __iter__: class Seq (object): def __len__(self): return 5 def __getitem__(self, idx): if idx > len(self): raise IndexError(idx) return idx * 2 i = iter(

[issue17973] '+=' on a list inside tuple both succeeds and raises an exception

2013-05-14 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- assignee: -> ronaldoussoren ___ Python tracker <http://bugs.python.org/issue17973> ___ ___ Python-bugs-list mailing list Un

[issue17973] '+=' on a list inside tuple both succeeds and raises an exception

2013-05-14 Thread Ronald Oussoren
Ronald Oussoren added the comment: This is a side effect to the way the in place operators work. Basically "a[0] += [3]" is evaluated as: a[0] = a[0].__iadd__([3]) The call to __iadd__ succeeds, which is why the list is updated, but you get an exception when the interprete

[issue17973] '+=' on a list inside tuple both succeeds and raises an exception

2013-05-14 Thread Ronald Oussoren
Ronald Oussoren added the comment: I'm closing this issue as rejected because the current behavior is intentional, although it is confusing (IMO). -- resolution: -> rejected status: open -> closed ___ Python tracker <http://b

[issue17128] OS X system openssl deprecated - installer should build local libssl

2013-05-14 Thread Ronald Oussoren
Ronald Oussoren added the comment: The RVM issue is wrong, ML still includes OpenSSL. Apple has deprecated the use of the system install of OpenSSL, but the library and include files are still there. There are two paths for avoiding the deprecated library: either ship your own build of

[issue17128] OS X system openssl deprecated - installer should build local libssl

2013-05-14 Thread Ronald Oussoren
Ronald Oussoren added the comment: The one difference between the system openssl and a separately compiled one is that the former can use the CA root from the KeyChain (and uses a private API to do that, as noted earlier). I just stumbled across a utility that can sync the KeyChain to an

[issue17973] '+=' on a list inside tuple both succeeds and raises an exception

2013-05-17 Thread Ronald Oussoren
Ronald Oussoren added the comment: You've got a point there. What about this patch (but then with proper english grammer)? BTW. Actually fixing this wart would be possible, but at a significant cost: you'd have to change the implementation of LHS += RHS from: tmp = LHS

[issue17973] FAQ entry for: '+=' on a list inside tuple both succeeds and raises an exception

2013-05-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: David: your update to the FAQ looks ok to me. I don't like updating the __setitem__ of tuple to allow setting an identical value (that is 'a[0] = a[0]'), it is a bit too magic to my taste and hides the real problem. I'd slightly prefer

[issue17973] FAQ entry for: '+=' on a list inside tuple both succeeds and raises an exception

2013-05-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: issue-17973-experimental.txt is a very crude first attempt at catching augment assignment to an immutable LHS. On first glance the code works, but it causes problems in the test suite and hence isn't correct yet. The generated code also isn't op

[issue17973] FAQ entry for: '+=' on a list inside tuple both succeeds and raises an exception

2013-05-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: Allowing the operation to succeed wouldn't be right, you are assigning to an immutable location after all. -- ___ Python tracker <http://bugs.python.org/is

[issue17973] FAQ entry for: '+=' on a list inside tuple both succeeds and raises an exception

2013-05-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: I agree that there's probably no good solution here. Catching TypeError would require emitting a lot more byte code, and would change the semantics of augmented assignment, in particular it wouldn't really be an assignment statement anymore (and

[issue17269] getaddrinfo segfaults on OS X when provided with invalid arguments combinations

2013-05-24 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue11101] plistlib has no graceful way of handing None values

2013-05-24 Thread Ronald Oussoren
Ronald Oussoren added the comment: At first I didn't like the proposal, but when I looked at the JSON module I noticed it has similar functionality for ignoring keys that cannot be represented in a JSON file. I'll look into this after merging #14455. The JSON library has two oth

[issue18049] Re-enable threading test on OSX

2013-05-24 Thread Ronald Oussoren
New submission from Ronald Oussoren: I recently notied that test.test_threading.ThreadingExceptionTests.test_recursion_limit is disabled for debug builds. The attached patch re-enables this test case and fixes the crash be increasing the stack size for new threads. The disadvantage of the

[issue14455] plistlib unable to read json and binary plist files

2013-05-24 Thread Ronald Oussoren
Ronald Oussoren added the comment: I've started work on integrating the latest patch. Some notes (primarily for my own use): * I'll drop support for the JSON format, that format is not used by Apple's libraries (although the plutil tool can convert plists to JSO

[issue22490] Using realpath for __PYVENV_LAUNCHER__ makes Homebrew installs fragile

2014-10-19 Thread Ronald Oussoren
Ronald Oussoren added the comment: First of all, sorry about the slow response. Vinay: I don't quite understand why you use __PYVENV_LAUNCHER__: When I create a pyvenv using python 3.3 (with a oldish build from the 3.3 branch) sys.executable point to a binary in the venv without mucking

[issue22490] Using realpath for __PYVENV_LAUNCHER__ makes Homebrew installs fragile

2014-11-10 Thread Ronald Oussoren
Ronald Oussoren added the comment: The environment variable itself cannot be removed from CPython, it is necessary to implement the correct behavior of pyvenv with framework builds of Python. That said, I do think that the environment variable should be unset as soon as possible in the

[issue22939] integer overflow in iterator object

2014-12-30 Thread Ronald Oussoren
Ronald Oussoren added the comment: Is it necessary to raise when it_index is PY_SSIZE_T_MAX? An alternative is to set it_index to -1 when there would be overflow and raise an exception on the next call to next(). That way a virtual sequence with PY_SSIZE_T_MAX-1 items would still work

[issue24290] c_uint32 bitfields break structures

2015-05-26 Thread Ronald Oussoren
Ronald Oussoren added the comment: You forgot to actually attach the code. -- nosy: +ronaldoussoren ___ Python tracker <http://bugs.python.org/issue24290> ___ ___

[issue24380] Got warning when compiling _scproxy.c on Mac

2015-06-17 Thread Ronald Oussoren
Ronald Oussoren added the comment: The patch is not correct. You're probably building with a new enough version of OSX as the deployment target. _scproxy.c should recognise this and should only perform the != NULL test when the variable address might be NULL.

[issue24464] Got warning when compiling sqlite3 module on Mac OSX

2015-06-21 Thread Ronald Oussoren
Ronald Oussoren added the comment: <https://www.sqlite.org/c3ref/enable_shared_cache.html> appears to indicate that the function is deprecated on OSX 10.7 and iOS 5.0, but looking at the latest sources on sqlite.org that's not the case, the warning in the documentation appears to

[issue24573] Using multiprocessing with tkinter frames in Python 3.4.3 crashes in OS X

2015-07-06 Thread Ronald Oussoren
Ronald Oussoren added the comment: This is likely a known issue with using os.fork on OSX: that is unsafe, and likely causes crashes, once one of Apple's frameworks has initialized. I think it might be better in the long run to make multiprocessing on OSX behave the same as on windows

[issue24633] Not a directory: '//anaconda/lib/python2.7/site-packages/readme/__about__.py'

2015-07-14 Thread Ronald Oussoren
Ronald Oussoren added the comment: I agree with Robert: renaming the file to README.txt would be a good idea regardless to enable easily opening the file with a GUI editor and as a bonus removes any change of conflict with a package name. The patch looks good to me

[issue24621] zipfile.BadZipFile: File is not a zip file

2015-07-16 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- nosy: +ronaldoussoren ___ Python tracker <http://bugs.python.org/issue24621> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24646] Python accepts SSL certificate that should be rejected on OSX

2015-07-17 Thread Ronald Oussoren
Ronald Oussoren added the comment: The fork of OpenSSL that Apple ships also looks at the CA list in the Keychain. IIRC that cannot be disabled. BTW. Annoyingly this fork uses a private API to access the keychain, which means we couldn't optionally use this behavior when not using Ap

[issue24658] open().write() fails on 2 GB+ data (OS X)

2015-07-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: This is likely a platform bug, it fails with os.write as well. Interestingly enough file.write works fine on Python 2.7 (which uses stdio), that appearently works around this kernel misfeature. A possible partial workaround is recognise this error in the

[issue24646] Python accepts SSL certificate that should be rejected on OSX

2015-07-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: Using our own OpenSSL build should be saver in the long run anyway. Apple provides enough API’s to reproduce the behaviour of Apple’s build in a cleaner way (by making the loading of system CA certs an explicit action). Problem is: that likely requires

[issue24658] open().write() fails on 2 GB+ data (OS X)

2015-07-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: The attached patch is a first stab at a workaround. It will unconditionally limit the write size in os.write to INT_MAX on OSX. I haven't tested yet if this actually fixes the problem mentioned on stack overflow. -- keywords: +needs review,

[issue24646] Python accepts SSL certificate that should be rejected on OSX

2015-07-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: I'll check, but they probably are because the use data structures from CoreFoundation. -- ___ Python tracker <http://bugs.python.org/is

[issue24646] Python accepts SSL certificate that should be rejected on OSX

2015-07-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: BTW. I think someone (me?) should write down the problems with using higher levels in the API stack w.r.t. os.fork in a PEP-style document. This can then be used to decide whether or not we want to use such APIs in the stdlib (and if so, what should be

[issue24658] open().write() fails on 2 GB+ data (OS X)

2015-07-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: The patch limits os.write to writing at most INT_MAX bytes on OSX. Buffered I/O using open("/some/file", "wb") should still write all data (at least according to the limited tests I've done so far). The same limitation is already pr

[issue24658] open().write() fails on 2 GB+ data (OS X)

2015-07-20 Thread Ronald Oussoren
Ronald Oussoren added the comment: The patch I attached earlier is for the default branch. More work is needed for the other active branches. -- ___ Python tracker <http://bugs.python.org/issue24

[issue24683] Type confusion in json encoding

2015-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: In encoder_init (the __init__ for _json.Encoder) s->marker is set to an argument of __init__, without any kind of type check, it can therefore be an arbitrary object. encoder_listencode_obj (and other functions) then use s->markers with the concrete A

[issue24646] Python accepts SSL certificate that should be rejected on OSX

2015-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: The attached program (which is pure C except for a call to NSLog) calls SecTrustCopyAnchorCertificates in a child process (and with a minor change the other function as well). This doesn't crash for me. However, that doesn't really mean anythin

[issue24658] open().write() fails on 2 GB+ data (OS X)

2015-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: Indeed, read(2) has the same problem. I just tested this with a small C program. I'll rework the patch for this, and will work on patches for 3.4/3.5 and 2.7 as well. -- ___ Python tracker

[issue20585] urllib2 unrelease KQUEUE on Mac OSX 10.9+

2015-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: I don't think it is possible to fix this crash other than by removing the use of _scproxy (proxy autodection on OSX) completely. Problem is that Apple's higher level APIs (such as those used in _scproxy) don't take the use-case of calling f

[issue9850] obsolete macpath module dangerously broken and should be removed

2015-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: I think it is by now safe to remove macpath, AFAIK there is no real use-case anymore for having classic MacOS9 paths on any recentish version of OSX.] I'm setting the version to 3.6 because it is too late to do this for Python 3.5, but it can be done fo

[issue24686] zipfile is intolerant of extra bytes

2015-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: The actual exception you're getting is IMHO a bug, it should have been a zipfile.BadZipfile exception. That said, it might be useful to teach zipfile to optionally be a little more forgiving about errors like this when reading a zipfile. I'm at

[issue18181] PEP447: Add type.__getdescriptor__

2015-07-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: Updated the title and versions, will work on an updated PEP and patch during and after EP'15. -- title: PEP447: Add type.__locallookup__ -> PEP447: Add type.__getdescriptor__ versions: +Python 3.6 -Py

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: ping... I think the current behavior is a bug in Python and should be fixed in 2.7, 3.4, 3.5 and default (using Dmitry's patch). I'd like to commit the patch, but would like someone else's review of the patch

[issue18181] PEP447: Add type.__getdescriptor__

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: I've attached a new version of the patch (pep447-2015-07-25.txt). Changes in this version of the patch: 1) Works with the current trunk (as in "all tests pass") 2) Types in C must explicitly set Py_TPFLAGS_GETDESCRIPTOR in tp_flags to

[issue18181] PEP447: Add type.__getdescriptor__

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: The attached micro benchmark indicates that method_cache in typeobject.c isn't used when using my patch. I'll have too look into that. Other than that benchmarks results look OK (but: not using the method_cache is unacceptable as this most definite

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: The only locale that doesn't include language information is the UTF-8 one, there is no locale named "US-ASCII". See /usr/share/locale on an OSX system. PS. The more I look at locale.py the more problems I find with it. The code make

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: The alias mechanism cannot be used because LC_CTYPE=UTF-8 as the locale doesn't imply anything about languages. In Linux terms it is more or less equal to "C.UTF-8" or "POSIX.UTF-8", except that those two ar

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: Testing this is interesting to say the least due to the dynamic way the module interface is built. Serhiy: are you testing on a Linux machine? On my machine getpreferredencoding() returns 'UTF-8' because it hits the CODESET path (which ends

[issue18378] locale.getdefaultlocale() fails on Mac OS X with default language set to English

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: I've attached a patch with more tests, but I'm not to happy about the new test because it too much of a white box test and is therefore fairly fragile w.r.t. the actual implementation of the module. -- Added file: http://bugs.python.org

[issue18181] PEP447: Add type.__getdescriptor__

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: pep447-2015-07-25-v2.txt changes two things w.r.t. the patch earlier today: 1) The performance problems w.r.t. the method_cache are gone 2) Added code for handling python exceptions other than AttributeError in calls to __getdescriptor__. This code

[issue18181] PEP447: Add type.__getdescriptor__

2015-07-25 Thread Ronald Oussoren
Ronald Oussoren added the comment: Note: the error handling code for exceptions in __getdescriptor__ definitely isn't good enough yet. I'm writing tests and am hunting down the problems those tests find. I'm getting closer and will post a new version when I think I&#x

[issue24725] test_socket testFDPassEmpty fails on OS X 10.11 DP with "Cannot allocate memory"

2015-07-26 Thread Ronald Oussoren
Ronald Oussoren added the comment: I agree this needs a radar when it works on older releases of the OS and not on the 10.11 beta's. -- ___ Python tracker <http://bugs.python.org/is

<    19   20   21   22   23   24   25   >