Florent Xicluna added the comment:
actually, there's a simpler implementation, using s.rstrip(always_safe + safe).
It is as fast as the previous one.
--
Added file: http://bugs.python.org/file17298/issue1285086_using_rstrip.diff
___
Python tr
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file17299/urllib_quote_speed_test.py
___
Python tracker
<http://bugs.python.org/issue1285086>
___
___
Pytho
Florent Xicluna added the comment:
afaict, it needs backport to 2.7.
--
components: +Tests
nosy: +flox
stage: -> commit review
status: closed -> open
type: -> crash
versions: +Python 2.7 -Python 3.2
___
Python tracker
<http://bug
Florent Xicluna added the comment:
It fails on "x86 Tiger trunk" buildbot, too.
(the PPC Tiger buildbot is happy)
--
keywords: +buildbot
nosy: +flox
___
Python tracker
<http://bugs.python.
Changes by Florent Xicluna :
--
assignee: -> ronaldoussoren
components: +Macintosh, Tests
nosy: +flox, mark.dickinson, michael.foord, ned.deily, ronaldoussoren
stage: -> needs patch
type: -> behavior
versions: +Python 2.7
___
Python track
Florent Xicluna added the comment:
Some diagnosis information ...
- happens for 2 tests inside test_pep277: test_listdir and test_normalize
- happens only for 4 weird filenames (added with #8180)
- happens only on "x86 Tiger" buildbot ("PPC Tiger" does not report thi
Florent Xicluna added the comment:
The gory details...
>>> import os, unicodedata
>>> tempdir = u'temp_pep277'
>>> name = u'\u0385\u03d3\u03d4'
>>> os.mkdir(tempdir)
>>> with open(os.path.join(tempdir, name), 'w') as f:
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue7980>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue11108>
___
___
Python-bugs-list mailing list
Unsubscribe:
Florent Xicluna added the comment:
Actuallly, the assertions were commented in the upstream repository.
https://bitbucket.org/effbot/et-2009-provolone/src/9e9e7f2710aa/elementtree/CHANGES#cl-46
> (1.3a6 released)
> - Removed most assert statements from the Element and ElementTree code
Florent Xicluna added the comment:
> If possible I would avoid pyElementTree,
Me too:
- __name__ and __qualname__ would be less confusing
- the cElementTree accelerator uses large parts of Python implementation
> ElementTree is different - it's pretty much two separate impleme
Florent Xicluna added the comment:
The first step is to strip out the cElementTree bootstrap code from the C
module.
I did it in the attached patch (plus removal of obsolete code for copy() in
Python 2.4).
This passes the unmodified tests "test_xml_etree" and "test_xml_etree_c&
Florent Xicluna added the comment:
> Anyhow, I tried to apply it and a few tests in test_xml_etree_c fail,
> because it can't find fromstring and fromstringlist.
Ooops, I cut some redundancy after running the tests, and I forgot to re-add
the import. You're right.
> H
Florent Xicluna added the comment:
Updated patch:
- fixed missing import and missing alias
- moved the XMLTreeBuilder alias to the Python module
--
___
Python tracker
<http://bugs.python.org/issue13
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file24485/issue13988_prepare_pep399_v2.diff
___
Python tracker
<http://bugs.python.org/issue13988>
___
___
Florent Xicluna added the comment:
I've pushed this first part, which is just a code refactoring.
I tried to work out a patch for the second part.
The tricky thing is because of xml.etree still using doctests.
The patch for the tests seems to be enough small and readable.
We have
Florent Xicluna added the comment:
There was a discussion in December which ruled out some CPython too specific
implementation details from the documentation.
http://mail.python.org/pipermail/python-dev/2011-December/115063.html
Maybe it's better to remove these 2 lines about the "t
Florent Xicluna added the comment:
Updated patch:
- add 'XMLID' and 'register_namespace' to the ElementTree.__all__
- the comment says explicitly that cElementTree is deprecated
- exercise the deprecated module with the tests
--
Added file:
http://bugs.
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue13997>
___
___
Python-bugs-list mailing list
Unsubscribe:
Florent Xicluna added the comment:
> from xml.etree.ElementTree import _namespace_map
>
> And the import in cElementTree won't be necessary.
> After all, _namespace_map is definitely not a public API!
Because of the interaction of the support.import_fresh_module with the
Cle
Florent Xicluna added the comment:
Now the merge is done. Thank you Eli for the effort, and to the other
contributors for the review.
Following topics may need further work:
- add a Deprecation warning for cElementTree? it will annoy the package
maintainers which support both 3.2 and
Changes by Florent Xicluna :
--
components: +XML
nosy: +flox
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue14001>
___
___
Python-bug
Florent Xicluna added the comment:
For the doctype() issue, it might be removed, since it was already deprecated
in 3.2 (in compliance with PEP 387). However the deprecation cycle is under
discussion for the 3.x serie. (issue 13248)
For subclassing, you hit the same issue for all the
Changes by Florent Xicluna :
--
resolution: -> duplicate
status: open -> closed
superseder: -> Unupdated source file in traceback
___
Python tracker
<http://bugs.python.or
New submission from Florent Xicluna :
While writing tests xml.etree, I hit a strange behaviour of import_fresh_module.
How to reproduce:
- dummy/__init__.py
- dummy/foo.py
- dummy/bar.py
- test_fresh_import.py
# 'dummy/foo.py'
from dummy.bar import func
# 'dummy/bar.py
Changes by Florent Xicluna :
--
nosy: +ezio.melotti
___
Python tracker
<http://bugs.python.org/issue14035>
___
___
Python-bugs-list mailing list
Unsubscribe:
Florent Xicluna added the comment:
Trigger the same behavior without import_fresh_module. (test_fresh_import2.py)
If you uncomment line #A or #B, it succeed.
On the other side, if you comment line #C or #D, it succeed too.
The import machinery is a bit complex, indeed ...
--
nosy
Florent Xicluna added the comment:
Keeping reference of fresh modules solves the issue.
--
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file24537/issue14035_fresh_modules.diff
___
Python tracker
&l
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue812369>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file24537/issue14035_fresh_modules.diff
___
Python tracker
<http://bugs.python.org/issue14035>
___
___
Florent Xicluna added the comment:
I have updated the patch to a simpler form where I copy() sys.modules.
Strangely, I do not detect any refleak running the tests.
I plan to commit this fix, if we don't have leaks in the test suite.
--
resolution: -> duplicate
Added fi
Changes by Florent Xicluna :
--
nosy: +effbot
___
Python tracker
<http://bugs.python.org/issue14128>
___
___
Python-bugs-list mailing list
Unsubscribe:
Florent Xicluna added the comment:
the class versus factory issue is gone to issue 14128.
The current issue is only about the doctype() method missing in the C
implementation.
I propose to drop this deprecated method from the Python version, instead of
implementing the deprecated method in
Florent Xicluna added the comment:
I understand the point about compatibility.
However it is slightly different here, because the method is already deprecated
in Python 2.7 and 3.2, with a warning in the documentation and a
DeprecationWarning at runtime.
This method was never available in the
Florent Xicluna added the comment:
This last feature (doctype handler on custom TreeBuilder) does not have tests...
So, it is certainly broken with the C implementation.
--
stage: needs patch -> test needed
___
Python tracker
&l
Florent Xicluna added the comment:
Same on OSX, building trunk (3.3.0a0)
$ uname -v
Darwin Kernel Version 10.8.0: Tue Jun 7 16:32:41 PDT 2011;
root:xnu-1504.15.3~1/RELEASE_X86_64
$ gcc --version
i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5666) (dot 3)
$ ./configure
Changes by Florent Xicluna :
--
assignee: ronaldoussoren ->
___
Python tracker
<http://bugs.python.org/issue14085>
___
___
Python-bugs-list mailing list
Un
Florent Xicluna added the comment:
Two other differences:
* the C TreeBuilder has an undocumented and unused method "xml"
* if you omit one of the TreeBuilder method (start(), end(), data(), close())
on you custom TreeBuilder implementation, the C XMLParser works fine, but t
Florent Xicluna added the comment:
FWIW, Fredrik, who is the creator of ElementTree, had a preference for JavaDoc
conventions, as explained here: http://bugs.python.org/issue6488#msg102087
They are compatible with the tool PythonDoc, authored by Fredrik too:
http://www.effbot.org/zone
Changes by Florent Xicluna :
--
stage: -> patch review
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue14164>
___
___
Python-bugs-lis
New submission from Florent Xicluna :
The links for the latest RC are broken on the official page.
http://www.python.org/download/
And the "release" page only list 3.2.3 rc1 and forget the other 3:
http://www.python.org/download/releases/
--
messages: 154762
nosy: flo
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue14208>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
nosy: +flox
title: __dict__ = self in subclass of dict causes a memory leak? -> __dict__ =
self in subclass of dict causes a memory leak
___
Python tracker
<http://bugs.python.org/issue1
Florent Xicluna added the comment:
It breaks the compilation on few buildbots.
Python/import.c:130:14: error: #if with no expression
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue6
Florent Xicluna added the comment:
If someone else is looking for the PyPI SSH support, it's there.
http://pypi.python.org/pypi/pypissh
(I did not find it mentioned in the tutorial)
Thanks Martin.
--
nosy: +flox
___
Python tracker
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue12643>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue4600>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Florent Xicluna :
This is probably a bug.
>>> class A:
... def f(self, __a=42):
... pass
...
>>> A().f()
>>> class A:
... def f(self, *, __a=42):
... pass
...
>>> A().f()
Traceback (most recent call last):
File "&q
Changes by Florent Xicluna :
--
components: +Windows
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue14608>
___
___
Python-bugs-list mailin
New submission from Florent Xicluna:
While testing wsgiref w.r.t RFC2616, I noticed that it sets the Content-Length
to 0 when the application returns 304 Not Modified.
This is a violation of RFC 2616 section 10.3.5.
And the net effect is a weird bug with some browsers (tested with Chrome 27
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue18167>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Florent Xicluna:
I noticed a minor issue with regrtest.
IMHO it should assume --randomize when you pass --randseed.
--
assignee: flox
components: Tests
messages: 192401
nosy: flox
priority: normal
severity: normal
stage: needs patch
status: open
title: python -m
New submission from Florent Xicluna:
It would be useful to display the number of processes used to run the test
suite.
(some buildbots have multiple -j on the command line, and it is unclear which
one is effective)
Proposal (on the third line):
== CPython 3.4.0a0 (default:6d278f426417, Jul
Changes by Florent Xicluna :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue18376>
___
___
Python-bugs-list mai
Changes by Florent Xicluna :
--
keywords: +patch
Added file:
http://bugs.python.org/file30798/issue18376_regrtest_count_processes.diff
___
Python tracker
<http://bugs.python.org/issue18
New submission from Florent Xicluna:
Running the test suite with -Wd, we got the warning:
[247/375] test_warnings
Warning -- warnings.filters was modified by test_warnings
This is how to reproduce:
./python -Wd
import warnings
from test import support
saved = warnings.filters.copy
Florent Xicluna added the comment:
Much simpler:
$ ./python -Wd
import warnings
import sys
saved = warnings.filters.copy()
del sys.modules['warnings']
import warnings
assert warnings.filters != saved
assert warnings.filters.pop(0) = warnings.filters[0]
assert warnings.filter
Florent Xicluna added the comment:
This patch fixes the issue.
--
keywords: +patch
stage: needs patch -> patch review
Added file:
http://bugs.python.org/file30817/issue18383_test_warnings_filters.diff
___
Python tracker
<http://bugs.pyth
New submission from Florent Xicluna:
It happens when POSTing a file for example.
When running the test suite:
./python.exe -m test test_cgi
Or with the script attached:
$ ./python test_fieldstorage.py
test_fieldstorage.py:28: ResourceWarning: unclosed file <_io.BufferedRandom
nam
Florent Xicluna added the comment:
Fix committed, with tests.
--
resolution: -> fixed
status: open -> closed
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/i
New submission from Florent Xicluna :
pydoc fails on custom instances in specific cases. (When instance __name__ does
not resolve to a str).
This is a small example:
>>> import pydoc
>>> class A:
... def __getattr__(self, name):
... return True
...
>>> print(
Florent Xicluna added the comment:
It seems the documentation is not enough accurate.
"Unlike the StringIO module, this module is not able to accept Unicode strings
that cannot be encoded as plain ASCII strings."
I understand that u'foo' can be encoded as plan ASCII,
Florent Xicluna added the comment:
Simpler test case:
class A:
x = 42
y = [x for _ in '1']
The semantics of list comprehension changed with Python 3.
However, I do not see this specific behavior documented somewhere.
http://docs.python.org/dev/whatsnew/3.0.html#chan
Florent Xicluna added the comment:
This is a duplicate of issue 11796.
See also issue 13557:
http://bugs.python.org/issue13557#msg154174
For Python 3, a list comprehension defines a block pretty much like the method
definition during the class creation:
class x:
x = 1
def incx
Changes by Florent Xicluna :
--
nosy: +anikom15, flox, josmiley
___
Python tracker
<http://bugs.python.org/issue11796>
___
___
Python-bugs-list mailing list
Unsub
New submission from Florent Xicluna :
I've hit this issue while playing with tokenize for the pep8.py module.
The tokenize detect_encoding() should report SyntaxError when the encoding is
improperly declared.
However it raises a LookupError in some cases.
$ ./python -m tokenize Lib
Florent Xicluna added the comment:
This patch seems to fix the issue.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file25805/issue14990_detect_encoding.diff
___
Python tracker
<http://bugs.pyth
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue13598>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue14998>
___
___
Python-bugs-list mailing list
Unsubscribe:
Florent Xicluna added the comment:
It should raise a SyntaxError, if coding is 'utf8'.
I don't agree with the last patch proposed.
If the import report a SyntaxError, 'tokenize' should do the same.
$ ./python Lib/test/bad_coding2.py
File "Lib/test/bad_c
New submission from Florent Xicluna :
With Python 2.7, both b'hello' and br'hello' are wrong.
With Python 3.3, b'hello' is wrong.
$ python2.7 -m tokenize <<<"'hello', u'hello', ur'hello', b'hello', br'hel
Florent Xicluna added the comment:
> File "/home/eliben/python-src/33/Lib/test/regrtest.py", line 710 in main
> File "/home/eliben/python-src/33/Lib/test/regrtest.py", line 1829 in
>
> File "/home/eliben/python-src/33/Lib/runpy.py", line 75 in _
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue15068>
___
___
Python-bugs-list mailing list
Unsubscribe:
Florent Xicluna added the comment:
The werkzeug.urls module has examples of such conversion IRI-to-URI:
https://github.com/mitsuhiko/werkzeug/blob/master/werkzeug/urls.py#L109,L205
--
___
Python tracker
<http://bugs.python.org/issue9
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue805255>
___
___
Python-bugs-list mailing list
Unsubscribe:
Florent Xicluna added the comment:
LGTM too. Thanks.
--
___
Python tracker
<http://bugs.python.org/issue15054>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue13823>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
nosy: +aronacher, flox
___
Python tracker
<http://bugs.python.org/issue15096>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
nosy: +vinay.sajip
___
Python tracker
<http://bugs.python.org/issue15096>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue12014>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Florent Xicluna :
--
components: +IO
nosy: +flox
___
Python tracker
<http://bugs.python.org/issue15100>
___
___
Python-bugs-list mailing list
Unsub
Florent Xicluna added the comment:
I don't see a valid use case to support "-" in the name of the positional
argument.
IMHO, it should raise an error (probably a ValueError) for the add_argument in
this case ...
Or we keep it as-is and close as wont-fix: if the op wants t
Florent Xicluna added the comment:
Confirmed.
It should probably raise an ArgumentError like this one.
http://docs.python.org/library/argparse.html#conflict-handler
--
components: +Library (Lib)
nosy: +flox
stage: -> needs patch
versions: +Python
Florent Xicluna added the comment:
Thanks. Fixed in trunk too, changeset b4322ad1fec4
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Florent Xicluna :
--
nosy: +flox
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue8881>
___
___
Python-bugs-lis
Florent Xicluna added the comment:
Do we agree to remove the "max_buffer_size" from the "io" module in 3.3?
This argument is unused, and deprecated. Just dead code.
See attachment.
--
Added file: http://bugs.python.org/file26297/issue13248_io_
Changes by Florent Xicluna :
Removed file:
http://bugs.python.org/file23928/issue13248_argparse_io_lib2to3.diff
___
Python tracker
<http://bugs.python.org/issue13
Florent Xicluna added the comment:
For the implementation part, there's something which already plays with the BOM
in the tokenize module.
See tokenize.open(), which uses tokenize.detect_encoding() to read the BOM in
some cases.
--
nosy:
Changes by Florent Xicluna :
Removed file: http://bugs.python.org/file23929/issue13248_obsolescence_v2.diff
___
Python tracker
<http://bugs.python.org/issue13248>
___
___
Changes by Florent Xicluna :
Added file: http://bugs.python.org/file26301/issue13248_obsolescence_v3.diff
___
Python tracker
<http://bugs.python.org/issue13248>
___
___
Florent Xicluna added the comment:
It looks as a duplicate of issue 13557.
I close this one, because a doc patch is attached on the other.
--
resolution: -> duplicate
status: open -> closed
superseder: -> exec of list comprehension fails on
Changes by Florent Xicluna :
--
nosy: +Trundle, anikom15, daniel.urban, flox, jonathan.hartley, josmiley,
michael.foord, mjs0, rhettinger
___
Python tracker
<http://bugs.python.org/issue13
Florent Xicluna added the comment:
Issue #11796 marked as duplicate of this one.
However the issue described in #11796 does not involve exec/execfile.
It is about scopes for list comprehension like this one.
Another doc patch should probably be written to cover the case described in
#11796
Florent Xicluna added the comment:
I cannot reproduce with 3.3 on Snow Leopard (default options, default compiler).
$ ./python.exe -m test.regrtest test_unittest
[1/1] test_unittest
1 test OK.
[158600 refs]
== CPython 3.3.0b1 (tip:9807de61191c, Jul 7 2012, 10:54:30) [GCC 4.2.1 (Apple
Inc
Florent Xicluna added the comment:
Few warnings when building trunk (on 10.6):
./Modules/_ctypes/libffi_osx/x86/x86-ffi64.c:49: warning: function declaration
isn’t a prototype
./Modules/_ctypes/libffi_osx/x86/x86-ffi64.c:379: warning: function declaration
isn’t a prototype
--
nosy
Florent Xicluna added the comment:
Eric, I will check but I thought they were not documented.
--
___
Python tracker
<http://bugs.python.org/issue13248>
___
___
New submission from Florent Xicluna :
I have this repeatable failure on OSX.
$ time ./python.exe -m test.regrtest -uall -W test_timeout
[1/1] test_timeout
testBlockingThenTimeout (test.test_timeout.CreationTestCase) ... ok
testFloatReturnValue (test.test_timeout.CreationTestCase) ... ok
Changes by Florent Xicluna :
--
assignee: -> ronaldoussoren
components: +Macintosh
nosy: +ronaldoussoren
___
Python tracker
<http://bugs.python.org/issu
New submission from Florent Xicluna :
There's a warning running test_builtin
$ ./python.exe -m test.regrtest -u all -v test_builtin
== CPython 3.3.0b1 (default:5b71f5891c54, Jul 7 2012, 17:47:30) [GCC 4.2.1
(Apple Inc. build 5666) (dot 3)]
== Darwin-10.8.0-i386-64bit little-e
Florent Xicluna added the comment:
happened on 10.6, 64 bits, with a fresh build.
== CPython 3.3.0b1 (default:5b71f5891c54, Jul 7 2012, 17:47:30) [GCC 4.2.1
(Apple Inc. build 5666) (dot 3)]
== Darwin-10.8.0-i386-64bit little-endian
--
___
Python
801 - 900 of 1386 matches
Mail list logo
