Eli Bendersky added the comment:
Attaching an updated patch for Doc/library/trace.rst in 3.2
Changed the formatting of command-line options per Éric's suggestion of using
program/cmdoption/option combos (great idea Éric - it looks much better).
--
Added file: http://bugs.pytho
Eli Bendersky added the comment:
Attaching an updated patch following Éric's suggestions:
* ``dir/package/module.cover`` -- FIXED
* '``>>>>>>``' looks wrong -- FIXED to just ``>>>>>>``
* ``os.pathsep`` -- FIXED
* method:: CoverageResults
Changes by Eli Bendersky :
--
Removed message: http://bugs.python.org/msg122522
___
Python tracker
<http://bugs.python.org/issue10516>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
Thanks for the report,
Attaching a patch for Doc/c-api/list.rst in Python 3.2
If this is OK, I can backport the patch to other versions as well.
--
keywords: +patch
nosy: +eli.bendersky
Added file: http://bugs.python.org/file19889/issue10594.py32.1
Eli Bendersky added the comment:
I fuzzily recall there was somewhere a decision to use the American spelling of
some words, like s/behaviour/behavior/ appearing in this patch. Is this right,
or was it decided that it doesn't matter?
--
nosy: +eli.bendersky
status: pending -&
Eli Bendersky added the comment:
Éric, also re your previous message, I personally would prefer seeing "contrary
to what one can think" removed altogether. IMHO it's too chatty for an official
document and doesn't really add new information over the
Eli Bendersky added the comment:
Terry,
Attaching a patch with the following:
1. Added unittest assertions for bjunk and bpopular data attributes.
2. Minor markup & formatting fixes in one paragraph of the doc difflib.rst
--
Added file: http://bugs.python.org/file19932/issue105
Eli Bendersky added the comment:
Alexander,
I reviewed the patch and ported the changes to the newest sources (since the
fix to issue 9299, os.makedirs can be naturally used with its new flag to fix
the bug Zooko refers to).
However, while experimenting, I think I ran into much larger
Changes by Eli Bendersky :
Added file: http://bugs.python.org/file19934/traced_module.py
___
Python tracker
<http://bugs.python.org/issue766910>
___
___
Python-bugs-list m
Eli Bendersky added the comment:
Was list.copy() also approved? After all, there are many ways to achieve the
same even now:
1. L[:]
2. list(L)
3. import copy and then copy.copy
Especially re the last one: list.copy() can be deep or shallow, which one
should it be
Eli Bendersky added the comment:
Also, where is the *official* place to document list objects and their methods?
--
___
Python tracker
<http://bugs.python.org/issue10
Eli Bendersky added the comment:
Attaching a patch with the following:
1. list.copy() and list.clear() implemented in Objects/listobject.c, with
appropriate doc strings (modeled after dict's docstrings)
2. Same methods implemented in collections.UserList
3. Tests added that exercis
Eli Bendersky added the comment:
Following Éric's suggestion, I'm attaching an updated patch with with the
documentation in Doc/library/stdtypes.rst updated with the new methods.
There seems to be a slight Sphinx markup problem with this addition. I rewrote
note (8) as:
:m
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file19835/issue10516.1.patch
___
Python tracker
<http://bugs.python.org/issue10516>
___
___
Python-bug
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file19938/issue10516.2.patch
___
Python tracker
<http://bugs.python.org/issue10516>
___
___
Python-bug
Eli Bendersky added the comment:
Éric - thanks, it works [attaching updated patch]. However, don't you think the
core problem is a Sphinx bug we should report?
Raymond - this happens after final 3.2 release (on Feb 05 2011 if it's on
schedule), right?
--
Added
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file19943/issue10516.3.patch
___
Python tracker
<http://bugs.python.org/issue10516>
___
___
Python-bug
Eli Bendersky added the comment:
Boštjan,
"a shallow copy": I took this directly from the documentation of dicts, which
says:
"D.copy() -> a shallow copy of D")
As I mentioned in an earlier message, the doc-strings of list and dict methods
are inconsistent in mo
New submission from Eli Bendersky :
The documentation of:
distutils.archive_util.make_zipfile(base_name, base_dir[, verbose=0,
dry_run=0])
Says:
Create a zip file from all files in and under base_dir. The output zip file
will be named base_dir + .zip.
This isn't correct, as the na
Eli Bendersky added the comment:
Attaching a fix for Doc/distutils/apiref.rst and Lib/distutils/archive_util.py
in Python 3.2
If it's OK I will backport to other versions as well.
--
keywords: +patch
Added file: http://bugs.python.org/file20055/issue10693.py32.1.
Eli Bendersky added the comment:
Updated patch with "versionadded" tag for the new methods
--
Added file: http://bugs.python.org/file20056/issue10516.5.patch
___
Python tracker
<http://bugs.python.o
Eli Bendersky added the comment:
Guys, this issue is pending for a long time. Anything else needed before a
commit is done?
--
status: pending -> open
___
Python tracker
<http://bugs.python.org/iss
Changes by Eli Bendersky :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue9264>
___
___
Python-bugs-list mailing list
Unsubscri
Eli Bendersky added the comment:
Éric,
The nested methods are nice, though a bit unusual IMHO. Is this the recommended
new way to markup methods of objects? [Because AFAIK it's not used much in
other docs]
--
status: open -> pending
__
Eli Bendersky added the comment:
I'll try to produce a test in the next hour or two
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/is
Eli Bendersky added the comment:
I'm attaching a patch with a test for Martin's fix. I had trouble
programmatically generating a "bad" zip for this bug, since it has different
encodings for the header and filename (probably created by WinZip?). So I
created a directory
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file20210/issue10801_test.1.patch
___
Python tracker
<http://bugs.python.org/issue10801>
___
___
Python-bug
Changes by Eli Bendersky :
Added file: http://bugs.python.org/file20211/issue10801_test.1.patch
___
Python tracker
<http://bugs.python.org/issue10801>
___
___
Python-bug
Eli Bendersky added the comment:
Georg, did you figure out the root cause of the problem on that buildbot?
Seeing it fails in open(targetpath, "wb"), extracting the file may have failed
if the bot had no write permissions to the current directory, but the ascii
encoding error is no
Eli Bendersky added the comment:
This code is in Modules/main.c, function Py_Main.
In 2.7, only _Py_ReleaseInternedStrings is called, and this function is defined
in Objects/stringobject.c
In 3k, the two functions are called as specified above.
_Py_ReleaseInternedStrings doesn't exi
Eli Bendersky added the comment:
Attaching a patch that removes the call of the non-existing function in py3k. I
ran the test suite and make patchcheck.
I don't remove the whole __INSURE__ since someone might still want it in (and I
don't have the tool to play around with it). Bu
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
stage: -> needs patch
type: performance -> behavior
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
Alexander, I get the same error for the he_IL locale. Will look into this
--
___
Python tracker
<http://bugs.python.org/issue8
Eli Bendersky added the comment:
Here's a patch that fixes it to "run*".
If it's OK I will commit it and port to py3k where the problem also exists
--
keywords: +patch
nosy: +ncoghlan
Added file: http://bugs.python.org/file20401/iss
Eli Bendersky added the comment:
Committed r87991
--
___
Python tracker
<http://bugs.python.org/issue9844>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Committed to release27-maint r87992
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issue10902>
___
___
Py
Eli Bendersky added the comment:
Committed to py3k r87993
--
___
Python tracker
<http://bugs.python.org/issue10902>
___
___
Python-bugs-list mailing list
Unsub
Eli Bendersky added the comment:
Georg, thanks - will keep that in mind. Here I started with 2.7 since this is
what the user reported on. I plan to have it committed to all 3 branches today
anyhow.
--
___
Python tracker
<http://bugs.python.
Eli Bendersky added the comment:
Backported to release31: r87994 (with svnmerge)
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Eli Bendersky added the comment:
Committed to release31 in r87995 (with svnmerge)
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
The problem for Hebrew appears to be the same as the one Victor stated for
French. March in Hebrew is also a 3-letter word which means it's equal to its
abbreviation.
--
___
Python tracker
<http://bugs.py
Eli Bendersky added the comment:
I'm attaching a patch for Lib/_strptime.py that handles the month differently
in __calc_date_time. It cycles all months, trying to find one where the full
and abbrev names are different and matches it against the timestamp created by
strftime.
This sol
Eli Bendersky added the comment:
I agree that the difference in behavior between the two functions is
unfortunate, but that's unlikely to change now.
The least we can do is make the documentation precise. I'm attaching a proposed
patch to Doc/c-api/object.rst
Nick/Terry/Georg
Eli Bendersky added the comment:
Committed the fix to py3k in r88009
--
___
Python tracker
<http://bugs.python.org/issue10912>
___
___
Python-bugs-list mailin
Eli Bendersky added the comment:
Backport to release31 branch in r88010
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
Nick, I read the protocol of issue 4296 and I understand the reasoning behind
the code, but I still think the naming is mightily confusing. Two distinct
changes went into a single function (A) Return -1/0/+1 instead of PyObject and
(B) the id() shortcut, and
Eli Bendersky added the comment:
Alexander,
1) Patch comments - thanks for those. Will have them fixed.
2) General strategy for implementing strptime. I must confess I don't fully
understand the reason for doing what the _strptime module does. Standard C
AFAIK has nothing of the sort
Eli Bendersky added the comment:
Alexander, but still - this isn't just an implementation of strptime. strptime,
AFAIU strptime gets the format string as a parameter and uses it to parse a
date string into a "tm" struct. So why do we need to parse a date string
*without* a f
Eli Bendersky added the comment:
Raymond,
I initially set "easy" on this issue because I considered it a documentation
issue, not the place to resolve the harder debate of the semantics of these
functions. Perhaps I was wrong?
Also, I agree with Nick that the difference must
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue3849>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue11015>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
I don't know if it matters much, but there's a slight mismatch in the
description of test.support.verbose. The documentation says it's a boolean,
while it's 0 or 1 in reality.
Can it just be changed to True/False in the code
Eli Bendersky added the comment:
Here's a patch fixing the 0/1 to True/False in a couple of places in
test.support and test.regrtest
I ran the test suite and it passes.
A review is needed to commit. I'll keep working on the documentation itself in
the meantime.
--
keywor
Eli Bendersky added the comment:
Here's a patch to Doc/library/test.rst with additional several exported
functions documented. These are the ones I found most important and clear.
fcmp() is currently not documented (pending discussion in pydev).
--
stage: needs patch -> patc
New submission from Eli Bendersky :
On a clean checkout of py3k, I try to open PCBuild/pcbuild.sln with my MSVC++
Express 2008. When opening, a message box pops saying:
Solution folders are not supported in this version of the application.
Solution folder "Solution Items" will be
Eli Bendersky added the comment:
I tried running make_buildinfo.exe manually from a VC command prompt, and I get
an error for invoking subwcrev.exe:
D:\eli\python-py3k-trunk\PCbuild>make_buildinfo.exe Debug Win32-temp-Debug
"C:\Program Files\TortoiseSVN\bin\subwcrev.exe"
Eli Bendersky added the comment:
After some investigation of running make_buildinfo standalone, it boils down to
this:
When it executes the path with quotes around the last argument:
"C:\Program Files\TortoiseSVN\bin\subwcrev.exe" .. ..\Modules\getbuildinfo.c
"Win32-temp-Debu
Eli Bendersky added the comment:
Amaury, seems like it - thanks. So I suppose the fix would be just to remove
the quotes in make_buildinfo.c
I wonder why it worked for others & buildbots?
--
___
Python tracker
<http://bugs.python.org/iss
Changes by Eli Bendersky :
--
priority: normal -> high
___
Python tracker
<http://bugs.python.org/issue11034>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Eli Bendersky :
--
nosy: +krisvale
___
Python tracker
<http://bugs.python.org/issue11034>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
Please see issue 11034
--
nosy: +eli.bendersky
status: closed -> open
___
Python tracker
<http://bugs.python.org/issu
Eli Bendersky added the comment:
Martin,
This makes sense, but keep in mind that:
1) Many, if indeed not *most* Windows SVN users use TortoiseSVN (and our dev
guide recommends it, IIRC)
2) When TortoiseSVN *is* installed, it almost always goes into "Program Files"
(its default in
Eli Bendersky added the comment:
Martin, the patch fixed the problem for me and the code looks good.
--
___
Python tracker
<http://bugs.python.org/issue11
Eli Bendersky added the comment:
Nick, agreed regarding verbose. Somehow I didn't think it would be used in
other modules like that, and only looked in regrtest where I didn't see
anything meaningful about verbose not being binary.
It's a good thing to do
Changes by Eli Bendersky :
Removed file: http://bugs.python.org/file20564/issue11015.py3k.1.patch
___
Python tracker
<http://bugs.python.org/issue11015>
___
___
Python-bug
Eli Bendersky added the comment:
Giampaolo, FYI I'm also working (issue 11015) in parallel on documenting some
of the undocumented functions in Doc/library/test.rst that look useful to me. I
think we can collaborate here to make sure they're both documented and tested.
I'll re
Changes by Eli Bendersky :
--
nosy: +ncoghlan
___
Python tracker
<http://bugs.python.org/issue11049>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eli Bendersky :
--
stage: needs patch -> patch review
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue11049>
___
___
Pyth
Eli Bendersky added the comment:
Giampaolo,
The patch looks good. Some minor comments below:
* class TestCase(unittest.TestCase): -> why not give the test class a more
useful name?
* import_fresh_module is tested similarly to import_module - can't a test be
added that it indeed perf
Eli Bendersky added the comment:
Raymond, as I said in the email sorry I wasn't aware of the issue, and Georg
permitted me to commit directly to the file once the freeze is over. Maybe
there was a misunderstanding.
Also, can you refer me to the part of the file you mean? I see it
Eli Bendersky added the comment:
r88274 - python/branches/py3k/Doc/whatsnew/3.2.rst
"Revert r88272 -- the examples are more readable with spacing."
Raymond - then perhaps we should consider revising PEP 8 as well. When I first
read it, the "no spaces around =" rule for k
Eli Bendersky added the comment:
Éric - your suggestions look good to me.
The correspondence with Terry was on July 16th, 2010 - maybe he can remember
which thread in pydev it was exactly.
--
___
Python tracker
<http://bugs.python.org/issue9
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue11173>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
IMHO this wording proposed by Stefan:
"""
[[Note: The xml.dom.minidom module provides an implementation of the W3C-DOM
whose API is similar to that in other programming languages. Users who are
unfamiliar with the W3C-DOM interface or who woul
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13782>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eli Bendersky added the comment:
At this point, 3.1 won't be fixed with such changes any longer.
Is this fixed in 3.2/3.3?
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
"file_paths(filtered_walk('.', included_files=['*.py']))" is a lot longer than
"rglob('*.py')".
It is, but is that a good enough reason to have both? It can also be achieved
with just a bit more code using t
Eli Bendersky added the comment:
>> It is. globbing is a well-known operation that many people expect to be
>> easily done.
According to Wikipedia (http://en.wikipedia.org/wiki/Glob_%28programming%29) -
"The noun "glob" is used to refer to a particular pattern, e
Eli Bendersky added the comment:
>> IOW, globbing is usually understood as the act of expanding a pattern
>> to the files it matches. Nothing in that implies recursive traversal
>> of a directory tree.
>
> Still, that's a common need. "I want all Python file
Eli Bendersky added the comment:
>> Google "walk directory". First hit is a Rosetta code page with
>> *recursive* walking implemented in various languages. So I guess it
>> does have this connotation. Regardless, os.walk has been in Python for
>> ages, and i
Eli Bendersky added the comment:
Oops, Éric, sorry about the title. I didn't even notice :)
--
___
Python tracker
<http://bugs.python.org/issue13968>
___
___
Eli Bendersky added the comment:
Martin, do you find the wording I quoted (*without* the reference to a more
Pythonic API) acceptable?
--
___
Python tracker
<http://bugs.python.org/issue11
Eli Bendersky added the comment:
>> Well, if glob() already lived in shutil, this decision would be a
no-brainer :) Having glob() in the glob module and globtree() in the
shutil module, though, looks a bit weird.
(I agree having a separate module for glob isn't ideal)
Would it be
Eli Bendersky added the comment:
Eric,
Thanks for checking. I agree that this behavior is acceptable, but a
documentation fix would be appropriate. The documentation of iterparse should
mention the events it accepts, also saying that those are strings.
The events are listed at http
Eli Bendersky added the comment:
Changing the target version(s) and adding some documentation experts to the
nosy list
--
nosy: +eric.araujo, ezio.melotti, sandro.tosi
versions: +Python 3.2, Python 3.3 -Python 3.1
___
Python tracker
<h
Eli Bendersky added the comment:
ISTM that part of the doc specifically deals with Unix, so this issue can be
closed as completed.
Windows is a different issue. Perhaps the documentation should have a new
section on embedding on Windows, similarly to the "Building C and C++
Extensio
Eli Bendersky added the comment:
Sandro, can you commit, taking Antoine's note into account?
--
___
Python tracker
<http://bugs.python.org/issue11836>
___
___
Eli Bendersky added the comment:
> I have to say that the non-obvious subtleties you point out in your rglob
> make me think I personally would probably opt to use Nick's module directly
> instead, so that I was sure what I was getting.
>
Eli Bendersky added the comment:
>> It looks more useful to me to have a consistent behavior between C and
>> Python version.
I agree, especially is we now consider to expose the C API by default, leaving
the Python API a
Eli Bendersky added the comment:
Terry, I agree with 3. The "regression" here is insignificant enough in my view
to warrant mucking with already released versions.
--
___
Python tracker
<http://bugs.python.o
Changes by Eli Bendersky :
--
nosy: +eli.bendersky
___
Python tracker
<http://bugs.python.org/issue13987>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eli Bendersky :
Following the discussion on python-dev [1], this issue will track the
re-organization of Lib/xml/etree to expose the C implementation (_elementtree)
by default when importing ElementTree. The test suite will also have to be
updated - it's required th
Eli Bendersky added the comment:
Oh, and not to forget: the documentation has to be updated to just not mention
cElementTree any longer. For the user, the fact that a fast C library is
invoked underneath should be invisible.
--
___
Python tracker
Eli Bendersky added the comment:
Hmm, that may be PEP 399:
If an acceleration module is provided it is to be named the same as the
module it is accelerating with an underscore attached as a prefix, e.g.,
_warnings for warnings. The common pattern to access the accelerated code from
the
Eli Bendersky added the comment:
>> IIRC, there is a well specified way how accelerator modules should be used
by Python modules. I recall a lengthy discussion on python-dev (or the py3k
list?) back in the old pre-3.0 days, maybe there's even a PEP?
If there's a convention, I
Eli Bendersky added the comment:
> If possible I would avoid pyElementTree,
I suppose it's possible, but I'm genuinely interested in a technical reason for
doing so. The approach suggested in PEP 399 is useful for module in which part
of the functionality is implemented i
Eli Bendersky added the comment:
>> From a performance point of view, consider the (by far) common case
>> - where _elementtree *is* successfully imported.
>> ... for each invocation, the whole import of the Python code has
>> to be done, just to reach the overri
Eli Bendersky added the comment:
Oops, in last message:
s/there will be circular dependencies/there will not be circular dependencies/
--
stage: needs patch ->
type: performance ->
___
Python tracker
<http://bugs.python.org/i
Eli Bendersky added the comment:
> What I had in mind is more like:
> - ElementTree: defines the python code and if _elementtree is available
> overrides part of it with the functions imported from it;
The problem with this is the bootstrap Python code executed by
_elementtree. Th
Eli Bendersky added the comment:
Ezio,
>> We are assuming that _elementtree might be missing, but what are the cases
>> where this might actually happen? Other implementations like PyPy? Exotic
>> platforms that can't compile _elementtree?
I guess both. To make
301 - 400 of 1229 matches
Mail list logo