Eli Bendersky <eli...@gmail.com> added the comment: Giampaolo,
The patch looks good. Some minor comments below: * class TestCase(unittest.TestCase): -> why not give the test class a more useful name? * import_fresh_module is tested similarly to import_module - can't a test be added that it indeed performs its "special sauce"? * test_DirsOnSysPath: you may want to use assertIn and assertNotIn here. [these were added to Python in 3.1] * test_python_is_optimized: you may want to use assertIsInstance here. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue11049> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
