Re: Pqiv Image Viewer

2013-12-11 Thread Antoine Jacoutot
> I'd kind-of prefer for them to be visibly out of sync ("port doesn't > build") as at least then there's a chance the WANTLIB will be regenerated ;) I personally never put the whole dep chain into LIB_DEPENDS -- the reason is that I work on the whole tree regularly and it is way easier if you do

Re: Pqiv Image Viewer

2013-12-11 Thread Stuart Henderson
On 2013/12/11 15:12, Jérémie Courrèges-Anglas wrote: > Landry Breuil writes: > > [...] > > > No need to LIB_DEPENDS on cairo/glib2, gtk+3 already does, > > Is "No need to" to be interpreted here as "should not", ie. a general > porting recommendation? > > Upstream explicitely uses this: > `p

Re: Pqiv Image Viewer

2013-12-11 Thread Landry Breuil
On Wed, Dec 11, 2013 at 03:22:20PM +0100, Landry Breuil wrote: > On Wed, Dec 11, 2013 at 03:12:58PM +0100, Jérémie Courrèges-Anglas wrote: > > Landry Breuil writes: > > > > [...] > > > > > No need to LIB_DEPENDS on cairo/glib2, gtk+3 already does, > > > > Is "No need to" to be interpreted here

Re: Pqiv Image Viewer

2013-12-11 Thread Landry Breuil
On Wed, Dec 11, 2013 at 03:12:58PM +0100, Jérémie Courrèges-Anglas wrote: > Landry Breuil writes: > > [...] > > > No need to LIB_DEPENDS on cairo/glib2, gtk+3 already does, > > Is "No need to" to be interpreted here as "should not", ie. a general > porting recommendation? > > Upstream explicit

Re: Pqiv Image Viewer

2013-12-11 Thread Jérémie Courrèges-Anglas
Landry Breuil writes: [...] > No need to LIB_DEPENDS on cairo/glib2, gtk+3 already does, Is "No need to" to be interpreted here as "should not", ie. a general porting recommendation? Upstream explicitely uses this: `pkg-config --libs gtk+-3.0 glib-2.0 cairo gio-2.0` If for whatever reason o

Re: Pqiv Image Viewer

2013-12-11 Thread Landry Breuil
On Wed, Dec 11, 2013 at 02:34:22PM +0100, Jérémie Courrèges-Anglas wrote: > Claudio writes: > > > Is there a chance of getting this into ports if it's fine? > > There was a bit of cleanup to do before thinking about that. > Here's another tarball, which fixes: > - ordering of variables (see Make

Re: Pqiv Image Viewer

2013-12-11 Thread Jérémie Courrèges-Anglas
Claudio writes: > Is there a chance of getting this into ports if it's fine? There was a bit of cleanup to do before thinking about that. Here's another tarball, which fixes: - ordering of variables (see Makefile.template) - void CFLAGS and LDFLAGS; they were not passed to the build, same for

Re: Pqiv Image Viewer

2013-12-10 Thread Claudio
Is there a chance of getting this into ports if it's fine? Claudio > Claudio writes: On Sun, Dec 08, 2013 at 03:07:33PM +0100, Jérémie Courrèges-Anglas wrote: > Claudio writes: > > > I opened that issue, the problem is 2.1 hasn't been release yet so it'd > > be straight from git, would a do-in

Re: Pqiv Image Viewer

2013-12-08 Thread Claudio
Forgot to remove the MANDIR , it's commented out. Claudio On Sun, Dec 08, 2013 at 03:07:33PM +0100, Jérémie Courrèges-Anglas wrote: > Claudio writes: > > > I opened that issue, the problem is 2.1 hasn't been release yet so it'd > > be straight from git, would a do-install (as suggested by Stuart

Re: Pqiv Image Viewer

2013-12-08 Thread Claudio
Is this better? Claudio On Sun, Dec 08, 2013 at 03:07:33PM +0100, Jérémie Courrèges-Anglas wrote: > Claudio writes: > > > I opened that issue, the problem is 2.1 hasn't been release yet so it'd > > be straight from git, would a do-install (as suggested by Stuart > > Henderson) be better then ?

Re: Pqiv Image Viewer

2013-12-08 Thread Jérémie Courrèges-Anglas
Claudio writes: > I opened that issue, the problem is 2.1 hasn't been release yet so it'd > be straight from git, would a do-install (as suggested by Stuart > Henderson) be better then ? Sure. > Could you point me to a do-install example ? do-install: ls -l ${WRKSRC} ${PREFIX} [...]

Re: Pqiv Image Viewer

2013-12-08 Thread Claudio
I opened that issue, the problem is 2.1 hasn't been release yet so it'd be straight from git, would a do-install (as suggested by Stuart Henderson) be better then ? Could you point me to a do-install example ? Thank you Claudio On Sun, Dec 08, 2013 at 02:31:01PM +0100, Jérémie Courrèges-Angl

Re: Pqiv Image Viewer

2013-12-08 Thread Jérémie Courrèges-Anglas
Stuart Henderson writes: > On 2013/12/08 14:09, Claudio wrote: >> It's my first port, pqiv is a minimalist image viewer inspired by qiv. >> >> Claudio > > > Not tried building it yet, but a few comments from reading: > >> COMMENT=very small and pretty fast gdk/Imlib image viewer

Re: Pqiv Image Viewer

2013-12-08 Thread Stuart Henderson
On 2013/12/08 14:09, Claudio wrote: > It's my first port, pqiv is a minimalist image viewer inspired by qiv. > > Claudio Not tried building it yet, but a few comments from reading: > COMMENT=very small and pretty fast gdk/Imlib image viewer > COMMENT=command lin